Coverage Report

Created: 2025-07-18 06:33

/src/httpd/server/apreq_parser_urlencoded.c
Line
Count
Source (jump to first uncovered line)
1
/*
2
**  Licensed to the Apache Software Foundation (ASF) under one or more
3
** contributor license agreements.  See the NOTICE file distributed with
4
** this work for additional information regarding copyright ownership.
5
** The ASF licenses this file to You under the Apache License, Version 2.0
6
** (the "License"); you may not use this file except in compliance with
7
** the License.  You may obtain a copy of the License at
8
**
9
**      http://www.apache.org/licenses/LICENSE-2.0
10
**
11
**  Unless required by applicable law or agreed to in writing, software
12
**  distributed under the License is distributed on an "AS IS" BASIS,
13
**  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14
**  See the License for the specific language governing permissions and
15
**  limitations under the License.
16
*/
17
18
#include "apreq_parser.h"
19
#include "apreq_util.h"
20
#include "apreq_error.h"
21
22
23
148
#define PARSER_STATUS_CHECK(PREFIX)   do {         \
24
148
    if (ctx->status == PREFIX##_ERROR)             \
25
148
        return APREQ_ERROR_GENERAL;                \
26
148
    else if (ctx->status == PREFIX##_COMPLETE)     \
27
148
        return APR_SUCCESS;                        \
28
148
    else if (bb == NULL)                           \
29
148
        return APR_INCOMPLETE;                     \
30
148
} while (0);
31
32
33
34
struct url_ctx {
35
    apr_bucket_brigade *bb;
36
    apr_size_t          nlen;
37
    apr_size_t          vlen;
38
    enum {
39
        URL_NAME,
40
        URL_VALUE,
41
        URL_COMPLETE,
42
        URL_ERROR
43
    }                   status;
44
};
45
46
47
/******************** application/x-www-form-urlencoded ********************/
48
49
static apr_status_t split_urlword(apreq_param_t **p, apr_pool_t *pool,
50
                                  apr_bucket_brigade *bb,
51
                                  apr_size_t nlen,
52
                                  apr_size_t vlen)
53
538
{
54
538
    apreq_param_t *param;
55
538
    apreq_value_t *v;
56
538
    apr_bucket *e, *f;
57
538
    apr_status_t s;
58
538
    struct iovec vec[APREQ_DEFAULT_NELTS];
59
538
    apr_array_header_t arr;
60
538
    apr_size_t mark;
61
538
    apreq_charset_t charset;
62
63
538
    if (nlen == 0)
64
1
        return APR_EBADARG;
65
66
537
    param = apreq_param_make(pool, NULL, nlen, NULL, vlen);
67
537
    if (param == NULL)
68
0
        return APR_ENOMEM;
69
537
    *(const apreq_value_t **)&v = &param->v;
70
71
537
    arr.pool     = pool;
72
537
    arr.elt_size = sizeof(struct iovec);
73
537
    arr.nelts    = 0;
74
537
    arr.nalloc   = APREQ_DEFAULT_NELTS;
75
537
    arr.elts     = (char *)vec;
76
77
537
    ++nlen, ++vlen;
78
537
    e = APR_BRIGADE_FIRST(bb);
79
80
537
    while (!APR_BUCKET_IS_EOS(e)) {
81
537
        struct iovec *iov = apr_array_push(&arr);
82
537
        apr_size_t len;
83
537
        s = apr_bucket_read(e, (const char **)&iov->iov_base,
84
537
                            &len, APR_BLOCK_READ);
85
537
        if (s != APR_SUCCESS)
86
0
            return s;
87
88
537
        iov->iov_len = len;
89
537
        nlen -= len;
90
91
537
        e = APR_BUCKET_NEXT(e);
92
93
537
        if (nlen == 0) {
94
537
            iov->iov_len--;
95
537
            break;
96
537
        }
97
537
    }
98
99
537
    mark = arr.nelts;
100
101
537
    while (!APR_BUCKET_IS_EOS(e)) {
102
537
        struct iovec *iov = apr_array_push(&arr);
103
537
        apr_size_t len;
104
537
        s = apr_bucket_read(e, (const char **)&iov->iov_base,
105
537
                            &len, APR_BLOCK_READ);
106
537
        if (s != APR_SUCCESS)
107
0
            return s;
108
109
537
        iov->iov_len = len;
110
537
        vlen -= len;
111
112
537
        e = APR_BUCKET_NEXT(e);
113
114
537
        if (vlen == 0) {
115
537
            iov->iov_len--;
116
537
            break;
117
537
        }
118
119
537
    }
120
121
537
    s = apreq_decodev(v->data, &vlen,
122
537
                      (struct iovec *)arr.elts + mark, arr.nelts - mark);
123
537
    if (s != APR_SUCCESS)
124
25
        return s;
125
126
512
    charset = apreq_charset_divine(v->data, vlen);
127
128
512
    v->name = v->data + vlen + 1;
129
512
    v->dlen = vlen;
130
131
512
    s = apreq_decodev(v->name, &nlen, (struct iovec *)arr.elts, mark);
132
512
    if (s != APR_SUCCESS)
133
38
        return s;
134
135
474
    switch (apreq_charset_divine(v->name, nlen)) {
136
74
    case APREQ_CHARSET_UTF8:
137
74
        if (charset == APREQ_CHARSET_ASCII)
138
47
            charset = APREQ_CHARSET_UTF8;
139
224
    case APREQ_CHARSET_ASCII:
140
224
        break;
141
142
173
    case APREQ_CHARSET_LATIN1:
143
173
        if (charset != APREQ_CHARSET_CP1252)
144
144
            charset = APREQ_CHARSET_LATIN1;
145
173
        break;
146
77
    case APREQ_CHARSET_CP1252:
147
77
        charset = APREQ_CHARSET_CP1252;
148
474
    }
149
150
474
    v->nlen = nlen;
151
152
1.42k
    while ((f = APR_BRIGADE_FIRST(bb)) != e)
153
948
        apr_bucket_delete(f);
154
155
474
    apreq_param_tainted_on(param);
156
474
    apreq_param_charset_set(param, charset);
157
474
    *p = param;
158
474
    return APR_SUCCESS;
159
474
}
160
161
APREQ_DECLARE_PARSER(apreq_parse_urlencoded)
162
148
{
163
148
    apr_pool_t *pool = parser->pool;
164
148
    apr_bucket *e;
165
148
    struct url_ctx *ctx;
166
167
148
    if (parser->ctx == NULL) {
168
148
        ctx = apr_pcalloc(pool, sizeof *ctx);
169
148
        ctx->bb = apr_brigade_create(pool, parser->bucket_alloc);
170
148
        parser->ctx = ctx;
171
148
        ctx->status = URL_NAME;
172
148
    }
173
0
    else
174
0
        ctx = parser->ctx;
175
176
148
    PARSER_STATUS_CHECK(URL);
177
148
    e = APR_BRIGADE_LAST(ctx->bb);
178
148
    APR_BRIGADE_CONCAT(ctx->bb, bb);
179
180
622
 parse_url_brigade:
181
182
622
    for (e  = APR_BUCKET_NEXT(e);
183
706
         e != APR_BRIGADE_SENTINEL(ctx->bb);
184
622
         e  = APR_BUCKET_NEXT(e))
185
622
    {
186
622
        apreq_param_t *param;
187
622
        apr_size_t off = 0, dlen;
188
622
        const char *data;
189
622
        apr_status_t s;
190
191
622
        if (APR_BUCKET_IS_EOS(e)) {
192
0
            if (ctx->status == URL_NAME) {
193
0
                s = APR_SUCCESS;
194
0
            }
195
0
            else {
196
0
                s = split_urlword(&param, pool, ctx->bb, ctx->nlen, ctx->vlen);
197
0
                if (parser->hook != NULL && s == APR_SUCCESS)
198
0
                    s = apreq_hook_run(parser->hook, param, NULL);
199
200
0
                if (s == APR_SUCCESS) {
201
0
                    apreq_value_table_add(&param->v, t);
202
0
                    ctx->status = URL_COMPLETE;
203
0
                }
204
0
                else {
205
0
                    ctx->status = URL_ERROR;
206
0
                }
207
0
            }
208
209
0
            APR_BRIGADE_CONCAT(bb, ctx->bb);
210
0
            return s;
211
0
        }
212
213
622
        s = apr_bucket_read(e, &data, &dlen, APR_BLOCK_READ);
214
622
        if ( s != APR_SUCCESS ) {
215
0
            ctx->status = URL_ERROR;
216
0
            return s;
217
0
        }
218
219
1.18k
    parse_url_bucket:
220
221
1.18k
        switch (ctx->status) {
222
223
622
        case URL_NAME:
224
5.15k
            while (off < dlen) {
225
5.09k
                switch (data[off++]) {
226
561
                case '=':
227
561
                    apr_bucket_split(e, off);
228
561
                    dlen -= off;
229
561
                    data += off;
230
561
                    off = 0;
231
561
                    e = APR_BUCKET_NEXT(e);
232
561
                    ctx->status = URL_VALUE;
233
561
                    goto parse_url_bucket;
234
4.53k
                default:
235
4.53k
                    ++ctx->nlen;
236
5.09k
                }
237
5.09k
            }
238
61
            break;
239
240
561
        case URL_VALUE:
241
3.43k
            while (off < dlen) {
242
243
3.40k
                switch (data[off++]) {
244
146
                case '&':
245
538
                case ';':
246
538
                    apr_bucket_split(e, off);
247
538
                    s = split_urlword(&param, pool, ctx->bb,
248
538
                                      ctx->nlen, ctx->vlen);
249
538
                    if (parser->hook != NULL && s == APR_SUCCESS)
250
474
                        s = apreq_hook_run(parser->hook, param, NULL);
251
252
538
                    if (s != APR_SUCCESS) {
253
64
                        ctx->status = URL_ERROR;
254
64
                        return s;
255
64
                    }
256
257
474
                    apreq_value_table_add(&param->v, t);
258
474
                    ctx->status = URL_NAME;
259
474
                    ctx->nlen = 0;
260
474
                    ctx->vlen = 0;
261
474
                    e = APR_BRIGADE_SENTINEL(ctx->bb);
262
474
                    goto parse_url_brigade;
263
264
2.87k
                default:
265
2.87k
                    ++ctx->vlen;
266
3.40k
                }
267
3.40k
            }
268
23
            break;
269
23
        default:
270
0
            ; /* not reached */
271
1.18k
        }
272
1.18k
    }
273
84
    apreq_brigade_setaside(ctx->bb, pool);
274
84
    return APR_INCOMPLETE;
275
622
}
276
277