Coverage Report

Created: 2025-08-03 06:47

/src/httpd/server/apreq_parser_urlencoded.c
Line
Count
Source (jump to first uncovered line)
1
/*
2
**  Licensed to the Apache Software Foundation (ASF) under one or more
3
** contributor license agreements.  See the NOTICE file distributed with
4
** this work for additional information regarding copyright ownership.
5
** The ASF licenses this file to You under the Apache License, Version 2.0
6
** (the "License"); you may not use this file except in compliance with
7
** the License.  You may obtain a copy of the License at
8
**
9
**      http://www.apache.org/licenses/LICENSE-2.0
10
**
11
**  Unless required by applicable law or agreed to in writing, software
12
**  distributed under the License is distributed on an "AS IS" BASIS,
13
**  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14
**  See the License for the specific language governing permissions and
15
**  limitations under the License.
16
*/
17
18
#include "apreq_parser.h"
19
#include "apreq_util.h"
20
#include "apreq_error.h"
21
22
23
144
#define PARSER_STATUS_CHECK(PREFIX)   do {         \
24
144
    if (ctx->status == PREFIX##_ERROR)             \
25
144
        return APREQ_ERROR_GENERAL;                \
26
144
    else if (ctx->status == PREFIX##_COMPLETE)     \
27
144
        return APR_SUCCESS;                        \
28
144
    else if (bb == NULL)                           \
29
144
        return APR_INCOMPLETE;                     \
30
144
} while (0);
31
32
33
34
struct url_ctx {
35
    apr_bucket_brigade *bb;
36
    apr_size_t          nlen;
37
    apr_size_t          vlen;
38
    enum {
39
        URL_NAME,
40
        URL_VALUE,
41
        URL_COMPLETE,
42
        URL_ERROR
43
    }                   status;
44
};
45
46
47
/******************** application/x-www-form-urlencoded ********************/
48
49
static apr_status_t split_urlword(apreq_param_t **p, apr_pool_t *pool,
50
                                  apr_bucket_brigade *bb,
51
                                  apr_size_t nlen,
52
                                  apr_size_t vlen)
53
549
{
54
549
    apreq_param_t *param;
55
549
    apreq_value_t *v;
56
549
    apr_bucket *e, *f;
57
549
    apr_status_t s;
58
549
    struct iovec vec[APREQ_DEFAULT_NELTS];
59
549
    apr_array_header_t arr;
60
549
    apr_size_t mark;
61
549
    apreq_charset_t charset;
62
63
549
    if (nlen == 0)
64
2
        return APR_EBADARG;
65
66
547
    param = apreq_param_make(pool, NULL, nlen, NULL, vlen);
67
547
    if (param == NULL)
68
0
        return APR_ENOMEM;
69
547
    *(const apreq_value_t **)&v = &param->v;
70
71
547
    arr.pool     = pool;
72
547
    arr.elt_size = sizeof(struct iovec);
73
547
    arr.nelts    = 0;
74
547
    arr.nalloc   = APREQ_DEFAULT_NELTS;
75
547
    arr.elts     = (char *)vec;
76
77
547
    ++nlen, ++vlen;
78
547
    e = APR_BRIGADE_FIRST(bb);
79
80
547
    while (!APR_BUCKET_IS_EOS(e)) {
81
547
        struct iovec *iov = apr_array_push(&arr);
82
547
        apr_size_t len;
83
547
        s = apr_bucket_read(e, (const char **)&iov->iov_base,
84
547
                            &len, APR_BLOCK_READ);
85
547
        if (s != APR_SUCCESS)
86
0
            return s;
87
88
547
        iov->iov_len = len;
89
547
        nlen -= len;
90
91
547
        e = APR_BUCKET_NEXT(e);
92
93
547
        if (nlen == 0) {
94
547
            iov->iov_len--;
95
547
            break;
96
547
        }
97
547
    }
98
99
547
    mark = arr.nelts;
100
101
547
    while (!APR_BUCKET_IS_EOS(e)) {
102
547
        struct iovec *iov = apr_array_push(&arr);
103
547
        apr_size_t len;
104
547
        s = apr_bucket_read(e, (const char **)&iov->iov_base,
105
547
                            &len, APR_BLOCK_READ);
106
547
        if (s != APR_SUCCESS)
107
0
            return s;
108
109
547
        iov->iov_len = len;
110
547
        vlen -= len;
111
112
547
        e = APR_BUCKET_NEXT(e);
113
114
547
        if (vlen == 0) {
115
547
            iov->iov_len--;
116
547
            break;
117
547
        }
118
119
547
    }
120
121
547
    s = apreq_decodev(v->data, &vlen,
122
547
                      (struct iovec *)arr.elts + mark, arr.nelts - mark);
123
547
    if (s != APR_SUCCESS)
124
28
        return s;
125
126
519
    charset = apreq_charset_divine(v->data, vlen);
127
128
519
    v->name = v->data + vlen + 1;
129
519
    v->dlen = vlen;
130
131
519
    s = apreq_decodev(v->name, &nlen, (struct iovec *)arr.elts, mark);
132
519
    if (s != APR_SUCCESS)
133
32
        return s;
134
135
487
    switch (apreq_charset_divine(v->name, nlen)) {
136
64
    case APREQ_CHARSET_UTF8:
137
64
        if (charset == APREQ_CHARSET_ASCII)
138
37
            charset = APREQ_CHARSET_UTF8;
139
261
    case APREQ_CHARSET_ASCII:
140
261
        break;
141
142
157
    case APREQ_CHARSET_LATIN1:
143
157
        if (charset != APREQ_CHARSET_CP1252)
144
127
            charset = APREQ_CHARSET_LATIN1;
145
157
        break;
146
69
    case APREQ_CHARSET_CP1252:
147
69
        charset = APREQ_CHARSET_CP1252;
148
487
    }
149
150
487
    v->nlen = nlen;
151
152
1.46k
    while ((f = APR_BRIGADE_FIRST(bb)) != e)
153
974
        apr_bucket_delete(f);
154
155
487
    apreq_param_tainted_on(param);
156
487
    apreq_param_charset_set(param, charset);
157
487
    *p = param;
158
487
    return APR_SUCCESS;
159
487
}
160
161
APREQ_DECLARE_PARSER(apreq_parse_urlencoded)
162
144
{
163
144
    apr_pool_t *pool = parser->pool;
164
144
    apr_bucket *e;
165
144
    struct url_ctx *ctx;
166
167
144
    if (parser->ctx == NULL) {
168
144
        ctx = apr_pcalloc(pool, sizeof *ctx);
169
144
        ctx->bb = apr_brigade_create(pool, parser->bucket_alloc);
170
144
        parser->ctx = ctx;
171
144
        ctx->status = URL_NAME;
172
144
    }
173
0
    else
174
0
        ctx = parser->ctx;
175
176
144
    PARSER_STATUS_CHECK(URL);
177
144
    e = APR_BRIGADE_LAST(ctx->bb);
178
144
    APR_BRIGADE_CONCAT(ctx->bb, bb);
179
180
631
 parse_url_brigade:
181
182
631
    for (e  = APR_BUCKET_NEXT(e);
183
713
         e != APR_BRIGADE_SENTINEL(ctx->bb);
184
631
         e  = APR_BUCKET_NEXT(e))
185
631
    {
186
631
        apreq_param_t *param;
187
631
        apr_size_t off = 0, dlen;
188
631
        const char *data;
189
631
        apr_status_t s;
190
191
631
        if (APR_BUCKET_IS_EOS(e)) {
192
0
            if (ctx->status == URL_NAME) {
193
0
                s = APR_SUCCESS;
194
0
            }
195
0
            else {
196
0
                s = split_urlword(&param, pool, ctx->bb, ctx->nlen, ctx->vlen);
197
0
                if (parser->hook != NULL && s == APR_SUCCESS)
198
0
                    s = apreq_hook_run(parser->hook, param, NULL);
199
200
0
                if (s == APR_SUCCESS) {
201
0
                    apreq_value_table_add(&param->v, t);
202
0
                    ctx->status = URL_COMPLETE;
203
0
                }
204
0
                else {
205
0
                    ctx->status = URL_ERROR;
206
0
                }
207
0
            }
208
209
0
            APR_BRIGADE_CONCAT(bb, ctx->bb);
210
0
            return s;
211
0
        }
212
213
631
        s = apr_bucket_read(e, &data, &dlen, APR_BLOCK_READ);
214
631
        if ( s != APR_SUCCESS ) {
215
0
            ctx->status = URL_ERROR;
216
0
            return s;
217
0
        }
218
219
1.19k
    parse_url_bucket:
220
221
1.19k
        switch (ctx->status) {
222
223
631
        case URL_NAME:
224
5.45k
            while (off < dlen) {
225
5.38k
                switch (data[off++]) {
226
561
                case '=':
227
561
                    apr_bucket_split(e, off);
228
561
                    dlen -= off;
229
561
                    data += off;
230
561
                    off = 0;
231
561
                    e = APR_BUCKET_NEXT(e);
232
561
                    ctx->status = URL_VALUE;
233
561
                    goto parse_url_bucket;
234
4.82k
                default:
235
4.82k
                    ++ctx->nlen;
236
5.38k
                }
237
5.38k
            }
238
70
            break;
239
240
561
        case URL_VALUE:
241
3.11k
            while (off < dlen) {
242
243
3.10k
                switch (data[off++]) {
244
158
                case '&':
245
549
                case ';':
246
549
                    apr_bucket_split(e, off);
247
549
                    s = split_urlword(&param, pool, ctx->bb,
248
549
                                      ctx->nlen, ctx->vlen);
249
549
                    if (parser->hook != NULL && s == APR_SUCCESS)
250
487
                        s = apreq_hook_run(parser->hook, param, NULL);
251
252
549
                    if (s != APR_SUCCESS) {
253
62
                        ctx->status = URL_ERROR;
254
62
                        return s;
255
62
                    }
256
257
487
                    apreq_value_table_add(&param->v, t);
258
487
                    ctx->status = URL_NAME;
259
487
                    ctx->nlen = 0;
260
487
                    ctx->vlen = 0;
261
487
                    e = APR_BRIGADE_SENTINEL(ctx->bb);
262
487
                    goto parse_url_brigade;
263
264
2.55k
                default:
265
2.55k
                    ++ctx->vlen;
266
3.10k
                }
267
3.10k
            }
268
12
            break;
269
12
        default:
270
0
            ; /* not reached */
271
1.19k
        }
272
1.19k
    }
273
82
    apreq_brigade_setaside(ctx->bb, pool);
274
82
    return APR_INCOMPLETE;
275
631
}
276
277