Coverage Report

Created: 2025-08-26 06:24

/src/httpd/server/apreq_parser_urlencoded.c
Line
Count
Source (jump to first uncovered line)
1
/*
2
**  Licensed to the Apache Software Foundation (ASF) under one or more
3
** contributor license agreements.  See the NOTICE file distributed with
4
** this work for additional information regarding copyright ownership.
5
** The ASF licenses this file to You under the Apache License, Version 2.0
6
** (the "License"); you may not use this file except in compliance with
7
** the License.  You may obtain a copy of the License at
8
**
9
**      http://www.apache.org/licenses/LICENSE-2.0
10
**
11
**  Unless required by applicable law or agreed to in writing, software
12
**  distributed under the License is distributed on an "AS IS" BASIS,
13
**  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14
**  See the License for the specific language governing permissions and
15
**  limitations under the License.
16
*/
17
18
#include "apreq_parser.h"
19
#include "apreq_util.h"
20
#include "apreq_error.h"
21
22
23
153
#define PARSER_STATUS_CHECK(PREFIX)   do {         \
24
153
    if (ctx->status == PREFIX##_ERROR)             \
25
153
        return APREQ_ERROR_GENERAL;                \
26
153
    else if (ctx->status == PREFIX##_COMPLETE)     \
27
153
        return APR_SUCCESS;                        \
28
153
    else if (bb == NULL)                           \
29
153
        return APR_INCOMPLETE;                     \
30
153
} while (0);
31
32
33
34
struct url_ctx {
35
    apr_bucket_brigade *bb;
36
    apr_size_t          nlen;
37
    apr_size_t          vlen;
38
    enum {
39
        URL_NAME,
40
        URL_VALUE,
41
        URL_COMPLETE,
42
        URL_ERROR
43
    }                   status;
44
};
45
46
47
/******************** application/x-www-form-urlencoded ********************/
48
49
static apr_status_t split_urlword(apreq_param_t **p, apr_pool_t *pool,
50
                                  apr_bucket_brigade *bb,
51
                                  apr_size_t nlen,
52
                                  apr_size_t vlen)
53
627
{
54
627
    apreq_param_t *param;
55
627
    apreq_value_t *v;
56
627
    apr_bucket *e, *f;
57
627
    apr_status_t s;
58
627
    struct iovec vec[APREQ_DEFAULT_NELTS];
59
627
    apr_array_header_t arr;
60
627
    apr_size_t mark;
61
627
    apreq_charset_t charset;
62
63
627
    if (nlen == 0)
64
1
        return APR_EBADARG;
65
66
626
    param = apreq_param_make(pool, NULL, nlen, NULL, vlen);
67
626
    if (param == NULL)
68
0
        return APR_ENOMEM;
69
626
    *(const apreq_value_t **)&v = &param->v;
70
71
626
    arr.pool     = pool;
72
626
    arr.elt_size = sizeof(struct iovec);
73
626
    arr.nelts    = 0;
74
626
    arr.nalloc   = APREQ_DEFAULT_NELTS;
75
626
    arr.elts     = (char *)vec;
76
77
626
    ++nlen, ++vlen;
78
626
    e = APR_BRIGADE_FIRST(bb);
79
80
626
    while (!APR_BUCKET_IS_EOS(e)) {
81
626
        struct iovec *iov = apr_array_push(&arr);
82
626
        apr_size_t len;
83
626
        s = apr_bucket_read(e, (const char **)&iov->iov_base,
84
626
                            &len, APR_BLOCK_READ);
85
626
        if (s != APR_SUCCESS)
86
0
            return s;
87
88
626
        iov->iov_len = len;
89
626
        nlen -= len;
90
91
626
        e = APR_BUCKET_NEXT(e);
92
93
626
        if (nlen == 0) {
94
626
            iov->iov_len--;
95
626
            break;
96
626
        }
97
626
    }
98
99
626
    mark = arr.nelts;
100
101
626
    while (!APR_BUCKET_IS_EOS(e)) {
102
626
        struct iovec *iov = apr_array_push(&arr);
103
626
        apr_size_t len;
104
626
        s = apr_bucket_read(e, (const char **)&iov->iov_base,
105
626
                            &len, APR_BLOCK_READ);
106
626
        if (s != APR_SUCCESS)
107
0
            return s;
108
109
626
        iov->iov_len = len;
110
626
        vlen -= len;
111
112
626
        e = APR_BUCKET_NEXT(e);
113
114
626
        if (vlen == 0) {
115
626
            iov->iov_len--;
116
626
            break;
117
626
        }
118
119
626
    }
120
121
626
    s = apreq_decodev(v->data, &vlen,
122
626
                      (struct iovec *)arr.elts + mark, arr.nelts - mark);
123
626
    if (s != APR_SUCCESS)
124
19
        return s;
125
126
607
    charset = apreq_charset_divine(v->data, vlen);
127
128
607
    v->name = v->data + vlen + 1;
129
607
    v->dlen = vlen;
130
131
607
    s = apreq_decodev(v->name, &nlen, (struct iovec *)arr.elts, mark);
132
607
    if (s != APR_SUCCESS)
133
38
        return s;
134
135
569
    switch (apreq_charset_divine(v->name, nlen)) {
136
74
    case APREQ_CHARSET_UTF8:
137
74
        if (charset == APREQ_CHARSET_ASCII)
138
50
            charset = APREQ_CHARSET_UTF8;
139
296
    case APREQ_CHARSET_ASCII:
140
296
        break;
141
142
197
    case APREQ_CHARSET_LATIN1:
143
197
        if (charset != APREQ_CHARSET_CP1252)
144
160
            charset = APREQ_CHARSET_LATIN1;
145
197
        break;
146
76
    case APREQ_CHARSET_CP1252:
147
76
        charset = APREQ_CHARSET_CP1252;
148
569
    }
149
150
569
    v->nlen = nlen;
151
152
1.70k
    while ((f = APR_BRIGADE_FIRST(bb)) != e)
153
1.13k
        apr_bucket_delete(f);
154
155
569
    apreq_param_tainted_on(param);
156
569
    apreq_param_charset_set(param, charset);
157
569
    *p = param;
158
569
    return APR_SUCCESS;
159
569
}
160
161
APREQ_DECLARE_PARSER(apreq_parse_urlencoded)
162
153
{
163
153
    apr_pool_t *pool = parser->pool;
164
153
    apr_bucket *e;
165
153
    struct url_ctx *ctx;
166
167
153
    if (parser->ctx == NULL) {
168
153
        ctx = apr_pcalloc(pool, sizeof *ctx);
169
153
        ctx->bb = apr_brigade_create(pool, parser->bucket_alloc);
170
153
        parser->ctx = ctx;
171
153
        ctx->status = URL_NAME;
172
153
    }
173
0
    else
174
0
        ctx = parser->ctx;
175
176
153
    PARSER_STATUS_CHECK(URL);
177
153
    e = APR_BRIGADE_LAST(ctx->bb);
178
153
    APR_BRIGADE_CONCAT(ctx->bb, bb);
179
180
722
 parse_url_brigade:
181
182
722
    for (e  = APR_BUCKET_NEXT(e);
183
817
         e != APR_BRIGADE_SENTINEL(ctx->bb);
184
722
         e  = APR_BUCKET_NEXT(e))
185
722
    {
186
722
        apreq_param_t *param;
187
722
        apr_size_t off = 0, dlen;
188
722
        const char *data;
189
722
        apr_status_t s;
190
191
722
        if (APR_BUCKET_IS_EOS(e)) {
192
0
            if (ctx->status == URL_NAME) {
193
0
                s = APR_SUCCESS;
194
0
            }
195
0
            else {
196
0
                s = split_urlword(&param, pool, ctx->bb, ctx->nlen, ctx->vlen);
197
0
                if (parser->hook != NULL && s == APR_SUCCESS)
198
0
                    s = apreq_hook_run(parser->hook, param, NULL);
199
200
0
                if (s == APR_SUCCESS) {
201
0
                    apreq_value_table_add(&param->v, t);
202
0
                    ctx->status = URL_COMPLETE;
203
0
                }
204
0
                else {
205
0
                    ctx->status = URL_ERROR;
206
0
                }
207
0
            }
208
209
0
            APR_BRIGADE_CONCAT(bb, ctx->bb);
210
0
            return s;
211
0
        }
212
213
722
        s = apr_bucket_read(e, &data, &dlen, APR_BLOCK_READ);
214
722
        if ( s != APR_SUCCESS ) {
215
0
            ctx->status = URL_ERROR;
216
0
            return s;
217
0
        }
218
219
1.37k
    parse_url_bucket:
220
221
1.37k
        switch (ctx->status) {
222
223
722
        case URL_NAME:
224
6.53k
            while (off < dlen) {
225
6.45k
                switch (data[off++]) {
226
648
                case '=':
227
648
                    apr_bucket_split(e, off);
228
648
                    dlen -= off;
229
648
                    data += off;
230
648
                    off = 0;
231
648
                    e = APR_BUCKET_NEXT(e);
232
648
                    ctx->status = URL_VALUE;
233
648
                    goto parse_url_bucket;
234
5.80k
                default:
235
5.80k
                    ++ctx->nlen;
236
6.45k
                }
237
6.45k
            }
238
74
            break;
239
240
648
        case URL_VALUE:
241
3.16k
            while (off < dlen) {
242
243
3.14k
                switch (data[off++]) {
244
167
                case '&':
245
627
                case ';':
246
627
                    apr_bucket_split(e, off);
247
627
                    s = split_urlword(&param, pool, ctx->bb,
248
627
                                      ctx->nlen, ctx->vlen);
249
627
                    if (parser->hook != NULL && s == APR_SUCCESS)
250
569
                        s = apreq_hook_run(parser->hook, param, NULL);
251
252
627
                    if (s != APR_SUCCESS) {
253
58
                        ctx->status = URL_ERROR;
254
58
                        return s;
255
58
                    }
256
257
569
                    apreq_value_table_add(&param->v, t);
258
569
                    ctx->status = URL_NAME;
259
569
                    ctx->nlen = 0;
260
569
                    ctx->vlen = 0;
261
569
                    e = APR_BRIGADE_SENTINEL(ctx->bb);
262
569
                    goto parse_url_brigade;
263
264
2.51k
                default:
265
2.51k
                    ++ctx->vlen;
266
3.14k
                }
267
3.14k
            }
268
21
            break;
269
21
        default:
270
0
            ; /* not reached */
271
1.37k
        }
272
1.37k
    }
273
95
    apreq_brigade_setaside(ctx->bb, pool);
274
95
    return APR_INCOMPLETE;
275
722
}
276
277