/src/httpd/server/apreq_parser_multipart.c

Source
/*
**  Licensed to the Apache Software Foundation (ASF) under one or more
** contributor license agreements.  See the NOTICE file distributed with
** this work for additional information regarding copyright ownership.
** The ASF licenses this file to You under the Apache License, Version 2.0
** (the "License"); you may not use this file except in compliance with
** the License.  You may obtain a copy of the License at
**
**      http://www.apache.org/licenses/LICENSE-2.0
**
**  Unless required by applicable law or agreed to in writing, software
**  distributed under the License is distributed on an "AS IS" BASIS,
**  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
**  See the License for the specific language governing permissions and
**  limitations under the License.
*/

#include "apreq_parser.h"
#include "apreq_error.h"
#include "apreq_util.h"
#include "apr_strings.h"
#include "apr_strmatch.h"

#ifndef CRLF
#define CRLF    "\015\012"
#endif

#define MIN(a, b) (((a) < (b)) ? (a) : (b))

#define PARSER_STATUS_CHECK(PREFIX)   do {         \
    if (ctx->status == PREFIX##_ERROR)             \
        return APREQ_ERROR_GENERAL;                \
    else if (ctx->status == PREFIX##_COMPLETE)     \
        return APR_SUCCESS;                        \
    else if (bb == NULL)                           \
        return APR_INCOMPLETE;                     \
} while (0);

/* maximum recursion level in the mfd parser */
#define MAX_LEVEL 8

struct mfd_ctx {
    apr_table_t                 *info;
    apr_bucket_brigade          *in;
    apr_bucket_brigade          *bb;
    apreq_parser_t              *hdr_parser;
    apreq_parser_t              *next_parser;
    const apr_strmatch_pattern  *pattern;
    char                        *bdry;
    enum {
        MFD_INIT,
        MFD_NEXTLINE,
        MFD_HEADER,
        MFD_POST_HEADER,
        MFD_PARAM,
        MFD_UPLOAD,
        MFD_MIXED,
        MFD_COMPLETE,
        MFD_ERROR
    }                            status;
    apr_bucket                  *eos;
    const char                  *param_name;
    apreq_param_t               *upload;
    unsigned                    level;
};


/********************* multipart/form-data *********************/

APR_INLINE
static apr_status_t brigade_start_string(apr_bucket_brigade *bb,
                                         const char *start_string)
{
    apr_bucket *e;
    apr_size_t slen = strlen(start_string);

    for (e = APR_BRIGADE_FIRST(bb); e != APR_BRIGADE_SENTINEL(bb);
         e = APR_BUCKET_NEXT(e))
    {
        const char *buf;
        apr_status_t s, bytes_to_check;
        apr_size_t blen;

        if (slen == 0)
            return APR_SUCCESS;

        if (APR_BUCKET_IS_EOS(e))
            return APR_EOF;

        s = apr_bucket_read(e, &buf, &blen, APR_BLOCK_READ);

        if (s != APR_SUCCESS)
            return s;

        if (blen == 0)
            continue;

        bytes_to_check = MIN(slen,blen);

        if (strncmp(buf,start_string,bytes_to_check) != 0)
            return APREQ_ERROR_GENERAL;

        slen -= bytes_to_check;
        start_string += bytes_to_check;
    }

    /* slen > 0, so brigade isn't large enough yet */
    return APR_INCOMPLETE;
}


static apr_status_t split_on_bdry(apr_bucket_brigade *out,
                                  apr_bucket_brigade *in,
                                  const apr_strmatch_pattern *pattern,
                                  const char *bdry)
{
    apr_bucket *e = APR_BRIGADE_FIRST(in);
    apr_size_t blen = strlen(bdry), off = 0;

    while ( e != APR_BRIGADE_SENTINEL(in) ) {
        apr_ssize_t idx;
        apr_size_t len;
        const char *buf;
        apr_status_t s;

        if (APR_BUCKET_IS_EOS(e))
            return APR_EOF;

        s = apr_bucket_read(e, &buf, &len, APR_BLOCK_READ);
        if (s != APR_SUCCESS)
            return s;

        if (len == 0) {
            apr_bucket *f = e;
            e = APR_BUCKET_NEXT(e);
            apr_bucket_delete(f);
            continue;
        }

    look_for_boundary_up_front:
        if (strncmp(bdry + off, buf, MIN(len, blen - off)) == 0) {
            if ( len >= blen - off ) {
                /* complete match */
                if (len > blen - off)
                    apr_bucket_split(e, blen - off);
                e = APR_BUCKET_NEXT(e);

                do {
                    apr_bucket *f = APR_BRIGADE_FIRST(in);
                    apr_bucket_delete(f);
                } while (APR_BRIGADE_FIRST(in) != e);

                return APR_SUCCESS;
            }
            /* partial match */
            off += len;
            e = APR_BUCKET_NEXT(e);
            continue;
        }
        else if (off > 0) {
            /* prior (partial) strncmp failed,
             * so we can move previous buckets across
             * and retest buf against the full bdry.
             */

            /* give hints to GCC by making the brigade volatile, otherwise the
             * loop below will end up being endless. See:
             * https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193740
             */
            apr_bucket_brigade * volatile in_v = in;

            do {
                apr_bucket *f = APR_BRIGADE_FIRST(in_v);
                APR_BUCKET_REMOVE(f);
                APR_BRIGADE_INSERT_TAIL(out, f);
            } while (e != APR_BRIGADE_FIRST(in_v));
            off = 0;
            goto look_for_boundary_up_front;
        }

        if (pattern != NULL && len >= blen) {
            const char *match = apr_strmatch(pattern, buf, len);
            if (match != NULL)
                idx = match - buf;
            else {
                idx = apreq_index(buf + len-blen, blen, bdry, blen,
                                  APREQ_MATCH_PARTIAL);
                if (idx >= 0)
                    idx += len-blen;
            }
        }
        else
            idx = apreq_index(buf, len, bdry, blen, APREQ_MATCH_PARTIAL);

        /* Theoretically idx should never be 0 here, because we
         * already tested the front of the brigade for a potential match.
         * However, it doesn't hurt to allow for the possibility,
         * since this will just start the whole loop over again.
         */
        if (idx >= 0)
            apr_bucket_split(e, idx);

        APR_BUCKET_REMOVE(e);
        APR_BRIGADE_INSERT_TAIL(out, e);
        e = APR_BRIGADE_FIRST(in);
    }

    return APR_INCOMPLETE;
}


static
struct mfd_ctx * create_multipart_context(const char *content_type,
                                          apr_pool_t *pool,
                                          apr_bucket_alloc_t *ba,
                                          apr_size_t brigade_limit,
                                          const char *temp_dir,
                                          unsigned level)

{
    apr_status_t s;
    apr_size_t blen;
    struct mfd_ctx *ctx;
    const char *attr;
    char *buf;

    attr = (content_type) ? strchr(content_type, ';') : NULL;
    if (!attr)
        return NULL; /* missing semicolon */

    ctx = apr_palloc(pool, sizeof *ctx);

    attr++;
    blen = strlen(attr) + 1;
    buf = apr_palloc(pool, 4 + blen);
    buf += 4;
    memcpy(buf, attr, blen);

    s = apreq_header_attribute(buf, "boundary", 8,
                               (const char **)&ctx->bdry, &blen);
    if (s != APR_SUCCESS || !blen)
        return NULL; /* missing or empty boundary */

    ctx->bdry[blen] = 0;

    *--ctx->bdry = '-';
    *--ctx->bdry = '-';
    *--ctx->bdry = '\n';
    *--ctx->bdry = '\r';

    ctx->status = MFD_INIT;
    ctx->pattern = apr_strmatch_precompile(pool, ctx->bdry, 1);
    ctx->hdr_parser = apreq_parser_make(pool, ba, "",
                                        apreq_parse_headers,
                                        brigade_limit,
                                        temp_dir, NULL, NULL);
    ctx->info = NULL;
    ctx->bb = apr_brigade_create(pool, ba);
    ctx->in = apr_brigade_create(pool, ba);
    ctx->eos = apr_bucket_eos_create(ba);
    ctx->next_parser = NULL;
    ctx->param_name = NULL;
    ctx->upload = NULL;
    ctx->level = level;

    return ctx;
}

APREQ_DECLARE_PARSER(apreq_parse_multipart)
{
    apr_pool_t *pool = parser->pool;
    apr_bucket_alloc_t *ba = parser->bucket_alloc;
    struct mfd_ctx *ctx = parser->ctx;
    apr_status_t s;

    if (ctx == NULL) {
        ctx = create_multipart_context(parser->content_type,
                                       pool, ba,
                                       parser->brigade_limit,
                                       parser->temp_dir, 1);
        if (ctx == NULL)
            return APREQ_ERROR_GENERAL;


        parser->ctx = ctx;
    }

    PARSER_STATUS_CHECK(MFD);
    APR_BRIGADE_CONCAT(ctx->in, bb);

 mfd_parse_brigade:

    switch (ctx->status) {

    case MFD_INIT:
        {
            s = split_on_bdry(ctx->bb, ctx->in, NULL, ctx->bdry + 2);
            if (s != APR_SUCCESS) {
                apreq_brigade_setaside(ctx->in, pool);
                apreq_brigade_setaside(ctx->bb, pool);
                return s;
            }
            ctx->status = MFD_NEXTLINE;
            /* Be polite and return any preamble text to the caller. */
            APR_BRIGADE_CONCAT(bb, ctx->bb);
        }

        /* fall through */

    case MFD_NEXTLINE:
        {
            s = split_on_bdry(ctx->bb, ctx->in, NULL, CRLF);
            if (s == APR_EOF) {
                ctx->status = MFD_COMPLETE;
                return APR_SUCCESS;
            }
            if (s != APR_SUCCESS) {
                apreq_brigade_setaside(ctx->in, pool);
                apreq_brigade_setaside(ctx->bb, pool);
                return s;
            }
            if (!APR_BRIGADE_EMPTY(ctx->bb)) {
                char *line;
                apr_size_t len;
                apr_brigade_pflatten(ctx->bb, &line, &len, pool);

                if (len >= 2 && strncmp(line, "--", 2) == 0) {
                    APR_BRIGADE_CONCAT(bb, ctx->in);
                    ctx->status = MFD_COMPLETE;
                    return APR_SUCCESS;
                }
                apr_brigade_cleanup(ctx->bb);
            }

            ctx->status = MFD_HEADER;
            ctx->info = NULL;
        }
        /* fall through */

    case MFD_HEADER:
        {
            if (ctx->info == NULL) {
                ctx->info = apr_table_make(pool, APREQ_DEFAULT_NELTS);
                /* flush out header parser internal structs for reuse */
                ctx->hdr_parser->ctx = NULL;
            }
            s = apreq_parser_run(ctx->hdr_parser, ctx->info, ctx->in);
            switch (s) {
            case APR_SUCCESS:
                ctx->status = MFD_POST_HEADER;
                break;
            case APR_INCOMPLETE:
                apreq_brigade_setaside(ctx->in, pool);
                return APR_INCOMPLETE;
            default:
                ctx->status = MFD_ERROR;
                return s;
            }
        }
        /* fall through */

    case MFD_POST_HEADER:
        {
            /*  Must handle special case of missing CRLF (mainly
             *  coming from empty file uploads). See RFC2065 S5.1.1:
             *
             *    body-part = MIME-part-header [CRLF *OCTET]
             *
             *  So the CRLF we already matched in MFD_HEADER may have been
             *  part of the boundary string! Both Konqueror (v??) and
             *  Mozilla-0.97 are known to emit such blocks.
             *
             *  Here we first check for this condition with
             *  brigade_start_string, and prefix the brigade with
             *  an additional CRLF bucket if necessary.
             */

            const char *cd, *ct, *name, *filename;
            apr_size_t nlen, flen;
            apr_bucket *e;

            switch (brigade_start_string(ctx->in, ctx->bdry + 2)) {

            case APR_INCOMPLETE:
                apreq_brigade_setaside(ctx->in, pool);
                return APR_INCOMPLETE;

            case APR_SUCCESS:
                /* part has no body- return CRLF to front */
                e = apr_bucket_immortal_create(CRLF, 2,
                                                ctx->bb->bucket_alloc);
                APR_BRIGADE_INSERT_HEAD(ctx->in, e);
                break;

            default:
                ; /* has body, ok */
            }

            cd = apr_table_get(ctx->info, "Content-Disposition");

            /*  First check to see if must descend into a new multipart
             *  block.  If we do, create a new parser and pass control
             *  to it.
             */

            ct = apr_table_get(ctx->info, "Content-Type");

            if (ct != NULL && strncmp(ct, "multipart/", 10) == 0) {
                struct mfd_ctx *next_ctx;

                if (ctx->level >= MAX_LEVEL) {
                    ctx->status = MFD_ERROR;
                    goto mfd_parse_brigade;
                }

                next_ctx = create_multipart_context(ct, pool, ba,
                                                    parser->brigade_limit,
                                                    parser->temp_dir,
                                                    ctx->level + 1);
                if (next_ctx == NULL) {
                    ctx->status = MFD_ERROR;
                    goto mfd_parse_brigade;
                }

                if (cd != NULL) {
                    s = apreq_header_attribute(cd, "name", 4,
                                               &name, &nlen);
                    if (s == APR_SUCCESS && nlen) {
                        next_ctx->param_name = apr_pstrmemdup(pool, name,
                                                              nlen);
                    }
                    else if (s != APREQ_ERROR_NOATTR) {
                        ctx->status = MFD_ERROR;
                        goto mfd_parse_brigade;
                    }
                }
                if (!next_ctx->param_name) {
                    const char *cid = apr_table_get(ctx->info,
                                                    "Content-ID");
                    if (cid) {
                        next_ctx->param_name = apr_pstrdup(pool, cid);
                    }
                    else {
                        next_ctx->param_name = "";
                    }
                }

                ctx->next_parser = apreq_parser_make(pool, ba, ct,
                                                     apreq_parse_multipart,
                                                     parser->brigade_limit,
                                                     parser->temp_dir,
                                                     parser->hook,
                                                     next_ctx);
                ctx->status = MFD_MIXED;
                goto mfd_parse_brigade;

            }

            /* Look for a normal form-data part. */

            if (cd != NULL && strncmp(cd, "form-data", 9) == 0) {
                s = apreq_header_attribute(cd, "name", 4, &name, &nlen);
                if (s != APR_SUCCESS || !nlen) {
                    ctx->status = MFD_ERROR;
                    goto mfd_parse_brigade;
                }

                s = apreq_header_attribute(cd, "filename",
                                           8, &filename, &flen);
                if (s == APR_SUCCESS && flen) {
                    apreq_param_t *param;

                    param = apreq_param_make(pool, name, nlen,
                                             filename, flen);
                    if (param == NULL)
                        return APR_ENOMEM;
                    apreq_param_tainted_on(param);
                    param->info = ctx->info;
                    param->upload
                        = apr_brigade_create(pool, ctx->bb->bucket_alloc);
                    ctx->upload = param;
                    ctx->status = MFD_UPLOAD;
                    goto mfd_parse_brigade;
                }
                else if (s != APREQ_ERROR_NOATTR) {
                    ctx->status = MFD_ERROR;
                    goto mfd_parse_brigade;
                }
                else {
                    ctx->param_name = apr_pstrmemdup(pool, name, nlen);
                    ctx->status = MFD_PARAM;
                    /* fall thru */
                }
            }

            /* else check for a file part in a multipart section */
            else if (cd != NULL && strncmp(cd, "file", 4) == 0) {
                apreq_param_t *param;

                s = apreq_header_attribute(cd, "filename",
                                           8, &filename, &flen);
                if (s != APR_SUCCESS || !flen || !ctx->param_name) {
                    ctx->status = MFD_ERROR;
                    goto mfd_parse_brigade;
                }
                name = ctx->param_name;
                nlen = strlen(name);
                param = apreq_param_make(pool, name, nlen,
                                         filename, flen);
                if (param == NULL)
                    return APR_ENOMEM;
                apreq_param_tainted_on(param);
                param->info = ctx->info;
                param->upload = apr_brigade_create(pool,
                                                   ctx->bb->bucket_alloc);
                ctx->upload = param;
                ctx->status = MFD_UPLOAD;
                goto mfd_parse_brigade;
            }

            /* otherwise look for Content-ID in multipart/mixed case */
            else {
                const char *cid = apr_table_get(ctx->info, "Content-ID");
                apreq_param_t *param;

                if (cid != NULL) {
                    name = cid;
                    nlen = strlen(name);
                }
                else {
                    name = "";
                    nlen = 0;
                }

                filename = "";
                flen = 0;
                param = apreq_param_make(pool, name, nlen,
                                         filename, flen);
                if (param == NULL)
                    return APR_ENOMEM;
                apreq_param_tainted_on(param);
                param->info = ctx->info;
                param->upload = apr_brigade_create(pool,
                                               ctx->bb->bucket_alloc);
                ctx->upload = param;
                ctx->status = MFD_UPLOAD;
                goto mfd_parse_brigade;
            }
        }
        /* fall through */

    case MFD_PARAM:
        {
            apreq_param_t *param;
            apreq_value_t *v;
            apr_size_t len;
            apr_off_t off;

            s = split_on_bdry(ctx->bb, ctx->in, ctx->pattern, ctx->bdry);

            switch (s) {

            case APR_INCOMPLETE:
                apreq_brigade_setaside(ctx->in, pool);
                apreq_brigade_setaside(ctx->bb, pool);
                return s;

            case APR_SUCCESS:
                s = apr_brigade_length(ctx->bb, 1, &off);
                if (s != APR_SUCCESS) {
                    ctx->status = MFD_ERROR;
                    return s;
                }
                len = off;
                param = apreq_param_make(pool, ctx->param_name,
                                         strlen(ctx->param_name),
                                         NULL, len);
                if (param == NULL)
                    return APR_ENOMEM;
                apreq_param_tainted_on(param);
                param->info = ctx->info;

                *(const apreq_value_t **)&v = &param->v;
                apr_brigade_flatten(ctx->bb, v->data, &len);
                v->data[len] = 0;

                if (parser->hook != NULL) {
                    s = apreq_hook_run(parser->hook, param, NULL);
                    if (s != APR_SUCCESS) {
                        ctx->status = MFD_ERROR;
                        return s;
                    }
                }

                apreq_param_charset_set(param,
                                        apreq_charset_divine(v->data, len));
                apreq_value_table_add(v, t);
                ctx->status = MFD_NEXTLINE;
                ctx->param_name = NULL;
                apr_brigade_cleanup(ctx->bb);
                goto mfd_parse_brigade;

            default:
                ctx->status = MFD_ERROR;
                return s;
            }


        }
        break;  /* not reached */

    case MFD_UPLOAD:
        {
            apreq_param_t *param = ctx->upload;

            s = split_on_bdry(ctx->bb, ctx->in, ctx->pattern, ctx->bdry);
            switch (s) {

            case APR_INCOMPLETE:
                if (parser->hook != NULL) {
                    s = apreq_hook_run(parser->hook, param, ctx->bb);
                    if (s != APR_SUCCESS) {
                        ctx->status = MFD_ERROR;
                        return s;
                    }
                }
                apreq_brigade_setaside(ctx->bb, pool);
                apreq_brigade_setaside(ctx->in, pool);
                s = apreq_brigade_concat(pool, parser->temp_dir,
                                         parser->brigade_limit,
                                         param->upload, ctx->bb);
                return (s == APR_SUCCESS) ? APR_INCOMPLETE : s;

            case APR_SUCCESS:
                if (parser->hook != NULL) {
                    APR_BRIGADE_INSERT_TAIL(ctx->bb, ctx->eos);
                    s = apreq_hook_run(parser->hook, param, ctx->bb);
                    APR_BUCKET_REMOVE(ctx->eos);
                    if (s != APR_SUCCESS) {
                        ctx->status = MFD_ERROR;
                        return s;
                    }
                }
                apreq_value_table_add(&param->v, t);
                apreq_brigade_setaside(ctx->bb, pool);
                s = apreq_brigade_concat(pool, parser->temp_dir,
                                         parser->brigade_limit,
                                         param->upload, ctx->bb);

                if (s != APR_SUCCESS)
                    return s;

                ctx->status = MFD_NEXTLINE;
                goto mfd_parse_brigade;

            default:
                ctx->status = MFD_ERROR;
                return s;
            }

        }
        break;  /* not reached */


    case MFD_MIXED:
        {
            s = apreq_parser_run(ctx->next_parser, t, ctx->in);
            switch (s) {
            case APR_SUCCESS:
                ctx->status = MFD_INIT;
                ctx->param_name = NULL;
                goto mfd_parse_brigade;
            case APR_INCOMPLETE:
                APR_BRIGADE_CONCAT(bb, ctx->in);
                return APR_INCOMPLETE;
            default:
                ctx->status = MFD_ERROR;
                return s;
            }

        }
        break; /* not reached */

    default:
        return APREQ_ERROR_GENERAL;
    }

    return APR_INCOMPLETE;
}

Coverage Report

Created: 2025-12-14 06:47

Line	Count	Source
1		/*
2		** Licensed to the Apache Software Foundation (ASF) under one or more
3		** contributor license agreements. See the NOTICE file distributed with
4		** this work for additional information regarding copyright ownership.
5		** The ASF licenses this file to You under the Apache License, Version 2.0
6		** (the "License"); you may not use this file except in compliance with
7		** the License. You may obtain a copy of the License at
8		**
9		** http://www.apache.org/licenses/LICENSE-2.0
10		**
11		** Unless required by applicable law or agreed to in writing, software
12		** distributed under the License is distributed on an "AS IS" BASIS,
13		** WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14		** See the License for the specific language governing permissions and
15		** limitations under the License.
16		*/
17
18		#include "apreq_parser.h"
19		#include "apreq_error.h"
20		#include "apreq_util.h"
21		#include "apr_strings.h"
22		#include "apr_strmatch.h"
23
24		#ifndef CRLF
25	1.02k	#define CRLF "\015\012"
26		#endif
27
28	4.45k	#define MIN(a, b) (((a) < (b)) ? (a) : (b))
29
30	828	#define PARSER_STATUS_CHECK(PREFIX) do { \
31	828	if (ctx->status == PREFIX##_ERROR) \
32	828	return APREQ_ERROR_GENERAL; \
33	828	else if (ctx->status == PREFIX##_COMPLETE) \
34	828	return APR_SUCCESS; \
35	828	else if (bb == NULL) \
36	828	return APR_INCOMPLETE; \
37	828	} while (0);
38
39		/* maximum recursion level in the mfd parser */
40	85	#define MAX_LEVEL 8
41
42		struct mfd_ctx {
43		apr_table_t *info;
44		apr_bucket_brigade *in;
45		apr_bucket_brigade *bb;
46		apreq_parser_t *hdr_parser;
47		apreq_parser_t *next_parser;
48		const apr_strmatch_pattern *pattern;
49		char *bdry;
50		enum {
51		MFD_INIT,
52		MFD_NEXTLINE,
53		MFD_HEADER,
54		MFD_POST_HEADER,
55		MFD_PARAM,
56		MFD_UPLOAD,
57		MFD_MIXED,
58		MFD_COMPLETE,
59		MFD_ERROR
60		} status;
61		apr_bucket *eos;
62		const char *param_name;
63		apreq_param_t *upload;
64		unsigned level;
65		};
66
67
68		/******************* multipart/form-data *******************/
69
70		APR_INLINE
71		static apr_status_t brigade_start_string(apr_bucket_brigade *bb,
72		const char *start_string)
73	736	{
74	736	apr_bucket *e;
75	736	apr_size_t slen = strlen(start_string);
76
77	757	for (e = APR_BRIGADE_FIRST(bb); e != APR_BRIGADE_SENTINEL(bb);
78	736	e = APR_BUCKET_NEXT(e))
79	744	{
80	744	const char *buf;
81	744	apr_status_t s, bytes_to_check;
82	744	apr_size_t blen;
83
84	744	if (slen == 0)
85	11	return APR_SUCCESS;
86
87	733	if (APR_BUCKET_IS_EOS(e))
88	0	return APR_EOF;
89
90	733	s = apr_bucket_read(e, &buf, &blen, APR_BLOCK_READ);
91
92	733	if (s != APR_SUCCESS)
93	0	return s;
94
95	733	if (blen == 0)
96	0	continue;
97
98	733	bytes_to_check = MIN(slen,blen);
99
100	733	if (strncmp(buf,start_string,bytes_to_check) != 0)
101	712	return APREQ_ERROR_GENERAL;
102
103	21	slen -= bytes_to_check;
104	21	start_string += bytes_to_check;
105	21	}
106
107		/* slen > 0, so brigade isn't large enough yet */
108	13	return APR_INCOMPLETE;
109	736	}
110
111
112		static apr_status_t split_on_bdry(apr_bucket_brigade *out,
113		apr_bucket_brigade *in,
114		const apr_strmatch_pattern *pattern,
115		const char *bdry)
116	2.53k	{
117	2.53k	apr_bucket *e = APR_BRIGADE_FIRST(in);
118	2.53k	apr_size_t blen = strlen(bdry), off = 0;
119
120	4.28k	while ( e != APR_BRIGADE_SENTINEL(in) ) {
121	3.70k	apr_ssize_t idx;
122	3.70k	apr_size_t len;
123	3.70k	const char *buf;
124	3.70k	apr_status_t s;
125
126	3.70k	if (APR_BUCKET_IS_EOS(e))
127	0	return APR_EOF;
128
129	3.70k	s = apr_bucket_read(e, &buf, &len, APR_BLOCK_READ);
130	3.70k	if (s != APR_SUCCESS)
131	0	return s;
132
133	3.70k	if (len == 0) {
134	2	apr_bucket *f = e;
135	2	e = APR_BUCKET_NEXT(e);
136	2	apr_bucket_delete(f);
137	2	continue;
138	2	}
139
140	3.71k	look_for_boundary_up_front:
141	3.71k	if (strncmp(bdry + off, buf, MIN(len, blen - off)) == 0) {
142	2.07k	if ( len >= blen - off ) {
143		/* complete match */
144	1.95k	if (len > blen - off)
145	1.91k	apr_bucket_split(e, blen - off);
146	1.95k	e = APR_BUCKET_NEXT(e);
147
148	1.96k	do {
149	1.96k	apr_bucket *f = APR_BRIGADE_FIRST(in);
150	1.96k	apr_bucket_delete(f);
151	1.96k	} while (APR_BRIGADE_FIRST(in) != e);
152
153	1.95k	return APR_SUCCESS;
154	1.95k	}
155		/* partial match */
156	122	off += len;
157	122	e = APR_BUCKET_NEXT(e);
158	122	continue;
159	2.07k	}
160	1.64k	else if (off > 0) {
161		/* prior (partial) strncmp failed,
162		* so we can move previous buckets across
163		* and retest buf against the full bdry.
164		*/
165
166		/* give hints to GCC by making the brigade volatile, otherwise the
167		* loop below will end up being endless. See:
168		* https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193740
169		*/
170	13	apr_bucket_brigade * volatile in_v = in;
171
172	13	do {
173	13	apr_bucket *f = APR_BRIGADE_FIRST(in_v);
174	13	APR_BUCKET_REMOVE(f);
175	13	APR_BRIGADE_INSERT_TAIL(out, f);
176	13	} while (e != APR_BRIGADE_FIRST(in_v));
177	13	off = 0;
178	13	goto look_for_boundary_up_front;
179	13	}
180
181	1.62k	if (pattern != NULL && len >= blen) {
182	421	const char *match = apr_strmatch(pattern, buf, len);
183	421	if (match != NULL)
184	153	idx = match - buf;
185	268	else {
186	268	idx = apreq_index(buf + len-blen, blen, bdry, blen,
187	268	APREQ_MATCH_PARTIAL);
188	268	if (idx >= 0)
189	50	idx += len-blen;
190	268	}
191	421	}
192	1.20k	else
193	1.20k	idx = apreq_index(buf, len, bdry, blen, APREQ_MATCH_PARTIAL);
194
195		/* Theoretically idx should never be 0 here, because we
196		* already tested the front of the brigade for a potential match.
197		* However, it doesn't hurt to allow for the possibility,
198		* since this will just start the whole loop over again.
199		*/
200	1.62k	if (idx >= 0)
201	1.15k	apr_bucket_split(e, idx);
202
203	1.62k	APR_BUCKET_REMOVE(e);
204	1.62k	APR_BRIGADE_INSERT_TAIL(out, e);
205	1.62k	e = APR_BRIGADE_FIRST(in);
206	1.62k	}
207
208	577	return APR_INCOMPLETE;
209	2.53k	}
210
211
212		static
213		struct mfd_ctx * create_multipart_context(const char *content_type,
214		apr_pool_t *pool,
215		apr_bucket_alloc_t *ba,
216		apr_size_t brigade_limit,
217		const char *temp_dir,
218		unsigned level)
219
220	943	{
221	943	apr_status_t s;
222	943	apr_size_t blen;
223	943	struct mfd_ctx *ctx;
224	943	const char *attr;
225	943	char *buf;
226
227	943	attr = (content_type) ? strchr(content_type, ';') : NULL;
228	943	if (!attr)
229	15	return NULL; /* missing semicolon */
230
231	928	ctx = apr_palloc(pool, sizeof *ctx);
232
233	928	attr++;
234	928	blen = strlen(attr) + 1;
235	928	buf = apr_palloc(pool, 4 + blen);
236	928	buf += 4;
237	928	memcpy(buf, attr, blen);
238
239	928	s = apreq_header_attribute(buf, "boundary", 8,
240	928	(const char **)&ctx->bdry, &blen);
241	928	if (s != APR_SUCCESS \|\| !blen)
242	96	return NULL; /* missing or empty boundary */
243
244	832	ctx->bdry[blen] = 0;
245
246	832	*--ctx->bdry = '-';
247	832	*--ctx->bdry = '-';
248	832	*--ctx->bdry = '\n';
249	832	*--ctx->bdry = '\r';
250
251	832	ctx->status = MFD_INIT;
252	832	ctx->pattern = apr_strmatch_precompile(pool, ctx->bdry, 1);
253	832	ctx->hdr_parser = apreq_parser_make(pool, ba, "",
254	832	apreq_parse_headers,
255	832	brigade_limit,
256	832	temp_dir, NULL, NULL);
257	832	ctx->info = NULL;
258	832	ctx->bb = apr_brigade_create(pool, ba);
259	832	ctx->in = apr_brigade_create(pool, ba);
260	832	ctx->eos = apr_bucket_eos_create(ba);
261	832	ctx->next_parser = NULL;
262	832	ctx->param_name = NULL;
263	832	ctx->upload = NULL;
264	832	ctx->level = level;
265
266	832	return ctx;
267	928	}
268
269		APREQ_DECLARE_PARSER(apreq_parse_multipart)
270	936	{
271	936	apr_pool_t *pool = parser->pool;
272	936	apr_bucket_alloc_t *ba = parser->bucket_alloc;
273	936	struct mfd_ctx *ctx = parser->ctx;
274	936	apr_status_t s;
275
276	936	if (ctx == NULL) {
277	858	ctx = create_multipart_context(parser->content_type,
278	858	pool, ba,
279	858	parser->brigade_limit,
280	858	parser->temp_dir, 1);
281	858	if (ctx == NULL)
282	108	return APREQ_ERROR_GENERAL;
283
284
285	750	parser->ctx = ctx;
286	750	}
287
288	828	PARSER_STATUS_CHECK(MFD);
289	828	APR_BRIGADE_CONCAT(ctx->in, bb);
290
291	1.78k	mfd_parse_brigade:
292
293	1.78k	switch (ctx->status) {
294
295	896	case MFD_INIT:
296	896	{
297	896	s = split_on_bdry(ctx->bb, ctx->in, NULL, ctx->bdry + 2);
298	896	if (s != APR_SUCCESS) {
299	100	apreq_brigade_setaside(ctx->in, pool);
300	100	apreq_brigade_setaside(ctx->bb, pool);
301	100	return s;
302	100	}
303	796	ctx->status = MFD_NEXTLINE;
304		/* Be polite and return any preamble text to the caller. */
305	796	APR_BRIGADE_CONCAT(bb, ctx->bb);
306	796	}
307
308		/* fall through */
309
310	1.01k	case MFD_NEXTLINE:
311	1.01k	{
312	1.01k	s = split_on_bdry(ctx->bb, ctx->in, NULL, CRLF);
313	1.01k	if (s == APR_EOF) {
314	0	ctx->status = MFD_COMPLETE;
315	0	return APR_SUCCESS;
316	0	}
317	1.01k	if (s != APR_SUCCESS) {
318	77	apreq_brigade_setaside(ctx->in, pool);
319	77	apreq_brigade_setaside(ctx->bb, pool);
320	77	return s;
321	77	}
322	939	if (!APR_BRIGADE_EMPTY(ctx->bb)) {
323	518	char *line;
324	518	apr_size_t len;
325	518	apr_brigade_pflatten(ctx->bb, &line, &len, pool);
326
327	518	if (len >= 2 && strncmp(line, "--", 2) == 0) {
328	76	APR_BRIGADE_CONCAT(bb, ctx->in);
329	76	ctx->status = MFD_COMPLETE;
330	76	return APR_SUCCESS;
331	76	}
332	442	apr_brigade_cleanup(ctx->bb);
333	442	}
334
335	863	ctx->status = MFD_HEADER;
336	863	ctx->info = NULL;
337	863	}
338		/* fall through */
339
340	863	case MFD_HEADER:
341	863	{
342	863	if (ctx->info == NULL) {
343	863	ctx->info = apr_table_make(pool, APREQ_DEFAULT_NELTS);
344		/* flush out header parser internal structs for reuse */
345	863	ctx->hdr_parser->ctx = NULL;
346	863	}
347	863	s = apreq_parser_run(ctx->hdr_parser, ctx->info, ctx->in);
348	863	switch (s) {
349	736	case APR_SUCCESS:
350	736	ctx->status = MFD_POST_HEADER;
351	736	break;
352	69	case APR_INCOMPLETE:
353	69	apreq_brigade_setaside(ctx->in, pool);
354	69	return APR_INCOMPLETE;
355	58	default:
356	58	ctx->status = MFD_ERROR;
357	58	return s;
358	863	}
359	863	}
360		/* fall through */
361
362	736	case MFD_POST_HEADER:
363	736	{
364		/* Must handle special case of missing CRLF (mainly
365		* coming from empty file uploads). See RFC2065 S5.1.1:
366		*
367		* body-part = MIME-part-header [CRLF *OCTET]
368		*
369		* So the CRLF we already matched in MFD_HEADER may have been
370		* part of the boundary string! Both Konqueror (v??) and
371		* Mozilla-0.97 are known to emit such blocks.
372		*
373		* Here we first check for this condition with
374		* brigade_start_string, and prefix the brigade with
375		* an additional CRLF bucket if necessary.
376		*/
377
378	736	const char cd, ct, name, filename;
379	736	apr_size_t nlen, flen;
380	736	apr_bucket *e;
381
382	736	switch (brigade_start_string(ctx->in, ctx->bdry + 2)) {
383
384	13	case APR_INCOMPLETE:
385	13	apreq_brigade_setaside(ctx->in, pool);
386	13	return APR_INCOMPLETE;
387
388	11	case APR_SUCCESS:
389		/* part has no body- return CRLF to front */
390	11	e = apr_bucket_immortal_create(CRLF, 2,
391	11	ctx->bb->bucket_alloc);
392	11	APR_BRIGADE_INSERT_HEAD(ctx->in, e);
393	11	break;
394
395	712	default:
396	712	; /* has body, ok */
397	736	}
398
399	723	cd = apr_table_get(ctx->info, "Content-Disposition");
400
401		/* First check to see if must descend into a new multipart
402		* block. If we do, create a new parser and pass control
403		* to it.
404		*/
405
406	723	ct = apr_table_get(ctx->info, "Content-Type");
407
408	723	if (ct != NULL && strncmp(ct, "multipart/", 10) == 0) {
409	85	struct mfd_ctx *next_ctx;
410
411	85	if (ctx->level >= MAX_LEVEL) {
412	0	ctx->status = MFD_ERROR;
413	0	goto mfd_parse_brigade;
414	0	}
415
416	85	next_ctx = create_multipart_context(ct, pool, ba,
417	85	parser->brigade_limit,
418	85	parser->temp_dir,
419	85	ctx->level + 1);
420	85	if (next_ctx == NULL) {
421	3	ctx->status = MFD_ERROR;
422	3	goto mfd_parse_brigade;
423	3	}
424
425	82	if (cd != NULL) {
426	8	s = apreq_header_attribute(cd, "name", 4,
427	8	&name, &nlen);
428	8	if (s == APR_SUCCESS && nlen) {
429	2	next_ctx->param_name = apr_pstrmemdup(pool, name,
430	2	nlen);
431	2	}
432	6	else if (s != APREQ_ERROR_NOATTR) {
433	4	ctx->status = MFD_ERROR;
434	4	goto mfd_parse_brigade;
435	4	}
436	8	}
437	78	if (!next_ctx->param_name) {
438	76	const char *cid = apr_table_get(ctx->info,
439	76	"Content-ID");
440	76	if (cid) {
441	2	next_ctx->param_name = apr_pstrdup(pool, cid);
442	2	}
443	74	else {
444	74	next_ctx->param_name = "";
445	74	}
446	76	}
447
448	78	ctx->next_parser = apreq_parser_make(pool, ba, ct,
449	78	apreq_parse_multipart,
450	78	parser->brigade_limit,
451	78	parser->temp_dir,
452	78	parser->hook,
453	78	next_ctx);
454	78	ctx->status = MFD_MIXED;
455	78	goto mfd_parse_brigade;
456
457	82	}
458
459		/* Look for a normal form-data part. */
460
461	638	if (cd != NULL && strncmp(cd, "form-data", 9) == 0) {
462	68	s = apreq_header_attribute(cd, "name", 4, &name, &nlen);
463	68	if (s != APR_SUCCESS \|\| !nlen) {
464	5	ctx->status = MFD_ERROR;
465	5	goto mfd_parse_brigade;
466	5	}
467
468	63	s = apreq_header_attribute(cd, "filename",
469	63	8, &filename, &flen);
470	63	if (s == APR_SUCCESS && flen) {
471	4	apreq_param_t *param;
472
473	4	param = apreq_param_make(pool, name, nlen,
474	4	filename, flen);
475	4	if (param == NULL)
476	0	return APR_ENOMEM;
477	4	apreq_param_tainted_on(param);
478	4	param->info = ctx->info;
479	4	param->upload
480	4	= apr_brigade_create(pool, ctx->bb->bucket_alloc);
481	4	ctx->upload = param;
482	4	ctx->status = MFD_UPLOAD;
483	4	goto mfd_parse_brigade;
484	4	}
485	59	else if (s != APREQ_ERROR_NOATTR) {
486	4	ctx->status = MFD_ERROR;
487	4	goto mfd_parse_brigade;
488	4	}
489	55	else {
490	55	ctx->param_name = apr_pstrmemdup(pool, name, nlen);
491	55	ctx->status = MFD_PARAM;
492		/* fall thru */
493	55	}
494	63	}
495
496		/* else check for a file part in a multipart section */
497	570	else if (cd != NULL && strncmp(cd, "file", 4) == 0) {
498	9	apreq_param_t *param;
499
500	9	s = apreq_header_attribute(cd, "filename",
501	9	8, &filename, &flen);
502	9	if (s != APR_SUCCESS \|\| !flen \|\| !ctx->param_name) {
503	9	ctx->status = MFD_ERROR;
504	9	goto mfd_parse_brigade;
505	9	}
506	0	name = ctx->param_name;
507	0	nlen = strlen(name);
508	0	param = apreq_param_make(pool, name, nlen,
509	0	filename, flen);
510	0	if (param == NULL)
511	0	return APR_ENOMEM;
512	0	apreq_param_tainted_on(param);
513	0	param->info = ctx->info;
514	0	param->upload = apr_brigade_create(pool,
515	0	ctx->bb->bucket_alloc);
516	0	ctx->upload = param;
517	0	ctx->status = MFD_UPLOAD;
518	0	goto mfd_parse_brigade;
519	0	}
520
521		/* otherwise look for Content-ID in multipart/mixed case */
522	561	else {
523	561	const char *cid = apr_table_get(ctx->info, "Content-ID");
524	561	apreq_param_t *param;
525
526	561	if (cid != NULL) {
527	22	name = cid;
528	22	nlen = strlen(name);
529	22	}
530	539	else {
531	539	name = "";
532	539	nlen = 0;
533	539	}
534
535	561	filename = "";
536	561	flen = 0;
537	561	param = apreq_param_make(pool, name, nlen,
538	561	filename, flen);
539	561	if (param == NULL)
540	0	return APR_ENOMEM;
541	561	apreq_param_tainted_on(param);
542	561	param->info = ctx->info;
543	561	param->upload = apr_brigade_create(pool,
544	561	ctx->bb->bucket_alloc);
545	561	ctx->upload = param;
546	561	ctx->status = MFD_UPLOAD;
547	561	goto mfd_parse_brigade;
548	561	}
549	638	}
550		/* fall through */
551
552	55	case MFD_PARAM:
553	55	{
554	55	apreq_param_t *param;
555	55	apreq_value_t *v;
556	55	apr_size_t len;
557	55	apr_off_t off;
558
559	55	s = split_on_bdry(ctx->bb, ctx->in, ctx->pattern, ctx->bdry);
560
561	55	switch (s) {
562
563	8	case APR_INCOMPLETE:
564	8	apreq_brigade_setaside(ctx->in, pool);
565	8	apreq_brigade_setaside(ctx->bb, pool);
566	8	return s;
567
568	47	case APR_SUCCESS:
569	47	s = apr_brigade_length(ctx->bb, 1, &off);
570	47	if (s != APR_SUCCESS) {
571	0	ctx->status = MFD_ERROR;
572	0	return s;
573	0	}
574	47	len = off;
575	47	param = apreq_param_make(pool, ctx->param_name,
576	47	strlen(ctx->param_name),
577	47	NULL, len);
578	47	if (param == NULL)
579	0	return APR_ENOMEM;
580	47	apreq_param_tainted_on(param);
581	47	param->info = ctx->info;
582
583	47	(const apreq_value_t *)&v = &param->v;
584	47	apr_brigade_flatten(ctx->bb, v->data, &len);
585	47	v->data[len] = 0;
586
587	47	if (parser->hook != NULL) {
588	47	s = apreq_hook_run(parser->hook, param, NULL);
589	47	if (s != APR_SUCCESS) {
590	0	ctx->status = MFD_ERROR;
591	0	return s;
592	0	}
593	47	}
594
595	47	apreq_param_charset_set(param,
596	47	apreq_charset_divine(v->data, len));
597	47	apreq_value_table_add(v, t);
598	47	ctx->status = MFD_NEXTLINE;
599	47	ctx->param_name = NULL;
600	47	apr_brigade_cleanup(ctx->bb);
601	47	goto mfd_parse_brigade;
602
603	0	default:
604	0	ctx->status = MFD_ERROR;
605	0	return s;
606	55	}
607
608
609	55	}
610	0	break; /* not reached */
611
612	565	case MFD_UPLOAD:
613	565	{
614	565	apreq_param_t *param = ctx->upload;
615
616	565	s = split_on_bdry(ctx->bb, ctx->in, ctx->pattern, ctx->bdry);
617	565	switch (s) {
618
619	392	case APR_INCOMPLETE:
620	392	if (parser->hook != NULL) {
621	392	s = apreq_hook_run(parser->hook, param, ctx->bb);
622	392	if (s != APR_SUCCESS) {
623	0	ctx->status = MFD_ERROR;
624	0	return s;
625	0	}
626	392	}
627	392	apreq_brigade_setaside(ctx->bb, pool);
628	392	apreq_brigade_setaside(ctx->in, pool);
629	392	s = apreq_brigade_concat(pool, parser->temp_dir,
630	392	parser->brigade_limit,
631	392	param->upload, ctx->bb);
632	392	return (s == APR_SUCCESS) ? APR_INCOMPLETE : s;
633
634	173	case APR_SUCCESS:
635	173	if (parser->hook != NULL) {
636	173	APR_BRIGADE_INSERT_TAIL(ctx->bb, ctx->eos);
637	173	s = apreq_hook_run(parser->hook, param, ctx->bb);
638	173	APR_BUCKET_REMOVE(ctx->eos);
639	173	if (s != APR_SUCCESS) {
640	0	ctx->status = MFD_ERROR;
641	0	return s;
642	0	}
643	173	}
644	173	apreq_value_table_add(&param->v, t);
645	173	apreq_brigade_setaside(ctx->bb, pool);
646	173	s = apreq_brigade_concat(pool, parser->temp_dir,
647	173	parser->brigade_limit,
648	173	param->upload, ctx->bb);
649
650	173	if (s != APR_SUCCESS)
651	0	return s;
652
653	173	ctx->status = MFD_NEXTLINE;
654	173	goto mfd_parse_brigade;
655
656	0	default:
657	0	ctx->status = MFD_ERROR;
658	0	return s;
659	565	}
660
661	565	}
662	0	break; /* not reached */
663
664
665	78	case MFD_MIXED:
666	78	{
667	78	s = apreq_parser_run(ctx->next_parser, t, ctx->in);
668	78	switch (s) {
669	68	case APR_SUCCESS:
670	68	ctx->status = MFD_INIT;
671	68	ctx->param_name = NULL;
672	68	goto mfd_parse_brigade;
673	8	case APR_INCOMPLETE:
674	8	APR_BRIGADE_CONCAT(bb, ctx->in);
675	8	return APR_INCOMPLETE;
676	2	default:
677	2	ctx->status = MFD_ERROR;
678	2	return s;
679	78	}
680
681	78	}
682	0	break; /* not reached */
683
684	25	default:
685	25	return APREQ_ERROR_GENERAL;
686	1.78k	}
687
688	0	return APR_INCOMPLETE;
689	1.78k	}