Coverage Report

Created: 2024-09-08 06:20

/src/FreeRDP/libfreerdp/core/surface.c
Line
Count
Source (jump to first uncovered line)
1
/**
2
 * FreeRDP: A Remote Desktop Protocol Implementation
3
 * Surface Commands
4
 *
5
 * Copyright 2011 Vic Lee
6
 *
7
 * Licensed under the Apache License, Version 2.0 (the "License");
8
 * you may not use this file except in compliance with the License.
9
 * You may obtain a copy of the License at
10
 *
11
 *     http://www.apache.org/licenses/LICENSE-2.0
12
 *
13
 * Unless required by applicable law or agreed to in writing, software
14
 * distributed under the License is distributed on an "AS IS" BASIS,
15
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16
 * See the License for the specific language governing permissions and
17
 * limitations under the License.
18
 */
19
20
#include <freerdp/config.h>
21
22
#include "settings.h"
23
24
#include <winpr/assert.h>
25
26
#include <freerdp/utils/pcap.h>
27
#include <freerdp/log.h>
28
29
#include "../cache/cache.h"
30
#include "surface.h"
31
32
#define TAG FREERDP_TAG("core.surface")
33
34
static BOOL update_recv_surfcmd_bitmap_header_ex(wStream* s, TS_COMPRESSED_BITMAP_HEADER_EX* header)
35
390
{
36
390
  if (!s || !header)
37
0
    return FALSE;
38
39
390
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 24))
40
10
    return FALSE;
41
42
380
  Stream_Read_UINT32(s, header->highUniqueId);
43
380
  Stream_Read_UINT32(s, header->lowUniqueId);
44
380
  Stream_Read_UINT64(s, header->tmMilliseconds);
45
380
  Stream_Read_UINT64(s, header->tmSeconds);
46
380
  return TRUE;
47
390
}
48
49
static BOOL update_recv_surfcmd_bitmap_ex(wStream* s, TS_BITMAP_DATA_EX* bmp)
50
993
{
51
993
  if (!s || !bmp)
52
0
    return FALSE;
53
54
993
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 12))
55
10
    return FALSE;
56
57
983
  Stream_Read_UINT8(s, bmp->bpp);
58
983
  Stream_Read_UINT8(s, bmp->flags);
59
983
  Stream_Seek(s, 1); /* reserved */
60
983
  Stream_Read_UINT8(s, bmp->codecID);
61
983
  Stream_Read_UINT16(s, bmp->width);
62
983
  Stream_Read_UINT16(s, bmp->height);
63
983
  Stream_Read_UINT32(s, bmp->bitmapDataLength);
64
65
983
  if ((bmp->width == 0) || (bmp->height == 0))
66
12
  {
67
12
    WLog_ERR(TAG, "invalid size value width=%" PRIu16 ", height=%" PRIu16, bmp->width,
68
12
             bmp->height);
69
12
    return FALSE;
70
12
  }
71
72
971
  if ((bmp->bpp < 1) || (bmp->bpp > 32))
73
26
  {
74
26
    WLog_ERR(TAG, "invalid bpp value %" PRIu32 "", bmp->bpp);
75
26
    return FALSE;
76
26
  }
77
78
945
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
79
390
  {
80
390
    if (!update_recv_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
81
10
      return FALSE;
82
390
  }
83
84
935
  bmp->bitmapData = Stream_Pointer(s);
85
935
  if (!Stream_SafeSeek(s, bmp->bitmapDataLength))
86
85
  {
87
85
    WLog_ERR(TAG, "expected bitmapDataLength %" PRIu32 ", not enough data",
88
85
             bmp->bitmapDataLength);
89
85
    return FALSE;
90
85
  }
91
850
  return TRUE;
92
935
}
93
94
static BOOL update_recv_surfcmd_is_rect_valid(const rdpContext* context,
95
                                              const SURFACE_BITS_COMMAND* cmd)
96
1.22k
{
97
1.22k
  WINPR_ASSERT(context);
98
1.22k
  WINPR_ASSERT(context->settings);
99
1.22k
  WINPR_ASSERT(cmd);
100
101
  /* We need a rectangle with left/top being smaller than right/bottom.
102
   * Also do not allow empty rectangles. */
103
1.22k
  if ((cmd->destTop >= cmd->destBottom) || (cmd->destLeft >= cmd->destRight))
104
138
  {
105
138
    WLog_WARN(TAG,
106
138
              "Empty surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
107
138
              "x%" PRIu16,
108
138
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom);
109
138
    return FALSE;
110
138
  }
111
112
  /* The rectangle needs to fit into our session size */
113
1.09k
  if ((cmd->destRight > context->settings->DesktopWidth) ||
114
1.09k
      (cmd->destBottom > context->settings->DesktopHeight))
115
97
  {
116
97
    WLog_WARN(TAG,
117
97
              "Invalid surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
118
97
              "x%" PRIu16 " does not fit %" PRIu32 "x%" PRIu32,
119
97
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom,
120
97
              context->settings->DesktopWidth, context->settings->DesktopHeight);
121
97
    return FALSE;
122
97
  }
123
124
993
  return TRUE;
125
1.09k
}
126
127
static BOOL update_recv_surfcmd_surface_bits(rdpUpdate* update, wStream* s, UINT16 cmdType)
128
1.25k
{
129
1.25k
  BOOL rc = FALSE;
130
1.25k
  SURFACE_BITS_COMMAND cmd = { 0 };
131
132
1.25k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 8))
133
31
    goto fail;
134
135
1.22k
  cmd.cmdType = cmdType;
136
1.22k
  Stream_Read_UINT16(s, cmd.destLeft);
137
1.22k
  Stream_Read_UINT16(s, cmd.destTop);
138
1.22k
  Stream_Read_UINT16(s, cmd.destRight);
139
1.22k
  Stream_Read_UINT16(s, cmd.destBottom);
140
141
1.22k
  if (!update_recv_surfcmd_is_rect_valid(update->context, &cmd))
142
235
    goto fail;
143
144
993
  if (!update_recv_surfcmd_bitmap_ex(s, &cmd.bmp))
145
143
    goto fail;
146
147
850
  if (!IFCALLRESULT(TRUE, update->SurfaceBits, update->context, &cmd))
148
88
  {
149
88
    WLog_DBG(TAG, "update->SurfaceBits implementation failed");
150
88
    goto fail;
151
88
  }
152
153
762
  rc = TRUE;
154
1.25k
fail:
155
1.25k
  return rc;
156
762
}
157
158
static BOOL update_recv_surfcmd_frame_marker(rdpUpdate* update, wStream* s)
159
97
{
160
97
  SURFACE_FRAME_MARKER marker = { 0 };
161
97
  rdp_update_internal* up = update_cast(update);
162
163
97
  WINPR_ASSERT(s);
164
165
97
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 2))
166
6
    return FALSE;
167
168
91
  Stream_Read_UINT16(s, marker.frameAction);
169
91
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 4))
170
91
    WLog_WARN(TAG,
171
80
              "[SERVER-BUG]: got %" PRIuz ", expected %" PRIuz
172
80
              " bytes. [MS-RDPBCGR] 2.2.9.2.3 Frame Marker Command (TS_FRAME_MARKER) is "
173
80
              "missing frameId, ignoring",
174
80
              Stream_GetRemainingLength(s), 4);
175
80
  else
176
80
    Stream_Read_UINT32(s, marker.frameId);
177
91
  WLog_Print(up->log, WLOG_DEBUG, "SurfaceFrameMarker: action: %s (%" PRIu32 ") id: %" PRIu32 "",
178
91
             (!marker.frameAction) ? "Begin" : "End", marker.frameAction, marker.frameId);
179
180
91
  if (!update->SurfaceFrameMarker)
181
25
  {
182
25
    WINPR_ASSERT(update->context);
183
25
    if (freerdp_settings_get_bool(update->context->settings, FreeRDP_DeactivateClientDecoding))
184
0
      return TRUE;
185
25
    WLog_ERR(TAG, "Missing callback update->SurfaceFrameMarker");
186
25
    return FALSE;
187
25
  }
188
189
66
  if (!update->SurfaceFrameMarker(update->context, &marker))
190
66
  {
191
66
    WLog_DBG(TAG, "update->SurfaceFrameMarker implementation failed");
192
66
    return FALSE;
193
66
  }
194
195
0
  return TRUE;
196
66
}
197
198
int update_recv_surfcmds(rdpUpdate* update, wStream* s)
199
13.2k
{
200
13.2k
  UINT16 cmdType = 0;
201
13.2k
  rdp_update_internal* up = update_cast(update);
202
203
13.2k
  WINPR_ASSERT(s);
204
205
14.0k
  while (Stream_GetRemainingLength(s) >= 2)
206
10.3k
  {
207
10.3k
    const size_t start = Stream_GetPosition(s);
208
10.3k
    const BYTE* mark = Stream_ConstPointer(s);
209
210
10.3k
    Stream_Read_UINT16(s, cmdType);
211
212
10.3k
    switch (cmdType)
213
10.3k
    {
214
626
      case CMDTYPE_SET_SURFACE_BITS:
215
1.25k
      case CMDTYPE_STREAM_SURFACE_BITS:
216
1.25k
        if (!update_recv_surfcmd_surface_bits(update, s, cmdType))
217
497
          return -1;
218
219
762
        break;
220
221
762
      case CMDTYPE_FRAME_MARKER:
222
97
        if (!update_recv_surfcmd_frame_marker(update, s))
223
97
          return -1;
224
225
0
        break;
226
227
8.96k
      default:
228
8.96k
        WLog_ERR(TAG, "unknown cmdType 0x%04" PRIX16 "", cmdType);
229
8.96k
        return -1;
230
10.3k
    }
231
232
762
    if (up->dump_rfx)
233
0
    {
234
0
      const size_t size = Stream_GetPosition(s) - start;
235
      /* TODO: treat return values */
236
0
      pcap_add_record(up->pcap_rfx, mark, size);
237
0
      pcap_flush(up->pcap_rfx);
238
0
    }
239
762
  }
240
241
3.71k
  return 0;
242
13.2k
}
243
244
static BOOL update_write_surfcmd_bitmap_header_ex(wStream* s,
245
                                                  const TS_COMPRESSED_BITMAP_HEADER_EX* header)
246
75
{
247
75
  if (!s || !header)
248
0
    return FALSE;
249
250
75
  if (!Stream_EnsureRemainingCapacity(s, 24))
251
0
    return FALSE;
252
253
75
  Stream_Write_UINT32(s, header->highUniqueId);
254
75
  Stream_Write_UINT32(s, header->lowUniqueId);
255
75
  Stream_Write_UINT64(s, header->tmMilliseconds);
256
75
  Stream_Write_UINT64(s, header->tmSeconds);
257
75
  return TRUE;
258
75
}
259
260
static BOOL update_write_surfcmd_bitmap_ex(wStream* s, const TS_BITMAP_DATA_EX* bmp)
261
88
{
262
88
  if (!s || !bmp)
263
0
    return FALSE;
264
265
88
  if (!Stream_EnsureRemainingCapacity(s, 12))
266
0
    return FALSE;
267
268
88
  if (bmp->codecID > UINT8_MAX)
269
0
  {
270
0
    WLog_ERR(TAG, "Invalid TS_BITMAP_DATA_EX::codecID=0x%04" PRIx16 "", bmp->codecID);
271
0
    return FALSE;
272
0
  }
273
88
  Stream_Write_UINT8(s, bmp->bpp);
274
88
  Stream_Write_UINT8(s, bmp->flags);
275
88
  Stream_Write_UINT8(s, 0); /* reserved1, reserved2 */
276
88
  Stream_Write_UINT8(s, (UINT8)bmp->codecID);
277
88
  Stream_Write_UINT16(s, bmp->width);
278
88
  Stream_Write_UINT16(s, bmp->height);
279
88
  Stream_Write_UINT32(s, bmp->bitmapDataLength);
280
281
88
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
282
75
  {
283
75
    if (!update_write_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
284
0
      return FALSE;
285
75
  }
286
287
88
  if (!Stream_EnsureRemainingCapacity(s, bmp->bitmapDataLength))
288
0
    return FALSE;
289
290
88
  Stream_Write(s, bmp->bitmapData, bmp->bitmapDataLength);
291
88
  return TRUE;
292
88
}
293
294
BOOL update_write_surfcmd_surface_bits(wStream* s, const SURFACE_BITS_COMMAND* cmd)
295
88
{
296
88
  UINT16 cmdType = 0;
297
88
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_SURFACE_BITS_HEADER_LENGTH))
298
0
    return FALSE;
299
300
88
  cmdType = cmd->cmdType;
301
88
  switch (cmdType)
302
88
  {
303
85
    case CMDTYPE_SET_SURFACE_BITS:
304
88
    case CMDTYPE_STREAM_SURFACE_BITS:
305
88
      break;
306
0
    default:
307
0
      WLog_WARN(TAG,
308
0
                "SURFACE_BITS_COMMAND->cmdType 0x%04" PRIx16
309
0
                " not allowed, correcting to 0x%04" PRIx16,
310
0
                cmdType, CMDTYPE_STREAM_SURFACE_BITS);
311
0
      cmdType = CMDTYPE_STREAM_SURFACE_BITS;
312
0
      break;
313
88
  }
314
315
88
  Stream_Write_UINT16(s, cmdType);
316
88
  Stream_Write_UINT16(s, cmd->destLeft);
317
88
  Stream_Write_UINT16(s, cmd->destTop);
318
88
  Stream_Write_UINT16(s, cmd->destRight);
319
88
  Stream_Write_UINT16(s, cmd->destBottom);
320
88
  return update_write_surfcmd_bitmap_ex(s, &cmd->bmp);
321
88
}
322
323
BOOL update_write_surfcmd_frame_marker(wStream* s, UINT16 frameAction, UINT32 frameId)
324
66
{
325
66
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_FRAME_MARKER_LENGTH))
326
0
    return FALSE;
327
328
66
  Stream_Write_UINT16(s, CMDTYPE_FRAME_MARKER);
329
66
  Stream_Write_UINT16(s, frameAction);
330
66
  Stream_Write_UINT32(s, frameId);
331
66
  return TRUE;
332
66
}