Coverage Report

Created: 2025-07-18 07:08

/src/FreeRDP/libfreerdp/core/surface.c
Line
Count
Source (jump to first uncovered line)
1
/**
2
 * FreeRDP: A Remote Desktop Protocol Implementation
3
 * Surface Commands
4
 *
5
 * Copyright 2011 Vic Lee
6
 *
7
 * Licensed under the Apache License, Version 2.0 (the "License");
8
 * you may not use this file except in compliance with the License.
9
 * You may obtain a copy of the License at
10
 *
11
 *     http://www.apache.org/licenses/LICENSE-2.0
12
 *
13
 * Unless required by applicable law or agreed to in writing, software
14
 * distributed under the License is distributed on an "AS IS" BASIS,
15
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16
 * See the License for the specific language governing permissions and
17
 * limitations under the License.
18
 */
19
20
#include <freerdp/config.h>
21
22
#include "settings.h"
23
24
#include <winpr/assert.h>
25
#include <winpr/cast.h>
26
27
#include <freerdp/utils/pcap.h>
28
#include <freerdp/log.h>
29
30
#include "../cache/cache.h"
31
#include "surface.h"
32
33
#define TAG FREERDP_TAG("core.surface")
34
35
static BOOL update_recv_surfcmd_bitmap_header_ex(wStream* s, TS_COMPRESSED_BITMAP_HEADER_EX* header)
36
166
{
37
166
  if (!s || !header)
38
0
    return FALSE;
39
40
166
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 24))
41
12
    return FALSE;
42
43
154
  Stream_Read_UINT32(s, header->highUniqueId);
44
154
  Stream_Read_UINT32(s, header->lowUniqueId);
45
154
  Stream_Read_UINT64(s, header->tmMilliseconds);
46
154
  Stream_Read_UINT64(s, header->tmSeconds);
47
154
  return TRUE;
48
166
}
49
50
static BOOL update_recv_surfcmd_bitmap_ex(wStream* s, TS_BITMAP_DATA_EX* bmp)
51
982
{
52
982
  if (!s || !bmp)
53
0
    return FALSE;
54
55
982
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 12))
56
13
    return FALSE;
57
58
969
  Stream_Read_UINT8(s, bmp->bpp);
59
969
  Stream_Read_UINT8(s, bmp->flags);
60
969
  Stream_Seek(s, 1); /* reserved */
61
969
  Stream_Read_UINT8(s, bmp->codecID);
62
969
  Stream_Read_UINT16(s, bmp->width);
63
969
  Stream_Read_UINT16(s, bmp->height);
64
969
  Stream_Read_UINT32(s, bmp->bitmapDataLength);
65
66
969
  if ((bmp->width == 0) || (bmp->height == 0))
67
41
  {
68
41
    WLog_ERR(TAG, "invalid size value width=%" PRIu16 ", height=%" PRIu16, bmp->width,
69
41
             bmp->height);
70
41
    return FALSE;
71
41
  }
72
73
928
  if ((bmp->bpp < 1) || (bmp->bpp > 32))
74
31
  {
75
31
    WLog_ERR(TAG, "invalid bpp value %" PRIu32 "", bmp->bpp);
76
31
    return FALSE;
77
31
  }
78
79
897
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
80
166
  {
81
166
    if (!update_recv_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
82
12
      return FALSE;
83
166
  }
84
85
885
  bmp->bitmapData = Stream_Pointer(s);
86
885
  if (!Stream_SafeSeek(s, bmp->bitmapDataLength))
87
119
  {
88
119
    WLog_ERR(TAG, "expected bitmapDataLength %" PRIu32 ", not enough data",
89
119
             bmp->bitmapDataLength);
90
119
    return FALSE;
91
119
  }
92
766
  return TRUE;
93
885
}
94
95
static BOOL update_recv_surfcmd_is_rect_valid(const rdpContext* context,
96
                                              const SURFACE_BITS_COMMAND* cmd)
97
1.21k
{
98
1.21k
  WINPR_ASSERT(context);
99
1.21k
  WINPR_ASSERT(context->settings);
100
1.21k
  WINPR_ASSERT(cmd);
101
102
  /* We need a rectangle with left/top being smaller than right/bottom.
103
   * Also do not allow empty rectangles. */
104
1.21k
  if ((cmd->destTop >= cmd->destBottom) || (cmd->destLeft >= cmd->destRight))
105
131
  {
106
131
    WLog_WARN(TAG,
107
131
              "Empty surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
108
131
              "x%" PRIu16,
109
131
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom);
110
131
    return FALSE;
111
131
  }
112
113
  /* The rectangle needs to fit into our session size */
114
1.08k
  if ((cmd->destRight > context->settings->DesktopWidth) ||
115
1.08k
      (cmd->destBottom > context->settings->DesktopHeight))
116
98
  {
117
98
    WLog_WARN(TAG,
118
98
              "Invalid surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
119
98
              "x%" PRIu16 " does not fit %" PRIu32 "x%" PRIu32,
120
98
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom,
121
98
              context->settings->DesktopWidth, context->settings->DesktopHeight);
122
98
    return FALSE;
123
98
  }
124
125
982
  return TRUE;
126
1.08k
}
127
128
static BOOL update_recv_surfcmd_surface_bits(rdpUpdate* update, wStream* s, UINT16 cmdType)
129
1.24k
{
130
1.24k
  BOOL rc = FALSE;
131
1.24k
  SURFACE_BITS_COMMAND cmd = { 0 };
132
133
1.24k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 8))
134
31
    goto fail;
135
136
1.21k
  cmd.cmdType = cmdType;
137
1.21k
  Stream_Read_UINT16(s, cmd.destLeft);
138
1.21k
  Stream_Read_UINT16(s, cmd.destTop);
139
1.21k
  Stream_Read_UINT16(s, cmd.destRight);
140
1.21k
  Stream_Read_UINT16(s, cmd.destBottom);
141
142
1.21k
  if (!update_recv_surfcmd_is_rect_valid(update->context, &cmd))
143
229
    goto fail;
144
145
982
  if (!update_recv_surfcmd_bitmap_ex(s, &cmd.bmp))
146
216
    goto fail;
147
148
766
  if (!IFCALLRESULT(TRUE, update->SurfaceBits, update->context, &cmd))
149
65
  {
150
65
    WLog_DBG(TAG, "update->SurfaceBits implementation failed");
151
65
    goto fail;
152
65
  }
153
154
701
  rc = TRUE;
155
1.24k
fail:
156
1.24k
  return rc;
157
701
}
158
159
static BOOL update_recv_surfcmd_frame_marker(rdpUpdate* update, wStream* s)
160
138
{
161
138
  SURFACE_FRAME_MARKER marker = { 0 };
162
138
  rdp_update_internal* up = update_cast(update);
163
164
138
  WINPR_ASSERT(s);
165
166
138
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 2))
167
11
    return FALSE;
168
169
127
  Stream_Read_UINT16(s, marker.frameAction);
170
127
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 4))
171
43
    WLog_WARN(TAG,
172
127
              "[SERVER-BUG]: got %" PRIuz ", expected %" PRIuz
173
127
              " bytes. [MS-RDPBCGR] 2.2.9.2.3 Frame Marker Command (TS_FRAME_MARKER) is "
174
127
              "missing frameId, ignoring",
175
127
              Stream_GetRemainingLength(s), 4);
176
84
  else
177
84
    Stream_Read_UINT32(s, marker.frameId);
178
127
  WLog_Print(up->log, WLOG_DEBUG, "SurfaceFrameMarker: action: %s (%" PRIu32 ") id: %" PRIu32 "",
179
127
             (!marker.frameAction) ? "Begin" : "End", marker.frameAction, marker.frameId);
180
181
127
  if (!update->SurfaceFrameMarker)
182
59
  {
183
59
    WINPR_ASSERT(update->context);
184
59
    if (freerdp_settings_get_bool(update->context->settings, FreeRDP_DeactivateClientDecoding))
185
0
      return TRUE;
186
59
    WLog_ERR(TAG, "Missing callback update->SurfaceFrameMarker");
187
59
    return FALSE;
188
59
  }
189
190
68
  if (!update->SurfaceFrameMarker(update->context, &marker))
191
68
  {
192
68
    WLog_DBG(TAG, "update->SurfaceFrameMarker implementation failed");
193
68
    return FALSE;
194
68
  }
195
196
0
  return TRUE;
197
68
}
198
199
int update_recv_surfcmds(rdpUpdate* update, wStream* s)
200
22.8k
{
201
22.8k
  UINT16 cmdType = 0;
202
22.8k
  rdp_update_internal* up = update_cast(update);
203
204
22.8k
  WINPR_ASSERT(s);
205
206
23.5k
  while (Stream_GetRemainingLength(s) >= 2)
207
11.0k
  {
208
11.0k
    const size_t start = Stream_GetPosition(s);
209
11.0k
    const BYTE* mark = Stream_ConstPointer(s);
210
211
11.0k
    Stream_Read_UINT16(s, cmdType);
212
213
11.0k
    switch (cmdType)
214
11.0k
    {
215
425
      case CMDTYPE_SET_SURFACE_BITS:
216
1.24k
      case CMDTYPE_STREAM_SURFACE_BITS:
217
1.24k
        if (!update_recv_surfcmd_surface_bits(update, s, cmdType))
218
541
          return -1;
219
220
701
        break;
221
222
701
      case CMDTYPE_FRAME_MARKER:
223
138
        if (!update_recv_surfcmd_frame_marker(update, s))
224
138
          return -1;
225
226
0
        break;
227
228
9.68k
      default:
229
9.68k
        WLog_ERR(TAG, "unknown cmdType 0x%04" PRIX16 "", cmdType);
230
9.68k
        return -1;
231
11.0k
    }
232
233
701
    if (up->dump_rfx)
234
0
    {
235
0
      const size_t size = Stream_GetPosition(s) - start;
236
      /* TODO: treat return values */
237
0
      pcap_add_record(up->pcap_rfx, mark, size);
238
0
      pcap_flush(up->pcap_rfx);
239
0
    }
240
701
  }
241
242
12.4k
  return 0;
243
22.8k
}
244
245
static BOOL update_write_surfcmd_bitmap_header_ex(wStream* s,
246
                                                  const TS_COMPRESSED_BITMAP_HEADER_EX* header)
247
50
{
248
50
  if (!s || !header)
249
0
    return FALSE;
250
251
50
  if (!Stream_EnsureRemainingCapacity(s, 24))
252
0
    return FALSE;
253
254
50
  Stream_Write_UINT32(s, header->highUniqueId);
255
50
  Stream_Write_UINT32(s, header->lowUniqueId);
256
50
  Stream_Write_UINT64(s, header->tmMilliseconds);
257
50
  Stream_Write_UINT64(s, header->tmSeconds);
258
50
  return TRUE;
259
50
}
260
261
static BOOL update_write_surfcmd_bitmap_ex(wStream* s, const TS_BITMAP_DATA_EX* bmp)
262
65
{
263
65
  if (!s || !bmp)
264
0
    return FALSE;
265
266
65
  if (!Stream_EnsureRemainingCapacity(s, 12))
267
0
    return FALSE;
268
269
65
  if (bmp->codecID > UINT8_MAX)
270
0
  {
271
0
    WLog_ERR(TAG, "Invalid TS_BITMAP_DATA_EX::codecID=0x%04" PRIx16 "", bmp->codecID);
272
0
    return FALSE;
273
0
  }
274
65
  Stream_Write_UINT8(s, bmp->bpp);
275
65
  Stream_Write_UINT8(s, bmp->flags);
276
65
  Stream_Write_UINT8(s, 0); /* reserved1, reserved2 */
277
65
  Stream_Write_UINT8(s, (UINT8)bmp->codecID);
278
65
  Stream_Write_UINT16(s, bmp->width);
279
65
  Stream_Write_UINT16(s, bmp->height);
280
65
  Stream_Write_UINT32(s, bmp->bitmapDataLength);
281
282
65
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
283
50
  {
284
50
    if (!update_write_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
285
0
      return FALSE;
286
50
  }
287
288
65
  if (!Stream_EnsureRemainingCapacity(s, bmp->bitmapDataLength))
289
0
    return FALSE;
290
291
65
  Stream_Write(s, bmp->bitmapData, bmp->bitmapDataLength);
292
65
  return TRUE;
293
65
}
294
295
BOOL update_write_surfcmd_surface_bits(wStream* s, const SURFACE_BITS_COMMAND* cmd)
296
65
{
297
65
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_SURFACE_BITS_HEADER_LENGTH))
298
0
    return FALSE;
299
300
65
  WINPR_ASSERT(cmd->cmdType <= UINT16_MAX);
301
65
  UINT16 cmdType = (UINT16)cmd->cmdType;
302
65
  switch (cmdType)
303
65
  {
304
62
    case CMDTYPE_SET_SURFACE_BITS:
305
65
    case CMDTYPE_STREAM_SURFACE_BITS:
306
65
      break;
307
0
    default:
308
0
      WLog_WARN(TAG,
309
0
                "SURFACE_BITS_COMMAND->cmdType 0x%04" PRIx16
310
0
                " not allowed, correcting to 0x%04" PRIx16,
311
0
                cmdType, CMDTYPE_STREAM_SURFACE_BITS);
312
0
      cmdType = CMDTYPE_STREAM_SURFACE_BITS;
313
0
      break;
314
65
  }
315
316
65
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmdType));
317
65
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destLeft));
318
65
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destTop));
319
65
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destRight));
320
65
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destBottom));
321
65
  return update_write_surfcmd_bitmap_ex(s, &cmd->bmp);
322
65
}
323
324
BOOL update_write_surfcmd_frame_marker(wStream* s, UINT16 frameAction, UINT32 frameId)
325
68
{
326
68
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_FRAME_MARKER_LENGTH))
327
0
    return FALSE;
328
329
68
  Stream_Write_UINT16(s, CMDTYPE_FRAME_MARKER);
330
68
  Stream_Write_UINT16(s, frameAction);
331
68
  Stream_Write_UINT32(s, frameId);
332
68
  return TRUE;
333
68
}