Coverage Report

Created: 2025-08-26 06:37

/src/FreeRDP/libfreerdp/core/surface.c
Line
Count
Source (jump to first uncovered line)
1
/**
2
 * FreeRDP: A Remote Desktop Protocol Implementation
3
 * Surface Commands
4
 *
5
 * Copyright 2011 Vic Lee
6
 *
7
 * Licensed under the Apache License, Version 2.0 (the "License");
8
 * you may not use this file except in compliance with the License.
9
 * You may obtain a copy of the License at
10
 *
11
 *     http://www.apache.org/licenses/LICENSE-2.0
12
 *
13
 * Unless required by applicable law or agreed to in writing, software
14
 * distributed under the License is distributed on an "AS IS" BASIS,
15
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16
 * See the License for the specific language governing permissions and
17
 * limitations under the License.
18
 */
19
20
#include <freerdp/config.h>
21
22
#include "settings.h"
23
24
#include <winpr/assert.h>
25
#include <winpr/cast.h>
26
27
#include <freerdp/utils/pcap.h>
28
#include <freerdp/log.h>
29
30
#include "../cache/cache.h"
31
#include "surface.h"
32
33
#define TAG FREERDP_TAG("core.surface")
34
35
static BOOL update_recv_surfcmd_bitmap_header_ex(wStream* s, TS_COMPRESSED_BITMAP_HEADER_EX* header)
36
151
{
37
151
  if (!s || !header)
38
0
    return FALSE;
39
40
151
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 24))
41
14
    return FALSE;
42
43
137
  Stream_Read_UINT32(s, header->highUniqueId);
44
137
  Stream_Read_UINT32(s, header->lowUniqueId);
45
137
  Stream_Read_UINT64(s, header->tmMilliseconds);
46
137
  Stream_Read_UINT64(s, header->tmSeconds);
47
137
  return TRUE;
48
151
}
49
50
static BOOL update_recv_surfcmd_bitmap_ex(wStream* s, TS_BITMAP_DATA_EX* bmp)
51
754
{
52
754
  if (!s || !bmp)
53
0
    return FALSE;
54
55
754
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 12))
56
17
    return FALSE;
57
58
737
  Stream_Read_UINT8(s, bmp->bpp);
59
737
  Stream_Read_UINT8(s, bmp->flags);
60
737
  Stream_Seek(s, 1); /* reserved */
61
737
  Stream_Read_UINT8(s, bmp->codecID);
62
737
  Stream_Read_UINT16(s, bmp->width);
63
737
  Stream_Read_UINT16(s, bmp->height);
64
737
  Stream_Read_UINT32(s, bmp->bitmapDataLength);
65
66
737
  if ((bmp->width == 0) || (bmp->height == 0))
67
32
  {
68
32
    WLog_ERR(TAG, "invalid size value width=%" PRIu16 ", height=%" PRIu16, bmp->width,
69
32
             bmp->height);
70
32
    return FALSE;
71
32
  }
72
73
705
  if ((bmp->bpp < 1) || (bmp->bpp > 32))
74
30
  {
75
30
    WLog_ERR(TAG, "invalid bpp value %" PRIu32 "", bmp->bpp);
76
30
    return FALSE;
77
30
  }
78
79
675
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
80
151
  {
81
151
    if (!update_recv_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
82
14
      return FALSE;
83
151
  }
84
85
661
  bmp->bitmapData = Stream_Pointer(s);
86
661
  if (!Stream_SafeSeek(s, bmp->bitmapDataLength))
87
98
  {
88
98
    WLog_ERR(TAG, "expected bitmapDataLength %" PRIu32 ", not enough data",
89
98
             bmp->bitmapDataLength);
90
98
    return FALSE;
91
98
  }
92
563
  return TRUE;
93
661
}
94
95
static BOOL update_recv_surfcmd_is_rect_valid(const rdpContext* context,
96
                                              const SURFACE_BITS_COMMAND* cmd)
97
951
{
98
951
  WINPR_ASSERT(context);
99
951
  WINPR_ASSERT(context->settings);
100
951
  WINPR_ASSERT(cmd);
101
102
  /* We need a rectangle with left/top being smaller than right/bottom.
103
   * Also do not allow empty rectangles. */
104
951
  if ((cmd->destTop >= cmd->destBottom) || (cmd->destLeft >= cmd->destRight))
105
117
  {
106
117
    WLog_WARN(TAG,
107
117
              "Empty surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
108
117
              "x%" PRIu16,
109
117
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom);
110
117
    return FALSE;
111
117
  }
112
113
  /* The rectangle needs to fit into our session size */
114
834
  if ((cmd->destRight > context->settings->DesktopWidth) ||
115
834
      (cmd->destBottom > context->settings->DesktopHeight))
116
80
  {
117
80
    WLog_WARN(TAG,
118
80
              "Invalid surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
119
80
              "x%" PRIu16 " does not fit %" PRIu32 "x%" PRIu32,
120
80
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom,
121
80
              context->settings->DesktopWidth, context->settings->DesktopHeight);
122
80
    return FALSE;
123
80
  }
124
125
754
  return TRUE;
126
834
}
127
128
static BOOL update_recv_surfcmd_surface_bits(rdpUpdate* update, wStream* s, UINT16 cmdType)
129
973
{
130
973
  BOOL rc = FALSE;
131
973
  SURFACE_BITS_COMMAND cmd = { 0 };
132
133
973
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 8))
134
22
    goto fail;
135
136
951
  cmd.cmdType = cmdType;
137
951
  Stream_Read_UINT16(s, cmd.destLeft);
138
951
  Stream_Read_UINT16(s, cmd.destTop);
139
951
  Stream_Read_UINT16(s, cmd.destRight);
140
951
  Stream_Read_UINT16(s, cmd.destBottom);
141
142
951
  if (!update_recv_surfcmd_is_rect_valid(update->context, &cmd))
143
197
    goto fail;
144
145
754
  if (!update_recv_surfcmd_bitmap_ex(s, &cmd.bmp))
146
191
    goto fail;
147
148
563
  if (!IFCALLRESULT(TRUE, update->SurfaceBits, update->context, &cmd))
149
67
  {
150
67
    WLog_DBG(TAG, "update->SurfaceBits implementation failed");
151
67
    goto fail;
152
67
  }
153
154
496
  rc = TRUE;
155
973
fail:
156
973
  return rc;
157
496
}
158
159
static BOOL update_recv_surfcmd_frame_marker(rdpUpdate* update, wStream* s)
160
166
{
161
166
  SURFACE_FRAME_MARKER marker = { 0 };
162
166
  rdp_update_internal* up = update_cast(update);
163
164
166
  WINPR_ASSERT(s);
165
166
166
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 2))
167
16
    return FALSE;
168
169
150
  Stream_Read_UINT16(s, marker.frameAction);
170
150
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 4))
171
33
    WLog_WARN(TAG,
172
150
              "[SERVER-BUG]: got %" PRIuz ", expected %" PRIuz
173
150
              " bytes. [MS-RDPBCGR] 2.2.9.2.3 Frame Marker Command (TS_FRAME_MARKER) is "
174
150
              "missing frameId, ignoring",
175
150
              Stream_GetRemainingLength(s), 4);
176
117
  else
177
117
    Stream_Read_UINT32(s, marker.frameId);
178
150
  WLog_Print(up->log, WLOG_DEBUG, "SurfaceFrameMarker: action: %s (%" PRIu32 ") id: %" PRIu32 "",
179
150
             (!marker.frameAction) ? "Begin" : "End", marker.frameAction, marker.frameId);
180
181
150
  if (!update->SurfaceFrameMarker)
182
59
  {
183
59
    WINPR_ASSERT(update->context);
184
59
    if (freerdp_settings_get_bool(update->context->settings, FreeRDP_DeactivateClientDecoding))
185
0
      return TRUE;
186
59
    WLog_ERR(TAG, "Missing callback update->SurfaceFrameMarker");
187
59
    return FALSE;
188
59
  }
189
190
91
  if (!update->SurfaceFrameMarker(update->context, &marker))
191
91
  {
192
91
    WLog_DBG(TAG, "update->SurfaceFrameMarker implementation failed");
193
91
    return FALSE;
194
91
  }
195
196
0
  return TRUE;
197
91
}
198
199
int update_recv_surfcmds(rdpUpdate* update, wStream* s)
200
23.6k
{
201
23.6k
  UINT16 cmdType = 0;
202
23.6k
  rdp_update_internal* up = update_cast(update);
203
204
23.6k
  WINPR_ASSERT(s);
205
206
24.1k
  while (Stream_GetRemainingLength(s) >= 2)
207
10.9k
  {
208
10.9k
    const size_t start = Stream_GetPosition(s);
209
10.9k
    const BYTE* mark = Stream_ConstPointer(s);
210
211
10.9k
    Stream_Read_UINT16(s, cmdType);
212
213
10.9k
    switch (cmdType)
214
10.9k
    {
215
397
      case CMDTYPE_SET_SURFACE_BITS:
216
973
      case CMDTYPE_STREAM_SURFACE_BITS:
217
973
        if (!update_recv_surfcmd_surface_bits(update, s, cmdType))
218
477
          return -1;
219
220
496
        break;
221
222
496
      case CMDTYPE_FRAME_MARKER:
223
166
        if (!update_recv_surfcmd_frame_marker(update, s))
224
166
          return -1;
225
226
0
        break;
227
228
9.76k
      default:
229
9.76k
        WLog_ERR(TAG, "unknown cmdType 0x%04" PRIX16 "", cmdType);
230
9.76k
        return -1;
231
10.9k
    }
232
233
496
    if (up->dump_rfx)
234
0
    {
235
0
      const size_t size = Stream_GetPosition(s) - start;
236
      /* TODO: treat return values */
237
0
      pcap_add_record(up->pcap_rfx, mark, size);
238
0
      pcap_flush(up->pcap_rfx);
239
0
    }
240
496
  }
241
242
13.2k
  return 0;
243
23.6k
}
244
245
static BOOL update_write_surfcmd_bitmap_header_ex(wStream* s,
246
                                                  const TS_COMPRESSED_BITMAP_HEADER_EX* header)
247
42
{
248
42
  if (!s || !header)
249
0
    return FALSE;
250
251
42
  if (!Stream_EnsureRemainingCapacity(s, 24))
252
0
    return FALSE;
253
254
42
  Stream_Write_UINT32(s, header->highUniqueId);
255
42
  Stream_Write_UINT32(s, header->lowUniqueId);
256
42
  Stream_Write_UINT64(s, header->tmMilliseconds);
257
42
  Stream_Write_UINT64(s, header->tmSeconds);
258
42
  return TRUE;
259
42
}
260
261
static BOOL update_write_surfcmd_bitmap_ex(wStream* s, const TS_BITMAP_DATA_EX* bmp)
262
67
{
263
67
  if (!s || !bmp)
264
0
    return FALSE;
265
266
67
  if (!Stream_EnsureRemainingCapacity(s, 12))
267
0
    return FALSE;
268
269
67
  if (bmp->codecID > UINT8_MAX)
270
0
  {
271
0
    WLog_ERR(TAG, "Invalid TS_BITMAP_DATA_EX::codecID=0x%04" PRIx16 "", bmp->codecID);
272
0
    return FALSE;
273
0
  }
274
67
  Stream_Write_UINT8(s, bmp->bpp);
275
67
  Stream_Write_UINT8(s, bmp->flags);
276
67
  Stream_Write_UINT8(s, 0); /* reserved1, reserved2 */
277
67
  Stream_Write_UINT8(s, (UINT8)bmp->codecID);
278
67
  Stream_Write_UINT16(s, bmp->width);
279
67
  Stream_Write_UINT16(s, bmp->height);
280
67
  Stream_Write_UINT32(s, bmp->bitmapDataLength);
281
282
67
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
283
42
  {
284
42
    if (!update_write_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
285
0
      return FALSE;
286
42
  }
287
288
67
  if (!Stream_EnsureRemainingCapacity(s, bmp->bitmapDataLength))
289
0
    return FALSE;
290
291
67
  Stream_Write(s, bmp->bitmapData, bmp->bitmapDataLength);
292
67
  return TRUE;
293
67
}
294
295
BOOL update_write_surfcmd_surface_bits(wStream* s, const SURFACE_BITS_COMMAND* cmd)
296
67
{
297
67
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_SURFACE_BITS_HEADER_LENGTH))
298
0
    return FALSE;
299
300
67
  WINPR_ASSERT(cmd->cmdType <= UINT16_MAX);
301
67
  UINT16 cmdType = (UINT16)cmd->cmdType;
302
67
  switch (cmdType)
303
67
  {
304
63
    case CMDTYPE_SET_SURFACE_BITS:
305
67
    case CMDTYPE_STREAM_SURFACE_BITS:
306
67
      break;
307
0
    default:
308
0
      WLog_WARN(TAG,
309
0
                "SURFACE_BITS_COMMAND->cmdType 0x%04" PRIx16
310
0
                " not allowed, correcting to 0x%04" PRIx16,
311
0
                cmdType, CMDTYPE_STREAM_SURFACE_BITS);
312
0
      cmdType = CMDTYPE_STREAM_SURFACE_BITS;
313
0
      break;
314
67
  }
315
316
67
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmdType));
317
67
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destLeft));
318
67
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destTop));
319
67
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destRight));
320
67
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destBottom));
321
67
  return update_write_surfcmd_bitmap_ex(s, &cmd->bmp);
322
67
}
323
324
BOOL update_write_surfcmd_frame_marker(wStream* s, UINT16 frameAction, UINT32 frameId)
325
91
{
326
91
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_FRAME_MARKER_LENGTH))
327
0
    return FALSE;
328
329
91
  Stream_Write_UINT16(s, CMDTYPE_FRAME_MARKER);
330
91
  Stream_Write_UINT16(s, frameAction);
331
91
  Stream_Write_UINT32(s, frameId);
332
91
  return TRUE;
333
91
}