Coverage Report

Created: 2025-11-24 06:38

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/FreeRDP/libfreerdp/core/surface.c
Line
Count
Source
1
/**
2
 * FreeRDP: A Remote Desktop Protocol Implementation
3
 * Surface Commands
4
 *
5
 * Copyright 2011 Vic Lee
6
 *
7
 * Licensed under the Apache License, Version 2.0 (the "License");
8
 * you may not use this file except in compliance with the License.
9
 * You may obtain a copy of the License at
10
 *
11
 *     http://www.apache.org/licenses/LICENSE-2.0
12
 *
13
 * Unless required by applicable law or agreed to in writing, software
14
 * distributed under the License is distributed on an "AS IS" BASIS,
15
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16
 * See the License for the specific language governing permissions and
17
 * limitations under the License.
18
 */
19
20
#include <freerdp/config.h>
21
22
#include "settings.h"
23
24
#include <winpr/assert.h>
25
#include <winpr/cast.h>
26
27
#include <freerdp/utils/pcap.h>
28
#include <freerdp/log.h>
29
30
#include "../cache/cache.h"
31
#include "surface.h"
32
33
#define TAG FREERDP_TAG("core.surface")
34
35
static BOOL update_recv_surfcmd_bitmap_header_ex(wStream* s, TS_COMPRESSED_BITMAP_HEADER_EX* header)
36
189
{
37
189
  if (!s || !header)
38
0
    return FALSE;
39
40
189
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 24))
41
10
    return FALSE;
42
43
179
  Stream_Read_UINT32(s, header->highUniqueId);
44
179
  Stream_Read_UINT32(s, header->lowUniqueId);
45
179
  Stream_Read_UINT64(s, header->tmMilliseconds);
46
179
  Stream_Read_UINT64(s, header->tmSeconds);
47
179
  return TRUE;
48
189
}
49
50
static BOOL update_recv_surfcmd_bitmap_ex(wStream* s, TS_BITMAP_DATA_EX* bmp)
51
566
{
52
566
  if (!s || !bmp)
53
0
    return FALSE;
54
55
566
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 12))
56
10
    return FALSE;
57
58
556
  Stream_Read_UINT8(s, bmp->bpp);
59
556
  Stream_Read_UINT8(s, bmp->flags);
60
556
  Stream_Seek(s, 1); /* reserved */
61
556
  Stream_Read_UINT8(s, bmp->codecID);
62
556
  Stream_Read_UINT16(s, bmp->width);
63
556
  Stream_Read_UINT16(s, bmp->height);
64
556
  Stream_Read_UINT32(s, bmp->bitmapDataLength);
65
66
556
  if ((bmp->width == 0) || (bmp->height == 0))
67
35
  {
68
35
    WLog_ERR(TAG, "invalid size value width=%" PRIu16 ", height=%" PRIu16, bmp->width,
69
35
             bmp->height);
70
35
    return FALSE;
71
35
  }
72
73
521
  if ((bmp->bpp < 1) || (bmp->bpp > 32))
74
33
  {
75
33
    WLog_ERR(TAG, "invalid bpp value %" PRIu32 "", bmp->bpp);
76
33
    return FALSE;
77
33
  }
78
79
488
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
80
189
  {
81
189
    if (!update_recv_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
82
10
      return FALSE;
83
189
  }
84
85
478
  bmp->bitmapData = Stream_Pointer(s);
86
478
  if (!Stream_SafeSeek(s, bmp->bitmapDataLength))
87
127
  {
88
127
    WLog_ERR(TAG, "expected bitmapDataLength %" PRIu32 ", not enough data",
89
127
             bmp->bitmapDataLength);
90
127
    return FALSE;
91
127
  }
92
351
  return TRUE;
93
478
}
94
95
static BOOL update_recv_surfcmd_is_rect_valid(const rdpContext* context,
96
                                              const SURFACE_BITS_COMMAND* cmd)
97
751
{
98
751
  WINPR_ASSERT(context);
99
751
  WINPR_ASSERT(context->settings);
100
751
  WINPR_ASSERT(cmd);
101
102
  /* We need a rectangle with left/top being smaller than right/bottom.
103
   * Also do not allow empty rectangles. */
104
751
  if ((cmd->destTop >= cmd->destBottom) || (cmd->destLeft >= cmd->destRight))
105
111
  {
106
111
    WLog_WARN(TAG,
107
111
              "Empty surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
108
111
              "x%" PRIu16,
109
111
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom);
110
111
    return FALSE;
111
111
  }
112
113
  /* The rectangle needs to fit into our session size */
114
640
  if ((cmd->destRight > context->settings->DesktopWidth) ||
115
580
      (cmd->destBottom > context->settings->DesktopHeight))
116
74
  {
117
74
    WLog_WARN(TAG,
118
74
              "Invalid surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
119
74
              "x%" PRIu16 " does not fit %" PRIu32 "x%" PRIu32,
120
74
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom,
121
74
              context->settings->DesktopWidth, context->settings->DesktopHeight);
122
74
    return FALSE;
123
74
  }
124
125
566
  return TRUE;
126
640
}
127
128
static BOOL update_recv_surfcmd_surface_bits(rdpUpdate* update, wStream* s, UINT16 cmdType)
129
773
{
130
773
  BOOL rc = FALSE;
131
773
  SURFACE_BITS_COMMAND cmd = { 0 };
132
133
773
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 8))
134
22
    goto fail;
135
136
751
  cmd.cmdType = cmdType;
137
751
  Stream_Read_UINT16(s, cmd.destLeft);
138
751
  Stream_Read_UINT16(s, cmd.destTop);
139
751
  Stream_Read_UINT16(s, cmd.destRight);
140
751
  Stream_Read_UINT16(s, cmd.destBottom);
141
142
751
  if (!update_recv_surfcmd_is_rect_valid(update->context, &cmd))
143
185
    goto fail;
144
145
566
  if (!update_recv_surfcmd_bitmap_ex(s, &cmd.bmp))
146
215
    goto fail;
147
148
351
  if (!IFCALLRESULT(TRUE, update->SurfaceBits, update->context, &cmd))
149
88
  {
150
88
    WLog_DBG(TAG, "update->SurfaceBits implementation failed");
151
88
    goto fail;
152
88
  }
153
154
263
  rc = TRUE;
155
773
fail:
156
773
  return rc;
157
263
}
158
159
static BOOL update_recv_surfcmd_frame_marker(rdpUpdate* update, wStream* s)
160
120
{
161
120
  SURFACE_FRAME_MARKER marker = { 0 };
162
120
  rdp_update_internal* up = update_cast(update);
163
164
120
  WINPR_ASSERT(s);
165
166
120
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 2))
167
10
    return FALSE;
168
169
110
  Stream_Read_UINT16(s, marker.frameAction);
170
110
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 4))
171
22
    WLog_WARN(TAG,
172
110
              "[SERVER-BUG]: got %" PRIuz ", expected %" PRIuz
173
110
              " bytes. [MS-RDPBCGR] 2.2.9.2.3 Frame Marker Command (TS_FRAME_MARKER) is "
174
110
              "missing frameId, ignoring",
175
110
              Stream_GetRemainingLength(s), 4);
176
88
  else
177
88
    Stream_Read_UINT32(s, marker.frameId);
178
110
  WLog_Print(up->log, WLOG_DEBUG, "SurfaceFrameMarker: action: %s (%" PRIu32 ") id: %" PRIu32 "",
179
110
             (!marker.frameAction) ? "Begin" : "End", marker.frameAction, marker.frameId);
180
181
110
  if (!update->SurfaceFrameMarker)
182
58
  {
183
58
    WINPR_ASSERT(update->context);
184
58
    if (freerdp_settings_get_bool(update->context->settings, FreeRDP_DeactivateClientDecoding))
185
0
      return TRUE;
186
58
    WLog_ERR(TAG, "Missing callback update->SurfaceFrameMarker");
187
58
    return FALSE;
188
58
  }
189
190
52
  if (!update->SurfaceFrameMarker(update->context, &marker))
191
52
  {
192
52
    WLog_DBG(TAG, "update->SurfaceFrameMarker implementation failed");
193
52
    return FALSE;
194
52
  }
195
196
0
  return TRUE;
197
52
}
198
199
int update_recv_surfcmds(rdpUpdate* update, wStream* s)
200
22.3k
{
201
22.3k
  UINT16 cmdType = 0;
202
22.3k
  rdp_update_internal* up = update_cast(update);
203
204
22.3k
  WINPR_ASSERT(s);
205
206
22.6k
  while (Stream_GetRemainingLength(s) >= 2)
207
10.4k
  {
208
10.4k
    const size_t start = Stream_GetPosition(s);
209
10.4k
    const BYTE* mark = Stream_ConstPointer(s);
210
211
10.4k
    Stream_Read_UINT16(s, cmdType);
212
213
10.4k
    switch (cmdType)
214
10.4k
    {
215
454
      case CMDTYPE_SET_SURFACE_BITS:
216
773
      case CMDTYPE_STREAM_SURFACE_BITS:
217
773
        if (!update_recv_surfcmd_surface_bits(update, s, cmdType))
218
510
          return -1;
219
220
263
        break;
221
222
263
      case CMDTYPE_FRAME_MARKER:
223
120
        if (!update_recv_surfcmd_frame_marker(update, s))
224
120
          return -1;
225
226
0
        break;
227
228
9.57k
      default:
229
9.57k
        WLog_ERR(TAG, "unknown cmdType 0x%04" PRIX16 "", cmdType);
230
9.57k
        return -1;
231
10.4k
    }
232
233
263
    if (up->dump_rfx)
234
0
    {
235
0
      const size_t size = Stream_GetPosition(s) - start;
236
      /* TODO: treat return values */
237
0
      pcap_add_record(up->pcap_rfx, mark, size);
238
0
      pcap_flush(up->pcap_rfx);
239
0
    }
240
263
  }
241
242
12.1k
  return 0;
243
22.3k
}
244
245
static BOOL update_write_surfcmd_bitmap_header_ex(wStream* s,
246
                                                  const TS_COMPRESSED_BITMAP_HEADER_EX* header)
247
73
{
248
73
  if (!s || !header)
249
0
    return FALSE;
250
251
73
  if (!Stream_EnsureRemainingCapacity(s, 24))
252
0
    return FALSE;
253
254
73
  Stream_Write_UINT32(s, header->highUniqueId);
255
73
  Stream_Write_UINT32(s, header->lowUniqueId);
256
73
  Stream_Write_UINT64(s, header->tmMilliseconds);
257
73
  Stream_Write_UINT64(s, header->tmSeconds);
258
73
  return TRUE;
259
73
}
260
261
static BOOL update_write_surfcmd_bitmap_ex(wStream* s, const TS_BITMAP_DATA_EX* bmp)
262
88
{
263
88
  if (!s || !bmp)
264
0
    return FALSE;
265
266
88
  if (!Stream_EnsureRemainingCapacity(s, 12))
267
0
    return FALSE;
268
269
88
  if (bmp->codecID > UINT8_MAX)
270
0
  {
271
0
    WLog_ERR(TAG, "Invalid TS_BITMAP_DATA_EX::codecID=0x%04" PRIx16 "", bmp->codecID);
272
0
    return FALSE;
273
0
  }
274
88
  Stream_Write_UINT8(s, bmp->bpp);
275
88
  Stream_Write_UINT8(s, bmp->flags);
276
88
  Stream_Write_UINT8(s, 0); /* reserved1, reserved2 */
277
88
  Stream_Write_UINT8(s, (UINT8)bmp->codecID);
278
88
  Stream_Write_UINT16(s, bmp->width);
279
88
  Stream_Write_UINT16(s, bmp->height);
280
88
  Stream_Write_UINT32(s, bmp->bitmapDataLength);
281
282
88
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
283
73
  {
284
73
    if (!update_write_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
285
0
      return FALSE;
286
73
  }
287
288
88
  if (!Stream_EnsureRemainingCapacity(s, bmp->bitmapDataLength))
289
0
    return FALSE;
290
291
88
  Stream_Write(s, bmp->bitmapData, bmp->bitmapDataLength);
292
88
  return TRUE;
293
88
}
294
295
BOOL update_write_surfcmd_surface_bits(wStream* s, const SURFACE_BITS_COMMAND* cmd)
296
88
{
297
88
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_SURFACE_BITS_HEADER_LENGTH))
298
0
    return FALSE;
299
300
88
  WINPR_ASSERT(cmd->cmdType <= UINT16_MAX);
301
88
  UINT16 cmdType = (UINT16)cmd->cmdType;
302
88
  switch (cmdType)
303
88
  {
304
86
    case CMDTYPE_SET_SURFACE_BITS:
305
88
    case CMDTYPE_STREAM_SURFACE_BITS:
306
88
      break;
307
0
    default:
308
0
      WLog_WARN(TAG,
309
0
                "SURFACE_BITS_COMMAND->cmdType 0x%04" PRIx16
310
0
                " not allowed, correcting to 0x%04" PRIx16,
311
0
                cmdType, CMDTYPE_STREAM_SURFACE_BITS);
312
0
      cmdType = CMDTYPE_STREAM_SURFACE_BITS;
313
0
      break;
314
88
  }
315
316
88
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmdType));
317
88
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destLeft));
318
88
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destTop));
319
88
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destRight));
320
88
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destBottom));
321
88
  return update_write_surfcmd_bitmap_ex(s, &cmd->bmp);
322
88
}
323
324
BOOL update_write_surfcmd_frame_marker(wStream* s, UINT16 frameAction, UINT32 frameId)
325
52
{
326
52
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_FRAME_MARKER_LENGTH))
327
0
    return FALSE;
328
329
52
  Stream_Write_UINT16(s, CMDTYPE_FRAME_MARKER);
330
52
  Stream_Write_UINT16(s, frameAction);
331
52
  Stream_Write_UINT32(s, frameId);
332
52
  return TRUE;
333
52
}