Coverage Report

Created: 2026-01-16 07:10

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/FreeRDP/libfreerdp/core/surface.c
Line
Count
Source
1
/**
2
 * FreeRDP: A Remote Desktop Protocol Implementation
3
 * Surface Commands
4
 *
5
 * Copyright 2011 Vic Lee
6
 *
7
 * Licensed under the Apache License, Version 2.0 (the "License");
8
 * you may not use this file except in compliance with the License.
9
 * You may obtain a copy of the License at
10
 *
11
 *     http://www.apache.org/licenses/LICENSE-2.0
12
 *
13
 * Unless required by applicable law or agreed to in writing, software
14
 * distributed under the License is distributed on an "AS IS" BASIS,
15
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16
 * See the License for the specific language governing permissions and
17
 * limitations under the License.
18
 */
19
20
#include <freerdp/config.h>
21
22
#include "settings.h"
23
24
#include <winpr/assert.h>
25
#include <winpr/cast.h>
26
27
#include <freerdp/utils/pcap.h>
28
#include <freerdp/log.h>
29
30
#include "../cache/cache.h"
31
#include "surface.h"
32
33
#define TAG FREERDP_TAG("core.surface")
34
35
static BOOL update_recv_surfcmd_bitmap_header_ex(wStream* s, TS_COMPRESSED_BITMAP_HEADER_EX* header)
36
188
{
37
188
  if (!s || !header)
38
0
    return FALSE;
39
40
188
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 24))
41
10
    return FALSE;
42
43
178
  Stream_Read_UINT32(s, header->highUniqueId);
44
178
  Stream_Read_UINT32(s, header->lowUniqueId);
45
178
  Stream_Read_UINT64(s, header->tmMilliseconds);
46
178
  Stream_Read_UINT64(s, header->tmSeconds);
47
178
  return TRUE;
48
188
}
49
50
static BOOL update_recv_surfcmd_bitmap_ex(wStream* s, TS_BITMAP_DATA_EX* bmp)
51
879
{
52
879
  if (!s || !bmp)
53
0
    return FALSE;
54
55
879
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 12))
56
13
    return FALSE;
57
58
866
  Stream_Read_UINT8(s, bmp->bpp);
59
866
  Stream_Read_UINT8(s, bmp->flags);
60
866
  Stream_Seek(s, 1); /* reserved */
61
866
  Stream_Read_UINT8(s, bmp->codecID);
62
866
  Stream_Read_UINT16(s, bmp->width);
63
866
  Stream_Read_UINT16(s, bmp->height);
64
866
  Stream_Read_UINT32(s, bmp->bitmapDataLength);
65
66
866
  if ((bmp->width == 0) || (bmp->height == 0))
67
34
  {
68
34
    WLog_ERR(TAG, "invalid size value width=%" PRIu16 ", height=%" PRIu16, bmp->width,
69
34
             bmp->height);
70
34
    return FALSE;
71
34
  }
72
73
832
  if ((bmp->bpp < 1) || (bmp->bpp > 32))
74
28
  {
75
28
    WLog_ERR(TAG, "invalid bpp value %" PRIu32 "", bmp->bpp);
76
28
    return FALSE;
77
28
  }
78
79
804
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
80
188
  {
81
188
    if (!update_recv_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
82
10
      return FALSE;
83
188
  }
84
85
794
  bmp->bitmapData = Stream_Pointer(s);
86
794
  if (!Stream_SafeSeek(s, bmp->bitmapDataLength))
87
104
  {
88
104
    WLog_ERR(TAG, "expected bitmapDataLength %" PRIu32 ", not enough data",
89
104
             bmp->bitmapDataLength);
90
104
    return FALSE;
91
104
  }
92
690
  return TRUE;
93
794
}
94
95
static BOOL update_recv_surfcmd_is_rect_valid(const rdpContext* context,
96
                                              const SURFACE_BITS_COMMAND* cmd)
97
1.09k
{
98
1.09k
  WINPR_ASSERT(context);
99
1.09k
  WINPR_ASSERT(context->settings);
100
1.09k
  WINPR_ASSERT(cmd);
101
102
  /* We need a rectangle with left/top being smaller than right/bottom.
103
   * Also do not allow empty rectangles. */
104
1.09k
  if ((cmd->destTop >= cmd->destBottom) || (cmd->destLeft >= cmd->destRight))
105
145
  {
106
145
    WLog_WARN(TAG,
107
145
              "Empty surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
108
145
              "x%" PRIu16,
109
145
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom);
110
145
    return FALSE;
111
145
  }
112
113
  /* The rectangle needs to fit into our session size */
114
949
  if ((cmd->destRight > context->settings->DesktopWidth) ||
115
886
      (cmd->destBottom > context->settings->DesktopHeight))
116
70
  {
117
70
    WLog_WARN(TAG,
118
70
              "Invalid surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
119
70
              "x%" PRIu16 " does not fit %" PRIu32 "x%" PRIu32,
120
70
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom,
121
70
              context->settings->DesktopWidth, context->settings->DesktopHeight);
122
70
    return FALSE;
123
70
  }
124
125
879
  return TRUE;
126
949
}
127
128
static BOOL update_recv_surfcmd_surface_bits(rdpUpdate* update, wStream* s, UINT16 cmdType)
129
1.12k
{
130
1.12k
  BOOL rc = FALSE;
131
1.12k
  SURFACE_BITS_COMMAND cmd = { 0 };
132
133
1.12k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 8))
134
28
    goto fail;
135
136
1.09k
  cmd.cmdType = cmdType;
137
1.09k
  Stream_Read_UINT16(s, cmd.destLeft);
138
1.09k
  Stream_Read_UINT16(s, cmd.destTop);
139
1.09k
  Stream_Read_UINT16(s, cmd.destRight);
140
1.09k
  Stream_Read_UINT16(s, cmd.destBottom);
141
142
1.09k
  if (!update_recv_surfcmd_is_rect_valid(update->context, &cmd))
143
215
    goto fail;
144
145
879
  if (!update_recv_surfcmd_bitmap_ex(s, &cmd.bmp))
146
189
    goto fail;
147
148
690
  if (!IFCALLRESULT(TRUE, update->SurfaceBits, update->context, &cmd))
149
90
  {
150
90
    WLog_DBG(TAG, "update->SurfaceBits implementation failed");
151
90
    goto fail;
152
90
  }
153
154
600
  rc = TRUE;
155
1.12k
fail:
156
1.12k
  return rc;
157
600
}
158
159
static BOOL update_recv_surfcmd_frame_marker(rdpUpdate* update, wStream* s)
160
88
{
161
88
  SURFACE_FRAME_MARKER marker = { 0 };
162
88
  rdp_update_internal* up = update_cast(update);
163
164
88
  WINPR_ASSERT(s);
165
166
88
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 2))
167
10
    return FALSE;
168
169
78
  Stream_Read_UINT16(s, marker.frameAction);
170
78
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 4))
171
27
    WLog_WARN(TAG,
172
78
              "[SERVER-BUG]: got %" PRIuz ", expected %" PRIuz
173
78
              " bytes. [MS-RDPBCGR] 2.2.9.2.3 Frame Marker Command (TS_FRAME_MARKER) is "
174
78
              "missing frameId, ignoring",
175
78
              Stream_GetRemainingLength(s), 4);
176
51
  else
177
51
    Stream_Read_UINT32(s, marker.frameId);
178
78
  WLog_Print(up->log, WLOG_DEBUG, "SurfaceFrameMarker: action: %s (%" PRIu32 ") id: %" PRIu32 "",
179
78
             (!marker.frameAction) ? "Begin" : "End", marker.frameAction, marker.frameId);
180
181
78
  if (!update->SurfaceFrameMarker)
182
32
  {
183
32
    WINPR_ASSERT(update->context);
184
32
    if (freerdp_settings_get_bool(update->context->settings, FreeRDP_DeactivateClientDecoding))
185
0
      return TRUE;
186
32
    WLog_ERR(TAG, "Missing callback update->SurfaceFrameMarker");
187
32
    return FALSE;
188
32
  }
189
190
46
  if (!update->SurfaceFrameMarker(update->context, &marker))
191
46
  {
192
46
    WLog_DBG(TAG, "update->SurfaceFrameMarker implementation failed");
193
46
    return FALSE;
194
46
  }
195
196
0
  return TRUE;
197
46
}
198
199
int update_recv_surfcmds(rdpUpdate* update, wStream* s)
200
21.4k
{
201
21.4k
  UINT16 cmdType = 0;
202
21.4k
  rdp_update_internal* up = update_cast(update);
203
204
21.4k
  WINPR_ASSERT(s);
205
206
22.0k
  while (Stream_GetRemainingLength(s) >= 2)
207
9.60k
  {
208
9.60k
    const size_t start = Stream_GetPosition(s);
209
9.60k
    const BYTE* mark = Stream_ConstPointer(s);
210
211
9.60k
    Stream_Read_UINT16(s, cmdType);
212
213
9.60k
    switch (cmdType)
214
9.60k
    {
215
468
      case CMDTYPE_SET_SURFACE_BITS:
216
1.12k
      case CMDTYPE_STREAM_SURFACE_BITS:
217
1.12k
        if (!update_recv_surfcmd_surface_bits(update, s, cmdType))
218
522
          return -1;
219
220
600
        break;
221
222
600
      case CMDTYPE_FRAME_MARKER:
223
88
        if (!update_recv_surfcmd_frame_marker(update, s))
224
88
          return -1;
225
226
0
        break;
227
228
8.39k
      default:
229
8.39k
        WLog_ERR(TAG, "unknown cmdType 0x%04" PRIX16 "", cmdType);
230
8.39k
        return -1;
231
9.60k
    }
232
233
600
    if (up->dump_rfx)
234
0
    {
235
0
      const size_t size = Stream_GetPosition(s) - start;
236
      /* TODO: treat return values */
237
0
      pcap_add_record(up->pcap_rfx, mark, size);
238
0
      pcap_flush(up->pcap_rfx);
239
0
    }
240
600
  }
241
242
12.4k
  return 0;
243
21.4k
}
244
245
static BOOL update_write_surfcmd_bitmap_header_ex(wStream* s,
246
                                                  const TS_COMPRESSED_BITMAP_HEADER_EX* header)
247
66
{
248
66
  if (!s || !header)
249
0
    return FALSE;
250
251
66
  if (!Stream_EnsureRemainingCapacity(s, 24))
252
0
    return FALSE;
253
254
66
  Stream_Write_UINT32(s, header->highUniqueId);
255
66
  Stream_Write_UINT32(s, header->lowUniqueId);
256
66
  Stream_Write_UINT64(s, header->tmMilliseconds);
257
66
  Stream_Write_UINT64(s, header->tmSeconds);
258
66
  return TRUE;
259
66
}
260
261
static BOOL update_write_surfcmd_bitmap_ex(wStream* s, const TS_BITMAP_DATA_EX* bmp)
262
90
{
263
90
  if (!s || !bmp)
264
0
    return FALSE;
265
266
90
  if (!Stream_EnsureRemainingCapacity(s, 12))
267
0
    return FALSE;
268
269
90
  if (bmp->codecID > UINT8_MAX)
270
0
  {
271
0
    WLog_ERR(TAG, "Invalid TS_BITMAP_DATA_EX::codecID=0x%04" PRIx16 "", bmp->codecID);
272
0
    return FALSE;
273
0
  }
274
90
  Stream_Write_UINT8(s, bmp->bpp);
275
90
  Stream_Write_UINT8(s, bmp->flags);
276
90
  Stream_Write_UINT8(s, 0); /* reserved1, reserved2 */
277
90
  Stream_Write_UINT8(s, (UINT8)bmp->codecID);
278
90
  Stream_Write_UINT16(s, bmp->width);
279
90
  Stream_Write_UINT16(s, bmp->height);
280
90
  Stream_Write_UINT32(s, bmp->bitmapDataLength);
281
282
90
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
283
66
  {
284
66
    if (!update_write_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
285
0
      return FALSE;
286
66
  }
287
288
90
  if (!Stream_EnsureRemainingCapacity(s, bmp->bitmapDataLength))
289
0
    return FALSE;
290
291
90
  Stream_Write(s, bmp->bitmapData, bmp->bitmapDataLength);
292
90
  return TRUE;
293
90
}
294
295
BOOL update_write_surfcmd_surface_bits(wStream* s, const SURFACE_BITS_COMMAND* cmd)
296
90
{
297
90
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_SURFACE_BITS_HEADER_LENGTH))
298
0
    return FALSE;
299
300
90
  WINPR_ASSERT(cmd->cmdType <= UINT16_MAX);
301
90
  UINT16 cmdType = (UINT16)cmd->cmdType;
302
90
  switch (cmdType)
303
90
  {
304
87
    case CMDTYPE_SET_SURFACE_BITS:
305
90
    case CMDTYPE_STREAM_SURFACE_BITS:
306
90
      break;
307
0
    default:
308
0
      WLog_WARN(TAG,
309
0
                "SURFACE_BITS_COMMAND->cmdType 0x%04" PRIx16
310
0
                " not allowed, correcting to 0x%04" PRIx16,
311
0
                cmdType, CMDTYPE_STREAM_SURFACE_BITS);
312
0
      cmdType = CMDTYPE_STREAM_SURFACE_BITS;
313
0
      break;
314
90
  }
315
316
90
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmdType));
317
90
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destLeft));
318
90
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destTop));
319
90
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destRight));
320
90
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destBottom));
321
90
  return update_write_surfcmd_bitmap_ex(s, &cmd->bmp);
322
90
}
323
324
BOOL update_write_surfcmd_frame_marker(wStream* s, UINT16 frameAction, UINT32 frameId)
325
46
{
326
46
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_FRAME_MARKER_LENGTH))
327
0
    return FALSE;
328
329
46
  Stream_Write_UINT16(s, CMDTYPE_FRAME_MARKER);
330
46
  Stream_Write_UINT16(s, frameAction);
331
46
  Stream_Write_UINT32(s, frameId);
332
46
  return TRUE;
333
46
}