Coverage Report

Created: 2026-03-04 06:17

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/FreeRDP/libfreerdp/core/surface.c
Line
Count
Source
1
/**
2
 * FreeRDP: A Remote Desktop Protocol Implementation
3
 * Surface Commands
4
 *
5
 * Copyright 2011 Vic Lee
6
 *
7
 * Licensed under the Apache License, Version 2.0 (the "License");
8
 * you may not use this file except in compliance with the License.
9
 * You may obtain a copy of the License at
10
 *
11
 *     http://www.apache.org/licenses/LICENSE-2.0
12
 *
13
 * Unless required by applicable law or agreed to in writing, software
14
 * distributed under the License is distributed on an "AS IS" BASIS,
15
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16
 * See the License for the specific language governing permissions and
17
 * limitations under the License.
18
 */
19
20
#include <freerdp/config.h>
21
22
#include "settings.h"
23
24
#include <winpr/assert.h>
25
#include <winpr/cast.h>
26
27
#include <freerdp/utils/pcap.h>
28
#include <freerdp/log.h>
29
30
#include "../cache/cache.h"
31
#include "surface.h"
32
33
#define TAG FREERDP_TAG("core.surface")
34
35
static BOOL update_recv_surfcmd_bitmap_header_ex(wStream* s, TS_COMPRESSED_BITMAP_HEADER_EX* header)
36
119
{
37
119
  if (!s || !header)
38
0
    return FALSE;
39
40
119
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 24))
41
8
    return FALSE;
42
43
111
  Stream_Read_UINT32(s, header->highUniqueId);
44
111
  Stream_Read_UINT32(s, header->lowUniqueId);
45
111
  Stream_Read_UINT64(s, header->tmMilliseconds);
46
111
  Stream_Read_UINT64(s, header->tmSeconds);
47
111
  return TRUE;
48
119
}
49
50
static BOOL update_recv_surfcmd_bitmap_ex(wStream* s, TS_BITMAP_DATA_EX* bmp)
51
624
{
52
624
  if (!s || !bmp)
53
0
    return FALSE;
54
55
624
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 12))
56
14
    return FALSE;
57
58
610
  Stream_Read_UINT8(s, bmp->bpp);
59
610
  Stream_Read_UINT8(s, bmp->flags);
60
610
  Stream_Seek(s, 1); /* reserved */
61
610
  Stream_Read_UINT8(s, bmp->codecID);
62
610
  Stream_Read_UINT16(s, bmp->width);
63
610
  Stream_Read_UINT16(s, bmp->height);
64
610
  Stream_Read_UINT32(s, bmp->bitmapDataLength);
65
66
610
  if ((bmp->width == 0) || (bmp->height == 0))
67
30
  {
68
30
    WLog_ERR(TAG, "invalid size value width=%" PRIu16 ", height=%" PRIu16, bmp->width,
69
30
             bmp->height);
70
30
    return FALSE;
71
30
  }
72
73
580
  if ((bmp->bpp < 1) || (bmp->bpp > 32))
74
24
  {
75
24
    WLog_ERR(TAG, "invalid bpp value %" PRIu32 "", bmp->bpp);
76
24
    return FALSE;
77
24
  }
78
79
556
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
80
119
  {
81
119
    if (!update_recv_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
82
8
      return FALSE;
83
119
  }
84
85
548
  bmp->bitmapData = Stream_Pointer(s);
86
548
  if (!Stream_SafeSeek(s, bmp->bitmapDataLength))
87
62
  {
88
62
    WLog_ERR(TAG, "expected bitmapDataLength %" PRIu32 ", not enough data",
89
62
             bmp->bitmapDataLength);
90
62
    return FALSE;
91
62
  }
92
486
  return TRUE;
93
548
}
94
95
static BOOL update_recv_surfcmd_is_rect_valid(const rdpContext* context,
96
                                              const SURFACE_BITS_COMMAND* cmd)
97
852
{
98
852
  WINPR_ASSERT(context);
99
852
  WINPR_ASSERT(context->settings);
100
852
  WINPR_ASSERT(cmd);
101
102
  /* We need a rectangle with left/top being smaller than right/bottom.
103
   * Also do not allow empty rectangles. */
104
852
  if ((cmd->destTop >= cmd->destBottom) || (cmd->destLeft >= cmd->destRight))
105
164
  {
106
164
    WLog_WARN(TAG,
107
164
              "Empty surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
108
164
              "x%" PRIu16,
109
164
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom);
110
164
    return FALSE;
111
164
  }
112
113
  /* The rectangle needs to fit into our session size */
114
688
  if ((cmd->destRight > context->settings->DesktopWidth) ||
115
637
      (cmd->destBottom > context->settings->DesktopHeight))
116
64
  {
117
64
    WLog_WARN(TAG,
118
64
              "Invalid surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
119
64
              "x%" PRIu16 " does not fit %" PRIu32 "x%" PRIu32,
120
64
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom,
121
64
              context->settings->DesktopWidth, context->settings->DesktopHeight);
122
64
    return FALSE;
123
64
  }
124
125
624
  return TRUE;
126
688
}
127
128
static BOOL update_recv_surfcmd_surface_bits(rdpUpdate* update, wStream* s, UINT16 cmdType)
129
876
{
130
876
  BOOL rc = FALSE;
131
876
  SURFACE_BITS_COMMAND cmd = WINPR_C_ARRAY_INIT;
132
133
876
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 8))
134
24
    goto fail;
135
136
852
  cmd.cmdType = cmdType;
137
852
  Stream_Read_UINT16(s, cmd.destLeft);
138
852
  Stream_Read_UINT16(s, cmd.destTop);
139
852
  Stream_Read_UINT16(s, cmd.destRight);
140
852
  Stream_Read_UINT16(s, cmd.destBottom);
141
142
852
  if (!update_recv_surfcmd_is_rect_valid(update->context, &cmd))
143
228
    goto fail;
144
145
624
  if (!update_recv_surfcmd_bitmap_ex(s, &cmd.bmp))
146
138
    goto fail;
147
148
486
  if (!IFCALLRESULT(TRUE, update->SurfaceBits, update->context, &cmd))
149
66
  {
150
66
    WLog_DBG(TAG, "update->SurfaceBits implementation failed");
151
66
    goto fail;
152
66
  }
153
154
420
  rc = TRUE;
155
876
fail:
156
876
  return rc;
157
420
}
158
159
static BOOL update_recv_surfcmd_frame_marker(rdpUpdate* update, wStream* s)
160
123
{
161
123
  SURFACE_FRAME_MARKER marker = WINPR_C_ARRAY_INIT;
162
123
  rdp_update_internal* up = update_cast(update);
163
164
123
  WINPR_ASSERT(s);
165
166
123
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 2))
167
11
    return FALSE;
168
169
112
  Stream_Read_UINT16(s, marker.frameAction);
170
112
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 4))
171
31
    WLog_WARN(TAG,
172
112
              "[SERVER-BUG]: got %" PRIuz ", expected %u"
173
112
              " bytes. [MS-RDPBCGR] 2.2.9.2.3 Frame Marker Command (TS_FRAME_MARKER) is "
174
112
              "missing frameId, ignoring",
175
112
              Stream_GetRemainingLength(s), 4u);
176
81
  else
177
81
    Stream_Read_UINT32(s, marker.frameId);
178
112
  WLog_Print(up->log, WLOG_DEBUG, "SurfaceFrameMarker: action: %s (%" PRIu32 ") id: %" PRIu32 "",
179
112
             (!marker.frameAction) ? "Begin" : "End", marker.frameAction, marker.frameId);
180
181
112
  if (!update->SurfaceFrameMarker)
182
57
  {
183
57
    WINPR_ASSERT(update->context);
184
57
    if (freerdp_settings_get_bool(update->context->settings, FreeRDP_DeactivateClientDecoding))
185
0
      return TRUE;
186
57
    WLog_ERR(TAG, "Missing callback update->SurfaceFrameMarker");
187
57
    return FALSE;
188
57
  }
189
190
55
  if (!update->SurfaceFrameMarker(update->context, &marker))
191
55
  {
192
55
    WLog_DBG(TAG, "update->SurfaceFrameMarker implementation failed");
193
55
    return FALSE;
194
55
  }
195
196
0
  return TRUE;
197
55
}
198
199
int update_recv_surfcmds(rdpUpdate* update, wStream* s)
200
19.0k
{
201
19.0k
  UINT16 cmdType = 0;
202
19.0k
  rdp_update_internal* up = update_cast(update);
203
204
19.0k
  WINPR_ASSERT(s);
205
206
19.5k
  while (Stream_GetRemainingLength(s) >= 2)
207
9.30k
  {
208
9.30k
    const size_t start = Stream_GetPosition(s);
209
9.30k
    const BYTE* mark = Stream_ConstPointer(s);
210
211
9.30k
    Stream_Read_UINT16(s, cmdType);
212
213
9.30k
    switch (cmdType)
214
9.30k
    {
215
391
      case CMDTYPE_SET_SURFACE_BITS:
216
876
      case CMDTYPE_STREAM_SURFACE_BITS:
217
876
        if (!update_recv_surfcmd_surface_bits(update, s, cmdType))
218
456
          return -1;
219
220
420
        break;
221
222
420
      case CMDTYPE_FRAME_MARKER:
223
123
        if (!update_recv_surfcmd_frame_marker(update, s))
224
123
          return -1;
225
226
0
        break;
227
228
8.30k
      default:
229
8.30k
        WLog_ERR(TAG, "unknown cmdType 0x%04" PRIX16 "", cmdType);
230
8.30k
        return -1;
231
9.30k
    }
232
233
420
    if (up->dump_rfx)
234
0
    {
235
0
      const size_t size = Stream_GetPosition(s) - start;
236
      /* TODO: treat return values */
237
0
      if (!pcap_add_record(up->pcap_rfx, mark, size))
238
0
        return -1;
239
0
      pcap_flush(up->pcap_rfx);
240
0
    }
241
420
  }
242
243
10.1k
  return 0;
244
19.0k
}
245
246
static BOOL update_write_surfcmd_bitmap_header_ex(wStream* s,
247
                                                  const TS_COMPRESSED_BITMAP_HEADER_EX* header)
248
49
{
249
49
  if (!s || !header)
250
0
    return FALSE;
251
252
49
  if (!Stream_EnsureRemainingCapacity(s, 24))
253
0
    return FALSE;
254
255
49
  Stream_Write_UINT32(s, header->highUniqueId);
256
49
  Stream_Write_UINT32(s, header->lowUniqueId);
257
49
  Stream_Write_UINT64(s, header->tmMilliseconds);
258
49
  Stream_Write_UINT64(s, header->tmSeconds);
259
49
  return TRUE;
260
49
}
261
262
static BOOL update_write_surfcmd_bitmap_ex(wStream* s, const TS_BITMAP_DATA_EX* bmp)
263
65
{
264
65
  if (!s || !bmp)
265
0
    return FALSE;
266
267
65
  if (!Stream_EnsureRemainingCapacity(s, 12))
268
0
    return FALSE;
269
270
65
  if (bmp->codecID > UINT8_MAX)
271
0
  {
272
0
    WLog_ERR(TAG, "Invalid TS_BITMAP_DATA_EX::codecID=0x%04" PRIx16 "", bmp->codecID);
273
0
    return FALSE;
274
0
  }
275
65
  Stream_Write_UINT8(s, bmp->bpp);
276
65
  Stream_Write_UINT8(s, bmp->flags);
277
65
  Stream_Write_UINT8(s, 0); /* reserved1, reserved2 */
278
65
  Stream_Write_UINT8(s, (UINT8)bmp->codecID);
279
65
  Stream_Write_UINT16(s, bmp->width);
280
65
  Stream_Write_UINT16(s, bmp->height);
281
65
  Stream_Write_UINT32(s, bmp->bitmapDataLength);
282
283
65
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
284
49
  {
285
49
    if (!update_write_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
286
0
      return FALSE;
287
49
  }
288
289
65
  if (!Stream_EnsureRemainingCapacity(s, bmp->bitmapDataLength))
290
0
    return FALSE;
291
292
65
  Stream_Write(s, bmp->bitmapData, bmp->bitmapDataLength);
293
65
  return TRUE;
294
65
}
295
296
BOOL update_write_surfcmd_surface_bits(wStream* s, const SURFACE_BITS_COMMAND* cmd)
297
65
{
298
65
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_SURFACE_BITS_HEADER_LENGTH))
299
0
    return FALSE;
300
301
65
  WINPR_ASSERT(cmd->cmdType <= UINT16_MAX);
302
65
  UINT16 cmdType = (UINT16)cmd->cmdType;
303
65
  switch (cmdType)
304
65
  {
305
59
    case CMDTYPE_SET_SURFACE_BITS:
306
65
    case CMDTYPE_STREAM_SURFACE_BITS:
307
65
      break;
308
0
    default:
309
0
    {
310
0
      const UINT16 defaultCmdType = CMDTYPE_STREAM_SURFACE_BITS;
311
0
      WLog_WARN(TAG,
312
0
                "SURFACE_BITS_COMMAND->cmdType 0x%04" PRIx16
313
0
                " not allowed, correcting to 0x%04" PRIx16,
314
0
                cmdType, defaultCmdType);
315
0
      cmdType = defaultCmdType;
316
0
    }
317
0
    break;
318
65
  }
319
320
65
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmdType));
321
65
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destLeft));
322
65
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destTop));
323
65
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destRight));
324
65
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destBottom));
325
65
  return update_write_surfcmd_bitmap_ex(s, &cmd->bmp);
326
65
}
327
328
BOOL update_write_surfcmd_frame_marker(wStream* s, UINT16 frameAction, UINT32 frameId)
329
47
{
330
47
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_FRAME_MARKER_LENGTH))
331
0
    return FALSE;
332
333
47
  Stream_Write_UINT16(s, CMDTYPE_FRAME_MARKER);
334
47
  Stream_Write_UINT16(s, frameAction);
335
47
  Stream_Write_UINT32(s, frameId);
336
47
  return TRUE;
337
47
}