Coverage Report

Created: 2026-06-09 06:17

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/FreeRDP/libfreerdp/core/surface.c
Line
Count
Source
1
/**
2
 * FreeRDP: A Remote Desktop Protocol Implementation
3
 * Surface Commands
4
 *
5
 * Copyright 2011 Vic Lee
6
 *
7
 * Licensed under the Apache License, Version 2.0 (the "License");
8
 * you may not use this file except in compliance with the License.
9
 * You may obtain a copy of the License at
10
 *
11
 *     http://www.apache.org/licenses/LICENSE-2.0
12
 *
13
 * Unless required by applicable law or agreed to in writing, software
14
 * distributed under the License is distributed on an "AS IS" BASIS,
15
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16
 * See the License for the specific language governing permissions and
17
 * limitations under the License.
18
 */
19
20
#include <freerdp/config.h>
21
22
#include "settings.h"
23
24
#include <winpr/assert.h>
25
#include <winpr/cast.h>
26
27
#include <freerdp/utils/pcap.h>
28
#include <freerdp/log.h>
29
30
#include "../cache/cache.h"
31
#include "surface.h"
32
33
#define TAG FREERDP_TAG("core.surface")
34
35
static BOOL update_recv_surfcmd_bitmap_header_ex(wStream* s, TS_COMPRESSED_BITMAP_HEADER_EX* header)
36
2.27k
{
37
2.27k
  if (!s || !header)
38
0
    return FALSE;
39
40
2.27k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 24))
41
113
    return FALSE;
42
43
2.16k
  Stream_Read_UINT32(s, header->highUniqueId);
44
2.16k
  Stream_Read_UINT32(s, header->lowUniqueId);
45
2.16k
  Stream_Read_UINT64(s, header->tmMilliseconds);
46
2.16k
  Stream_Read_UINT64(s, header->tmSeconds);
47
2.16k
  return TRUE;
48
2.27k
}
49
50
static BOOL update_recv_surfcmd_bitmap_ex(wStream* s, TS_BITMAP_DATA_EX* bmp)
51
4.29k
{
52
4.29k
  if (!s || !bmp)
53
0
    return FALSE;
54
55
4.29k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 12))
56
233
    return FALSE;
57
58
4.06k
  Stream_Read_UINT8(s, bmp->bpp);
59
4.06k
  Stream_Read_UINT8(s, bmp->flags);
60
4.06k
  Stream_Seek(s, 1); /* reserved */
61
4.06k
  Stream_Read_UINT8(s, bmp->codecID);
62
4.06k
  Stream_Read_UINT16(s, bmp->width);
63
4.06k
  Stream_Read_UINT16(s, bmp->height);
64
4.06k
  Stream_Read_UINT32(s, bmp->bitmapDataLength);
65
66
4.06k
  if ((bmp->width == 0) || (bmp->height == 0))
67
182
  {
68
182
    WLog_ERR(TAG, "invalid size value width=%" PRIu16 ", height=%" PRIu16, bmp->width,
69
182
             bmp->height);
70
182
    return FALSE;
71
182
  }
72
73
3.87k
  if ((bmp->bpp < 1) || (bmp->bpp > 32))
74
521
  {
75
521
    WLog_ERR(TAG, "invalid bpp value %" PRIu32 "", bmp->bpp);
76
521
    return FALSE;
77
521
  }
78
79
3.35k
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
80
2.27k
  {
81
2.27k
    if (!update_recv_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
82
113
      return FALSE;
83
2.27k
  }
84
85
3.24k
  bmp->bitmapData = Stream_Pointer(s);
86
3.24k
  if (!Stream_SafeSeek(s, bmp->bitmapDataLength))
87
2.07k
  {
88
2.07k
    WLog_ERR(TAG, "expected bitmapDataLength %" PRIu32 ", not enough data",
89
2.07k
             bmp->bitmapDataLength);
90
2.07k
    return FALSE;
91
2.07k
  }
92
1.17k
  return TRUE;
93
3.24k
}
94
95
static BOOL update_recv_surfcmd_is_rect_valid(const rdpContext* context,
96
                                              const SURFACE_BITS_COMMAND* cmd)
97
6.43k
{
98
6.43k
  WINPR_ASSERT(context);
99
6.43k
  WINPR_ASSERT(context->settings);
100
6.43k
  WINPR_ASSERT(cmd);
101
102
  /* We need a rectangle with left/top being smaller than right/bottom.
103
   * Also do not allow empty rectangles. */
104
6.43k
  if ((cmd->destTop >= cmd->destBottom) || (cmd->destLeft >= cmd->destRight))
105
1.51k
  {
106
1.51k
    WLog_WARN(TAG,
107
1.51k
              "Empty surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
108
1.51k
              "x%" PRIu16,
109
1.51k
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom);
110
1.51k
    return FALSE;
111
1.51k
  }
112
113
  /* The rectangle needs to fit into our session size */
114
4.92k
  const DWORD DesktopWidth = freerdp_settings_get_uint32(context->settings, FreeRDP_DesktopWidth);
115
4.92k
  const DWORD DesktopHeight =
116
4.92k
      freerdp_settings_get_uint32(context->settings, FreeRDP_DesktopHeight);
117
4.92k
  if ((cmd->destRight > DesktopWidth) || (cmd->destBottom > DesktopHeight))
118
633
  {
119
633
    WLog_WARN(TAG,
120
633
              "Invalid surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
121
633
              "x%" PRIu16 " does not fit %" PRIu32 "x%" PRIu32,
122
633
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom, DesktopWidth,
123
633
              DesktopHeight);
124
633
    return FALSE;
125
633
  }
126
127
4.29k
  return TRUE;
128
4.92k
}
129
130
static BOOL update_recv_surfcmd_surface_bits(rdpUpdate* update, wStream* s, UINT16 cmdType)
131
6.97k
{
132
6.97k
  BOOL rc = FALSE;
133
6.97k
  SURFACE_BITS_COMMAND cmd = WINPR_C_ARRAY_INIT;
134
135
6.97k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 8))
136
532
    goto fail;
137
138
6.43k
  cmd.cmdType = cmdType;
139
6.43k
  Stream_Read_UINT16(s, cmd.destLeft);
140
6.43k
  Stream_Read_UINT16(s, cmd.destTop);
141
6.43k
  Stream_Read_UINT16(s, cmd.destRight);
142
6.43k
  Stream_Read_UINT16(s, cmd.destBottom);
143
144
6.43k
  if (!update_recv_surfcmd_is_rect_valid(update->context, &cmd))
145
2.14k
    goto fail;
146
147
4.29k
  if (!update_recv_surfcmd_bitmap_ex(s, &cmd.bmp))
148
3.12k
    goto fail;
149
150
1.17k
  if (!IFCALLRESULT(TRUE, update->SurfaceBits, update->context, &cmd))
151
585
  {
152
585
    WLog_DBG(TAG, "update->SurfaceBits implementation failed");
153
585
    goto fail;
154
585
  }
155
156
586
  rc = TRUE;
157
6.97k
fail:
158
6.97k
  return rc;
159
586
}
160
161
static BOOL update_recv_surfcmd_frame_marker(rdpUpdate* update, wStream* s)
162
1.66k
{
163
1.66k
  SURFACE_FRAME_MARKER marker = WINPR_C_ARRAY_INIT;
164
1.66k
  rdp_update_internal* up = update_cast(update);
165
166
1.66k
  WINPR_ASSERT(s);
167
168
1.66k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 2))
169
277
    return FALSE;
170
171
1.38k
  Stream_Read_UINT16(s, marker.frameAction);
172
1.38k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 4))
173
794
    WLog_WARN(TAG,
174
1.38k
              "[SERVER-BUG]: got %" PRIuz ", expected %u"
175
1.38k
              " bytes. [MS-RDPBCGR] 2.2.9.2.3 Frame Marker Command (TS_FRAME_MARKER) is "
176
1.38k
              "missing frameId, ignoring",
177
1.38k
              Stream_GetRemainingLength(s), 4u);
178
591
  else
179
591
    Stream_Read_UINT32(s, marker.frameId);
180
1.38k
  WLog_Print(up->log, WLOG_DEBUG, "SurfaceFrameMarker: action: %s (%" PRIu32 ") id: %" PRIu32 "",
181
1.38k
             (!marker.frameAction) ? "Begin" : "End", marker.frameAction, marker.frameId);
182
183
1.38k
  if (!update->SurfaceFrameMarker)
184
426
  {
185
426
    WINPR_ASSERT(update->context);
186
426
    if (freerdp_settings_get_bool(update->context->settings, FreeRDP_DeactivateClientDecoding))
187
0
      return TRUE;
188
426
    WLog_ERR(TAG, "Missing callback update->SurfaceFrameMarker");
189
426
    return FALSE;
190
426
  }
191
192
959
  if (!update->SurfaceFrameMarker(update->context, &marker))
193
959
  {
194
959
    WLog_DBG(TAG, "update->SurfaceFrameMarker implementation failed");
195
959
    return FALSE;
196
959
  }
197
198
0
  return TRUE;
199
959
}
200
201
BOOL update_recv_surfcmds(rdpUpdate* update, wStream* s)
202
34.8k
{
203
34.8k
  UINT16 cmdType = 0;
204
34.8k
  rdp_update_internal* up = update_cast(update);
205
206
34.8k
  WINPR_ASSERT(s);
207
208
35.4k
  while (Stream_GetRemainingLength(s) >= 2)
209
19.4k
  {
210
19.4k
    const size_t start = Stream_GetPosition(s);
211
19.4k
    const BYTE* mark = Stream_ConstPointer(s);
212
213
19.4k
    Stream_Read_UINT16(s, cmdType);
214
215
19.4k
    switch (cmdType)
216
19.4k
    {
217
5.88k
      case CMDTYPE_SET_SURFACE_BITS:
218
6.97k
      case CMDTYPE_STREAM_SURFACE_BITS:
219
6.97k
        if (!update_recv_surfcmd_surface_bits(update, s, cmdType))
220
6.38k
          return FALSE;
221
222
586
        break;
223
224
1.66k
      case CMDTYPE_FRAME_MARKER:
225
1.66k
        if (!update_recv_surfcmd_frame_marker(update, s))
226
1.66k
          return FALSE;
227
228
0
        break;
229
230
10.8k
      default:
231
10.8k
        WLog_ERR(TAG, "unknown cmdType 0x%04" PRIX16 "", cmdType);
232
10.8k
        return FALSE;
233
19.4k
    }
234
235
586
    if (up->dump_rfx)
236
0
    {
237
0
      const size_t size = Stream_GetPosition(s) - start;
238
      /* TODO: treat return values */
239
0
      if (!pcap_add_record(up->pcap_rfx, mark, size))
240
0
        return FALSE;
241
0
      pcap_flush(up->pcap_rfx);
242
0
    }
243
586
  }
244
245
15.9k
  return TRUE;
246
34.8k
}
247
248
static BOOL update_write_surfcmd_bitmap_header_ex(wStream* s,
249
                                                  const TS_COMPRESSED_BITMAP_HEADER_EX* header)
250
102
{
251
102
  if (!s || !header)
252
0
    return FALSE;
253
254
102
  if (!Stream_EnsureRemainingCapacity(s, 24))
255
0
    return FALSE;
256
257
102
  Stream_Write_UINT32(s, header->highUniqueId);
258
102
  Stream_Write_UINT32(s, header->lowUniqueId);
259
102
  Stream_Write_UINT64(s, header->tmMilliseconds);
260
102
  Stream_Write_UINT64(s, header->tmSeconds);
261
102
  return TRUE;
262
102
}
263
264
static BOOL update_write_surfcmd_bitmap_ex(wStream* s, const TS_BITMAP_DATA_EX* bmp)
265
583
{
266
583
  if (!s || !bmp)
267
0
    return FALSE;
268
269
583
  if (!Stream_EnsureRemainingCapacity(s, 12))
270
0
    return FALSE;
271
272
583
  if (bmp->codecID > UINT8_MAX)
273
0
  {
274
0
    WLog_ERR(TAG, "Invalid TS_BITMAP_DATA_EX::codecID=0x%04" PRIx16 "", bmp->codecID);
275
0
    return FALSE;
276
0
  }
277
583
  Stream_Write_UINT8(s, bmp->bpp);
278
583
  Stream_Write_UINT8(s, bmp->flags);
279
583
  Stream_Write_UINT8(s, 0); /* reserved1, reserved2 */
280
583
  Stream_Write_UINT8(s, (UINT8)bmp->codecID);
281
583
  Stream_Write_UINT16(s, bmp->width);
282
583
  Stream_Write_UINT16(s, bmp->height);
283
583
  Stream_Write_UINT32(s, bmp->bitmapDataLength);
284
285
583
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
286
102
  {
287
102
    if (!update_write_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
288
0
      return FALSE;
289
102
  }
290
291
583
  if (!Stream_EnsureRemainingCapacity(s, bmp->bitmapDataLength))
292
0
    return FALSE;
293
294
583
  Stream_Write(s, bmp->bitmapData, bmp->bitmapDataLength);
295
583
  return TRUE;
296
583
}
297
298
BOOL update_write_surfcmd_surface_bits(wStream* s, const SURFACE_BITS_COMMAND* cmd)
299
583
{
300
583
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_SURFACE_BITS_HEADER_LENGTH))
301
0
    return FALSE;
302
303
583
  WINPR_ASSERT(cmd->cmdType <= UINT16_MAX);
304
583
  UINT16 cmdType = (UINT16)cmd->cmdType;
305
583
  switch (cmdType)
306
583
  {
307
543
    case CMDTYPE_SET_SURFACE_BITS:
308
583
    case CMDTYPE_STREAM_SURFACE_BITS:
309
583
      break;
310
0
    default:
311
0
    {
312
0
      const UINT16 defaultCmdType = CMDTYPE_STREAM_SURFACE_BITS;
313
0
      WLog_WARN(TAG,
314
0
                "SURFACE_BITS_COMMAND->cmdType 0x%04" PRIx16
315
0
                " not allowed, correcting to 0x%04" PRIx16,
316
0
                cmdType, defaultCmdType);
317
0
      cmdType = defaultCmdType;
318
0
    }
319
0
    break;
320
583
  }
321
322
583
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmdType));
323
583
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destLeft));
324
583
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destTop));
325
583
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destRight));
326
583
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destBottom));
327
583
  return update_write_surfcmd_bitmap_ex(s, &cmd->bmp);
328
583
}
329
330
BOOL update_write_surfcmd_frame_marker(wStream* s, UINT16 frameAction, UINT32 frameId)
331
954
{
332
954
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_FRAME_MARKER_LENGTH))
333
0
    return FALSE;
334
335
954
  Stream_Write_UINT16(s, CMDTYPE_FRAME_MARKER);
336
954
  Stream_Write_UINT16(s, frameAction);
337
954
  Stream_Write_UINT32(s, frameId);
338
954
  return TRUE;
339
954
}