Coverage Report

Created: 2026-08-31 06:29

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/FreeRDP/libfreerdp/core/surface.c
Line
Count
Source
1
/**
2
 * FreeRDP: A Remote Desktop Protocol Implementation
3
 * Surface Commands
4
 *
5
 * Copyright 2011 Vic Lee
6
 *
7
 * Licensed under the Apache License, Version 2.0 (the "License");
8
 * you may not use this file except in compliance with the License.
9
 * You may obtain a copy of the License at
10
 *
11
 *     http://www.apache.org/licenses/LICENSE-2.0
12
 *
13
 * Unless required by applicable law or agreed to in writing, software
14
 * distributed under the License is distributed on an "AS IS" BASIS,
15
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16
 * See the License for the specific language governing permissions and
17
 * limitations under the License.
18
 */
19
20
#include <freerdp/config.h>
21
22
#include "settings.h"
23
24
#include <winpr/assert.h>
25
#include <winpr/cast.h>
26
27
#include <freerdp/utils/pcap.h>
28
#include <freerdp/log.h>
29
30
#include "../cache/cache.h"
31
#include "surface.h"
32
33
#define TAG FREERDP_TAG("core.surface")
34
35
static BOOL update_recv_surfcmd_bitmap_header_ex(wStream* s, TS_COMPRESSED_BITMAP_HEADER_EX* header)
36
2.20k
{
37
2.20k
  if (!s || !header)
38
0
    return FALSE;
39
40
2.20k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 24))
41
145
    return FALSE;
42
43
2.05k
  Stream_Read_UINT32(s, header->highUniqueId);
44
2.05k
  Stream_Read_UINT32(s, header->lowUniqueId);
45
2.05k
  Stream_Read_UINT64(s, header->tmMilliseconds);
46
2.05k
  Stream_Read_UINT64(s, header->tmSeconds);
47
2.05k
  return TRUE;
48
2.20k
}
49
50
static BOOL update_recv_surfcmd_bitmap_ex(wStream* s, TS_BITMAP_DATA_EX* bmp)
51
4.94k
{
52
4.94k
  if (!s || !bmp)
53
0
    return FALSE;
54
55
4.94k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 12))
56
265
    return FALSE;
57
58
4.68k
  Stream_Read_UINT8(s, bmp->bpp);
59
4.68k
  Stream_Read_UINT8(s, bmp->flags);
60
4.68k
  Stream_Seek(s, 1); /* reserved */
61
4.68k
  Stream_Read_UINT8(s, bmp->codecID);
62
4.68k
  Stream_Read_UINT16(s, bmp->width);
63
4.68k
  Stream_Read_UINT16(s, bmp->height);
64
4.68k
  Stream_Read_UINT32(s, bmp->bitmapDataLength);
65
66
4.68k
  if ((bmp->width == 0) || (bmp->height == 0))
67
413
  {
68
413
    WLog_ERR(TAG, "invalid size value width=%" PRIu16 ", height=%" PRIu16, bmp->width,
69
413
             bmp->height);
70
413
    return FALSE;
71
413
  }
72
73
4.26k
  if ((bmp->bpp < 1) || (bmp->bpp > 32))
74
744
  {
75
744
    WLog_ERR(TAG, "invalid bpp value %" PRIu32 "", bmp->bpp);
76
744
    return FALSE;
77
744
  }
78
79
3.52k
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
80
2.20k
  {
81
2.20k
    if (!update_recv_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
82
145
      return FALSE;
83
2.20k
  }
84
85
3.37k
  bmp->bitmapData = Stream_Pointer(s);
86
3.37k
  if (!Stream_SafeSeek(s, bmp->bitmapDataLength))
87
951
  {
88
951
    WLog_ERR(TAG, "expected bitmapDataLength %" PRIu32 ", not enough data",
89
951
             bmp->bitmapDataLength);
90
951
    return FALSE;
91
951
  }
92
2.42k
  return TRUE;
93
3.37k
}
94
95
static BOOL update_recv_surfcmd_is_rect_valid(const rdpContext* context,
96
                                              const SURFACE_BITS_COMMAND* cmd)
97
7.18k
{
98
7.18k
  WINPR_ASSERT(context);
99
7.18k
  WINPR_ASSERT(context->settings);
100
7.18k
  WINPR_ASSERT(cmd);
101
102
  /* We need a rectangle with left/top being smaller than right/bottom.
103
   * Also do not allow empty rectangles. */
104
7.18k
  if ((cmd->destTop >= cmd->destBottom) || (cmd->destLeft >= cmd->destRight))
105
1.09k
  {
106
1.09k
    WLog_WARN(TAG,
107
1.09k
              "Empty surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
108
1.09k
              "x%" PRIu16,
109
1.09k
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom);
110
1.09k
    return FALSE;
111
1.09k
  }
112
113
  /* The rectangle needs to fit into our session size */
114
6.08k
  const DWORD DesktopWidth = freerdp_settings_get_uint32(context->settings, FreeRDP_DesktopWidth);
115
6.08k
  const DWORD DesktopHeight =
116
6.08k
      freerdp_settings_get_uint32(context->settings, FreeRDP_DesktopHeight);
117
6.08k
  if ((cmd->destRight > DesktopWidth) || (cmd->destBottom > DesktopHeight))
118
1.14k
  {
119
1.14k
    WLog_WARN(TAG,
120
1.14k
              "Invalid surface bits command rectangle: %" PRIu16 "x%" PRIu16 "-%" PRIu16
121
1.14k
              "x%" PRIu16 " does not fit %" PRIu32 "x%" PRIu32,
122
1.14k
              cmd->destLeft, cmd->destTop, cmd->destRight, cmd->destBottom, DesktopWidth,
123
1.14k
              DesktopHeight);
124
1.14k
    return FALSE;
125
1.14k
  }
126
127
4.94k
  return TRUE;
128
6.08k
}
129
130
static BOOL update_recv_surfcmd_surface_bits(rdpUpdate* update, wStream* s, UINT16 cmdType)
131
7.83k
{
132
7.83k
  rdp_update_internal* up = update_cast(update);
133
7.83k
  BOOL rc = FALSE;
134
7.83k
  SURFACE_BITS_COMMAND cmd = WINPR_C_ARRAY_INIT;
135
136
7.83k
  WINPR_ASSERT(up);
137
138
7.83k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 8))
139
656
    goto fail;
140
141
7.18k
  cmd.cmdType = cmdType;
142
7.18k
  Stream_Read_UINT16(s, cmd.destLeft);
143
7.18k
  Stream_Read_UINT16(s, cmd.destTop);
144
7.18k
  Stream_Read_UINT16(s, cmd.destRight);
145
7.18k
  Stream_Read_UINT16(s, cmd.destBottom);
146
147
7.18k
  if (!update_recv_surfcmd_is_rect_valid(update->context, &cmd))
148
2.23k
    goto fail;
149
150
4.94k
  if (!update_recv_surfcmd_bitmap_ex(s, &cmd.bmp))
151
2.51k
    goto fail;
152
153
2.42k
  up->stats.base[RDP_STATS_SURFACE_BITS]++;
154
2.42k
  switch (cmd.bmp.codecID)
155
2.42k
  {
156
100
    case RDP_CODEC_ID_REMOTEFX:
157
100
      up->stats.base[RDP_STATS_SURFACE_BITS_RFX]++;
158
100
      break;
159
78
    case RDP_CODEC_ID_IMAGE_REMOTEFX:
160
78
      up->stats.base[RDP_STATS_SURFACE_BITS_RFX_IMAGE]++;
161
78
      break;
162
228
    case RDP_CODEC_ID_NSCODEC:
163
228
      up->stats.base[RDP_STATS_SURFACE_BITS_NSC]++;
164
228
      break;
165
385
    case RDP_CODEC_ID_NONE:
166
385
      up->stats.base[RDP_STATS_SURFACE_BITS_NONE]++;
167
385
      break;
168
1.63k
    default:
169
1.63k
      up->stats.base[RDP_STATS_SURFACE_BITS_UNKNOWN]++;
170
1.63k
      break;
171
2.42k
  }
172
173
2.42k
  if (!IFCALLRESULT(TRUE, update->SurfaceBits, update->context, &cmd))
174
1.36k
  {
175
1.36k
    WLog_DBG(TAG, "update->SurfaceBits implementation failed");
176
1.36k
    goto fail;
177
1.36k
  }
178
179
1.06k
  rc = TRUE;
180
7.83k
fail:
181
7.83k
  return rc;
182
1.06k
}
183
184
static BOOL update_recv_surfcmd_frame_marker(rdpUpdate* update, wStream* s)
185
2.10k
{
186
2.10k
  SURFACE_FRAME_MARKER marker = WINPR_C_ARRAY_INIT;
187
2.10k
  rdp_update_internal* up = update_cast(update);
188
189
2.10k
  WINPR_ASSERT(s);
190
191
2.10k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 2))
192
354
    return FALSE;
193
194
1.75k
  Stream_Read_UINT16(s, marker.frameAction);
195
1.75k
  if (!Stream_CheckAndLogRequiredLength(TAG, s, 4))
196
1.09k
    WLog_WARN(TAG,
197
1.75k
              "[SERVER-BUG]: got %" PRIuz ", expected %u"
198
1.75k
              " bytes. [MS-RDPBCGR] 2.2.9.2.3 Frame Marker Command (TS_FRAME_MARKER) is "
199
1.75k
              "missing frameId, ignoring",
200
1.75k
              Stream_GetRemainingLength(s), 4u);
201
655
  else
202
655
    Stream_Read_UINT32(s, marker.frameId);
203
1.75k
  WLog_Print(up->log, WLOG_DEBUG, "SurfaceFrameMarker: action: %s (%" PRIu32 ") id: %" PRIu32 "",
204
1.75k
             (!marker.frameAction) ? "Begin" : "End", marker.frameAction, marker.frameId);
205
206
1.75k
  if (!update->SurfaceFrameMarker)
207
364
  {
208
364
    WINPR_ASSERT(update->context);
209
364
    if (freerdp_settings_get_bool(update->context->settings, FreeRDP_DeactivateClientDecoding))
210
0
      return TRUE;
211
364
    WLog_ERR(TAG, "Missing callback update->SurfaceFrameMarker");
212
364
    return FALSE;
213
364
  }
214
215
1.38k
  if (!update->SurfaceFrameMarker(update->context, &marker))
216
1.38k
  {
217
1.38k
    WLog_DBG(TAG, "update->SurfaceFrameMarker implementation failed");
218
1.38k
    return FALSE;
219
1.38k
  }
220
221
0
  return TRUE;
222
1.38k
}
223
224
BOOL update_recv_surfcmds(rdpUpdate* update, wStream* s)
225
33.1k
{
226
33.1k
  UINT16 cmdType = 0;
227
33.1k
  rdp_update_internal* up = update_cast(update);
228
229
33.1k
  WINPR_ASSERT(s);
230
231
34.2k
  while (Stream_GetRemainingLength(s) >= 2)
232
20.1k
  {
233
20.1k
    const size_t start = Stream_GetPosition(s);
234
20.1k
    const BYTE* mark = Stream_ConstPointer(s);
235
236
20.1k
    Stream_Read_UINT16(s, cmdType);
237
238
20.1k
    switch (cmdType)
239
20.1k
    {
240
6.38k
      case CMDTYPE_SET_SURFACE_BITS:
241
7.83k
      case CMDTYPE_STREAM_SURFACE_BITS:
242
7.83k
        if (!update_recv_surfcmd_surface_bits(update, s, cmdType))
243
6.77k
          return FALSE;
244
1.06k
        break;
245
246
2.10k
      case CMDTYPE_FRAME_MARKER:
247
2.10k
        up->stats.base[RDP_STATS_SURFACE_FRAME_MARKER]++;
248
2.10k
        if (!update_recv_surfcmd_frame_marker(update, s))
249
2.10k
          return FALSE;
250
251
0
        break;
252
253
10.2k
      default:
254
10.2k
        WLog_ERR(TAG, "unknown cmdType 0x%04" PRIX16 "", cmdType);
255
10.2k
        return FALSE;
256
20.1k
    }
257
258
1.06k
    if (up->dump_rfx)
259
0
    {
260
0
      const size_t size = Stream_GetPosition(s) - start;
261
      /* TODO: treat return values */
262
0
      if (!pcap_add_record(up->pcap_rfx, mark, size))
263
0
        return FALSE;
264
0
      pcap_flush(up->pcap_rfx);
265
0
    }
266
1.06k
  }
267
268
14.0k
  return TRUE;
269
33.1k
}
270
271
static BOOL update_write_surfcmd_bitmap_header_ex(wStream* s,
272
                                                  const TS_COMPRESSED_BITMAP_HEADER_EX* header)
273
895
{
274
895
  if (!s || !header)
275
0
    return FALSE;
276
277
895
  if (!Stream_EnsureRemainingCapacity(s, 24))
278
0
    return FALSE;
279
280
895
  Stream_Write_UINT32(s, header->highUniqueId);
281
895
  Stream_Write_UINT32(s, header->lowUniqueId);
282
895
  Stream_Write_UINT64(s, header->tmMilliseconds);
283
895
  Stream_Write_UINT64(s, header->tmSeconds);
284
895
  return TRUE;
285
895
}
286
287
static BOOL update_write_surfcmd_bitmap_ex(wStream* s, const TS_BITMAP_DATA_EX* bmp)
288
1.36k
{
289
1.36k
  if (!s || !bmp)
290
0
    return FALSE;
291
292
1.36k
  if (!Stream_EnsureRemainingCapacity(s, 12))
293
0
    return FALSE;
294
295
1.36k
  if (bmp->codecID > UINT8_MAX)
296
0
  {
297
0
    WLog_ERR(TAG, "Invalid TS_BITMAP_DATA_EX::codecID=0x%04" PRIx16 "", bmp->codecID);
298
0
    return FALSE;
299
0
  }
300
1.36k
  Stream_Write_UINT8(s, bmp->bpp);
301
1.36k
  Stream_Write_UINT8(s, bmp->flags);
302
1.36k
  Stream_Write_UINT8(s, 0); /* reserved1, reserved2 */
303
1.36k
  Stream_Write_UINT8(s, (UINT8)bmp->codecID);
304
1.36k
  Stream_Write_UINT16(s, bmp->width);
305
1.36k
  Stream_Write_UINT16(s, bmp->height);
306
1.36k
  Stream_Write_UINT32(s, bmp->bitmapDataLength);
307
308
1.36k
  if (bmp->flags & EX_COMPRESSED_BITMAP_HEADER_PRESENT)
309
895
  {
310
895
    if (!update_write_surfcmd_bitmap_header_ex(s, &bmp->exBitmapDataHeader))
311
0
      return FALSE;
312
895
  }
313
314
1.36k
  if (!Stream_EnsureRemainingCapacity(s, bmp->bitmapDataLength))
315
0
    return FALSE;
316
317
1.36k
  Stream_Write(s, bmp->bitmapData, bmp->bitmapDataLength);
318
1.36k
  return TRUE;
319
1.36k
}
320
321
BOOL update_write_surfcmd_surface_bits(wStream* s, const SURFACE_BITS_COMMAND* cmd)
322
1.36k
{
323
1.36k
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_SURFACE_BITS_HEADER_LENGTH))
324
0
    return FALSE;
325
326
1.36k
  WINPR_ASSERT(cmd->cmdType <= UINT16_MAX);
327
1.36k
  UINT16 cmdType = (UINT16)cmd->cmdType;
328
1.36k
  switch (cmdType)
329
1.36k
  {
330
987
    case CMDTYPE_SET_SURFACE_BITS:
331
1.36k
    case CMDTYPE_STREAM_SURFACE_BITS:
332
1.36k
      break;
333
0
    default:
334
0
    {
335
0
      const UINT16 defaultCmdType = CMDTYPE_STREAM_SURFACE_BITS;
336
0
      WLog_WARN(TAG,
337
0
                "SURFACE_BITS_COMMAND->cmdType 0x%04" PRIx16
338
0
                " not allowed, correcting to 0x%04" PRIx16,
339
0
                cmdType, defaultCmdType);
340
0
      cmdType = defaultCmdType;
341
0
    }
342
0
    break;
343
1.36k
  }
344
345
1.36k
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmdType));
346
1.36k
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destLeft));
347
1.36k
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destTop));
348
1.36k
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destRight));
349
1.36k
  Stream_Write_UINT16(s, WINPR_ASSERTING_INT_CAST(uint16_t, cmd->destBottom));
350
1.36k
  return update_write_surfcmd_bitmap_ex(s, &cmd->bmp);
351
1.36k
}
352
353
BOOL update_write_surfcmd_frame_marker(wStream* s, UINT16 frameAction, UINT32 frameId)
354
1.38k
{
355
1.38k
  if (!Stream_EnsureRemainingCapacity(s, SURFCMD_FRAME_MARKER_LENGTH))
356
0
    return FALSE;
357
358
1.38k
  Stream_Write_UINT16(s, CMDTYPE_FRAME_MARKER);
359
1.38k
  Stream_Write_UINT16(s, frameAction);
360
1.38k
  Stream_Write_UINT32(s, frameId);
361
1.38k
  return TRUE;
362
1.38k
}