Line | Count | Source (jump to first uncovered line) |
1 | | #define USE_THE_REPOSITORY_VARIABLE |
2 | | |
3 | | #include "git-compat-util.h" |
4 | | #include "abspath.h" |
5 | | #include "repository.h" |
6 | | #include "config.h" |
7 | | #include "submodule-config.h" |
8 | | #include "submodule.h" |
9 | | #include "dir.h" |
10 | | #include "diff.h" |
11 | | #include "commit.h" |
12 | | #include "environment.h" |
13 | | #include "gettext.h" |
14 | | #include "hex.h" |
15 | | #include "revision.h" |
16 | | #include "run-command.h" |
17 | | #include "diffcore.h" |
18 | | #include "refs.h" |
19 | | #include "string-list.h" |
20 | | #include "oid-array.h" |
21 | | #include "strvec.h" |
22 | | #include "thread-utils.h" |
23 | | #include "path.h" |
24 | | #include "remote.h" |
25 | | #include "worktree.h" |
26 | | #include "parse-options.h" |
27 | | #include "object-file.h" |
28 | | #include "object-name.h" |
29 | | #include "object-store-ll.h" |
30 | | #include "commit-reach.h" |
31 | | #include "read-cache-ll.h" |
32 | | #include "setup.h" |
33 | | #include "trace2.h" |
34 | | |
35 | | static int config_update_recurse_submodules = RECURSE_SUBMODULES_OFF; |
36 | | static int initialized_fetch_ref_tips; |
37 | | static struct oid_array ref_tips_before_fetch; |
38 | | static struct oid_array ref_tips_after_fetch; |
39 | | |
40 | | /* |
41 | | * Check if the .gitmodules file is unmerged. Parsing of the .gitmodules file |
42 | | * will be disabled because we can't guess what might be configured in |
43 | | * .gitmodules unless the user resolves the conflict. |
44 | | */ |
45 | | int is_gitmodules_unmerged(struct index_state *istate) |
46 | 0 | { |
47 | 0 | int pos = index_name_pos(istate, GITMODULES_FILE, strlen(GITMODULES_FILE)); |
48 | 0 | if (pos < 0) { /* .gitmodules not found or isn't merged */ |
49 | 0 | pos = -1 - pos; |
50 | 0 | if (istate->cache_nr > pos) { /* there is a .gitmodules */ |
51 | 0 | const struct cache_entry *ce = istate->cache[pos]; |
52 | 0 | if (ce_namelen(ce) == strlen(GITMODULES_FILE) && |
53 | 0 | !strcmp(ce->name, GITMODULES_FILE)) |
54 | 0 | return 1; |
55 | 0 | } |
56 | 0 | } |
57 | | |
58 | 0 | return 0; |
59 | 0 | } |
60 | | |
61 | | /* |
62 | | * Check if the .gitmodules file is safe to write. |
63 | | * |
64 | | * Writing to the .gitmodules file requires that the file exists in the |
65 | | * working tree or, if it doesn't, that a brand new .gitmodules file is going |
66 | | * to be created (i.e. it's neither in the index nor in the current branch). |
67 | | * |
68 | | * It is not safe to write to .gitmodules if it's not in the working tree but |
69 | | * it is in the index or in the current branch, because writing new values |
70 | | * (and staging them) would blindly overwrite ALL the old content. |
71 | | */ |
72 | | int is_writing_gitmodules_ok(void) |
73 | 0 | { |
74 | 0 | struct object_id oid; |
75 | 0 | return file_exists(GITMODULES_FILE) || |
76 | 0 | (repo_get_oid(the_repository, GITMODULES_INDEX, &oid) < 0 && repo_get_oid(the_repository, GITMODULES_HEAD, &oid) < 0); |
77 | 0 | } |
78 | | |
79 | | /* |
80 | | * Check if the .gitmodules file has unstaged modifications. This must be |
81 | | * checked before allowing modifications to the .gitmodules file with the |
82 | | * intention to stage them later, because when continuing we would stage the |
83 | | * modifications the user didn't stage herself too. That might change in a |
84 | | * future version when we learn to stage the changes we do ourselves without |
85 | | * staging any previous modifications. |
86 | | */ |
87 | | int is_staging_gitmodules_ok(struct index_state *istate) |
88 | 0 | { |
89 | 0 | int pos = index_name_pos(istate, GITMODULES_FILE, strlen(GITMODULES_FILE)); |
90 | |
|
91 | 0 | if ((pos >= 0) && (pos < istate->cache_nr)) { |
92 | 0 | struct stat st; |
93 | 0 | if (lstat(GITMODULES_FILE, &st) == 0 && |
94 | 0 | ie_modified(istate, istate->cache[pos], &st, 0) & DATA_CHANGED) |
95 | 0 | return 0; |
96 | 0 | } |
97 | | |
98 | 0 | return 1; |
99 | 0 | } |
100 | | |
101 | | static int for_each_remote_ref_submodule(const char *submodule, |
102 | | each_ref_fn fn, void *cb_data) |
103 | 0 | { |
104 | 0 | return refs_for_each_remote_ref(repo_get_submodule_ref_store(the_repository, |
105 | 0 | submodule), |
106 | 0 | fn, cb_data); |
107 | 0 | } |
108 | | |
109 | | /* |
110 | | * Try to update the "path" entry in the "submodule.<name>" section of the |
111 | | * .gitmodules file. Return 0 only if a .gitmodules file was found, a section |
112 | | * with the correct path=<oldpath> setting was found and we could update it. |
113 | | */ |
114 | | int update_path_in_gitmodules(const char *oldpath, const char *newpath) |
115 | 0 | { |
116 | 0 | struct strbuf entry = STRBUF_INIT; |
117 | 0 | const struct submodule *submodule; |
118 | 0 | int ret; |
119 | |
|
120 | 0 | if (!file_exists(GITMODULES_FILE)) /* Do nothing without .gitmodules */ |
121 | 0 | return -1; |
122 | | |
123 | 0 | if (is_gitmodules_unmerged(the_repository->index)) |
124 | 0 | die(_("Cannot change unmerged .gitmodules, resolve merge conflicts first")); |
125 | | |
126 | 0 | submodule = submodule_from_path(the_repository, null_oid(), oldpath); |
127 | 0 | if (!submodule || !submodule->name) { |
128 | 0 | warning(_("Could not find section in .gitmodules where path=%s"), oldpath); |
129 | 0 | return -1; |
130 | 0 | } |
131 | 0 | strbuf_addstr(&entry, "submodule."); |
132 | 0 | strbuf_addstr(&entry, submodule->name); |
133 | 0 | strbuf_addstr(&entry, ".path"); |
134 | 0 | ret = config_set_in_gitmodules_file_gently(entry.buf, newpath); |
135 | 0 | strbuf_release(&entry); |
136 | 0 | return ret; |
137 | 0 | } |
138 | | |
139 | | /* |
140 | | * Try to remove the "submodule.<name>" section from .gitmodules where the given |
141 | | * path is configured. Return 0 only if a .gitmodules file was found, a section |
142 | | * with the correct path=<path> setting was found and we could remove it. |
143 | | */ |
144 | | int remove_path_from_gitmodules(const char *path) |
145 | 0 | { |
146 | 0 | struct strbuf sect = STRBUF_INIT; |
147 | 0 | const struct submodule *submodule; |
148 | |
|
149 | 0 | if (!file_exists(GITMODULES_FILE)) /* Do nothing without .gitmodules */ |
150 | 0 | return -1; |
151 | | |
152 | 0 | if (is_gitmodules_unmerged(the_repository->index)) |
153 | 0 | die(_("Cannot change unmerged .gitmodules, resolve merge conflicts first")); |
154 | | |
155 | 0 | submodule = submodule_from_path(the_repository, null_oid(), path); |
156 | 0 | if (!submodule || !submodule->name) { |
157 | 0 | warning(_("Could not find section in .gitmodules where path=%s"), path); |
158 | 0 | return -1; |
159 | 0 | } |
160 | 0 | strbuf_addstr(§, "submodule."); |
161 | 0 | strbuf_addstr(§, submodule->name); |
162 | 0 | if (repo_config_rename_section_in_file(the_repository, GITMODULES_FILE, sect.buf, NULL) < 0) { |
163 | | /* Maybe the user already did that, don't error out here */ |
164 | 0 | warning(_("Could not remove .gitmodules entry for %s"), path); |
165 | 0 | strbuf_release(§); |
166 | 0 | return -1; |
167 | 0 | } |
168 | 0 | strbuf_release(§); |
169 | 0 | return 0; |
170 | 0 | } |
171 | | |
172 | | void stage_updated_gitmodules(struct index_state *istate) |
173 | 0 | { |
174 | 0 | if (add_file_to_index(istate, GITMODULES_FILE, 0)) |
175 | 0 | die(_("staging updated .gitmodules failed")); |
176 | 0 | } |
177 | | |
178 | | static struct string_list added_submodule_odb_paths = STRING_LIST_INIT_NODUP; |
179 | | |
180 | | void add_submodule_odb_by_path(const char *path) |
181 | 0 | { |
182 | 0 | string_list_insert(&added_submodule_odb_paths, xstrdup(path)); |
183 | 0 | } |
184 | | |
185 | | int register_all_submodule_odb_as_alternates(void) |
186 | 0 | { |
187 | 0 | int i; |
188 | 0 | int ret = added_submodule_odb_paths.nr; |
189 | |
|
190 | 0 | for (i = 0; i < added_submodule_odb_paths.nr; i++) |
191 | 0 | add_to_alternates_memory(added_submodule_odb_paths.items[i].string); |
192 | 0 | if (ret) { |
193 | 0 | string_list_clear(&added_submodule_odb_paths, 0); |
194 | 0 | trace2_data_intmax("submodule", the_repository, |
195 | 0 | "register_all_submodule_odb_as_alternates/registered", ret); |
196 | 0 | if (git_env_bool("GIT_TEST_FATAL_REGISTER_SUBMODULE_ODB", 0)) |
197 | 0 | BUG("register_all_submodule_odb_as_alternates() called"); |
198 | 0 | } |
199 | 0 | return ret; |
200 | 0 | } |
201 | | |
202 | | void set_diffopt_flags_from_submodule_config(struct diff_options *diffopt, |
203 | | const char *path) |
204 | 0 | { |
205 | 0 | const struct submodule *submodule = submodule_from_path(the_repository, |
206 | 0 | null_oid(), |
207 | 0 | path); |
208 | 0 | if (submodule) { |
209 | 0 | const char *ignore; |
210 | 0 | char *key; |
211 | |
|
212 | 0 | key = xstrfmt("submodule.%s.ignore", submodule->name); |
213 | 0 | if (repo_config_get_string_tmp(the_repository, key, &ignore)) |
214 | 0 | ignore = submodule->ignore; |
215 | 0 | free(key); |
216 | |
|
217 | 0 | if (ignore) |
218 | 0 | handle_ignore_submodules_arg(diffopt, ignore); |
219 | 0 | else if (is_gitmodules_unmerged(the_repository->index)) |
220 | 0 | diffopt->flags.ignore_submodules = 1; |
221 | 0 | } |
222 | 0 | } |
223 | | |
224 | | /* Cheap function that only determines if we're interested in submodules at all */ |
225 | | int git_default_submodule_config(const char *var, const char *value, |
226 | | void *cb UNUSED) |
227 | 0 | { |
228 | 0 | if (!strcmp(var, "submodule.recurse")) { |
229 | 0 | int v = git_config_bool(var, value) ? |
230 | 0 | RECURSE_SUBMODULES_ON : RECURSE_SUBMODULES_OFF; |
231 | 0 | config_update_recurse_submodules = v; |
232 | 0 | } |
233 | 0 | return 0; |
234 | 0 | } |
235 | | |
236 | | int option_parse_recurse_submodules_worktree_updater(const struct option *opt, |
237 | | const char *arg, int unset) |
238 | 0 | { |
239 | 0 | if (unset) { |
240 | 0 | config_update_recurse_submodules = RECURSE_SUBMODULES_OFF; |
241 | 0 | return 0; |
242 | 0 | } |
243 | 0 | if (arg) |
244 | 0 | config_update_recurse_submodules = |
245 | 0 | parse_update_recurse_submodules_arg(opt->long_name, |
246 | 0 | arg); |
247 | 0 | else |
248 | 0 | config_update_recurse_submodules = RECURSE_SUBMODULES_ON; |
249 | |
|
250 | 0 | return 0; |
251 | 0 | } |
252 | | |
253 | | /* |
254 | | * Determine if a submodule has been initialized at a given 'path' |
255 | | */ |
256 | | /* |
257 | | * NEEDSWORK: Emit a warning if submodule.active exists, but is valueless, |
258 | | * ie, the config looks like: "[submodule] active\n". |
259 | | * Since that is an invalid pathspec, we should inform the user. |
260 | | */ |
261 | | int is_tree_submodule_active(struct repository *repo, |
262 | | const struct object_id *treeish_name, |
263 | | const char *path) |
264 | 0 | { |
265 | 0 | int ret = 0; |
266 | 0 | char *key = NULL; |
267 | 0 | char *value = NULL; |
268 | 0 | const struct string_list *sl; |
269 | 0 | const struct submodule *module; |
270 | |
|
271 | 0 | module = submodule_from_path(repo, treeish_name, path); |
272 | | |
273 | | /* early return if there isn't a path->module mapping */ |
274 | 0 | if (!module) |
275 | 0 | return 0; |
276 | | |
277 | | /* submodule.<name>.active is set */ |
278 | 0 | key = xstrfmt("submodule.%s.active", module->name); |
279 | 0 | if (!repo_config_get_bool(repo, key, &ret)) { |
280 | 0 | free(key); |
281 | 0 | return ret; |
282 | 0 | } |
283 | 0 | free(key); |
284 | | |
285 | | /* submodule.active is set */ |
286 | 0 | if (!repo_config_get_string_multi(repo, "submodule.active", &sl)) { |
287 | 0 | struct pathspec ps; |
288 | 0 | struct strvec args = STRVEC_INIT; |
289 | 0 | const struct string_list_item *item; |
290 | |
|
291 | 0 | for_each_string_list_item(item, sl) { |
292 | 0 | strvec_push(&args, item->string); |
293 | 0 | } |
294 | |
|
295 | 0 | parse_pathspec(&ps, 0, 0, NULL, args.v); |
296 | 0 | ret = match_pathspec(repo->index, &ps, path, strlen(path), 0, NULL, 1); |
297 | |
|
298 | 0 | strvec_clear(&args); |
299 | 0 | clear_pathspec(&ps); |
300 | 0 | return ret; |
301 | 0 | } |
302 | | |
303 | | /* fallback to checking if the URL is set */ |
304 | 0 | key = xstrfmt("submodule.%s.url", module->name); |
305 | 0 | ret = !repo_config_get_string(repo, key, &value); |
306 | |
|
307 | 0 | free(value); |
308 | 0 | free(key); |
309 | 0 | return ret; |
310 | 0 | } |
311 | | |
312 | | int is_submodule_active(struct repository *repo, const char *path) |
313 | 0 | { |
314 | 0 | return is_tree_submodule_active(repo, null_oid(), path); |
315 | 0 | } |
316 | | |
317 | | int is_submodule_populated_gently(const char *path, int *return_error_code) |
318 | 0 | { |
319 | 0 | int ret = 0; |
320 | 0 | char *gitdir = xstrfmt("%s/.git", path); |
321 | |
|
322 | 0 | if (resolve_gitdir_gently(gitdir, return_error_code)) |
323 | 0 | ret = 1; |
324 | |
|
325 | 0 | free(gitdir); |
326 | 0 | return ret; |
327 | 0 | } |
328 | | |
329 | | /* |
330 | | * Dies if the provided 'prefix' corresponds to an unpopulated submodule |
331 | | */ |
332 | | void die_in_unpopulated_submodule(struct index_state *istate, |
333 | | const char *prefix) |
334 | 0 | { |
335 | 0 | int i, prefixlen; |
336 | |
|
337 | 0 | if (!prefix) |
338 | 0 | return; |
339 | | |
340 | 0 | prefixlen = strlen(prefix); |
341 | |
|
342 | 0 | for (i = 0; i < istate->cache_nr; i++) { |
343 | 0 | struct cache_entry *ce = istate->cache[i]; |
344 | 0 | int ce_len = ce_namelen(ce); |
345 | |
|
346 | 0 | if (!S_ISGITLINK(ce->ce_mode)) |
347 | 0 | continue; |
348 | 0 | if (prefixlen <= ce_len) |
349 | 0 | continue; |
350 | 0 | if (strncmp(ce->name, prefix, ce_len)) |
351 | 0 | continue; |
352 | 0 | if (prefix[ce_len] != '/') |
353 | 0 | continue; |
354 | | |
355 | 0 | die(_("in unpopulated submodule '%s'"), ce->name); |
356 | 0 | } |
357 | 0 | } |
358 | | |
359 | | /* |
360 | | * Dies if any paths in the provided pathspec descends into a submodule |
361 | | */ |
362 | | void die_path_inside_submodule(struct index_state *istate, |
363 | | const struct pathspec *ps) |
364 | 0 | { |
365 | 0 | int i, j; |
366 | |
|
367 | 0 | for (i = 0; i < istate->cache_nr; i++) { |
368 | 0 | struct cache_entry *ce = istate->cache[i]; |
369 | 0 | int ce_len = ce_namelen(ce); |
370 | |
|
371 | 0 | if (!S_ISGITLINK(ce->ce_mode)) |
372 | 0 | continue; |
373 | | |
374 | 0 | for (j = 0; j < ps->nr ; j++) { |
375 | 0 | const struct pathspec_item *item = &ps->items[j]; |
376 | |
|
377 | 0 | if (item->len <= ce_len) |
378 | 0 | continue; |
379 | 0 | if (item->match[ce_len] != '/') |
380 | 0 | continue; |
381 | 0 | if (strncmp(ce->name, item->match, ce_len)) |
382 | 0 | continue; |
383 | 0 | if (item->len == ce_len + 1) |
384 | 0 | continue; |
385 | | |
386 | 0 | die(_("Pathspec '%s' is in submodule '%.*s'"), |
387 | 0 | item->original, ce_len, ce->name); |
388 | 0 | } |
389 | 0 | } |
390 | 0 | } |
391 | | |
392 | | enum submodule_update_type parse_submodule_update_type(const char *value) |
393 | 0 | { |
394 | 0 | if (!strcmp(value, "none")) |
395 | 0 | return SM_UPDATE_NONE; |
396 | 0 | else if (!strcmp(value, "checkout")) |
397 | 0 | return SM_UPDATE_CHECKOUT; |
398 | 0 | else if (!strcmp(value, "rebase")) |
399 | 0 | return SM_UPDATE_REBASE; |
400 | 0 | else if (!strcmp(value, "merge")) |
401 | 0 | return SM_UPDATE_MERGE; |
402 | 0 | else if (*value == '!') |
403 | 0 | return SM_UPDATE_COMMAND; |
404 | 0 | else |
405 | 0 | return SM_UPDATE_UNSPECIFIED; |
406 | 0 | } |
407 | | |
408 | | int parse_submodule_update_strategy(const char *value, |
409 | | struct submodule_update_strategy *dst) |
410 | 0 | { |
411 | 0 | enum submodule_update_type type; |
412 | |
|
413 | 0 | free((void*)dst->command); |
414 | 0 | dst->command = NULL; |
415 | |
|
416 | 0 | type = parse_submodule_update_type(value); |
417 | 0 | if (type == SM_UPDATE_UNSPECIFIED) |
418 | 0 | return -1; |
419 | | |
420 | 0 | dst->type = type; |
421 | 0 | if (type == SM_UPDATE_COMMAND) |
422 | 0 | dst->command = xstrdup(value + 1); |
423 | |
|
424 | 0 | return 0; |
425 | 0 | } |
426 | | |
427 | | const char *submodule_update_type_to_string(enum submodule_update_type type) |
428 | 0 | { |
429 | 0 | switch (type) { |
430 | 0 | case SM_UPDATE_CHECKOUT: |
431 | 0 | return "checkout"; |
432 | 0 | case SM_UPDATE_MERGE: |
433 | 0 | return "merge"; |
434 | 0 | case SM_UPDATE_REBASE: |
435 | 0 | return "rebase"; |
436 | 0 | case SM_UPDATE_NONE: |
437 | 0 | return "none"; |
438 | 0 | case SM_UPDATE_UNSPECIFIED: |
439 | 0 | case SM_UPDATE_COMMAND: |
440 | 0 | BUG("init_submodule() should handle type %d", type); |
441 | 0 | default: |
442 | 0 | BUG("unexpected update strategy type: %d", type); |
443 | 0 | } |
444 | 0 | } |
445 | | |
446 | | void handle_ignore_submodules_arg(struct diff_options *diffopt, |
447 | | const char *arg) |
448 | 0 | { |
449 | 0 | diffopt->flags.ignore_submodule_set = 1; |
450 | 0 | diffopt->flags.ignore_submodules = 0; |
451 | 0 | diffopt->flags.ignore_untracked_in_submodules = 0; |
452 | 0 | diffopt->flags.ignore_dirty_submodules = 0; |
453 | |
|
454 | 0 | if (!strcmp(arg, "all")) |
455 | 0 | diffopt->flags.ignore_submodules = 1; |
456 | 0 | else if (!strcmp(arg, "untracked")) |
457 | 0 | diffopt->flags.ignore_untracked_in_submodules = 1; |
458 | 0 | else if (!strcmp(arg, "dirty")) |
459 | 0 | diffopt->flags.ignore_dirty_submodules = 1; |
460 | 0 | else if (strcmp(arg, "none")) |
461 | 0 | die(_("bad --ignore-submodules argument: %s"), arg); |
462 | | /* |
463 | | * Please update _git_status() in git-completion.bash when you |
464 | | * add new options |
465 | | */ |
466 | 0 | } |
467 | | |
468 | | static int prepare_submodule_diff_summary(struct repository *r, struct rev_info *rev, |
469 | | const char *path, |
470 | | struct commit *left, struct commit *right, |
471 | | struct commit_list *merge_bases) |
472 | 0 | { |
473 | 0 | struct commit_list *list; |
474 | |
|
475 | 0 | repo_init_revisions(r, rev, NULL); |
476 | 0 | setup_revisions(0, NULL, rev, NULL); |
477 | 0 | rev->left_right = 1; |
478 | 0 | rev->first_parent_only = 1; |
479 | 0 | left->object.flags |= SYMMETRIC_LEFT; |
480 | 0 | add_pending_object(rev, &left->object, path); |
481 | 0 | add_pending_object(rev, &right->object, path); |
482 | 0 | for (list = merge_bases; list; list = list->next) { |
483 | 0 | list->item->object.flags |= UNINTERESTING; |
484 | 0 | add_pending_object(rev, &list->item->object, |
485 | 0 | oid_to_hex(&list->item->object.oid)); |
486 | 0 | } |
487 | 0 | return prepare_revision_walk(rev); |
488 | 0 | } |
489 | | |
490 | | static void print_submodule_diff_summary(struct repository *r, struct rev_info *rev, struct diff_options *o) |
491 | 0 | { |
492 | 0 | static const char format[] = " %m %s"; |
493 | 0 | struct strbuf sb = STRBUF_INIT; |
494 | 0 | struct commit *commit; |
495 | |
|
496 | 0 | while ((commit = get_revision(rev))) { |
497 | 0 | struct pretty_print_context ctx = {0}; |
498 | 0 | ctx.date_mode = rev->date_mode; |
499 | 0 | ctx.output_encoding = get_log_output_encoding(); |
500 | 0 | strbuf_setlen(&sb, 0); |
501 | 0 | repo_format_commit_message(r, commit, format, &sb, |
502 | 0 | &ctx); |
503 | 0 | strbuf_addch(&sb, '\n'); |
504 | 0 | if (commit->object.flags & SYMMETRIC_LEFT) |
505 | 0 | diff_emit_submodule_del(o, sb.buf); |
506 | 0 | else |
507 | 0 | diff_emit_submodule_add(o, sb.buf); |
508 | 0 | } |
509 | 0 | strbuf_release(&sb); |
510 | 0 | } |
511 | | |
512 | | void prepare_submodule_repo_env(struct strvec *out) |
513 | 0 | { |
514 | 0 | prepare_other_repo_env(out, DEFAULT_GIT_DIR_ENVIRONMENT); |
515 | 0 | } |
516 | | |
517 | | static void prepare_submodule_repo_env_in_gitdir(struct strvec *out) |
518 | 0 | { |
519 | 0 | prepare_other_repo_env(out, "."); |
520 | 0 | } |
521 | | |
522 | | /* |
523 | | * Initialize a repository struct for a submodule based on the provided 'path'. |
524 | | * |
525 | | * Returns the repository struct on success, |
526 | | * NULL when the submodule is not present. |
527 | | */ |
528 | | static struct repository *open_submodule(const char *path) |
529 | 0 | { |
530 | 0 | struct strbuf sb = STRBUF_INIT; |
531 | 0 | struct repository *out = xmalloc(sizeof(*out)); |
532 | |
|
533 | 0 | if (submodule_to_gitdir(&sb, path) || repo_init(out, sb.buf, NULL)) { |
534 | 0 | strbuf_release(&sb); |
535 | 0 | free(out); |
536 | 0 | return NULL; |
537 | 0 | } |
538 | | |
539 | | /* Mark it as a submodule */ |
540 | 0 | out->submodule_prefix = xstrdup(path); |
541 | |
|
542 | 0 | strbuf_release(&sb); |
543 | 0 | return out; |
544 | 0 | } |
545 | | |
546 | | /* |
547 | | * Helper function to display the submodule header line prior to the full |
548 | | * summary output. |
549 | | * |
550 | | * If it can locate the submodule git directory it will create a repository |
551 | | * handle for the submodule and lookup both the left and right commits and |
552 | | * put them into the left and right pointers. |
553 | | */ |
554 | | static void show_submodule_header(struct diff_options *o, |
555 | | const char *path, |
556 | | struct object_id *one, struct object_id *two, |
557 | | unsigned dirty_submodule, |
558 | | struct repository *sub, |
559 | | struct commit **left, struct commit **right, |
560 | | struct commit_list **merge_bases) |
561 | 0 | { |
562 | 0 | const char *message = NULL; |
563 | 0 | struct strbuf sb = STRBUF_INIT; |
564 | 0 | int fast_forward = 0, fast_backward = 0; |
565 | |
|
566 | 0 | if (dirty_submodule & DIRTY_SUBMODULE_UNTRACKED) |
567 | 0 | diff_emit_submodule_untracked(o, path); |
568 | |
|
569 | 0 | if (dirty_submodule & DIRTY_SUBMODULE_MODIFIED) |
570 | 0 | diff_emit_submodule_modified(o, path); |
571 | |
|
572 | 0 | if (is_null_oid(one)) |
573 | 0 | message = "(new submodule)"; |
574 | 0 | else if (is_null_oid(two)) |
575 | 0 | message = "(submodule deleted)"; |
576 | |
|
577 | 0 | if (!sub) { |
578 | 0 | if (!message) |
579 | 0 | message = "(commits not present)"; |
580 | 0 | goto output_header; |
581 | 0 | } |
582 | | |
583 | | /* |
584 | | * Attempt to lookup the commit references, and determine if this is |
585 | | * a fast forward or fast backwards update. |
586 | | */ |
587 | 0 | *left = lookup_commit_reference(sub, one); |
588 | 0 | *right = lookup_commit_reference(sub, two); |
589 | | |
590 | | /* |
591 | | * Warn about missing commits in the submodule project, but only if |
592 | | * they aren't null. |
593 | | */ |
594 | 0 | if ((!is_null_oid(one) && !*left) || |
595 | 0 | (!is_null_oid(two) && !*right)) |
596 | 0 | message = "(commits not present)"; |
597 | |
|
598 | 0 | *merge_bases = NULL; |
599 | 0 | if (repo_get_merge_bases(sub, *left, *right, merge_bases) < 0) { |
600 | 0 | message = "(corrupt repository)"; |
601 | 0 | goto output_header; |
602 | 0 | } |
603 | | |
604 | 0 | if (*merge_bases) { |
605 | 0 | if ((*merge_bases)->item == *left) |
606 | 0 | fast_forward = 1; |
607 | 0 | else if ((*merge_bases)->item == *right) |
608 | 0 | fast_backward = 1; |
609 | 0 | } |
610 | |
|
611 | 0 | if (oideq(one, two)) { |
612 | 0 | strbuf_release(&sb); |
613 | 0 | return; |
614 | 0 | } |
615 | | |
616 | 0 | output_header: |
617 | 0 | strbuf_addf(&sb, "Submodule %s ", path); |
618 | 0 | strbuf_add_unique_abbrev(&sb, one, DEFAULT_ABBREV); |
619 | 0 | strbuf_addstr(&sb, (fast_backward || fast_forward) ? ".." : "..."); |
620 | 0 | strbuf_add_unique_abbrev(&sb, two, DEFAULT_ABBREV); |
621 | 0 | if (message) |
622 | 0 | strbuf_addf(&sb, " %s\n", message); |
623 | 0 | else |
624 | 0 | strbuf_addf(&sb, "%s:\n", fast_backward ? " (rewind)" : ""); |
625 | 0 | diff_emit_submodule_header(o, sb.buf); |
626 | |
|
627 | 0 | strbuf_release(&sb); |
628 | 0 | } |
629 | | |
630 | | void show_submodule_diff_summary(struct diff_options *o, const char *path, |
631 | | struct object_id *one, struct object_id *two, |
632 | | unsigned dirty_submodule) |
633 | 0 | { |
634 | 0 | struct rev_info rev = REV_INFO_INIT; |
635 | 0 | struct commit *left = NULL, *right = NULL; |
636 | 0 | struct commit_list *merge_bases = NULL; |
637 | 0 | struct repository *sub; |
638 | |
|
639 | 0 | sub = open_submodule(path); |
640 | 0 | show_submodule_header(o, path, one, two, dirty_submodule, |
641 | 0 | sub, &left, &right, &merge_bases); |
642 | | |
643 | | /* |
644 | | * If we don't have both a left and a right pointer, there is no |
645 | | * reason to try and display a summary. The header line should contain |
646 | | * all the information the user needs. |
647 | | */ |
648 | 0 | if (!left || !right || !sub) |
649 | 0 | goto out; |
650 | | |
651 | | /* Treat revision walker failure the same as missing commits */ |
652 | 0 | if (prepare_submodule_diff_summary(sub, &rev, path, left, right, merge_bases)) { |
653 | 0 | diff_emit_submodule_error(o, "(revision walker failed)\n"); |
654 | 0 | goto out; |
655 | 0 | } |
656 | | |
657 | 0 | print_submodule_diff_summary(sub, &rev, o); |
658 | |
|
659 | 0 | out: |
660 | 0 | free_commit_list(merge_bases); |
661 | 0 | release_revisions(&rev); |
662 | 0 | clear_commit_marks(left, ~0); |
663 | 0 | clear_commit_marks(right, ~0); |
664 | 0 | if (sub) { |
665 | 0 | repo_clear(sub); |
666 | 0 | free(sub); |
667 | 0 | } |
668 | 0 | } |
669 | | |
670 | | void show_submodule_inline_diff(struct diff_options *o, const char *path, |
671 | | struct object_id *one, struct object_id *two, |
672 | | unsigned dirty_submodule) |
673 | 0 | { |
674 | 0 | const struct object_id *old_oid = the_hash_algo->empty_tree, *new_oid = the_hash_algo->empty_tree; |
675 | 0 | struct commit *left = NULL, *right = NULL; |
676 | 0 | struct commit_list *merge_bases = NULL; |
677 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
678 | 0 | struct strbuf sb = STRBUF_INIT; |
679 | 0 | struct repository *sub; |
680 | |
|
681 | 0 | sub = open_submodule(path); |
682 | 0 | show_submodule_header(o, path, one, two, dirty_submodule, |
683 | 0 | sub, &left, &right, &merge_bases); |
684 | | |
685 | | /* We need a valid left and right commit to display a difference */ |
686 | 0 | if (!(left || is_null_oid(one)) || |
687 | 0 | !(right || is_null_oid(two))) |
688 | 0 | goto done; |
689 | | |
690 | 0 | if (left) |
691 | 0 | old_oid = one; |
692 | 0 | if (right) |
693 | 0 | new_oid = two; |
694 | |
|
695 | 0 | cp.git_cmd = 1; |
696 | 0 | cp.dir = path; |
697 | 0 | cp.out = -1; |
698 | 0 | cp.no_stdin = 1; |
699 | | |
700 | | /* TODO: other options may need to be passed here. */ |
701 | 0 | strvec_pushl(&cp.args, "diff", "--submodule=diff", NULL); |
702 | 0 | strvec_pushf(&cp.args, "--color=%s", want_color(o->use_color) ? |
703 | 0 | "always" : "never"); |
704 | |
|
705 | 0 | if (o->flags.reverse_diff) { |
706 | 0 | strvec_pushf(&cp.args, "--src-prefix=%s%s/", |
707 | 0 | o->b_prefix, path); |
708 | 0 | strvec_pushf(&cp.args, "--dst-prefix=%s%s/", |
709 | 0 | o->a_prefix, path); |
710 | 0 | } else { |
711 | 0 | strvec_pushf(&cp.args, "--src-prefix=%s%s/", |
712 | 0 | o->a_prefix, path); |
713 | 0 | strvec_pushf(&cp.args, "--dst-prefix=%s%s/", |
714 | 0 | o->b_prefix, path); |
715 | 0 | } |
716 | 0 | strvec_push(&cp.args, oid_to_hex(old_oid)); |
717 | | /* |
718 | | * If the submodule has modified content, we will diff against the |
719 | | * work tree, under the assumption that the user has asked for the |
720 | | * diff format and wishes to actually see all differences even if they |
721 | | * haven't yet been committed to the submodule yet. |
722 | | */ |
723 | 0 | if (!(dirty_submodule & DIRTY_SUBMODULE_MODIFIED)) |
724 | 0 | strvec_push(&cp.args, oid_to_hex(new_oid)); |
725 | |
|
726 | 0 | prepare_submodule_repo_env(&cp.env); |
727 | |
|
728 | 0 | if (!is_directory(path)) { |
729 | | /* fall back to absorbed git dir, if any */ |
730 | 0 | if (!sub) |
731 | 0 | goto done; |
732 | 0 | cp.dir = sub->gitdir; |
733 | 0 | strvec_push(&cp.env, GIT_DIR_ENVIRONMENT "=."); |
734 | 0 | strvec_push(&cp.env, GIT_WORK_TREE_ENVIRONMENT "=."); |
735 | 0 | } |
736 | | |
737 | 0 | if (start_command(&cp)) { |
738 | 0 | diff_emit_submodule_error(o, "(diff failed)\n"); |
739 | 0 | goto done; |
740 | 0 | } |
741 | | |
742 | 0 | while (strbuf_getwholeline_fd(&sb, cp.out, '\n') != EOF) |
743 | 0 | diff_emit_submodule_pipethrough(o, sb.buf, sb.len); |
744 | |
|
745 | 0 | if (finish_command(&cp)) |
746 | 0 | diff_emit_submodule_error(o, "(diff failed)\n"); |
747 | |
|
748 | 0 | done: |
749 | 0 | strbuf_release(&sb); |
750 | 0 | free_commit_list(merge_bases); |
751 | 0 | if (left) |
752 | 0 | clear_commit_marks(left, ~0); |
753 | 0 | if (right) |
754 | 0 | clear_commit_marks(right, ~0); |
755 | 0 | if (sub) { |
756 | 0 | repo_clear(sub); |
757 | 0 | free(sub); |
758 | 0 | } |
759 | 0 | } |
760 | | |
761 | | int should_update_submodules(void) |
762 | 0 | { |
763 | 0 | return config_update_recurse_submodules == RECURSE_SUBMODULES_ON; |
764 | 0 | } |
765 | | |
766 | | const struct submodule *submodule_from_ce(const struct cache_entry *ce) |
767 | 0 | { |
768 | 0 | if (!S_ISGITLINK(ce->ce_mode)) |
769 | 0 | return NULL; |
770 | | |
771 | 0 | if (!should_update_submodules()) |
772 | 0 | return NULL; |
773 | | |
774 | 0 | return submodule_from_path(the_repository, null_oid(), ce->name); |
775 | 0 | } |
776 | | |
777 | | |
778 | | struct collect_changed_submodules_cb_data { |
779 | | struct repository *repo; |
780 | | struct string_list *changed; |
781 | | const struct object_id *commit_oid; |
782 | | }; |
783 | | |
784 | | /* |
785 | | * this would normally be two functions: default_name_from_path() and |
786 | | * path_from_default_name(). Since the default name is the same as |
787 | | * the submodule path we can get away with just one function which only |
788 | | * checks whether there is a submodule in the working directory at that |
789 | | * location. |
790 | | */ |
791 | | static const char *default_name_or_path(const char *path_or_name) |
792 | 0 | { |
793 | 0 | int error_code; |
794 | |
|
795 | 0 | if (!is_submodule_populated_gently(path_or_name, &error_code)) |
796 | 0 | return NULL; |
797 | | |
798 | 0 | return path_or_name; |
799 | 0 | } |
800 | | |
801 | | /* |
802 | | * Holds relevant information for a changed submodule. Used as the .util |
803 | | * member of the changed submodule name string_list_item. |
804 | | * |
805 | | * (super_oid, path) allows the submodule config to be read from _some_ |
806 | | * .gitmodules file. We store this information the first time we find a |
807 | | * superproject commit that points to the submodule, but this is |
808 | | * arbitrary - we can choose any (super_oid, path) that matches the |
809 | | * submodule's name. |
810 | | * |
811 | | * NEEDSWORK: Storing an arbitrary commit is undesirable because we can't |
812 | | * guarantee that we're reading the commit that the user would expect. A better |
813 | | * scheme would be to just fetch a submodule by its name. This requires two |
814 | | * steps: |
815 | | * - Create a function that behaves like repo_submodule_init(), but accepts a |
816 | | * submodule name instead of treeish_name and path. This should be easy |
817 | | * because repo_submodule_init() internally uses the submodule's name. |
818 | | * |
819 | | * - Replace most instances of 'struct submodule' (which is the .gitmodules |
820 | | * config) with just the submodule name. This is OK because we expect |
821 | | * submodule settings to be stored in .git/config (via "git submodule init"), |
822 | | * not .gitmodules. This also lets us delete get_non_gitmodules_submodule(), |
823 | | * which constructs a bogus 'struct submodule' for the sake of giving a |
824 | | * placeholder name to a gitlink. |
825 | | */ |
826 | | struct changed_submodule_data { |
827 | | /* |
828 | | * The first superproject commit in the rev walk that points to |
829 | | * the submodule. |
830 | | */ |
831 | | const struct object_id *super_oid; |
832 | | /* |
833 | | * Path to the submodule in the superproject commit referenced |
834 | | * by 'super_oid'. |
835 | | */ |
836 | | char *path; |
837 | | /* The submodule commits that have changed in the rev walk. */ |
838 | | struct oid_array new_commits; |
839 | | }; |
840 | | |
841 | | static void changed_submodule_data_clear(struct changed_submodule_data *cs_data) |
842 | 0 | { |
843 | 0 | oid_array_clear(&cs_data->new_commits); |
844 | 0 | free(cs_data->path); |
845 | 0 | } |
846 | | |
847 | | static void collect_changed_submodules_cb(struct diff_queue_struct *q, |
848 | | struct diff_options *options UNUSED, |
849 | | void *data) |
850 | 0 | { |
851 | 0 | struct collect_changed_submodules_cb_data *me = data; |
852 | 0 | struct string_list *changed = me->changed; |
853 | 0 | const struct object_id *commit_oid = me->commit_oid; |
854 | 0 | int i; |
855 | |
|
856 | 0 | for (i = 0; i < q->nr; i++) { |
857 | 0 | struct diff_filepair *p = q->queue[i]; |
858 | 0 | const struct submodule *submodule; |
859 | 0 | const char *name; |
860 | 0 | struct string_list_item *item; |
861 | 0 | struct changed_submodule_data *cs_data; |
862 | |
|
863 | 0 | if (!S_ISGITLINK(p->two->mode)) |
864 | 0 | continue; |
865 | | |
866 | 0 | submodule = submodule_from_path(me->repo, |
867 | 0 | commit_oid, p->two->path); |
868 | 0 | if (submodule) |
869 | 0 | name = submodule->name; |
870 | 0 | else { |
871 | 0 | name = default_name_or_path(p->two->path); |
872 | | /* make sure name does not collide with existing one */ |
873 | 0 | if (name) |
874 | 0 | submodule = submodule_from_name(me->repo, |
875 | 0 | commit_oid, name); |
876 | 0 | if (submodule) { |
877 | 0 | warning(_("Submodule in commit %s at path: " |
878 | 0 | "'%s' collides with a submodule named " |
879 | 0 | "the same. Skipping it."), |
880 | 0 | oid_to_hex(commit_oid), p->two->path); |
881 | 0 | name = NULL; |
882 | 0 | } |
883 | 0 | } |
884 | |
|
885 | 0 | if (!name) |
886 | 0 | continue; |
887 | | |
888 | 0 | item = string_list_insert(changed, name); |
889 | 0 | if (item->util) |
890 | 0 | cs_data = item->util; |
891 | 0 | else { |
892 | 0 | item->util = xcalloc(1, sizeof(struct changed_submodule_data)); |
893 | 0 | cs_data = item->util; |
894 | 0 | cs_data->super_oid = commit_oid; |
895 | 0 | cs_data->path = xstrdup(p->two->path); |
896 | 0 | } |
897 | 0 | oid_array_append(&cs_data->new_commits, &p->two->oid); |
898 | 0 | } |
899 | 0 | } |
900 | | |
901 | | /* |
902 | | * Collect the paths of submodules in 'changed' which have changed based on |
903 | | * the revisions as specified in 'argv'. Each entry in 'changed' will also |
904 | | * have a corresponding 'struct oid_array' (in the 'util' field) which lists |
905 | | * what the submodule pointers were updated to during the change. |
906 | | */ |
907 | | static void collect_changed_submodules(struct repository *r, |
908 | | struct string_list *changed, |
909 | | struct strvec *argv) |
910 | 0 | { |
911 | 0 | struct rev_info rev; |
912 | 0 | const struct commit *commit; |
913 | 0 | int save_warning; |
914 | 0 | struct setup_revision_opt s_r_opt = { |
915 | 0 | .assume_dashdash = 1, |
916 | 0 | }; |
917 | |
|
918 | 0 | save_warning = warn_on_object_refname_ambiguity; |
919 | 0 | warn_on_object_refname_ambiguity = 0; |
920 | 0 | repo_init_revisions(r, &rev, NULL); |
921 | 0 | setup_revisions(argv->nr, argv->v, &rev, &s_r_opt); |
922 | 0 | warn_on_object_refname_ambiguity = save_warning; |
923 | 0 | if (prepare_revision_walk(&rev)) |
924 | 0 | die(_("revision walk setup failed")); |
925 | | |
926 | 0 | while ((commit = get_revision(&rev))) { |
927 | 0 | struct rev_info diff_rev; |
928 | 0 | struct collect_changed_submodules_cb_data data; |
929 | 0 | data.repo = r; |
930 | 0 | data.changed = changed; |
931 | 0 | data.commit_oid = &commit->object.oid; |
932 | |
|
933 | 0 | repo_init_revisions(r, &diff_rev, NULL); |
934 | 0 | diff_rev.diffopt.output_format |= DIFF_FORMAT_CALLBACK; |
935 | 0 | diff_rev.diffopt.format_callback = collect_changed_submodules_cb; |
936 | 0 | diff_rev.diffopt.format_callback_data = &data; |
937 | 0 | diff_rev.dense_combined_merges = 1; |
938 | 0 | diff_tree_combined_merge(commit, &diff_rev); |
939 | 0 | release_revisions(&diff_rev); |
940 | 0 | } |
941 | |
|
942 | 0 | reset_revision_walk(); |
943 | 0 | release_revisions(&rev); |
944 | 0 | } |
945 | | |
946 | | static void free_submodules_data(struct string_list *submodules) |
947 | 0 | { |
948 | 0 | struct string_list_item *item; |
949 | 0 | for_each_string_list_item(item, submodules) |
950 | 0 | changed_submodule_data_clear(item->util); |
951 | |
|
952 | 0 | string_list_clear(submodules, 1); |
953 | 0 | } |
954 | | |
955 | | static int has_remote(const char *refname UNUSED, |
956 | | const char *referent UNUSED, |
957 | | const struct object_id *oid UNUSED, |
958 | | int flags UNUSED, void *cb_data UNUSED) |
959 | 0 | { |
960 | 0 | return 1; |
961 | 0 | } |
962 | | |
963 | | static int append_oid_to_argv(const struct object_id *oid, void *data) |
964 | 0 | { |
965 | 0 | struct strvec *argv = data; |
966 | 0 | strvec_push(argv, oid_to_hex(oid)); |
967 | 0 | return 0; |
968 | 0 | } |
969 | | |
970 | | struct has_commit_data { |
971 | | struct repository *repo; |
972 | | int result; |
973 | | const char *path; |
974 | | const struct object_id *super_oid; |
975 | | }; |
976 | | |
977 | | static int check_has_commit(const struct object_id *oid, void *data) |
978 | 0 | { |
979 | 0 | struct has_commit_data *cb = data; |
980 | 0 | struct repository subrepo; |
981 | 0 | enum object_type type; |
982 | |
|
983 | 0 | if (repo_submodule_init(&subrepo, cb->repo, cb->path, cb->super_oid)) { |
984 | 0 | cb->result = 0; |
985 | | /* subrepo failed to init, so don't clean it up. */ |
986 | 0 | return 0; |
987 | 0 | } |
988 | | |
989 | 0 | type = oid_object_info(&subrepo, oid, NULL); |
990 | |
|
991 | 0 | switch (type) { |
992 | 0 | case OBJ_COMMIT: |
993 | 0 | goto cleanup; |
994 | 0 | case OBJ_BAD: |
995 | | /* |
996 | | * Object is missing or invalid. If invalid, an error message |
997 | | * has already been printed. |
998 | | */ |
999 | 0 | cb->result = 0; |
1000 | 0 | goto cleanup; |
1001 | 0 | default: |
1002 | 0 | die(_("submodule entry '%s' (%s) is a %s, not a commit"), |
1003 | 0 | cb->path, oid_to_hex(oid), type_name(type)); |
1004 | 0 | } |
1005 | 0 | cleanup: |
1006 | 0 | repo_clear(&subrepo); |
1007 | 0 | return 0; |
1008 | 0 | } |
1009 | | |
1010 | | static int submodule_has_commits(struct repository *r, |
1011 | | const char *path, |
1012 | | const struct object_id *super_oid, |
1013 | | struct oid_array *commits) |
1014 | 0 | { |
1015 | 0 | struct has_commit_data has_commit = { |
1016 | 0 | .repo = r, |
1017 | 0 | .result = 1, |
1018 | 0 | .path = path, |
1019 | 0 | .super_oid = super_oid |
1020 | 0 | }; |
1021 | |
|
1022 | 0 | if (validate_submodule_path(path) < 0) |
1023 | 0 | exit(128); |
1024 | | |
1025 | 0 | oid_array_for_each_unique(commits, check_has_commit, &has_commit); |
1026 | |
|
1027 | 0 | if (has_commit.result) { |
1028 | | /* |
1029 | | * Even if the submodule is checked out and the commit is |
1030 | | * present, make sure it exists in the submodule's object store |
1031 | | * and that it is reachable from a ref. |
1032 | | */ |
1033 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
1034 | 0 | struct strbuf out = STRBUF_INIT; |
1035 | |
|
1036 | 0 | strvec_pushl(&cp.args, "rev-list", "-n", "1", NULL); |
1037 | 0 | oid_array_for_each_unique(commits, append_oid_to_argv, &cp.args); |
1038 | 0 | strvec_pushl(&cp.args, "--not", "--all", NULL); |
1039 | |
|
1040 | 0 | prepare_submodule_repo_env(&cp.env); |
1041 | 0 | cp.git_cmd = 1; |
1042 | 0 | cp.no_stdin = 1; |
1043 | 0 | cp.dir = path; |
1044 | |
|
1045 | 0 | if (capture_command(&cp, &out, GIT_MAX_HEXSZ + 1) || out.len) |
1046 | 0 | has_commit.result = 0; |
1047 | |
|
1048 | 0 | strbuf_release(&out); |
1049 | 0 | } |
1050 | |
|
1051 | 0 | return has_commit.result; |
1052 | 0 | } |
1053 | | |
1054 | | static int submodule_needs_pushing(struct repository *r, |
1055 | | const char *path, |
1056 | | struct oid_array *commits) |
1057 | 0 | { |
1058 | 0 | if (!submodule_has_commits(r, path, null_oid(), commits)) |
1059 | | /* |
1060 | | * NOTE: We do consider it safe to return "no" here. The |
1061 | | * correct answer would be "We do not know" instead of |
1062 | | * "No push needed", but it is quite hard to change |
1063 | | * the submodule pointer without having the submodule |
1064 | | * around. If a user did however change the submodules |
1065 | | * without having the submodule around, this indicates |
1066 | | * an expert who knows what they are doing or a |
1067 | | * maintainer integrating work from other people. In |
1068 | | * both cases it should be safe to skip this check. |
1069 | | */ |
1070 | 0 | return 0; |
1071 | | |
1072 | 0 | if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) { |
1073 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
1074 | 0 | struct strbuf buf = STRBUF_INIT; |
1075 | 0 | int needs_pushing = 0; |
1076 | |
|
1077 | 0 | strvec_push(&cp.args, "rev-list"); |
1078 | 0 | oid_array_for_each_unique(commits, append_oid_to_argv, &cp.args); |
1079 | 0 | strvec_pushl(&cp.args, "--not", "--remotes", "-n", "1" , NULL); |
1080 | |
|
1081 | 0 | prepare_submodule_repo_env(&cp.env); |
1082 | 0 | cp.git_cmd = 1; |
1083 | 0 | cp.no_stdin = 1; |
1084 | 0 | cp.out = -1; |
1085 | 0 | cp.dir = path; |
1086 | 0 | if (start_command(&cp)) |
1087 | 0 | die(_("Could not run 'git rev-list <commits> --not --remotes -n 1' command in submodule %s"), |
1088 | 0 | path); |
1089 | 0 | if (strbuf_read(&buf, cp.out, the_hash_algo->hexsz + 1)) |
1090 | 0 | needs_pushing = 1; |
1091 | 0 | finish_command(&cp); |
1092 | 0 | close(cp.out); |
1093 | 0 | strbuf_release(&buf); |
1094 | 0 | return needs_pushing; |
1095 | 0 | } |
1096 | | |
1097 | 0 | return 0; |
1098 | 0 | } |
1099 | | |
1100 | | int find_unpushed_submodules(struct repository *r, |
1101 | | struct oid_array *commits, |
1102 | | const char *remotes_name, |
1103 | | struct string_list *needs_pushing) |
1104 | 0 | { |
1105 | 0 | struct string_list submodules = STRING_LIST_INIT_DUP; |
1106 | 0 | struct string_list_item *name; |
1107 | 0 | struct strvec argv = STRVEC_INIT; |
1108 | | |
1109 | | /* argv.v[0] will be ignored by setup_revisions */ |
1110 | 0 | strvec_push(&argv, "find_unpushed_submodules"); |
1111 | 0 | oid_array_for_each_unique(commits, append_oid_to_argv, &argv); |
1112 | 0 | strvec_push(&argv, "--not"); |
1113 | 0 | strvec_pushf(&argv, "--remotes=%s", remotes_name); |
1114 | |
|
1115 | 0 | collect_changed_submodules(r, &submodules, &argv); |
1116 | |
|
1117 | 0 | for_each_string_list_item(name, &submodules) { |
1118 | 0 | struct changed_submodule_data *cs_data = name->util; |
1119 | 0 | const struct submodule *submodule; |
1120 | 0 | const char *path = NULL; |
1121 | |
|
1122 | 0 | submodule = submodule_from_name(r, null_oid(), name->string); |
1123 | 0 | if (submodule) |
1124 | 0 | path = submodule->path; |
1125 | 0 | else |
1126 | 0 | path = default_name_or_path(name->string); |
1127 | |
|
1128 | 0 | if (!path) |
1129 | 0 | continue; |
1130 | | |
1131 | 0 | if (submodule_needs_pushing(r, path, &cs_data->new_commits)) |
1132 | 0 | string_list_insert(needs_pushing, path); |
1133 | 0 | } |
1134 | |
|
1135 | 0 | free_submodules_data(&submodules); |
1136 | 0 | strvec_clear(&argv); |
1137 | |
|
1138 | 0 | return needs_pushing->nr; |
1139 | 0 | } |
1140 | | |
1141 | | static int push_submodule(const char *path, |
1142 | | const struct remote *remote, |
1143 | | const struct refspec *rs, |
1144 | | const struct string_list *push_options, |
1145 | | int dry_run) |
1146 | 0 | { |
1147 | 0 | if (validate_submodule_path(path) < 0) |
1148 | 0 | exit(128); |
1149 | | |
1150 | 0 | if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) { |
1151 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
1152 | 0 | strvec_push(&cp.args, "push"); |
1153 | | /* |
1154 | | * When recursing into a submodule, treat any "only" configurations as "on- |
1155 | | * demand", since "only" would not work (we need all submodules to be pushed |
1156 | | * in order to be able to push the superproject). |
1157 | | */ |
1158 | 0 | strvec_push(&cp.args, "--recurse-submodules=only-is-on-demand"); |
1159 | 0 | if (dry_run) |
1160 | 0 | strvec_push(&cp.args, "--dry-run"); |
1161 | |
|
1162 | 0 | if (push_options && push_options->nr) { |
1163 | 0 | const struct string_list_item *item; |
1164 | 0 | for_each_string_list_item(item, push_options) |
1165 | 0 | strvec_pushf(&cp.args, "--push-option=%s", |
1166 | 0 | item->string); |
1167 | 0 | } |
1168 | |
|
1169 | 0 | if (remote->origin != REMOTE_UNCONFIGURED) { |
1170 | 0 | int i; |
1171 | 0 | strvec_push(&cp.args, remote->name); |
1172 | 0 | for (i = 0; i < rs->raw_nr; i++) |
1173 | 0 | strvec_push(&cp.args, rs->raw[i]); |
1174 | 0 | } |
1175 | |
|
1176 | 0 | prepare_submodule_repo_env(&cp.env); |
1177 | 0 | cp.git_cmd = 1; |
1178 | 0 | cp.no_stdin = 1; |
1179 | 0 | cp.dir = path; |
1180 | 0 | if (run_command(&cp)) |
1181 | 0 | return 0; |
1182 | 0 | close(cp.out); |
1183 | 0 | } |
1184 | | |
1185 | 0 | return 1; |
1186 | 0 | } |
1187 | | |
1188 | | /* |
1189 | | * Perform a check in the submodule to see if the remote and refspec work. |
1190 | | * Die if the submodule can't be pushed. |
1191 | | */ |
1192 | | static void submodule_push_check(const char *path, const char *head, |
1193 | | const struct remote *remote, |
1194 | | const struct refspec *rs) |
1195 | 0 | { |
1196 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
1197 | 0 | int i; |
1198 | |
|
1199 | 0 | if (validate_submodule_path(path) < 0) |
1200 | 0 | exit(128); |
1201 | | |
1202 | 0 | strvec_push(&cp.args, "submodule--helper"); |
1203 | 0 | strvec_push(&cp.args, "push-check"); |
1204 | 0 | strvec_push(&cp.args, head); |
1205 | 0 | strvec_push(&cp.args, remote->name); |
1206 | |
|
1207 | 0 | for (i = 0; i < rs->raw_nr; i++) |
1208 | 0 | strvec_push(&cp.args, rs->raw[i]); |
1209 | |
|
1210 | 0 | prepare_submodule_repo_env(&cp.env); |
1211 | 0 | cp.git_cmd = 1; |
1212 | 0 | cp.no_stdin = 1; |
1213 | 0 | cp.no_stdout = 1; |
1214 | 0 | cp.dir = path; |
1215 | | |
1216 | | /* |
1217 | | * Simply indicate if 'submodule--helper push-check' failed. |
1218 | | * More detailed error information will be provided by the |
1219 | | * child process. |
1220 | | */ |
1221 | 0 | if (run_command(&cp)) |
1222 | 0 | die(_("process for submodule '%s' failed"), path); |
1223 | 0 | } |
1224 | | |
1225 | | int push_unpushed_submodules(struct repository *r, |
1226 | | struct oid_array *commits, |
1227 | | const struct remote *remote, |
1228 | | const struct refspec *rs, |
1229 | | const struct string_list *push_options, |
1230 | | int dry_run) |
1231 | 0 | { |
1232 | 0 | int i, ret = 1; |
1233 | 0 | struct string_list needs_pushing = STRING_LIST_INIT_DUP; |
1234 | |
|
1235 | 0 | if (!find_unpushed_submodules(r, commits, |
1236 | 0 | remote->name, &needs_pushing)) |
1237 | 0 | return 1; |
1238 | | |
1239 | | /* |
1240 | | * Verify that the remote and refspec can be propagated to all |
1241 | | * submodules. This check can be skipped if the remote and refspec |
1242 | | * won't be propagated due to the remote being unconfigured (e.g. a URL |
1243 | | * instead of a remote name). |
1244 | | */ |
1245 | 0 | if (remote->origin != REMOTE_UNCONFIGURED) { |
1246 | 0 | char *head; |
1247 | 0 | struct object_id head_oid; |
1248 | |
|
1249 | 0 | head = refs_resolve_refdup(get_main_ref_store(the_repository), |
1250 | 0 | "HEAD", 0, &head_oid, NULL); |
1251 | 0 | if (!head) |
1252 | 0 | die(_("Failed to resolve HEAD as a valid ref.")); |
1253 | | |
1254 | 0 | for (i = 0; i < needs_pushing.nr; i++) |
1255 | 0 | submodule_push_check(needs_pushing.items[i].string, |
1256 | 0 | head, remote, rs); |
1257 | 0 | free(head); |
1258 | 0 | } |
1259 | | |
1260 | | /* Actually push the submodules */ |
1261 | 0 | for (i = 0; i < needs_pushing.nr; i++) { |
1262 | 0 | const char *path = needs_pushing.items[i].string; |
1263 | 0 | fprintf(stderr, _("Pushing submodule '%s'\n"), path); |
1264 | 0 | if (!push_submodule(path, remote, rs, |
1265 | 0 | push_options, dry_run)) { |
1266 | 0 | fprintf(stderr, _("Unable to push submodule '%s'\n"), path); |
1267 | 0 | ret = 0; |
1268 | 0 | } |
1269 | 0 | } |
1270 | |
|
1271 | 0 | string_list_clear(&needs_pushing, 0); |
1272 | |
|
1273 | 0 | return ret; |
1274 | 0 | } |
1275 | | |
1276 | | static int append_oid_to_array(const char *ref UNUSED, |
1277 | | const char *referent UNUSED, |
1278 | | const struct object_id *oid, |
1279 | | int flags UNUSED, void *data) |
1280 | 0 | { |
1281 | 0 | struct oid_array *array = data; |
1282 | 0 | oid_array_append(array, oid); |
1283 | 0 | return 0; |
1284 | 0 | } |
1285 | | |
1286 | | void check_for_new_submodule_commits(struct object_id *oid) |
1287 | 0 | { |
1288 | 0 | if (!initialized_fetch_ref_tips) { |
1289 | 0 | refs_for_each_ref(get_main_ref_store(the_repository), |
1290 | 0 | append_oid_to_array, &ref_tips_before_fetch); |
1291 | 0 | initialized_fetch_ref_tips = 1; |
1292 | 0 | } |
1293 | |
|
1294 | 0 | oid_array_append(&ref_tips_after_fetch, oid); |
1295 | 0 | } |
1296 | | |
1297 | | /* |
1298 | | * Returns 1 if there is at least one submodule gitdir in |
1299 | | * $GIT_DIR/modules and 0 otherwise. This follows |
1300 | | * submodule_name_to_gitdir(), which looks for submodules in |
1301 | | * $GIT_DIR/modules, not $GIT_COMMON_DIR. |
1302 | | * |
1303 | | * A submodule can be moved to $GIT_DIR/modules manually by running "git |
1304 | | * submodule absorbgitdirs", or it may be initialized there by "git |
1305 | | * submodule update". |
1306 | | */ |
1307 | | static int repo_has_absorbed_submodules(struct repository *r) |
1308 | 0 | { |
1309 | 0 | int ret; |
1310 | 0 | struct strbuf buf = STRBUF_INIT; |
1311 | |
|
1312 | 0 | strbuf_repo_git_path(&buf, r, "modules/"); |
1313 | 0 | ret = file_exists(buf.buf) && !is_empty_dir(buf.buf); |
1314 | 0 | strbuf_release(&buf); |
1315 | 0 | return ret; |
1316 | 0 | } |
1317 | | |
1318 | | static void calculate_changed_submodule_paths(struct repository *r, |
1319 | | struct string_list *changed_submodule_names) |
1320 | 0 | { |
1321 | 0 | struct strvec argv = STRVEC_INIT; |
1322 | 0 | struct string_list_item *name; |
1323 | | |
1324 | | /* No need to check if no submodules would be fetched */ |
1325 | 0 | if (!submodule_from_path(r, NULL, NULL) && |
1326 | 0 | !repo_has_absorbed_submodules(r)) |
1327 | 0 | return; |
1328 | | |
1329 | 0 | strvec_push(&argv, "--"); /* argv[0] program name */ |
1330 | 0 | oid_array_for_each_unique(&ref_tips_after_fetch, |
1331 | 0 | append_oid_to_argv, &argv); |
1332 | 0 | strvec_push(&argv, "--not"); |
1333 | 0 | oid_array_for_each_unique(&ref_tips_before_fetch, |
1334 | 0 | append_oid_to_argv, &argv); |
1335 | | |
1336 | | /* |
1337 | | * Collect all submodules (whether checked out or not) for which new |
1338 | | * commits have been recorded upstream in "changed_submodule_names". |
1339 | | */ |
1340 | 0 | collect_changed_submodules(r, changed_submodule_names, &argv); |
1341 | |
|
1342 | 0 | for_each_string_list_item(name, changed_submodule_names) { |
1343 | 0 | struct changed_submodule_data *cs_data = name->util; |
1344 | 0 | const struct submodule *submodule; |
1345 | 0 | const char *path = NULL; |
1346 | |
|
1347 | 0 | submodule = submodule_from_name(r, null_oid(), name->string); |
1348 | 0 | if (submodule) |
1349 | 0 | path = submodule->path; |
1350 | 0 | else |
1351 | 0 | path = default_name_or_path(name->string); |
1352 | |
|
1353 | 0 | if (!path) |
1354 | 0 | continue; |
1355 | | |
1356 | 0 | if (submodule_has_commits(r, path, null_oid(), &cs_data->new_commits)) { |
1357 | 0 | changed_submodule_data_clear(cs_data); |
1358 | 0 | *name->string = '\0'; |
1359 | 0 | } |
1360 | 0 | } |
1361 | |
|
1362 | 0 | string_list_remove_empty_items(changed_submodule_names, 1); |
1363 | |
|
1364 | 0 | strvec_clear(&argv); |
1365 | 0 | oid_array_clear(&ref_tips_before_fetch); |
1366 | 0 | oid_array_clear(&ref_tips_after_fetch); |
1367 | 0 | initialized_fetch_ref_tips = 0; |
1368 | 0 | } |
1369 | | |
1370 | | int submodule_touches_in_range(struct repository *r, |
1371 | | struct object_id *excl_oid, |
1372 | | struct object_id *incl_oid) |
1373 | 0 | { |
1374 | 0 | struct string_list subs = STRING_LIST_INIT_DUP; |
1375 | 0 | struct strvec args = STRVEC_INIT; |
1376 | 0 | int ret; |
1377 | | |
1378 | | /* No need to check if there are no submodules configured */ |
1379 | 0 | if (!submodule_from_path(r, NULL, NULL)) |
1380 | 0 | return 0; |
1381 | | |
1382 | 0 | strvec_push(&args, "--"); /* args[0] program name */ |
1383 | 0 | strvec_push(&args, oid_to_hex(incl_oid)); |
1384 | 0 | if (!is_null_oid(excl_oid)) { |
1385 | 0 | strvec_push(&args, "--not"); |
1386 | 0 | strvec_push(&args, oid_to_hex(excl_oid)); |
1387 | 0 | } |
1388 | |
|
1389 | 0 | collect_changed_submodules(r, &subs, &args); |
1390 | 0 | ret = subs.nr; |
1391 | |
|
1392 | 0 | strvec_clear(&args); |
1393 | |
|
1394 | 0 | free_submodules_data(&subs); |
1395 | 0 | return ret; |
1396 | 0 | } |
1397 | | |
1398 | | struct submodule_parallel_fetch { |
1399 | | /* |
1400 | | * The index of the last index entry processed by |
1401 | | * get_fetch_task_from_index(). |
1402 | | */ |
1403 | | int index_count; |
1404 | | /* |
1405 | | * The index of the last string_list entry processed by |
1406 | | * get_fetch_task_from_changed(). |
1407 | | */ |
1408 | | int changed_count; |
1409 | | struct strvec args; |
1410 | | struct repository *r; |
1411 | | const char *prefix; |
1412 | | int command_line_option; |
1413 | | int default_option; |
1414 | | int quiet; |
1415 | | int result; |
1416 | | |
1417 | | /* |
1418 | | * Names of submodules that have new commits. Generated by |
1419 | | * walking the newly fetched superproject commits. |
1420 | | */ |
1421 | | struct string_list changed_submodule_names; |
1422 | | /* |
1423 | | * Names of submodules that have already been processed. Lets us |
1424 | | * avoid fetching the same submodule more than once. |
1425 | | */ |
1426 | | struct string_list seen_submodule_names; |
1427 | | |
1428 | | /* Pending fetches by OIDs */ |
1429 | | struct fetch_task **oid_fetch_tasks; |
1430 | | int oid_fetch_tasks_nr, oid_fetch_tasks_alloc; |
1431 | | |
1432 | | struct strbuf submodules_with_errors; |
1433 | | }; |
1434 | 0 | #define SPF_INIT { \ |
1435 | 0 | .args = STRVEC_INIT, \ |
1436 | 0 | .changed_submodule_names = STRING_LIST_INIT_DUP, \ |
1437 | 0 | .seen_submodule_names = STRING_LIST_INIT_DUP, \ |
1438 | 0 | .submodules_with_errors = STRBUF_INIT, \ |
1439 | 0 | } |
1440 | | |
1441 | | static int get_fetch_recurse_config(const struct submodule *submodule, |
1442 | | struct submodule_parallel_fetch *spf) |
1443 | 0 | { |
1444 | 0 | if (spf->command_line_option != RECURSE_SUBMODULES_DEFAULT) |
1445 | 0 | return spf->command_line_option; |
1446 | | |
1447 | 0 | if (submodule) { |
1448 | 0 | char *key; |
1449 | 0 | const char *value; |
1450 | |
|
1451 | 0 | int fetch_recurse = submodule->fetch_recurse; |
1452 | 0 | key = xstrfmt("submodule.%s.fetchRecurseSubmodules", submodule->name); |
1453 | 0 | if (!repo_config_get_string_tmp(spf->r, key, &value)) { |
1454 | 0 | fetch_recurse = parse_fetch_recurse_submodules_arg(key, value); |
1455 | 0 | } |
1456 | 0 | free(key); |
1457 | |
|
1458 | 0 | if (fetch_recurse != RECURSE_SUBMODULES_NONE) |
1459 | | /* local config overrules everything except commandline */ |
1460 | 0 | return fetch_recurse; |
1461 | 0 | } |
1462 | | |
1463 | 0 | return spf->default_option; |
1464 | 0 | } |
1465 | | |
1466 | | /* |
1467 | | * Fetch in progress (if callback data) or |
1468 | | * pending (if in oid_fetch_tasks in struct submodule_parallel_fetch) |
1469 | | */ |
1470 | | struct fetch_task { |
1471 | | struct repository *repo; |
1472 | | const struct submodule *sub; |
1473 | | unsigned free_sub : 1; /* Do we need to free the submodule? */ |
1474 | | const char *default_argv; /* The default fetch mode. */ |
1475 | | struct strvec git_args; /* Args for the child git process. */ |
1476 | | |
1477 | | struct oid_array *commits; /* Ensure these commits are fetched */ |
1478 | | }; |
1479 | | |
1480 | | /** |
1481 | | * When a submodule is not defined in .gitmodules, we cannot access it |
1482 | | * via the regular submodule-config. Create a fake submodule, which we can |
1483 | | * work on. |
1484 | | */ |
1485 | | static const struct submodule *get_non_gitmodules_submodule(const char *path) |
1486 | 0 | { |
1487 | 0 | struct submodule *ret = NULL; |
1488 | 0 | const char *name = default_name_or_path(path); |
1489 | |
|
1490 | 0 | if (!name) |
1491 | 0 | return NULL; |
1492 | | |
1493 | 0 | ret = xmalloc(sizeof(*ret)); |
1494 | 0 | memset(ret, 0, sizeof(*ret)); |
1495 | 0 | ret->path = name; |
1496 | 0 | ret->name = name; |
1497 | |
|
1498 | 0 | return (const struct submodule *) ret; |
1499 | 0 | } |
1500 | | |
1501 | | static void fetch_task_free(struct fetch_task *p) |
1502 | 0 | { |
1503 | 0 | if (p->free_sub) |
1504 | 0 | free((void*)p->sub); |
1505 | 0 | p->free_sub = 0; |
1506 | 0 | p->sub = NULL; |
1507 | |
|
1508 | 0 | if (p->repo) |
1509 | 0 | repo_clear(p->repo); |
1510 | 0 | FREE_AND_NULL(p->repo); |
1511 | |
|
1512 | 0 | strvec_clear(&p->git_args); |
1513 | 0 | free(p); |
1514 | 0 | } |
1515 | | |
1516 | | static struct repository *get_submodule_repo_for(struct repository *r, |
1517 | | const char *path, |
1518 | | const struct object_id *treeish_name) |
1519 | 0 | { |
1520 | 0 | struct repository *ret = xmalloc(sizeof(*ret)); |
1521 | |
|
1522 | 0 | if (repo_submodule_init(ret, r, path, treeish_name)) { |
1523 | 0 | free(ret); |
1524 | 0 | return NULL; |
1525 | 0 | } |
1526 | | |
1527 | 0 | return ret; |
1528 | 0 | } |
1529 | | |
1530 | | static struct fetch_task *fetch_task_create(struct submodule_parallel_fetch *spf, |
1531 | | const char *path, |
1532 | | const struct object_id *treeish_name) |
1533 | 0 | { |
1534 | 0 | struct fetch_task *task = xmalloc(sizeof(*task)); |
1535 | 0 | memset(task, 0, sizeof(*task)); |
1536 | |
|
1537 | 0 | if (validate_submodule_path(path) < 0) |
1538 | 0 | exit(128); |
1539 | | |
1540 | 0 | task->sub = submodule_from_path(spf->r, treeish_name, path); |
1541 | |
|
1542 | 0 | if (!task->sub) { |
1543 | | /* |
1544 | | * No entry in .gitmodules? Technically not a submodule, |
1545 | | * but historically we supported repositories that happen to be |
1546 | | * in-place where a gitlink is. Keep supporting them. |
1547 | | */ |
1548 | 0 | task->sub = get_non_gitmodules_submodule(path); |
1549 | 0 | if (!task->sub) |
1550 | 0 | goto cleanup; |
1551 | | |
1552 | 0 | task->free_sub = 1; |
1553 | 0 | } |
1554 | | |
1555 | 0 | if (string_list_lookup(&spf->seen_submodule_names, task->sub->name)) |
1556 | 0 | goto cleanup; |
1557 | | |
1558 | 0 | switch (get_fetch_recurse_config(task->sub, spf)) |
1559 | 0 | { |
1560 | 0 | default: |
1561 | 0 | case RECURSE_SUBMODULES_DEFAULT: |
1562 | 0 | case RECURSE_SUBMODULES_ON_DEMAND: |
1563 | 0 | if (!task->sub || |
1564 | 0 | !string_list_lookup( |
1565 | 0 | &spf->changed_submodule_names, |
1566 | 0 | task->sub->name)) |
1567 | 0 | goto cleanup; |
1568 | 0 | task->default_argv = "on-demand"; |
1569 | 0 | break; |
1570 | 0 | case RECURSE_SUBMODULES_ON: |
1571 | 0 | task->default_argv = "yes"; |
1572 | 0 | break; |
1573 | 0 | case RECURSE_SUBMODULES_OFF: |
1574 | 0 | goto cleanup; |
1575 | 0 | } |
1576 | | |
1577 | 0 | task->repo = get_submodule_repo_for(spf->r, path, treeish_name); |
1578 | |
|
1579 | 0 | return task; |
1580 | | |
1581 | 0 | cleanup: |
1582 | 0 | fetch_task_free(task); |
1583 | 0 | return NULL; |
1584 | 0 | } |
1585 | | |
1586 | | static struct fetch_task * |
1587 | | get_fetch_task_from_index(struct submodule_parallel_fetch *spf, |
1588 | | struct strbuf *err) |
1589 | 0 | { |
1590 | 0 | for (; spf->index_count < spf->r->index->cache_nr; spf->index_count++) { |
1591 | 0 | const struct cache_entry *ce = |
1592 | 0 | spf->r->index->cache[spf->index_count]; |
1593 | 0 | struct fetch_task *task; |
1594 | |
|
1595 | 0 | if (!S_ISGITLINK(ce->ce_mode)) |
1596 | 0 | continue; |
1597 | | |
1598 | 0 | task = fetch_task_create(spf, ce->name, null_oid()); |
1599 | 0 | if (!task) |
1600 | 0 | continue; |
1601 | | |
1602 | 0 | if (task->repo) { |
1603 | 0 | if (!spf->quiet) |
1604 | 0 | strbuf_addf(err, _("Fetching submodule %s%s\n"), |
1605 | 0 | spf->prefix, ce->name); |
1606 | |
|
1607 | 0 | spf->index_count++; |
1608 | 0 | return task; |
1609 | 0 | } else { |
1610 | 0 | struct strbuf empty_submodule_path = STRBUF_INIT; |
1611 | |
|
1612 | 0 | fetch_task_free(task); |
1613 | | |
1614 | | /* |
1615 | | * An empty directory is normal, |
1616 | | * the submodule is not initialized |
1617 | | */ |
1618 | 0 | strbuf_addf(&empty_submodule_path, "%s/%s/", |
1619 | 0 | spf->r->worktree, |
1620 | 0 | ce->name); |
1621 | 0 | if (S_ISGITLINK(ce->ce_mode) && |
1622 | 0 | !is_empty_dir(empty_submodule_path.buf)) { |
1623 | 0 | spf->result = 1; |
1624 | 0 | strbuf_addf(err, |
1625 | 0 | _("Could not access submodule '%s'\n"), |
1626 | 0 | ce->name); |
1627 | 0 | } |
1628 | 0 | strbuf_release(&empty_submodule_path); |
1629 | 0 | } |
1630 | 0 | } |
1631 | 0 | return NULL; |
1632 | 0 | } |
1633 | | |
1634 | | static struct fetch_task * |
1635 | | get_fetch_task_from_changed(struct submodule_parallel_fetch *spf, |
1636 | | struct strbuf *err) |
1637 | 0 | { |
1638 | 0 | for (; spf->changed_count < spf->changed_submodule_names.nr; |
1639 | 0 | spf->changed_count++) { |
1640 | 0 | struct string_list_item item = |
1641 | 0 | spf->changed_submodule_names.items[spf->changed_count]; |
1642 | 0 | struct changed_submodule_data *cs_data = item.util; |
1643 | 0 | struct fetch_task *task; |
1644 | |
|
1645 | 0 | if (!is_tree_submodule_active(spf->r, cs_data->super_oid,cs_data->path)) |
1646 | 0 | continue; |
1647 | | |
1648 | 0 | task = fetch_task_create(spf, cs_data->path, |
1649 | 0 | cs_data->super_oid); |
1650 | 0 | if (!task) |
1651 | 0 | continue; |
1652 | | |
1653 | 0 | if (!task->repo) { |
1654 | 0 | strbuf_addf(err, _("Could not access submodule '%s' at commit %s\n"), |
1655 | 0 | cs_data->path, |
1656 | 0 | repo_find_unique_abbrev(the_repository, cs_data->super_oid, DEFAULT_ABBREV)); |
1657 | |
|
1658 | 0 | fetch_task_free(task); |
1659 | 0 | continue; |
1660 | 0 | } |
1661 | | |
1662 | 0 | if (!spf->quiet) |
1663 | 0 | strbuf_addf(err, |
1664 | 0 | _("Fetching submodule %s%s at commit %s\n"), |
1665 | 0 | spf->prefix, task->sub->path, |
1666 | 0 | repo_find_unique_abbrev(the_repository, cs_data->super_oid, |
1667 | 0 | DEFAULT_ABBREV)); |
1668 | |
|
1669 | 0 | spf->changed_count++; |
1670 | | /* |
1671 | | * NEEDSWORK: Submodules set/unset a value for |
1672 | | * core.worktree when they are populated/unpopulated by |
1673 | | * "git checkout" (and similar commands, see |
1674 | | * submodule_move_head() and |
1675 | | * connect_work_tree_and_git_dir()), but if the |
1676 | | * submodule is unpopulated in another way (e.g. "git |
1677 | | * rm", "rm -r"), core.worktree will still be set even |
1678 | | * though the directory doesn't exist, and the child |
1679 | | * process will crash while trying to chdir into the |
1680 | | * nonexistent directory. |
1681 | | * |
1682 | | * In this case, we know that the submodule has no |
1683 | | * working tree, so we can work around this by |
1684 | | * setting "--work-tree=." (--bare does not work because |
1685 | | * worktree settings take precedence over bare-ness). |
1686 | | * However, this is not necessarily true in other cases, |
1687 | | * so a generalized solution is still necessary. |
1688 | | * |
1689 | | * Possible solutions: |
1690 | | * - teach "git [add|rm]" to unset core.worktree and |
1691 | | * discourage users from removing submodules without |
1692 | | * using a Git command. |
1693 | | * - teach submodule child processes to ignore stale |
1694 | | * core.worktree values. |
1695 | | */ |
1696 | 0 | strvec_push(&task->git_args, "--work-tree=."); |
1697 | 0 | return task; |
1698 | 0 | } |
1699 | 0 | return NULL; |
1700 | 0 | } |
1701 | | |
1702 | | static int get_next_submodule(struct child_process *cp, struct strbuf *err, |
1703 | | void *data, void **task_cb) |
1704 | 0 | { |
1705 | 0 | struct submodule_parallel_fetch *spf = data; |
1706 | 0 | struct fetch_task *task = |
1707 | 0 | get_fetch_task_from_index(spf, err); |
1708 | 0 | if (!task) |
1709 | 0 | task = get_fetch_task_from_changed(spf, err); |
1710 | |
|
1711 | 0 | if (task) { |
1712 | 0 | child_process_init(cp); |
1713 | 0 | cp->dir = task->repo->gitdir; |
1714 | 0 | prepare_submodule_repo_env_in_gitdir(&cp->env); |
1715 | 0 | cp->git_cmd = 1; |
1716 | 0 | strvec_init(&cp->args); |
1717 | 0 | if (task->git_args.nr) |
1718 | 0 | strvec_pushv(&cp->args, task->git_args.v); |
1719 | 0 | strvec_pushv(&cp->args, spf->args.v); |
1720 | 0 | strvec_push(&cp->args, task->default_argv); |
1721 | 0 | strvec_pushf(&cp->args, "--submodule-prefix=%s%s/", |
1722 | 0 | spf->prefix, task->sub->path); |
1723 | |
|
1724 | 0 | *task_cb = task; |
1725 | |
|
1726 | 0 | string_list_insert(&spf->seen_submodule_names, task->sub->name); |
1727 | 0 | return 1; |
1728 | 0 | } |
1729 | | |
1730 | 0 | if (spf->oid_fetch_tasks_nr) { |
1731 | 0 | struct fetch_task *task = |
1732 | 0 | spf->oid_fetch_tasks[spf->oid_fetch_tasks_nr - 1]; |
1733 | 0 | spf->oid_fetch_tasks_nr--; |
1734 | |
|
1735 | 0 | child_process_init(cp); |
1736 | 0 | prepare_submodule_repo_env_in_gitdir(&cp->env); |
1737 | 0 | cp->git_cmd = 1; |
1738 | 0 | cp->dir = task->repo->gitdir; |
1739 | |
|
1740 | 0 | strvec_init(&cp->args); |
1741 | 0 | strvec_pushv(&cp->args, spf->args.v); |
1742 | 0 | strvec_push(&cp->args, "on-demand"); |
1743 | 0 | strvec_pushf(&cp->args, "--submodule-prefix=%s%s/", |
1744 | 0 | spf->prefix, task->sub->path); |
1745 | | |
1746 | | /* NEEDSWORK: have get_default_remote from submodule--helper */ |
1747 | 0 | strvec_push(&cp->args, "origin"); |
1748 | 0 | oid_array_for_each_unique(task->commits, |
1749 | 0 | append_oid_to_argv, &cp->args); |
1750 | |
|
1751 | 0 | *task_cb = task; |
1752 | 0 | return 1; |
1753 | 0 | } |
1754 | | |
1755 | 0 | return 0; |
1756 | 0 | } |
1757 | | |
1758 | | static int fetch_start_failure(struct strbuf *err UNUSED, |
1759 | | void *cb, void *task_cb) |
1760 | 0 | { |
1761 | 0 | struct submodule_parallel_fetch *spf = cb; |
1762 | 0 | struct fetch_task *task = task_cb; |
1763 | |
|
1764 | 0 | spf->result = 1; |
1765 | |
|
1766 | 0 | fetch_task_free(task); |
1767 | 0 | return 0; |
1768 | 0 | } |
1769 | | |
1770 | | static int commit_missing_in_sub(const struct object_id *oid, void *data) |
1771 | 0 | { |
1772 | 0 | struct repository *subrepo = data; |
1773 | |
|
1774 | 0 | enum object_type type = oid_object_info(subrepo, oid, NULL); |
1775 | |
|
1776 | 0 | return type != OBJ_COMMIT; |
1777 | 0 | } |
1778 | | |
1779 | | static int fetch_finish(int retvalue, struct strbuf *err UNUSED, |
1780 | | void *cb, void *task_cb) |
1781 | 0 | { |
1782 | 0 | struct submodule_parallel_fetch *spf = cb; |
1783 | 0 | struct fetch_task *task = task_cb; |
1784 | |
|
1785 | 0 | struct string_list_item *it; |
1786 | 0 | struct changed_submodule_data *cs_data; |
1787 | |
|
1788 | 0 | if (!task || !task->sub) |
1789 | 0 | BUG("callback cookie bogus"); |
1790 | | |
1791 | 0 | if (retvalue) { |
1792 | | /* |
1793 | | * NEEDSWORK: This indicates that the overall fetch |
1794 | | * failed, even though there may be a subsequent fetch |
1795 | | * by commit hash that might work. It may be a good |
1796 | | * idea to not indicate failure in this case, and only |
1797 | | * indicate failure if the subsequent fetch fails. |
1798 | | */ |
1799 | 0 | spf->result = 1; |
1800 | |
|
1801 | 0 | strbuf_addf(&spf->submodules_with_errors, "\t%s\n", |
1802 | 0 | task->sub->name); |
1803 | 0 | } |
1804 | | |
1805 | | /* Is this the second time we process this submodule? */ |
1806 | 0 | if (task->commits) |
1807 | 0 | goto out; |
1808 | | |
1809 | 0 | it = string_list_lookup(&spf->changed_submodule_names, task->sub->name); |
1810 | 0 | if (!it) |
1811 | | /* Could be an unchanged submodule, not contained in the list */ |
1812 | 0 | goto out; |
1813 | | |
1814 | 0 | cs_data = it->util; |
1815 | 0 | oid_array_filter(&cs_data->new_commits, |
1816 | 0 | commit_missing_in_sub, |
1817 | 0 | task->repo); |
1818 | | |
1819 | | /* Are there commits we want, but do not exist? */ |
1820 | 0 | if (cs_data->new_commits.nr) { |
1821 | 0 | task->commits = &cs_data->new_commits; |
1822 | 0 | ALLOC_GROW(spf->oid_fetch_tasks, |
1823 | 0 | spf->oid_fetch_tasks_nr + 1, |
1824 | 0 | spf->oid_fetch_tasks_alloc); |
1825 | 0 | spf->oid_fetch_tasks[spf->oid_fetch_tasks_nr] = task; |
1826 | 0 | spf->oid_fetch_tasks_nr++; |
1827 | 0 | return 0; |
1828 | 0 | } |
1829 | | |
1830 | 0 | out: |
1831 | 0 | fetch_task_free(task); |
1832 | 0 | return 0; |
1833 | 0 | } |
1834 | | |
1835 | | int fetch_submodules(struct repository *r, |
1836 | | const struct strvec *options, |
1837 | | const char *prefix, int command_line_option, |
1838 | | int default_option, |
1839 | | int quiet, int max_parallel_jobs) |
1840 | 0 | { |
1841 | 0 | int i; |
1842 | 0 | struct submodule_parallel_fetch spf = SPF_INIT; |
1843 | 0 | const struct run_process_parallel_opts opts = { |
1844 | 0 | .tr2_category = "submodule", |
1845 | 0 | .tr2_label = "parallel/fetch", |
1846 | |
|
1847 | 0 | .processes = max_parallel_jobs, |
1848 | |
|
1849 | 0 | .get_next_task = get_next_submodule, |
1850 | 0 | .start_failure = fetch_start_failure, |
1851 | 0 | .task_finished = fetch_finish, |
1852 | 0 | .data = &spf, |
1853 | 0 | }; |
1854 | |
|
1855 | 0 | spf.r = r; |
1856 | 0 | spf.command_line_option = command_line_option; |
1857 | 0 | spf.default_option = default_option; |
1858 | 0 | spf.quiet = quiet; |
1859 | 0 | spf.prefix = prefix; |
1860 | |
|
1861 | 0 | if (!r->worktree) |
1862 | 0 | goto out; |
1863 | | |
1864 | 0 | if (repo_read_index(r) < 0) |
1865 | 0 | die(_("index file corrupt")); |
1866 | | |
1867 | 0 | strvec_push(&spf.args, "fetch"); |
1868 | 0 | for (i = 0; i < options->nr; i++) |
1869 | 0 | strvec_push(&spf.args, options->v[i]); |
1870 | 0 | strvec_push(&spf.args, "--recurse-submodules-default"); |
1871 | | /* default value, "--submodule-prefix" and its value are added later */ |
1872 | |
|
1873 | 0 | calculate_changed_submodule_paths(r, &spf.changed_submodule_names); |
1874 | 0 | string_list_sort(&spf.changed_submodule_names); |
1875 | 0 | run_processes_parallel(&opts); |
1876 | |
|
1877 | 0 | if (spf.submodules_with_errors.len > 0) |
1878 | 0 | fprintf(stderr, _("Errors during submodule fetch:\n%s"), |
1879 | 0 | spf.submodules_with_errors.buf); |
1880 | | |
1881 | |
|
1882 | 0 | strvec_clear(&spf.args); |
1883 | 0 | out: |
1884 | 0 | free_submodules_data(&spf.changed_submodule_names); |
1885 | 0 | string_list_clear(&spf.seen_submodule_names, 0); |
1886 | 0 | return spf.result; |
1887 | 0 | } |
1888 | | |
1889 | | unsigned is_submodule_modified(const char *path, int ignore_untracked) |
1890 | 0 | { |
1891 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
1892 | 0 | struct strbuf buf = STRBUF_INIT; |
1893 | 0 | FILE *fp; |
1894 | 0 | unsigned dirty_submodule = 0; |
1895 | 0 | const char *git_dir; |
1896 | 0 | int ignore_cp_exit_code = 0; |
1897 | |
|
1898 | 0 | if (validate_submodule_path(path) < 0) |
1899 | 0 | exit(128); |
1900 | | |
1901 | 0 | strbuf_addf(&buf, "%s/.git", path); |
1902 | 0 | git_dir = read_gitfile(buf.buf); |
1903 | 0 | if (!git_dir) |
1904 | 0 | git_dir = buf.buf; |
1905 | 0 | if (!is_git_directory(git_dir)) { |
1906 | 0 | if (is_directory(git_dir)) |
1907 | 0 | die(_("'%s' not recognized as a git repository"), git_dir); |
1908 | 0 | strbuf_release(&buf); |
1909 | | /* The submodule is not checked out, so it is not modified */ |
1910 | 0 | return 0; |
1911 | 0 | } |
1912 | 0 | strbuf_reset(&buf); |
1913 | |
|
1914 | 0 | strvec_pushl(&cp.args, "status", "--porcelain=2", NULL); |
1915 | 0 | if (ignore_untracked) |
1916 | 0 | strvec_push(&cp.args, "-uno"); |
1917 | |
|
1918 | 0 | prepare_submodule_repo_env(&cp.env); |
1919 | 0 | cp.git_cmd = 1; |
1920 | 0 | cp.no_stdin = 1; |
1921 | 0 | cp.out = -1; |
1922 | 0 | cp.dir = path; |
1923 | 0 | if (start_command(&cp)) |
1924 | 0 | die(_("Could not run 'git status --porcelain=2' in submodule %s"), path); |
1925 | | |
1926 | 0 | fp = xfdopen(cp.out, "r"); |
1927 | 0 | while (strbuf_getwholeline(&buf, fp, '\n') != EOF) { |
1928 | | /* regular untracked files */ |
1929 | 0 | if (buf.buf[0] == '?') |
1930 | 0 | dirty_submodule |= DIRTY_SUBMODULE_UNTRACKED; |
1931 | |
|
1932 | 0 | if (buf.buf[0] == 'u' || |
1933 | 0 | buf.buf[0] == '1' || |
1934 | 0 | buf.buf[0] == '2') { |
1935 | | /* T = line type, XY = status, SSSS = submodule state */ |
1936 | 0 | if (buf.len < strlen("T XY SSSS")) |
1937 | 0 | BUG("invalid status --porcelain=2 line %s", |
1938 | 0 | buf.buf); |
1939 | | |
1940 | 0 | if (buf.buf[5] == 'S' && buf.buf[8] == 'U') |
1941 | | /* nested untracked file */ |
1942 | 0 | dirty_submodule |= DIRTY_SUBMODULE_UNTRACKED; |
1943 | |
|
1944 | 0 | if (buf.buf[0] == 'u' || |
1945 | 0 | buf.buf[0] == '2' || |
1946 | 0 | memcmp(buf.buf + 5, "S..U", 4)) |
1947 | | /* other change */ |
1948 | 0 | dirty_submodule |= DIRTY_SUBMODULE_MODIFIED; |
1949 | 0 | } |
1950 | | |
1951 | 0 | if ((dirty_submodule & DIRTY_SUBMODULE_MODIFIED) && |
1952 | 0 | ((dirty_submodule & DIRTY_SUBMODULE_UNTRACKED) || |
1953 | 0 | ignore_untracked)) { |
1954 | | /* |
1955 | | * We're not interested in any further information from |
1956 | | * the child any more, neither output nor its exit code. |
1957 | | */ |
1958 | 0 | ignore_cp_exit_code = 1; |
1959 | 0 | break; |
1960 | 0 | } |
1961 | 0 | } |
1962 | 0 | fclose(fp); |
1963 | |
|
1964 | 0 | if (finish_command(&cp) && !ignore_cp_exit_code) |
1965 | 0 | die(_("'git status --porcelain=2' failed in submodule %s"), path); |
1966 | | |
1967 | 0 | strbuf_release(&buf); |
1968 | 0 | return dirty_submodule; |
1969 | 0 | } |
1970 | | |
1971 | | int submodule_uses_gitfile(const char *path) |
1972 | 0 | { |
1973 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
1974 | 0 | struct strbuf buf = STRBUF_INIT; |
1975 | 0 | const char *git_dir; |
1976 | |
|
1977 | 0 | if (validate_submodule_path(path) < 0) |
1978 | 0 | exit(128); |
1979 | | |
1980 | 0 | strbuf_addf(&buf, "%s/.git", path); |
1981 | 0 | git_dir = read_gitfile(buf.buf); |
1982 | 0 | if (!git_dir) { |
1983 | 0 | strbuf_release(&buf); |
1984 | 0 | return 0; |
1985 | 0 | } |
1986 | 0 | strbuf_release(&buf); |
1987 | | |
1988 | | /* Now test that all nested submodules use a gitfile too */ |
1989 | 0 | strvec_pushl(&cp.args, |
1990 | 0 | "submodule", "foreach", "--quiet", "--recursive", |
1991 | 0 | "test -f .git", NULL); |
1992 | |
|
1993 | 0 | prepare_submodule_repo_env(&cp.env); |
1994 | 0 | cp.git_cmd = 1; |
1995 | 0 | cp.no_stdin = 1; |
1996 | 0 | cp.no_stderr = 1; |
1997 | 0 | cp.no_stdout = 1; |
1998 | 0 | cp.dir = path; |
1999 | 0 | if (run_command(&cp)) |
2000 | 0 | return 0; |
2001 | | |
2002 | 0 | return 1; |
2003 | 0 | } |
2004 | | |
2005 | | /* |
2006 | | * Check if it is a bad idea to remove a submodule, i.e. if we'd lose data |
2007 | | * when doing so. |
2008 | | * |
2009 | | * Return 1 if we'd lose data, return 0 if the removal is fine, |
2010 | | * and negative values for errors. |
2011 | | */ |
2012 | | int bad_to_remove_submodule(const char *path, unsigned flags) |
2013 | 0 | { |
2014 | 0 | ssize_t len; |
2015 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
2016 | 0 | struct strbuf buf = STRBUF_INIT; |
2017 | 0 | int ret = 0; |
2018 | |
|
2019 | 0 | if (validate_submodule_path(path) < 0) |
2020 | 0 | exit(128); |
2021 | | |
2022 | 0 | if (!file_exists(path) || is_empty_dir(path)) |
2023 | 0 | return 0; |
2024 | | |
2025 | 0 | if (!submodule_uses_gitfile(path)) |
2026 | 0 | return 1; |
2027 | | |
2028 | 0 | strvec_pushl(&cp.args, "status", "--porcelain", |
2029 | 0 | "--ignore-submodules=none", NULL); |
2030 | |
|
2031 | 0 | if (flags & SUBMODULE_REMOVAL_IGNORE_UNTRACKED) |
2032 | 0 | strvec_push(&cp.args, "-uno"); |
2033 | 0 | else |
2034 | 0 | strvec_push(&cp.args, "-uall"); |
2035 | |
|
2036 | 0 | if (!(flags & SUBMODULE_REMOVAL_IGNORE_IGNORED_UNTRACKED)) |
2037 | 0 | strvec_push(&cp.args, "--ignored"); |
2038 | |
|
2039 | 0 | prepare_submodule_repo_env(&cp.env); |
2040 | 0 | cp.git_cmd = 1; |
2041 | 0 | cp.no_stdin = 1; |
2042 | 0 | cp.out = -1; |
2043 | 0 | cp.dir = path; |
2044 | 0 | if (start_command(&cp)) { |
2045 | 0 | if (flags & SUBMODULE_REMOVAL_DIE_ON_ERROR) |
2046 | 0 | die(_("could not start 'git status' in submodule '%s'"), |
2047 | 0 | path); |
2048 | 0 | ret = -1; |
2049 | 0 | goto out; |
2050 | 0 | } |
2051 | | |
2052 | 0 | len = strbuf_read(&buf, cp.out, 1024); |
2053 | 0 | if (len > 2) |
2054 | 0 | ret = 1; |
2055 | 0 | close(cp.out); |
2056 | |
|
2057 | 0 | if (finish_command(&cp)) { |
2058 | 0 | if (flags & SUBMODULE_REMOVAL_DIE_ON_ERROR) |
2059 | 0 | die(_("could not run 'git status' in submodule '%s'"), |
2060 | 0 | path); |
2061 | 0 | ret = -1; |
2062 | 0 | } |
2063 | 0 | out: |
2064 | 0 | strbuf_release(&buf); |
2065 | 0 | return ret; |
2066 | 0 | } |
2067 | | |
2068 | | void submodule_unset_core_worktree(const struct submodule *sub) |
2069 | 0 | { |
2070 | 0 | struct strbuf config_path = STRBUF_INIT; |
2071 | |
|
2072 | 0 | if (validate_submodule_path(sub->path) < 0) |
2073 | 0 | exit(128); |
2074 | | |
2075 | 0 | submodule_name_to_gitdir(&config_path, the_repository, sub->name); |
2076 | 0 | strbuf_addstr(&config_path, "/config"); |
2077 | |
|
2078 | 0 | if (git_config_set_in_file_gently(config_path.buf, "core.worktree", NULL, NULL)) |
2079 | 0 | warning(_("Could not unset core.worktree setting in submodule '%s'"), |
2080 | 0 | sub->path); |
2081 | |
|
2082 | 0 | strbuf_release(&config_path); |
2083 | 0 | } |
2084 | | |
2085 | | static int submodule_has_dirty_index(const struct submodule *sub) |
2086 | 0 | { |
2087 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
2088 | |
|
2089 | 0 | if (validate_submodule_path(sub->path) < 0) |
2090 | 0 | exit(128); |
2091 | | |
2092 | 0 | prepare_submodule_repo_env(&cp.env); |
2093 | |
|
2094 | 0 | cp.git_cmd = 1; |
2095 | 0 | strvec_pushl(&cp.args, "diff-index", "--quiet", |
2096 | 0 | "--cached", "HEAD", NULL); |
2097 | 0 | cp.no_stdin = 1; |
2098 | 0 | cp.no_stdout = 1; |
2099 | 0 | cp.dir = sub->path; |
2100 | 0 | if (start_command(&cp)) |
2101 | 0 | die(_("could not recurse into submodule '%s'"), sub->path); |
2102 | | |
2103 | 0 | return finish_command(&cp); |
2104 | 0 | } |
2105 | | |
2106 | | static void submodule_reset_index(const char *path, const char *super_prefix) |
2107 | 0 | { |
2108 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
2109 | |
|
2110 | 0 | if (validate_submodule_path(path) < 0) |
2111 | 0 | exit(128); |
2112 | | |
2113 | 0 | prepare_submodule_repo_env(&cp.env); |
2114 | |
|
2115 | 0 | cp.git_cmd = 1; |
2116 | 0 | cp.no_stdin = 1; |
2117 | 0 | cp.dir = path; |
2118 | | |
2119 | | /* TODO: determine if this might overwright untracked files */ |
2120 | 0 | strvec_pushl(&cp.args, "read-tree", "-u", "--reset", NULL); |
2121 | 0 | strvec_pushf(&cp.args, "--super-prefix=%s%s/", |
2122 | 0 | (super_prefix ? super_prefix : ""), path); |
2123 | |
|
2124 | 0 | strvec_push(&cp.args, empty_tree_oid_hex(the_repository->hash_algo)); |
2125 | |
|
2126 | 0 | if (run_command(&cp)) |
2127 | 0 | die(_("could not reset submodule index")); |
2128 | 0 | } |
2129 | | |
2130 | | /** |
2131 | | * Moves a submodule at a given path from a given head to another new head. |
2132 | | * For edge cases (a submodule coming into existence or removing a submodule) |
2133 | | * pass NULL for old or new respectively. |
2134 | | */ |
2135 | | int submodule_move_head(const char *path, const char *super_prefix, |
2136 | | const char *old_head, const char *new_head, |
2137 | | unsigned flags) |
2138 | 0 | { |
2139 | 0 | int ret = 0; |
2140 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
2141 | 0 | const struct submodule *sub; |
2142 | 0 | int *error_code_ptr, error_code; |
2143 | |
|
2144 | 0 | if (!is_submodule_active(the_repository, path)) |
2145 | 0 | return 0; |
2146 | | |
2147 | 0 | if (flags & SUBMODULE_MOVE_HEAD_FORCE) |
2148 | | /* |
2149 | | * Pass non NULL pointer to is_submodule_populated_gently |
2150 | | * to prevent die()-ing. We'll use connect_work_tree_and_git_dir |
2151 | | * to fixup the submodule in the force case later. |
2152 | | */ |
2153 | 0 | error_code_ptr = &error_code; |
2154 | 0 | else |
2155 | 0 | error_code_ptr = NULL; |
2156 | |
|
2157 | 0 | if (old_head && !is_submodule_populated_gently(path, error_code_ptr)) |
2158 | 0 | return 0; |
2159 | | |
2160 | 0 | sub = submodule_from_path(the_repository, null_oid(), path); |
2161 | |
|
2162 | 0 | if (!sub) |
2163 | 0 | BUG("could not get submodule information for '%s'", path); |
2164 | | |
2165 | 0 | if (old_head && !(flags & SUBMODULE_MOVE_HEAD_FORCE)) { |
2166 | | /* Check if the submodule has a dirty index. */ |
2167 | 0 | if (submodule_has_dirty_index(sub)) |
2168 | 0 | return error(_("submodule '%s' has dirty index"), path); |
2169 | 0 | } |
2170 | | |
2171 | 0 | if (!(flags & SUBMODULE_MOVE_HEAD_DRY_RUN)) { |
2172 | 0 | if (old_head) { |
2173 | 0 | if (!submodule_uses_gitfile(path)) |
2174 | 0 | absorb_git_dir_into_superproject(path, |
2175 | 0 | super_prefix); |
2176 | 0 | else { |
2177 | 0 | char *dotgit = xstrfmt("%s/.git", path); |
2178 | 0 | char *git_dir = xstrdup(read_gitfile(dotgit)); |
2179 | |
|
2180 | 0 | free(dotgit); |
2181 | 0 | if (validate_submodule_git_dir(git_dir, |
2182 | 0 | sub->name) < 0) |
2183 | 0 | die(_("refusing to create/use '%s' in " |
2184 | 0 | "another submodule's git dir"), |
2185 | 0 | git_dir); |
2186 | 0 | free(git_dir); |
2187 | 0 | } |
2188 | 0 | } else { |
2189 | 0 | struct strbuf gitdir = STRBUF_INIT; |
2190 | 0 | submodule_name_to_gitdir(&gitdir, the_repository, |
2191 | 0 | sub->name); |
2192 | 0 | if (validate_submodule_git_dir(gitdir.buf, |
2193 | 0 | sub->name) < 0) |
2194 | 0 | die(_("refusing to create/use '%s' in another " |
2195 | 0 | "submodule's git dir"), |
2196 | 0 | gitdir.buf); |
2197 | 0 | connect_work_tree_and_git_dir(path, gitdir.buf, 0); |
2198 | 0 | strbuf_release(&gitdir); |
2199 | | |
2200 | | /* make sure the index is clean as well */ |
2201 | 0 | submodule_reset_index(path, super_prefix); |
2202 | 0 | } |
2203 | | |
2204 | 0 | if (old_head && (flags & SUBMODULE_MOVE_HEAD_FORCE)) { |
2205 | 0 | struct strbuf gitdir = STRBUF_INIT; |
2206 | 0 | submodule_name_to_gitdir(&gitdir, the_repository, |
2207 | 0 | sub->name); |
2208 | 0 | connect_work_tree_and_git_dir(path, gitdir.buf, 1); |
2209 | 0 | strbuf_release(&gitdir); |
2210 | 0 | } |
2211 | 0 | } |
2212 | | |
2213 | 0 | prepare_submodule_repo_env(&cp.env); |
2214 | |
|
2215 | 0 | cp.git_cmd = 1; |
2216 | 0 | cp.no_stdin = 1; |
2217 | 0 | cp.dir = path; |
2218 | |
|
2219 | 0 | strvec_pushl(&cp.args, "read-tree", "--recurse-submodules", NULL); |
2220 | 0 | strvec_pushf(&cp.args, "--super-prefix=%s%s/", |
2221 | 0 | (super_prefix ? super_prefix : ""), path); |
2222 | |
|
2223 | 0 | if (flags & SUBMODULE_MOVE_HEAD_DRY_RUN) |
2224 | 0 | strvec_push(&cp.args, "-n"); |
2225 | 0 | else |
2226 | 0 | strvec_push(&cp.args, "-u"); |
2227 | |
|
2228 | 0 | if (flags & SUBMODULE_MOVE_HEAD_FORCE) |
2229 | 0 | strvec_push(&cp.args, "--reset"); |
2230 | 0 | else |
2231 | 0 | strvec_push(&cp.args, "-m"); |
2232 | |
|
2233 | 0 | if (!(flags & SUBMODULE_MOVE_HEAD_FORCE)) |
2234 | 0 | strvec_push(&cp.args, old_head ? old_head : empty_tree_oid_hex(the_repository->hash_algo)); |
2235 | |
|
2236 | 0 | strvec_push(&cp.args, new_head ? new_head : empty_tree_oid_hex(the_repository->hash_algo)); |
2237 | |
|
2238 | 0 | if (run_command(&cp)) { |
2239 | 0 | ret = error(_("Submodule '%s' could not be updated."), path); |
2240 | 0 | goto out; |
2241 | 0 | } |
2242 | | |
2243 | 0 | if (!(flags & SUBMODULE_MOVE_HEAD_DRY_RUN)) { |
2244 | 0 | if (new_head) { |
2245 | 0 | child_process_init(&cp); |
2246 | | /* also set the HEAD accordingly */ |
2247 | 0 | cp.git_cmd = 1; |
2248 | 0 | cp.no_stdin = 1; |
2249 | 0 | cp.dir = path; |
2250 | |
|
2251 | 0 | prepare_submodule_repo_env(&cp.env); |
2252 | 0 | strvec_pushl(&cp.args, "update-ref", "HEAD", |
2253 | 0 | "--no-deref", new_head, NULL); |
2254 | |
|
2255 | 0 | if (run_command(&cp)) { |
2256 | 0 | ret = -1; |
2257 | 0 | goto out; |
2258 | 0 | } |
2259 | 0 | } else { |
2260 | 0 | struct strbuf sb = STRBUF_INIT; |
2261 | |
|
2262 | 0 | strbuf_addf(&sb, "%s/.git", path); |
2263 | 0 | unlink_or_warn(sb.buf); |
2264 | 0 | strbuf_release(&sb); |
2265 | |
|
2266 | 0 | if (is_empty_dir(path)) |
2267 | 0 | rmdir_or_warn(path); |
2268 | |
|
2269 | 0 | submodule_unset_core_worktree(sub); |
2270 | 0 | } |
2271 | 0 | } |
2272 | 0 | out: |
2273 | 0 | return ret; |
2274 | 0 | } |
2275 | | |
2276 | | int validate_submodule_git_dir(char *git_dir, const char *submodule_name) |
2277 | 0 | { |
2278 | 0 | size_t len = strlen(git_dir), suffix_len = strlen(submodule_name); |
2279 | 0 | char *p; |
2280 | 0 | int ret = 0; |
2281 | |
|
2282 | 0 | if (len <= suffix_len || (p = git_dir + len - suffix_len)[-1] != '/' || |
2283 | 0 | strcmp(p, submodule_name)) |
2284 | 0 | BUG("submodule name '%s' not a suffix of git dir '%s'", |
2285 | 0 | submodule_name, git_dir); |
2286 | | |
2287 | | /* |
2288 | | * We prevent the contents of sibling submodules' git directories to |
2289 | | * clash. |
2290 | | * |
2291 | | * Example: having a submodule named `hippo` and another one named |
2292 | | * `hippo/hooks` would result in the git directories |
2293 | | * `.git/modules/hippo/` and `.git/modules/hippo/hooks/`, respectively, |
2294 | | * but the latter directory is already designated to contain the hooks |
2295 | | * of the former. |
2296 | | */ |
2297 | 0 | for (; *p; p++) { |
2298 | 0 | if (is_dir_sep(*p)) { |
2299 | 0 | char c = *p; |
2300 | |
|
2301 | 0 | *p = '\0'; |
2302 | 0 | if (is_git_directory(git_dir)) |
2303 | 0 | ret = -1; |
2304 | 0 | *p = c; |
2305 | |
|
2306 | 0 | if (ret < 0) |
2307 | 0 | return error(_("submodule git dir '%s' is " |
2308 | 0 | "inside git dir '%.*s'"), |
2309 | 0 | git_dir, |
2310 | 0 | (int)(p - git_dir), git_dir); |
2311 | 0 | } |
2312 | 0 | } |
2313 | | |
2314 | 0 | return 0; |
2315 | 0 | } |
2316 | | |
2317 | | int validate_submodule_path(const char *path) |
2318 | 0 | { |
2319 | 0 | char *p = xstrdup(path); |
2320 | 0 | struct stat st; |
2321 | 0 | int i, ret = 0; |
2322 | 0 | char sep; |
2323 | |
|
2324 | 0 | for (i = 0; !ret && p[i]; i++) { |
2325 | 0 | if (!is_dir_sep(p[i])) |
2326 | 0 | continue; |
2327 | | |
2328 | 0 | sep = p[i]; |
2329 | 0 | p[i] = '\0'; |
2330 | | /* allow missing components, but no symlinks */ |
2331 | 0 | ret = lstat(p, &st) || !S_ISLNK(st.st_mode) ? 0 : -1; |
2332 | 0 | p[i] = sep; |
2333 | 0 | if (ret) |
2334 | 0 | error(_("expected '%.*s' in submodule path '%s' not to " |
2335 | 0 | "be a symbolic link"), i, p, p); |
2336 | 0 | } |
2337 | 0 | if (!lstat(p, &st) && S_ISLNK(st.st_mode)) |
2338 | 0 | ret = error(_("expected submodule path '%s' not to be a " |
2339 | 0 | "symbolic link"), p); |
2340 | 0 | free(p); |
2341 | 0 | return ret; |
2342 | 0 | } |
2343 | | |
2344 | | |
2345 | | /* |
2346 | | * Embeds a single submodules git directory into the superprojects git dir, |
2347 | | * non recursively. |
2348 | | */ |
2349 | | static void relocate_single_git_dir_into_superproject(const char *path, |
2350 | | const char *super_prefix) |
2351 | 0 | { |
2352 | 0 | char *old_git_dir = NULL, *real_old_git_dir = NULL, *real_new_git_dir = NULL; |
2353 | 0 | struct strbuf new_gitdir = STRBUF_INIT; |
2354 | 0 | const struct submodule *sub; |
2355 | |
|
2356 | 0 | if (validate_submodule_path(path) < 0) |
2357 | 0 | exit(128); |
2358 | | |
2359 | 0 | if (submodule_uses_worktrees(path)) |
2360 | 0 | die(_("relocate_gitdir for submodule '%s' with " |
2361 | 0 | "more than one worktree not supported"), path); |
2362 | | |
2363 | 0 | old_git_dir = xstrfmt("%s/.git", path); |
2364 | 0 | if (read_gitfile(old_git_dir)) |
2365 | | /* If it is an actual gitfile, it doesn't need migration. */ |
2366 | 0 | return; |
2367 | | |
2368 | 0 | real_old_git_dir = real_pathdup(old_git_dir, 1); |
2369 | |
|
2370 | 0 | sub = submodule_from_path(the_repository, null_oid(), path); |
2371 | 0 | if (!sub) |
2372 | 0 | die(_("could not lookup name for submodule '%s'"), path); |
2373 | | |
2374 | 0 | submodule_name_to_gitdir(&new_gitdir, the_repository, sub->name); |
2375 | 0 | if (validate_submodule_git_dir(new_gitdir.buf, sub->name) < 0) |
2376 | 0 | die(_("refusing to move '%s' into an existing git dir"), |
2377 | 0 | real_old_git_dir); |
2378 | 0 | if (safe_create_leading_directories_const(new_gitdir.buf) < 0) |
2379 | 0 | die(_("could not create directory '%s'"), new_gitdir.buf); |
2380 | 0 | real_new_git_dir = real_pathdup(new_gitdir.buf, 1); |
2381 | |
|
2382 | 0 | fprintf(stderr, _("Migrating git directory of '%s%s' from\n'%s' to\n'%s'\n"), |
2383 | 0 | super_prefix ? super_prefix : "", path, |
2384 | 0 | real_old_git_dir, real_new_git_dir); |
2385 | |
|
2386 | 0 | relocate_gitdir(path, real_old_git_dir, real_new_git_dir); |
2387 | |
|
2388 | 0 | free(old_git_dir); |
2389 | 0 | free(real_old_git_dir); |
2390 | 0 | free(real_new_git_dir); |
2391 | 0 | strbuf_release(&new_gitdir); |
2392 | 0 | } |
2393 | | |
2394 | | static void absorb_git_dir_into_superproject_recurse(const char *path, |
2395 | | const char *super_prefix) |
2396 | 0 | { |
2397 | |
|
2398 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
2399 | |
|
2400 | 0 | if (validate_submodule_path(path) < 0) |
2401 | 0 | exit(128); |
2402 | | |
2403 | 0 | cp.dir = path; |
2404 | 0 | cp.git_cmd = 1; |
2405 | 0 | cp.no_stdin = 1; |
2406 | 0 | strvec_pushl(&cp.args, "submodule--helper", |
2407 | 0 | "absorbgitdirs", NULL); |
2408 | 0 | strvec_pushf(&cp.args, "--super-prefix=%s%s/", super_prefix ? |
2409 | 0 | super_prefix : "", path); |
2410 | |
|
2411 | 0 | prepare_submodule_repo_env(&cp.env); |
2412 | 0 | if (run_command(&cp)) |
2413 | 0 | die(_("could not recurse into submodule '%s'"), path); |
2414 | 0 | } |
2415 | | |
2416 | | /* |
2417 | | * Migrate the git directory of the submodule given by path from |
2418 | | * having its git directory within the working tree to the git dir nested |
2419 | | * in its superprojects git dir under modules/. |
2420 | | */ |
2421 | | void absorb_git_dir_into_superproject(const char *path, |
2422 | | const char *super_prefix) |
2423 | 0 | { |
2424 | 0 | int err_code; |
2425 | 0 | const char *sub_git_dir; |
2426 | 0 | struct strbuf gitdir = STRBUF_INIT; |
2427 | |
|
2428 | 0 | if (validate_submodule_path(path) < 0) |
2429 | 0 | exit(128); |
2430 | | |
2431 | 0 | strbuf_addf(&gitdir, "%s/.git", path); |
2432 | 0 | sub_git_dir = resolve_gitdir_gently(gitdir.buf, &err_code); |
2433 | | |
2434 | | /* Not populated? */ |
2435 | 0 | if (!sub_git_dir) { |
2436 | 0 | const struct submodule *sub; |
2437 | 0 | struct strbuf sub_gitdir = STRBUF_INIT; |
2438 | |
|
2439 | 0 | if (err_code == READ_GITFILE_ERR_STAT_FAILED) { |
2440 | | /* unpopulated as expected */ |
2441 | 0 | strbuf_release(&gitdir); |
2442 | 0 | return; |
2443 | 0 | } |
2444 | | |
2445 | 0 | if (err_code != READ_GITFILE_ERR_NOT_A_REPO) |
2446 | | /* We don't know what broke here. */ |
2447 | 0 | read_gitfile_error_die(err_code, path, NULL); |
2448 | | |
2449 | | /* |
2450 | | * Maybe populated, but no git directory was found? |
2451 | | * This can happen if the superproject is a submodule |
2452 | | * itself and was just absorbed. The absorption of the |
2453 | | * superproject did not rewrite the git file links yet, |
2454 | | * fix it now. |
2455 | | */ |
2456 | 0 | sub = submodule_from_path(the_repository, null_oid(), path); |
2457 | 0 | if (!sub) |
2458 | 0 | die(_("could not lookup name for submodule '%s'"), path); |
2459 | 0 | submodule_name_to_gitdir(&sub_gitdir, the_repository, sub->name); |
2460 | 0 | connect_work_tree_and_git_dir(path, sub_gitdir.buf, 0); |
2461 | 0 | strbuf_release(&sub_gitdir); |
2462 | 0 | } else { |
2463 | | /* Is it already absorbed into the superprojects git dir? */ |
2464 | 0 | char *real_sub_git_dir = real_pathdup(sub_git_dir, 1); |
2465 | 0 | char *real_common_git_dir = real_pathdup(get_git_common_dir(), 1); |
2466 | |
|
2467 | 0 | if (!starts_with(real_sub_git_dir, real_common_git_dir)) |
2468 | 0 | relocate_single_git_dir_into_superproject(path, super_prefix); |
2469 | |
|
2470 | 0 | free(real_sub_git_dir); |
2471 | 0 | free(real_common_git_dir); |
2472 | 0 | } |
2473 | 0 | strbuf_release(&gitdir); |
2474 | |
|
2475 | 0 | absorb_git_dir_into_superproject_recurse(path, super_prefix); |
2476 | 0 | } |
2477 | | |
2478 | | int get_superproject_working_tree(struct strbuf *buf) |
2479 | 0 | { |
2480 | 0 | struct child_process cp = CHILD_PROCESS_INIT; |
2481 | 0 | struct strbuf sb = STRBUF_INIT; |
2482 | 0 | struct strbuf one_up = STRBUF_INIT; |
2483 | 0 | char *cwd = xgetcwd(); |
2484 | 0 | int ret = 0; |
2485 | 0 | const char *subpath; |
2486 | 0 | int code; |
2487 | 0 | ssize_t len; |
2488 | |
|
2489 | 0 | if (!is_inside_work_tree()) |
2490 | | /* |
2491 | | * FIXME: |
2492 | | * We might have a superproject, but it is harder |
2493 | | * to determine. |
2494 | | */ |
2495 | 0 | return 0; |
2496 | | |
2497 | 0 | if (!strbuf_realpath(&one_up, "../", 0)) |
2498 | 0 | return 0; |
2499 | | |
2500 | 0 | subpath = relative_path(cwd, one_up.buf, &sb); |
2501 | 0 | strbuf_release(&one_up); |
2502 | |
|
2503 | 0 | prepare_submodule_repo_env(&cp.env); |
2504 | 0 | strvec_pop(&cp.env); |
2505 | |
|
2506 | 0 | strvec_pushl(&cp.args, "--literal-pathspecs", "-C", "..", |
2507 | 0 | "ls-files", "-z", "--stage", "--full-name", "--", |
2508 | 0 | subpath, NULL); |
2509 | 0 | strbuf_reset(&sb); |
2510 | |
|
2511 | 0 | cp.no_stdin = 1; |
2512 | 0 | cp.no_stderr = 1; |
2513 | 0 | cp.out = -1; |
2514 | 0 | cp.git_cmd = 1; |
2515 | |
|
2516 | 0 | if (start_command(&cp)) |
2517 | 0 | die(_("could not start ls-files in ..")); |
2518 | | |
2519 | 0 | len = strbuf_read(&sb, cp.out, PATH_MAX); |
2520 | 0 | close(cp.out); |
2521 | |
|
2522 | 0 | if (starts_with(sb.buf, "160000")) { |
2523 | 0 | int super_sub_len; |
2524 | 0 | int cwd_len = strlen(cwd); |
2525 | 0 | char *super_sub, *super_wt; |
2526 | | |
2527 | | /* |
2528 | | * There is a superproject having this repo as a submodule. |
2529 | | * The format is <mode> SP <hash> SP <stage> TAB <full name> \0, |
2530 | | * We're only interested in the name after the tab. |
2531 | | */ |
2532 | 0 | super_sub = strchr(sb.buf, '\t') + 1; |
2533 | 0 | super_sub_len = strlen(super_sub); |
2534 | |
|
2535 | 0 | if (super_sub_len > cwd_len || |
2536 | 0 | strcmp(&cwd[cwd_len - super_sub_len], super_sub)) |
2537 | 0 | BUG("returned path string doesn't match cwd?"); |
2538 | | |
2539 | 0 | super_wt = xstrdup(cwd); |
2540 | 0 | super_wt[cwd_len - super_sub_len] = '\0'; |
2541 | |
|
2542 | 0 | strbuf_realpath(buf, super_wt, 1); |
2543 | 0 | ret = 1; |
2544 | 0 | free(super_wt); |
2545 | 0 | } |
2546 | 0 | free(cwd); |
2547 | 0 | strbuf_release(&sb); |
2548 | |
|
2549 | 0 | code = finish_command(&cp); |
2550 | |
|
2551 | 0 | if (code == 128) |
2552 | | /* '../' is not a git repository */ |
2553 | 0 | return 0; |
2554 | 0 | if (code == 0 && len == 0) |
2555 | | /* There is an unrelated git repository at '../' */ |
2556 | 0 | return 0; |
2557 | 0 | if (code) |
2558 | 0 | die(_("ls-tree returned unexpected return code %d"), code); |
2559 | | |
2560 | 0 | return ret; |
2561 | 0 | } |
2562 | | |
2563 | | /* |
2564 | | * Put the gitdir for a submodule (given relative to the main |
2565 | | * repository worktree) into `buf`, or return -1 on error. |
2566 | | */ |
2567 | | int submodule_to_gitdir(struct strbuf *buf, const char *submodule) |
2568 | 0 | { |
2569 | 0 | const struct submodule *sub; |
2570 | 0 | const char *git_dir; |
2571 | 0 | int ret = 0; |
2572 | |
|
2573 | 0 | if (validate_submodule_path(submodule) < 0) |
2574 | 0 | exit(128); |
2575 | | |
2576 | 0 | strbuf_reset(buf); |
2577 | 0 | strbuf_addstr(buf, submodule); |
2578 | 0 | strbuf_complete(buf, '/'); |
2579 | 0 | strbuf_addstr(buf, ".git"); |
2580 | |
|
2581 | 0 | git_dir = read_gitfile(buf->buf); |
2582 | 0 | if (git_dir) { |
2583 | 0 | strbuf_reset(buf); |
2584 | 0 | strbuf_addstr(buf, git_dir); |
2585 | 0 | } |
2586 | 0 | if (!is_git_directory(buf->buf)) { |
2587 | 0 | sub = submodule_from_path(the_repository, null_oid(), |
2588 | 0 | submodule); |
2589 | 0 | if (!sub) { |
2590 | 0 | ret = -1; |
2591 | 0 | goto cleanup; |
2592 | 0 | } |
2593 | 0 | strbuf_reset(buf); |
2594 | 0 | submodule_name_to_gitdir(buf, the_repository, sub->name); |
2595 | 0 | } |
2596 | | |
2597 | 0 | cleanup: |
2598 | 0 | return ret; |
2599 | 0 | } |
2600 | | |
2601 | | void submodule_name_to_gitdir(struct strbuf *buf, struct repository *r, |
2602 | | const char *submodule_name) |
2603 | 0 | { |
2604 | | /* |
2605 | | * NEEDSWORK: The current way of mapping a submodule's name to |
2606 | | * its location in .git/modules/ has problems with some naming |
2607 | | * schemes. For example, if a submodule is named "foo" and |
2608 | | * another is named "foo/bar" (whether present in the same |
2609 | | * superproject commit or not - the problem will arise if both |
2610 | | * superproject commits have been checked out at any point in |
2611 | | * time), or if two submodule names only have different cases in |
2612 | | * a case-insensitive filesystem. |
2613 | | * |
2614 | | * There are several solutions, including encoding the path in |
2615 | | * some way, introducing a submodule.<name>.gitdir config in |
2616 | | * .git/config (not .gitmodules) that allows overriding what the |
2617 | | * gitdir of a submodule would be (and teach Git, upon noticing |
2618 | | * a clash, to automatically determine a non-clashing name and |
2619 | | * to write such a config), or introducing a |
2620 | | * submodule.<name>.gitdir config in .gitmodules that repo |
2621 | | * administrators can explicitly set. Nothing has been decided, |
2622 | | * so for now, just append the name at the end of the path. |
2623 | | */ |
2624 | 0 | strbuf_repo_git_path(buf, r, "modules/"); |
2625 | 0 | strbuf_addstr(buf, submodule_name); |
2626 | 0 | } |