Coverage Report

Created: 2025-08-11 08:01

/src/libjxl/lib/jxl/memory_manager_internal.cc
Line
Count
Source (jump to first uncovered line)
1
// Copyright (c) the JPEG XL Project Authors. All rights reserved.
2
//
3
// Use of this source code is governed by a BSD-style
4
// license that can be found in the LICENSE file.
5
6
#include "lib/jxl/memory_manager_internal.h"
7
8
#include <jxl/memory_manager.h>
9
10
#include <algorithm>
11
#include <atomic>
12
#include <cstddef>
13
#include <cstdio>
14
#include <cstdlib>
15
#include <cstring>     // memcpy
16
#include <hwy/base.h>  // kMaxVectorSize
17
18
#include "lib/jxl/base/common.h"
19
#include "lib/jxl/base/status.h"
20
#include "lib/jxl/simd_util.h"
21
22
namespace jxl {
23
24
namespace {
25
26
0
void* MemoryManagerDefaultAlloc(void* opaque, size_t size) {
27
0
  return malloc(size);
28
0
}
29
30
0
void MemoryManagerDefaultFree(void* opaque, void* address) { free(address); }
31
32
}  // namespace
33
34
22.4k
void* MemoryManagerAlloc(const JxlMemoryManager* memory_manager, size_t size) {
35
22.4k
  return memory_manager->alloc(memory_manager->opaque, size);
36
22.4k
}
37
38
22.4k
void MemoryManagerFree(const JxlMemoryManager* memory_manager, void* address) {
39
22.4k
  memory_manager->free(memory_manager->opaque, address);
40
22.4k
}
41
42
Status MemoryManagerInit(JxlMemoryManager* self,
43
22.4k
                         const JxlMemoryManager* memory_manager) {
44
22.4k
  if (memory_manager) {
45
22.4k
    *self = *memory_manager;
46
22.4k
  } else {
47
0
    memset(self, 0, sizeof(*self));
48
0
  }
49
22.4k
  bool is_default_alloc = (self->alloc == nullptr);
50
22.4k
  bool is_default_free = (self->free == nullptr);
51
22.4k
  if (is_default_alloc != is_default_free) {
52
0
    return false;
53
0
  }
54
22.4k
  if (is_default_alloc) self->alloc = jxl::MemoryManagerDefaultAlloc;
55
22.4k
  if (is_default_free) self->free = jxl::MemoryManagerDefaultFree;
56
57
22.4k
  return true;
58
22.4k
}
59
60
13.4M
size_t BytesPerRow(const size_t xsize, const size_t sizeof_t) {
61
  // Special case: we don't allow any ops -> don't need extra padding/
62
13.4M
  if (xsize == 0) {
63
154k
    return 0;
64
154k
  }
65
66
13.2M
  const size_t vec_size = MaxVectorSize();
67
13.2M
  size_t valid_bytes = xsize * sizeof_t;
68
69
  // Allow unaligned accesses starting at the last valid value.
70
  // Skip for the scalar case because no extra lanes will be loaded.
71
13.2M
  if (vec_size != 0) {
72
13.2M
    valid_bytes += vec_size - sizeof_t;
73
13.2M
  }
74
75
  // Round up to vector and cache line size.
76
13.2M
  const size_t align = std::max(vec_size, memory_manager_internal::kAlignment);
77
13.2M
  size_t bytes_per_row = RoundUpTo(valid_bytes, align);
78
79
  // During the lengthy window before writes are committed to memory, CPUs
80
  // guard against read after write hazards by checking the address, but
81
  // only the lower 11 bits. We avoid a false dependency between writes to
82
  // consecutive rows by ensuring their sizes are not multiples of 2 KiB.
83
  // Avoid2K prevents the same problem for the planes of an Image3.
84
13.2M
  if (bytes_per_row % memory_manager_internal::kAlias == 0) {
85
52.4k
    bytes_per_row += align;
86
52.4k
  }
87
88
13.2M
  JXL_DASSERT(bytes_per_row % align == 0);
89
13.2M
  return bytes_per_row;
90
13.2M
}
91
92
StatusOr<AlignedMemory> AlignedMemory::Create(JxlMemoryManager* memory_manager,
93
13.4M
                                              size_t size, size_t pre_padding) {
94
13.4M
  JXL_ENSURE(pre_padding <= memory_manager_internal::kAlias);
95
13.4M
  size_t allocation_size = size + pre_padding + memory_manager_internal::kAlias;
96
13.4M
  if (size > allocation_size) {
97
0
    return JXL_FAILURE("Requested allocation is too large");
98
0
  }
99
13.4M
  JXL_ENSURE(memory_manager);
100
13.4M
  void* allocated =
101
13.4M
      memory_manager->alloc(memory_manager->opaque, allocation_size);
102
13.4M
  if (allocated == nullptr) {
103
27
    return JXL_FAILURE("Allocation failed");
104
27
  }
105
13.4M
  return AlignedMemory(memory_manager, allocated, pre_padding);
106
13.4M
}
107
108
AlignedMemory::AlignedMemory(JxlMemoryManager* memory_manager, void* allocation,
109
                             size_t pre_padding)
110
13.4M
    : allocation_(allocation), memory_manager_(memory_manager) {
111
  // Congruence to `offset` (mod kAlias) reduces cache conflicts and load/store
112
  // stalls, especially with large allocations that would otherwise have similar
113
  // alignments.
114
13.4M
  static std::atomic<uint32_t> next_group{0};
115
13.4M
  size_t group =
116
13.4M
      static_cast<size_t>(next_group.fetch_add(1, std::memory_order_relaxed));
117
13.4M
  group &= (memory_manager_internal::kNumAlignmentGroups - 1);
118
13.4M
  size_t offset = memory_manager_internal::kAlignment * group;
119
120
  // Actual allocation.
121
13.4M
  uintptr_t address = reinterpret_cast<uintptr_t>(allocation) + pre_padding;
122
123
  // Aligned address, but might land before allocation (50%/50%) or not have
124
  // enough pre-padding.
125
13.4M
  uintptr_t aligned_address =
126
13.4M
      (address & ~(memory_manager_internal::kAlias - 1)) + offset;
127
13.4M
  if (aligned_address < address)
128
7.21M
    aligned_address += memory_manager_internal::kAlias;
129
130
13.4M
  address_ = reinterpret_cast<void*>(aligned_address);  // NOLINT
131
13.4M
}
132
133
55.4M
AlignedMemory::AlignedMemory(AlignedMemory&& other) noexcept {
134
55.4M
  allocation_ = other.allocation_;
135
55.4M
  memory_manager_ = other.memory_manager_;
136
55.4M
  address_ = other.address_;
137
55.4M
  other.memory_manager_ = nullptr;
138
55.4M
}
139
140
17.1M
AlignedMemory& AlignedMemory::operator=(AlignedMemory&& other) noexcept {
141
17.1M
  if (this == &other) return *this;
142
17.1M
  if (memory_manager_ && allocation_) {
143
557k
    memory_manager_->free(memory_manager_->opaque, allocation_);
144
557k
  }
145
17.1M
  allocation_ = other.allocation_;
146
17.1M
  memory_manager_ = other.memory_manager_;
147
17.1M
  address_ = other.address_;
148
17.1M
  other.memory_manager_ = nullptr;
149
17.1M
  return *this;
150
17.1M
}
151
152
87.2M
AlignedMemory::~AlignedMemory() {
153
87.2M
  if (memory_manager_ == nullptr) return;
154
12.8M
  memory_manager_->free(memory_manager_->opaque, allocation_);
155
12.8M
}
156
157
}  // namespace jxl