Coverage Report

Created: 2026-09-14 07:37

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/libjxl/lib/jxl/modular/encoding/dec_ma.cc
Line
Count
Source
1
// Copyright (c) the JPEG XL Project Authors. All rights reserved.
2
//
3
// Use of this source code is governed by a BSD-style
4
// license that can be found in the LICENSE file.
5
6
#include "lib/jxl/modular/encoding/dec_ma.h"
7
8
#include <jxl/memory_manager.h>
9
10
#include <algorithm>
11
#include <cstddef>
12
#include <cstdint>
13
#include <limits>
14
#include <utility>
15
#include <vector>
16
17
#include "lib/jxl/base/printf_macros.h"
18
#include "lib/jxl/base/status.h"
19
#include "lib/jxl/dec_ans.h"
20
#include "lib/jxl/dec_bit_reader.h"
21
#include "lib/jxl/modular/encoding/ma_common.h"
22
#include "lib/jxl/modular/modular_image.h"
23
#include "lib/jxl/modular/options.h"
24
#include "lib/jxl/pack_signed.h"
25
26
namespace jxl {
27
28
namespace {
29
30
enum class NextAction { CHECK_AND_GO_LEFT, GO_RIGHT, POP };
31
32
struct WorkItem {
33
  size_t node_index;
34
  pixel_type orig_l;
35
  pixel_type orig_u;
36
  NextAction action;
37
};
38
39
176k
Status ValidateTree(const Tree& tree) {
40
176k
  if (tree.empty()) return true;
41
  // TODO(eustas): or invalid?
42
43
176k
  int num_properties = 0;
44
519k
  for (auto node : tree) {
45
519k
    if (node.property >= num_properties) {
46
27.4k
      num_properties = node.property + 1;
47
27.4k
    }
48
519k
  }
49
50
176k
  std::vector<std::pair<pixel_type, pixel_type>> property_ranges(
51
176k
      num_properties);
52
381k
  for (int i = 0; i < num_properties; i++) {
53
205k
    property_ranges[i].first = std::numeric_limits<pixel_type>::min();
54
205k
    property_ranges[i].second = std::numeric_limits<pixel_type>::max();
55
205k
  }
56
57
176k
  constexpr size_t kHeightLimit = 2048;
58
59
176k
  std::vector<WorkItem> stack;
60
176k
  stack.push_back({/*node_index=*/0, /*orig_l=*/0, /*orig_u=*/0,
61
176k
                   NextAction::CHECK_AND_GO_LEFT});
62
63
1.03M
  while (!stack.empty()) {
64
856k
    if (stack.size() >= kHeightLimit) return JXL_FAILURE("Tree too tall");
65
856k
    WorkItem& item = stack.back();
66
856k
    const auto& node = tree[item.node_index];
67
856k
    switch (item.action) {
68
516k
      case NextAction::CHECK_AND_GO_LEFT: {
69
516k
        int16_t p = node.property;
70
516k
        if (p == -1) {
71
345k
          stack.pop_back();
72
345k
          continue;
73
345k
        }
74
170k
        PropertyVal v = node.splitval;
75
170k
        pixel_type l = property_ranges[p].first;
76
170k
        pixel_type u = property_ranges[p].second;
77
170k
        if (l > v || u <= v) {
78
343
          return JXL_FAILURE("Invalid tree");
79
343
        }
80
170k
        item.orig_l = l;
81
170k
        item.orig_u = u;
82
170k
        item.action = NextAction::GO_RIGHT;
83
170k
        property_ranges[node.property].first = node.splitval + 1;
84
170k
        stack.push_back({/*node_index=*/node.lchild,
85
170k
                         /*orig_l=*/0, /*orig_u=*/0,
86
170k
                         NextAction::CHECK_AND_GO_LEFT});
87
170k
        continue;
88
170k
      }
89
90
170k
      case NextAction::GO_RIGHT:
91
170k
        item.action = NextAction::POP;
92
170k
        property_ranges[node.property].first = item.orig_l;
93
170k
        property_ranges[node.property].second = node.splitval;
94
170k
        stack.push_back({/*node_index=*/node.rchild,
95
170k
                         /*orig_l=*/0, /*orig_u=*/0,
96
170k
                         NextAction::CHECK_AND_GO_LEFT});
97
170k
        continue;
98
99
169k
      case NextAction::POP:
100
169k
        property_ranges[node.property].second = item.orig_u;
101
169k
        stack.pop_back();
102
169k
        continue;
103
856k
    }
104
856k
  }
105
106
175k
  return true;
107
176k
}
108
109
Status DecodeTree(BitReader* br, ANSSymbolReader* reader,
110
                  const std::vector<uint8_t>& context_map, Tree* tree,
111
187k
                  size_t tree_size_limit) {
112
187k
  size_t leaf_id = 0;
113
187k
  size_t to_decode = 1;
114
187k
  tree->clear();
115
1.65M
  while (to_decode > 0) {
116
1.47M
    JXL_RETURN_IF_ERROR(br->AllReadsWithinBounds());
117
1.46M
    if (tree->size() > tree_size_limit) {
118
251
      return JXL_FAILURE("Tree is too large: %" PRIuS " nodes vs %" PRIuS
119
251
                         " max nodes",
120
251
                         tree->size(), tree_size_limit);
121
251
    }
122
1.46M
    to_decode--;
123
1.46M
    uint32_t prop1 = reader->ReadHybridUint(kPropertyContext, br, context_map);
124
1.46M
    if (prop1 > 256) return JXL_FAILURE("Invalid tree property value");
125
1.46M
    int property = prop1 - 1;
126
1.46M
    if (property == -1) {
127
361k
      size_t predictor =
128
361k
          reader->ReadHybridUint(kPredictorContext, br, context_map);
129
361k
      if (predictor >= kNumModularPredictors) {
130
488
        return JXL_FAILURE("Invalid predictor");
131
488
      }
132
360k
      int64_t predictor_offset =
133
360k
          UnpackSigned(reader->ReadHybridUint(kOffsetContext, br, context_map));
134
360k
      uint32_t mul_log =
135
360k
          reader->ReadHybridUint(kMultiplierLogContext, br, context_map);
136
360k
      if (mul_log >= 31) {
137
26
        return JXL_FAILURE("Invalid multiplier logarithm");
138
26
      }
139
360k
      uint32_t mul_bits =
140
360k
          reader->ReadHybridUint(kMultiplierBitsContext, br, context_map);
141
360k
      if (mul_bits >= (1u << (31u - mul_log)) - 1u) {
142
10
        return JXL_FAILURE("Invalid multiplier");
143
10
      }
144
360k
      uint32_t multiplier = (mul_bits + 1U) << mul_log;
145
360k
      Predictor p = static_cast<Predictor>(static_cast<uint32_t>(predictor));
146
360k
      tree->emplace_back(-1, 0, static_cast<int>(leaf_id), 0, p,
147
360k
                         predictor_offset, multiplier);
148
360k
      leaf_id++;
149
360k
      continue;
150
360k
    }
151
1.10M
    int splitval =
152
1.10M
        UnpackSigned(reader->ReadHybridUint(kSplitValContext, br, context_map));
153
1.10M
    tree->emplace_back(
154
1.10M
        property, splitval, static_cast<int>(tree->size() + to_decode + 1),
155
1.10M
        static_cast<int>(tree->size() + to_decode + 2), Predictor::Zero, 0, 1);
156
1.10M
    to_decode += 2;
157
1.10M
  }
158
176k
  return ValidateTree(*tree);
159
187k
}
160
}  // namespace
161
162
Status DecodeTree(JxlMemoryManager* memory_manager, BitReader* br, Tree* tree,
163
202k
                  size_t tree_size_limit) {
164
202k
  std::vector<uint8_t> tree_context_map;
165
202k
  ANSCode tree_code;
166
202k
  JXL_RETURN_IF_ERROR(DecodeHistograms(memory_manager, br, kNumTreeContexts,
167
202k
                                       &tree_code, &tree_context_map));
168
  // TODO(eustas): investigate more infinite tree cases.
169
188k
  if (tree_code.degenerate_symbols[tree_context_map[kPropertyContext]] > 0) {
170
1.02k
    return JXL_FAILURE("Infinite tree");
171
1.02k
  }
172
374k
  JXL_ASSIGN_OR_RETURN(ANSSymbolReader reader,
173
374k
                       ANSSymbolReader::Create(&tree_code, br));
174
374k
  JXL_RETURN_IF_ERROR(DecodeTree(br, &reader, tree_context_map, tree,
175
374k
                                 std::min(tree_size_limit, kMaxTreeSize)));
176
175k
  if (!reader.CheckANSFinalState()) {
177
0
    return JXL_FAILURE("ANS decode final state failed");
178
0
  }
179
175k
  return true;
180
175k
}
181
182
}  // namespace jxl