TestFederationClientInterceptorRetry.java

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package org.apache.hadoop.yarn.server.router.clientrm;

import static org.apache.hadoop.yarn.conf.YarnConfiguration.FEDERATION_POLICY_MANAGER;
import static org.hamcrest.CoreMatchers.is;
import static org.mockito.Mockito.mock;

import java.io.IOException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.List;

import org.apache.hadoop.test.LambdaTestUtils;
import org.apache.hadoop.yarn.MockApps;
import org.apache.hadoop.yarn.api.protocolrecords.GetNewApplicationRequest;
import org.apache.hadoop.yarn.api.protocolrecords.GetNewApplicationResponse;
import org.apache.hadoop.yarn.api.protocolrecords.SubmitApplicationRequest;
import org.apache.hadoop.yarn.api.protocolrecords.SubmitApplicationResponse;
import org.apache.hadoop.yarn.api.protocolrecords.GetClusterMetricsRequest;
import org.apache.hadoop.yarn.api.protocolrecords.GetClusterMetricsResponse;
import org.apache.hadoop.yarn.api.records.ApplicationId;
import org.apache.hadoop.yarn.api.records.ApplicationSubmissionContext;
import org.apache.hadoop.yarn.api.records.ContainerLaunchContext;
import org.apache.hadoop.yarn.api.records.Priority;
import org.apache.hadoop.yarn.conf.YarnConfiguration;
import org.apache.hadoop.yarn.exceptions.YarnException;
import org.apache.hadoop.yarn.server.federation.policies.manager.UniformBroadcastPolicyManager;
import org.apache.hadoop.yarn.server.federation.store.impl.MemoryFederationStateStore;
import org.apache.hadoop.yarn.server.federation.store.records.ApplicationHomeSubCluster;
import org.apache.hadoop.yarn.server.federation.store.records.GetApplicationHomeSubClusterRequest;
import org.apache.hadoop.yarn.server.federation.store.records.GetApplicationHomeSubClusterResponse;
import org.apache.hadoop.yarn.server.federation.store.records.SubClusterId;
import org.apache.hadoop.yarn.server.federation.utils.FederationStateStoreFacade;
import org.apache.hadoop.yarn.server.federation.utils.FederationStateStoreTestUtil;
import org.apache.hadoop.yarn.server.resourcemanager.ResourceManager;
import org.apache.hadoop.yarn.util.resource.Resources;
import org.junit.Assert;
import org.junit.Assume;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.junit.runners.Parameterized.Parameters;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import static org.apache.hadoop.yarn.server.federation.policies.FederationPolicyUtils.NO_ACTIVE_SUBCLUSTER_AVAILABLE;

/**
 * Extends the {@code BaseRouterClientRMTest} and overrides methods in order to
 * use the {@code RouterClientRMService} pipeline test cases for testing the
 * {@code FederationInterceptor} class. The tests for
 * {@code RouterClientRMService} has been written cleverly so that it can be
 * reused to validate different request interceptor chains.
 *
 * It tests the case with SubClusters down and the Router logic of retries. We
 * have 1 good SubCluster and 2 bad ones for all the tests.
 */
@RunWith(Parameterized.class)
public class TestFederationClientInterceptorRetry
    extends BaseRouterClientRMTest {
  private static final Logger LOG =
      LoggerFactory.getLogger(TestFederationClientInterceptorRetry.class);

  @Parameters
  public static Collection<String[]> getParameters() {
    return Arrays.asList(new String[][] {{UniformBroadcastPolicyManager.class.getName()},
        {TestSequentialBroadcastPolicyManager.class.getName()}});
  }

  private TestableFederationClientInterceptor interceptor;
  private MemoryFederationStateStore stateStore;
  private FederationStateStoreTestUtil stateStoreUtil;
  private String routerPolicyManagerName;

  private String user = "test-user";

  // running and registered
  private static SubClusterId good;

  // registered but not running
  private static SubClusterId bad1;
  private static SubClusterId bad2;

  private static List<SubClusterId> scs = new ArrayList<>();

  public TestFederationClientInterceptorRetry(String policyManagerName) {
    this.routerPolicyManagerName = policyManagerName;
  }

  @Override
  public void setUp() throws IOException {
    super.setUpConfig();
    interceptor = new TestableFederationClientInterceptor();

    stateStore = new MemoryFederationStateStore();
    stateStore.init(this.getConf());
    FederationStateStoreFacade.getInstance(getConf()).reinitialize(stateStore,
        getConf());
    stateStoreUtil = new FederationStateStoreTestUtil(stateStore);

    interceptor.setConf(this.getConf());
    interceptor.init(user);

    // Create SubClusters
    good = SubClusterId.newInstance("0");
    bad1 = SubClusterId.newInstance("1");
    bad2 = SubClusterId.newInstance("2");
    scs.add(good);
    scs.add(bad1);
    scs.add(bad2);

    // The mock RM will not start in these SubClusters, this is done to simulate
    // a SubCluster down

    interceptor.registerBadSubCluster(bad1);
    interceptor.registerBadSubCluster(bad2);
  }

  @Override
  public void tearDown() {
    interceptor.shutdown();
    super.tearDown();
  }

  private void setupCluster(List<SubClusterId> scsToRegister) throws YarnException {

    try {
      // Clean up the StateStore before every test
      stateStoreUtil.deregisterAllSubClusters();

      for (SubClusterId sc : scsToRegister) {
        stateStoreUtil.registerSubCluster(sc);
      }
    } catch (YarnException e) {
      LOG.error(e.getMessage());
      Assert.fail();
    }
  }

  @Override
  protected YarnConfiguration createConfiguration() {

    YarnConfiguration conf = new YarnConfiguration();
    conf.setBoolean(YarnConfiguration.FEDERATION_ENABLED, true);
    String mockPassThroughInterceptorClass =
        PassThroughClientRequestInterceptor.class.getName();

    // Create a request interceptor pipeline for testing. The last one in the
    // chain is the federation interceptor that calls the mock resource manager.
    // The others in the chain will simply forward it to the next one in the
    // chain
    conf.set(YarnConfiguration.ROUTER_CLIENTRM_INTERCEPTOR_CLASS_PIPELINE,
        mockPassThroughInterceptorClass + "," + mockPassThroughInterceptorClass
            + "," + TestableFederationClientInterceptor.class.getName());

    conf.set(FEDERATION_POLICY_MANAGER, this.routerPolicyManagerName);

    // Disable StateStoreFacade cache
    conf.setInt(YarnConfiguration.FEDERATION_CACHE_TIME_TO_LIVE_SECS, 0);

    return conf;
  }

  /**
   * This test validates the correctness of GetNewApplication in case the
   * cluster is composed of only 1 bad SubCluster.
   */
  @Test
  public void testGetNewApplicationOneBadSC() throws Exception {

    LOG.info("Test getNewApplication with one bad SubCluster");
    setupCluster(Arrays.asList(bad2));

    GetNewApplicationRequest request = GetNewApplicationRequest.newInstance();
    LambdaTestUtils.intercept(YarnException.class, NO_ACTIVE_SUBCLUSTER_AVAILABLE,
        () -> interceptor.getNewApplication(request));
  }

  /**
   * This test validates the correctness of GetNewApplication in case the
   * cluster is composed of only 2 bad SubClusters.
   */
  @Test
  public void testGetNewApplicationTwoBadSCs() throws Exception {

    LOG.info("Test getNewApplication with two bad SubClusters");
    setupCluster(Arrays.asList(bad1, bad2));

    GetNewApplicationRequest request = GetNewApplicationRequest.newInstance();
    LambdaTestUtils.intercept(YarnException.class, NO_ACTIVE_SUBCLUSTER_AVAILABLE,
        () -> interceptor.getNewApplication(request));
  }

  /**
   * This test validates the correctness of GetNewApplication in case the
   * cluster is composed of only 1 bad SubCluster and 1 good one.
   */
  @Test
  public void testGetNewApplicationOneBadOneGood() throws YarnException, IOException {

    LOG.info("Test getNewApplication with one bad, one good SC");
    setupCluster(Arrays.asList(good, bad2));
    GetNewApplicationRequest request = GetNewApplicationRequest.newInstance();
    GetNewApplicationResponse response = interceptor.getNewApplication(request);

    Assert.assertNotNull(response);
    Assert.assertEquals(ResourceManager.getClusterTimeStamp(),
        response.getApplicationId().getClusterTimestamp());
  }

  /**
   * This test validates the correctness of SubmitApplication in case the
   * cluster is composed of only 1 bad SubCluster.
   */
  @Test
  public void testSubmitApplicationOneBadSC() throws Exception {

    LOG.info("Test submitApplication with one bad SubCluster");
    setupCluster(Arrays.asList(bad2));

    final ApplicationId appId =
        ApplicationId.newInstance(System.currentTimeMillis(), 1);

    final SubmitApplicationRequest request = mockSubmitApplicationRequest(appId);
    LambdaTestUtils.intercept(YarnException.class, NO_ACTIVE_SUBCLUSTER_AVAILABLE,
        () -> interceptor.submitApplication(request));
  }

  private SubmitApplicationRequest mockSubmitApplicationRequest(ApplicationId appId) {
    ContainerLaunchContext amContainerSpec = mock(ContainerLaunchContext.class);
    ApplicationSubmissionContext context = ApplicationSubmissionContext
        .newInstance(appId, MockApps.newAppName(), "q1",
        Priority.newInstance(0), amContainerSpec, false, false, -1,
        Resources.createResource(YarnConfiguration.DEFAULT_RM_SCHEDULER_MINIMUM_ALLOCATION_MB),
        "MockApp");
    SubmitApplicationRequest request = SubmitApplicationRequest.newInstance(context);
    return request;
  }

  /**
   * This test validates the correctness of SubmitApplication in case the
   * cluster is composed of only 2 bad SubClusters.
   */
  @Test
  public void testSubmitApplicationTwoBadSCs() throws Exception {

    LOG.info("Test submitApplication with two bad SubClusters.");
    setupCluster(Arrays.asList(bad1, bad2));

    final ApplicationId appId =
        ApplicationId.newInstance(System.currentTimeMillis(), 1);

    final SubmitApplicationRequest request = mockSubmitApplicationRequest(appId);
    LambdaTestUtils.intercept(YarnException.class, NO_ACTIVE_SUBCLUSTER_AVAILABLE,
        () -> interceptor.submitApplication(request));
  }

  /**
   * This test validates the correctness of SubmitApplication in case the
   * cluster is composed of only 1 bad SubCluster and a good one.
   */
  @Test
  public void testSubmitApplicationOneBadOneGood()
      throws YarnException, IOException, InterruptedException {

    LOG.info("Test submitApplication with one bad, one good SC.");
    setupCluster(Arrays.asList(good, bad2));

    final ApplicationId appId =
        ApplicationId.newInstance(System.currentTimeMillis(), 1);

    final SubmitApplicationRequest request = mockSubmitApplicationRequest(appId);
    SubmitApplicationResponse response = interceptor.submitApplication(request);
    Assert.assertNotNull(response);

    GetApplicationHomeSubClusterRequest getAppRequest =
        GetApplicationHomeSubClusterRequest.newInstance(appId);
    GetApplicationHomeSubClusterResponse getAppResponse =
        stateStore.getApplicationHomeSubCluster(getAppRequest);
    Assert.assertNotNull(getAppResponse);

    ApplicationHomeSubCluster responseHomeSubCluster =
        getAppResponse.getApplicationHomeSubCluster();
    Assert.assertNotNull(responseHomeSubCluster);
    SubClusterId respSubClusterId = responseHomeSubCluster.getHomeSubCluster();
    Assert.assertEquals(good, respSubClusterId);
  }

  @Test
  public void testSubmitApplicationTwoBadOneGood() throws Exception {

    LOG.info("Test submitApplication with two bad, one good SC.");

    // This test must require the TestSequentialRouterPolicy policy
    Assume.assumeThat(routerPolicyManagerName,
        is(TestSequentialBroadcastPolicyManager.class.getName()));

    setupCluster(Arrays.asList(bad1, bad2, good));
    final ApplicationId appId =
        ApplicationId.newInstance(System.currentTimeMillis(), 1);

    // Use the TestSequentialRouterPolicy strategy,
    // which will sort the SubClusterId because good=0, bad1=1, bad2=2
    // We will get 2, 1, 0 [bad2, bad1, good]
    // Set the retryNum to 1
    // 1st time will use bad2, 2nd time will use bad1
    // bad1 is updated to stateStore
    interceptor.setNumSubmitRetries(1);
    final SubmitApplicationRequest request = mockSubmitApplicationRequest(appId);
    LambdaTestUtils.intercept(YarnException.class, "RM is stopped",
        () -> interceptor.submitApplication(request));

    // We will get bad1
    checkSubmitSubCluster(appId, bad1);

    // Set the retryNum to 2
    // 1st time will use bad2, 2nd time will use bad1, 3rd good
    interceptor.setNumSubmitRetries(2);
    SubmitApplicationResponse submitAppResponse = interceptor.submitApplication(request);
    Assert.assertNotNull(submitAppResponse);

    // We will get good
    checkSubmitSubCluster(appId, good);
  }

  private void checkSubmitSubCluster(ApplicationId appId, SubClusterId expectSubCluster)
      throws YarnException {
    GetApplicationHomeSubClusterRequest getAppRequest =
        GetApplicationHomeSubClusterRequest.newInstance(appId);
    GetApplicationHomeSubClusterResponse getAppResponse =
        stateStore.getApplicationHomeSubCluster(getAppRequest);
    Assert.assertNotNull(getAppResponse);
    Assert.assertNotNull(getAppResponse);
    ApplicationHomeSubCluster responseHomeSubCluster =
        getAppResponse.getApplicationHomeSubCluster();
    Assert.assertNotNull(responseHomeSubCluster);
    SubClusterId respSubClusterId = responseHomeSubCluster.getHomeSubCluster();
    Assert.assertEquals(expectSubCluster, respSubClusterId);
  }

  @Test
  public void testSubmitApplicationTwoBadNodeWithRealError() throws Exception {
    LOG.info("Test submitApplication with two bad SubClusters.");
    setupCluster(Arrays.asList(bad1, bad2));
    interceptor.setNumSubmitRetries(1);

    final ApplicationId appId =
        ApplicationId.newInstance(System.currentTimeMillis(), 5);

    final SubmitApplicationRequest request = mockSubmitApplicationRequest(appId);

    LambdaTestUtils.intercept(YarnException.class, "RM is stopped",
        () -> interceptor.submitApplication(request));
  }

  @Test
  public void testSubmitApplicationOneBadNodeWithRealError() throws Exception {
    LOG.info("Test submitApplication with one bad SubClusters.");
    setupCluster(Arrays.asList(bad1));
    interceptor.setNumSubmitRetries(0);

    final ApplicationId appId =
        ApplicationId.newInstance(System.currentTimeMillis(), 6);

    final SubmitApplicationRequest request = mockSubmitApplicationRequest(appId);

    LambdaTestUtils.intercept(YarnException.class, "RM is stopped",
        () -> interceptor.submitApplication(request));
  }

  @Test
  public void testGetClusterMetricsTwoBadNodeWithRealError() throws Exception {
    LOG.info("Test getClusterMetrics with two bad SubClusters.");
    setupCluster(Arrays.asList(bad1, bad2));
    GetClusterMetricsRequest request = GetClusterMetricsRequest.newInstance();

    LambdaTestUtils.intercept(YarnException.class,
        "subClusterId 1 exec getClusterMetrics error RM is stopped.",
        () -> interceptor.getClusterMetrics(request));

    LambdaTestUtils.intercept(YarnException.class,
        "subClusterId 2 exec getClusterMetrics error RM is stopped.",
        () -> interceptor.getClusterMetrics(request));
  }

  @Test
  public void testGetClusterMetricsOneBadNodeWithRealError() throws Exception {
    LOG.info("Test getClusterMetrics with one bad SubClusters.");
    setupCluster(Arrays.asList(bad1));
    GetClusterMetricsRequest request = GetClusterMetricsRequest.newInstance();

    LambdaTestUtils.intercept(YarnException.class,
        "subClusterId 1 exec getClusterMetrics error RM is stopped.",
        () -> interceptor.getClusterMetrics(request));
  }

  @Test
  public void testGetClusterMetricsOneBadOneGoodNodeWithRealError() throws Exception {
    LOG.info("Test getClusterMetrics with one bad and one good SubCluster.");
    setupCluster(Arrays.asList(bad1, good));
    GetClusterMetricsRequest request = GetClusterMetricsRequest.newInstance();

    GetClusterMetricsResponse clusterMetrics = interceptor.getClusterMetrics(request);
    Assert.assertNotNull(clusterMetrics);

    // If partial results are not allowed to be returned, an exception will be thrown.
    interceptor.setAllowPartialResult(false);
    LambdaTestUtils.intercept(YarnException.class,
        "subClusterId 1 exec getClusterMetrics error RM is stopped.",
        () -> interceptor.getClusterMetrics(request));
    interceptor.setAllowPartialResult(true);
  }
}