Coverage Report

Created: 2025-08-12 07:37

/src/libjxl/lib/jxl/dec_bit_reader.h
Line
Count
Source (jump to first uncovered line)
1
// Copyright (c) the JPEG XL Project Authors. All rights reserved.
2
//
3
// Use of this source code is governed by a BSD-style
4
// license that can be found in the LICENSE file.
5
6
#ifndef LIB_JXL_DEC_BIT_READER_H_
7
#define LIB_JXL_DEC_BIT_READER_H_
8
9
// Bounds-checked bit reader; 64-bit buffer with support for deferred refills
10
// and switching to reading byte-aligned words.
11
12
#include <cstddef>
13
#include <cstdint>
14
#include <cstring>  // memcpy
15
16
#ifdef __BMI2__
17
#include <immintrin.h>
18
#endif
19
20
#include "lib/jxl/base/byte_order.h"
21
#include "lib/jxl/base/common.h"
22
#include "lib/jxl/base/compiler_specific.h"
23
#include "lib/jxl/base/status.h"
24
25
namespace jxl {
26
27
// Reads bits previously written to memory by BitWriter. Uses unaligned 8-byte
28
// little-endian loads.
29
class BitReader {
30
 public:
31
  static constexpr size_t kMaxBitsPerCall = 56;
32
33
  // Constructs an invalid BitReader, to be overwritten before usage.
34
  BitReader()
35
      : buf_(0),
36
        bits_in_buf_(0),
37
        next_byte_{nullptr},
38
        end_minus_8_{nullptr},
39
0
        first_byte_(nullptr) {}
40
  BitReader(const BitReader&) = delete;
41
42
  // bytes need not be aligned nor padded!
43
  template <class ArrayLike>
44
  explicit BitReader(const ArrayLike& bytes)
45
342k
      : buf_(0),
46
342k
        bits_in_buf_(0),
47
342k
        next_byte_(bytes.data()),
48
        // Assumes first_byte_ >= 8.
49
342k
        end_minus_8_(bytes.data() - 8 + bytes.size()),
50
342k
        first_byte_(bytes.data()) {
51
342k
    Refill();
52
342k
  }
53
342k
  ~BitReader() {
54
    // Close() must be called before destroying an initialized bit reader.
55
    // Invalid bit readers will have a nullptr in first_byte_.
56
342k
    JXL_DASSERT(close_called_ || !first_byte_);
57
342k
  }
58
59
  // Move operator needs to invalidate the other BitReader such that it is
60
  // irrelevant if we call Close() on it or not.
61
0
  BitReader& operator=(BitReader&& other) noexcept {
62
0
    // Ensure the current instance was already closed, before we overwrite it
63
0
    // with other.
64
0
    JXL_DASSERT(close_called_ || !first_byte_);
65
0
66
0
    JXL_DASSERT(!other.close_called_);
67
0
    buf_ = other.buf_;
68
0
    bits_in_buf_ = other.bits_in_buf_;
69
0
    next_byte_ = other.next_byte_;
70
0
    end_minus_8_ = other.end_minus_8_;
71
0
    first_byte_ = other.first_byte_;
72
0
    overread_bytes_ = other.overread_bytes_;
73
0
    close_called_ = other.close_called_;
74
0
75
0
    other.first_byte_ = nullptr;
76
0
    other.next_byte_ = nullptr;
77
0
    return *this;
78
0
  }
79
  BitReader& operator=(const BitReader& other) = delete;
80
81
  // For time-critical reads, refills can be shared by multiple reads.
82
  // Based on variant 4 (plus bounds-checking), see
83
  // fgiesen.wordpress.com/2018/02/20/reading-bits-in-far-too-many-ways-part-2/
84
196M
  JXL_INLINE void Refill() {
85
196M
    if (JXL_UNLIKELY(next_byte_ > end_minus_8_)) {
86
113M
      BoundsCheckedRefill();
87
113M
    } else {
88
      // It's safe to load 64 bits; insert valid (possibly nonzero) bits above
89
      // bits_in_buf_. The shift requires bits_in_buf_ < 64.
90
83.3M
      buf_ |= LoadLE64(next_byte_) << bits_in_buf_;
91
92
      // Advance by bytes fully absorbed into the buffer.
93
83.3M
      next_byte_ += (63 - bits_in_buf_) >> 3;
94
95
      // We absorbed a multiple of 8 bits, so the lower 3 bits of bits_in_buf_
96
      // must remain unchanged, otherwise the next refill's shifted bits will
97
      // not align with buf_. Set the three upper bits so the result >= 56.
98
83.3M
      bits_in_buf_ |= 56;
99
83.3M
      JXL_DASSERT(56 <= bits_in_buf_ && bits_in_buf_ < 64);
100
83.3M
    }
101
196M
  }
102
103
  // Returns the bits that would be returned by Read without calling Advance().
104
  // It is legal to PEEK at more bits than present in the bitstream (required
105
  // by Huffman), and those bits will be zero.
106
  template <size_t N>
107
29.1M
  JXL_INLINE uint64_t PeekFixedBits() const {
108
29.1M
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
29.1M
    JXL_DASSERT(!close_called_);
110
29.1M
    return buf_ & ((1ULL << N) - 1);
111
29.1M
  }
unsigned long jxl::BitReader::PeekFixedBits<16ul>() const
Line
Count
Source
107
21.1M
  JXL_INLINE uint64_t PeekFixedBits() const {
108
21.1M
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
21.1M
    JXL_DASSERT(!close_called_);
110
21.1M
    return buf_ & ((1ULL << N) - 1);
111
21.1M
  }
unsigned long jxl::BitReader::PeekFixedBits<1ul>() const
Line
Count
Source
107
588k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
588k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
588k
    JXL_DASSERT(!close_called_);
110
588k
    return buf_ & ((1ULL << N) - 1);
111
588k
  }
unsigned long jxl::BitReader::PeekFixedBits<8ul>() const
Line
Count
Source
107
124k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
124k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
124k
    JXL_DASSERT(!close_called_);
110
124k
    return buf_ & ((1ULL << N) - 1);
111
124k
  }
unsigned long jxl::BitReader::PeekFixedBits<4ul>() const
Line
Count
Source
107
232k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
232k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
232k
    JXL_DASSERT(!close_called_);
110
232k
    return buf_ & ((1ULL << N) - 1);
111
232k
  }
unsigned long jxl::BitReader::PeekFixedBits<3ul>() const
Line
Count
Source
107
30.0k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
30.0k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
30.0k
    JXL_DASSERT(!close_called_);
110
30.0k
    return buf_ & ((1ULL << N) - 1);
111
30.0k
  }
unsigned long jxl::BitReader::PeekFixedBits<7ul>() const
Line
Count
Source
107
338k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
338k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
338k
    JXL_DASSERT(!close_called_);
110
338k
    return buf_ & ((1ULL << N) - 1);
111
338k
  }
unsigned long jxl::BitReader::PeekFixedBits<2ul>() const
Line
Count
Source
107
1.80M
  JXL_INLINE uint64_t PeekFixedBits() const {
108
1.80M
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
1.80M
    JXL_DASSERT(!close_called_);
110
1.80M
    return buf_ & ((1ULL << N) - 1);
111
1.80M
  }
unsigned long jxl::BitReader::PeekFixedBits<32ul>() const
Line
Count
Source
107
40.9k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
40.9k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
40.9k
    JXL_DASSERT(!close_called_);
110
40.9k
    return buf_ & ((1ULL << N) - 1);
111
40.9k
  }
unsigned long jxl::BitReader::PeekFixedBits<5ul>() const
Line
Count
Source
107
4.68M
  JXL_INLINE uint64_t PeekFixedBits() const {
108
4.68M
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
4.68M
    JXL_DASSERT(!close_called_);
110
4.68M
    return buf_ & ((1ULL << N) - 1);
111
4.68M
  }
unsigned long jxl::BitReader::PeekFixedBits<10ul>() const
Line
Count
Source
107
28.8k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
28.8k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
28.8k
    JXL_DASSERT(!close_called_);
110
28.8k
    return buf_ & ((1ULL << N) - 1);
111
28.8k
  }
unsigned long jxl::BitReader::PeekFixedBits<12ul>() const
Line
Count
Source
107
72.6k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
72.6k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
72.6k
    JXL_DASSERT(!close_called_);
110
72.6k
    return buf_ & ((1ULL << N) - 1);
111
72.6k
  }
unsigned long jxl::BitReader::PeekFixedBits<0ul>() const
Line
Count
Source
107
2.36k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
2.36k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
2.36k
    JXL_DASSERT(!close_called_);
110
2.36k
    return buf_ & ((1ULL << N) - 1);
111
2.36k
  }
112
113
170M
  JXL_INLINE uint64_t PeekBits(size_t nbits) const {
114
170M
    JXL_DASSERT(nbits <= kMaxBitsPerCall);
115
170M
    JXL_DASSERT(!close_called_);
116
117
    // Slightly faster but requires BMI2. It is infeasible to make the many
118
    // callers reside between begin/end_target, especially because only the
119
    // callers in dec_ans are time-critical. Therefore only enabled if the
120
    // entire binary is compiled for (and thus requires) BMI2.
121
#if defined(__BMI2__) && defined(__x86_64__)
122
    return _bzhi_u64(buf_, nbits);
123
#else
124
170M
    const uint64_t mask = (1ULL << nbits) - 1;
125
170M
    return buf_ & mask;
126
170M
#endif
127
170M
  }
128
129
  // Removes bits from the buffer. Need not match the previous Peek size, but
130
  // the buffer must contain at least num_bits (this prevents consuming more
131
  // than the total number of bits).
132
199M
  JXL_INLINE void Consume(size_t num_bits) {
133
199M
    JXL_DASSERT(!close_called_);
134
199M
    JXL_DASSERT(bits_in_buf_ >= num_bits);
135
199M
    if (JXL_CRASH_ON_ERROR) {
136
      // When JXL_CRASH_ON_ERROR is defined, it is a fatal error to read more
137
      // bits than available in the stream. A non-zero overread_bytes_ implies
138
      // that next_byte_ is already at the end of the stream, so we don't need
139
      // to check that.
140
0
      JXL_DASSERT(bits_in_buf_ >= num_bits + overread_bytes_ * kBitsPerByte);
141
0
    }
142
199M
    bits_in_buf_ -= num_bits;
143
199M
    buf_ >>= num_bits;
144
199M
  }
145
146
4.57M
  JXL_INLINE uint64_t ReadBits(size_t nbits) {
147
4.57M
    JXL_DASSERT(!close_called_);
148
4.57M
    Refill();
149
4.57M
    const uint64_t bits = PeekBits(nbits);
150
4.57M
    Consume(nbits);
151
4.57M
    return bits;
152
4.57M
  }
153
154
  template <size_t N>
155
3.10M
  JXL_INLINE uint64_t ReadFixedBits() {
156
3.10M
    JXL_DASSERT(!close_called_);
157
3.10M
    Refill();
158
3.10M
    const uint64_t bits = PeekFixedBits<N>();
159
3.10M
    Consume(N);
160
3.10M
    return bits;
161
3.10M
  }
unsigned long jxl::BitReader::ReadFixedBits<1ul>()
Line
Count
Source
155
588k
  JXL_INLINE uint64_t ReadFixedBits() {
156
588k
    JXL_DASSERT(!close_called_);
157
588k
    Refill();
158
588k
    const uint64_t bits = PeekFixedBits<N>();
159
588k
    Consume(N);
160
588k
    return bits;
161
588k
  }
unsigned long jxl::BitReader::ReadFixedBits<8ul>()
Line
Count
Source
155
124k
  JXL_INLINE uint64_t ReadFixedBits() {
156
124k
    JXL_DASSERT(!close_called_);
157
124k
    Refill();
158
124k
    const uint64_t bits = PeekFixedBits<N>();
159
124k
    Consume(N);
160
124k
    return bits;
161
124k
  }
unsigned long jxl::BitReader::ReadFixedBits<4ul>()
Line
Count
Source
155
94.2k
  JXL_INLINE uint64_t ReadFixedBits() {
156
94.2k
    JXL_DASSERT(!close_called_);
157
94.2k
    Refill();
158
94.2k
    const uint64_t bits = PeekFixedBits<N>();
159
94.2k
    Consume(N);
160
94.2k
    return bits;
161
94.2k
  }
unsigned long jxl::BitReader::ReadFixedBits<3ul>()
Line
Count
Source
155
30.0k
  JXL_INLINE uint64_t ReadFixedBits() {
156
30.0k
    JXL_DASSERT(!close_called_);
157
30.0k
    Refill();
158
30.0k
    const uint64_t bits = PeekFixedBits<N>();
159
30.0k
    Consume(N);
160
30.0k
    return bits;
161
30.0k
  }
unsigned long jxl::BitReader::ReadFixedBits<2ul>()
Line
Count
Source
155
1.80M
  JXL_INLINE uint64_t ReadFixedBits() {
156
1.80M
    JXL_DASSERT(!close_called_);
157
1.80M
    Refill();
158
1.80M
    const uint64_t bits = PeekFixedBits<N>();
159
1.80M
    Consume(N);
160
1.80M
    return bits;
161
1.80M
  }
unsigned long jxl::BitReader::ReadFixedBits<32ul>()
Line
Count
Source
155
40.9k
  JXL_INLINE uint64_t ReadFixedBits() {
156
40.9k
    JXL_DASSERT(!close_called_);
157
40.9k
    Refill();
158
40.9k
    const uint64_t bits = PeekFixedBits<N>();
159
40.9k
    Consume(N);
160
40.9k
    return bits;
161
40.9k
  }
unsigned long jxl::BitReader::ReadFixedBits<10ul>()
Line
Count
Source
155
28.8k
  JXL_INLINE uint64_t ReadFixedBits() {
156
28.8k
    JXL_DASSERT(!close_called_);
157
28.8k
    Refill();
158
28.8k
    const uint64_t bits = PeekFixedBits<N>();
159
28.8k
    Consume(N);
160
28.8k
    return bits;
161
28.8k
  }
unsigned long jxl::BitReader::ReadFixedBits<12ul>()
Line
Count
Source
155
72.6k
  JXL_INLINE uint64_t ReadFixedBits() {
156
72.6k
    JXL_DASSERT(!close_called_);
157
72.6k
    Refill();
158
72.6k
    const uint64_t bits = PeekFixedBits<N>();
159
72.6k
    Consume(N);
160
72.6k
    return bits;
161
72.6k
  }
unsigned long jxl::BitReader::ReadFixedBits<16ul>()
Line
Count
Source
155
315k
  JXL_INLINE uint64_t ReadFixedBits() {
156
315k
    JXL_DASSERT(!close_called_);
157
315k
    Refill();
158
315k
    const uint64_t bits = PeekFixedBits<N>();
159
315k
    Consume(N);
160
315k
    return bits;
161
315k
  }
unsigned long jxl::BitReader::ReadFixedBits<0ul>()
Line
Count
Source
155
2.36k
  JXL_INLINE uint64_t ReadFixedBits() {
156
2.36k
    JXL_DASSERT(!close_called_);
157
2.36k
    Refill();
158
2.36k
    const uint64_t bits = PeekFixedBits<N>();
159
2.36k
    Consume(N);
160
2.36k
    return bits;
161
2.36k
  }
162
163
  // Equivalent to calling ReadFixedBits(1) `skip` times, but much faster.
164
  // `skip` is typically large.
165
225k
  void SkipBits(size_t skip) {
166
225k
    JXL_DASSERT(!close_called_);
167
    // Buffer is large enough - don't zero buf_ below.
168
225k
    if (JXL_UNLIKELY(skip <= bits_in_buf_)) {
169
184k
      Consume(skip);
170
184k
      return;
171
184k
    }
172
173
    // First deduct what we can satisfy from the buffer
174
40.9k
    skip -= bits_in_buf_;
175
40.9k
    bits_in_buf_ = 0;
176
    // Not enough to call Advance - that may leave some bits in the buffer
177
    // which were previously ABOVE bits_in_buf.
178
40.9k
    buf_ = 0;
179
180
    // Skip whole bytes
181
40.9k
    const size_t whole_bytes = skip / kBitsPerByte;
182
40.9k
    skip %= kBitsPerByte;
183
40.9k
    if (JXL_UNLIKELY(whole_bytes >
184
40.9k
                     static_cast<size_t>(end_minus_8_ + 8 - next_byte_))) {
185
      // This is already an overflow condition (skipping past the end of the bit
186
      // stream). However if we increase next_byte_ too much we risk overflowing
187
      // that value and potentially making it valid again (next_byte_ < end).
188
      // This will set next_byte_ to the end of the stream and still consume
189
      // some bits in overread_bytes_, however the TotalBitsConsumed() will be
190
      // incorrect (still larger than the TotalBytes()).
191
36.7k
      next_byte_ = end_minus_8_ + 8;
192
36.7k
      skip += kBitsPerByte;
193
36.7k
    } else {
194
4.21k
      next_byte_ += whole_bytes;
195
4.21k
    }
196
197
40.9k
    Refill();
198
40.9k
    Consume(skip);
199
40.9k
  }
200
201
10.7M
  size_t TotalBitsConsumed() const {
202
10.7M
    const size_t bytes_read = static_cast<size_t>(next_byte_ - first_byte_);
203
10.7M
    return (bytes_read + overread_bytes_) * kBitsPerByte - bits_in_buf_;
204
10.7M
  }
205
206
85.3k
  Status JumpToByteBoundary() {
207
85.3k
    const size_t remainder = TotalBitsConsumed() % kBitsPerByte;
208
85.3k
    if (remainder == 0) return true;
209
76.3k
    if (JXL_UNLIKELY(ReadBits(kBitsPerByte - remainder) != 0)) {
210
275
      return JXL_FAILURE("Non-zero padding bits");
211
275
    }
212
76.0k
    return true;
213
76.3k
  }
214
215
  // For interoperability with other bitreaders (for resuming at
216
  // non-byte-aligned positions).
217
0
  const uint8_t* FirstByte() const { return first_byte_; }
218
5.04M
  size_t TotalBytes() const {
219
5.04M
    return static_cast<size_t>(end_minus_8_ + 8 - first_byte_);
220
5.04M
  }
221
222
  // Returns whether all the bits read so far have been within the input bounds.
223
  // When reading past the EOF, the Read*() and Consume() functions return zeros
224
  // but flag a failure when calling Close() without checking this function.
225
4.90M
  Status AllReadsWithinBounds() {
226
    // Mark up to which point the user checked the out of bounds condition. If
227
    // the user handles the condition at higher level (e.g. fetch more bytes
228
    // from network, return a custom JXL_FAILURE, ...), Close() should not
229
    // output a debug error (which would break tests with JXL_CRASH_ON_ERROR
230
    // even when legitimately handling the situation at higher level). This is
231
    // used by Bundle::CanRead.
232
4.90M
    checked_out_of_bounds_bits_ = TotalBitsConsumed();
233
4.90M
    if (TotalBitsConsumed() > TotalBytes() * kBitsPerByte) {
234
166k
      return false;
235
166k
    }
236
4.73M
    return true;
237
4.90M
  }
238
239
  // Close the bit reader and return whether all the previous reads were
240
  // successful. Close must be called once.
241
342k
  Status Close() {
242
342k
    JXL_DASSERT(!close_called_);
243
342k
    close_called_ = true;
244
342k
    if (!first_byte_) return true;
245
342k
    if (TotalBitsConsumed() > checked_out_of_bounds_bits_ &&
246
342k
        TotalBitsConsumed() > TotalBytes() * kBitsPerByte) {
247
0
      return JXL_FAILURE("Read more bits than available in the bit_reader");
248
0
    }
249
342k
    return true;
250
342k
  }
251
252
 private:
253
  // Separate function avoids inlining this relatively cold code into callers.
254
  JXL_NOINLINE void BoundsCheckedRefill();
255
256
0
  JXL_NOINLINE uint32_t BoundsCheckedReadByteAlignedWord() {
257
0
    if (next_byte_ + 1 < end_minus_8_ + 8) {
258
0
      uint32_t ret = LoadLE16(next_byte_);
259
0
      next_byte_ += 2;
260
0
      return ret;
261
0
    }
262
0
    overread_bytes_ += 2;
263
0
    return 0;
264
0
  }
265
266
  uint64_t buf_;
267
  size_t bits_in_buf_;  // [0, 64)
268
  const uint8_t* JXL_RESTRICT next_byte_;
269
  const uint8_t* end_minus_8_;  // for refill bounds check
270
  const uint8_t* first_byte_;   // for GetSpan
271
272
  // Number of bytes past the end that were loaded into the buf_. These bytes
273
  // are not read from memory, but instead assumed 0. It is an error (likely due
274
  // to an invalid stream) to Consume() more bits than specified in the range
275
  // passed to the constructor.
276
  uint64_t overread_bytes_{0};
277
  bool close_called_{false};
278
279
  uint64_t checked_out_of_bounds_bits_{0};
280
};
281
282
// Closes a BitReader when the BitReaderScopedCloser goes out of scope. When
283
// closing the bit reader, if the status result was failure it sets this failure
284
// to the passed variable pointer. Typical usage.
285
//
286
// Status ret = true;
287
// {
288
//   BitReader reader(...);
289
//   BitReaderScopedCloser reader_closer(&reader, &ret);
290
//
291
//   // ... code that can return errors here ...
292
// }
293
// // ... more code that doesn't use the BitReader.
294
// return ret;
295
296
class BitReaderScopedCloser {
297
 public:
298
  BitReaderScopedCloser(BitReader& reader, Status& status)
299
62
      : reader_(&reader), status_(&status) {}
300
62
  ~BitReaderScopedCloser() {
301
62
    if (reader_ != nullptr) {
302
62
      Status close_ret = reader_->Close();
303
62
      if (!close_ret) *status_ = close_ret;
304
62
    }
305
62
  }
306
  BitReaderScopedCloser(const BitReaderScopedCloser&) = delete;
307
308
 private:
309
  BitReader* reader_;
310
  Status* status_;
311
};
312
313
}  // namespace jxl
314
315
#endif  // LIB_JXL_DEC_BIT_READER_H_