Coverage Report

Created: 2025-11-14 07:32

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/libjxl/lib/jxl/enc_coeff_order.cc
Line
Count
Source
1
// Copyright (c) the JPEG XL Project Authors. All rights reserved.
2
//
3
// Use of this source code is governed by a BSD-style
4
// license that can be found in the LICENSE file.
5
6
#include <jxl/memory_manager.h>
7
8
#include <algorithm>
9
#include <cmath>
10
#include <cstddef>
11
#include <cstdint>
12
#include <cstring>
13
#include <limits>
14
#include <utility>
15
#include <vector>
16
17
#include "lib/jxl/ac_strategy.h"
18
#include "lib/jxl/base/compiler_specific.h"
19
#include "lib/jxl/base/rect.h"
20
#include "lib/jxl/base/status.h"
21
#include "lib/jxl/coeff_order.h"
22
#include "lib/jxl/coeff_order_fwd.h"
23
#include "lib/jxl/common.h"
24
#include "lib/jxl/dct_util.h"
25
#include "lib/jxl/enc_ans.h"
26
#include "lib/jxl/enc_ans_params.h"
27
#include "lib/jxl/enc_bit_writer.h"
28
#include "lib/jxl/frame_dimensions.h"
29
#include "lib/jxl/lehmer_code.h"
30
#include "lib/jxl/memory_manager_internal.h"
31
32
namespace jxl {
33
34
struct AuxOut;
35
enum class LayerType : uint8_t;
36
37
std::pair<uint32_t, uint32_t> ComputeUsedOrders(
38
    const SpeedTier speed, const AcStrategyImage& ac_strategy,
39
3.02k
    const Rect& rect) {
40
  // No coefficient reordering in Falcon or faster.
41
  // Only uses DCT8 = 0, so bitfield = 1.
42
3.02k
  if (speed >= SpeedTier::kFalcon) return {1, 1};
43
44
3.02k
  uint32_t ret = 0;
45
3.02k
  uint32_t ret_customize = 0;
46
3.02k
  size_t xsize_blocks = rect.xsize();
47
3.02k
  size_t ysize_blocks = rect.ysize();
48
  // TODO(veluca): precompute when doing DCT.
49
104k
  for (size_t by = 0; by < ysize_blocks; ++by) {
50
101k
    AcStrategyRow acs_row = ac_strategy.ConstRow(rect, by);
51
4.74M
    for (size_t bx = 0; bx < xsize_blocks; ++bx) {
52
4.64M
      int ord = kStrategyOrder[acs_row[bx].RawStrategy()];
53
      // Do not customize coefficient orders for blocks bigger than 32x32.
54
4.64M
      ret |= 1u << ord;
55
4.64M
      if (ord > 6) {
56
1.40M
        continue;
57
1.40M
      }
58
3.24M
      ret_customize |= 1u << ord;
59
3.24M
    }
60
101k
  }
61
  // Use default orders for small images.
62
3.02k
  if (ac_strategy.xsize() < 5 && ac_strategy.ysize() < 5) return {ret, 0};
63
2.67k
  return {ret, ret_customize};
64
3.02k
}
65
66
Status ComputeCoeffOrder(SpeedTier speed, const ACImage& ac_image,
67
                         const AcStrategyImage& ac_strategy,
68
                         const FrameDimensions& frame_dim,
69
                         uint32_t& all_used_orders, uint32_t prev_used_acs,
70
                         uint32_t current_used_acs,
71
                         uint32_t current_used_orders,
72
3.02k
                         coeff_order_t* JXL_RESTRICT order) {
73
3.02k
  JxlMemoryManager* memory_manager = ac_strategy.memory_manager();
74
3.02k
  std::vector<int64_t> num_zeros(kCoeffOrderMaxSize);
75
  // If compressing at high speed and only using 8x8 DCTs, only consider a
76
  // subset of blocks.
77
3.02k
  double block_fraction = 1.0f;
78
  // TODO(veluca): figure out why sampling blocks if non-8x8s are used makes
79
  // encoding significantly less dense.
80
3.02k
  if (speed >= SpeedTier::kSquirrel && current_used_orders == 1) {
81
7
    block_fraction = 0.5f;
82
7
  }
83
  // No need to compute number of zero coefficients if all orders are the
84
  // default.
85
3.02k
  if (current_used_orders != 0) {
86
2.64k
    uint64_t threshold =
87
2.64k
        (std::numeric_limits<uint64_t>::max() >> 32) * block_fraction;
88
2.64k
    uint64_t s[2] = {static_cast<uint64_t>(0x94D049BB133111EBull),
89
2.64k
                     static_cast<uint64_t>(0xBF58476D1CE4E5B9ull)};
90
    // Xorshift128+ adapted from xorshift128+-inl.h
91
2.13M
    auto use_sample = [&]() {
92
2.13M
      auto s1 = s[0];
93
2.13M
      const auto s0 = s[1];
94
2.13M
      const auto bits = s1 + s0;  // b, c
95
2.13M
      s[0] = s0;
96
2.13M
      s1 ^= s1 << 23;
97
2.13M
      s1 ^= s0 ^ (s1 >> 18) ^ (s0 >> 5);
98
2.13M
      s[1] = s1;
99
2.13M
      return (bits >> 32) <= threshold;
100
2.13M
    };
101
102
    // Count number of zero coefficients, separately for each DCT band.
103
    // TODO(veluca): precompute when doing DCT.
104
10.0k
    for (size_t group_index = 0; group_index < frame_dim.num_groups;
105
7.39k
         group_index++) {
106
7.39k
      const size_t gx = group_index % frame_dim.xsize_groups;
107
7.39k
      const size_t gy = group_index / frame_dim.xsize_groups;
108
7.39k
      const Rect rect(gx * kGroupDimInBlocks, gy * kGroupDimInBlocks,
109
7.39k
                      kGroupDimInBlocks, kGroupDimInBlocks,
110
7.39k
                      frame_dim.xsize_blocks, frame_dim.ysize_blocks);
111
7.39k
      ConstACPtr rows[3];
112
7.39k
      ACType type = ac_image.Type();
113
29.5k
      for (size_t c = 0; c < 3; c++) {
114
22.1k
        rows[c] = ac_image.PlaneRow(c, group_index, 0);
115
22.1k
      }
116
7.39k
      size_t ac_offset = 0;
117
118
      // TODO(veluca): SIMDfy.
119
188k
      for (size_t by = 0; by < rect.ysize(); ++by) {
120
181k
        AcStrategyRow acs_row = ac_strategy.ConstRow(rect, by);
121
4.77M
        for (size_t bx = 0; bx < rect.xsize(); ++bx) {
122
4.59M
          AcStrategy acs = acs_row[bx];
123
4.59M
          if (!acs.IsFirstBlock()) continue;
124
2.13M
          if (!use_sample()) continue;
125
2.13M
          size_t size = kDCTBlockSize << acs.log2_covered_blocks();
126
8.55M
          for (size_t c = 0; c < 3; ++c) {
127
6.41M
            const size_t order_offset =
128
6.41M
                CoeffOrderOffset(kStrategyOrder[acs.RawStrategy()], c);
129
6.41M
            if (type == ACType::k16) {
130
0
              for (size_t k = 0; k < size; k++) {
131
0
                bool is_zero = rows[c].ptr16[ac_offset + k] == 0;
132
0
                num_zeros[order_offset + k] += is_zero ? 1 : 0;
133
0
              }
134
6.41M
            } else {
135
888M
              for (size_t k = 0; k < size; k++) {
136
881M
                bool is_zero = rows[c].ptr32[ac_offset + k] == 0;
137
881M
                num_zeros[order_offset + k] += is_zero ? 1 : 0;
138
881M
              }
139
6.41M
            }
140
            // Ensure LLFs are first in the order.
141
6.41M
            size_t cx = acs.covered_blocks_x();
142
6.41M
            size_t cy = acs.covered_blocks_y();
143
6.41M
            CoefficientLayout(&cy, &cx);
144
13.8M
            for (size_t iy = 0; iy < cy; iy++) {
145
21.2M
              for (size_t ix = 0; ix < cx; ix++) {
146
13.7M
                num_zeros[order_offset + iy * kBlockDim * cx + ix] = -1;
147
13.7M
              }
148
7.44M
            }
149
6.41M
          }
150
2.13M
          ac_offset += size;
151
2.13M
        }
152
181k
      }
153
7.39k
    }
154
2.64k
  }
155
3.02k
  struct PosAndCount {
156
3.02k
    uint32_t pos;
157
    // Saving index breaks the ties for non-stable sort
158
3.02k
    uint64_t count_and_idx;
159
3.02k
  };
160
3.02k
  size_t mem_bytes = AcStrategy::kMaxCoeffArea * sizeof(PosAndCount);
161
3.02k
  JXL_ASSIGN_OR_RETURN(auto mem,
162
3.02k
                       AlignedMemory::Create(memory_manager, mem_bytes));
163
164
3.02k
  std::vector<coeff_order_t> natural_order_buffer;
165
166
3.02k
  uint16_t computed = 0;
167
84.5k
  for (uint8_t o = 0; o < AcStrategy::kNumValidStrategies; ++o) {
168
81.5k
    uint8_t ord = kStrategyOrder[o];
169
81.5k
    if (computed & (1 << ord)) continue;
170
39.2k
    computed |= 1 << ord;
171
39.2k
    AcStrategy acs = AcStrategy::FromRawStrategy(o);
172
39.2k
    size_t sz = kDCTBlockSize * acs.covered_blocks_x() * acs.covered_blocks_y();
173
    // Expected maximal size is 256 x 256.
174
39.2k
    JXL_DASSERT(sz <= (1 << 16));
175
176
    // Do nothing for transforms that don't appear.
177
39.2k
    if ((1 << ord) & ~current_used_acs) continue;
178
179
    // Do nothing if we already committed to this custom order previously.
180
11.5k
    if ((1 << ord) & prev_used_acs) continue;
181
11.5k
    if ((1 << ord) & all_used_orders) continue;
182
183
11.5k
    if (natural_order_buffer.size() < sz) natural_order_buffer.resize(sz);
184
11.5k
    acs.ComputeNaturalCoeffOrder(natural_order_buffer.data());
185
186
    // Ensure natural coefficient order is not permuted if the order is
187
    // not transmitted.
188
11.5k
    if ((1 << ord) & ~current_used_orders) {
189
6.74k
      for (size_t c = 0; c < 3; c++) {
190
5.05k
        size_t offset = CoeffOrderOffset(ord, c);
191
5.05k
        JXL_ENSURE(CoeffOrderOffset(ord, c + 1) - offset == sz);
192
5.05k
        memcpy(&order[offset], natural_order_buffer.data(),
193
5.05k
               sz * sizeof(*order));
194
5.05k
      }
195
1.68k
      continue;
196
1.68k
    }
197
198
9.84k
    bool is_nondefault = false;
199
39.3k
    for (uint8_t c = 0; c < 3; c++) {
200
      // Apply zig-zag order.
201
29.5k
      PosAndCount* pos_and_val = mem.address<PosAndCount>();
202
29.5k
      size_t offset = CoeffOrderOffset(ord, c);
203
29.5k
      JXL_ENSURE(CoeffOrderOffset(ord, c + 1) - offset == sz);
204
29.5k
      float inv_sqrt_sz = 1.0f / std::sqrt(sz);
205
8.33M
      for (size_t i = 0; i < sz; ++i) {
206
8.30M
        size_t pos = natural_order_buffer[i];
207
8.30M
        pos_and_val[i].pos = pos;
208
        // We don't care for the exact number -> quantize number of zeros,
209
        // to get less permuted order.
210
8.30M
        uint64_t count = num_zeros[offset + pos] * inv_sqrt_sz + 0.1f;
211
        // Worst case: all dct8x8, all zeroes: count <= nb_pixels/64/8
212
        // nb_pixels is limited to 2^40 (Level 10 limit)
213
        // so count is limited to 2^31
214
8.30M
        JXL_DASSERT(count < (uint64_t{1} << 48));
215
8.30M
        pos_and_val[i].count_and_idx = (count << 16) | i;
216
8.30M
      }
217
218
      // Stable-sort -> elements with same number of zeros will preserve their
219
      // order.
220
23.0M
      auto comparator = [](const PosAndCount& a, const PosAndCount& b) -> bool {
221
23.0M
        return a.count_and_idx < b.count_and_idx;
222
23.0M
      };
223
29.5k
      std::sort(pos_and_val, pos_and_val + sz, comparator);
224
225
      // Grab indices.
226
8.33M
      for (size_t i = 0; i < sz; ++i) {
227
8.30M
        order[offset + i] = pos_and_val[i].pos;
228
8.30M
        is_nondefault |= natural_order_buffer[i] != pos_and_val[i].pos;
229
8.30M
      }
230
29.5k
    }
231
9.84k
    if (!is_nondefault) {
232
5.64k
      current_used_orders &= ~(1 << ord);
233
5.64k
    }
234
9.84k
  }
235
3.02k
  all_used_orders |= current_used_orders;
236
3.02k
  return true;
237
3.02k
}
238
239
namespace {
240
241
Status TokenizePermutation(const coeff_order_t* JXL_RESTRICT order, size_t skip,
242
12.5k
                           size_t size, std::vector<Token>* tokens) {
243
12.5k
  std::vector<LehmerT> lehmer(size);
244
12.5k
  std::vector<uint32_t> temp(size + 1);
245
12.5k
  JXL_RETURN_IF_ERROR(
246
12.5k
      ComputeLehmerCode(order, temp.data(), size, lehmer.data()));
247
12.5k
  size_t end = size;
248
1.78M
  while (end > skip && lehmer[end - 1] == 0) {
249
1.77M
    --end;
250
1.77M
  }
251
12.5k
  tokens->emplace_back(CoeffOrderContext(size),
252
12.5k
                       static_cast<uint32_t>(end - skip));
253
12.5k
  uint32_t last = 0;
254
491k
  for (size_t i = skip; i < end; ++i) {
255
478k
    tokens->emplace_back(CoeffOrderContext(last), lehmer[i]);
256
478k
    last = lehmer[i];
257
478k
  }
258
12.5k
  return true;
259
12.5k
}
260
261
}  // namespace
262
263
Status EncodePermutation(const coeff_order_t* JXL_RESTRICT order, size_t skip,
264
                         size_t size, BitWriter* writer, LayerType layer,
265
0
                         AuxOut* aux_out) {
266
0
  JxlMemoryManager* memory_manager = writer->memory_manager();
267
0
  std::vector<std::vector<Token>> tokens(1);
268
0
  JXL_RETURN_IF_ERROR(TokenizePermutation(order, skip, size, tokens.data()));
269
0
  EntropyEncodingData codes;
270
0
  JXL_ASSIGN_OR_RETURN(
271
0
      size_t cost, BuildAndEncodeHistograms(memory_manager, HistogramParams(),
272
0
                                            kPermutationContexts, tokens,
273
0
                                            &codes, writer, layer, aux_out));
274
0
  (void)cost;
275
0
  JXL_RETURN_IF_ERROR(WriteTokens(tokens[0], codes, 0, writer, layer, aux_out));
276
0
  return true;
277
0
}
278
279
namespace {
280
Status EncodeCoeffOrder(const coeff_order_t* JXL_RESTRICT order, AcStrategy acs,
281
                        std::vector<Token>* tokens, coeff_order_t* order_zigzag,
282
12.5k
                        std::vector<coeff_order_t>& natural_order_lut) {
283
12.5k
  const size_t llf = acs.covered_blocks_x() * acs.covered_blocks_y();
284
12.5k
  const size_t size = kDCTBlockSize * llf;
285
2.30M
  for (size_t i = 0; i < size; ++i) {
286
2.29M
    order_zigzag[i] = natural_order_lut[order[i]];
287
2.29M
  }
288
12.5k
  JXL_RETURN_IF_ERROR(TokenizePermutation(order_zigzag, llf, size, tokens));
289
12.5k
  return true;
290
12.5k
}
291
}  // namespace
292
293
Status EncodeCoeffOrders(uint16_t used_orders,
294
                         const coeff_order_t* JXL_RESTRICT order,
295
                         BitWriter* writer, LayerType layer,
296
3.02k
                         AuxOut* JXL_RESTRICT aux_out) {
297
3.02k
  JxlMemoryManager* memory_manager = writer->memory_manager();
298
3.02k
  size_t mem_bytes = AcStrategy::kMaxCoeffArea * sizeof(coeff_order_t);
299
3.02k
  JXL_ASSIGN_OR_RETURN(auto mem,
300
3.02k
                       AlignedMemory::Create(memory_manager, mem_bytes));
301
3.02k
  uint16_t computed = 0;
302
3.02k
  std::vector<std::vector<Token>> tokens(1);
303
3.02k
  std::vector<coeff_order_t> natural_order_lut;
304
84.5k
  for (uint8_t o = 0; o < AcStrategy::kNumValidStrategies; ++o) {
305
81.5k
    uint8_t ord = kStrategyOrder[o];
306
81.5k
    if (computed & (1 << ord)) continue;
307
39.2k
    computed |= 1 << ord;
308
39.2k
    if ((used_orders & (1 << ord)) == 0) continue;
309
4.19k
    AcStrategy acs = AcStrategy::FromRawStrategy(o);
310
4.19k
    const size_t llf = acs.covered_blocks_x() * acs.covered_blocks_y();
311
4.19k
    const size_t size = kDCTBlockSize * llf;
312
4.19k
    if (natural_order_lut.size() < size) natural_order_lut.resize(size);
313
4.19k
    acs.ComputeNaturalCoeffOrderLut(natural_order_lut.data());
314
16.7k
    for (size_t c = 0; c < 3; c++) {
315
12.5k
      JXL_RETURN_IF_ERROR(
316
12.5k
          EncodeCoeffOrder(&order[CoeffOrderOffset(ord, c)], acs, tokens.data(),
317
12.5k
                           mem.address<coeff_order_t>(), natural_order_lut));
318
12.5k
    }
319
4.19k
  }
320
  // Do not write anything if no order is used.
321
3.02k
  if (used_orders != 0) {
322
1.71k
    EntropyEncodingData codes;
323
1.71k
    JXL_ASSIGN_OR_RETURN(
324
1.71k
        size_t cost, BuildAndEncodeHistograms(memory_manager, HistogramParams(),
325
1.71k
                                              kPermutationContexts, tokens,
326
1.71k
                                              &codes, writer, layer, aux_out));
327
1.71k
    (void)cost;
328
1.71k
    JXL_RETURN_IF_ERROR(
329
1.71k
        WriteTokens(tokens[0], codes, 0, writer, layer, aux_out));
330
1.71k
  }
331
3.02k
  return true;
332
3.02k
}
333
334
}  // namespace jxl