Coverage Report

Created: 2026-03-31 06:56

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/libjxl/lib/jxl/memory_manager_internal.cc
Line
Count
Source
1
// Copyright (c) the JPEG XL Project Authors. All rights reserved.
2
//
3
// Use of this source code is governed by a BSD-style
4
// license that can be found in the LICENSE file.
5
6
#include "lib/jxl/memory_manager_internal.h"
7
8
#include <jxl/memory_manager.h>
9
10
#include <algorithm>
11
#include <atomic>
12
#include <cstddef>
13
#include <cstdio>
14
#include <cstdlib>
15
#include <cstring>     // memcpy
16
#include <hwy/base.h>  // kMaxVectorSize
17
18
#include "lib/jxl/base/common.h"
19
#include "lib/jxl/base/status.h"
20
#include "lib/jxl/simd_util.h"
21
22
namespace jxl {
23
24
namespace {
25
26
0
void* MemoryManagerDefaultAlloc(void* opaque, size_t size) {
27
0
  return malloc(size);
28
0
}
29
30
0
void MemoryManagerDefaultFree(void* opaque, void* address) { free(address); }
31
32
}  // namespace
33
34
25.5k
void* MemoryManagerAlloc(const JxlMemoryManager* memory_manager, size_t size) {
35
25.5k
  return memory_manager->alloc(memory_manager->opaque, size);
36
25.5k
}
37
38
25.5k
void MemoryManagerFree(const JxlMemoryManager* memory_manager, void* address) {
39
25.5k
  memory_manager->free(memory_manager->opaque, address);
40
25.5k
}
41
42
Status MemoryManagerInit(JxlMemoryManager* self,
43
25.5k
                         const JxlMemoryManager* memory_manager) {
44
25.5k
  if (memory_manager) {
45
25.5k
    *self = *memory_manager;
46
25.5k
  } else {
47
0
    memset(self, 0, sizeof(*self));
48
0
  }
49
25.5k
  bool is_default_alloc = (self->alloc == nullptr);
50
25.5k
  bool is_default_free = (self->free == nullptr);
51
25.5k
  if (is_default_alloc != is_default_free) {
52
0
    return false;
53
0
  }
54
25.5k
  if (is_default_alloc) self->alloc = jxl::MemoryManagerDefaultAlloc;
55
25.5k
  if (is_default_free) self->free = jxl::MemoryManagerDefaultFree;
56
57
25.5k
  return true;
58
25.5k
}
59
60
27.0M
size_t BytesPerRow(const size_t xsize, const size_t sizeof_t) {
61
  // Special case: we don't allow any ops -> don't need extra padding/
62
27.0M
  if (xsize == 0) {
63
206k
    return 0;
64
206k
  }
65
66
26.8M
  const size_t vec_size = MaxVectorSize();
67
26.8M
  size_t valid_bytes = xsize * sizeof_t;
68
69
  // Allow unaligned accesses starting at the last valid value.
70
  // Skip for the scalar case because no extra lanes will be loaded.
71
26.8M
  if (vec_size != 0) {
72
26.8M
    valid_bytes += vec_size - sizeof_t;
73
26.8M
  }
74
75
  // Round up to vector and cache line size.
76
26.8M
  const size_t align = std::max(vec_size, memory_manager_internal::kAlignment);
77
26.8M
  size_t bytes_per_row = RoundUpTo(valid_bytes, align);
78
79
  // During the lengthy window before writes are committed to memory, CPUs
80
  // guard against read after write hazards by checking the address, but
81
  // only the lower 11 bits. We avoid a false dependency between writes to
82
  // consecutive rows by ensuring their sizes are not multiples of 2 KiB.
83
  // Avoid2K prevents the same problem for the planes of an Image3.
84
26.8M
  if (bytes_per_row % memory_manager_internal::kAlias == 0) {
85
101k
    bytes_per_row += align;
86
101k
  }
87
88
26.8M
  JXL_DASSERT(bytes_per_row % align == 0);
89
26.8M
  return bytes_per_row;
90
27.0M
}
91
92
StatusOr<AlignedMemory> AlignedMemory::Create(JxlMemoryManager* memory_manager,
93
27.4M
                                              size_t size, size_t pre_padding) {
94
27.4M
  JXL_ENSURE(pre_padding <= memory_manager_internal::kAlias);
95
27.4M
  size_t allocation_size;
96
27.4M
  if (!SafeAdd<size_t>(size, pre_padding, allocation_size) ||
97
27.4M
      !SafeAdd(allocation_size, memory_manager_internal::kAlias,
98
27.4M
               allocation_size)) {
99
0
    return JXL_FAILURE("Requested allocation is too large");
100
0
  }
101
27.4M
  JXL_ENSURE(memory_manager);
102
27.4M
  void* allocated =
103
27.4M
      memory_manager->alloc(memory_manager->opaque, allocation_size);
104
27.4M
  if (allocated == nullptr) {
105
8
    return JXL_FAILURE("Allocation failed");
106
8
  }
107
27.4M
  return AlignedMemory(memory_manager, allocated, pre_padding);
108
27.4M
}
109
110
AlignedMemory::AlignedMemory(JxlMemoryManager* memory_manager, void* allocation,
111
                             size_t pre_padding)
112
27.4M
    : allocation_(allocation), memory_manager_(memory_manager) {
113
  // Congruence to `offset` (mod kAlias) reduces cache conflicts and load/store
114
  // stalls, especially with large allocations that would otherwise have similar
115
  // alignments.
116
27.4M
  static std::atomic<uint32_t> next_group{0};
117
27.4M
  size_t group =
118
27.4M
      static_cast<size_t>(next_group.fetch_add(1, std::memory_order_relaxed));
119
27.4M
  group &= (memory_manager_internal::kNumAlignmentGroups - 1);
120
27.4M
  size_t offset = memory_manager_internal::kAlignment * group;
121
122
  // Actual allocation.
123
27.4M
  uintptr_t address = reinterpret_cast<uintptr_t>(allocation) + pre_padding;
124
125
  // Aligned address, but might land before allocation (50%/50%) or not have
126
  // enough pre-padding.
127
27.4M
  uintptr_t aligned_address =
128
27.4M
      (address & ~(memory_manager_internal::kAlias - 1)) + offset;
129
27.4M
  if (aligned_address < address)
130
12.9M
    aligned_address += memory_manager_internal::kAlias;
131
132
27.4M
  address_ = reinterpret_cast<void*>(aligned_address);  // NOLINT
133
27.4M
}
134
135
112M
AlignedMemory::AlignedMemory(AlignedMemory&& other) noexcept {
136
112M
  allocation_ = other.allocation_;
137
112M
  memory_manager_ = other.memory_manager_;
138
112M
  address_ = other.address_;
139
112M
  other.memory_manager_ = nullptr;
140
112M
}
141
142
37.8M
AlignedMemory& AlignedMemory::operator=(AlignedMemory&& other) noexcept {
143
37.8M
  if (this == &other) return *this;
144
37.8M
  if (memory_manager_ && allocation_) {
145
1.33M
    memory_manager_->free(memory_manager_->opaque, allocation_);
146
1.33M
  }
147
37.8M
  allocation_ = other.allocation_;
148
37.8M
  memory_manager_ = other.memory_manager_;
149
37.8M
  address_ = other.address_;
150
37.8M
  other.memory_manager_ = nullptr;
151
37.8M
  return *this;
152
37.8M
}
153
154
174M
AlignedMemory::~AlignedMemory() {
155
174M
  if (memory_manager_ == nullptr) return;
156
26.1M
  memory_manager_->free(memory_manager_->opaque, allocation_);
157
26.1M
}
158
159
}  // namespace jxl