Coverage Report

Created: 2026-05-16 07:22

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/libjxl/lib/jxl/icc_codec.cc
Line
Count
Source
1
// Copyright (c) the JPEG XL Project Authors. All rights reserved.
2
//
3
// Use of this source code is governed by a BSD-style
4
// license that can be found in the LICENSE file.
5
6
#include "lib/jxl/icc_codec.h"
7
8
#include <jxl/memory_manager.h>
9
10
#include <algorithm>
11
#include <cstddef>
12
#include <cstdint>
13
14
#include "lib/jxl/base/common.h"
15
#include "lib/jxl/base/status.h"
16
#include "lib/jxl/dec_ans.h"
17
#include "lib/jxl/dec_bit_reader.h"
18
#include "lib/jxl/fields.h"
19
#include "lib/jxl/icc_codec_common.h"
20
#include "lib/jxl/padded_bytes.h"
21
22
namespace jxl {
23
namespace {
24
25
// Shuffles or interleaves bytes, for example with width 2, turns "ABCDabcd"
26
// into "AaBbCcDd". Transposes a matrix of ceil(size / width) columns and
27
// width rows. There are size elements, size may be < width * height, if so the
28
// last elements of the rightmost column are missing, the missing spots are
29
// transposed along with the filled spots, and the result has the missing
30
// elements at the end of the bottom row. The input is the input matrix in
31
// scanline order but with missing elements skipped (which may occur in multiple
32
// locations), the output is the result matrix in scanline order (with
33
// no need to skip missing elements as they are past the end of the data).
34
Status Shuffle(JxlMemoryManager* memory_manager, uint8_t* data, size_t size,
35
4.94k
               size_t width) {
36
4.94k
  size_t height = (size + width - 1) / width;  // amount of rows of output
37
4.94k
  PaddedBytes result(memory_manager);
38
4.94k
  JXL_ASSIGN_OR_RETURN(result,
39
4.94k
                       PaddedBytes::WithInitialSpace(memory_manager, size));
40
  // i = output index, j input index
41
4.94k
  size_t s = 0;
42
4.94k
  size_t j = 0;
43
70.7k
  for (size_t i = 0; i < size; i++) {
44
65.8k
    result[i] = data[j];
45
65.8k
    j += height;
46
65.8k
    if (j >= size) j = ++s;
47
65.8k
  }
48
49
70.7k
  for (size_t i = 0; i < size; i++) {
50
65.8k
    data[i] = result[i];
51
65.8k
  }
52
4.94k
  return true;
53
4.94k
}
54
55
// TODO(eustas): should be 20, or even 18, once DecodeVarInt is improved;
56
//               currently DecodeVarInt does not signal the errors, and marks
57
//               11 bytes as used even if only 10 are used (and 9 is enough for
58
//               63-bit values).
59
constexpr const size_t kPreambleSize = 22;  // enough for reading 2 VarInts
60
61
18.9k
uint64_t DecodeVarInt(const uint8_t* input, size_t inputSize, size_t* pos) {
62
18.9k
  size_t i;
63
18.9k
  uint64_t ret = 0;
64
24.8k
  for (i = 0; *pos + i < inputSize && i < 10; ++i) {
65
24.7k
    ret |= static_cast<uint64_t>(input[*pos + i] & 127)
66
24.7k
           << static_cast<uint64_t>(7 * i);
67
    // If the next-byte flag is not set, stop
68
24.7k
    if ((input[*pos + i] & 128) == 0) break;
69
24.7k
  }
70
  // TODO(user): Return a decoding error if i == 10.
71
18.9k
  *pos += i + 1;
72
18.9k
  return ret;
73
18.9k
}
74
75
}  // namespace
76
77
// Mimics the beginning of UnpredictICC for quick validity check.
78
// At least kPreambleSize bytes of data should be valid at invocation time.
79
1.08k
Status CheckPreamble(const PaddedBytes& data, size_t enc_size) {
80
1.08k
  const uint8_t* enc = data.data();
81
1.08k
  size_t size = data.size();
82
1.08k
  size_t pos = 0;
83
1.08k
  uint64_t osize = DecodeVarInt(enc, size, &pos);
84
1.08k
  JXL_RETURN_IF_ERROR(CheckIs32Bit(osize));
85
1.06k
  if (pos >= size) return JXL_FAILURE("Out of bounds");
86
1.06k
  uint64_t csize = DecodeVarInt(enc, size, &pos);
87
1.06k
  JXL_RETURN_IF_ERROR(CheckIs32Bit(csize));
88
1.06k
  JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, csize, size));
89
  // We expect that UnpredictICC inflates input, not the other way round.
90
1.04k
  if (osize + 65536 < enc_size) return JXL_FAILURE("Malformed ICC");
91
92
  // NB(eustas): 64 MiB ICC should be enough for everything!?
93
1.02k
  const size_t output_limit = 1 << 28;
94
1.02k
  if (output_limit && osize > output_limit) {
95
4
    return JXL_FAILURE("Decoded ICC is too large");
96
4
  }
97
1.01k
  return true;
98
1.02k
}
99
100
// Decodes the result of PredictICC back to a valid ICC profile.
101
870
Status UnpredictICC(const uint8_t* enc, size_t size, PaddedBytes* result) {
102
870
  if (!result->empty()) return JXL_FAILURE("result must be empty initially");
103
870
  JxlMemoryManager* memory_manager = result->memory_manager();
104
870
  size_t pos = 0;
105
  // TODO(lode): technically speaking we need to check that the entire varint
106
  // decoding never goes out of bounds, not just the first byte. This requires
107
  // a DecodeVarInt function that returns an error code. It is safe to use
108
  // DecodeVarInt with out of bounds values, it silently returns, but the
109
  // specification requires an error. Idem for all DecodeVarInt below.
110
870
  if (pos >= size) return JXL_FAILURE("Out of bounds");
111
858
  uint64_t osize = DecodeVarInt(enc, size, &pos);  // Output size
112
858
  JXL_RETURN_IF_ERROR(CheckIs32Bit(osize));
113
849
  if (pos >= size) return JXL_FAILURE("Out of bounds");
114
845
  uint64_t csize = DecodeVarInt(enc, size, &pos);  // Commands size
115
  // Every command is translated to at least on byte.
116
845
  JXL_RETURN_IF_ERROR(CheckIs32Bit(csize));
117
839
  size_t cpos = pos;  // pos in commands stream
118
839
  JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, csize, size));
119
823
  size_t commands_end = cpos + csize;
120
823
  pos = commands_end;  // pos in data stream
121
122
  // Header
123
823
  PaddedBytes header{memory_manager};
124
823
  JXL_RETURN_IF_ERROR(header.append(ICCInitialHeaderPrediction(osize)));
125
80.4k
  for (size_t i = 0; i <= kICCHeaderSize; i++) {
126
80.4k
    if (result->size() == osize) {
127
205
      if (cpos != commands_end) return JXL_FAILURE("Not all commands used");
128
141
      if (pos != size) return JXL_FAILURE("Not all data used");
129
19
      return true;  // Valid end
130
141
    }
131
80.2k
    if (i == kICCHeaderSize) break;  // Done
132
79.6k
    ICCPredictHeader(result->data(), result->size(), header.data(), i);
133
79.6k
    if (pos >= size) return JXL_FAILURE("Out of bounds");
134
79.6k
    JXL_RETURN_IF_ERROR(result->push_back(enc[pos++] + header[i]));
135
79.6k
  }
136
605
  if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
137
138
  // Tag list
139
601
  uint64_t numtags = DecodeVarInt(enc, size, &cpos);
140
141
601
  if (numtags != 0) {
142
419
    numtags--;
143
419
    JXL_RETURN_IF_ERROR(CheckIs32Bit(numtags));
144
409
    JXL_RETURN_IF_ERROR(AppendUint32(numtags, result));
145
409
    uint64_t prevtagstart = kICCHeaderSize + numtags * 12;
146
409
    uint64_t prevtagsize = 0;
147
12.2k
    for (;;) {
148
12.2k
      if (result->size() > osize) return JXL_FAILURE("Invalid result size");
149
12.2k
      if (cpos > commands_end) return JXL_FAILURE("Out of bounds");
150
12.2k
      if (cpos == commands_end) break;  // Valid end
151
12.1k
      uint8_t command = enc[cpos++];
152
12.1k
      uint8_t tagcode = command & 63;
153
12.1k
      Tag tag;
154
12.1k
      if (tagcode == 0) {
155
225
        break;
156
11.9k
      } else if (tagcode == kCommandTagUnknown) {
157
1.07k
        JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, 4, size));
158
1.07k
        tag = DecodeKeyword(enc, size, pos);
159
1.07k
        pos += 4;
160
10.8k
      } else if (tagcode == kCommandTagTRC) {
161
1.84k
        tag = kRtrcTag;
162
9.04k
      } else if (tagcode == kCommandTagXYZ) {
163
982
        tag = kRxyzTag;
164
8.06k
      } else {
165
8.06k
        if (tagcode - kCommandTagStringFirst >= kNumTagStrings) {
166
23
          return JXL_FAILURE("Unknown tagcode");
167
23
        }
168
8.04k
        tag = *kTagStrings[tagcode - kCommandTagStringFirst];
169
8.04k
      }
170
11.9k
      JXL_RETURN_IF_ERROR(AppendKeyword(tag, result));
171
172
11.9k
      uint64_t tagstart;
173
11.9k
      uint64_t tagsize = prevtagsize;
174
11.9k
      if (tag == kRxyzTag || tag == kGxyzTag || tag == kBxyzTag ||
175
8.46k
          tag == kKxyzTag || tag == kWtptTag || tag == kBkptTag ||
176
6.61k
          tag == kLumiTag) {
177
6.61k
        tagsize = 20;
178
6.61k
      }
179
180
11.9k
      if (command & kFlagBitOffset) {
181
2.16k
        if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
182
2.14k
        tagstart = DecodeVarInt(enc, size, &cpos);
183
9.78k
      } else {
184
9.78k
        JXL_RETURN_IF_ERROR(CheckIs32Bit(prevtagstart));
185
9.77k
        tagstart = prevtagstart + prevtagsize;
186
9.77k
      }
187
11.9k
      JXL_RETURN_IF_ERROR(CheckIs32Bit(tagstart));
188
11.9k
      JXL_RETURN_IF_ERROR(AppendUint32(tagstart, result));
189
11.9k
      if (command & kFlagBitSize) {
190
2.85k
        if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
191
2.83k
        tagsize = DecodeVarInt(enc, size, &cpos);
192
2.83k
      }
193
11.8k
      JXL_RETURN_IF_ERROR(CheckIs32Bit(tagsize));
194
11.8k
      JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
195
11.8k
      prevtagstart = tagstart;
196
11.8k
      prevtagsize = tagsize;
197
198
11.8k
      if (tagcode == kCommandTagTRC) {
199
1.84k
        JXL_RETURN_IF_ERROR(AppendKeyword(kGtrcTag, result));
200
1.84k
        JXL_RETURN_IF_ERROR(AppendUint32(tagstart, result));
201
1.84k
        JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
202
1.84k
        JXL_RETURN_IF_ERROR(AppendKeyword(kBtrcTag, result));
203
1.84k
        JXL_RETURN_IF_ERROR(AppendUint32(tagstart, result));
204
1.84k
        JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
205
1.84k
      }
206
207
11.8k
      if (tagcode == kCommandTagXYZ) {
208
979
        JXL_RETURN_IF_ERROR(CheckIs32Bit(tagstart + tagsize * 2));
209
977
        JXL_RETURN_IF_ERROR(AppendKeyword(kGxyzTag, result));
210
977
        JXL_RETURN_IF_ERROR(AppendUint32(tagstart + tagsize, result));
211
977
        JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
212
977
        JXL_RETURN_IF_ERROR(AppendKeyword(kBxyzTag, result));
213
977
        JXL_RETURN_IF_ERROR(AppendUint32(tagstart + tagsize * 2, result));
214
977
        JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
215
977
      }
216
11.8k
    }
217
409
  }
218
219
  // Main Content
220
11.7k
  for (;;) {
221
11.7k
    if (result->size() > osize) return JXL_FAILURE("Invalid result size");
222
11.7k
    if (cpos > commands_end) return JXL_FAILURE("Out of bounds");
223
11.7k
    if (cpos == commands_end) break;  // Valid end
224
11.6k
    uint8_t command = enc[cpos++];
225
11.6k
    if (command == kCommandInsert) {
226
1.75k
      if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
227
1.74k
      uint64_t num = DecodeVarInt(enc, size, &cpos);
228
1.74k
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, num, size));
229
11.7k
      for (size_t i = 0; i < num; i++) {
230
9.99k
        JXL_RETURN_IF_ERROR(result->push_back(enc[pos++]));
231
9.99k
      }
232
9.85k
    } else if (command == kCommandShuffle2 || command == kCommandShuffle4) {
233
3.05k
      if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
234
3.03k
      uint64_t num = DecodeVarInt(enc, size, &cpos);
235
3.03k
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, num, size));
236
3.01k
      PaddedBytes shuffled(memory_manager);
237
3.01k
      JXL_ASSIGN_OR_RETURN(shuffled,
238
3.01k
                           PaddedBytes::WithInitialSpace(memory_manager, num));
239
24.5k
      for (size_t i = 0; i < num; i++) {
240
21.5k
        shuffled[i] = enc[pos + i];
241
21.5k
      }
242
3.01k
      if (command == kCommandShuffle2) {
243
1.84k
        JXL_RETURN_IF_ERROR(Shuffle(memory_manager, shuffled.data(), num, 2));
244
1.84k
      } else if (command == kCommandShuffle4) {
245
1.16k
        JXL_RETURN_IF_ERROR(Shuffle(memory_manager, shuffled.data(), num, 4));
246
1.16k
      }
247
24.5k
      for (size_t i = 0; i < num; i++) {
248
21.5k
        JXL_RETURN_IF_ERROR(result->push_back(shuffled[i]));
249
21.5k
        pos++;
250
21.5k
      }
251
6.80k
    } else if (command == kCommandPredict) {
252
3.80k
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(cpos, 2, commands_end));
253
3.78k
      uint8_t flags = enc[cpos++];
254
255
3.78k
      size_t width = (flags & 3) + 1;
256
3.78k
      if (width == 3) return JXL_FAILURE("Invalid width");
257
258
3.78k
      int order = (flags & 12) >> 2;
259
3.78k
      if (order == 3) return JXL_FAILURE("Invalid order");
260
261
3.77k
      uint64_t stride = width;
262
3.77k
      if (flags & 16) {
263
969
        if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
264
969
        stride = DecodeVarInt(enc, size, &cpos);
265
969
        if (stride < width) {
266
2
          return JXL_FAILURE("Invalid stride");
267
2
        }
268
969
      }
269
      // If stride * 4 >= result->size(), return failure. The check
270
      // "size == 0 || ((size - 1) >> 2) < stride" corresponds to
271
      // "stride * 4 >= size", but does not suffer from integer overflow.
272
      // This check is more strict than necessary but follows the specification
273
      // and the encoder should ensure this is followed.
274
3.77k
      if (result->empty() || ((result->size() - 1u) >> 2u) < stride) {
275
53
        return JXL_FAILURE("Invalid stride");
276
53
      }
277
278
3.72k
      if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
279
3.71k
      uint64_t num = DecodeVarInt(enc, size, &cpos);  // in bytes
280
3.71k
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, num, size));
281
282
3.69k
      PaddedBytes shuffled(memory_manager);
283
3.69k
      JXL_ASSIGN_OR_RETURN(shuffled,
284
3.69k
                           PaddedBytes::WithInitialSpace(memory_manager, num));
285
286
65.1k
      for (size_t i = 0; i < num; i++) {
287
61.4k
        shuffled[i] = enc[pos + i];
288
61.4k
      }
289
3.69k
      if (width > 1) {
290
1.93k
        JXL_RETURN_IF_ERROR(
291
1.93k
            Shuffle(memory_manager, shuffled.data(), num, width));
292
1.93k
      }
293
294
3.69k
      size_t start = result->size();
295
65.1k
      for (size_t i = 0; i < num; i++) {
296
61.4k
        uint8_t predicted = LinearPredictICCValue(result->data(), start, i,
297
61.4k
                                                  stride, width, order);
298
61.4k
        JXL_RETURN_IF_ERROR(result->push_back(predicted + shuffled[i]));
299
61.4k
      }
300
3.69k
      pos += num;
301
3.69k
    } else if (command == kCommandXYZ) {
302
469
      JXL_RETURN_IF_ERROR(AppendKeyword(kXyz_Tag, result));
303
2.34k
      for (int i = 0; i < 4; i++) {
304
1.87k
        JXL_RETURN_IF_ERROR(result->push_back(0));
305
1.87k
      }
306
469
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, 12, size));
307
5.98k
      for (size_t i = 0; i < 12; i++) {
308
5.52k
        JXL_RETURN_IF_ERROR(result->push_back(enc[pos++]));
309
5.52k
      }
310
2.52k
    } else if (command >= kCommandTypeStartFirst &&
311
2.46k
               command < kCommandTypeStartFirst + kNumTypeStrings) {
312
2.37k
      JXL_RETURN_IF_ERROR(AppendKeyword(
313
2.37k
          *kTypeStrings[command - kCommandTypeStartFirst], result));
314
11.8k
      for (size_t i = 0; i < 4; i++) {
315
9.48k
        JXL_RETURN_IF_ERROR(result->push_back(0));
316
9.48k
      }
317
2.37k
    } else {
318
158
      return JXL_FAILURE("Unknown command");
319
158
    }
320
11.6k
  }
321
322
133
  if (pos != size) return JXL_FAILURE("Not all data used");
323
19
  if (result->size() != osize) return JXL_FAILURE("Invalid result size");
324
325
18
  return true;
326
19
}
327
328
2.86k
Status ICCReader::Init(BitReader* reader) {
329
2.86k
  JXL_RETURN_IF_ERROR(CheckEOI(reader));
330
2.86k
  JxlMemoryManager* memory_manager = decompressed_.memory_manager();
331
2.86k
  used_bits_base_ = reader->TotalBitsConsumed();
332
2.86k
  if (bits_to_skip_ == 0) {
333
2.42k
    enc_size_ = U64Coder::Read(reader);
334
2.42k
    if (enc_size_ > 268435456) {
335
      // Avoid too large memory allocation for invalid file.
336
55
      return JXL_FAILURE("Too large encoded profile");
337
55
    }
338
2.36k
    JXL_RETURN_IF_ERROR(DecodeHistograms(
339
2.36k
        memory_manager, reader, kNumICCContexts, &code_, &context_map_));
340
3.70k
    JXL_ASSIGN_OR_RETURN(ans_reader_, ANSSymbolReader::Create(&code_, reader));
341
3.70k
    i_ = 0;
342
3.70k
    JXL_RETURN_IF_ERROR(
343
3.70k
        decompressed_.resize(std::min<size_t>(i_ + 0x400, enc_size_)));
344
5.27k
    for (; i_ < std::min<size_t>(2, enc_size_); i_++) {
345
3.42k
      decompressed_[i_] = ans_reader_.ReadHybridUint(
346
3.42k
          ICCANSContext(i_, i_ > 0 ? decompressed_[i_ - 1] : 0,
347
3.42k
                        i_ > 1 ? decompressed_[i_ - 2] : 0),
348
3.42k
          reader, context_map_);
349
3.42k
    }
350
1.85k
    if (enc_size_ > kPreambleSize) {
351
32.6k
      for (; i_ < kPreambleSize; i_++) {
352
31.0k
        decompressed_[i_] = ans_reader_.ReadHybridUint(
353
31.0k
            ICCANSContext(i_, decompressed_[i_ - 1], decompressed_[i_ - 2]),
354
31.0k
            reader, context_map_);
355
31.0k
      }
356
1.55k
      JXL_RETURN_IF_ERROR(CheckEOI(reader));
357
1.08k
      JXL_RETURN_IF_ERROR(CheckPreamble(decompressed_, enc_size_));
358
1.08k
    }
359
1.31k
    bits_to_skip_ = reader->TotalBitsConsumed() - used_bits_base_;
360
1.31k
  } else {
361
441
    reader->SkipBits(bits_to_skip_);
362
441
  }
363
1.75k
  return true;
364
2.86k
}
365
366
1.36k
Status ICCReader::Process(BitReader* reader, PaddedBytes* icc) {
367
1.36k
  auto checkpoint = jxl::make_unique<ANSSymbolReader::Checkpoint>();
368
1.36k
  size_t saved_i = 0;
369
11.1k
  auto save = [&]() {
370
11.1k
    ans_reader_.Save(checkpoint.get());
371
11.1k
    bits_to_skip_ = reader->TotalBitsConsumed() - used_bits_base_;
372
11.1k
    saved_i = i_;
373
11.1k
  };
374
1.36k
  save();
375
11.1k
  auto check_and_restore = [&]() -> Status {
376
11.1k
    Status status = CheckEOI(reader);
377
11.1k
    if (!status) {
378
      // not enough bytes.
379
484
      ans_reader_.Restore(*checkpoint);
380
484
      i_ = saved_i;
381
484
      return status;
382
484
    }
383
10.6k
    return true;
384
11.1k
  };
385
5.40M
  for (; i_ < enc_size_; i_++) {
386
5.39M
    if (i_ % ANSSymbolReader::kMaxCheckpointInterval == 0 && i_ > 0) {
387
10.1k
      JXL_RETURN_IF_ERROR(check_and_restore());
388
9.80k
      save();
389
9.80k
      if ((i_ > 0) && (((i_ & 0xFFFF) == 0))) {
390
51
        float used_bytes =
391
51
            (reader->TotalBitsConsumed() - used_bits_base_) / 8.0f;
392
51
        if (i_ > used_bytes * 256) return JXL_FAILURE("Corrupted stream");
393
51
      }
394
9.80k
      JXL_RETURN_IF_ERROR(
395
9.80k
          decompressed_.resize(std::min<size_t>(i_ + 0x400, enc_size_)));
396
9.80k
    }
397
5.39M
    JXL_ENSURE(i_ >= 2);
398
5.39M
    decompressed_[i_] = ans_reader_.ReadHybridUint(
399
5.39M
        ICCANSContext(i_, decompressed_[i_ - 1], decompressed_[i_ - 2]), reader,
400
5.39M
        context_map_);
401
5.39M
  }
402
1.04k
  JXL_RETURN_IF_ERROR(check_and_restore());
403
870
  bits_to_skip_ = reader->TotalBitsConsumed() - used_bits_base_;
404
870
  if (!ans_reader_.CheckANSFinalState()) {
405
0
    return JXL_FAILURE("Corrupted ICC profile");
406
0
  }
407
408
870
  icc->clear();
409
870
  return UnpredictICC(decompressed_.data(), decompressed_.size(), icc);
410
870
}
411
412
15.5k
Status ICCReader::CheckEOI(BitReader* reader) {
413
15.5k
  if (reader->AllReadsWithinBounds()) return true;
414
948
  return JXL_NOT_ENOUGH_BYTES("Not enough bytes for reading ICC profile");
415
15.5k
}
416
417
}  // namespace jxl