Coverage Report

Created: 2026-06-07 07:20

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/libjxl/lib/jxl/dec_bit_reader.h
Line
Count
Source
1
// Copyright (c) the JPEG XL Project Authors. All rights reserved.
2
//
3
// Use of this source code is governed by a BSD-style
4
// license that can be found in the LICENSE file.
5
6
#ifndef LIB_JXL_DEC_BIT_READER_H_
7
#define LIB_JXL_DEC_BIT_READER_H_
8
9
// Bounds-checked bit reader; 64-bit buffer with support for deferred refills
10
// and switching to reading byte-aligned words.
11
12
#include <cstddef>
13
#include <cstdint>
14
#include <cstring>  // memcpy
15
16
#ifdef __BMI2__
17
#include <immintrin.h>
18
#endif
19
20
#include "lib/jxl/base/byte_order.h"
21
#include "lib/jxl/base/common.h"
22
#include "lib/jxl/base/compiler_specific.h"
23
#include "lib/jxl/base/status.h"
24
25
namespace jxl {
26
27
// Reads bits previously written to memory by BitWriter. Uses unaligned 8-byte
28
// little-endian loads.
29
class BitReader {
30
 public:
31
  static constexpr size_t kMaxBitsPerCall = 56;
32
33
  // Constructs an invalid BitReader, to be overwritten before usage.
34
  BitReader()
35
      : buf_(0),
36
        bits_in_buf_(0),
37
        next_byte_{nullptr},
38
        end_minus_8_{nullptr},
39
0
        first_byte_(nullptr) {}
40
  BitReader(const BitReader&) = delete;
41
42
  // bytes need not be aligned nor padded!
43
  template <class ArrayLike>
44
  explicit BitReader(const ArrayLike& bytes)
45
229k
      : buf_(0),
46
229k
        bits_in_buf_(0),
47
229k
        next_byte_(bytes.data()),
48
        // Assumes first_byte_ >= 8.
49
229k
        end_minus_8_(bytes.data() - 8 + bytes.size()),
50
229k
        first_byte_(bytes.data()) {
51
229k
    Refill();
52
229k
  }
53
229k
  ~BitReader() {
54
    // Close() must be called before destroying an initialized bit reader.
55
    // Invalid bit readers will have a nullptr in first_byte_.
56
229k
    JXL_DASSERT(close_called_ || !first_byte_);
57
229k
  }
58
59
  // Move operator needs to invalidate the other BitReader such that it is
60
  // irrelevant if we call Close() on it or not.
61
0
  BitReader& operator=(BitReader&& other) noexcept {
62
0
    // Ensure the current instance was already closed, before we overwrite it
63
0
    // with other.
64
0
    JXL_DASSERT(close_called_ || !first_byte_);
65
0
66
0
    JXL_DASSERT(!other.close_called_);
67
0
    buf_ = other.buf_;
68
0
    bits_in_buf_ = other.bits_in_buf_;
69
0
    next_byte_ = other.next_byte_;
70
0
    end_minus_8_ = other.end_minus_8_;
71
0
    first_byte_ = other.first_byte_;
72
0
    overread_bytes_ = other.overread_bytes_;
73
0
    close_called_ = other.close_called_;
74
0
75
0
    other.first_byte_ = nullptr;
76
0
    other.next_byte_ = nullptr;
77
0
    return *this;
78
0
  }
79
  BitReader& operator=(const BitReader& other) = delete;
80
81
  // For time-critical reads, refills can be shared by multiple reads.
82
  // Based on variant 4 (plus bounds-checking), see
83
  // fgiesen.wordpress.com/2018/02/20/reading-bits-in-far-too-many-ways-part-2/
84
474M
  JXL_INLINE void Refill() {
85
474M
    if (JXL_UNLIKELY(next_byte_ > end_minus_8_)) {
86
369M
      BoundsCheckedRefill();
87
369M
    } else {
88
      // It's safe to load 64 bits; insert valid (possibly nonzero) bits above
89
      // bits_in_buf_. The shift requires bits_in_buf_ < 64.
90
104M
      buf_ |= LoadLE64(next_byte_) << bits_in_buf_;
91
92
      // Advance by bytes fully absorbed into the buffer.
93
104M
      next_byte_ += (63 - bits_in_buf_) >> 3;
94
95
      // We absorbed a multiple of 8 bits, so the lower 3 bits of bits_in_buf_
96
      // must remain unchanged, otherwise the next refill's shifted bits will
97
      // not align with buf_. Set the three upper bits so the result >= 56.
98
104M
      bits_in_buf_ |= 56;
99
104M
      JXL_DASSERT(56 <= bits_in_buf_ && bits_in_buf_ < 64);
100
104M
    }
101
474M
  }
102
103
  // Returns the bits that would be returned by Read without calling Advance().
104
  // It is legal to PEEK at more bits than present in the bitstream (required
105
  // by Huffman), and those bits will be zero.
106
  template <size_t N>
107
231M
  JXL_INLINE uint64_t PeekFixedBits() const {
108
231M
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
231M
    JXL_DASSERT(!close_called_);
110
231M
    return buf_ & ((1ULL << N) - 1);
111
231M
  }
unsigned long jxl::BitReader::PeekFixedBits<16ul>() const
Line
Count
Source
107
225M
  JXL_INLINE uint64_t PeekFixedBits() const {
108
225M
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
225M
    JXL_DASSERT(!close_called_);
110
225M
    return buf_ & ((1ULL << N) - 1);
111
225M
  }
unsigned long jxl::BitReader::PeekFixedBits<1ul>() const
Line
Count
Source
107
556k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
556k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
556k
    JXL_DASSERT(!close_called_);
110
556k
    return buf_ & ((1ULL << N) - 1);
111
556k
  }
unsigned long jxl::BitReader::PeekFixedBits<8ul>() const
Line
Count
Source
107
25.7k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
25.7k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
25.7k
    JXL_DASSERT(!close_called_);
110
25.7k
    return buf_ & ((1ULL << N) - 1);
111
25.7k
  }
unsigned long jxl::BitReader::PeekFixedBits<4ul>() const
Line
Count
Source
107
68.6k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
68.6k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
68.6k
    JXL_DASSERT(!close_called_);
110
68.6k
    return buf_ & ((1ULL << N) - 1);
111
68.6k
  }
unsigned long jxl::BitReader::PeekFixedBits<3ul>() const
Line
Count
Source
107
62.1k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
62.1k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
62.1k
    JXL_DASSERT(!close_called_);
110
62.1k
    return buf_ & ((1ULL << N) - 1);
111
62.1k
  }
unsigned long jxl::BitReader::PeekFixedBits<7ul>() const
Line
Count
Source
107
572k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
572k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
572k
    JXL_DASSERT(!close_called_);
110
572k
    return buf_ & ((1ULL << N) - 1);
111
572k
  }
unsigned long jxl::BitReader::PeekFixedBits<2ul>() const
Line
Count
Source
107
1.07M
  JXL_INLINE uint64_t PeekFixedBits() const {
108
1.07M
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
1.07M
    JXL_DASSERT(!close_called_);
110
1.07M
    return buf_ & ((1ULL << N) - 1);
111
1.07M
  }
unsigned long jxl::BitReader::PeekFixedBits<32ul>() const
Line
Count
Source
107
51.3k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
51.3k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
51.3k
    JXL_DASSERT(!close_called_);
110
51.3k
    return buf_ & ((1ULL << N) - 1);
111
51.3k
  }
unsigned long jxl::BitReader::PeekFixedBits<5ul>() const
Line
Count
Source
107
3.26M
  JXL_INLINE uint64_t PeekFixedBits() const {
108
3.26M
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
3.26M
    JXL_DASSERT(!close_called_);
110
3.26M
    return buf_ & ((1ULL << N) - 1);
111
3.26M
  }
unsigned long jxl::BitReader::PeekFixedBits<10ul>() const
Line
Count
Source
107
41.2k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
41.2k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
41.2k
    JXL_DASSERT(!close_called_);
110
41.2k
    return buf_ & ((1ULL << N) - 1);
111
41.2k
  }
unsigned long jxl::BitReader::PeekFixedBits<12ul>() const
Line
Count
Source
107
10.4k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
10.4k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
10.4k
    JXL_DASSERT(!close_called_);
110
10.4k
    return buf_ & ((1ULL << N) - 1);
111
10.4k
  }
unsigned long jxl::BitReader::PeekFixedBits<0ul>() const
Line
Count
Source
107
5.39k
  JXL_INLINE uint64_t PeekFixedBits() const {
108
5.39k
    static_assert(N <= kMaxBitsPerCall, "Reading too many bits in one call.");
109
5.39k
    JXL_DASSERT(!close_called_);
110
5.39k
    return buf_ & ((1ULL << N) - 1);
111
5.39k
  }
112
113
404M
  JXL_INLINE uint64_t PeekBits(size_t nbits) const {
114
404M
    JXL_DASSERT(nbits <= kMaxBitsPerCall);
115
404M
    JXL_DASSERT(!close_called_);
116
117
    // Slightly faster but requires BMI2. It is infeasible to make the many
118
    // callers reside between begin/end_target, especially because only the
119
    // callers in dec_ans are time-critical. Therefore only enabled if the
120
    // entire binary is compiled for (and thus requires) BMI2.
121
#if defined(__BMI2__) && defined(__x86_64__)
122
    return _bzhi_u64(buf_, nbits);
123
#else
124
404M
    const uint64_t mask = (1ULL << nbits) - 1;
125
404M
    return buf_ & mask;
126
404M
#endif
127
404M
  }
128
129
  // Removes bits from the buffer. Need not match the previous Peek size, but
130
  // the buffer must contain at least num_bits (this prevents consuming more
131
  // than the total number of bits).
132
636M
  JXL_INLINE void Consume(size_t num_bits) {
133
636M
    JXL_DASSERT(!close_called_);
134
636M
    JXL_DASSERT(bits_in_buf_ >= num_bits);
135
636M
    if (JXL_CRASH_ON_ERROR) {
136
      // When JXL_CRASH_ON_ERROR is defined, it is a fatal error to read more
137
      // bits than available in the stream. A non-zero overread_bytes_ implies
138
      // that next_byte_ is already at the end of the stream, so we don't need
139
      // to check that.
140
0
      JXL_DASSERT(bits_in_buf_ >= num_bits + overread_bytes_ * kBitsPerByte);
141
0
    }
142
636M
    bits_in_buf_ -= num_bits;
143
636M
    buf_ >>= num_bits;
144
636M
  }
145
146
3.07M
  JXL_INLINE uint64_t ReadBits(size_t nbits) {
147
3.07M
    JXL_DASSERT(!close_called_);
148
3.07M
    Refill();
149
3.07M
    const uint64_t bits = PeekBits(nbits);
150
3.07M
    Consume(nbits);
151
3.07M
    return bits;
152
3.07M
  }
153
154
  template <size_t N>
155
1.95M
  JXL_INLINE uint64_t ReadFixedBits() {
156
1.95M
    JXL_DASSERT(!close_called_);
157
1.95M
    Refill();
158
1.95M
    const uint64_t bits = PeekFixedBits<N>();
159
1.95M
    Consume(N);
160
1.95M
    return bits;
161
1.95M
  }
unsigned long jxl::BitReader::ReadFixedBits<1ul>()
Line
Count
Source
155
556k
  JXL_INLINE uint64_t ReadFixedBits() {
156
556k
    JXL_DASSERT(!close_called_);
157
556k
    Refill();
158
556k
    const uint64_t bits = PeekFixedBits<N>();
159
556k
    Consume(N);
160
556k
    return bits;
161
556k
  }
unsigned long jxl::BitReader::ReadFixedBits<8ul>()
Line
Count
Source
155
25.7k
  JXL_INLINE uint64_t ReadFixedBits() {
156
25.7k
    JXL_DASSERT(!close_called_);
157
25.7k
    Refill();
158
25.7k
    const uint64_t bits = PeekFixedBits<N>();
159
25.7k
    Consume(N);
160
25.7k
    return bits;
161
25.7k
  }
unsigned long jxl::BitReader::ReadFixedBits<4ul>()
Line
Count
Source
155
31.3k
  JXL_INLINE uint64_t ReadFixedBits() {
156
31.3k
    JXL_DASSERT(!close_called_);
157
31.3k
    Refill();
158
31.3k
    const uint64_t bits = PeekFixedBits<N>();
159
31.3k
    Consume(N);
160
31.3k
    return bits;
161
31.3k
  }
unsigned long jxl::BitReader::ReadFixedBits<3ul>()
Line
Count
Source
155
62.1k
  JXL_INLINE uint64_t ReadFixedBits() {
156
62.1k
    JXL_DASSERT(!close_called_);
157
62.1k
    Refill();
158
62.1k
    const uint64_t bits = PeekFixedBits<N>();
159
62.1k
    Consume(N);
160
62.1k
    return bits;
161
62.1k
  }
unsigned long jxl::BitReader::ReadFixedBits<2ul>()
Line
Count
Source
155
1.07M
  JXL_INLINE uint64_t ReadFixedBits() {
156
1.07M
    JXL_DASSERT(!close_called_);
157
1.07M
    Refill();
158
1.07M
    const uint64_t bits = PeekFixedBits<N>();
159
1.07M
    Consume(N);
160
1.07M
    return bits;
161
1.07M
  }
unsigned long jxl::BitReader::ReadFixedBits<32ul>()
Line
Count
Source
155
51.3k
  JXL_INLINE uint64_t ReadFixedBits() {
156
51.3k
    JXL_DASSERT(!close_called_);
157
51.3k
    Refill();
158
51.3k
    const uint64_t bits = PeekFixedBits<N>();
159
51.3k
    Consume(N);
160
51.3k
    return bits;
161
51.3k
  }
unsigned long jxl::BitReader::ReadFixedBits<10ul>()
Line
Count
Source
155
41.2k
  JXL_INLINE uint64_t ReadFixedBits() {
156
41.2k
    JXL_DASSERT(!close_called_);
157
41.2k
    Refill();
158
41.2k
    const uint64_t bits = PeekFixedBits<N>();
159
41.2k
    Consume(N);
160
41.2k
    return bits;
161
41.2k
  }
unsigned long jxl::BitReader::ReadFixedBits<12ul>()
Line
Count
Source
155
10.4k
  JXL_INLINE uint64_t ReadFixedBits() {
156
10.4k
    JXL_DASSERT(!close_called_);
157
10.4k
    Refill();
158
10.4k
    const uint64_t bits = PeekFixedBits<N>();
159
10.4k
    Consume(N);
160
10.4k
    return bits;
161
10.4k
  }
unsigned long jxl::BitReader::ReadFixedBits<16ul>()
Line
Count
Source
155
92.4k
  JXL_INLINE uint64_t ReadFixedBits() {
156
92.4k
    JXL_DASSERT(!close_called_);
157
92.4k
    Refill();
158
92.4k
    const uint64_t bits = PeekFixedBits<N>();
159
92.4k
    Consume(N);
160
92.4k
    return bits;
161
92.4k
  }
unsigned long jxl::BitReader::ReadFixedBits<0ul>()
Line
Count
Source
155
5.39k
  JXL_INLINE uint64_t ReadFixedBits() {
156
5.39k
    JXL_DASSERT(!close_called_);
157
5.39k
    Refill();
158
5.39k
    const uint64_t bits = PeekFixedBits<N>();
159
5.39k
    Consume(N);
160
5.39k
    return bits;
161
5.39k
  }
162
163
  // Equivalent to calling ReadFixedBits(1) `skip` times, but much faster.
164
  // `skip` is typically large.
165
97.7k
  void SkipBits(size_t skip) {
166
97.7k
    JXL_DASSERT(!close_called_);
167
    // Buffer is large enough - don't zero buf_ below.
168
97.7k
    if (JXL_UNLIKELY(skip <= bits_in_buf_)) {
169
96.0k
      Consume(skip);
170
96.0k
      return;
171
96.0k
    }
172
173
    // First deduct what we can satisfy from the buffer
174
1.72k
    skip -= bits_in_buf_;
175
1.72k
    bits_in_buf_ = 0;
176
    // Not enough to call Advance - that may leave some bits in the buffer
177
    // which were previously ABOVE bits_in_buf.
178
1.72k
    buf_ = 0;
179
180
    // Skip whole bytes
181
1.72k
    const size_t whole_bytes = skip / kBitsPerByte;
182
1.72k
    skip %= kBitsPerByte;
183
1.72k
    if (JXL_UNLIKELY(whole_bytes >
184
1.72k
                     static_cast<size_t>(end_minus_8_ + 8 - next_byte_))) {
185
      // This is already an overflow condition (skipping past the end of the bit
186
      // stream). However if we increase next_byte_ too much we risk overflowing
187
      // that value and potentially making it valid again (next_byte_ < end).
188
      // This will set next_byte_ to the end of the stream and still consume
189
      // some bits in overread_bytes_, however the TotalBitsConsumed() will be
190
      // incorrect (still larger than the TotalBytes()).
191
1.07k
      next_byte_ = end_minus_8_ + 8;
192
1.07k
      skip += kBitsPerByte;
193
1.07k
    } else {
194
654
      next_byte_ += whole_bytes;
195
654
    }
196
197
1.72k
    Refill();
198
1.72k
    Consume(skip);
199
1.72k
  }
200
201
7.81M
  size_t TotalBitsConsumed() const {
202
7.81M
    const size_t bytes_read = static_cast<size_t>(next_byte_ - first_byte_);
203
7.81M
    return (bytes_read + overread_bytes_) * kBitsPerByte - bits_in_buf_;
204
7.81M
  }
205
206
115k
  Status JumpToByteBoundary() {
207
115k
    const size_t remainder = TotalBitsConsumed() % kBitsPerByte;
208
115k
    if (remainder == 0) return true;
209
100k
    if (JXL_UNLIKELY(ReadBits(kBitsPerByte - remainder) != 0)) {
210
454
      return JXL_FAILURE("Non-zero padding bits");
211
454
    }
212
100k
    return true;
213
100k
  }
214
215
  // For interoperability with other bitreaders (for resuming at
216
  // non-byte-aligned positions).
217
0
  const uint8_t* FirstByte() const { return first_byte_; }
218
3.64M
  size_t TotalBytes() const {
219
3.64M
    return static_cast<size_t>(end_minus_8_ + 8 - first_byte_);
220
3.64M
  }
221
222
  // Forces the BitReader into an out-of-bounds state. Used by higher-level
223
  // decoders to short-circuit further reads when they detect a corrupt stream
224
  // (e.g. an LZ77 length-code overflow): after this call, subsequent reads
225
  // still return zeros, but AllReadsWithinBounds() and Close() will report
226
  // failure so the corruption surfaces at the next checkpoint rather than
227
  // silently producing phantom-zero symbols.
228
72
  void MarkUnhealthy() {
229
72
    next_byte_ = end_minus_8_ + 8;
230
    // Add enough overread to make TotalBitsConsumed() exceed TotalBytes() *
231
    // kBitsPerByte regardless of how many bits remain in buf_.
232
72
    overread_bytes_ += 8;
233
72
  }
234
235
  // Returns whether all the bits read so far have been within the input bounds.
236
  // When reading past the EOF, the Read*() and Consume() functions return zeros
237
  // but flag a failure when calling Close() without checking this function.
238
3.48M
  Status AllReadsWithinBounds() {
239
    // Mark up to which point the user checked the out of bounds condition. If
240
    // the user handles the condition at higher level (e.g. fetch more bytes
241
    // from network, return a custom JXL_FAILURE, ...), Close() should not
242
    // output a debug error (which would break tests with JXL_CRASH_ON_ERROR
243
    // even when legitimately handling the situation at higher level). This is
244
    // used by Bundle::CanRead.
245
3.48M
    checked_out_of_bounds_bits_ = TotalBitsConsumed();
246
3.48M
    if (TotalBitsConsumed() > TotalBytes() * kBitsPerByte) {
247
29.3k
      return false;
248
29.3k
    }
249
3.45M
    return true;
250
3.48M
  }
251
252
  // Close the bit reader and return whether all the previous reads were
253
  // successful. Close must be called once.
254
229k
  Status Close() {
255
229k
    JXL_DASSERT(!close_called_);
256
229k
    close_called_ = true;
257
229k
    if (!first_byte_) return true;
258
229k
    if (TotalBitsConsumed() > checked_out_of_bounds_bits_ &&
259
846
        TotalBitsConsumed() > TotalBytes() * kBitsPerByte) {
260
0
      return JXL_FAILURE("Read more bits than available in the bit_reader");
261
0
    }
262
229k
    return true;
263
229k
  }
264
265
 private:
266
  // Separate function avoids inlining this relatively cold code into callers.
267
  JXL_NOINLINE void BoundsCheckedRefill();
268
269
0
  JXL_NOINLINE uint32_t BoundsCheckedReadByteAlignedWord() {
270
0
    if (next_byte_ + 1 < end_minus_8_ + 8) {
271
0
      uint32_t ret = LoadLE16(next_byte_);
272
0
      next_byte_ += 2;
273
0
      return ret;
274
0
    }
275
0
    overread_bytes_ += 2;
276
0
    return 0;
277
0
  }
278
279
  uint64_t buf_;
280
  size_t bits_in_buf_;  // [0, 64)
281
  const uint8_t* JXL_RESTRICT next_byte_;
282
  const uint8_t* end_minus_8_;  // for refill bounds check
283
  const uint8_t* first_byte_;   // for GetSpan
284
285
  // Number of bytes past the end that were loaded into the buf_. These bytes
286
  // are not read from memory, but instead assumed 0. It is an error (likely due
287
  // to an invalid stream) to Consume() more bits than specified in the range
288
  // passed to the constructor.
289
  uint64_t overread_bytes_{0};
290
  bool close_called_{false};
291
292
  uint64_t checked_out_of_bounds_bits_{0};
293
};
294
295
// Closes a BitReader when the BitReaderScopedCloser goes out of scope. When
296
// closing the bit reader, if the status result was failure it sets this failure
297
// to the passed variable pointer. Typical usage.
298
//
299
// Status ret = true;
300
// {
301
//   BitReader reader(...);
302
//   BitReaderScopedCloser reader_closer(&reader, &ret);
303
//
304
//   // ... code that can return errors here ...
305
// }
306
// // ... more code that doesn't use the BitReader.
307
// return ret;
308
309
class BitReaderScopedCloser {
310
 public:
311
  BitReaderScopedCloser(BitReader& reader, Status& status)
312
846
      : reader_(&reader), status_(&status) {}
313
846
  ~BitReaderScopedCloser() {
314
846
    if (reader_ != nullptr) {
315
846
      Status close_ret = reader_->Close();
316
846
      if (!close_ret) *status_ = close_ret;
317
846
    }
318
846
  }
319
  BitReaderScopedCloser(const BitReaderScopedCloser&) = delete;
320
321
 private:
322
  BitReader* reader_;
323
  Status* status_;
324
};
325
326
}  // namespace jxl
327
328
#endif  // LIB_JXL_DEC_BIT_READER_H_