Coverage Report

Created: 2026-09-13 07:02

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/libjxl/lib/jxl/icc_codec.cc
Line
Count
Source
1
// Copyright (c) the JPEG XL Project Authors. All rights reserved.
2
//
3
// Use of this source code is governed by a BSD-style
4
// license that can be found in the LICENSE file.
5
6
#include "lib/jxl/icc_codec.h"
7
8
#include <jxl/memory_manager.h>
9
10
#include <algorithm>
11
#include <cstddef>
12
#include <cstdint>
13
14
#include "lib/jxl/base/common.h"
15
#include "lib/jxl/base/status.h"
16
#include "lib/jxl/dec_ans.h"
17
#include "lib/jxl/dec_bit_reader.h"
18
#include "lib/jxl/fields.h"
19
#include "lib/jxl/icc_codec_common.h"
20
#include "lib/jxl/padded_bytes.h"
21
22
namespace jxl {
23
namespace {
24
25
// Shuffles or interleaves bytes, for example with width 2, turns "ABCDabcd"
26
// into "AaBbCcDd". Transposes a matrix of ceil(size / width) columns and
27
// width rows. There are size elements, size may be < width * height, if so the
28
// last elements of the rightmost column are missing, the missing spots are
29
// transposed along with the filled spots, and the result has the missing
30
// elements at the end of the bottom row. The input is the input matrix in
31
// scanline order but with missing elements skipped (which may occur in multiple
32
// locations), the output is the result matrix in scanline order (with
33
// no need to skip missing elements as they are past the end of the data).
34
Status Shuffle(JxlMemoryManager* memory_manager, uint8_t* data, size_t size,
35
3.01k
               size_t width) {
36
3.01k
  size_t height = (size + width - 1) / width;  // amount of rows of output
37
3.01k
  PaddedBytes result(memory_manager);
38
3.01k
  JXL_ASSIGN_OR_RETURN(result,
39
3.01k
                       PaddedBytes::WithInitialSpace(memory_manager, size));
40
  // i = output index, j input index
41
3.01k
  size_t s = 0;
42
3.01k
  size_t j = 0;
43
101k
  for (size_t i = 0; i < size; i++) {
44
98.7k
    result[i] = data[j];
45
98.7k
    j += height;
46
98.7k
    if (j >= size) j = ++s;
47
98.7k
  }
48
49
101k
  for (size_t i = 0; i < size; i++) {
50
98.7k
    data[i] = result[i];
51
98.7k
  }
52
3.01k
  return true;
53
3.01k
}
54
55
// Two base-128 varints at up to 10 bytes each.
56
constexpr size_t kPreambleSize = 20;
57
58
// Decodes a base-128 unsigned varint into *out, advancing *pos by the exact
59
// number of bytes consumed. Returns an error if the input is truncated, if
60
// the terminator (top-bit-clear byte) is not seen within 10 bytes, or if the
61
// 10th byte encodes a value that does not fit in a uint64_t.
62
Status DecodeVarInt(const uint8_t* input, size_t inputSize, size_t* pos,
63
16.6k
                    uint64_t* out) {
64
16.6k
  uint64_t ret = 0;
65
  // 9 bytes cover bits 0..62; the 10th byte may only contribute bit 63.
66
23.3k
  for (size_t i = 0; i < 9; ++i) {
67
23.3k
    if (*pos >= inputSize) {
68
103
      return JXL_FAILURE("DecodeVarInt: truncated input");
69
103
    }
70
23.2k
    const uint8_t byte = input[(*pos)++];
71
23.2k
    ret |= static_cast<uint64_t>(byte & 0x7F) << (7 * i);
72
23.2k
    if ((byte & 0x80) == 0) {
73
16.5k
      *out = ret;
74
16.5k
      return true;
75
16.5k
    }
76
23.2k
  }
77
48
  if (*pos >= inputSize) {
78
3
    return JXL_FAILURE("DecodeVarInt: truncated input (10th byte)");
79
3
  }
80
45
  const uint8_t byte = input[(*pos)++];
81
45
  if ((byte & 0x80) != 0) {
82
23
    return JXL_FAILURE("DecodeVarInt: varint exceeds 10 bytes");
83
23
  }
84
22
  if ((byte & 0x7E) != 0) {
85
2
    return JXL_FAILURE("DecodeVarInt: value exceeds 2^64 - 1");
86
2
  }
87
20
  ret |= static_cast<uint64_t>(byte & 0x01) << 63;
88
20
  *out = ret;
89
20
  return true;
90
22
}
91
92
}  // namespace
93
94
// Mimics the beginning of UnpredictICC for quick validity check.
95
// At least kPreambleSize bytes of data should be valid at invocation time.
96
940
Status CheckPreamble(const PaddedBytes& data, size_t enc_size) {
97
940
  const uint8_t* enc = data.data();
98
940
  size_t size = data.size();
99
940
  size_t pos = 0;
100
940
  uint64_t osize;
101
940
  JXL_RETURN_IF_ERROR(DecodeVarInt(enc, size, &pos, &osize));
102
931
  JXL_RETURN_IF_ERROR(CheckIs32Bit(osize));
103
924
  uint64_t csize;
104
924
  JXL_RETURN_IF_ERROR(DecodeVarInt(enc, size, &pos, &csize));
105
922
  JXL_RETURN_IF_ERROR(CheckIs32Bit(csize));
106
914
  JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, csize, size));
107
  // We expect that UnpredictICC inflates input, not the other way round.
108
894
  if (osize + 65536 < enc_size) return JXL_FAILURE("Malformed ICC");
109
110
  // NB(eustas): 64 MiB ICC should be enough for everything!?
111
878
  const size_t output_limit = 1 << 28;
112
878
  if (output_limit && osize > output_limit) {
113
6
    return JXL_FAILURE("Decoded ICC is too large");
114
6
  }
115
872
  return true;
116
878
}
117
118
// Decodes the result of PredictICC back to a valid ICC profile.
119
787
Status UnpredictICC(const uint8_t* enc, size_t size, PaddedBytes* result) {
120
787
  if (!result->empty()) return JXL_FAILURE("result must be empty initially");
121
787
  JxlMemoryManager* memory_manager = result->memory_manager();
122
787
  size_t pos = 0;
123
787
  uint64_t osize;
124
787
  JXL_RETURN_IF_ERROR(DecodeVarInt(enc, size, &pos, &osize));  // Output size
125
764
  JXL_RETURN_IF_ERROR(CheckIs32Bit(osize));
126
756
  uint64_t csize;
127
756
  JXL_RETURN_IF_ERROR(DecodeVarInt(enc, size, &pos, &csize));  // Commands size
128
  // Every command is translated to at least one byte.
129
739
  JXL_RETURN_IF_ERROR(CheckIs32Bit(csize));
130
733
  size_t cpos = pos;  // pos in commands stream
131
733
  JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, csize, size));
132
722
  size_t commands_end = cpos + csize;
133
722
  pos = commands_end;  // pos in data stream
134
135
  // Header
136
722
  PaddedBytes header{memory_manager};
137
722
  JXL_RETURN_IF_ERROR(header.append(ICCInitialHeaderPrediction(osize)));
138
71.2k
  for (size_t i = 0; i <= kICCHeaderSize; i++) {
139
71.2k
    if (result->size() == osize) {
140
171
      if (cpos != commands_end) return JXL_FAILURE("Not all commands used");
141
123
      if (pos != size) return JXL_FAILURE("Not all data used");
142
16
      return true;  // Valid end
143
123
    }
144
71.0k
    if (i == kICCHeaderSize) break;  // Done
145
70.4k
    ICCPredictHeader(result->data(), result->size(), header.data(), i);
146
70.4k
    if (pos >= size) return JXL_FAILURE("Out of bounds");
147
70.4k
    JXL_RETURN_IF_ERROR(result->push_back(enc[pos++] + header[i]));
148
70.4k
  }
149
535
  if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
150
151
  // Tag list
152
532
  uint64_t numtags;
153
532
  JXL_RETURN_IF_ERROR(DecodeVarInt(enc, commands_end, &cpos, &numtags));
154
155
528
  if (numtags != 0) {
156
321
    numtags--;
157
321
    JXL_RETURN_IF_ERROR(CheckIs32Bit(numtags));
158
315
    JXL_RETURN_IF_ERROR(AppendUint32(numtags, result));
159
315
    uint64_t prevtagstart = kICCHeaderSize + numtags * 12;
160
315
    uint64_t prevtagsize = 0;
161
10.8k
    for (;;) {
162
10.8k
      if (result->size() > osize) return JXL_FAILURE("Invalid result size");
163
10.8k
      if (cpos > commands_end) return JXL_FAILURE("Out of bounds");
164
10.8k
      if (cpos == commands_end) break;  // Valid end
165
10.7k
      uint8_t command = enc[cpos++];
166
10.7k
      uint8_t tagcode = command & 63;
167
10.7k
      Tag tag;
168
10.7k
      if (tagcode == 0) {
169
160
        break;
170
10.6k
      } else if (tagcode == kCommandTagUnknown) {
171
1.73k
        JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, 4, size));
172
1.73k
        tag = DecodeKeyword(enc, size, pos);
173
1.73k
        pos += 4;
174
8.86k
      } else if (tagcode == kCommandTagTRC) {
175
1.23k
        tag = kRtrcTag;
176
7.63k
      } else if (tagcode == kCommandTagXYZ) {
177
1.57k
        tag = kRxyzTag;
178
6.05k
      } else {
179
6.05k
        if (tagcode - kCommandTagStringFirst >= kNumTagStrings) {
180
27
          return JXL_FAILURE("Unknown tagcode");
181
27
        }
182
6.03k
        tag = *kTagStrings[tagcode - kCommandTagStringFirst];
183
6.03k
      }
184
10.5k
      JXL_RETURN_IF_ERROR(AppendKeyword(tag, result));
185
186
10.5k
      uint64_t tagstart;
187
10.5k
      uint64_t tagsize = prevtagsize;
188
10.5k
      if (tag == kRxyzTag || tag == kGxyzTag || tag == kBxyzTag ||
189
7.10k
          tag == kKxyzTag || tag == kWtptTag || tag == kBkptTag ||
190
5.67k
          tag == kLumiTag) {
191
5.44k
        tagsize = 20;
192
5.44k
      }
193
194
10.5k
      if (command & kFlagBitOffset) {
195
2.59k
        JXL_RETURN_IF_ERROR(DecodeVarInt(enc, commands_end, &cpos, &tagstart));
196
7.97k
      } else {
197
7.97k
        JXL_RETURN_IF_ERROR(CheckIs32Bit(prevtagstart));
198
7.97k
        tagstart = prevtagstart + prevtagsize;
199
7.97k
      }
200
10.5k
      JXL_RETURN_IF_ERROR(CheckIs32Bit(tagstart));
201
10.5k
      JXL_RETURN_IF_ERROR(AppendUint32(tagstart, result));
202
10.5k
      if (command & kFlagBitSize) {
203
2.28k
        JXL_RETURN_IF_ERROR(DecodeVarInt(enc, commands_end, &cpos, &tagsize));
204
2.28k
      }
205
10.5k
      JXL_RETURN_IF_ERROR(CheckIs32Bit(tagsize));
206
10.5k
      JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
207
10.5k
      prevtagstart = tagstart;
208
10.5k
      prevtagsize = tagsize;
209
210
10.5k
      if (tagcode == kCommandTagTRC) {
211
1.22k
        JXL_RETURN_IF_ERROR(AppendKeyword(kGtrcTag, result));
212
1.22k
        JXL_RETURN_IF_ERROR(AppendUint32(tagstart, result));
213
1.22k
        JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
214
1.22k
        JXL_RETURN_IF_ERROR(AppendKeyword(kBtrcTag, result));
215
1.22k
        JXL_RETURN_IF_ERROR(AppendUint32(tagstart, result));
216
1.22k
        JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
217
1.22k
      }
218
219
10.5k
      if (tagcode == kCommandTagXYZ) {
220
1.56k
        JXL_RETURN_IF_ERROR(CheckIs32Bit(tagstart + tagsize * 2));
221
1.56k
        JXL_RETURN_IF_ERROR(AppendKeyword(kGxyzTag, result));
222
1.56k
        JXL_RETURN_IF_ERROR(AppendUint32(tagstart + tagsize, result));
223
1.56k
        JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
224
1.56k
        JXL_RETURN_IF_ERROR(AppendKeyword(kBxyzTag, result));
225
1.56k
        JXL_RETURN_IF_ERROR(AppendUint32(tagstart + tagsize * 2, result));
226
1.56k
        JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
227
1.56k
      }
228
10.5k
    }
229
315
  }
230
231
  // Main Content
232
10.7k
  for (;;) {
233
10.7k
    if (result->size() > osize) return JXL_FAILURE("Invalid result size");
234
10.7k
    if (cpos > commands_end) return JXL_FAILURE("Out of bounds");
235
10.7k
    if (cpos == commands_end) break;  // Valid end
236
10.6k
    uint8_t command = enc[cpos++];
237
10.6k
    if (command == kCommandInsert) {
238
1.97k
      uint64_t num;
239
1.97k
      JXL_RETURN_IF_ERROR(DecodeVarInt(enc, commands_end, &cpos, &num));
240
1.96k
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, num, size));
241
12.1k
      for (size_t i = 0; i < num; i++) {
242
10.2k
        JXL_RETURN_IF_ERROR(result->push_back(enc[pos++]));
243
10.2k
      }
244
8.70k
    } else if (command == kCommandShuffle2 || command == kCommandShuffle4) {
245
1.89k
      uint64_t num;
246
1.89k
      JXL_RETURN_IF_ERROR(DecodeVarInt(enc, commands_end, &cpos, &num));
247
1.87k
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, num, size));
248
1.86k
      PaddedBytes shuffled(memory_manager);
249
1.86k
      JXL_ASSIGN_OR_RETURN(shuffled,
250
1.86k
                           PaddedBytes::WithInitialSpace(memory_manager, num));
251
19.9k
      for (size_t i = 0; i < num; i++) {
252
18.0k
        shuffled[i] = enc[pos + i];
253
18.0k
      }
254
1.86k
      if (command == kCommandShuffle2) {
255
856
        JXL_RETURN_IF_ERROR(Shuffle(memory_manager, shuffled.data(), num, 2));
256
1.00k
      } else if (command == kCommandShuffle4) {
257
1.00k
        JXL_RETURN_IF_ERROR(Shuffle(memory_manager, shuffled.data(), num, 4));
258
1.00k
      }
259
19.9k
      for (size_t i = 0; i < num; i++) {
260
18.0k
        JXL_RETURN_IF_ERROR(result->push_back(shuffled[i]));
261
18.0k
        pos++;
262
18.0k
      }
263
6.81k
    } else if (command == kCommandPredict) {
264
3.48k
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(cpos, 2, commands_end));
265
3.46k
      uint8_t flags = enc[cpos++];
266
267
3.46k
      size_t width = (flags & 3) + 1;
268
3.46k
      if (width == 3) return JXL_FAILURE("Invalid width");
269
270
3.46k
      int order = (flags & 12) >> 2;
271
3.46k
      if (order == 3) return JXL_FAILURE("Invalid order");
272
273
3.46k
      uint64_t stride = width;
274
3.46k
      if (flags & 16) {
275
598
        JXL_RETURN_IF_ERROR(DecodeVarInt(enc, commands_end, &cpos, &stride));
276
595
        if (stride < width) {
277
2
          return JXL_FAILURE("Invalid stride");
278
2
        }
279
595
      }
280
      // If stride * 4 >= result->size(), return failure. The check
281
      // "size == 0 || ((size - 1) >> 2) < stride" corresponds to
282
      // "stride * 4 >= size", but does not suffer from integer overflow.
283
      // This check is more strict than necessary but follows the specification
284
      // and the encoder should ensure this is followed.
285
3.45k
      if (result->empty() || ((result->size() - 1u) >> 2u) < stride) {
286
62
        return JXL_FAILURE("Invalid stride");
287
62
      }
288
289
3.39k
      uint64_t num;
290
3.39k
      JXL_RETURN_IF_ERROR(DecodeVarInt(enc, commands_end, &cpos, &num));  // in bytes
291
3.38k
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, num, size));
292
293
3.36k
      PaddedBytes shuffled(memory_manager);
294
3.36k
      JXL_ASSIGN_OR_RETURN(shuffled,
295
3.36k
                           PaddedBytes::WithInitialSpace(memory_manager, num));
296
297
102k
      for (size_t i = 0; i < num; i++) {
298
98.6k
        shuffled[i] = enc[pos + i];
299
98.6k
      }
300
3.36k
      if (width > 1) {
301
1.15k
        JXL_RETURN_IF_ERROR(
302
1.15k
            Shuffle(memory_manager, shuffled.data(), num, width));
303
1.15k
      }
304
305
3.36k
      size_t start = result->size();
306
102k
      for (size_t i = 0; i < num; i++) {
307
98.6k
        uint8_t predicted = LinearPredictICCValue(result->data(), start, i,
308
98.6k
                                                  stride, width, order);
309
98.6k
        JXL_RETURN_IF_ERROR(result->push_back(predicted + shuffled[i]));
310
98.6k
      }
311
3.36k
      pos += num;
312
3.36k
    } else if (command == kCommandXYZ) {
313
491
      JXL_RETURN_IF_ERROR(AppendKeyword(kXyz_Tag, result));
314
2.45k
      for (int i = 0; i < 4; i++) {
315
1.96k
        JXL_RETURN_IF_ERROR(result->push_back(0));
316
1.96k
      }
317
491
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, 12, size));
318
6.29k
      for (size_t i = 0; i < 12; i++) {
319
5.80k
        JXL_RETURN_IF_ERROR(result->push_back(enc[pos++]));
320
5.80k
      }
321
2.83k
    } else if (command >= kCommandTypeStartFirst &&
322
2.79k
               command < kCommandTypeStartFirst + kNumTypeStrings) {
323
2.71k
      JXL_RETURN_IF_ERROR(AppendKeyword(
324
2.71k
          *kTypeStrings[command - kCommandTypeStartFirst], result));
325
13.5k
      for (size_t i = 0; i < 4; i++) {
326
10.8k
        JXL_RETURN_IF_ERROR(result->push_back(0));
327
10.8k
      }
328
2.71k
    } else {
329
122
      return JXL_FAILURE("Unknown command");
330
122
    }
331
10.6k
  }
332
333
105
  if (pos != size) return JXL_FAILURE("Not all data used");
334
23
  if (result->size() != osize) return JXL_FAILURE("Invalid result size");
335
336
22
  return true;
337
23
}
338
339
2.58k
Status ICCReader::Init(BitReader* reader) {
340
2.58k
  JXL_RETURN_IF_ERROR(CheckEOI(reader));
341
2.58k
  JxlMemoryManager* memory_manager = decompressed_.memory_manager();
342
2.58k
  used_bits_base_ = reader->TotalBitsConsumed();
343
2.58k
  if (bits_to_skip_ == 0) {
344
2.22k
    enc_size_ = U64Coder::Read(reader);
345
2.22k
    if (enc_size_ > 268435456) {
346
      // Avoid too large memory allocation for invalid file.
347
75
      return JXL_FAILURE("Too large encoded profile");
348
75
    }
349
2.14k
    JXL_RETURN_IF_ERROR(DecodeHistograms(
350
2.14k
        memory_manager, reader, kNumICCContexts, &code_, &context_map_));
351
3.30k
    JXL_ASSIGN_OR_RETURN(ans_reader_, ANSSymbolReader::Create(&code_, reader));
352
3.30k
    i_ = 0;
353
3.30k
    JXL_RETURN_IF_ERROR(
354
3.30k
        decompressed_.resize(std::min<size_t>(i_ + 0x400, enc_size_)));
355
4.73k
    for (; i_ < std::min<size_t>(2, enc_size_); i_++) {
356
3.08k
      decompressed_[i_] = ans_reader_.ReadHybridUint(
357
3.08k
          ICCANSContext(i_, i_ > 0 ? decompressed_[i_ - 1] : 0,
358
3.08k
                        i_ > 1 ? decompressed_[i_ - 2] : 0),
359
3.08k
          reader, context_map_);
360
3.08k
    }
361
1.65k
    if (enc_size_ > kPreambleSize) {
362
26.0k
      for (; i_ < kPreambleSize; i_++) {
363
24.6k
        decompressed_[i_] = ans_reader_.ReadHybridUint(
364
24.6k
            ICCANSContext(i_, decompressed_[i_ - 1], decompressed_[i_ - 2]),
365
24.6k
            reader, context_map_);
366
24.6k
      }
367
1.37k
      JXL_RETURN_IF_ERROR(CheckEOI(reader));
368
940
      JXL_RETURN_IF_ERROR(CheckPreamble(decompressed_, enc_size_));
369
940
    }
370
1.15k
    bits_to_skip_ = reader->TotalBitsConsumed() - used_bits_base_;
371
1.15k
  } else {
372
358
    reader->SkipBits(bits_to_skip_);
373
358
  }
374
1.51k
  return true;
375
2.58k
}
376
377
1.17k
Status ICCReader::Process(BitReader* reader, PaddedBytes* icc) {
378
1.17k
  auto checkpoint = jxl::make_unique<ANSSymbolReader::Checkpoint>();
379
1.17k
  size_t saved_i = 0;
380
13.1k
  auto save = [&]() {
381
13.1k
    ans_reader_.Save(checkpoint.get());
382
13.1k
    bits_to_skip_ = reader->TotalBitsConsumed() - used_bits_base_;
383
13.1k
    saved_i = i_;
384
13.1k
  };
385
1.17k
  save();
386
13.1k
  auto check_and_restore = [&]() -> Status {
387
13.1k
    Status status = CheckEOI(reader);
388
13.1k
    if (!status) {
389
      // not enough bytes.
390
382
      ans_reader_.Restore(*checkpoint);
391
382
      i_ = saved_i;
392
382
      return status;
393
382
    }
394
12.8k
    return true;
395
13.1k
  };
396
6.46M
  for (; i_ < enc_size_; i_++) {
397
6.46M
    if (i_ % ANSSymbolReader::kMaxCheckpointInterval == 0 && i_ > 0) {
398
12.2k
      JXL_RETURN_IF_ERROR(check_and_restore());
399
12.0k
      save();
400
12.0k
      if ((i_ > 0) && (((i_ & 0xFFFF) == 0))) {
401
69
        float used_bytes =
402
69
            (reader->TotalBitsConsumed() - used_bits_base_) / 8.0f;
403
69
        if (i_ > used_bytes * 256) return JXL_FAILURE("Corrupted stream");
404
69
      }
405
12.0k
      JXL_RETURN_IF_ERROR(
406
12.0k
          decompressed_.resize(std::min<size_t>(i_ + 0x400, enc_size_)));
407
12.0k
    }
408
6.46M
    JXL_ENSURE(i_ >= 2);
409
6.46M
    decompressed_[i_] = ans_reader_.ReadHybridUint(
410
6.46M
        ICCANSContext(i_, decompressed_[i_ - 1], decompressed_[i_ - 2]), reader,
411
6.46M
        context_map_);
412
6.46M
  }
413
959
  JXL_RETURN_IF_ERROR(check_and_restore());
414
787
  bits_to_skip_ = reader->TotalBitsConsumed() - used_bits_base_;
415
787
  if (!ans_reader_.CheckANSFinalState()) {
416
0
    return JXL_FAILURE("Corrupted ICC profile");
417
0
  }
418
419
787
  icc->clear();
420
787
  return UnpredictICC(decompressed_.data(), decompressed_.size(), icc);
421
787
}
422
423
17.1k
Status ICCReader::CheckEOI(BitReader* reader) {
424
17.1k
  if (reader->AllReadsWithinBounds()) return true;
425
814
  return JXL_NOT_ENOUGH_BYTES("Not enough bytes for reading ICC profile");
426
17.1k
}
427
428
}  // namespace jxl