Coverage Report

Created: 2025-07-16 07:53

/src/libjxl/lib/jxl/icc_codec.cc
Line
Count
Source (jump to first uncovered line)
1
// Copyright (c) the JPEG XL Project Authors. All rights reserved.
2
//
3
// Use of this source code is governed by a BSD-style
4
// license that can be found in the LICENSE file.
5
6
#include "lib/jxl/icc_codec.h"
7
8
#include <jxl/memory_manager.h>
9
10
#include <cstdint>
11
12
#include "lib/jxl/base/status.h"
13
#include "lib/jxl/dec_ans.h"
14
#include "lib/jxl/fields.h"
15
#include "lib/jxl/icc_codec_common.h"
16
#include "lib/jxl/padded_bytes.h"
17
18
namespace jxl {
19
namespace {
20
21
// Shuffles or interleaves bytes, for example with width 2, turns "ABCDabcd"
22
// into "AaBbCcDd". Transposes a matrix of ceil(size / width) columns and
23
// width rows. There are size elements, size may be < width * height, if so the
24
// last elements of the rightmost column are missing, the missing spots are
25
// transposed along with the filled spots, and the result has the missing
26
// elements at the end of the bottom row. The input is the input matrix in
27
// scanline order but with missing elements skipped (which may occur in multiple
28
// locations), the output is the result matrix in scanline order (with
29
// no need to skip missing elements as they are past the end of the data).
30
Status Shuffle(JxlMemoryManager* memory_manager, uint8_t* data, size_t size,
31
8.11k
               size_t width) {
32
8.11k
  size_t height = (size + width - 1) / width;  // amount of rows of output
33
8.11k
  PaddedBytes result(memory_manager);
34
8.11k
  JXL_ASSIGN_OR_RETURN(result,
35
8.11k
                       PaddedBytes::WithInitialSpace(memory_manager, size));
36
  // i = output index, j input index
37
8.11k
  size_t s = 0;
38
8.11k
  size_t j = 0;
39
467k
  for (size_t i = 0; i < size; i++) {
40
459k
    result[i] = data[j];
41
459k
    j += height;
42
459k
    if (j >= size) j = ++s;
43
459k
  }
44
45
467k
  for (size_t i = 0; i < size; i++) {
46
459k
    data[i] = result[i];
47
459k
  }
48
8.11k
  return true;
49
8.11k
}
50
51
// TODO(eustas): should be 20, or even 18, once DecodeVarInt is improved;
52
//               currently DecodeVarInt does not signal the errors, and marks
53
//               11 bytes as used even if only 10 are used (and 9 is enough for
54
//               63-bit values).
55
constexpr const size_t kPreambleSize = 22;  // enough for reading 2 VarInts
56
57
50.1k
uint64_t DecodeVarInt(const uint8_t* input, size_t inputSize, size_t* pos) {
58
50.1k
  size_t i;
59
50.1k
  uint64_t ret = 0;
60
62.8k
  for (i = 0; *pos + i < inputSize && i < 10; ++i) {
61
62.8k
    ret |= static_cast<uint64_t>(input[*pos + i] & 127)
62
62.8k
           << static_cast<uint64_t>(7 * i);
63
    // If the next-byte flag is not set, stop
64
62.8k
    if ((input[*pos + i] & 128) == 0) break;
65
62.8k
  }
66
  // TODO(user): Return a decoding error if i == 10.
67
50.1k
  *pos += i + 1;
68
50.1k
  return ret;
69
50.1k
}
70
71
}  // namespace
72
73
// Mimics the beginning of UnpredictICC for quick validity check.
74
// At least kPreambleSize bytes of data should be valid at invocation time.
75
2.19k
Status CheckPreamble(const PaddedBytes& data, size_t enc_size) {
76
2.19k
  const uint8_t* enc = data.data();
77
2.19k
  size_t size = data.size();
78
2.19k
  size_t pos = 0;
79
2.19k
  uint64_t osize = DecodeVarInt(enc, size, &pos);
80
2.19k
  JXL_RETURN_IF_ERROR(CheckIs32Bit(osize));
81
2.19k
  if (pos >= size) return JXL_FAILURE("Out of bounds");
82
2.19k
  uint64_t csize = DecodeVarInt(enc, size, &pos);
83
2.19k
  JXL_RETURN_IF_ERROR(CheckIs32Bit(csize));
84
2.19k
  JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, csize, size));
85
  // We expect that UnpredictICC inflates input, not the other way round.
86
2.19k
  if (osize + 65536 < enc_size) return JXL_FAILURE("Malformed ICC");
87
88
  // NB(eustas): 64 MiB ICC should be enough for everything!?
89
2.19k
  const size_t output_limit = 1 << 28;
90
2.19k
  if (output_limit && osize > output_limit) {
91
0
    return JXL_FAILURE("Decoded ICC is too large");
92
0
  }
93
2.19k
  return true;
94
2.19k
}
95
96
// Decodes the result of PredictICC back to a valid ICC profile.
97
2.18k
Status UnpredictICC(const uint8_t* enc, size_t size, PaddedBytes* result) {
98
2.18k
  if (!result->empty()) return JXL_FAILURE("result must be empty initially");
99
2.18k
  JxlMemoryManager* memory_manager = result->memory_manager();
100
2.18k
  size_t pos = 0;
101
  // TODO(lode): technically speaking we need to check that the entire varint
102
  // decoding never goes out of bounds, not just the first byte. This requires
103
  // a DecodeVarInt function that returns an error code. It is safe to use
104
  // DecodeVarInt with out of bounds values, it silently returns, but the
105
  // specification requires an error. Idem for all DecodeVarInt below.
106
2.18k
  if (pos >= size) return JXL_FAILURE("Out of bounds");
107
2.18k
  uint64_t osize = DecodeVarInt(enc, size, &pos);  // Output size
108
2.18k
  JXL_RETURN_IF_ERROR(CheckIs32Bit(osize));
109
2.18k
  if (pos >= size) return JXL_FAILURE("Out of bounds");
110
2.18k
  uint64_t csize = DecodeVarInt(enc, size, &pos);  // Commands size
111
  // Every command is translated to at least on byte.
112
2.18k
  JXL_RETURN_IF_ERROR(CheckIs32Bit(csize));
113
2.18k
  size_t cpos = pos;  // pos in commands stream
114
2.18k
  JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, csize, size));
115
2.18k
  size_t commands_end = cpos + csize;
116
2.18k
  pos = commands_end;  // pos in data stream
117
118
  // Header
119
2.18k
  PaddedBytes header{memory_manager};
120
2.18k
  JXL_RETURN_IF_ERROR(header.append(ICCInitialHeaderPrediction(osize)));
121
282k
  for (size_t i = 0; i <= kICCHeaderSize; i++) {
122
282k
    if (result->size() == osize) {
123
1
      if (cpos != commands_end) return JXL_FAILURE("Not all commands used");
124
1
      if (pos != size) return JXL_FAILURE("Not all data used");
125
0
      return true;  // Valid end
126
1
    }
127
282k
    if (i == kICCHeaderSize) break;  // Done
128
279k
    ICCPredictHeader(result->data(), result->size(), header.data(), i);
129
279k
    if (pos >= size) return JXL_FAILURE("Out of bounds");
130
279k
    JXL_RETURN_IF_ERROR(result->push_back(enc[pos++] + header[i]));
131
279k
  }
132
2.18k
  if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
133
134
  // Tag list
135
2.18k
  uint64_t numtags = DecodeVarInt(enc, size, &cpos);
136
137
2.18k
  if (numtags != 0) {
138
2.18k
    numtags--;
139
2.18k
    JXL_RETURN_IF_ERROR(CheckIs32Bit(numtags));
140
2.18k
    JXL_RETURN_IF_ERROR(AppendUint32(numtags, result));
141
2.18k
    uint64_t prevtagstart = kICCHeaderSize + numtags * 12;
142
2.18k
    uint64_t prevtagsize = 0;
143
25.2k
    for (;;) {
144
25.2k
      if (result->size() > osize) return JXL_FAILURE("Invalid result size");
145
25.2k
      if (cpos > commands_end) return JXL_FAILURE("Out of bounds");
146
25.2k
      if (cpos == commands_end) break;  // Valid end
147
25.2k
      uint8_t command = enc[cpos++];
148
25.2k
      uint8_t tagcode = command & 63;
149
25.2k
      Tag tag;
150
25.2k
      if (tagcode == 0) {
151
2.18k
        break;
152
23.0k
      } else if (tagcode == kCommandTagUnknown) {
153
2.24k
        JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, 4, size));
154
2.24k
        tag = DecodeKeyword(enc, size, pos);
155
2.24k
        pos += 4;
156
20.7k
      } else if (tagcode == kCommandTagTRC) {
157
2.05k
        tag = kRtrcTag;
158
18.7k
      } else if (tagcode == kCommandTagXYZ) {
159
174
        tag = kRxyzTag;
160
18.5k
      } else {
161
18.5k
        if (tagcode - kCommandTagStringFirst >= kNumTagStrings) {
162
1
          return JXL_FAILURE("Unknown tagcode");
163
1
        }
164
18.5k
        tag = *kTagStrings[tagcode - kCommandTagStringFirst];
165
18.5k
      }
166
23.0k
      JXL_RETURN_IF_ERROR(AppendKeyword(tag, result));
167
168
23.0k
      uint64_t tagstart;
169
23.0k
      uint64_t tagsize = prevtagsize;
170
23.0k
      if (tag == kRxyzTag || tag == kGxyzTag || tag == kBxyzTag ||
171
23.0k
          tag == kKxyzTag || tag == kWtptTag || tag == kBkptTag ||
172
23.0k
          tag == kLumiTag) {
173
8.06k
        tagsize = 20;
174
8.06k
      }
175
176
23.0k
      if (command & kFlagBitOffset) {
177
6.62k
        if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
178
6.62k
        tagstart = DecodeVarInt(enc, size, &cpos);
179
16.4k
      } else {
180
16.4k
        JXL_RETURN_IF_ERROR(CheckIs32Bit(prevtagstart));
181
16.4k
        tagstart = prevtagstart + prevtagsize;
182
16.4k
      }
183
23.0k
      JXL_RETURN_IF_ERROR(CheckIs32Bit(tagstart));
184
23.0k
      JXL_RETURN_IF_ERROR(AppendUint32(tagstart, result));
185
23.0k
      if (command & kFlagBitSize) {
186
14.4k
        if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
187
14.4k
        tagsize = DecodeVarInt(enc, size, &cpos);
188
14.4k
      }
189
23.0k
      JXL_RETURN_IF_ERROR(CheckIs32Bit(tagsize));
190
23.0k
      JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
191
23.0k
      prevtagstart = tagstart;
192
23.0k
      prevtagsize = tagsize;
193
194
23.0k
      if (tagcode == kCommandTagTRC) {
195
2.05k
        JXL_RETURN_IF_ERROR(AppendKeyword(kGtrcTag, result));
196
2.05k
        JXL_RETURN_IF_ERROR(AppendUint32(tagstart, result));
197
2.05k
        JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
198
2.05k
        JXL_RETURN_IF_ERROR(AppendKeyword(kBtrcTag, result));
199
2.05k
        JXL_RETURN_IF_ERROR(AppendUint32(tagstart, result));
200
2.05k
        JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
201
2.05k
      }
202
203
23.0k
      if (tagcode == kCommandTagXYZ) {
204
174
        JXL_RETURN_IF_ERROR(CheckIs32Bit(tagstart + tagsize * 2));
205
174
        JXL_RETURN_IF_ERROR(AppendKeyword(kGxyzTag, result));
206
174
        JXL_RETURN_IF_ERROR(AppendUint32(tagstart + tagsize, result));
207
174
        JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
208
174
        JXL_RETURN_IF_ERROR(AppendKeyword(kBxyzTag, result));
209
174
        JXL_RETURN_IF_ERROR(AppendUint32(tagstart + tagsize * 2, result));
210
174
        JXL_RETURN_IF_ERROR(AppendUint32(tagsize, result));
211
174
      }
212
23.0k
    }
213
2.18k
  }
214
215
  // Main Content
216
41.3k
  for (;;) {
217
41.3k
    if (result->size() > osize) return JXL_FAILURE("Invalid result size");
218
41.3k
    if (cpos > commands_end) return JXL_FAILURE("Out of bounds");
219
41.3k
    if (cpos == commands_end) break;  // Valid end
220
39.1k
    uint8_t command = enc[cpos++];
221
39.1k
    if (command == kCommandInsert) {
222
10.0k
      if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
223
10.0k
      uint64_t num = DecodeVarInt(enc, size, &cpos);
224
10.0k
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, num, size));
225
7.81M
      for (size_t i = 0; i < num; i++) {
226
7.80M
        JXL_RETURN_IF_ERROR(result->push_back(enc[pos++]));
227
7.80M
      }
228
29.1k
    } else if (command == kCommandShuffle2 || command == kCommandShuffle4) {
229
8.11k
      if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
230
8.11k
      uint64_t num = DecodeVarInt(enc, size, &cpos);
231
8.11k
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, num, size));
232
8.11k
      PaddedBytes shuffled(memory_manager);
233
8.11k
      JXL_ASSIGN_OR_RETURN(shuffled,
234
8.11k
                           PaddedBytes::WithInitialSpace(memory_manager, num));
235
467k
      for (size_t i = 0; i < num; i++) {
236
459k
        shuffled[i] = enc[pos + i];
237
459k
      }
238
8.11k
      if (command == kCommandShuffle2) {
239
8.11k
        JXL_RETURN_IF_ERROR(Shuffle(memory_manager, shuffled.data(), num, 2));
240
8.11k
      } else if (command == kCommandShuffle4) {
241
0
        JXL_RETURN_IF_ERROR(Shuffle(memory_manager, shuffled.data(), num, 4));
242
0
      }
243
467k
      for (size_t i = 0; i < num; i++) {
244
459k
        JXL_RETURN_IF_ERROR(result->push_back(shuffled[i]));
245
459k
        pos++;
246
459k
      }
247
21.0k
    } else if (command == kCommandPredict) {
248
0
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(cpos, 2, commands_end));
249
0
      uint8_t flags = enc[cpos++];
250
251
0
      size_t width = (flags & 3) + 1;
252
0
      if (width == 3) return JXL_FAILURE("Invalid width");
253
254
0
      int order = (flags & 12) >> 2;
255
0
      if (order == 3) return JXL_FAILURE("Invalid order");
256
257
0
      uint64_t stride = width;
258
0
      if (flags & 16) {
259
0
        if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
260
0
        stride = DecodeVarInt(enc, size, &cpos);
261
0
        if (stride < width) {
262
0
          return JXL_FAILURE("Invalid stride");
263
0
        }
264
0
      }
265
      // If stride * 4 >= result->size(), return failure. The check
266
      // "size == 0 || ((size - 1) >> 2) < stride" corresponds to
267
      // "stride * 4 >= size", but does not suffer from integer overflow.
268
      // This check is more strict than necessary but follows the specification
269
      // and the encoder should ensure this is followed.
270
0
      if (result->empty() || ((result->size() - 1u) >> 2u) < stride) {
271
0
        return JXL_FAILURE("Invalid stride");
272
0
      }
273
274
0
      if (cpos >= commands_end) return JXL_FAILURE("Out of bounds");
275
0
      uint64_t num = DecodeVarInt(enc, size, &cpos);  // in bytes
276
0
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, num, size));
277
278
0
      PaddedBytes shuffled(memory_manager);
279
0
      JXL_ASSIGN_OR_RETURN(shuffled,
280
0
                           PaddedBytes::WithInitialSpace(memory_manager, num));
281
282
0
      for (size_t i = 0; i < num; i++) {
283
0
        shuffled[i] = enc[pos + i];
284
0
      }
285
0
      if (width > 1) {
286
0
        JXL_RETURN_IF_ERROR(
287
0
            Shuffle(memory_manager, shuffled.data(), num, width));
288
0
      }
289
290
0
      size_t start = result->size();
291
0
      for (size_t i = 0; i < num; i++) {
292
0
        uint8_t predicted = LinearPredictICCValue(result->data(), start, i,
293
0
                                                  stride, width, order);
294
0
        JXL_RETURN_IF_ERROR(result->push_back(predicted + shuffled[i]));
295
0
      }
296
0
      pos += num;
297
21.0k
    } else if (command == kCommandXYZ) {
298
8.41k
      JXL_RETURN_IF_ERROR(AppendKeyword(kXyz_Tag, result));
299
42.0k
      for (int i = 0; i < 4; i++) {
300
33.6k
        JXL_RETURN_IF_ERROR(result->push_back(0));
301
33.6k
      }
302
8.41k
      JXL_RETURN_IF_ERROR(CheckOutOfBounds(pos, 12, size));
303
109k
      for (size_t i = 0; i < 12; i++) {
304
100k
        JXL_RETURN_IF_ERROR(result->push_back(enc[pos++]));
305
100k
      }
306
12.5k
    } else if (command >= kCommandTypeStartFirst &&
307
12.5k
               command < kCommandTypeStartFirst + kNumTypeStrings) {
308
12.5k
      JXL_RETURN_IF_ERROR(AppendKeyword(
309
12.5k
          *kTypeStrings[command - kCommandTypeStartFirst], result));
310
62.9k
      for (size_t i = 0; i < 4; i++) {
311
50.3k
        JXL_RETURN_IF_ERROR(result->push_back(0));
312
50.3k
      }
313
12.5k
    } else {
314
0
      return JXL_FAILURE("Unknown command");
315
0
    }
316
39.1k
  }
317
318
2.18k
  if (pos != size) return JXL_FAILURE("Not all data used");
319
2.18k
  if (result->size() != osize) return JXL_FAILURE("Invalid result size");
320
321
2.18k
  return true;
322
2.18k
}
323
324
2.33k
Status ICCReader::Init(BitReader* reader) {
325
2.33k
  JXL_RETURN_IF_ERROR(CheckEOI(reader));
326
2.33k
  JxlMemoryManager* memory_manager = decompressed_.memory_manager();
327
2.33k
  used_bits_base_ = reader->TotalBitsConsumed();
328
2.33k
  if (bits_to_skip_ == 0) {
329
2.20k
    enc_size_ = U64Coder::Read(reader);
330
2.20k
    if (enc_size_ > 268435456) {
331
      // Avoid too large memory allocation for invalid file.
332
0
      return JXL_FAILURE("Too large encoded profile");
333
0
    }
334
2.20k
    JXL_RETURN_IF_ERROR(DecodeHistograms(
335
2.20k
        memory_manager, reader, kNumICCContexts, &code_, &context_map_));
336
4.39k
    JXL_ASSIGN_OR_RETURN(ans_reader_, ANSSymbolReader::Create(&code_, reader));
337
4.39k
    i_ = 0;
338
4.39k
    JXL_RETURN_IF_ERROR(
339
4.39k
        decompressed_.resize(std::min<size_t>(i_ + 0x400, enc_size_)));
340
6.59k
    for (; i_ < std::min<size_t>(2, enc_size_); i_++) {
341
4.39k
      decompressed_[i_] = ans_reader_.ReadHybridUint(
342
4.39k
          ICCANSContext(i_, i_ > 0 ? decompressed_[i_ - 1] : 0,
343
4.39k
                        i_ > 1 ? decompressed_[i_ - 2] : 0),
344
4.39k
          reader, context_map_);
345
4.39k
    }
346
2.19k
    if (enc_size_ > kPreambleSize) {
347
46.1k
      for (; i_ < kPreambleSize; i_++) {
348
43.9k
        decompressed_[i_] = ans_reader_.ReadHybridUint(
349
43.9k
            ICCANSContext(i_, decompressed_[i_ - 1], decompressed_[i_ - 2]),
350
43.9k
            reader, context_map_);
351
43.9k
      }
352
2.19k
      JXL_RETURN_IF_ERROR(CheckEOI(reader));
353
2.19k
      JXL_RETURN_IF_ERROR(CheckPreamble(decompressed_, enc_size_));
354
2.19k
    }
355
2.19k
    bits_to_skip_ = reader->TotalBitsConsumed() - used_bits_base_;
356
2.19k
  } else {
357
134
    reader->SkipBits(bits_to_skip_);
358
134
  }
359
2.33k
  return true;
360
2.33k
}
361
362
2.33k
Status ICCReader::Process(BitReader* reader, PaddedBytes* icc) {
363
2.33k
  ANSSymbolReader::Checkpoint checkpoint;
364
2.33k
  size_t saved_i = 0;
365
28.0k
  auto save = [&]() {
366
28.0k
    ans_reader_.Save(&checkpoint);
367
28.0k
    bits_to_skip_ = reader->TotalBitsConsumed() - used_bits_base_;
368
28.0k
    saved_i = i_;
369
28.0k
  };
370
2.33k
  save();
371
28.0k
  auto check_and_restore = [&]() {
372
28.0k
    Status status = CheckEOI(reader);
373
28.0k
    if (!status) {
374
      // not enough bytes.
375
143
      ans_reader_.Restore(checkpoint);
376
143
      i_ = saved_i;
377
143
      return status;
378
143
    }
379
27.8k
    return Status(true);
380
28.0k
  };
381
13.4M
  for (; i_ < enc_size_; i_++) {
382
13.4M
    if (i_ % ANSSymbolReader::kMaxCheckpointInterval == 0 && i_ > 0) {
383
25.7k
      JXL_RETURN_IF_ERROR(check_and_restore());
384
25.6k
      save();
385
25.6k
      if ((i_ > 0) && (((i_ & 0xFFFF) == 0))) {
386
132
        float used_bytes =
387
132
            (reader->TotalBitsConsumed() - used_bits_base_) / 8.0f;
388
132
        if (i_ > used_bytes * 256) return JXL_FAILURE("Corrupted stream");
389
132
      }
390
25.6k
      JXL_RETURN_IF_ERROR(
391
25.6k
          decompressed_.resize(std::min<size_t>(i_ + 0x400, enc_size_)));
392
25.6k
    }
393
13.4M
    JXL_ENSURE(i_ >= 2);
394
13.4M
    decompressed_[i_] = ans_reader_.ReadHybridUint(
395
13.4M
        ICCANSContext(i_, decompressed_[i_ - 1], decompressed_[i_ - 2]), reader,
396
13.4M
        context_map_);
397
13.4M
  }
398
2.32k
  JXL_RETURN_IF_ERROR(check_and_restore());
399
2.18k
  bits_to_skip_ = reader->TotalBitsConsumed() - used_bits_base_;
400
2.18k
  if (!ans_reader_.CheckANSFinalState()) {
401
0
    return JXL_FAILURE("Corrupted ICC profile");
402
0
  }
403
404
2.18k
  icc->clear();
405
2.18k
  return UnpredictICC(decompressed_.data(), decompressed_.size(), icc);
406
2.18k
}
407
408
32.5k
Status ICCReader::CheckEOI(BitReader* reader) {
409
32.5k
  if (reader->AllReadsWithinBounds()) return true;
410
143
  return JXL_STATUS(StatusCode::kNotEnoughBytes,
411
32.5k
                    "Not enough bytes for reading ICC profile");
412
32.5k
}
413
414
}  // namespace jxl