Coverage Report

Created: 2026-05-29 06:46

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/mosquitto/lib/handle_suback.c
Line
Count
Source
1
/*
2
Copyright (c) 2009-2021 Roger Light <roger@atchoo.org>
3
4
All rights reserved. This program and the accompanying materials
5
are made available under the terms of the Eclipse Public License 2.0
6
and Eclipse Distribution License v1.0 which accompany this distribution.
7
8
The Eclipse Public License is available at
9
   https://www.eclipse.org/legal/epl-2.0/
10
and the Eclipse Distribution License is available at
11
  http://www.eclipse.org/org/documents/edl-v10.php.
12
13
SPDX-License-Identifier: EPL-2.0 OR BSD-3-Clause
14
15
Contributors:
16
   Roger Light - initial implementation and documentation.
17
*/
18
19
#include "config.h"
20
21
#include <assert.h>
22
23
#ifdef WITH_BROKER
24
#  include "mosquitto_broker_internal.h"
25
#endif
26
27
#include "callbacks.h"
28
#include "mosquitto.h"
29
#include "mosquitto_internal.h"
30
#include "logging_mosq.h"
31
#include "mosquitto/mqtt_protocol.h"
32
#include "packet_mosq.h"
33
#include "property_mosq.h"
34
#include "read_handle.h"
35
#include "util_mosq.h"
36
37
38
int handle__suback(struct mosquitto *mosq)
39
95
{
40
95
  uint16_t mid;
41
95
  uint8_t qos;
42
95
  int *granted_qos;
43
95
  int qos_count;
44
95
  int i = 0;
45
95
  int rc;
46
95
  mosquitto_property *properties = NULL;
47
48
95
  assert(mosq);
49
50
95
  if(mosquitto__get_state(mosq) != mosq_cs_active){
51
8
#ifdef WITH_BROKER
52
8
    log__printf(NULL, MOSQ_LOG_INFO, "Protocol error from %s: SUBACK before session is active.", mosq->id);
53
8
#endif
54
8
    return MOSQ_ERR_PROTOCOL;
55
8
  }
56
87
  if(mosq->in_packet.command != CMD_SUBACK){
57
4
    return MOSQ_ERR_MALFORMED_PACKET;
58
4
  }
59
60
83
#ifdef WITH_BROKER
61
83
  if(mosq->bridge == NULL){
62
    /* Client is not a bridge, so shouldn't be sending SUBACK */
63
0
    log__printf(NULL, MOSQ_LOG_INFO, "Protocol error from %s: SUBACK when not a bridge.", mosq->id);
64
0
    return MOSQ_ERR_PROTOCOL;
65
0
  }
66
83
  log__printf(NULL, MOSQ_LOG_DEBUG, "Received SUBACK from %s", SAFE_PRINT(mosq->id));
67
#else
68
  log__printf(mosq, MOSQ_LOG_DEBUG, "Client %s received SUBACK", SAFE_PRINT(mosq->id));
69
#endif
70
83
  rc = packet__read_uint16(&mosq->in_packet, &mid);
71
83
  if(rc){
72
1
    return rc;
73
1
  }
74
82
  if(mid == 0){
75
1
    return MOSQ_ERR_PROTOCOL;
76
1
  }
77
78
81
  if(mosq->protocol == mosq_p_mqtt5){
79
38
    rc = property__read_all(CMD_SUBACK, &mosq->in_packet, &properties);
80
38
    if(rc){
81
20
      return rc;
82
20
    }
83
38
  }
84
85
61
  qos_count = (int)(mosq->in_packet.remaining_length - mosq->in_packet.pos);
86
61
  if(qos_count == 0){
87
18
    mosquitto_property_free_all(&properties);
88
18
    return MOSQ_ERR_PROTOCOL;
89
18
  }
90
43
  granted_qos = mosquitto_malloc((size_t)qos_count*sizeof(int));
91
43
  if(!granted_qos){
92
0
    mosquitto_property_free_all(&properties);
93
0
    return MOSQ_ERR_NOMEM;
94
0
  }
95
5.78M
  while(mosq->in_packet.pos < mosq->in_packet.remaining_length){
96
5.78M
    rc = packet__read_byte(&mosq->in_packet, &qos);
97
5.78M
    if(rc){
98
0
      mosquitto_FREE(granted_qos);
99
0
      mosquitto_property_free_all(&properties);
100
0
      return rc;
101
0
    }
102
5.78M
    granted_qos[i] = (int)qos;
103
5.78M
    i++;
104
5.78M
  }
105
43
#ifdef WITH_BROKER
106
  /* Immediately free, we don't do anything with Reason String or User Property at the moment */
107
43
  mosquitto_property_free_all(&properties);
108
#else
109
  callback__on_subscribe(mosq, mid, qos_count, granted_qos, properties);
110
  mosquitto_property_free_all(&properties);
111
#endif
112
43
  mosquitto_FREE(granted_qos);
113
114
43
  return MOSQ_ERR_SUCCESS;
115
43
}