Coverage Report

Created: 2026-08-31 06:09

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/openssh/kex-names.c
Line
Count
Source
1
/* $OpenBSD: kex-names.c,v 1.10 2026/08/08 07:27:54 djm Exp $ */
2
/*
3
 * Copyright (c) 2000, 2001 Markus Friedl.  All rights reserved.
4
 *
5
 * Redistribution and use in source and binary forms, with or without
6
 * modification, are permitted provided that the following conditions
7
 * are met:
8
 * 1. Redistributions of source code must retain the above copyright
9
 *    notice, this list of conditions and the following disclaimer.
10
 * 2. Redistributions in binary form must reproduce the above copyright
11
 *    notice, this list of conditions and the following disclaimer in the
12
 *    documentation and/or other materials provided with the distribution.
13
 *
14
 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
15
 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
16
 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
17
 * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
18
 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
19
 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
20
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
21
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23
 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24
 */
25
26
#include "includes.h"
27
28
#include <stdio.h>
29
#include <stdlib.h>
30
#include <string.h>
31
#include <signal.h>
32
33
#ifdef WITH_OPENSSL
34
#include <openssl/crypto.h>
35
#include <openssl/evp.h>
36
#endif
37
38
#include "kex.h"
39
#include "log.h"
40
#include "match.h"
41
#include "digest.h"
42
#include "misc.h"
43
44
#include "ssherr.h"
45
46
struct kexalg {
47
  char *name;
48
  u_int type;
49
  int ec_nid;
50
  int hash_alg;
51
  int pq_alg;
52
};
53
static const struct kexalg kexalgs[] = {
54
#ifdef WITH_OPENSSL
55
  { KEX_DH1, KEX_DH_GRP1_SHA1, 0, SSH_DIGEST_SHA1, KEX_NOT_PQ },
56
  { KEX_DH14_SHA1, KEX_DH_GRP14_SHA1, 0, SSH_DIGEST_SHA1, KEX_NOT_PQ },
57
  { KEX_DH14_SHA256, KEX_DH_GRP14_SHA256, 0, SSH_DIGEST_SHA256, KEX_NOT_PQ },
58
  { KEX_DH16_SHA512, KEX_DH_GRP16_SHA512, 0, SSH_DIGEST_SHA512, KEX_NOT_PQ },
59
  { KEX_DH18_SHA512, KEX_DH_GRP18_SHA512, 0, SSH_DIGEST_SHA512, KEX_NOT_PQ },
60
  { KEX_DHGEX_SHA1, KEX_DH_GEX_SHA1, 0, SSH_DIGEST_SHA1, KEX_NOT_PQ },
61
# ifdef HAVE_EVP_SHA256
62
  { KEX_DHGEX_SHA256, KEX_DH_GEX_SHA256, 0, SSH_DIGEST_SHA256, KEX_NOT_PQ },
63
# endif /* HAVE_EVP_SHA256 */
64
  { KEX_ECDH_SHA2_NISTP256, KEX_ECDH_SHA2,
65
      NID_X9_62_prime256v1, SSH_DIGEST_SHA256, KEX_NOT_PQ },
66
  { KEX_ECDH_SHA2_NISTP384, KEX_ECDH_SHA2, NID_secp384r1,
67
      SSH_DIGEST_SHA384, KEX_NOT_PQ },
68
  { KEX_ECDH_SHA2_NISTP521, KEX_ECDH_SHA2, NID_secp521r1,
69
      SSH_DIGEST_SHA512, KEX_NOT_PQ },
70
  { KEX_MLKEM768NISTP256_SHA256, KEX_KEM_MLKEM768ECDH_SHA256,
71
      NID_X9_62_prime256v1, SSH_DIGEST_SHA256, KEX_IS_PQ },
72
#endif /* WITH_OPENSSL */
73
#if defined(HAVE_EVP_SHA256) || !defined(WITH_OPENSSL)
74
  { KEX_CURVE25519_SHA256, KEX_C25519_SHA256, 0, SSH_DIGEST_SHA256, KEX_NOT_PQ },
75
  { KEX_CURVE25519_SHA256_OLD, KEX_C25519_SHA256, 0, SSH_DIGEST_SHA256, KEX_NOT_PQ },
76
#ifdef USE_SNTRUP761X25519
77
  { KEX_SNTRUP761X25519_SHA512, KEX_KEM_SNTRUP761X25519_SHA512, 0,
78
      SSH_DIGEST_SHA512, KEX_IS_PQ },
79
  { KEX_SNTRUP761X25519_SHA512_OLD, KEX_KEM_SNTRUP761X25519_SHA512, 0,
80
      SSH_DIGEST_SHA512, KEX_IS_PQ },
81
#endif
82
#ifdef USE_MLKEM768X25519
83
  { KEX_MLKEM768X25519_SHA256, KEX_KEM_MLKEM768X25519_SHA256, 0,
84
      SSH_DIGEST_SHA256, KEX_IS_PQ },
85
#endif
86
#endif /* HAVE_EVP_SHA256 || !WITH_OPENSSL */
87
  { NULL, 0, -1, -1, 0 },
88
};
89
90
char *
91
kex_alg_list(char sep)
92
0
{
93
0
  char *ret = NULL;
94
0
  const struct kexalg *k;
95
0
  char sep_str[2] = {sep, '\0'};
96
97
0
  for (k = kexalgs; k->name != NULL; k++)
98
0
    xextendf(&ret, sep_str, "%s", k->name);
99
100
0
  return ret;
101
0
}
102
103
static const struct kexalg *
104
kex_alg_by_name(const char *name)
105
0
{
106
0
  const struct kexalg *k;
107
108
0
  for (k = kexalgs; k->name != NULL; k++) {
109
0
    if (strcmp(k->name, name) == 0)
110
0
      return k;
111
0
  }
112
0
  return NULL;
113
0
}
114
115
int
116
kex_name_valid(const char *name)
117
0
{
118
0
  return kex_alg_by_name(name) != NULL;
119
0
}
120
121
int
122
kex_is_pq_from_name(const char *name)
123
0
{
124
0
  const struct kexalg *k;
125
126
0
  if ((k = kex_alg_by_name(name)) == NULL)
127
0
    return 0;
128
0
  return k->pq_alg == KEX_IS_PQ;
129
0
}
130
131
u_int
132
kex_type_from_name(const char *name)
133
0
{
134
0
  const struct kexalg *k;
135
136
0
  if ((k = kex_alg_by_name(name)) == NULL)
137
0
    return 0;
138
0
  return k->type;
139
0
}
140
141
int
142
kex_hash_from_name(const char *name)
143
0
{
144
0
  const struct kexalg *k;
145
146
0
  if ((k = kex_alg_by_name(name)) == NULL)
147
0
    return -1;
148
0
  return k->hash_alg;
149
0
}
150
151
int
152
kex_nid_from_name(const char *name)
153
0
{
154
0
  const struct kexalg *k;
155
156
0
  if ((k = kex_alg_by_name(name)) == NULL)
157
0
    return -1;
158
0
  return k->ec_nid;
159
0
}
160
161
/* Validate KEX method name list */
162
int
163
kex_names_valid(const char *names)
164
0
{
165
0
  char *s, *cp, *p;
166
167
0
  if (names == NULL || strcmp(names, "") == 0)
168
0
    return 0;
169
0
  if ((s = cp = strdup(names)) == NULL)
170
0
    return 0;
171
0
  for ((p = strsep(&cp, ",")); p && *p != '\0';
172
0
      (p = strsep(&cp, ","))) {
173
0
    if (kex_alg_by_name(p) == NULL) {
174
0
      error("Unsupported KEX algorithm \"%.100s\"", p);
175
0
      free(s);
176
0
      return 0;
177
0
    }
178
0
  }
179
0
  debug3("kex names ok: [%s]", names);
180
0
  free(s);
181
0
  return 1;
182
0
}
183
184
/* returns non-zero if proposal contains any algorithm from algs */
185
int
186
kex_has_any_alg(const char *proposal, const char *algs)
187
0
{
188
0
  char *cp;
189
190
0
  if ((cp = match_list(proposal, algs, NULL)) == NULL)
191
0
    return 0;
192
0
  free(cp);
193
0
  return 1;
194
0
}
195
196
/*
197
 * Concatenate algorithm names, avoiding duplicates in the process.
198
 * Caller must free returned string.
199
 */
200
char *
201
kex_names_cat(const char *a, const char *b)
202
0
{
203
0
  char *ret = NULL, *tmp = NULL, *cp, *p;
204
0
  size_t len;
205
206
0
  if (a == NULL || *a == '\0')
207
0
    return strdup(b);
208
0
  if (b == NULL || *b == '\0')
209
0
    return strdup(a);
210
0
  if (strlen(b) > 1024*1024)
211
0
    return NULL;
212
0
  len = strlen(a) + strlen(b) + 2;
213
0
  if ((tmp = cp = strdup(b)) == NULL ||
214
0
      (ret = calloc(1, len)) == NULL) {
215
0
    free(tmp);
216
0
    return NULL;
217
0
  }
218
0
  strlcpy(ret, a, len);
219
0
  for ((p = strsep(&cp, ",")); p && *p != '\0'; (p = strsep(&cp, ","))) {
220
0
    if (kex_has_any_alg(ret, p))
221
0
      continue; /* Algorithm already present */
222
0
    if (strlcat(ret, ",", len) >= len ||
223
0
        strlcat(ret, p, len) >= len) {
224
0
      free(tmp);
225
0
      free(ret);
226
0
      return NULL; /* Shouldn't happen */
227
0
    }
228
0
  }
229
0
  free(tmp);
230
0
  return ret;
231
0
}
232
233
/*
234
 * Assemble a list of algorithms from a default list and a string from a
235
 * configuration file. The user-provided string may begin with '+' to
236
 * indicate that it should be appended to the default, '-' that the
237
 * specified names should be removed, or '^' that they should be placed
238
 * at the head.
239
 */
240
int
241
kex_assemble_names(char **listp, const char *def, const char *all)
242
0
{
243
0
  char *cp, *tmp, *patterns;
244
0
  char *list = NULL, *ret = NULL, *matching = NULL, *opatterns = NULL;
245
0
  int r = SSH_ERR_INTERNAL_ERROR;
246
247
0
  if (listp == NULL || def == NULL || all == NULL)
248
0
    return SSH_ERR_INVALID_ARGUMENT;
249
250
0
  if (*listp == NULL || **listp == '\0') {
251
0
    if ((*listp = strdup(def)) == NULL)
252
0
      return SSH_ERR_ALLOC_FAIL;
253
0
    return 0;
254
0
  }
255
256
0
  list = *listp;
257
0
  *listp = NULL;
258
0
  if (*list == '+') {
259
    /* Append names to default list */
260
0
    if ((tmp = kex_names_cat(def, list + 1)) == NULL) {
261
0
      r = SSH_ERR_ALLOC_FAIL;
262
0
      goto fail;
263
0
    }
264
0
    free(list);
265
0
    list = tmp;
266
0
  } else if (*list == '-') {
267
    /* Remove names from default list */
268
0
    if ((*listp = match_filter_denylist(def, list + 1)) == NULL) {
269
0
      r = SSH_ERR_ALLOC_FAIL;
270
0
      goto fail;
271
0
    }
272
0
    free(list);
273
    /* filtering has already been done */
274
0
    return 0;
275
0
  } else if (*list == '^') {
276
    /* Place names at head of default list */
277
0
    if ((tmp = kex_names_cat(list + 1, def)) == NULL) {
278
0
      r = SSH_ERR_ALLOC_FAIL;
279
0
      goto fail;
280
0
    }
281
0
    free(list);
282
0
    list = tmp;
283
0
  } else {
284
    /* Explicit list, overrides default - just use "list" as is */
285
0
  }
286
287
  /*
288
   * The supplied names may be a pattern-list. For the -list case,
289
   * the patterns are applied above. For the +list and explicit list
290
   * cases we need to do it now.
291
   */
292
0
  ret = NULL;
293
0
  if ((patterns = opatterns = strdup(list)) == NULL) {
294
0
    r = SSH_ERR_ALLOC_FAIL;
295
0
    goto fail;
296
0
  }
297
  /* Apply positive (i.e. non-negated) patterns from the list */
298
0
  while ((cp = strsep(&patterns, ",")) != NULL) {
299
0
    if (*cp == '!') {
300
      /* negated matches are not supported here */
301
0
      r = SSH_ERR_INVALID_ARGUMENT;
302
0
      goto fail;
303
0
    }
304
0
    free(matching);
305
0
    if ((matching = match_filter_allowlist(all, cp)) == NULL) {
306
0
      r = SSH_ERR_ALLOC_FAIL;
307
0
      goto fail;
308
0
    }
309
0
    if ((tmp = kex_names_cat(ret, matching)) == NULL) {
310
0
      r = SSH_ERR_ALLOC_FAIL;
311
0
      goto fail;
312
0
    }
313
0
    free(ret);
314
0
    ret = tmp;
315
0
  }
316
0
  if (ret == NULL || *ret == '\0') {
317
    /* An empty name-list is an error */
318
    /* XXX better error code? */
319
0
    r = SSH_ERR_INVALID_ARGUMENT;
320
0
    goto fail;
321
0
  }
322
323
  /* success */
324
0
  *listp = ret;
325
0
  ret = NULL;
326
0
  r = 0;
327
328
0
 fail:
329
0
  free(matching);
330
0
  free(opatterns);
331
0
  free(list);
332
0
  free(ret);
333
0
  return r;
334
0
}