Coverage Report

Created: 2023-06-08 06:41

/src/openssl30/crypto/cmp/cmp_vfy.c
Line
Count
Source (jump to first uncovered line)
1
/*
2
 * Copyright 2007-2023 The OpenSSL Project Authors. All Rights Reserved.
3
 * Copyright Nokia 2007-2020
4
 * Copyright Siemens AG 2015-2020
5
 *
6
 * Licensed under the Apache License 2.0 (the "License").  You may not use
7
 * this file except in compliance with the License.  You can obtain a copy
8
 * in the file LICENSE in the source distribution or at
9
 * https://www.openssl.org/source/license.html
10
 */
11
12
/* CMP functions for PKIMessage checking */
13
14
#include "cmp_local.h"
15
#include <openssl/cmp_util.h>
16
17
/* explicit #includes not strictly needed since implied by the above: */
18
#include <openssl/asn1t.h>
19
#include <openssl/cmp.h>
20
#include <openssl/crmf.h>
21
#include <openssl/err.h>
22
#include <openssl/x509.h>
23
24
/* Verify a message protected by signature according to RFC section 5.1.3.3 */
25
static int verify_signature(const OSSL_CMP_CTX *cmp_ctx,
26
                            const OSSL_CMP_MSG *msg, X509 *cert)
27
0
{
28
0
    OSSL_CMP_PROTECTEDPART prot_part;
29
0
    EVP_PKEY *pubkey = NULL;
30
0
    BIO *bio;
31
0
    int res = 0;
32
33
0
    if (!ossl_assert(cmp_ctx != NULL && msg != NULL && cert != NULL))
34
0
        return 0;
35
36
0
    bio = BIO_new(BIO_s_mem()); /* may be NULL */
37
38
    /* verify that keyUsage, if present, contains digitalSignature */
39
0
    if (!cmp_ctx->ignore_keyusage
40
0
            && (X509_get_key_usage(cert) & X509v3_KU_DIGITAL_SIGNATURE) == 0) {
41
0
        ERR_raise(ERR_LIB_CMP, CMP_R_MISSING_KEY_USAGE_DIGITALSIGNATURE);
42
0
        goto sig_err;
43
0
    }
44
45
0
    pubkey = X509_get_pubkey(cert);
46
0
    if (pubkey == NULL) {
47
0
        ERR_raise(ERR_LIB_CMP, CMP_R_FAILED_EXTRACTING_PUBKEY);
48
0
        goto sig_err;
49
0
    }
50
51
0
    prot_part.header = msg->header;
52
0
    prot_part.body = msg->body;
53
54
0
    if (ASN1_item_verify_ex(ASN1_ITEM_rptr(OSSL_CMP_PROTECTEDPART),
55
0
                            msg->header->protectionAlg, msg->protection,
56
0
                            &prot_part, NULL, pubkey, cmp_ctx->libctx,
57
0
                            cmp_ctx->propq) > 0) {
58
0
        res = 1;
59
0
        goto end;
60
0
    }
61
62
0
 sig_err:
63
0
    res = ossl_x509_print_ex_brief(bio, cert, X509_FLAG_NO_EXTENSIONS);
64
0
    ERR_raise(ERR_LIB_CMP, CMP_R_ERROR_VALIDATING_SIGNATURE);
65
0
    if (res)
66
0
        ERR_add_error_mem_bio("\n", bio);
67
0
    res = 0;
68
69
0
 end:
70
0
    EVP_PKEY_free(pubkey);
71
0
    BIO_free(bio);
72
73
0
    return res;
74
0
}
75
76
/* Verify a message protected with PBMAC */
77
static int verify_PBMAC(OSSL_CMP_CTX *ctx, const OSSL_CMP_MSG *msg)
78
191
{
79
191
    ASN1_BIT_STRING *protection = NULL;
80
191
    int valid = 0;
81
82
    /* generate expected protection for the message */
83
191
    if ((protection = ossl_cmp_calc_protection(ctx, msg)) == NULL)
84
122
        return 0; /* failed to generate protection string! */
85
86
69
    valid = msg->protection != NULL && msg->protection->length >= 0
87
69
            && msg->protection->type == protection->type
88
69
            && msg->protection->length == protection->length
89
69
            && CRYPTO_memcmp(msg->protection->data, protection->data,
90
37
                             protection->length) == 0;
91
69
    ASN1_BIT_STRING_free(protection);
92
69
    if (!valid)
93
69
        ERR_raise(ERR_LIB_CMP, CMP_R_WRONG_PBM_VALUE);
94
95
69
    return valid;
96
191
}
97
98
/*-
99
 * Attempt to validate certificate and path using any given store with trusted
100
 * certs (possibly including CRLs and a cert verification callback function)
101
 * and non-trusted intermediate certs from the given ctx.
102
 *
103
 * Returns 1 on successful validation and 0 otherwise.
104
 */
105
int OSSL_CMP_validate_cert_path(const OSSL_CMP_CTX *ctx,
106
                                X509_STORE *trusted_store, X509 *cert)
107
0
{
108
0
    int valid = 0;
109
0
    X509_STORE_CTX *csc = NULL;
110
0
    int err;
111
112
0
    if (ctx == NULL || cert == NULL) {
113
0
        ERR_raise(ERR_LIB_CMP, CMP_R_NULL_ARGUMENT);
114
0
        return 0;
115
0
    }
116
117
0
    if (trusted_store == NULL) {
118
0
        ERR_raise(ERR_LIB_CMP, CMP_R_MISSING_TRUST_STORE);
119
0
        return 0;
120
0
    }
121
122
0
    if ((csc = X509_STORE_CTX_new_ex(ctx->libctx, ctx->propq)) == NULL
123
0
            || !X509_STORE_CTX_init(csc, trusted_store,
124
0
                                    cert, ctx->untrusted))
125
0
        goto err;
126
127
0
    valid = X509_verify_cert(csc) > 0;
128
129
    /* make sure suitable error is queued even if callback did not do */
130
0
    err = ERR_peek_last_error();
131
0
    if (!valid && ERR_GET_REASON(err) != CMP_R_POTENTIALLY_INVALID_CERTIFICATE)
132
0
        ERR_raise(ERR_LIB_CMP, CMP_R_POTENTIALLY_INVALID_CERTIFICATE);
133
134
0
 err:
135
    /* directly output any fresh errors, needed for check_msg_find_cert() */
136
0
    OSSL_CMP_CTX_print_errors(ctx);
137
0
    X509_STORE_CTX_free(csc);
138
0
    return valid;
139
0
}
140
141
/* Return 0 if expect_name != NULL and there is no matching actual_name */
142
static int check_name(const OSSL_CMP_CTX *ctx, int log_success,
143
                      const char *actual_desc, const X509_NAME *actual_name,
144
                      const char *expect_desc, const X509_NAME *expect_name)
145
4.89k
{
146
4.89k
    char *str;
147
148
4.89k
    if (expect_name == NULL)
149
4.89k
        return 1; /* no expectation, thus trivially fulfilled */
150
151
    /* make sure that a matching name is there */
152
0
    if (actual_name == NULL) {
153
0
        ossl_cmp_log1(WARN, ctx, "missing %s", actual_desc);
154
0
        return 0;
155
0
    }
156
0
    str = X509_NAME_oneline(actual_name, NULL, 0);
157
0
    if (X509_NAME_cmp(actual_name, expect_name) == 0) {
158
0
        if (log_success && str != NULL)
159
0
            ossl_cmp_log2(INFO, ctx, " subject matches %s: %s", expect_desc,
160
0
                          str);
161
0
        OPENSSL_free(str);
162
0
        return 1;
163
0
    }
164
165
0
    if (str != NULL)
166
0
        ossl_cmp_log2(INFO, ctx, " actual name in %s = %s", actual_desc, str);
167
0
    OPENSSL_free(str);
168
0
    if ((str = X509_NAME_oneline(expect_name, NULL, 0)) != NULL)
169
0
        ossl_cmp_log2(INFO, ctx, " does not match %s = %s", expect_desc, str);
170
0
    OPENSSL_free(str);
171
0
    return 0;
172
0
}
173
174
/* Return 0 if skid != NULL and there is no matching subject key ID in cert */
175
static int check_kid(const OSSL_CMP_CTX *ctx,
176
                     const ASN1_OCTET_STRING *ckid,
177
                     const ASN1_OCTET_STRING *skid)
178
0
{
179
0
    char *str;
180
181
0
    if (skid == NULL)
182
0
        return 1; /* no expectation, thus trivially fulfilled */
183
184
    /* make sure that the expected subject key identifier is there */
185
0
    if (ckid == NULL) {
186
0
        ossl_cmp_warn(ctx, "missing Subject Key Identifier in certificate");
187
0
        return 0;
188
0
    }
189
0
    str = OPENSSL_buf2hexstr(ckid->data, ckid->length);
190
0
    if (ASN1_OCTET_STRING_cmp(ckid, skid) == 0) {
191
0
        if (str != NULL)
192
0
            ossl_cmp_log1(INFO, ctx, " subjectKID matches senderKID: %s", str);
193
0
        OPENSSL_free(str);
194
0
        return 1;
195
0
    }
196
197
0
    if (str != NULL)
198
0
        ossl_cmp_log1(INFO, ctx, " cert Subject Key Identifier = %s", str);
199
0
    OPENSSL_free(str);
200
0
    if ((str = OPENSSL_buf2hexstr(skid->data, skid->length)) != NULL)
201
0
        ossl_cmp_log1(INFO, ctx, " does not match senderKID    = %s", str);
202
0
    OPENSSL_free(str);
203
0
    return 0;
204
0
}
205
206
static int already_checked(const X509 *cert,
207
                           const STACK_OF(X509) *already_checked)
208
0
{
209
0
    int i;
210
211
0
    for (i = sk_X509_num(already_checked /* may be NULL */); i > 0; i--)
212
0
        if (X509_cmp(sk_X509_value(already_checked, i - 1), cert) == 0)
213
0
            return 1;
214
0
    return 0;
215
0
}
216
217
/*-
218
 * Check if the given cert is acceptable as sender cert of the given message.
219
 * The subject DN must match, the subject key ID as well if present in the msg,
220
 * and the cert must be current (checked if ctx->trusted is not NULL).
221
 * Note that cert revocation etc. is checked by OSSL_CMP_validate_cert_path().
222
 *
223
 * Returns 0 on error or not acceptable, else 1.
224
 */
225
static int cert_acceptable(const OSSL_CMP_CTX *ctx,
226
                           const char *desc1, const char *desc2, X509 *cert,
227
                           const STACK_OF(X509) *already_checked1,
228
                           const STACK_OF(X509) *already_checked2,
229
                           const OSSL_CMP_MSG *msg)
230
0
{
231
0
    X509_STORE *ts = ctx->trusted;
232
0
    int self_issued = X509_check_issued(cert, cert) == X509_V_OK;
233
0
    char *str;
234
0
    X509_VERIFY_PARAM *vpm = ts != NULL ? X509_STORE_get0_param(ts) : NULL;
235
0
    int time_cmp;
236
237
0
    ossl_cmp_log3(INFO, ctx, " considering %s%s %s with..",
238
0
                  self_issued ? "self-issued ": "", desc1, desc2);
239
0
    if ((str = X509_NAME_oneline(X509_get_subject_name(cert), NULL, 0)) != NULL)
240
0
        ossl_cmp_log1(INFO, ctx, "  subject = %s", str);
241
0
    OPENSSL_free(str);
242
0
    if (!self_issued) {
243
0
        str = X509_NAME_oneline(X509_get_issuer_name(cert), NULL, 0);
244
0
        if (str != NULL)
245
0
            ossl_cmp_log1(INFO, ctx, "  issuer  = %s", str);
246
0
        OPENSSL_free(str);
247
0
    }
248
249
0
    if (already_checked(cert, already_checked1)
250
0
            || already_checked(cert, already_checked2)) {
251
0
        ossl_cmp_info(ctx, " cert has already been checked");
252
0
        return 0;
253
0
    }
254
255
0
    time_cmp = X509_cmp_timeframe(vpm, X509_get0_notBefore(cert),
256
0
                                  X509_get0_notAfter(cert));
257
0
    if (time_cmp != 0) {
258
0
        ossl_cmp_warn(ctx, time_cmp > 0 ? "cert has expired"
259
0
                                        : "cert is not yet valid");
260
0
        return 0;
261
0
    }
262
263
0
    if (!check_name(ctx, 1,
264
0
                    "cert subject", X509_get_subject_name(cert),
265
0
                    "sender field", msg->header->sender->d.directoryName))
266
0
        return 0;
267
268
0
    if (!check_kid(ctx, X509_get0_subject_key_id(cert), msg->header->senderKID))
269
0
        return 0;
270
    /* prevent misleading error later in case x509v3_cache_extensions() fails */
271
0
    if (!ossl_x509v3_cache_extensions(cert)) {
272
0
        ossl_cmp_warn(ctx, "cert appears to be invalid");
273
0
        return 0;
274
0
    }
275
0
    if (!verify_signature(ctx, msg, cert)) {
276
0
        ossl_cmp_warn(ctx, "msg signature verification failed");
277
0
        return 0;
278
0
    }
279
    /* acceptable also if there is no senderKID in msg header */
280
0
    ossl_cmp_info(ctx, " cert seems acceptable");
281
0
    return 1;
282
0
}
283
284
static int check_cert_path(const OSSL_CMP_CTX *ctx, X509_STORE *store,
285
                           X509 *scrt)
286
0
{
287
0
    if (OSSL_CMP_validate_cert_path(ctx, store, scrt))
288
0
        return 1;
289
290
0
    ossl_cmp_warn(ctx,
291
0
                  "msg signature validates but cert path validation failed");
292
0
    return 0;
293
0
}
294
295
/*
296
 * Exceptional handling for 3GPP TS 33.310 [3G/LTE Network Domain Security
297
 * (NDS); Authentication Framework (AF)], only to use for IP messages
298
 * and if the ctx option is explicitly set: use self-issued certificates
299
 * from extraCerts as trust anchor to validate sender cert -
300
 * provided it also can validate the newly enrolled certificate
301
 */
302
static int check_cert_path_3gpp(const OSSL_CMP_CTX *ctx,
303
                                const OSSL_CMP_MSG *msg, X509 *scrt)
304
0
{
305
0
    int valid = 0;
306
0
    X509_STORE *store;
307
308
0
    if (!ctx->permitTAInExtraCertsForIR)
309
0
        return 0;
310
311
0
    if ((store = X509_STORE_new()) == NULL
312
0
            || !ossl_cmp_X509_STORE_add1_certs(store, msg->extraCerts,
313
0
                                               1 /* self-issued only */))
314
0
        goto err;
315
316
    /* store does not include CRLs */
317
0
    valid = OSSL_CMP_validate_cert_path(ctx, store, scrt);
318
0
    if (!valid) {
319
0
        ossl_cmp_warn(ctx,
320
0
                      "also exceptional 3GPP mode cert path validation failed");
321
0
    } else {
322
        /*
323
         * verify that the newly enrolled certificate (which assumed rid ==
324
         * OSSL_CMP_CERTREQID) can also be validated with the same trusted store
325
         */
326
0
        OSSL_CMP_CERTRESPONSE *crep =
327
0
            ossl_cmp_certrepmessage_get0_certresponse(msg->body->value.ip,
328
0
                                                      OSSL_CMP_CERTREQID);
329
0
        X509 *newcrt = ossl_cmp_certresponse_get1_cert(ctx, crep);
330
331
        /*
332
         * maybe better use get_cert_status() from cmp_client.c, which catches
333
         * errors
334
         */
335
0
        valid = OSSL_CMP_validate_cert_path(ctx, store, newcrt);
336
0
        X509_free(newcrt);
337
0
    }
338
339
0
 err:
340
0
    X509_STORE_free(store);
341
0
    return valid;
342
0
}
343
344
static int check_msg_given_cert(const OSSL_CMP_CTX *ctx, X509 *cert,
345
                                const OSSL_CMP_MSG *msg)
346
0
{
347
0
    return cert_acceptable(ctx, "previously validated", "sender cert",
348
0
                           cert, NULL, NULL, msg)
349
0
        && (check_cert_path(ctx, ctx->trusted, cert)
350
0
            || check_cert_path_3gpp(ctx, msg, cert));
351
0
}
352
353
/*-
354
 * Try all certs in given list for verifying msg, normally or in 3GPP mode.
355
 * If already_checked1 == NULL then certs are assumed to be the msg->extraCerts.
356
 * On success cache the found cert using ossl_cmp_ctx_set0_validatedSrvCert().
357
 */
358
static int check_msg_with_certs(OSSL_CMP_CTX *ctx, const STACK_OF(X509) *certs,
359
                                const char *desc,
360
                                const STACK_OF(X509) *already_checked1,
361
                                const STACK_OF(X509) *already_checked2,
362
                                const OSSL_CMP_MSG *msg, int mode_3gpp)
363
0
{
364
0
    int in_extraCerts = already_checked1 == NULL;
365
0
    int n_acceptable_certs = 0;
366
0
    int i;
367
368
0
    if (sk_X509_num(certs) <= 0) {
369
0
        ossl_cmp_log1(WARN, ctx, "no %s", desc);
370
0
        return 0;
371
0
    }
372
373
0
    for (i = 0; i < sk_X509_num(certs); i++) { /* certs may be NULL */
374
0
        X509 *cert = sk_X509_value(certs, i);
375
376
0
        if (!ossl_assert(cert != NULL))
377
0
            return 0;
378
0
        if (!cert_acceptable(ctx, "cert from", desc, cert,
379
0
                             already_checked1, already_checked2, msg))
380
0
            continue;
381
0
        n_acceptable_certs++;
382
0
        if (mode_3gpp ? check_cert_path_3gpp(ctx, msg, cert)
383
0
                      : check_cert_path(ctx, ctx->trusted, cert)) {
384
            /* store successful sender cert for further msgs in transaction */
385
0
            if (!X509_up_ref(cert))
386
0
                return 0;
387
0
            if (!ossl_cmp_ctx_set0_validatedSrvCert(ctx, cert)) {
388
0
                X509_free(cert);
389
0
                return 0;
390
0
            }
391
0
            return 1;
392
0
        }
393
0
    }
394
0
    if (in_extraCerts && n_acceptable_certs == 0)
395
0
        ossl_cmp_warn(ctx, "no acceptable cert in extraCerts");
396
0
    return 0;
397
0
}
398
399
/*-
400
 * Verify msg trying first ctx->untrusted, which should include extraCerts
401
 * at its front, then trying the trusted certs in truststore (if any) of ctx.
402
 * On success cache the found cert using ossl_cmp_ctx_set0_validatedSrvCert().
403
 */
404
static int check_msg_all_certs(OSSL_CMP_CTX *ctx, const OSSL_CMP_MSG *msg,
405
                               int mode_3gpp)
406
0
{
407
0
    int ret = 0;
408
409
0
    if (mode_3gpp
410
0
            && ((!ctx->permitTAInExtraCertsForIR
411
0
                     || OSSL_CMP_MSG_get_bodytype(msg) != OSSL_CMP_PKIBODY_IP)))
412
0
        return 0;
413
414
0
    ossl_cmp_info(ctx,
415
0
                  mode_3gpp ? "normal mode failed; trying now 3GPP mode trusting extraCerts"
416
0
                            : "trying first normal mode using trust store");
417
0
    if (check_msg_with_certs(ctx, msg->extraCerts, "extraCerts",
418
0
                             NULL, NULL, msg, mode_3gpp))
419
0
        return 1;
420
0
    if (check_msg_with_certs(ctx, ctx->untrusted, "untrusted certs",
421
0
                             msg->extraCerts, NULL, msg, mode_3gpp))
422
0
        return 1;
423
424
0
    if (ctx->trusted == NULL) {
425
0
        ossl_cmp_warn(ctx, mode_3gpp ? "no self-issued extraCerts"
426
0
                                     : "no trusted store");
427
0
    } else {
428
0
        STACK_OF(X509) *trusted = X509_STORE_get1_all_certs(ctx->trusted);
429
0
        ret = check_msg_with_certs(ctx, trusted,
430
0
                                   mode_3gpp ? "self-issued extraCerts"
431
0
                                             : "certs in trusted store",
432
0
                                   msg->extraCerts, ctx->untrusted,
433
0
                                   msg, mode_3gpp);
434
0
        sk_X509_pop_free(trusted, X509_free);
435
0
    }
436
0
    return ret;
437
0
}
438
439
static int no_log_cb(const char *func, const char *file, int line,
440
                     OSSL_CMP_severity level, const char *msg)
441
0
{
442
0
    return 1;
443
0
}
444
445
/*-
446
 * Verify message signature with any acceptable and valid candidate cert.
447
 * On success cache the found cert using ossl_cmp_ctx_set0_validatedSrvCert().
448
 */
449
static int check_msg_find_cert(OSSL_CMP_CTX *ctx, const OSSL_CMP_MSG *msg)
450
0
{
451
0
    X509 *scrt = ctx->validatedSrvCert; /* previous successful sender cert */
452
0
    GENERAL_NAME *sender = msg->header->sender;
453
0
    char *sname = NULL;
454
0
    char *skid_str = NULL;
455
0
    const ASN1_OCTET_STRING *skid = msg->header->senderKID;
456
0
    OSSL_CMP_log_cb_t backup_log_cb = ctx->log_cb;
457
0
    int res = 0;
458
459
0
    if (sender == NULL || msg->body == NULL)
460
0
        return 0; /* other NULL cases already have been checked */
461
0
    if (sender->type != GEN_DIRNAME) {
462
0
        ERR_raise(ERR_LIB_CMP, CMP_R_SENDER_GENERALNAME_TYPE_NOT_SUPPORTED);
463
0
        return 0;
464
0
    }
465
466
    /* dump any hitherto errors to avoid confusion when printing further ones */
467
0
    OSSL_CMP_CTX_print_errors(ctx);
468
469
    /* enable clearing irrelevant errors in attempts to validate sender certs */
470
0
    (void)ERR_set_mark();
471
0
    ctx->log_cb = no_log_cb; /* temporarily disable logging */
472
473
    /*
474
     * try first cached scrt, used successfully earlier in same transaction,
475
     * for validating this and any further msgs where extraCerts may be left out
476
     */
477
0
    if (scrt != NULL) {
478
0
        if (check_msg_given_cert(ctx, scrt, msg)) {
479
0
            ctx->log_cb = backup_log_cb;
480
0
            (void)ERR_pop_to_mark();
481
0
            return 1;
482
0
        }
483
        /* cached sender cert has shown to be no more successfully usable */
484
0
        (void)ossl_cmp_ctx_set0_validatedSrvCert(ctx, NULL);
485
        /* re-do the above check (just) for adding diagnostic information */
486
0
        ossl_cmp_info(ctx,
487
0
                      "trying to verify msg signature with previously validated cert");
488
0
        (void)check_msg_given_cert(ctx, scrt, msg);
489
0
    }
490
491
0
    res = check_msg_all_certs(ctx, msg, 0 /* using ctx->trusted */)
492
0
            || check_msg_all_certs(ctx, msg, 1 /* 3gpp */);
493
0
    ctx->log_cb = backup_log_cb;
494
0
    if (res) {
495
        /* discard any diagnostic information on trying to use certs */
496
0
        (void)ERR_pop_to_mark();
497
0
        goto end;
498
0
    }
499
    /* failed finding a sender cert that verifies the message signature */
500
0
    (void)ERR_clear_last_mark();
501
502
0
    sname = X509_NAME_oneline(sender->d.directoryName, NULL, 0);
503
0
    skid_str = skid == NULL ? NULL
504
0
                            : OPENSSL_buf2hexstr(skid->data, skid->length);
505
0
    if (ctx->log_cb != NULL) {
506
0
        ossl_cmp_info(ctx, "trying to verify msg signature with a valid cert that..");
507
0
        if (sname != NULL)
508
0
            ossl_cmp_log1(INFO, ctx, "matches msg sender    = %s", sname);
509
0
        if (skid_str != NULL)
510
0
            ossl_cmp_log1(INFO, ctx, "matches msg senderKID = %s", skid_str);
511
0
        else
512
0
            ossl_cmp_info(ctx, "while msg header does not contain senderKID");
513
        /* re-do the above checks (just) for adding diagnostic information */
514
0
        (void)check_msg_all_certs(ctx, msg, 0 /* using ctx->trusted */);
515
0
        (void)check_msg_all_certs(ctx, msg, 1 /* 3gpp */);
516
0
    }
517
518
0
    ERR_raise(ERR_LIB_CMP, CMP_R_NO_SUITABLE_SENDER_CERT);
519
0
    if (sname != NULL) {
520
0
        ERR_add_error_txt(NULL, "for msg sender name = ");
521
0
        ERR_add_error_txt(NULL, sname);
522
0
    }
523
0
    if (skid_str != NULL) {
524
0
        ERR_add_error_txt(" and ", "for msg senderKID = ");
525
0
        ERR_add_error_txt(NULL, skid_str);
526
0
    }
527
528
0
 end:
529
0
    OPENSSL_free(sname);
530
0
    OPENSSL_free(skid_str);
531
0
    return res;
532
0
}
533
534
/*-
535
 * Validate the protection of the given PKIMessage using either password-
536
 * based mac (PBM) or a signature algorithm. In the case of signature algorithm,
537
 * the sender certificate can have been pinned by providing it in ctx->srvCert,
538
 * else it is searched in msg->extraCerts, ctx->untrusted, in ctx->trusted
539
 * (in this order) and is path is validated against ctx->trusted.
540
 * On success cache the found cert using ossl_cmp_ctx_set0_validatedSrvCert().
541
 *
542
 * If ctx->permitTAInExtraCertsForIR is true and when validating a CMP IP msg,
543
 * the trust anchor for validating the IP msg may be taken from msg->extraCerts
544
 * if a self-issued certificate is found there that can be used to
545
 * validate the enrolled certificate returned in the IP.
546
 * This is according to the need given in 3GPP TS 33.310.
547
 *
548
 * Returns 1 on success, 0 on error or validation failed.
549
 */
550
int OSSL_CMP_validate_msg(OSSL_CMP_CTX *ctx, const OSSL_CMP_MSG *msg)
551
800
{
552
800
    X509 *scrt;
553
554
800
    ossl_cmp_debug(ctx, "validating CMP message");
555
800
    if (ctx == NULL || msg == NULL
556
800
            || msg->header == NULL || msg->body == NULL) {
557
0
        ERR_raise(ERR_LIB_CMP, CMP_R_NULL_ARGUMENT);
558
0
        return 0;
559
0
    }
560
561
    if (msg->header->protectionAlg == NULL /* unprotected message */
562
800
            || msg->protection == NULL || msg->protection->data == NULL) {
563
51
        ERR_raise(ERR_LIB_CMP, CMP_R_MISSING_PROTECTION);
564
51
        return 0;
565
51
    }
566
567
749
    switch (ossl_cmp_hdr_get_protection_nid(msg->header)) {
568
        /* 5.1.3.1.  Shared Secret Information */
569
392
    case NID_id_PasswordBasedMAC:
570
392
        if (ctx->secretValue == NULL) {
571
201
            ossl_cmp_info(ctx, "no secret available for verifying PBM-based CMP message protection");
572
201
            ERR_raise(ERR_LIB_CMP, CMP_R_MISSING_SECRET);
573
201
            return 0;
574
201
        }
575
191
        if (verify_PBMAC(ctx, msg)) {
576
            /*
577
             * RFC 4210, 5.3.2: 'Note that if the PKI Message Protection is
578
             * "shared secret information", then any certificate transported in
579
             * the caPubs field may be directly trusted as a root CA
580
             * certificate by the initiator.'
581
             */
582
0
            switch (OSSL_CMP_MSG_get_bodytype(msg)) {
583
0
            case -1:
584
0
                return 0;
585
0
            case OSSL_CMP_PKIBODY_IP:
586
0
            case OSSL_CMP_PKIBODY_CP:
587
0
            case OSSL_CMP_PKIBODY_KUP:
588
0
            case OSSL_CMP_PKIBODY_CCP:
589
0
                if (ctx->trusted != NULL) {
590
0
                    STACK_OF(X509) *certs = msg->body->value.ip->caPubs;
591
                    /* value.ip is same for cp, kup, and ccp */
592
593
0
                    if (!ossl_cmp_X509_STORE_add1_certs(ctx->trusted, certs, 0))
594
                        /* adds both self-issued and not self-issued certs */
595
0
                        return 0;
596
0
                }
597
0
                break;
598
0
            default:
599
0
                break;
600
0
            }
601
0
            ossl_cmp_debug(ctx,
602
0
                           "sucessfully validated PBM-based CMP message protection");
603
0
            return 1;
604
0
        }
605
191
        ossl_cmp_warn(ctx, "verifying PBM-based CMP message protection failed");
606
191
        break;
607
608
        /*
609
         * 5.1.3.2 DH Key Pairs
610
         * Not yet supported
611
         */
612
3
    case NID_id_DHBasedMac:
613
3
        ERR_raise(ERR_LIB_CMP, CMP_R_UNSUPPORTED_PROTECTION_ALG_DHBASEDMAC);
614
3
        break;
615
616
        /*
617
         * 5.1.3.3.  Signature
618
         */
619
354
    default:
620
354
        scrt = ctx->srvCert;
621
354
        if (scrt == NULL) {
622
354
            if (ctx->trusted == NULL) {
623
354
                ossl_cmp_info(ctx, "no trust store nor pinned server cert available for verifying signature-based CMP message protection");
624
354
                ERR_raise(ERR_LIB_CMP, CMP_R_MISSING_TRUST_ANCHOR);
625
354
                return 0;
626
354
            }
627
0
            if (check_msg_find_cert(ctx, msg))
628
0
                return 1;
629
0
        } else { /* use pinned sender cert */
630
            /* use ctx->srvCert for signature check even if not acceptable */
631
0
            if (verify_signature(ctx, msg, scrt)) {
632
0
                ossl_cmp_debug(ctx,
633
0
                               "sucessfully validated signature-based CMP message protection");
634
635
0
                return 1;
636
0
            }
637
0
            ossl_cmp_warn(ctx, "CMP message signature verification failed");
638
0
            ERR_raise(ERR_LIB_CMP, CMP_R_SRVCERT_DOES_NOT_VALIDATE_MSG);
639
0
        }
640
0
        break;
641
749
    }
642
194
    return 0;
643
749
}
644
645
/*-
646
 * Check received message (i.e., response by server or request from client)
647
 * Any msg->extraCerts are prepended to ctx->untrusted.
648
 *
649
 * Ensures that:
650
 * its sender is of appropriate type (curently only X509_NAME) and
651
 *     matches any expected sender or srvCert subject given in the ctx
652
 * it has a valid body type
653
 * its protection is valid (or invalid/absent, but only if a callback function
654
 *     is present and yields a positive result using also the supplied argument)
655
 * its transaction ID matches the previous transaction ID stored in ctx (if any)
656
 * its recipNonce matches the previous senderNonce stored in the ctx (if any)
657
 *
658
 * If everything is fine:
659
 * learns the senderNonce from the received message,
660
 * learns the transaction ID if it is not yet in ctx,
661
 * and makes any certs in caPubs directly trusted.
662
 *
663
 * Returns 1 on success, 0 on error.
664
 */
665
int ossl_cmp_msg_check_update(OSSL_CMP_CTX *ctx, const OSSL_CMP_MSG *msg,
666
                              ossl_cmp_allow_unprotected_cb_t cb, int cb_arg)
667
8.97k
{
668
8.97k
    OSSL_CMP_PKIHEADER *hdr;
669
8.97k
    const X509_NAME *expected_sender;
670
671
8.97k
    if (!ossl_assert(ctx != NULL && msg != NULL && msg->header != NULL))
672
0
        return 0;
673
8.97k
    hdr = OSSL_CMP_MSG_get0_header(msg);
674
675
    /* validate sender name of received msg */
676
8.97k
    if (hdr->sender->type != GEN_DIRNAME) {
677
4.07k
        ERR_raise(ERR_LIB_CMP, CMP_R_SENDER_GENERALNAME_TYPE_NOT_SUPPORTED);
678
4.07k
        return 0;
679
4.07k
    }
680
    /*
681
     * Compare actual sender name of response with expected sender name.
682
     * Mitigates risk to accept misused PBM secret
683
     * or misused certificate of an unauthorized entity of a trusted hierarchy.
684
     */
685
4.89k
    expected_sender = ctx->expected_sender;
686
4.89k
    if (expected_sender == NULL && ctx->srvCert != NULL)
687
0
        expected_sender = X509_get_subject_name(ctx->srvCert);
688
4.89k
    if (!check_name(ctx, 0, "sender DN field", hdr->sender->d.directoryName,
689
4.89k
                    "expected sender", expected_sender))
690
0
        return 0;
691
    /* Note: if recipient was NULL-DN it could be learned here if needed */
692
693
4.89k
    if (sk_X509_num(msg->extraCerts) > 10)
694
4.89k
        ossl_cmp_warn(ctx,
695
4.89k
                      "received CMP message contains more than 10 extraCerts");
696
    /*
697
     * Store any provided extraCerts in ctx for use in OSSL_CMP_validate_msg()
698
     * and for future use, such that they are available to ctx->certConf_cb and
699
     * the peer does not need to send them again in the same transaction.
700
     * Note that it does not help validating the message before storing the
701
     * extraCerts because they do not belong to the protected msg part anyway.
702
     * For efficiency, the extraCerts are prepended so they get used first.
703
     */
704
4.89k
    if (!X509_add_certs(ctx->untrusted, msg->extraCerts,
705
                        /* this allows self-signed certs */
706
4.89k
                        X509_ADD_FLAG_UP_REF | X509_ADD_FLAG_NO_DUP
707
4.89k
                        | X509_ADD_FLAG_PREPEND))
708
0
        return 0;
709
710
    /* validate message protection */
711
4.89k
    if (hdr->protectionAlg != NULL) {
712
        /* detect explicitly permitted exceptions for invalid protection */
713
800
        if (!OSSL_CMP_validate_msg(ctx, msg)
714
800
                && (cb == NULL || (*cb)(ctx, msg, 1, cb_arg) <= 0)) {
715
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
716
            ERR_raise(ERR_LIB_CMP, CMP_R_ERROR_VALIDATING_PROTECTION);
717
            return 0;
718
#endif
719
449
        }
720
4.09k
    } else {
721
        /* detect explicitly permitted exceptions for missing protection */
722
4.09k
        if (cb == NULL || (*cb)(ctx, msg, 0, cb_arg) <= 0) {
723
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
724
            ERR_raise(ERR_LIB_CMP, CMP_R_MISSING_PROTECTION);
725
            return 0;
726
#endif
727
2.15k
        }
728
4.09k
    }
729
730
    /* check CMP version number in header */
731
4.89k
    if (ossl_cmp_hdr_get_pvno(hdr) != OSSL_CMP_PVNO) {
732
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
733
        ERR_raise(ERR_LIB_CMP, CMP_R_UNEXPECTED_PVNO);
734
        return 0;
735
#endif
736
4.28k
    }
737
738
4.89k
    if (OSSL_CMP_MSG_get_bodytype(msg) < 0) {
739
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
740
        ERR_raise(ERR_LIB_CMP, CMP_R_PKIBODY_ERROR);
741
        return 0;
742
#endif
743
0
    }
744
745
    /* compare received transactionID with the expected one in previous msg */
746
4.89k
    if (ctx->transactionID != NULL
747
4.89k
            && (hdr->transactionID == NULL
748
0
                || ASN1_OCTET_STRING_cmp(ctx->transactionID,
749
0
                                         hdr->transactionID) != 0)) {
750
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
751
        ERR_raise(ERR_LIB_CMP, CMP_R_TRANSACTIONID_UNMATCHED);
752
        return 0;
753
#endif
754
0
    }
755
756
    /* compare received nonce with the one we sent */
757
4.89k
    if (ctx->senderNonce != NULL
758
4.89k
            && (msg->header->recipNonce == NULL
759
0
                || ASN1_OCTET_STRING_cmp(ctx->senderNonce,
760
0
                                         hdr->recipNonce) != 0)) {
761
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
762
        ERR_raise(ERR_LIB_CMP, CMP_R_RECIPNONCE_UNMATCHED);
763
        return 0;
764
#endif
765
0
    }
766
767
    /* if not yet present, learn transactionID */
768
4.89k
    if (ctx->transactionID == NULL
769
4.89k
        && !OSSL_CMP_CTX_set1_transactionID(ctx, hdr->transactionID))
770
0
        return 0;
771
772
    /*
773
     * RFC 4210 section 5.1.1 states: the recipNonce is copied from
774
     * the senderNonce of the previous message in the transaction.
775
     * --> Store for setting in next message
776
     */
777
4.89k
    if (!ossl_cmp_ctx_set1_recipNonce(ctx, hdr->senderNonce))
778
0
        return 0;
779
780
    /*
781
     * Store any provided extraCerts in ctx for future use,
782
     * such that they are available to ctx->certConf_cb and
783
     * the peer does not need to send them again in the same transaction.
784
     * For efficiency, the extraCerts are prepended so they get used first.
785
     */
786
4.89k
    if (!X509_add_certs(ctx->untrusted, msg->extraCerts,
787
                        /* this allows self-signed certs */
788
4.89k
                        X509_ADD_FLAG_UP_REF | X509_ADD_FLAG_NO_DUP
789
4.89k
                        | X509_ADD_FLAG_PREPEND))
790
0
        return 0;
791
792
4.89k
    if (ossl_cmp_hdr_get_protection_nid(hdr) == NID_id_PasswordBasedMAC) {
793
        /*
794
         * RFC 4210, 5.3.2: 'Note that if the PKI Message Protection is
795
         * "shared secret information", then any certificate transported in
796
         * the caPubs field may be directly trusted as a root CA
797
         * certificate by the initiator.'
798
         */
799
403
        switch (OSSL_CMP_MSG_get_bodytype(msg)) {
800
5
        case OSSL_CMP_PKIBODY_IP:
801
8
        case OSSL_CMP_PKIBODY_CP:
802
9
        case OSSL_CMP_PKIBODY_KUP:
803
11
        case OSSL_CMP_PKIBODY_CCP:
804
11
            if (ctx->trusted != NULL) {
805
0
                STACK_OF(X509) *certs = msg->body->value.ip->caPubs;
806
                /* value.ip is same for cp, kup, and ccp */
807
808
0
                if (!ossl_cmp_X509_STORE_add1_certs(ctx->trusted, certs, 0))
809
                    /* adds both self-issued and not self-issued certs */
810
0
                    return 0;
811
0
            }
812
11
            break;
813
392
        default:
814
392
            break;
815
403
        }
816
403
    }
817
4.89k
    return 1;
818
4.89k
}
819
820
int ossl_cmp_verify_popo(const OSSL_CMP_CTX *ctx,
821
                         const OSSL_CMP_MSG *msg, int acceptRAVerified)
822
953
{
823
953
    if (!ossl_assert(msg != NULL && msg->body != NULL))
824
0
        return 0;
825
953
    switch (msg->body->type) {
826
786
    case OSSL_CMP_PKIBODY_P10CR:
827
786
        {
828
786
            X509_REQ *req = msg->body->value.p10cr;
829
830
786
            if (X509_REQ_verify_ex(req, X509_REQ_get0_pubkey(req), ctx->libctx,
831
786
                                   ctx->propq) <= 0) {
832
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
833
                ERR_raise(ERR_LIB_CMP, CMP_R_REQUEST_NOT_ACCEPTED);
834
                return 0;
835
#endif
836
785
            }
837
786
        }
838
786
        break;
839
86
    case OSSL_CMP_PKIBODY_IR:
840
164
    case OSSL_CMP_PKIBODY_CR:
841
167
    case OSSL_CMP_PKIBODY_KUR:
842
167
        if (!OSSL_CRMF_MSGS_verify_popo(msg->body->value.ir, OSSL_CMP_CERTREQID,
843
167
                                        acceptRAVerified,
844
167
                                        ctx->libctx, ctx->propq)) {
845
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
846
            return 0;
847
#endif
848
158
        }
849
167
        break;
850
0
    default:
851
0
        ERR_raise(ERR_LIB_CMP, CMP_R_PKIBODY_ERROR);
852
0
        return 0;
853
953
    }
854
953
    return 1;
855
953
}