Coverage Report

Created: 2025-08-28 07:07

/src/openssl30/crypto/x509/x_crl.c
Line
Count
Source (jump to first uncovered line)
1
/*
2
 * Copyright 1995-2022 The OpenSSL Project Authors. All Rights Reserved.
3
 *
4
 * Licensed under the Apache License 2.0 (the "License").  You may not use
5
 * this file except in compliance with the License.  You can obtain a copy
6
 * in the file LICENSE in the source distribution or at
7
 * https://www.openssl.org/source/license.html
8
 */
9
10
#include <stdio.h>
11
#include "internal/cryptlib.h"
12
#include <openssl/asn1t.h>
13
#include <openssl/x509.h>
14
#include "crypto/x509.h"
15
#include <openssl/x509v3.h>
16
#include "x509_local.h"
17
18
static int X509_REVOKED_cmp(const X509_REVOKED *const *a,
19
                            const X509_REVOKED *const *b);
20
static int setup_idp(X509_CRL *crl, ISSUING_DIST_POINT *idp);
21
22
ASN1_SEQUENCE(X509_REVOKED) = {
23
        ASN1_EMBED(X509_REVOKED,serialNumber, ASN1_INTEGER),
24
        ASN1_SIMPLE(X509_REVOKED,revocationDate, ASN1_TIME),
25
        ASN1_SEQUENCE_OF_OPT(X509_REVOKED,extensions, X509_EXTENSION)
26
} ASN1_SEQUENCE_END(X509_REVOKED)
27
28
static int def_crl_verify(X509_CRL *crl, EVP_PKEY *r);
29
static int def_crl_lookup(X509_CRL *crl,
30
                          X509_REVOKED **ret, const ASN1_INTEGER *serial,
31
                          const X509_NAME *issuer);
32
33
static X509_CRL_METHOD int_crl_meth = {
34
    0,
35
    0, 0,
36
    def_crl_lookup,
37
    def_crl_verify
38
};
39
40
static const X509_CRL_METHOD *default_crl_method = &int_crl_meth;
41
42
/*
43
 * The X509_CRL_INFO structure needs a bit of customisation. Since we cache
44
 * the original encoding the signature won't be affected by reordering of the
45
 * revoked field.
46
 */
47
static int crl_inf_cb(int operation, ASN1_VALUE **pval, const ASN1_ITEM *it,
48
                      void *exarg)
49
1.60M
{
50
1.60M
    X509_CRL_INFO *a = (X509_CRL_INFO *)*pval;
51
52
1.60M
    if (!a || !a->revoked)
53
1.55M
        return 1;
54
49.8k
    switch (operation) {
55
        /*
56
         * Just set cmp function here. We don't sort because that would
57
         * affect the output of X509_CRL_print().
58
         */
59
24.4k
    case ASN1_OP_D2I_POST:
60
24.4k
        (void)sk_X509_REVOKED_set_cmp_func(a->revoked, X509_REVOKED_cmp);
61
24.4k
        break;
62
49.8k
    }
63
49.8k
    return 1;
64
49.8k
}
65
66
67
ASN1_SEQUENCE_enc(X509_CRL_INFO, enc, crl_inf_cb) = {
68
        ASN1_OPT(X509_CRL_INFO, version, ASN1_INTEGER),
69
        ASN1_EMBED(X509_CRL_INFO, sig_alg, X509_ALGOR),
70
        ASN1_SIMPLE(X509_CRL_INFO, issuer, X509_NAME),
71
        ASN1_SIMPLE(X509_CRL_INFO, lastUpdate, ASN1_TIME),
72
        ASN1_OPT(X509_CRL_INFO, nextUpdate, ASN1_TIME),
73
        ASN1_SEQUENCE_OF_OPT(X509_CRL_INFO, revoked, X509_REVOKED),
74
        ASN1_EXP_SEQUENCE_OF_OPT(X509_CRL_INFO, extensions, X509_EXTENSION, 0)
75
} ASN1_SEQUENCE_END_enc(X509_CRL_INFO, X509_CRL_INFO)
76
77
/*
78
 * Set CRL entry issuer according to CRL certificate issuer extension. Check
79
 * for unhandled critical CRL entry extensions.
80
 */
81
82
static int crl_set_issuers(X509_CRL *crl)
83
44.2k
{
84
85
44.2k
    int i, j;
86
44.2k
    GENERAL_NAMES *gens, *gtmp;
87
44.2k
    STACK_OF(X509_REVOKED) *revoked;
88
89
44.2k
    revoked = X509_CRL_get_REVOKED(crl);
90
91
44.2k
    gens = NULL;
92
70.4k
    for (i = 0; i < sk_X509_REVOKED_num(revoked); i++) {
93
28.2k
        X509_REVOKED *rev = sk_X509_REVOKED_value(revoked, i);
94
28.2k
        STACK_OF(X509_EXTENSION) *exts;
95
28.2k
        ASN1_ENUMERATED *reason;
96
28.2k
        X509_EXTENSION *ext;
97
28.2k
        gtmp = X509_REVOKED_get_ext_d2i(rev,
98
28.2k
                                        NID_certificate_issuer, &j, NULL);
99
28.2k
        if (!gtmp && (j != -1)) {
100
1.24k
            crl->flags |= EXFLAG_INVALID;
101
1.24k
            return 1;
102
1.24k
        }
103
104
27.0k
        if (gtmp) {
105
4.52k
            gens = gtmp;
106
4.52k
            if (crl->issuers == NULL) {
107
618
                crl->issuers = sk_GENERAL_NAMES_new_null();
108
618
                if (crl->issuers == NULL) {
109
0
                    GENERAL_NAMES_free(gtmp);
110
0
                    return 0;
111
0
                }
112
618
            }
113
4.52k
            if (!sk_GENERAL_NAMES_push(crl->issuers, gtmp)) {
114
0
                GENERAL_NAMES_free(gtmp);
115
0
                return 0;
116
0
            }
117
4.52k
        }
118
27.0k
        rev->issuer = gens;
119
120
27.0k
        reason = X509_REVOKED_get_ext_d2i(rev, NID_crl_reason, &j, NULL);
121
27.0k
        if (!reason && (j != -1)) {
122
839
            crl->flags |= EXFLAG_INVALID;
123
839
            return 1;
124
839
        }
125
126
26.1k
        if (reason) {
127
6.83k
            rev->reason = ASN1_ENUMERATED_get(reason);
128
6.83k
            ASN1_ENUMERATED_free(reason);
129
6.83k
        } else
130
19.3k
            rev->reason = CRL_REASON_NONE;
131
132
        /* Check for critical CRL entry extensions */
133
134
26.1k
        exts = rev->extensions;
135
136
40.5k
        for (j = 0; j < sk_X509_EXTENSION_num(exts); j++) {
137
16.9k
            ext = sk_X509_EXTENSION_value(exts, j);
138
16.9k
            if (X509_EXTENSION_get_critical(ext)) {
139
3.55k
                if (OBJ_obj2nid(X509_EXTENSION_get_object(ext)) == NID_certificate_issuer)
140
949
                    continue;
141
2.60k
                crl->flags |= EXFLAG_CRITICAL;
142
2.60k
                break;
143
3.55k
            }
144
16.9k
        }
145
146
26.1k
    }
147
148
42.2k
    return 1;
149
150
44.2k
}
151
152
/*
153
 * The X509_CRL structure needs a bit of customisation. Cache some extensions
154
 * and hash of the whole CRL or set EXFLAG_NO_FINGERPRINT if this fails.
155
 */
156
static int crl_cb(int operation, ASN1_VALUE **pval, const ASN1_ITEM *it,
157
                  void *exarg)
158
2.02M
{
159
2.02M
    X509_CRL *crl = (X509_CRL *)*pval;
160
2.02M
    STACK_OF(X509_EXTENSION) *exts;
161
2.02M
    X509_EXTENSION *ext;
162
2.02M
    int idx, i;
163
164
2.02M
    switch (operation) {
165
242k
    case ASN1_OP_D2I_PRE:
166
242k
        if (crl->meth->crl_free) {
167
0
            if (!crl->meth->crl_free(crl))
168
0
                return 0;
169
0
        }
170
242k
        AUTHORITY_KEYID_free(crl->akid);
171
242k
        ISSUING_DIST_POINT_free(crl->idp);
172
242k
        ASN1_INTEGER_free(crl->crl_number);
173
242k
        ASN1_INTEGER_free(crl->base_crl_number);
174
242k
        sk_GENERAL_NAMES_pop_free(crl->issuers, GENERAL_NAMES_free);
175
        /* fall thru */
176
177
484k
    case ASN1_OP_NEW_POST:
178
484k
        crl->idp = NULL;
179
484k
        crl->akid = NULL;
180
484k
        crl->flags = 0;
181
484k
        crl->idp_flags = 0;
182
484k
        crl->idp_reasons = CRLDP_ALL_REASONS;
183
484k
        crl->meth = default_crl_method;
184
484k
        crl->meth_data = NULL;
185
484k
        crl->issuers = NULL;
186
484k
        crl->crl_number = NULL;
187
484k
        crl->base_crl_number = NULL;
188
484k
        break;
189
190
172k
    case ASN1_OP_D2I_POST:
191
172k
        if (!X509_CRL_digest(crl, EVP_sha1(), crl->sha1_hash, NULL))
192
0
            crl->flags |= EXFLAG_NO_FINGERPRINT;
193
172k
        crl->idp = X509_CRL_get_ext_d2i(crl,
194
172k
                                        NID_issuing_distribution_point, &i,
195
172k
                                        NULL);
196
172k
        if (crl->idp != NULL) {
197
24.3k
            if (!setup_idp(crl, crl->idp))
198
6.95k
                crl->flags |= EXFLAG_INVALID;
199
24.3k
        }
200
148k
        else if (i != -1) {
201
49.7k
            crl->flags |= EXFLAG_INVALID;
202
49.7k
        }
203
204
172k
        crl->akid = X509_CRL_get_ext_d2i(crl,
205
172k
                                         NID_authority_key_identifier, &i,
206
172k
                                         NULL);
207
172k
        if (crl->akid == NULL && i != -1)
208
34.2k
            crl->flags |= EXFLAG_INVALID;
209
210
172k
        crl->crl_number = X509_CRL_get_ext_d2i(crl,
211
172k
                                               NID_crl_number, &i, NULL);
212
172k
        if (crl->crl_number == NULL && i != -1)
213
8.73k
            crl->flags |= EXFLAG_INVALID;
214
215
172k
        crl->base_crl_number = X509_CRL_get_ext_d2i(crl,
216
172k
                                                    NID_delta_crl, &i,
217
172k
                                                    NULL);
218
172k
        if (crl->base_crl_number == NULL && i != -1)
219
5.46k
            crl->flags |= EXFLAG_INVALID;
220
        /* Delta CRLs must have CRL number */
221
172k
        if (crl->base_crl_number && !crl->crl_number)
222
1.62k
            crl->flags |= EXFLAG_INVALID;
223
224
        /*
225
         * See if we have any unhandled critical CRL extensions and indicate
226
         * this in a flag. We only currently handle IDP so anything else
227
         * critical sets the flag. This code accesses the X509_CRL structure
228
         * directly: applications shouldn't do this.
229
         */
230
231
172k
        exts = crl->crl.extensions;
232
233
1.18M
        for (idx = 0; idx < sk_X509_EXTENSION_num(exts); idx++) {
234
1.01M
            int nid;
235
1.01M
            ext = sk_X509_EXTENSION_value(exts, idx);
236
1.01M
            nid = OBJ_obj2nid(X509_EXTENSION_get_object(ext));
237
1.01M
            if (nid == NID_freshest_crl)
238
71.8k
                crl->flags |= EXFLAG_FRESHEST;
239
1.01M
            if (X509_EXTENSION_get_critical(ext)) {
240
                /* We handle IDP and deltas */
241
26.0k
                if ((nid == NID_issuing_distribution_point)
242
26.0k
                    || (nid == NID_authority_key_identifier)
243
26.0k
                    || (nid == NID_delta_crl))
244
20.9k
                    continue;
245
5.14k
                crl->flags |= EXFLAG_CRITICAL;
246
5.14k
                break;
247
26.0k
            }
248
1.01M
        }
249
250
172k
        if (!crl_set_issuers(crl))
251
0
            return 0;
252
253
172k
        if (crl->meth->crl_init) {
254
0
            if (crl->meth->crl_init(crl) == 0)
255
0
                return 0;
256
0
        }
257
258
172k
        crl->flags |= EXFLAG_SET;
259
172k
        break;
260
261
242k
    case ASN1_OP_FREE_POST:
262
242k
        if (crl->meth != NULL && crl->meth->crl_free != NULL) {
263
0
            if (!crl->meth->crl_free(crl))
264
0
                return 0;
265
0
        }
266
242k
        AUTHORITY_KEYID_free(crl->akid);
267
242k
        ISSUING_DIST_POINT_free(crl->idp);
268
242k
        ASN1_INTEGER_free(crl->crl_number);
269
242k
        ASN1_INTEGER_free(crl->base_crl_number);
270
242k
        sk_GENERAL_NAMES_pop_free(crl->issuers, GENERAL_NAMES_free);
271
242k
        OPENSSL_free(crl->propq);
272
242k
        break;
273
0
    case ASN1_OP_DUP_POST:
274
0
        {
275
0
            X509_CRL *old = exarg;
276
277
0
            if (!ossl_x509_crl_set0_libctx(crl, old->libctx, old->propq))
278
0
                return 0;
279
0
        }
280
0
        break;
281
2.02M
    }
282
2.02M
    return 1;
283
2.02M
}
284
285
/* Convert IDP into a more convenient form */
286
287
static int setup_idp(X509_CRL *crl, ISSUING_DIST_POINT *idp)
288
18.1k
{
289
18.1k
    int idp_only = 0;
290
291
    /* Set various flags according to IDP */
292
18.1k
    crl->idp_flags |= IDP_PRESENT;
293
18.1k
    if (idp->onlyuser > 0) {
294
803
        idp_only++;
295
803
        crl->idp_flags |= IDP_ONLYUSER;
296
803
    }
297
18.1k
    if (idp->onlyCA > 0) {
298
748
        idp_only++;
299
748
        crl->idp_flags |= IDP_ONLYCA;
300
748
    }
301
18.1k
    if (idp->onlyattr > 0) {
302
779
        idp_only++;
303
779
        crl->idp_flags |= IDP_ONLYATTR;
304
779
    }
305
306
18.1k
    if (idp_only > 1)
307
742
        crl->idp_flags |= IDP_INVALID;
308
309
18.1k
    if (idp->indirectCRL > 0)
310
648
        crl->idp_flags |= IDP_INDIRECT;
311
312
18.1k
    if (idp->onlysomereasons) {
313
1.77k
        crl->idp_flags |= IDP_REASONS;
314
1.77k
        if (idp->onlysomereasons->length > 0)
315
1.08k
            crl->idp_reasons = idp->onlysomereasons->data[0];
316
1.77k
        if (idp->onlysomereasons->length > 1)
317
698
            crl->idp_reasons |= (idp->onlysomereasons->data[1] << 8);
318
1.77k
        crl->idp_reasons &= CRLDP_ALL_REASONS;
319
1.77k
    }
320
321
18.1k
    return DIST_POINT_set_dpname(idp->distpoint, X509_CRL_get_issuer(crl));
322
18.1k
}
323
324
ASN1_SEQUENCE_ref(X509_CRL, crl_cb) = {
325
        ASN1_EMBED(X509_CRL, crl, X509_CRL_INFO),
326
        ASN1_EMBED(X509_CRL, sig_alg, X509_ALGOR),
327
        ASN1_EMBED(X509_CRL, signature, ASN1_BIT_STRING)
328
} ASN1_SEQUENCE_END_ref(X509_CRL, X509_CRL)
329
330
IMPLEMENT_ASN1_FUNCTIONS(X509_REVOKED)
331
332
IMPLEMENT_ASN1_DUP_FUNCTION(X509_REVOKED)
333
334
IMPLEMENT_ASN1_FUNCTIONS(X509_CRL_INFO)
335
336
IMPLEMENT_ASN1_FUNCTIONS(X509_CRL)
337
338
IMPLEMENT_ASN1_DUP_FUNCTION(X509_CRL)
339
340
static int X509_REVOKED_cmp(const X509_REVOKED *const *a,
341
                            const X509_REVOKED *const *b)
342
1.75k
{
343
1.75k
    return (ASN1_STRING_cmp((ASN1_STRING *)&(*a)->serialNumber,
344
1.75k
                            (ASN1_STRING *)&(*b)->serialNumber));
345
1.75k
}
346
347
X509_CRL *X509_CRL_new_ex(OSSL_LIB_CTX *libctx, const char *propq)
348
0
{
349
0
    X509_CRL *crl = NULL;
350
351
0
    crl = (X509_CRL *)ASN1_item_new((X509_CRL_it()));
352
0
    if (!ossl_x509_crl_set0_libctx(crl, libctx, propq)) {
353
0
        X509_CRL_free(crl);
354
0
        crl = NULL;
355
0
    }
356
0
    return crl;
357
0
}
358
359
int X509_CRL_add0_revoked(X509_CRL *crl, X509_REVOKED *rev)
360
0
{
361
0
    X509_CRL_INFO *inf;
362
363
0
    inf = &crl->crl;
364
0
    if (inf->revoked == NULL)
365
0
        inf->revoked = sk_X509_REVOKED_new(X509_REVOKED_cmp);
366
0
    if (inf->revoked == NULL || !sk_X509_REVOKED_push(inf->revoked, rev)) {
367
0
        ERR_raise(ERR_LIB_ASN1, ERR_R_MALLOC_FAILURE);
368
0
        return 0;
369
0
    }
370
0
    inf->enc.modified = 1;
371
0
    return 1;
372
0
}
373
374
int X509_CRL_verify(X509_CRL *crl, EVP_PKEY *r)
375
4.88k
{
376
4.88k
    if (crl->meth->crl_verify)
377
4.88k
        return crl->meth->crl_verify(crl, r);
378
0
    return 0;
379
4.88k
}
380
381
int X509_CRL_get0_by_serial(X509_CRL *crl,
382
                            X509_REVOKED **ret, const ASN1_INTEGER *serial)
383
0
{
384
0
    if (crl->meth->crl_lookup)
385
0
        return crl->meth->crl_lookup(crl, ret, serial, NULL);
386
0
    return 0;
387
0
}
388
389
int X509_CRL_get0_by_cert(X509_CRL *crl, X509_REVOKED **ret, X509 *x)
390
4.88k
{
391
4.88k
    if (crl->meth->crl_lookup)
392
4.88k
        return crl->meth->crl_lookup(crl, ret,
393
4.88k
                                     X509_get0_serialNumber(x),
394
4.88k
                                     X509_get_issuer_name(x));
395
0
    return 0;
396
4.88k
}
397
398
static int def_crl_verify(X509_CRL *crl, EVP_PKEY *r)
399
4.88k
{
400
4.88k
    return ASN1_item_verify_ex(ASN1_ITEM_rptr(X509_CRL_INFO),
401
4.88k
                               &crl->sig_alg, &crl->signature, &crl->crl, NULL,
402
4.88k
                               r, crl->libctx, crl->propq);
403
4.88k
}
404
405
static int crl_revoked_issuer_match(X509_CRL *crl, const X509_NAME *nm,
406
                                    X509_REVOKED *rev)
407
11
{
408
11
    int i;
409
410
11
    if (!rev->issuer) {
411
11
        if (!nm)
412
0
            return 1;
413
11
        if (!X509_NAME_cmp(nm, X509_CRL_get_issuer(crl)))
414
11
            return 1;
415
0
        return 0;
416
11
    }
417
418
0
    if (!nm)
419
0
        nm = X509_CRL_get_issuer(crl);
420
421
0
    for (i = 0; i < sk_GENERAL_NAME_num(rev->issuer); i++) {
422
0
        GENERAL_NAME *gen = sk_GENERAL_NAME_value(rev->issuer, i);
423
0
        if (gen->type != GEN_DIRNAME)
424
0
            continue;
425
0
        if (!X509_NAME_cmp(nm, gen->d.directoryName))
426
0
            return 1;
427
0
    }
428
0
    return 0;
429
430
0
}
431
432
static int def_crl_lookup(X509_CRL *crl,
433
                          X509_REVOKED **ret, const ASN1_INTEGER *serial,
434
                          const X509_NAME *issuer)
435
4.88k
{
436
4.88k
    X509_REVOKED rtmp, *rev;
437
4.88k
    int idx, num;
438
439
4.88k
    if (crl->crl.revoked == NULL)
440
4.83k
        return 0;
441
442
    /*
443
     * Sort revoked into serial number order if not already sorted. Do this
444
     * under a lock to avoid race condition.
445
     */
446
56
    if (!sk_X509_REVOKED_is_sorted(crl->crl.revoked)) {
447
56
        if (!CRYPTO_THREAD_write_lock(crl->lock))
448
0
            return 0;
449
56
        sk_X509_REVOKED_sort(crl->crl.revoked);
450
56
        CRYPTO_THREAD_unlock(crl->lock);
451
56
    }
452
56
    rtmp.serialNumber = *serial;
453
56
    idx = sk_X509_REVOKED_find(crl->crl.revoked, &rtmp);
454
56
    if (idx < 0)
455
45
        return 0;
456
    /* Need to look for matching name */
457
11
    for (num = sk_X509_REVOKED_num(crl->crl.revoked); idx < num; idx++) {
458
11
        rev = sk_X509_REVOKED_value(crl->crl.revoked, idx);
459
11
        if (ASN1_INTEGER_cmp(&rev->serialNumber, serial))
460
0
            return 0;
461
11
        if (crl_revoked_issuer_match(crl, issuer, rev)) {
462
11
            if (ret)
463
11
                *ret = rev;
464
11
            if (rev->reason == CRL_REASON_REMOVE_FROM_CRL)
465
0
                return 2;
466
11
            return 1;
467
11
        }
468
11
    }
469
0
    return 0;
470
11
}
471
472
void X509_CRL_set_default_method(const X509_CRL_METHOD *meth)
473
0
{
474
0
    if (meth == NULL)
475
0
        default_crl_method = &int_crl_meth;
476
0
    else
477
0
        default_crl_method = meth;
478
0
}
479
480
X509_CRL_METHOD *X509_CRL_METHOD_new(int (*crl_init) (X509_CRL *crl),
481
                                     int (*crl_free) (X509_CRL *crl),
482
                                     int (*crl_lookup) (X509_CRL *crl,
483
                                                        X509_REVOKED **ret,
484
                                                        const ASN1_INTEGER *ser,
485
                                                        const X509_NAME *issuer),
486
                                     int (*crl_verify) (X509_CRL *crl,
487
                                                        EVP_PKEY *pk))
488
0
{
489
0
    X509_CRL_METHOD *m = OPENSSL_malloc(sizeof(*m));
490
491
0
    if (m == NULL) {
492
0
        ERR_raise(ERR_LIB_X509, ERR_R_MALLOC_FAILURE);
493
0
        return NULL;
494
0
    }
495
0
    m->crl_init = crl_init;
496
0
    m->crl_free = crl_free;
497
0
    m->crl_lookup = crl_lookup;
498
0
    m->crl_verify = crl_verify;
499
0
    m->flags = X509_CRL_METHOD_DYNAMIC;
500
0
    return m;
501
0
}
502
503
void X509_CRL_METHOD_free(X509_CRL_METHOD *m)
504
0
{
505
0
    if (m == NULL || !(m->flags & X509_CRL_METHOD_DYNAMIC))
506
0
        return;
507
0
    OPENSSL_free(m);
508
0
}
509
510
void X509_CRL_set_meth_data(X509_CRL *crl, void *dat)
511
0
{
512
0
    crl->meth_data = dat;
513
0
}
514
515
void *X509_CRL_get_meth_data(X509_CRL *crl)
516
0
{
517
0
    return crl->meth_data;
518
0
}
519
520
int ossl_x509_crl_set0_libctx(X509_CRL *x, OSSL_LIB_CTX *libctx,
521
                              const char *propq)
522
0
{
523
0
    if (x != NULL) {
524
0
        x->libctx = libctx;
525
0
        OPENSSL_free(x->propq);
526
0
        x->propq = NULL;
527
0
        if (propq != NULL) {
528
0
            x->propq = OPENSSL_strdup(propq);
529
0
            if (x->propq == NULL)
530
0
                return 0;
531
0
        }
532
0
    }
533
0
    return 1;
534
0
}