Coverage Report

Created: 2026-07-23 06:28

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/openssl35/crypto/cmp/cmp_vfy.c
Line
Count
Source
1
/*
2
 * Copyright 2007-2026 The OpenSSL Project Authors. All Rights Reserved.
3
 * Copyright Nokia 2007-2020
4
 * Copyright Siemens AG 2015-2020
5
 *
6
 * Licensed under the Apache License 2.0 (the "License").  You may not use
7
 * this file except in compliance with the License.  You can obtain a copy
8
 * in the file LICENSE in the source distribution or at
9
 * https://www.openssl.org/source/license.html
10
 */
11
12
/* CMP functions for PKIMessage checking */
13
14
#include "cmp_local.h"
15
#include <openssl/cmp_util.h>
16
17
/* explicit #includes not strictly needed since implied by the above: */
18
#include <openssl/asn1t.h>
19
#include <openssl/cmp.h>
20
#include <openssl/crmf.h>
21
#include <openssl/err.h>
22
#include <openssl/x509.h>
23
24
/* Verify a message protected by signature according to RFC section 5.1.3.3 */
25
static int verify_signature(const OSSL_CMP_CTX *cmp_ctx,
26
    const OSSL_CMP_MSG *msg, X509 *cert)
27
3.85k
{
28
3.85k
    OSSL_CMP_PROTECTEDPART prot_part;
29
3.85k
    EVP_PKEY *pubkey = NULL;
30
3.85k
    BIO *bio;
31
3.85k
    int res = 0;
32
33
3.85k
    if (!ossl_assert(cmp_ctx != NULL && msg != NULL && cert != NULL))
34
0
        return 0;
35
36
3.85k
    bio = BIO_new(BIO_s_mem()); /* may be NULL */
37
3.85k
    if (bio == NULL)
38
0
        return 0;
39
    /* verify that keyUsage, if present, contains digitalSignature */
40
3.85k
    if (!cmp_ctx->ignore_keyusage
41
3.85k
        && (X509_get_key_usage(cert) & X509v3_KU_DIGITAL_SIGNATURE) == 0) {
42
404
        ERR_raise(ERR_LIB_CMP, CMP_R_MISSING_KEY_USAGE_DIGITALSIGNATURE);
43
404
        goto sig_err;
44
404
    }
45
46
3.44k
    pubkey = X509_get_pubkey(cert);
47
3.44k
    if (pubkey == NULL) {
48
1.80k
        ERR_raise(ERR_LIB_CMP, CMP_R_FAILED_EXTRACTING_PUBKEY);
49
1.80k
        goto sig_err;
50
1.80k
    }
51
52
1.64k
    prot_part.header = msg->header;
53
1.64k
    prot_part.body = msg->body;
54
55
1.64k
    if (ASN1_item_verify_ex(ASN1_ITEM_rptr(OSSL_CMP_PROTECTEDPART),
56
1.64k
            msg->header->protectionAlg, msg->protection,
57
1.64k
            &prot_part, NULL, pubkey, cmp_ctx->libctx,
58
1.64k
            cmp_ctx->propq)
59
1.64k
        > 0) {
60
51
        res = 1;
61
51
        goto end;
62
51
    }
63
64
3.80k
sig_err:
65
3.80k
    res = ossl_x509_print_ex_brief(bio, cert, X509_FLAG_NO_EXTENSIONS);
66
3.80k
    ERR_raise(ERR_LIB_CMP, CMP_R_ERROR_VALIDATING_SIGNATURE);
67
3.80k
    if (res) {
68
3.80k
        ERR_add_error_txt(NULL, "\n");
69
3.80k
        ERR_add_error_mem_bio(NULL, bio);
70
3.80k
    }
71
3.80k
    res = 0;
72
73
3.85k
end:
74
3.85k
    EVP_PKEY_free(pubkey);
75
3.85k
    BIO_free(bio);
76
77
3.85k
    return res;
78
3.80k
}
79
80
/* Verify a message protected with PBMAC */
81
static int verify_PBMAC(OSSL_CMP_CTX *ctx, const OSSL_CMP_MSG *msg)
82
1.30k
{
83
1.30k
    ASN1_BIT_STRING *protection = NULL;
84
1.30k
    int valid = 0;
85
86
    /* generate expected protection for the message */
87
1.30k
    if ((protection = ossl_cmp_calc_protection(ctx, msg)) == NULL)
88
946
        return 0; /* failed to generate protection string! */
89
90
361
    valid = msg->protection != NULL && msg->protection->length >= 0
91
361
        && msg->protection->type == protection->type
92
361
        && msg->protection->length == protection->length
93
235
        && CRYPTO_memcmp(msg->protection->data, protection->data,
94
235
               protection->length)
95
235
            == 0;
96
361
    ASN1_BIT_STRING_free(protection);
97
361
    if (!valid)
98
361
        ERR_raise(ERR_LIB_CMP, CMP_R_WRONG_PBM_VALUE);
99
100
361
    return valid;
101
1.30k
}
102
103
/*-
104
 * Attempt to validate certificate and path using any given store with trusted
105
 * certs (possibly including CRLs and a cert verification callback function)
106
 * and non-trusted intermediate certs from the given ctx.
107
 *
108
 * Returns 1 on successful validation and 0 otherwise.
109
 */
110
int OSSL_CMP_validate_cert_path(const OSSL_CMP_CTX *ctx,
111
    X509_STORE *trusted_store, X509 *cert)
112
57
{
113
57
    int valid = 0;
114
57
    X509_STORE_CTX *csc = NULL;
115
57
    int err;
116
117
57
    if (ctx == NULL || cert == NULL) {
118
0
        ERR_raise(ERR_LIB_CMP, CMP_R_NULL_ARGUMENT);
119
0
        return 0;
120
0
    }
121
122
57
    if (trusted_store == NULL) {
123
57
        ERR_raise(ERR_LIB_CMP, CMP_R_MISSING_TRUST_STORE);
124
57
        return 0;
125
57
    }
126
127
0
    if ((csc = X509_STORE_CTX_new_ex(ctx->libctx, ctx->propq)) == NULL
128
0
        || !X509_STORE_CTX_init(csc, trusted_store,
129
0
            cert, ctx->untrusted))
130
0
        goto err;
131
132
0
    valid = X509_verify_cert(csc) > 0;
133
134
    /* make sure suitable error is queued even if callback did not do */
135
0
    err = ERR_peek_last_error();
136
0
    if (!valid && ERR_GET_REASON(err) != CMP_R_POTENTIALLY_INVALID_CERTIFICATE)
137
0
        ERR_raise(ERR_LIB_CMP, CMP_R_POTENTIALLY_INVALID_CERTIFICATE);
138
139
0
err:
140
    /* directly output any fresh errors, needed for check_msg_find_cert() */
141
0
    OSSL_CMP_CTX_print_errors(ctx);
142
0
    X509_STORE_CTX_free(csc);
143
0
    return valid;
144
0
}
145
146
static int verify_cb_cert(X509_STORE *ts, X509 *cert, int err)
147
4.22k
{
148
4.22k
    X509_STORE_CTX_verify_cb verify_cb;
149
4.22k
    X509_STORE_CTX *csc;
150
4.22k
    int ok = 0;
151
152
4.22k
    if (ts == NULL || (verify_cb = X509_STORE_get_verify_cb(ts)) == NULL)
153
4.22k
        return ok;
154
0
    if ((csc = X509_STORE_CTX_new()) != NULL
155
0
        && X509_STORE_CTX_init(csc, ts, cert, NULL)) {
156
0
        X509_STORE_CTX_set_error(csc, err);
157
0
        X509_STORE_CTX_set_current_cert(csc, cert);
158
0
        ok = (*verify_cb)(0, csc);
159
0
    }
160
0
    X509_STORE_CTX_free(csc);
161
0
    return ok;
162
4.22k
}
163
164
/* Return 0 if expect_name != NULL and there is no matching actual_name */
165
static int check_name(const OSSL_CMP_CTX *ctx, int log_success,
166
    const char *actual_desc, const X509_NAME *actual_name,
167
    const char *expect_desc, const X509_NAME *expect_name)
168
15.8k
{
169
15.8k
    char *str;
170
171
15.8k
    if (expect_name == NULL)
172
4.67k
        return 1; /* no expectation, thus trivially fulfilled */
173
174
    /* make sure that a matching name is there */
175
11.1k
    if (actual_name == NULL) {
176
0
        ossl_cmp_log1(WARN, ctx, "missing %s", actual_desc);
177
0
        return 0;
178
0
    }
179
11.1k
    str = X509_NAME_oneline(actual_name, NULL, 0);
180
11.1k
    if (X509_NAME_cmp(actual_name, expect_name) == 0) {
181
5.02k
        if (log_success && str != NULL)
182
5.02k
            ossl_cmp_log3(INFO, ctx, " %s matches %s: %s",
183
5.02k
                actual_desc, expect_desc, str);
184
5.02k
        OPENSSL_free(str);
185
5.02k
        return 1;
186
5.02k
    }
187
188
6.17k
    if (str != NULL)
189
6.17k
        ossl_cmp_log2(INFO, ctx, " actual name in %s = %s", actual_desc, str);
190
6.17k
    OPENSSL_free(str);
191
6.17k
    if ((str = X509_NAME_oneline(expect_name, NULL, 0)) != NULL)
192
6.17k
        ossl_cmp_log2(INFO, ctx, " does not match %s = %s", expect_desc, str);
193
6.17k
    OPENSSL_free(str);
194
6.17k
    return 0;
195
11.1k
}
196
197
/* Return 0 if skid != NULL and there is no matching subject key ID in cert */
198
static int check_kid(const OSSL_CMP_CTX *ctx,
199
    const ASN1_OCTET_STRING *ckid,
200
    const ASN1_OCTET_STRING *skid)
201
5.02k
{
202
5.02k
    char *str;
203
204
5.02k
    if (skid == NULL)
205
2.10k
        return 1; /* no expectation, thus trivially fulfilled */
206
207
    /* make sure that the expected subject key identifier is there */
208
2.91k
    if (ckid == NULL) {
209
216
        ossl_cmp_warn(ctx, "missing Subject Key Identifier in certificate");
210
216
        return 0;
211
216
    }
212
2.70k
    str = i2s_ASN1_OCTET_STRING(NULL, ckid);
213
2.70k
    if (ASN1_OCTET_STRING_cmp(ckid, skid) == 0) {
214
2.52k
        if (str != NULL)
215
2.52k
            ossl_cmp_log1(INFO, ctx, " subjectKID matches senderKID: %s", str);
216
2.52k
        OPENSSL_free(str);
217
2.52k
        return 1;
218
2.52k
    }
219
220
174
    if (str != NULL)
221
174
        ossl_cmp_log1(INFO, ctx, " cert Subject Key Identifier = %s", str);
222
174
    OPENSSL_free(str);
223
174
    if ((str = i2s_ASN1_OCTET_STRING(NULL, skid)) != NULL)
224
174
        ossl_cmp_log1(INFO, ctx, " does not match senderKID    = %s", str);
225
174
    OPENSSL_free(str);
226
174
    return 0;
227
2.70k
}
228
229
static int already_checked(const X509 *cert,
230
    const STACK_OF(X509) *already_checked)
231
49.1k
{
232
49.1k
    int i;
233
234
74.7k
    for (i = sk_X509_num(already_checked /* may be NULL */); i > 0; i--)
235
42.0k
        if (X509_cmp(sk_X509_value(already_checked, i - 1), cert) == 0)
236
16.3k
            return 1;
237
32.7k
    return 0;
238
49.1k
}
239
240
/*-
241
 * Check if the given cert is acceptable as sender cert of the given message.
242
 * The subject DN must match, the subject key ID as well if present in the msg,
243
 * and the cert must be current (checked if ctx->trusted is not NULL).
244
 * Note that cert revocation etc. is checked by OSSL_CMP_validate_cert_path().
245
 *
246
 * Returns 0 on error or not acceptable, else 1.
247
 */
248
static int cert_acceptable(const OSSL_CMP_CTX *ctx,
249
    const char *desc1, const char *desc2, X509 *cert,
250
    const STACK_OF(X509) *already_checked1,
251
    const STACK_OF(X509) *already_checked2,
252
    const OSSL_CMP_MSG *msg)
253
23.2k
{
254
23.2k
    X509_STORE *ts = ctx->trusted;
255
23.2k
    int self_issued = X509_check_issued(cert, cert) == X509_V_OK;
256
23.2k
    char *str;
257
23.2k
    X509_VERIFY_PARAM *vpm = ts != NULL ? X509_STORE_get0_param(ts) : NULL;
258
23.2k
    int time_cmp;
259
260
23.2k
    ossl_cmp_log3(INFO, ctx, " considering %s%s %s with..",
261
23.2k
        self_issued ? "self-issued " : "", desc1, desc2);
262
23.2k
    if ((str = X509_NAME_oneline(X509_get_subject_name(cert), NULL, 0)) != NULL)
263
23.2k
        ossl_cmp_log1(INFO, ctx, "  subject = %s", str);
264
23.2k
    OPENSSL_free(str);
265
23.2k
    if (!self_issued) {
266
20.8k
        str = X509_NAME_oneline(X509_get_issuer_name(cert), NULL, 0);
267
20.8k
        if (str != NULL)
268
20.8k
            ossl_cmp_log1(INFO, ctx, "  issuer  = %s", str);
269
20.8k
        OPENSSL_free(str);
270
20.8k
    }
271
272
23.2k
    if (already_checked(cert, already_checked1)
273
11.6k
        || already_checked(cert, already_checked2)) {
274
11.6k
        ossl_cmp_info(ctx, " cert has already been checked");
275
11.6k
        return 0;
276
11.6k
    }
277
278
11.6k
    time_cmp = X509_cmp_timeframe(vpm, X509_get0_notBefore(cert),
279
11.6k
        X509_get0_notAfter(cert));
280
11.6k
    if (time_cmp != 0) {
281
6.22k
        int err = time_cmp > 0 ? X509_V_ERR_CERT_HAS_EXPIRED
282
6.22k
                               : X509_V_ERR_CERT_NOT_YET_VALID;
283
284
6.22k
        ossl_cmp_warn(ctx, time_cmp > 0 ? "cert has expired" : "cert is not yet valid");
285
6.22k
        if (ctx->log_cb != NULL /* logging not temporarily disabled */
286
3.11k
            && verify_cb_cert(ts, cert, err) <= 0)
287
3.11k
            return 0;
288
6.22k
    }
289
290
8.51k
    if (!check_name(ctx, 1,
291
8.51k
            "cert subject", X509_get_subject_name(cert),
292
8.51k
            "sender field", msg->header->sender->d.directoryName))
293
4.72k
        return 0;
294
295
3.79k
    if (!check_kid(ctx, X509_get0_subject_key_id(cert), msg->header->senderKID))
296
292
        return 0;
297
    /* prevent misleading error later in case x509v3_cache_extensions() fails */
298
3.50k
    if (!ossl_x509v3_cache_extensions(cert)) {
299
212
        ossl_cmp_warn(ctx, "cert appears to be invalid");
300
212
        return 0;
301
212
    }
302
3.28k
    if (!verify_signature(ctx, msg, cert)) {
303
3.24k
        ossl_cmp_warn(ctx, "msg signature verification failed");
304
3.24k
        return 0;
305
3.24k
    }
306
    /* acceptable also if there is no senderKID in msg header */
307
41
    ossl_cmp_info(ctx, " cert seems acceptable");
308
41
    return 1;
309
3.28k
}
310
311
static int check_cert_path(const OSSL_CMP_CTX *ctx, X509_STORE *store,
312
    X509 *scrt)
313
57
{
314
57
    if (OSSL_CMP_validate_cert_path(ctx, store, scrt))
315
0
        return 1;
316
317
57
    ossl_cmp_warn(ctx,
318
57
        "msg signature validates but cert path validation failed");
319
57
    return 0;
320
57
}
321
322
/*
323
 * Exceptional handling for 3GPP TS 33.310 [3G/LTE Network Domain Security
324
 * (NDS); Authentication Framework (AF)], only to use for IP messages
325
 * and if the ctx option is explicitly set: use self-issued certificates
326
 * from extraCerts as trust anchor to validate sender cert -
327
 * provided it also can validate the newly enrolled certificate
328
 */
329
static int check_cert_path_3gpp(const OSSL_CMP_CTX *ctx,
330
    const OSSL_CMP_MSG *msg, X509 *scrt)
331
0
{
332
0
    int valid = 0;
333
0
    X509_STORE *store;
334
335
0
    if (!ctx->permitTAInExtraCertsForIR)
336
0
        return 0;
337
338
0
    if ((store = X509_STORE_new()) == NULL
339
0
        || !ossl_cmp_X509_STORE_add1_certs(store, msg->extraCerts,
340
0
            1 /* self-issued only */))
341
0
        goto err;
342
343
    /* store does not include CRLs */
344
0
    valid = OSSL_CMP_validate_cert_path(ctx, store, scrt);
345
0
    if (!valid) {
346
0
        ossl_cmp_warn(ctx,
347
0
            "also exceptional 3GPP mode cert path validation failed");
348
0
    } else if (OSSL_CMP_MSG_get_bodytype(msg) == OSSL_CMP_PKIBODY_IP) {
349
        /*
350
         * verify that the newly enrolled certificate (which assumed rid ==
351
         * OSSL_CMP_CERTREQID) can also be validated with the same trusted store
352
         */
353
0
        OSSL_CMP_CERTRESPONSE *crep = ossl_cmp_certrepmessage_get0_certresponse(msg->body->value.ip,
354
0
            OSSL_CMP_CERTREQID);
355
0
        X509 *newcrt = NULL;
356
357
0
        valid = crep != NULL
358
0
            && (newcrt = ossl_cmp_certresponse_get1_cert(ctx, crep)) != NULL
359
0
            && OSSL_CMP_validate_cert_path(ctx, store, newcrt);
360
0
        X509_free(newcrt);
361
0
    }
362
363
0
err:
364
0
    X509_STORE_free(store);
365
0
    return valid;
366
0
}
367
368
/* checks protection of msg but not cert revocation nor cert chain */
369
static int check_msg_given_cert(const OSSL_CMP_CTX *ctx, X509 *cert,
370
    const OSSL_CMP_MSG *msg)
371
0
{
372
0
    return cert_acceptable(ctx, "previously validated", "sender cert",
373
0
        cert, NULL, NULL, msg);
374
0
}
375
376
/*-
377
 * Try all certs in given list for verifying msg, normally or in 3GPP mode.
378
 * If already_checked1 == NULL then certs are assumed to be the msg->extraCerts.
379
 * On success cache the found cert using ossl_cmp_ctx_set1_validatedSrvCert().
380
 */
381
static int check_msg_with_certs(OSSL_CMP_CTX *ctx, const STACK_OF(X509) *certs,
382
    const char *desc,
383
    const STACK_OF(X509) *already_checked1,
384
    const STACK_OF(X509) *already_checked2,
385
    const OSSL_CMP_MSG *msg, int mode_3gpp)
386
14.2k
{
387
14.2k
    int in_extraCerts = already_checked1 == NULL;
388
14.2k
    int n_acceptable_certs = 0;
389
14.2k
    int i;
390
391
14.2k
    if (sk_X509_num(certs) <= 0) {
392
1.44k
        ossl_cmp_log1(INFO, ctx, "no %s", desc);
393
1.44k
        return 0;
394
1.44k
    }
395
396
41.1k
    for (i = 0; i < sk_X509_num(certs); i++) { /* certs may be NULL */
397
28.3k
        X509 *cert = sk_X509_value(certs, i);
398
399
28.3k
        if (!ossl_assert(cert != NULL))
400
0
            return 0;
401
28.3k
        if (!cert_acceptable(ctx, "cert from", desc, cert,
402
28.3k
                already_checked1, already_checked2, msg))
403
28.2k
            continue;
404
51
        n_acceptable_certs++;
405
51
        if (mode_3gpp ? check_cert_path_3gpp(ctx, msg, cert)
406
51
                      : check_cert_path(ctx, ctx->trusted, cert)) {
407
            /* store successful sender cert for further msgs in transaction */
408
0
            return ossl_cmp_ctx_set1_validatedSrvCert(ctx, cert);
409
0
        }
410
51
    }
411
12.8k
    if (in_extraCerts && n_acceptable_certs == 0)
412
6.37k
        ossl_cmp_log1(WARN, ctx, "no acceptable %s", desc);
413
12.8k
    return 0;
414
12.8k
}
415
416
/*-
417
 * Verify msg trying first ctx->untrusted, which should include extraCerts
418
 * at its front, then trying the trusted certs in truststore (if any) of ctx.
419
 * On success cache the found cert using ossl_cmp_ctx_set1_validatedSrvCert().
420
 */
421
static int check_msg_all_certs(OSSL_CMP_CTX *ctx, const OSSL_CMP_MSG *msg,
422
    int mode_3gpp)
423
14.2k
{
424
14.2k
    int ret = 0;
425
426
14.2k
    if (ctx->permitTAInExtraCertsForIR
427
0
        && OSSL_CMP_MSG_get_bodytype(msg) == OSSL_CMP_PKIBODY_IP)
428
14.2k
        ossl_cmp_info(ctx, mode_3gpp ? "normal mode failed; trying now 3GPP mode trusting extraCerts" : "trying first normal mode using trust store");
429
14.2k
    else if (mode_3gpp)
430
7.14k
        return 0;
431
432
7.14k
    if (check_msg_with_certs(ctx, msg->extraCerts, "extraCerts",
433
7.14k
            NULL, NULL, msg, mode_3gpp))
434
0
        return 1;
435
7.14k
    if (check_msg_with_certs(ctx, ctx->untrusted, "untrusted certs",
436
7.14k
            msg->extraCerts, NULL, msg, mode_3gpp))
437
0
        return 1;
438
439
7.14k
    if (ctx->trusted == NULL) {
440
7.14k
        ossl_cmp_warn(ctx, mode_3gpp ? "no self-issued extraCerts" : "no trusted store");
441
7.14k
    } else {
442
0
        STACK_OF(X509) *trusted = X509_STORE_get1_all_certs(ctx->trusted);
443
444
0
        ret = check_msg_with_certs(ctx, trusted,
445
0
            mode_3gpp ? "self-issued extraCerts"
446
0
                      : "certs in trusted store",
447
0
            msg->extraCerts, ctx->untrusted,
448
0
            msg, mode_3gpp);
449
0
        OSSL_STACK_OF_X509_free(trusted);
450
0
    }
451
7.14k
    return ret;
452
7.14k
}
453
454
/*-
455
 * Verify message signature with any acceptable and valid candidate cert.
456
 * On success cache the found cert using ossl_cmp_ctx_set1_validatedSrvCert().
457
 */
458
static int check_msg_find_cert(OSSL_CMP_CTX *ctx, const OSSL_CMP_MSG *msg)
459
4.07k
{
460
4.07k
    X509 *scrt = ctx->validatedSrvCert; /* previous successful sender cert */
461
4.07k
    GENERAL_NAME *sender = msg->header->sender;
462
4.07k
    char *sname = NULL;
463
4.07k
    char *skid_str = NULL;
464
4.07k
    const ASN1_OCTET_STRING *skid = msg->header->senderKID;
465
4.07k
    OSSL_CMP_log_cb_t backup_log_cb = ctx->log_cb;
466
4.07k
    int res = 0;
467
468
4.07k
    if (sender == NULL || msg->body == NULL)
469
0
        return 0; /* other NULL cases already have been checked */
470
4.07k
    if (sender->type != GEN_DIRNAME) {
471
        /* So far, only X509_NAME is supported */
472
0
        ERR_raise(ERR_LIB_CMP, CMP_R_SENDER_GENERALNAME_TYPE_NOT_SUPPORTED);
473
0
        return 0;
474
0
    }
475
476
    /* dump any hitherto errors to avoid confusion when printing further ones */
477
4.07k
    OSSL_CMP_CTX_print_errors(ctx);
478
479
    /* enable clearing irrelevant errors in attempts to validate sender certs */
480
4.07k
    (void)ERR_set_mark();
481
4.07k
    ctx->log_cb = NULL; /* temporarily disable logging */
482
483
4.07k
    if (scrt != NULL) {
484
        /*-
485
         * try first using cached message sender cert (in 'scrt' variable),
486
         * which was used successfully earlier in the same transaction
487
         * (assuming that the certificate itself was not revoked meanwhile and
488
         *  is a good guess for use in validating also the current message)
489
         */
490
0
        if (check_msg_given_cert(ctx, scrt, msg)) {
491
0
            ctx->log_cb = backup_log_cb;
492
0
            (void)ERR_pop_to_mark();
493
0
            return 1;
494
0
        }
495
        /* cached sender cert has shown to be no more successfully usable */
496
        /* re-do the above check (just) for adding diagnostic information */
497
0
        ossl_cmp_info(ctx,
498
0
            "trying to verify msg signature with previously validated cert");
499
0
        ctx->log_cb = backup_log_cb;
500
0
        (void)check_msg_given_cert(ctx, scrt, msg);
501
0
        ctx->log_cb = NULL;
502
0
        (void)ossl_cmp_ctx_set1_validatedSrvCert(ctx, NULL); /* this invalidates scrt */
503
0
    }
504
505
4.07k
    res = check_msg_all_certs(ctx, msg, 0 /* using ctx->trusted */)
506
4.07k
        || check_msg_all_certs(ctx, msg, 1 /* 3gpp */);
507
508
4.07k
    ctx->log_cb = backup_log_cb; /* re-enable logging */
509
    /* discard any previous diagnostic information on trying to use certs */
510
4.07k
    (void)ERR_pop_to_mark();
511
512
4.07k
    if (res)
513
0
        goto end;
514
    /* failed finding a sender cert that verifies the message signature */
515
516
4.07k
    sname = X509_NAME_oneline(sender->d.directoryName, NULL, 0);
517
4.07k
    skid_str = skid == NULL ? NULL : i2s_ASN1_OCTET_STRING(NULL, skid);
518
4.07k
    if (ctx->log_cb != NULL) {
519
4.07k
        ossl_cmp_info(ctx, "trying to verify msg signature with a valid cert that..");
520
4.07k
        if (sname != NULL)
521
4.07k
            ossl_cmp_log1(INFO, ctx, "matches msg sender    = %s", sname);
522
4.07k
        if (skid_str != NULL)
523
2.16k
            ossl_cmp_log1(INFO, ctx, "matches msg senderKID = %s", skid_str);
524
1.90k
        else
525
4.07k
            ossl_cmp_info(ctx, "while msg header does not contain senderKID");
526
        /* re-do the above checks (just) for adding diagnostic information */
527
4.07k
        (void)check_msg_all_certs(ctx, msg, 0 /* using ctx->trusted */);
528
4.07k
        (void)check_msg_all_certs(ctx, msg, 1 /* 3gpp */);
529
4.07k
    }
530
531
4.07k
    ERR_raise(ERR_LIB_CMP, CMP_R_NO_SUITABLE_SENDER_CERT);
532
4.07k
    if (sname != NULL) {
533
4.07k
        ERR_add_error_txt(NULL, "for msg sender name = ");
534
4.07k
        ERR_add_error_txt(NULL, sname);
535
4.07k
    }
536
4.07k
    if (skid_str != NULL) {
537
2.16k
        ERR_add_error_txt(" and ", "for msg senderKID = ");
538
2.16k
        ERR_add_error_txt(NULL, skid_str);
539
2.16k
    }
540
541
4.07k
end:
542
4.07k
    OPENSSL_free(sname);
543
4.07k
    OPENSSL_free(skid_str);
544
4.07k
    return res;
545
4.07k
}
546
547
/*-
548
 * Validate the protection of the given PKIMessage using either password-
549
 * based mac (PBM) or a signature algorithm. In the case of signature algorithm,
550
 * the sender certificate can have been pinned by providing it in ctx->srvCert,
551
 * else it is searched in msg->extraCerts, ctx->untrusted, in ctx->trusted
552
 * (in this order) and is path is validated against ctx->trusted.
553
 * On success cache the found cert using ossl_cmp_ctx_set1_validatedSrvCert().
554
 *
555
 * If ctx->permitTAInExtraCertsForIR is true and when validating a CMP IP msg,
556
 * the trust anchor for validating the IP msg may be taken from msg->extraCerts
557
 * if a self-issued certificate is found there that can be used to
558
 * validate the enrolled certificate returned in the IP.
559
 * This is according to the need given in 3GPP TS 33.310.
560
 *
561
 * Returns 1 on success, 0 on error or validation failed.
562
 */
563
int OSSL_CMP_validate_msg(OSSL_CMP_CTX *ctx, const OSSL_CMP_MSG *msg)
564
5.61k
{
565
5.61k
    X509 *scrt;
566
567
5.61k
    ossl_cmp_debug(ctx, "validating CMP message");
568
5.61k
    if (ctx == NULL || msg == NULL
569
5.61k
        || msg->header == NULL || msg->body == NULL) {
570
0
        ERR_raise(ERR_LIB_CMP, CMP_R_NULL_ARGUMENT);
571
0
        return 0;
572
0
    }
573
574
5.61k
    if (msg->header->protectionAlg == NULL /* unprotected message */
575
5.61k
        || msg->protection == NULL || msg->protection->data == NULL) {
576
1.24k
        ERR_raise(ERR_LIB_CMP, CMP_R_MISSING_PROTECTION);
577
1.24k
        return 0;
578
1.24k
    }
579
580
4.37k
    switch (ossl_cmp_hdr_get_protection_nid(msg->header)) {
581
        /* 5.1.3.1.  Shared Secret Information */
582
983
    case NID_id_PasswordBasedMAC:
583
983
        if (ctx->secretValue == NULL) {
584
434
            ossl_cmp_info(ctx, "no secret available for verifying PBM-based CMP message protection");
585
434
            ERR_raise(ERR_LIB_CMP, CMP_R_MISSING_SECRET);
586
434
            return 0;
587
434
        }
588
549
        if (verify_PBMAC(ctx, msg)) {
589
            /*
590
             * RFC 9810, 5.3.2: 'Note that if the PKI message protection is
591
             * "shared secret information", then any certificate transported in
592
             * the caPubs field may be directly trusted as a root CA
593
             * certificate by the initiator.'
594
             */
595
4
            switch (OSSL_CMP_MSG_get_bodytype(msg)) {
596
0
            case -1:
597
0
                return 0;
598
0
            case OSSL_CMP_PKIBODY_IP:
599
0
            case OSSL_CMP_PKIBODY_CP:
600
0
            case OSSL_CMP_PKIBODY_KUP:
601
2
            case OSSL_CMP_PKIBODY_CCP:
602
2
                if (ctx->trusted != NULL) {
603
0
                    STACK_OF(X509) *certs = msg->body->value.ip->caPubs;
604
                    /* value.ip is same for cp, kup, and ccp */
605
606
0
                    if (!ossl_cmp_X509_STORE_add1_certs(ctx->trusted, certs, 0))
607
                        /* adds both self-issued and not self-issued certs */
608
0
                        return 0;
609
0
                }
610
2
                break;
611
2
            default:
612
2
                break;
613
4
            }
614
4
            ossl_cmp_debug(ctx,
615
4
                "successfully validated PBM-based CMP message protection");
616
4
            return 1;
617
4
        }
618
545
        ossl_cmp_warn(ctx, "verifying PBM-based CMP message protection failed");
619
545
        break;
620
621
        /*
622
         * 5.1.3.2 DH Key Pairs
623
         * Not yet supported
624
         */
625
32
    case NID_id_DHBasedMac:
626
32
        ERR_raise(ERR_LIB_CMP, CMP_R_UNSUPPORTED_PROTECTION_ALG_DHBASEDMAC);
627
32
        break;
628
629
        /*
630
         * 5.1.3.3.  Signature
631
         */
632
3.35k
    default:
633
3.35k
        scrt = ctx->srvCert;
634
3.35k
        if (scrt == NULL) {
635
3.35k
            if (ctx->trusted == NULL && ctx->secretValue != NULL) {
636
1.25k
                ossl_cmp_info(ctx, "no trust store nor pinned sender cert available for verifying signature-based CMP message protection");
637
1.25k
                ERR_raise(ERR_LIB_CMP, CMP_R_MISSING_TRUST_ANCHOR);
638
1.25k
                return 0;
639
1.25k
            }
640
2.10k
            if (check_msg_find_cert(ctx, msg)) {
641
0
                ossl_cmp_log1(DEBUG, ctx,
642
0
                    "successfully validated signature-based CMP message protection using trust store%s",
643
0
                    ctx->permitTAInExtraCertsForIR ? " or 3GPP mode" : "");
644
0
                return 1;
645
0
            }
646
2.10k
        } else { /* use pinned sender cert */
647
            /* use ctx->srvCert for signature check even if not acceptable */
648
0
            if (verify_signature(ctx, msg, scrt)) {
649
0
                ossl_cmp_debug(ctx,
650
0
                    "successfully validated signature-based CMP message protection using pinned sender cert");
651
0
                return ossl_cmp_ctx_set1_validatedSrvCert(ctx, scrt);
652
0
            }
653
0
            ossl_cmp_warn(ctx, "CMP message signature verification failed");
654
0
            ERR_raise(ERR_LIB_CMP, CMP_R_SRVCERT_DOES_NOT_VALIDATE_MSG);
655
0
        }
656
2.10k
        break;
657
4.37k
    }
658
2.68k
    return 0;
659
4.37k
}
660
661
static int check_transactionID_or_nonce(ASN1_OCTET_STRING *expected,
662
    ASN1_OCTET_STRING *actual, int reason)
663
82.2k
{
664
82.2k
    if (expected != NULL
665
0
        && (actual == NULL || ASN1_OCTET_STRING_cmp(expected, actual) != 0)) {
666
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
667
        char *expected_str, *actual_str;
668
669
        expected_str = i2s_ASN1_OCTET_STRING(NULL, expected);
670
        actual_str = actual == NULL ? NULL : i2s_ASN1_OCTET_STRING(NULL, actual);
671
        ERR_raise_data(ERR_LIB_CMP, reason,
672
            "expected = %s, actual = %s",
673
            expected_str == NULL ? "?" : expected_str,
674
            actual == NULL ? "(none)" : actual_str == NULL ? "?"
675
                                                           : actual_str);
676
        OPENSSL_free(expected_str);
677
        OPENSSL_free(actual_str);
678
        return 0;
679
#endif
680
0
    }
681
82.2k
    return 1;
682
82.2k
}
683
684
/*-
685
 * Check received message (i.e., response by server or request from client)
686
 * Any msg->extraCerts are prepended to ctx->untrusted.
687
 *
688
 * Ensures that:
689
 * its sender is of appropriate type (currently only X509_NAME) and
690
 *     matches any expected sender or srvCert subject given in the ctx
691
 * it has a valid body type
692
 * its protection is valid (or invalid/absent, but only if a callback function
693
 *     is present and yields a positive result using also the supplied argument)
694
 * its transaction ID matches the previous transaction ID stored in ctx (if any)
695
 * its recipNonce matches the previous senderNonce stored in the ctx (if any)
696
 *
697
 * If everything is fine:
698
 * learns the senderNonce from the received message,
699
 * learns the transaction ID if it is not yet in ctx,
700
 * and makes any certs in caPubs directly trusted.
701
 *
702
 * Returns 1 on success, 0 on error.
703
 */
704
int ossl_cmp_msg_check_update(OSSL_CMP_CTX *ctx, const OSSL_CMP_MSG *msg,
705
    ossl_cmp_allow_unprotected_cb_t cb, int cb_arg)
706
33.2k
{
707
33.2k
    OSSL_CMP_PKIHEADER *hdr;
708
33.2k
    const X509_NAME *expected_sender;
709
33.2k
    int num_untrusted, num_added, res;
710
711
33.2k
    if (!ossl_assert(ctx != NULL && msg != NULL && msg->header != NULL))
712
0
        return 0;
713
33.2k
    hdr = OSSL_CMP_MSG_get0_header(msg);
714
715
    /* If expected_sender is given, validate sender name of received msg */
716
33.2k
    expected_sender = ctx->expected_sender;
717
33.2k
    if (expected_sender == NULL && ctx->srvCert != NULL)
718
0
        expected_sender = X509_get_subject_name(ctx->srvCert);
719
33.2k
    if (expected_sender != NULL) {
720
0
        const X509_NAME *actual_sender;
721
0
        char *str;
722
723
0
        if (hdr->sender->type != GEN_DIRNAME) {
724
0
            ERR_raise(ERR_LIB_CMP, CMP_R_SENDER_GENERALNAME_TYPE_NOT_SUPPORTED);
725
0
            return 0;
726
0
        }
727
0
        actual_sender = hdr->sender->d.directoryName;
728
        /*
729
         * Compare actual sender name of response with expected sender name.
730
         * Mitigates risk of accepting misused PBM secret or
731
         * misused certificate of an unauthorized entity of a trusted hierarchy.
732
         */
733
0
        if (!check_name(ctx, 0, "sender DN field", actual_sender,
734
0
                "expected sender", expected_sender)) {
735
0
            str = X509_NAME_oneline(actual_sender, NULL, 0);
736
0
            ERR_raise_data(ERR_LIB_CMP, CMP_R_UNEXPECTED_SENDER,
737
0
                str != NULL ? str : "<unknown>");
738
0
            OPENSSL_free(str);
739
0
            return 0;
740
0
        }
741
0
    }
742
    /* Note: if recipient was NULL-DN it could be learned here if needed */
743
744
33.2k
    num_added = sk_X509_num(msg->extraCerts);
745
33.2k
    if (num_added > 10)
746
0
        ossl_cmp_log1(WARN, ctx, "received CMP message contains %d extraCerts",
747
33.2k
            num_added);
748
    /*
749
     * Store any provided extraCerts in ctx for use in OSSL_CMP_validate_msg()
750
     * and for future use, such that they are available to ctx->certConf_cb and
751
     * the peer does not need to send them again in the same transaction.
752
     * Note that it does not help validating the message before storing the
753
     * extraCerts because they do not belong to the protected msg part anyway.
754
     * The extraCerts are prepended. Allows simple removal if they shall not be
755
     * cached. Also they get used first, which is likely good for efficiency.
756
     */
757
33.2k
    num_untrusted = ctx->untrusted == NULL ? 0 : sk_X509_num(ctx->untrusted);
758
33.2k
    res = ossl_x509_add_certs_new(&ctx->untrusted, msg->extraCerts,
759
        /* this allows self-signed certs */
760
33.2k
        X509_ADD_FLAG_UP_REF | X509_ADD_FLAG_NO_DUP
761
33.2k
            | X509_ADD_FLAG_PREPEND);
762
33.2k
    num_added = (ctx->untrusted == NULL ? 0 : sk_X509_num(ctx->untrusted))
763
33.2k
        - num_untrusted;
764
33.2k
    if (!res) {
765
0
        while (num_added-- > 0)
766
0
            X509_free(sk_X509_shift(ctx->untrusted));
767
0
        return 0;
768
0
    }
769
770
33.2k
    if (hdr->protectionAlg != NULL)
771
9.23k
        res = OSSL_CMP_validate_msg(ctx, msg)
772
            /* explicitly permitted exceptions for invalid protection: */
773
9.23k
            || (cb != NULL && (*cb)(ctx, msg, 1, cb_arg) > 0);
774
24.0k
    else
775
        /* explicitly permitted exceptions for missing protection: */
776
24.0k
        res = cb != NULL && (*cb)(ctx, msg, 0, cb_arg) > 0;
777
33.2k
#ifdef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
778
33.2k
    res = 1; /* support more aggressive fuzzing by letting invalid msg pass */
779
33.2k
#endif
780
781
    /* remove extraCerts again if not caching */
782
33.2k
    if (ctx->noCacheExtraCerts)
783
0
        while (num_added-- > 0)
784
0
            X509_free(sk_X509_shift(ctx->untrusted));
785
786
33.2k
    if (!res) {
787
0
        if (hdr->protectionAlg != NULL)
788
0
            ERR_raise(ERR_LIB_CMP, CMP_R_ERROR_VALIDATING_PROTECTION);
789
0
        else
790
0
            ERR_raise(ERR_LIB_CMP, CMP_R_MISSING_PROTECTION);
791
0
        return 0;
792
0
    }
793
794
    /* check CMP version number in header */
795
33.2k
    if (ossl_cmp_hdr_get_pvno(hdr) != OSSL_CMP_PVNO_2
796
25.0k
        && ossl_cmp_hdr_get_pvno(hdr) != OSSL_CMP_PVNO_3) {
797
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
798
        ERR_raise(ERR_LIB_CMP, CMP_R_UNEXPECTED_PVNO);
799
        return 0;
800
#endif
801
25.0k
    }
802
803
33.2k
    if (OSSL_CMP_MSG_get_bodytype(msg) < 0) {
804
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
805
        ERR_raise(ERR_LIB_CMP, CMP_R_PKIBODY_ERROR);
806
        return 0;
807
#endif
808
0
    }
809
810
    /* compare received transactionID with the expected one in previous msg */
811
33.2k
    if (!check_transactionID_or_nonce(ctx->transactionID, hdr->transactionID,
812
33.2k
            CMP_R_TRANSACTIONID_UNMATCHED))
813
0
        return 0;
814
815
    /*
816
     * enable clearing irrelevant errors
817
     * in attempts to validate recipient nonce in case of delayed delivery.
818
     */
819
33.2k
    (void)ERR_set_mark();
820
    /* compare received nonce with the one we sent */
821
33.2k
    if (!check_transactionID_or_nonce(ctx->senderNonce, hdr->recipNonce,
822
33.2k
            CMP_R_RECIPNONCE_UNMATCHED)) {
823
        /* check if we are polling and received final response */
824
0
        if (ctx->first_senderNonce == NULL
825
0
            || OSSL_CMP_MSG_get_bodytype(msg) == OSSL_CMP_PKIBODY_POLLREP
826
            /* compare received nonce with our sender nonce at poll start */
827
0
            || !check_transactionID_or_nonce(ctx->first_senderNonce,
828
0
                hdr->recipNonce,
829
0
                CMP_R_RECIPNONCE_UNMATCHED)) {
830
0
            (void)ERR_clear_last_mark();
831
0
            return 0;
832
0
        }
833
0
    }
834
33.2k
    (void)ERR_pop_to_mark();
835
836
    /* if not yet present, learn transactionID */
837
33.2k
    if (ctx->transactionID == NULL
838
33.2k
        && !OSSL_CMP_CTX_set1_transactionID(ctx, hdr->transactionID))
839
0
        return 0;
840
841
    /*
842
     * RFC 9810 section 5.1.1 states: the recipNonce is copied from
843
     * the senderNonce of the previous message in the transaction.
844
     * --> Store for setting in next message
845
     */
846
33.2k
    if (!ossl_cmp_ctx_set1_recipNonce(ctx, hdr->senderNonce))
847
0
        return 0;
848
849
33.2k
    if (ossl_cmp_hdr_get_protection_nid(hdr) == NID_id_PasswordBasedMAC) {
850
        /*
851
         * RFC 9810, 5.3.2: 'Note that if the PKI message protection is
852
         * "shared secret information", then any certificate transported in
853
         * the caPubs field may be directly trusted as a root CA
854
         * certificate by the initiator.'
855
         */
856
3.01k
        switch (OSSL_CMP_MSG_get_bodytype(msg)) {
857
9
        case OSSL_CMP_PKIBODY_IP:
858
20
        case OSSL_CMP_PKIBODY_CP:
859
24
        case OSSL_CMP_PKIBODY_KUP:
860
50
        case OSSL_CMP_PKIBODY_CCP:
861
50
            if (ctx->trusted != NULL) {
862
0
                STACK_OF(X509) *certs = msg->body->value.ip->caPubs;
863
                /* value.ip is same for cp, kup, and ccp */
864
865
0
                if (!ossl_cmp_X509_STORE_add1_certs(ctx->trusted, certs, 0))
866
                    /* adds both self-issued and not self-issued certs */
867
0
                    return 0;
868
0
            }
869
50
            break;
870
2.96k
        default:
871
2.96k
            break;
872
3.01k
        }
873
3.01k
    }
874
33.2k
    return 1;
875
33.2k
}
876
877
int ossl_cmp_verify_popo(const OSSL_CMP_CTX *ctx,
878
    const OSSL_CMP_MSG *msg, int acceptRAVerified)
879
5.73k
{
880
5.73k
    if (!ossl_assert(msg != NULL && msg->body != NULL))
881
0
        return 0;
882
5.73k
    switch (msg->body->type) {
883
3.39k
    case OSSL_CMP_PKIBODY_P10CR: {
884
3.39k
        X509_REQ *req = msg->body->value.p10cr;
885
886
3.39k
        if (X509_REQ_verify_ex(req, X509_REQ_get0_pubkey(req), ctx->libctx,
887
3.39k
                ctx->propq)
888
3.39k
            <= 0) {
889
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
890
            ERR_raise(ERR_LIB_CMP, CMP_R_REQUEST_NOT_ACCEPTED);
891
            return 0;
892
#endif
893
3.38k
        }
894
3.39k
    } break;
895
1.26k
    case OSSL_CMP_PKIBODY_IR:
896
2.01k
    case OSSL_CMP_PKIBODY_CR:
897
2.34k
    case OSSL_CMP_PKIBODY_KUR:
898
2.34k
        if (!OSSL_CRMF_MSGS_verify_popo(msg->body->value.ir, OSSL_CMP_CERTREQID,
899
2.34k
                acceptRAVerified,
900
2.34k
                ctx->libctx, ctx->propq)) {
901
#ifndef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
902
            return 0;
903
#endif
904
2.23k
        }
905
2.34k
        break;
906
0
    default:
907
0
        ERR_raise(ERR_LIB_CMP, CMP_R_PKIBODY_ERROR);
908
0
        return 0;
909
5.73k
    }
910
5.73k
    return 1;
911
5.73k
}