Coverage Report

Created: 2026-09-12 06:55

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/openssl36/crypto/ml_dsa/ml_dsa_sign.c
Line
Count
Source
1
/*
2
 * Copyright 2024-2026 The OpenSSL Project Authors. All Rights Reserved.
3
 *
4
 * Licensed under the Apache License 2.0 (the "License").  You may not use
5
 * this file except in compliance with the License.  You can obtain a copy
6
 * in the file LICENSE in the source distribution or at
7
 * https://www.openssl.org/source/license.html
8
 */
9
10
#include <openssl/core_dispatch.h>
11
#include <openssl/core_names.h>
12
#include <openssl/params.h>
13
#include <openssl/rand.h>
14
#include <openssl/err.h>
15
#include <openssl/proverr.h>
16
#include "internal/common.h"
17
#include "ml_dsa_local.h"
18
#include "ml_dsa_key.h"
19
#include "ml_dsa_matrix.h"
20
#include "ml_dsa_sign.h"
21
#include "ml_dsa_hash.h"
22
23
#define ML_DSA_MAX_LAMBDA 256 /* bit strength for ML-DSA-87 */
24
25
/*
26
 * @brief Initialize a Signature object by pointing all of its objects to
27
 * preallocated blocks. The values passed for hint, z and
28
 * c_tilde values are not owned/freed by the |sig| object.
29
 *
30
 * @param sig The ML_DSA_SIG to initialize.
31
 * @param hint A preallocated array of |k| polynomial blocks
32
 * @param k The number of |hint| polynomials
33
 * @param z A preallocated array of |l| polynomial blocks
34
 * @param l The number of |z| polynomials
35
 * @param c_tilde A preallocated buffer
36
 * @param c_tilde_len The size of |c_tilde|
37
 */
38
static void signature_init(ML_DSA_SIG *sig,
39
    POLY *hint, uint32_t k, POLY *z, uint32_t l,
40
    uint8_t *c_tilde, size_t c_tilde_len)
41
1.78k
{
42
1.78k
    vector_init(&sig->z, z, l);
43
1.78k
    vector_init(&sig->hint, hint, k);
44
1.78k
    sig->c_tilde = c_tilde;
45
1.78k
    sig->c_tilde_len = c_tilde_len;
46
1.78k
}
47
48
/*
49
 * @brief: Auxiliary functions to compute ML-DSA's MU.
50
 * This combines the steps of creating M' and concatenating it
51
 * to the Public Key Hash to obtain MU.
52
 * See FIPS 204 Algorithm 2 Step 10 (and algorithm 3 Step 5) as
53
 * well as Algorithm 7 Step 6 (and algorithm 8 Step 7)
54
 *
55
 * ML_DSA pure signatures are encoded as M' = 00 || ctx_len || ctx || msg
56
 * Where ctx is the empty string by default and ctx_len <= 255.
57
 * The message is appended to the encoded context.
58
 * Finally a public key hash is prepended, and the whole is hashed
59
 * to derive the mu value.
60
 *
61
 * @param key: A public or private ML-DSA key;
62
 * @param encode: if not set, assumes that M' is provided raw and the
63
 * following parameters are ignored.
64
 * @param ctx An optional context to add to the message encoding.
65
 * @param ctx_len The size of |ctx|. It must be in the range 0..255
66
 * @returns an EVP_MD_CTX if the operation is successful, NULL otherwise.
67
 */
68
69
EVP_MD_CTX *ossl_ml_dsa_mu_init(const ML_DSA_KEY *key, int encode,
70
    const uint8_t *ctx, size_t ctx_len)
71
394
{
72
394
    EVP_MD_CTX *md_ctx;
73
394
    uint8_t itb[2];
74
75
394
    if (key == NULL)
76
0
        return NULL;
77
78
394
    md_ctx = EVP_MD_CTX_new();
79
394
    if (md_ctx == NULL)
80
0
        return NULL;
81
82
    /* H(.. */
83
394
    if (!EVP_DigestInit_ex2(md_ctx, key->shake256_md, NULL))
84
0
        goto err;
85
    /* ..pk (= key->tr) */
86
394
    if (!EVP_DigestUpdate(md_ctx, key->tr, sizeof(key->tr)))
87
0
        goto err;
88
    /* M' = .. */
89
394
    if (encode) {
90
394
        if (ctx_len > ML_DSA_MAX_CONTEXT_STRING_LEN)
91
0
            goto err;
92
        /* IntegerToBytes(0, 1) .. */
93
394
        itb[0] = 0;
94
        /* || IntegerToBytes(|ctx|, 1) || .. */
95
394
        itb[1] = (uint8_t)ctx_len;
96
394
        if (!EVP_DigestUpdate(md_ctx, itb, 2))
97
0
            goto err;
98
        /* ctx || .. */
99
394
        if (!EVP_DigestUpdate(md_ctx, ctx, ctx_len))
100
0
            goto err;
101
        /* .. msg) will follow in update and final functions */
102
394
    }
103
104
394
    return md_ctx;
105
106
0
err:
107
0
    EVP_MD_CTX_free(md_ctx);
108
0
    return NULL;
109
394
}
110
111
/*
112
 * @brief: updates the internal ML-DSA hash with an additional message chunk.
113
 *
114
 * @param md_ctx: The hashing context
115
 * @param msg: The next message chunk
116
 * @param msg_len: The length of the msg buffer to process
117
 * @returns 1 on success, 0 on error
118
 */
119
int ossl_ml_dsa_mu_update(EVP_MD_CTX *md_ctx, const uint8_t *msg, size_t msg_len)
120
1.37k
{
121
1.37k
    return EVP_DigestUpdate(md_ctx, msg, msg_len);
122
1.37k
}
123
124
/*
125
 * @brief: finalizes the internal ML-DSA hash
126
 *
127
 * @param md_ctx: The hashing context
128
 * @param mu: The output buffer for Mu
129
 * @param mu_len: The size of the output buffer
130
 * @returns 1 on success, 0 on error
131
 */
132
int ossl_ml_dsa_mu_finalize(EVP_MD_CTX *md_ctx, uint8_t *mu, size_t mu_len)
133
1.36k
{
134
1.36k
    if (!ossl_assert(mu_len == ML_DSA_MU_BYTES)) {
135
0
        ERR_raise(ERR_LIB_PROV, PROV_R_BAD_LENGTH);
136
0
        return 0;
137
0
    }
138
1.36k
    return EVP_DigestSqueeze(md_ctx, mu, mu_len);
139
1.36k
}
140
141
/*
142
 * @brief FIPS 204, Algorithm 7, ML-DSA.Sign_internal()
143
 *
144
 * This algorithm is decomposed in 2 steps, a set of functions to compute mu
145
 * and then the actual signing function.
146
 *
147
 * @param priv: The private ML-DSA key
148
 * @param mu: The pre-computed mu hash
149
 * @param mu_len: The length of the mu buffer
150
 * @param rnd: The random buffer
151
 * @param rnd_len: The length of the random buffer
152
 * @param out_sig: The output signature buffer
153
 * @returns 1 on success, 0 on error
154
 */
155
static int ml_dsa_sign_internal(const ML_DSA_KEY *priv,
156
    const uint8_t *mu, size_t mu_len,
157
    const uint8_t *rnd, size_t rnd_len,
158
    uint8_t *out_sig)
159
418
{
160
418
    int ret = 0;
161
418
    const ML_DSA_PARAMS *params = priv->params;
162
418
    EVP_MD_CTX *md_ctx = NULL;
163
418
    uint32_t k = (uint32_t)params->k, l = (uint32_t)params->l;
164
418
    uint32_t gamma1 = params->gamma1, gamma2 = params->gamma2;
165
418
    uint8_t *alloc = NULL, *w1_encoded;
166
418
    size_t alloc_len, w1_encoded_len;
167
418
    size_t num_polys_sig_k = 2 * k;
168
418
    size_t num_polys_k = 5 * k;
169
418
    size_t num_polys_l = 3 * l;
170
418
    size_t num_polys_k_by_l = k * l;
171
418
    POLY *p, *c_ntt;
172
418
    VECTOR s1_ntt, s2_ntt, t0_ntt, w, w1, cs1, cs2, y;
173
418
    MATRIX a_ntt;
174
418
    ML_DSA_SIG sig;
175
418
    uint8_t rho_prime[ML_DSA_RHO_PRIME_BYTES];
176
418
    uint8_t c_tilde[ML_DSA_MAX_LAMBDA / 4];
177
418
    size_t c_tilde_len = params->bit_strength >> 2;
178
418
    size_t kappa;
179
180
418
    if (mu_len != ML_DSA_MU_BYTES) {
181
0
        ERR_raise(ERR_LIB_PROV, PROV_R_BAD_LENGTH);
182
0
        return 0;
183
0
    }
184
185
    /*
186
     * Allocate a single blob for most of the variable size temporary variables.
187
     * Mostly used for VECTOR POLYNOMIALS (every POLY is 1K).
188
     */
189
418
    w1_encoded_len = k * (gamma2 == ML_DSA_GAMMA2_Q_MINUS1_DIV88 ? 192 : 128);
190
418
    alloc_len = w1_encoded_len
191
418
        + sizeof(*p) * (1 + num_polys_k + num_polys_l + num_polys_k_by_l + num_polys_sig_k);
192
418
    alloc = OPENSSL_malloc(alloc_len);
193
418
    if (alloc == NULL)
194
0
        return 0;
195
418
    md_ctx = EVP_MD_CTX_new();
196
418
    if (md_ctx == NULL)
197
0
        goto err;
198
199
418
    w1_encoded = alloc;
200
    /* Init the temp vectors to point to the allocated polys blob */
201
418
    p = (POLY *)(w1_encoded + w1_encoded_len);
202
418
    c_ntt = p++;
203
418
    matrix_init(&a_ntt, p, k, l);
204
418
    p += num_polys_k_by_l;
205
418
    vector_init(&s2_ntt, p, k);
206
418
    vector_init(&t0_ntt, s2_ntt.poly + k, k);
207
418
    vector_init(&w, t0_ntt.poly + k, k);
208
418
    vector_init(&w1, w.poly + k, k);
209
418
    vector_init(&cs2, w1.poly + k, k);
210
418
    p += num_polys_k;
211
418
    vector_init(&s1_ntt, p, l);
212
418
    vector_init(&y, p + l, l);
213
418
    vector_init(&cs1, p + 2 * l, l);
214
418
    p += num_polys_l;
215
418
    signature_init(&sig, p, k, p + k, l, c_tilde, c_tilde_len);
216
    /* End of the allocated blob setup */
217
218
418
    if (!matrix_expand_A(md_ctx, priv->shake128_md, priv->rho, &a_ntt))
219
0
        goto err;
220
221
418
    if (!shake_xof_3(md_ctx, priv->shake256_md, priv->K, sizeof(priv->K),
222
418
            rnd, rnd_len, mu, mu_len,
223
418
            rho_prime, sizeof(rho_prime)))
224
0
        goto err;
225
226
418
    vector_copy(&s1_ntt, &priv->s1);
227
418
    vector_ntt(&s1_ntt);
228
418
    vector_copy(&s2_ntt, &priv->s2);
229
418
    vector_ntt(&s2_ntt);
230
418
    vector_copy(&t0_ntt, &priv->t0);
231
418
    vector_ntt(&t0_ntt);
232
233
    /*
234
     * kappa must not exceed 2^16. But the probability of it
235
     * exceeding even 1000 iterations is vanishingly small.
236
     */
237
1.97k
    for (kappa = 0;; kappa += l) {
238
1.97k
        VECTOR *y_ntt = &cs1;
239
1.97k
        VECTOR *r0 = &w1;
240
1.97k
        VECTOR *ct0 = &w1;
241
1.97k
        uint32_t z_max, r0_max, ct0_max, h_ones;
242
243
1.97k
        vector_expand_mask(&y, rho_prime, sizeof(rho_prime), (uint32_t)kappa,
244
1.97k
            gamma1, md_ctx, priv->shake256_md);
245
1.97k
        vector_copy(y_ntt, &y);
246
1.97k
        vector_ntt(y_ntt);
247
248
1.97k
        matrix_mult_vector(&a_ntt, y_ntt, &w);
249
1.97k
        vector_ntt_inverse(&w);
250
251
1.97k
        vector_high_bits(&w, gamma2, &w1);
252
1.97k
        ossl_ml_dsa_w1_encode(&w1, gamma2, w1_encoded, w1_encoded_len);
253
254
1.97k
        if (!shake_xof_2(md_ctx, priv->shake256_md, mu, mu_len,
255
1.97k
                w1_encoded, w1_encoded_len, c_tilde, c_tilde_len))
256
0
            break;
257
258
1.97k
        if (!poly_sample_in_ball_ntt(c_ntt, c_tilde, (int)c_tilde_len,
259
1.97k
                md_ctx, priv->shake256_md, params->tau))
260
0
            break;
261
262
1.97k
        vector_mult_scalar(&s1_ntt, c_ntt, &cs1);
263
1.97k
        vector_ntt_inverse(&cs1);
264
1.97k
        vector_mult_scalar(&s2_ntt, c_ntt, &cs2);
265
1.97k
        vector_ntt_inverse(&cs2);
266
267
1.97k
        vector_add(&y, &cs1, &sig.z);
268
269
        /* r0 = lowbits(w - cs2) */
270
1.97k
        vector_sub(&w, &cs2, r0);
271
1.97k
        vector_low_bits(r0, gamma2, r0);
272
273
        /*
274
         * Leaking that the signature is rejected is fine as the next attempt at a
275
         * signature will be (indistinguishable from) independent of this one.
276
         */
277
1.97k
        z_max = vector_max(&sig.z);
278
1.97k
        r0_max = vector_max_signed(r0);
279
1.97k
        if (value_barrier_32(constant_time_ge(z_max, gamma1 - params->beta)
280
1.97k
                | constant_time_ge(r0_max, gamma2 - params->beta)))
281
1.54k
            continue;
282
283
424
        vector_mult_scalar(&t0_ntt, c_ntt, ct0);
284
424
        vector_ntt_inverse(ct0);
285
424
        vector_make_hint(ct0, &cs2, &w, gamma2, &sig.hint);
286
287
424
        ct0_max = vector_max(ct0);
288
424
        h_ones = (uint32_t)vector_count_ones(&sig.hint);
289
        /* Same reasoning applies to the leak as above */
290
424
        if (value_barrier_32(constant_time_ge(ct0_max, gamma2)
291
424
                | constant_time_lt(params->omega, h_ones)))
292
6
            continue;
293
418
        ret = ossl_ml_dsa_sig_encode(&sig, params, out_sig);
294
418
        break;
295
424
    }
296
418
err:
297
418
    EVP_MD_CTX_free(md_ctx);
298
418
    OPENSSL_clear_free(alloc, alloc_len);
299
418
    OPENSSL_cleanse(rho_prime, sizeof(rho_prime));
300
418
    OPENSSL_cleanse(c_tilde, sizeof(c_tilde));
301
418
    return ret;
302
418
}
303
304
/*
305
 * @brief FIPS 204, Algorithm 8, ML-DSA.Verify_internal().
306
 *
307
 * This algorithm is decomposed in 2 steps, a set of functions to compute mu
308
 * and then the actual verification function.
309
 *
310
 * @param pub: The public ML-DSA key
311
 * @param mu: The pre-computed mu hash
312
 * @param mu_len: The length of the mu buffer
313
 * @param sig_enc: The encoded signature to be verified
314
 * @param sig_enc_len: the encoded csignature length
315
 * @returns 1 on success, 0 on error
316
 */
317
static int ml_dsa_verify_internal(const ML_DSA_KEY *pub,
318
    const uint8_t *mu, size_t mu_len,
319
    const uint8_t *sig_enc,
320
    size_t sig_enc_len)
321
197
{
322
197
    int ret = 0;
323
197
    uint8_t *alloc = NULL, *w1_encoded;
324
197
    POLY *p, *c_ntt;
325
197
    MATRIX a_ntt;
326
197
    VECTOR az_ntt, ct1_ntt, *z_ntt, *w1, *w_approx;
327
197
    ML_DSA_SIG sig;
328
197
    const ML_DSA_PARAMS *params = pub->params;
329
197
    uint32_t k = (uint32_t)pub->params->k;
330
197
    uint32_t l = (uint32_t)pub->params->l;
331
197
    uint32_t gamma2 = params->gamma2;
332
197
    size_t w1_encoded_len;
333
197
    size_t num_polys_sig = k + l;
334
197
    size_t num_polys_k = 2 * k;
335
197
    size_t num_polys_l = 1 * l;
336
197
    size_t num_polys_k_by_l = k * l;
337
197
    uint8_t c_tilde[ML_DSA_MAX_LAMBDA / 4];
338
197
    uint8_t c_tilde_sig[ML_DSA_MAX_LAMBDA / 4];
339
197
    EVP_MD_CTX *md_ctx = NULL;
340
197
    size_t c_tilde_len = params->bit_strength >> 2;
341
197
    uint32_t z_max;
342
343
197
    if (mu_len != ML_DSA_MU_BYTES) {
344
0
        ERR_raise(ERR_LIB_PROV, PROV_R_BAD_LENGTH);
345
0
        return 0;
346
0
    }
347
348
    /* Allocate space for all the POLYNOMIALS used by temporary VECTORS */
349
197
    w1_encoded_len = k * (gamma2 == ML_DSA_GAMMA2_Q_MINUS1_DIV88 ? 192 : 128);
350
197
    alloc = OPENSSL_malloc(w1_encoded_len
351
197
        + sizeof(*p) * (1 + num_polys_k + num_polys_l + num_polys_k_by_l + num_polys_sig));
352
197
    if (alloc == NULL)
353
0
        return 0;
354
197
    md_ctx = EVP_MD_CTX_new();
355
197
    if (md_ctx == NULL)
356
0
        goto err;
357
358
197
    w1_encoded = alloc;
359
    /* Init the temp vectors to point to the allocated polys blob */
360
197
    p = (POLY *)(w1_encoded + w1_encoded_len);
361
197
    c_ntt = p++;
362
197
    matrix_init(&a_ntt, p, k, l);
363
197
    p += num_polys_k_by_l;
364
197
    signature_init(&sig, p, k, p + k, l, c_tilde_sig, c_tilde_len);
365
197
    p += num_polys_sig;
366
197
    vector_init(&az_ntt, p, k);
367
197
    vector_init(&ct1_ntt, p + k, k);
368
369
197
    if (!ossl_ml_dsa_sig_decode(&sig, sig_enc, sig_enc_len, pub->params)
370
197
        || !matrix_expand_A(md_ctx, pub->shake128_md, pub->rho, &a_ntt))
371
0
        goto err;
372
373
    /* Compute verifiers challenge c_ntt = NTT(SampleInBall(c_tilde)) */
374
197
    if (!poly_sample_in_ball_ntt(c_ntt, c_tilde_sig, (int)c_tilde_len,
375
197
            md_ctx, pub->shake256_md, params->tau))
376
0
        goto err;
377
378
    /* ct1_ntt = NTT(c) * NTT(t1 * 2^d) */
379
197
    vector_scale_power2_round_ntt(&pub->t1, &ct1_ntt);
380
197
    vector_mult_scalar(&ct1_ntt, c_ntt, &ct1_ntt);
381
382
    /* compute z_max early in order to reuse sig.z */
383
197
    z_max = vector_max(&sig.z);
384
385
    /* w_approx = NTT_inverse(A * NTT(z) - ct1_ntt) */
386
197
    z_ntt = &sig.z;
387
197
    vector_ntt(z_ntt);
388
197
    matrix_mult_vector(&a_ntt, z_ntt, &az_ntt);
389
197
    w_approx = &az_ntt;
390
197
    vector_sub(&az_ntt, &ct1_ntt, w_approx);
391
197
    vector_ntt_inverse(w_approx);
392
393
    /* compute w1_encoded */
394
197
    w1 = w_approx;
395
197
    vector_use_hint(&sig.hint, w_approx, gamma2, w1);
396
197
    ossl_ml_dsa_w1_encode(w1, gamma2, w1_encoded, w1_encoded_len);
397
398
197
    if (!shake_xof_3(md_ctx, pub->shake256_md, mu, mu_len,
399
197
            w1_encoded, w1_encoded_len, NULL, 0, c_tilde, c_tilde_len))
400
0
        goto err;
401
402
197
    ret = (z_max < (uint32_t)(params->gamma1 - params->beta))
403
197
        && memcmp(c_tilde, sig.c_tilde, c_tilde_len) == 0;
404
197
err:
405
197
    OPENSSL_free(alloc);
406
197
    EVP_MD_CTX_free(md_ctx);
407
197
    return ret;
408
197
}
409
410
/**
411
 * See FIPS 204 Section 5.2 Algorithm 2 ML-DSA.Sign()
412
 *
413
 * @returns 1 on success, or 0 on error.
414
 */
415
int ossl_ml_dsa_sign(const ML_DSA_KEY *priv, int msg_is_mu,
416
    const uint8_t *msg, size_t msg_len,
417
    const uint8_t *context, size_t context_len,
418
    const uint8_t *rand, size_t rand_len, int encode,
419
    unsigned char *sig, size_t *sig_len, size_t sig_size)
420
1.36k
{
421
1.36k
    EVP_MD_CTX *md_ctx = NULL;
422
1.36k
    uint8_t mu[ML_DSA_MU_BYTES];
423
1.36k
    const uint8_t *mu_ptr = mu;
424
1.36k
    size_t mu_len = sizeof(mu);
425
1.36k
    int ret = 0;
426
427
1.36k
    if (ossl_ml_dsa_key_get_priv(priv) == NULL)
428
0
        return 0;
429
430
1.36k
    if (sig_len != NULL)
431
1.36k
        *sig_len = priv->params->sig_len;
432
433
1.36k
    if (sig == NULL)
434
681
        return (sig_len != NULL) ? 1 : 0;
435
436
681
    if (sig_size < priv->params->sig_len)
437
0
        return 0;
438
439
681
    if (msg_is_mu) {
440
0
        mu_ptr = msg;
441
0
        mu_len = msg_len;
442
681
    } else {
443
681
        md_ctx = ossl_ml_dsa_mu_init(priv, encode, context, context_len);
444
681
        if (md_ctx == NULL)
445
0
            return 0;
446
447
681
        if (!ossl_ml_dsa_mu_update(md_ctx, msg, msg_len))
448
0
            goto err;
449
450
681
        if (!ossl_ml_dsa_mu_finalize(md_ctx, mu, mu_len))
451
0
            goto err;
452
681
    }
453
454
681
    ret = ml_dsa_sign_internal(priv, mu_ptr, mu_len, rand, rand_len, sig);
455
456
681
err:
457
681
    EVP_MD_CTX_free(md_ctx);
458
681
    OPENSSL_cleanse(mu, sizeof(mu));
459
681
    return ret;
460
681
}
461
462
/**
463
 * See FIPS 203 Section 5.3 Algorithm 3 ML-DSA.Verify()
464
 * @returns 1 on success, or 0 on error.
465
 */
466
int ossl_ml_dsa_verify(const ML_DSA_KEY *pub, int msg_is_mu,
467
    const uint8_t *msg, size_t msg_len,
468
    const uint8_t *context, size_t context_len, int encode,
469
    const uint8_t *sig, size_t sig_len)
470
681
{
471
681
    EVP_MD_CTX *md_ctx = NULL;
472
681
    uint8_t mu[ML_DSA_MU_BYTES];
473
681
    const uint8_t *mu_ptr = mu;
474
681
    size_t mu_len = sizeof(mu);
475
681
    int ret = 0;
476
477
681
    if (ossl_ml_dsa_key_get_pub(pub) == NULL)
478
0
        return 0;
479
480
681
    if (msg_is_mu) {
481
0
        mu_ptr = msg;
482
0
        mu_len = msg_len;
483
681
    } else {
484
681
        md_ctx = ossl_ml_dsa_mu_init(pub, encode, context, context_len);
485
681
        if (md_ctx == NULL)
486
0
            return 0;
487
488
681
        if (!ossl_ml_dsa_mu_update(md_ctx, msg, msg_len))
489
0
            goto err;
490
491
681
        if (!ossl_ml_dsa_mu_finalize(md_ctx, mu, mu_len))
492
0
            goto err;
493
681
    }
494
495
681
    ret = ml_dsa_verify_internal(pub, mu_ptr, mu_len, sig, sig_len);
496
681
err:
497
681
    EVP_MD_CTX_free(md_ctx);
498
681
    OPENSSL_cleanse(mu, sizeof(mu));
499
681
    return ret;
500
681
}