Coverage Report

Created: 2025-12-14 06:09

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/php-src/Zend/Optimizer/dfa_pass.c
Line
Count
Source
1
/*
2
   +----------------------------------------------------------------------+
3
   | Zend OPcache                                                         |
4
   +----------------------------------------------------------------------+
5
   | Copyright (c) The PHP Group                                          |
6
   +----------------------------------------------------------------------+
7
   | This source file is subject to version 3.01 of the PHP license,      |
8
   | that is bundled with this package in the file LICENSE, and is        |
9
   | available through the world-wide-web at the following url:           |
10
   | https://www.php.net/license/3_01.txt                                 |
11
   | If you did not receive a copy of the PHP license and are unable to   |
12
   | obtain it through the world-wide-web, please send a note to          |
13
   | license@php.net so we can mail you a copy immediately.               |
14
   +----------------------------------------------------------------------+
15
   | Authors: Dmitry Stogov <dmitry@php.net>                              |
16
   +----------------------------------------------------------------------+
17
*/
18
19
#include "Optimizer/zend_optimizer.h"
20
#include "Optimizer/zend_optimizer_internal.h"
21
#include "zend_API.h"
22
#include "zend_constants.h"
23
#include "zend_execute.h"
24
#include "zend_vm.h"
25
#include "zend_bitset.h"
26
#include "zend_cfg.h"
27
#include "zend_ssa.h"
28
#include "zend_func_info.h"
29
#include "zend_call_graph.h"
30
#include "zend_inference.h"
31
#include "zend_dump.h"
32
33
#ifndef ZEND_DEBUG_DFA
34
# define ZEND_DEBUG_DFA ZEND_DEBUG
35
#endif
36
37
#if ZEND_DEBUG_DFA
38
# include "ssa_integrity.c"
39
#endif
40
41
zend_result zend_dfa_analyze_op_array(zend_op_array *op_array, zend_optimizer_ctx *ctx, zend_ssa *ssa)
42
51.4k
{
43
51.4k
  uint32_t build_flags;
44
45
51.4k
  if (op_array->last_try_catch) {
46
    /* TODO: we can't analyze functions with try/catch/finally ??? */
47
12.9k
    return FAILURE;
48
12.9k
  }
49
50
    /* Build SSA */
51
38.4k
  memset(ssa, 0, sizeof(zend_ssa));
52
53
38.4k
  zend_build_cfg(&ctx->arena, op_array, ZEND_CFG_NO_ENTRY_PREDECESSORS, &ssa->cfg);
54
55
38.4k
  if ((ssa->cfg.flags & ZEND_FUNC_INDIRECT_VAR_ACCESS)) {
56
    /* TODO: we can't analyze functions with indirect variable access ??? */
57
1.43k
    return FAILURE;
58
1.43k
  }
59
60
37.0k
  zend_cfg_build_predecessors(&ctx->arena, &ssa->cfg);
61
62
37.0k
  if (ctx->debug_level & ZEND_DUMP_DFA_CFG) {
63
0
    zend_dump_op_array(op_array, ZEND_DUMP_CFG, "dfa cfg", &ssa->cfg);
64
0
  }
65
66
  /* Compute Dominators Tree */
67
37.0k
  zend_cfg_compute_dominators_tree(op_array, &ssa->cfg);
68
69
  /* Identify reducible and irreducible loops */
70
37.0k
  zend_cfg_identify_loops(op_array, &ssa->cfg);
71
72
37.0k
  if (ctx->debug_level & ZEND_DUMP_DFA_DOMINATORS) {
73
0
    zend_dump_dominators(op_array, &ssa->cfg);
74
0
  }
75
76
37.0k
  build_flags = 0;
77
37.0k
  if (ctx->debug_level & ZEND_DUMP_DFA_LIVENESS) {
78
0
    build_flags |= ZEND_SSA_DEBUG_LIVENESS;
79
0
  }
80
37.0k
  if (ctx->debug_level & ZEND_DUMP_DFA_PHI) {
81
0
    build_flags |= ZEND_SSA_DEBUG_PHI_PLACEMENT;
82
0
  }
83
37.0k
  if (zend_build_ssa(&ctx->arena, ctx->script, op_array, build_flags, ssa) == FAILURE) {
84
0
    return FAILURE;
85
0
  }
86
87
37.0k
  if (ctx->debug_level & ZEND_DUMP_DFA_SSA) {
88
0
    zend_dump_op_array(op_array, ZEND_DUMP_SSA, "dfa ssa", ssa);
89
0
  }
90
91
92
37.0k
  zend_ssa_compute_use_def_chains(&ctx->arena, op_array, ssa);
93
94
37.0k
  zend_ssa_find_false_dependencies(op_array, ssa);
95
96
37.0k
  zend_ssa_find_sccs(op_array, ssa);
97
98
37.0k
  if (zend_ssa_inference(&ctx->arena, op_array, ctx->script, ssa, ctx->optimization_level) == FAILURE) {
99
0
    return FAILURE;
100
0
  }
101
102
37.0k
  if (zend_ssa_escape_analysis(ctx->script, op_array, ssa) == FAILURE) {
103
0
    return FAILURE;
104
0
  }
105
106
37.0k
  if (ctx->debug_level & ZEND_DUMP_DFA_SSA_VARS) {
107
0
    zend_dump_ssa_variables(op_array, ssa, 0);
108
0
  }
109
110
37.0k
  return SUCCESS;
111
37.0k
}
112
113
static void zend_ssa_remove_nops(zend_op_array *op_array, zend_ssa *ssa, zend_optimizer_ctx *ctx)
114
3.65k
{
115
3.65k
  zend_basic_block *blocks = ssa->cfg.blocks;
116
3.65k
  zend_basic_block *blocks_end = blocks + ssa->cfg.blocks_count;
117
3.65k
  zend_basic_block *b;
118
3.65k
  zend_func_info *func_info;
119
3.65k
  int j;
120
3.65k
  uint32_t i = 0;
121
3.65k
  uint32_t target = 0;
122
3.65k
  uint32_t *shiftlist;
123
3.65k
  ALLOCA_FLAG(use_heap);
124
125
3.65k
  shiftlist = (uint32_t *)do_alloca(sizeof(uint32_t) * op_array->last, use_heap);
126
3.65k
  memset(shiftlist, 0, sizeof(uint32_t) * op_array->last);
127
  /* remove empty callee_info */
128
3.65k
  func_info = ZEND_FUNC_INFO(op_array);
129
3.65k
  if (func_info) {
130
3.65k
    zend_call_info **call_info = &func_info->callee_info;
131
7.35k
    while ((*call_info)) {
132
3.70k
      if ((*call_info)->caller_init_opline->opcode == ZEND_NOP) {
133
26
        *call_info = (*call_info)->next_callee;
134
3.67k
      } else {
135
3.67k
        call_info = &(*call_info)->next_callee;
136
3.67k
      }
137
3.70k
    }
138
3.65k
  }
139
140
39.3k
  for (b = blocks; b < blocks_end; b++) {
141
35.6k
    if (b->flags & (ZEND_BB_REACHABLE|ZEND_BB_UNREACHABLE_FREE)) {
142
32.4k
      if (b->len) {
143
32.2k
        uint32_t new_start, old_end;
144
39.1k
        while (i < b->start) {
145
6.94k
          shiftlist[i] = i - target;
146
6.94k
          i++;
147
6.94k
        }
148
149
32.2k
        if (b->flags & ZEND_BB_UNREACHABLE_FREE) {
150
          /* Only keep the FREE for the loop var */
151
4
          ZEND_ASSERT(op_array->opcodes[b->start].opcode == ZEND_FREE
152
4
              || op_array->opcodes[b->start].opcode == ZEND_FE_FREE);
153
4
          b->len = 1;
154
4
        }
155
156
32.2k
        new_start = target;
157
32.2k
        old_end = b->start + b->len;
158
266k
        while (i < old_end) {
159
234k
          shiftlist[i] = i - target;
160
234k
          if (EXPECTED(op_array->opcodes[i].opcode != ZEND_NOP)) {
161
221k
            if (i != target) {
162
115k
              op_array->opcodes[target] = op_array->opcodes[i];
163
115k
              ssa->ops[target] = ssa->ops[i];
164
115k
              ssa->cfg.map[target] = b - blocks;
165
115k
            }
166
221k
            target++;
167
221k
          }
168
234k
          i++;
169
234k
        }
170
32.2k
        b->start = new_start;
171
32.2k
        if (target != old_end) {
172
16.7k
          zend_op *opline;
173
16.7k
          zend_op *new_opline;
174
175
16.7k
          b->len = target - b->start;
176
16.7k
          opline = op_array->opcodes + old_end - 1;
177
16.7k
          if (opline->opcode == ZEND_NOP) {
178
49
            continue;
179
49
          }
180
181
16.6k
          new_opline = op_array->opcodes + target - 1;
182
16.6k
          zend_optimizer_migrate_jump(op_array, new_opline, opline);
183
16.6k
        }
184
32.2k
      } else {
185
224
        b->start = target;
186
224
      }
187
32.4k
    } else {
188
3.21k
      b->start = target;
189
3.21k
      b->len = 0;
190
3.21k
    }
191
35.6k
  }
192
193
3.65k
  if (target != op_array->last) {
194
    /* reset rest opcodes */
195
23.6k
    for (i = target; i < op_array->last; i++) {
196
20.0k
      MAKE_NOP(op_array->opcodes + i);
197
20.0k
    }
198
199
    /* update SSA variables */
200
236k
    for (j = 0; j < ssa->vars_count; j++) {
201
232k
      if (ssa->vars[j].definition >= 0) {
202
164k
        ssa->vars[j].definition -= shiftlist[ssa->vars[j].definition];
203
164k
      }
204
232k
      if (ssa->vars[j].use_chain >= 0) {
205
171k
        ssa->vars[j].use_chain -= shiftlist[ssa->vars[j].use_chain];
206
171k
      }
207
232k
    }
208
245k
    for (i = 0; i < op_array->last; i++) {
209
241k
      if (ssa->ops[i].op1_use_chain >= 0) {
210
8.39k
        ssa->ops[i].op1_use_chain -= shiftlist[ssa->ops[i].op1_use_chain];
211
8.39k
      }
212
241k
      if (ssa->ops[i].op2_use_chain >= 0) {
213
16.6k
        ssa->ops[i].op2_use_chain -= shiftlist[ssa->ops[i].op2_use_chain];
214
16.6k
      }
215
241k
      if (ssa->ops[i].res_use_chain >= 0) {
216
0
        ssa->ops[i].res_use_chain -= shiftlist[ssa->ops[i].res_use_chain];
217
0
      }
218
241k
    }
219
220
    /* update branch targets */
221
39.3k
    for (b = blocks; b < blocks_end; b++) {
222
35.6k
      if ((b->flags & ZEND_BB_REACHABLE) && b->len != 0) {
223
32.2k
        zend_op *opline = op_array->opcodes + b->start + b->len - 1;
224
32.2k
        zend_optimizer_shift_jump(op_array, opline, shiftlist);
225
32.2k
      }
226
35.6k
    }
227
228
    /* update try/catch array */
229
3.65k
    for (uint32_t j = 0; j < op_array->last_try_catch; j++) {
230
0
      op_array->try_catch_array[j].try_op -= shiftlist[op_array->try_catch_array[j].try_op];
231
0
      op_array->try_catch_array[j].catch_op -= shiftlist[op_array->try_catch_array[j].catch_op];
232
0
      if (op_array->try_catch_array[j].finally_op) {
233
0
        op_array->try_catch_array[j].finally_op -= shiftlist[op_array->try_catch_array[j].finally_op];
234
0
        op_array->try_catch_array[j].finally_end -= shiftlist[op_array->try_catch_array[j].finally_end];
235
0
      }
236
0
    }
237
238
    /* update call graph */
239
3.65k
    if (func_info) {
240
3.65k
      zend_call_info *call_info = func_info->callee_info;
241
7.33k
      while (call_info) {
242
3.67k
        call_info->caller_init_opline -=
243
3.67k
          shiftlist[call_info->caller_init_opline - op_array->opcodes];
244
3.67k
        if (call_info->caller_call_opline) {
245
3.67k
          call_info->caller_call_opline -=
246
3.67k
            shiftlist[call_info->caller_call_opline - op_array->opcodes];
247
3.67k
        }
248
3.67k
        call_info = call_info->next_callee;
249
3.67k
      }
250
3.65k
    }
251
252
3.65k
    op_array->last = target;
253
3.65k
  }
254
3.65k
  free_alloca(shiftlist, use_heap);
255
3.65k
}
256
257
171
static bool safe_instanceof(const zend_class_entry *ce1, const zend_class_entry *ce2) {
258
171
  if (ce1 == ce2) {
259
105
    return true;
260
105
  }
261
66
  if (!(ce1->ce_flags & ZEND_ACC_LINKED)) {
262
    /* This case could be generalized, similarly to unlinked_instanceof */
263
8
    return false;
264
8
  }
265
58
  return instanceof_function(ce1, ce2);
266
66
}
267
268
static inline bool can_elide_list_type(
269
  const zend_script *script, const zend_op_array *op_array,
270
  const zend_ssa_var_info *use_info, const zend_type type)
271
223
{
272
223
  const zend_type *single_type;
273
  /* For intersection: result==false is failure, default is success.
274
   * For union: result==true is success, default is failure. */
275
223
  bool is_intersection = ZEND_TYPE_IS_INTERSECTION(type);
276
446
  ZEND_TYPE_FOREACH(type, single_type) {
277
446
    if (ZEND_TYPE_HAS_LIST(*single_type)) {
278
28
      ZEND_ASSERT(!is_intersection);
279
28
      return can_elide_list_type(script, op_array, use_info, *single_type);
280
28
    }
281
195
    if (ZEND_TYPE_HAS_NAME(*single_type)) {
282
195
      zend_string *lcname = zend_string_tolower(ZEND_TYPE_NAME(*single_type));
283
195
      const zend_class_entry *ce = zend_optimizer_get_class_entry(script, op_array, lcname);
284
195
      zend_string_release(lcname);
285
195
      bool result = ce && safe_instanceof(use_info->ce, ce);
286
195
      if (result == !is_intersection) {
287
151
        return result;
288
151
      }
289
195
    }
290
195
  } ZEND_TYPE_FOREACH_END();
291
44
  return is_intersection;
292
223
}
293
294
static inline bool can_elide_return_type_check(
295
1.25k
    const zend_script *script, zend_op_array *op_array, zend_ssa *ssa, zend_ssa_op *ssa_op) {
296
1.25k
  zend_arg_info *arg_info = &op_array->arg_info[-1];
297
1.25k
  zend_ssa_var_info *use_info = &ssa->var_info[ssa_op->op1_use];
298
1.25k
  uint32_t use_type = use_info->type & (MAY_BE_ANY|MAY_BE_UNDEF);
299
1.25k
  if (use_type & MAY_BE_REF) {
300
0
    return false;
301
0
  }
302
303
1.25k
  if (use_type & MAY_BE_UNDEF) {
304
18
    use_type &= ~MAY_BE_UNDEF;
305
18
    use_type |= MAY_BE_NULL;
306
18
  }
307
308
1.25k
  uint32_t disallowed_types = use_type & ~ZEND_TYPE_PURE_MASK(arg_info->type);
309
1.25k
  if (!disallowed_types) {
310
    /* Only contains allowed types. */
311
281
    return true;
312
281
  }
313
314
971
  if (disallowed_types == MAY_BE_OBJECT && use_info->ce && ZEND_TYPE_IS_COMPLEX(arg_info->type)) {
315
195
    return can_elide_list_type(script, op_array, use_info, arg_info->type);
316
195
  }
317
318
776
  return false;
319
971
}
320
321
static bool opline_supports_assign_contraction(
322
2.66k
    zend_op_array *op_array, zend_ssa *ssa, zend_op *opline, int src_var, uint32_t cv_var) {
323
2.66k
  if (opline->opcode == ZEND_NEW) {
324
    /* see Zend/tests/generators/aborted_yield_during_new.phpt */
325
518
    return false;
326
518
  }
327
328
  /* Frameless calls override the return value, but the return value may overlap with the arguments. */
329
2.14k
  switch (opline->opcode) {
330
0
    case ZEND_FRAMELESS_ICALL_3:
331
0
      if ((opline + 1)->op1_type == IS_CV && (opline + 1)->op1.var == cv_var) return false;
332
0
      ZEND_FALLTHROUGH;
333
0
    case ZEND_FRAMELESS_ICALL_2:
334
0
      if (opline->op2_type == IS_CV && opline->op2.var == cv_var) return false;
335
0
      ZEND_FALLTHROUGH;
336
0
    case ZEND_FRAMELESS_ICALL_1:
337
0
      if (opline->op1_type == IS_CV && opline->op1.var == cv_var) return false;
338
0
      return true;
339
2.14k
  }
340
341
2.14k
  if (opline->opcode == ZEND_DO_ICALL || opline->opcode == ZEND_DO_UCALL
342
2.13k
      || opline->opcode == ZEND_DO_FCALL || opline->opcode == ZEND_DO_FCALL_BY_NAME) {
343
    /* Function calls may dtor the return value after it has already been written -- allow
344
     * direct assignment only for types where a double-dtor does not matter. */
345
220
    uint32_t type = ssa->var_info[src_var].type;
346
220
    uint32_t simple = MAY_BE_NULL|MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_LONG|MAY_BE_DOUBLE;
347
220
    return !((type & MAY_BE_ANY) & ~simple);
348
220
  }
349
350
1.92k
  if (opline->opcode == ZEND_POST_INC || opline->opcode == ZEND_POST_DEC) {
351
    /* POST_INC/DEC write the result variable before performing the inc/dec. For $i = $i++
352
     * eliding the temporary variable would thus yield an incorrect result. */
353
19
    return opline->op1_type != IS_CV || opline->op1.var != cv_var;
354
19
  }
355
356
1.90k
  if (opline->opcode == ZEND_INIT_ARRAY) {
357
    /* INIT_ARRAY initializes the result array before reading key/value. */
358
20
    return (opline->op1_type != IS_CV || opline->op1.var != cv_var)
359
18
      && (opline->op2_type != IS_CV || opline->op2.var != cv_var);
360
20
  }
361
362
1.88k
  if (opline->opcode == ZEND_CAST
363
25
      && (opline->extended_value == IS_ARRAY || opline->extended_value == IS_OBJECT)) {
364
    /* CAST to array/object may initialize the result to an empty array/object before
365
     * reading the expression. */
366
9
    return opline->op1_type != IS_CV || opline->op1.var != cv_var;
367
9
  }
368
369
1.87k
  if ((opline->opcode == ZEND_ASSIGN_OP
370
1.86k
    || opline->opcode == ZEND_ASSIGN_OBJ
371
1.86k
    || opline->opcode == ZEND_ASSIGN_DIM
372
1.86k
    || opline->opcode == ZEND_ASSIGN_OBJ_OP
373
1.86k
    || opline->opcode == ZEND_ASSIGN_DIM_OP)
374
16
   && opline->op1_type == IS_CV
375
16
   && opline->op1.var == cv_var
376
12
   && zend_may_throw(opline, &ssa->ops[ssa->vars[src_var].definition], op_array, ssa)) {
377
9
    return false;
378
9
  }
379
380
1.86k
  return true;
381
1.87k
}
382
383
static bool variable_defined_or_used_in_range(zend_ssa *ssa, int var, int start, int end)
384
1.92k
{
385
1.94k
  while (start < end) {
386
24
    const zend_ssa_op *ssa_op = &ssa->ops[start];
387
24
    if ((ssa_op->op1_def >= 0 && ssa->vars[ssa_op->op1_def].var == var) ||
388
24
      (ssa_op->op2_def >= 0 && ssa->vars[ssa_op->op2_def].var == var) ||
389
24
      (ssa_op->result_def >= 0 && ssa->vars[ssa_op->result_def].var == var) ||
390
24
      (ssa_op->op1_use >= 0 && ssa->vars[ssa_op->op1_use].var == var) ||
391
24
      (ssa_op->op2_use >= 0 && ssa->vars[ssa_op->op2_use].var == var) ||
392
24
      (ssa_op->result_use >= 0 && ssa->vars[ssa_op->result_use].var == var)
393
24
    ) {
394
0
      return true;
395
0
    }
396
24
    start++;
397
24
  }
398
1.92k
  return false;
399
1.92k
}
400
401
int zend_dfa_optimize_calls(zend_op_array *op_array, zend_ssa *ssa)
402
37.0k
{
403
37.0k
  zend_func_info *func_info = ZEND_FUNC_INFO(op_array);
404
37.0k
  int removed_ops = 0;
405
406
37.0k
  if (func_info->callee_info) {
407
15.8k
    zend_call_info *call_info = func_info->callee_info;
408
409
38.8k
    do {
410
38.8k
      zend_op *op = call_info->caller_init_opline;
411
412
38.8k
      if ((op->opcode == ZEND_FRAMELESS_ICALL_2
413
38.8k
        || (op->opcode == ZEND_FRAMELESS_ICALL_3 && (op + 1)->op1_type == IS_CONST))
414
0
       && call_info->callee_func
415
0
       && zend_string_equals_literal_ci(call_info->callee_func->common.function_name, "in_array")) {
416
417
0
        bool strict = false;
418
0
        bool has_opdata = op->opcode == ZEND_FRAMELESS_ICALL_3;
419
0
        ZEND_ASSERT(!call_info->is_prototype);
420
421
0
        if (has_opdata) {
422
0
          if (zend_is_true(CT_CONSTANT_EX(op_array, (op + 1)->op1.constant))) {
423
0
            strict = true;
424
0
          }
425
0
        }
426
427
0
        if (op->op2_type == IS_CONST
428
0
         && Z_TYPE_P(CT_CONSTANT_EX(op_array, op->op2.constant)) == IS_ARRAY) {
429
0
          bool ok = true;
430
431
0
          HashTable *src = Z_ARRVAL_P(CT_CONSTANT_EX(op_array, op->op2.constant));
432
0
          HashTable *dst;
433
0
          zval *val, tmp;
434
0
          zend_ulong idx;
435
436
0
          ZVAL_TRUE(&tmp);
437
0
          dst = zend_new_array(zend_hash_num_elements(src));
438
0
          if (strict) {
439
0
            ZEND_HASH_FOREACH_VAL(src, val) {
440
0
              if (Z_TYPE_P(val) == IS_STRING) {
441
0
                zend_hash_add(dst, Z_STR_P(val), &tmp);
442
0
              } else if (Z_TYPE_P(val) == IS_LONG) {
443
0
                zend_hash_index_add(dst, Z_LVAL_P(val), &tmp);
444
0
              } else {
445
0
                zend_array_destroy(dst);
446
0
                ok = false;
447
0
                break;
448
0
              }
449
0
            } ZEND_HASH_FOREACH_END();
450
0
          } else {
451
0
            ZEND_HASH_FOREACH_VAL(src, val) {
452
0
              if (Z_TYPE_P(val) != IS_STRING || ZEND_HANDLE_NUMERIC(Z_STR_P(val), idx)) {
453
0
                zend_array_destroy(dst);
454
0
                ok = false;
455
0
                break;
456
0
              }
457
0
              zend_hash_add(dst, Z_STR_P(val), &tmp);
458
0
            } ZEND_HASH_FOREACH_END();
459
0
          }
460
461
0
          if (ok) {
462
0
            ZVAL_ARR(&tmp, dst);
463
464
            /* Update opcode */
465
0
            op->opcode = ZEND_IN_ARRAY;
466
0
            op->extended_value = strict;
467
0
            op->op2.constant = zend_optimizer_add_literal(op_array, &tmp);
468
0
            if (has_opdata) {
469
0
              MAKE_NOP(op + 1);
470
0
              removed_ops++;
471
0
            }
472
0
          }
473
0
        }
474
0
      }
475
38.8k
      call_info = call_info->next_callee;
476
38.8k
    } while (call_info);
477
15.8k
  }
478
479
37.0k
  return removed_ops;
480
37.0k
}
481
482
static zend_always_inline void take_successor_0(zend_ssa *ssa, int block_num, zend_basic_block *block)
483
1.08k
{
484
1.08k
  if (block->successors_count == 2) {
485
163
    if (block->successors[1] != block->successors[0]) {
486
46
      zend_ssa_remove_predecessor(ssa, block_num, block->successors[1]);
487
46
    }
488
163
    block->successors_count = 1;
489
163
  }
490
1.08k
}
491
492
static zend_always_inline void take_successor_1(zend_ssa *ssa, int block_num, zend_basic_block *block)
493
454
{
494
454
  if (block->successors_count == 2) {
495
343
    if (block->successors[1] != block->successors[0]) {
496
301
      zend_ssa_remove_predecessor(ssa, block_num, block->successors[0]);
497
301
      block->successors[0] = block->successors[1];
498
301
    }
499
343
    block->successors_count = 1;
500
343
  }
501
454
}
502
503
static zend_always_inline void take_successor_ex(zend_ssa *ssa, int block_num, zend_basic_block *block, int target_block)
504
6
{
505
6
  int i;
506
507
18
  for (i = 0; i < block->successors_count; i++) {
508
12
    if (block->successors[i] != target_block) {
509
6
      zend_ssa_remove_predecessor(ssa, block_num, block->successors[i]);
510
6
    }
511
12
  }
512
6
  block->successors[0] = target_block;
513
6
  block->successors_count = 1;
514
6
}
515
516
static void compress_block(zend_op_array *op_array, zend_basic_block *block)
517
153k
{
518
156k
  while (block->len > 0) {
519
155k
    zend_op *opline = &op_array->opcodes[block->start + block->len - 1];
520
521
155k
    if (opline->opcode == ZEND_NOP) {
522
3.26k
      block->len--;
523
152k
    } else {
524
152k
      break;
525
152k
    }
526
155k
  }
527
153k
}
528
529
1.06k
static void replace_predecessor(zend_ssa *ssa, int block_id, int old_pred, int new_pred) {
530
1.06k
  zend_basic_block *block = &ssa->cfg.blocks[block_id];
531
1.06k
  int *predecessors = &ssa->cfg.predecessors[block->predecessor_offset];
532
1.06k
  zend_ssa_phi *phi;
533
534
1.06k
  int i;
535
1.06k
  int old_pred_idx = -1;
536
1.06k
  int new_pred_idx = -1;
537
2.56k
  for (i = 0; i < block->predecessors_count; i++) {
538
1.49k
    if (predecessors[i] == old_pred) {
539
1.06k
      old_pred_idx = i;
540
1.06k
    }
541
1.49k
    if (predecessors[i] == new_pred) {
542
177
      new_pred_idx = i;
543
177
    }
544
1.49k
  }
545
546
1.06k
  ZEND_ASSERT(old_pred_idx != -1);
547
1.06k
  if (new_pred_idx == -1) {
548
    /* If the new predecessor doesn't exist yet, simply rewire the old one */
549
887
    predecessors[old_pred_idx] = new_pred;
550
887
  } else {
551
    /* Otherwise, rewiring the old predecessor would make the new predecessor appear
552
     * twice, which violates our CFG invariants. Remove the old predecessor instead. */
553
177
    memmove(
554
177
      predecessors + old_pred_idx,
555
177
      predecessors + old_pred_idx + 1,
556
177
      sizeof(int) * (block->predecessors_count - old_pred_idx - 1)
557
177
    );
558
559
    /* Also remove the corresponding phi node entries */
560
193
    for (phi = ssa->blocks[block_id].phis; phi; phi = phi->next) {
561
16
      if (phi->pi >= 0) {
562
4
        if (phi->pi == old_pred || phi->pi == new_pred) {
563
4
          zend_ssa_rename_var_uses(
564
4
            ssa, phi->ssa_var, phi->sources[0], /* update_types */ 0);
565
4
          zend_ssa_remove_phi(ssa, phi);
566
4
        }
567
12
      } else {
568
12
        memmove(
569
12
          phi->sources + old_pred_idx,
570
12
          phi->sources + old_pred_idx + 1,
571
12
          sizeof(int) * (block->predecessors_count - old_pred_idx - 1)
572
12
        );
573
12
      }
574
16
    }
575
576
177
    block->predecessors_count--;
577
177
  }
578
1.06k
}
579
580
static void zend_ssa_replace_control_link(zend_op_array *op_array, zend_ssa *ssa, int from, int to, int new_to)
581
1.06k
{
582
1.06k
  zend_basic_block *src = &ssa->cfg.blocks[from];
583
1.06k
  zend_basic_block *old = &ssa->cfg.blocks[to];
584
1.06k
  zend_basic_block *dst = &ssa->cfg.blocks[new_to];
585
1.06k
  int i;
586
1.06k
  zend_op *opline;
587
588
2.82k
  for (i = 0; i < src->successors_count; i++) {
589
1.76k
    if (src->successors[i] == to) {
590
1.08k
      src->successors[i] = new_to;
591
1.08k
    }
592
1.76k
  }
593
594
1.06k
  if (src->len > 0) {
595
924
    opline = op_array->opcodes + src->start + src->len - 1;
596
924
    switch (opline->opcode) {
597
4
      case ZEND_JMP:
598
4
      case ZEND_FAST_CALL:
599
4
        ZEND_ASSERT(ZEND_OP1_JMP_ADDR(opline) == op_array->opcodes + old->start);
600
4
        ZEND_SET_OP_JMP_ADDR(opline, opline->op1, op_array->opcodes + dst->start);
601
4
        break;
602
293
      case ZEND_JMPZ:
603
412
      case ZEND_JMPNZ:
604
574
      case ZEND_JMPZ_EX:
605
598
      case ZEND_JMPNZ_EX:
606
598
      case ZEND_FE_RESET_R:
607
598
      case ZEND_FE_RESET_RW:
608
636
      case ZEND_JMP_SET:
609
719
      case ZEND_COALESCE:
610
719
      case ZEND_ASSERT_CHECK:
611
719
      case ZEND_JMP_NULL:
612
719
      case ZEND_BIND_INIT_STATIC_OR_JMP:
613
719
      case ZEND_JMP_FRAMELESS:
614
719
        if (ZEND_OP2_JMP_ADDR(opline) == op_array->opcodes + old->start) {
615
126
          ZEND_SET_OP_JMP_ADDR(opline, opline->op2, op_array->opcodes + dst->start);
616
126
        }
617
719
        break;
618
0
      case ZEND_CATCH:
619
0
        if (!(opline->extended_value & ZEND_LAST_CATCH)) {
620
0
          if (ZEND_OP2_JMP_ADDR(opline) == op_array->opcodes + old->start) {
621
0
            ZEND_SET_OP_JMP_ADDR(opline, opline->op2, op_array->opcodes + dst->start);
622
0
          }
623
0
        }
624
0
        break;
625
6
      case ZEND_FE_FETCH_R:
626
6
      case ZEND_FE_FETCH_RW:
627
6
        if (ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value) == old->start) {
628
0
          opline->extended_value = ZEND_OPLINE_NUM_TO_OFFSET(op_array, opline, dst->start);
629
0
        }
630
6
        break;
631
0
      case ZEND_SWITCH_LONG:
632
0
      case ZEND_SWITCH_STRING:
633
4
      case ZEND_MATCH:
634
4
        {
635
4
          HashTable *jumptable = Z_ARRVAL(ZEND_OP2_LITERAL(opline));
636
4
          zval *zv;
637
26
          ZEND_HASH_FOREACH_VAL(jumptable, zv) {
638
26
            if (ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, Z_LVAL_P(zv)) == old->start) {
639
4
              Z_LVAL_P(zv) = ZEND_OPLINE_NUM_TO_OFFSET(op_array, opline, dst->start);
640
4
            }
641
26
          } ZEND_HASH_FOREACH_END();
642
4
          if (ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value) == old->start) {
643
2
            opline->extended_value = ZEND_OPLINE_NUM_TO_OFFSET(op_array, opline, dst->start);
644
2
          }
645
4
          break;
646
0
        }
647
924
    }
648
924
  }
649
650
1.06k
  replace_predecessor(ssa, new_to, to, from);
651
1.06k
}
652
653
static void zend_ssa_unlink_block(zend_op_array *op_array, zend_ssa *ssa, zend_basic_block *block, int block_num)
654
1.34k
{
655
1.34k
  if (block->predecessors_count == 1 && ssa->blocks[block_num].phis == NULL) {
656
1.06k
    int *predecessors, i;
657
1.06k
    zend_basic_block *fe_fetch_block = NULL;
658
659
1.06k
    ZEND_ASSERT(block->successors_count == 1);
660
1.06k
    predecessors = &ssa->cfg.predecessors[block->predecessor_offset];
661
1.06k
    if (block->predecessors_count == 1 && (block->flags & ZEND_BB_FOLLOW)) {
662
999
      zend_basic_block *pred_block = &ssa->cfg.blocks[predecessors[0]];
663
664
999
      if (pred_block->len > 0 && (pred_block->flags & ZEND_BB_REACHABLE)) {
665
861
        if ((op_array->opcodes[pred_block->start + pred_block->len - 1].opcode == ZEND_FE_FETCH_R
666
855
         || op_array->opcodes[pred_block->start + pred_block->len - 1].opcode == ZEND_FE_FETCH_RW)
667
6
          && op_array->opcodes[pred_block->start + pred_block->len - 1].op2_type == IS_CV) {
668
6
          fe_fetch_block = pred_block;
669
6
          }
670
861
      }
671
999
    }
672
2.12k
    for (i = 0; i < block->predecessors_count; i++) {
673
1.06k
      zend_ssa_replace_control_link(op_array, ssa, predecessors[i], block_num, block->successors[0]);
674
1.06k
    }
675
1.06k
    zend_ssa_remove_block(op_array, ssa, block_num);
676
1.06k
    if (fe_fetch_block && fe_fetch_block->successors[0] == fe_fetch_block->successors[1]) {
677
      /* The body of "foreach" loop was removed */
678
4
      int ssa_var = ssa->ops[fe_fetch_block->start + fe_fetch_block->len - 1].op2_def;
679
4
      if (ssa_var >= 0) {
680
4
        zend_ssa_remove_uses_of_var(ssa, ssa_var);
681
4
      }
682
4
    }
683
1.06k
  }
684
1.34k
}
685
686
static int zend_dfa_optimize_jmps(zend_op_array *op_array, zend_ssa *ssa)
687
74.0k
{
688
74.0k
  int removed_ops = 0;
689
74.0k
  int block_num = 0;
690
691
231k
  for (block_num = 1; block_num < ssa->cfg.blocks_count; block_num++) {
692
157k
    zend_basic_block *block = &ssa->cfg.blocks[block_num];
693
694
157k
    if (!(block->flags & ZEND_BB_REACHABLE)) {
695
5.12k
      continue;
696
5.12k
    }
697
152k
    compress_block(op_array, block);
698
152k
    if (block->len == 0) {
699
500
      zend_ssa_unlink_block(op_array, ssa, block, block_num);
700
500
    }
701
152k
  }
702
703
74.0k
  block_num = 0;
704
74.0k
  while (block_num < ssa->cfg.blocks_count
705
74.0k
    && !(ssa->cfg.blocks[block_num].flags & ZEND_BB_REACHABLE)) {
706
0
    block_num++;
707
0
  }
708
300k
  while (block_num < ssa->cfg.blocks_count) {
709
226k
    int next_block_num = block_num + 1;
710
226k
    zend_basic_block *block = &ssa->cfg.blocks[block_num];
711
226k
    uint32_t op_num;
712
226k
    zend_op *opline;
713
226k
    zend_ssa_op *ssa_op;
714
226k
    bool can_follow = true;
715
716
238k
    while (next_block_num < ssa->cfg.blocks_count
717
164k
      && !(ssa->cfg.blocks[next_block_num].flags & ZEND_BB_REACHABLE)) {
718
12.0k
      if (ssa->cfg.blocks[next_block_num].flags & ZEND_BB_UNREACHABLE_FREE) {
719
20
        can_follow = false;
720
20
      }
721
12.0k
      next_block_num++;
722
12.0k
    }
723
724
226k
    if (block->len) {
725
226k
      op_num = block->start + block->len - 1;
726
226k
      opline = op_array->opcodes + op_num;
727
226k
      ssa_op = ssa->ops + op_num;
728
729
226k
      switch (opline->opcode) {
730
11.8k
        case ZEND_JMP:
731
12.8k
optimize_jmp:
732
12.8k
          if (block->successors[0] == next_block_num && can_follow) {
733
963
            MAKE_NOP(opline);
734
963
            removed_ops++;
735
963
            goto optimize_nop;
736
963
          }
737
11.8k
          break;
738
11.8k
        case ZEND_JMPZ:
739
6.98k
optimize_jmpz:
740
6.98k
          if (opline->op1_type == IS_CONST) {
741
283
            if (zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
742
164
              MAKE_NOP(opline);
743
164
              removed_ops++;
744
164
              take_successor_1(ssa, block_num, block);
745
164
              goto optimize_nop;
746
164
            } else {
747
119
              opline->opcode = ZEND_JMP;
748
119
              COPY_NODE(opline->op1, opline->op2);
749
119
              take_successor_0(ssa, block_num, block);
750
119
              goto optimize_jmp;
751
119
            }
752
6.70k
          } else {
753
6.70k
            if (block->successors[0] == next_block_num && can_follow) {
754
73
              take_successor_0(ssa, block_num, block);
755
73
              if (opline->op1_type == IS_CV && (OP1_INFO() & MAY_BE_UNDEF)) {
756
2
                opline->opcode = ZEND_CHECK_VAR;
757
2
                opline->op2.num = 0;
758
71
              } else if (opline->op1_type == IS_CV || !(OP1_INFO() & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
759
45
                zend_ssa_remove_instr(ssa, opline, ssa_op);
760
45
                removed_ops++;
761
45
                goto optimize_nop;
762
45
              } else {
763
26
                opline->opcode = ZEND_FREE;
764
26
                opline->op2.num = 0;
765
26
              }
766
73
            }
767
6.70k
          }
768
6.66k
          break;
769
7.08k
        case ZEND_JMPNZ:
770
7.83k
optimize_jmpnz:
771
7.83k
          if (opline->op1_type == IS_CONST) {
772
440
            if (zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
773
302
              opline->opcode = ZEND_JMP;
774
302
              COPY_NODE(opline->op1, opline->op2);
775
302
              take_successor_0(ssa, block_num, block);
776
302
              goto optimize_jmp;
777
302
            } else {
778
138
              MAKE_NOP(opline);
779
138
              removed_ops++;
780
138
              take_successor_1(ssa, block_num, block);
781
138
              goto optimize_nop;
782
138
            }
783
7.39k
          } else if (block->successors_count == 2) {
784
7.39k
            if (block->successors[0] == next_block_num && can_follow) {
785
44
              take_successor_0(ssa, block_num, block);
786
44
              if (opline->op1_type == IS_CV && (OP1_INFO() & MAY_BE_UNDEF)) {
787
0
                opline->opcode = ZEND_CHECK_VAR;
788
0
                opline->op2.num = 0;
789
44
              } else if (opline->op1_type == IS_CV || !(OP1_INFO() & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
790
38
                zend_ssa_remove_instr(ssa, opline, ssa_op);
791
38
                removed_ops++;
792
38
                goto optimize_nop;
793
38
              } else {
794
6
                opline->opcode = ZEND_FREE;
795
6
                opline->op2.num = 0;
796
6
              }
797
44
            }
798
7.39k
          }
799
7.35k
          break;
800
7.35k
        case ZEND_JMPZ_EX:
801
1.09k
          if (ssa->vars[ssa_op->result_def].use_chain < 0
802
1.09k
              && ssa->vars[ssa_op->result_def].phi_use_chain == NULL) {
803
402
            opline->opcode = ZEND_JMPZ;
804
402
            opline->result_type = IS_UNUSED;
805
402
            zend_ssa_remove_result_def(ssa, ssa_op);
806
402
            goto optimize_jmpz;
807
694
          } else if (opline->op1_type == IS_CONST) {
808
156
            if (zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
809
80
              opline->opcode = ZEND_BOOL;
810
80
              take_successor_1(ssa, block_num, block);
811
80
            }
812
156
          }
813
694
          break;
814
694
        case ZEND_JMPNZ_EX:
815
624
          if (ssa->vars[ssa_op->result_def].use_chain < 0
816
622
              && ssa->vars[ssa_op->result_def].phi_use_chain == NULL) {
817
136
            opline->opcode = ZEND_JMPNZ;
818
136
            opline->result_type = IS_UNUSED;
819
136
            zend_ssa_remove_result_def(ssa, ssa_op);
820
136
            goto optimize_jmpnz;
821
488
          } else if (opline->op1_type == IS_CONST) {
822
82
            if (!zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
823
0
              opline->opcode = ZEND_BOOL;
824
0
              take_successor_1(ssa, block_num, block);
825
0
            }
826
82
          }
827
488
          break;
828
1.20k
        case ZEND_JMP_SET:
829
1.20k
          if (ssa->vars[ssa_op->result_def].use_chain < 0
830
1.20k
              && ssa->vars[ssa_op->result_def].phi_use_chain == NULL) {
831
611
            opline->opcode = ZEND_JMPNZ;
832
611
            opline->result_type = IS_UNUSED;
833
611
            zend_ssa_remove_result_def(ssa, ssa_op);
834
611
            goto optimize_jmpnz;
835
611
          } else if (opline->op1_type == IS_CONST) {
836
0
            if (!zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
837
0
              MAKE_NOP(opline);
838
0
              removed_ops++;
839
0
              take_successor_1(ssa, block_num, block);
840
0
              zend_ssa_remove_result_def(ssa, ssa_op);
841
0
              goto optimize_nop;
842
0
            }
843
0
          }
844
589
          break;
845
2.32k
        case ZEND_COALESCE:
846
2.32k
        {
847
2.32k
          zend_ssa_var *var = &ssa->vars[ssa_op->result_def];
848
2.32k
          if (opline->op1_type == IS_CONST
849
588
              && var->use_chain < 0 && var->phi_use_chain == NULL) {
850
572
            if (Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op1.constant)) == IS_NULL) {
851
40
              zend_ssa_remove_result_def(ssa, ssa_op);
852
40
              MAKE_NOP(opline);
853
40
              removed_ops++;
854
40
              take_successor_1(ssa, block_num, block);
855
40
              goto optimize_nop;
856
532
            } else {
857
532
              opline->opcode = ZEND_JMP;
858
532
              opline->result_type = IS_UNUSED;
859
532
              zend_ssa_remove_result_def(ssa, ssa_op);
860
532
              COPY_NODE(opline->op1, opline->op2);
861
532
              take_successor_0(ssa, block_num, block);
862
532
              goto optimize_jmp;
863
532
            }
864
572
          }
865
1.75k
          break;
866
2.32k
        }
867
49.3k
        case ZEND_JMP_NULL:
868
49.3k
        {
869
49.3k
          zend_ssa_var *var = &ssa->vars[ssa_op->result_def];
870
49.3k
          if (opline->op1_type == IS_CONST
871
76
              && var->use_chain < 0 && var->phi_use_chain == NULL) {
872
44
            if (Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op1.constant)) == IS_NULL) {
873
12
              opline->opcode = ZEND_JMP;
874
12
              opline->result_type = IS_UNUSED;
875
12
              zend_ssa_remove_result_def(ssa, ssa_op);
876
12
              COPY_NODE(opline->op1, opline->op2);
877
12
              take_successor_0(ssa, block_num, block);
878
12
              goto optimize_jmp;
879
32
            } else {
880
32
              zend_ssa_remove_result_def(ssa, ssa_op);
881
32
              MAKE_NOP(opline);
882
32
              removed_ops++;
883
32
              take_successor_1(ssa, block_num, block);
884
32
              goto optimize_nop;
885
32
            }
886
44
          }
887
49.3k
          break;
888
49.3k
        }
889
49.3k
        case ZEND_SWITCH_LONG:
890
68
        case ZEND_SWITCH_STRING:
891
188
        case ZEND_MATCH:
892
188
          if (opline->op1_type == IS_CONST) {
893
6
            zval *zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
894
6
            uint8_t type = Z_TYPE_P(zv);
895
6
            bool correct_type =
896
6
              (opline->opcode == ZEND_SWITCH_LONG && type == IS_LONG)
897
6
              || (opline->opcode == ZEND_SWITCH_STRING && type == IS_STRING)
898
6
              || (opline->opcode == ZEND_MATCH && (type == IS_LONG || type == IS_STRING));
899
900
            /* Switch statements have a fallback chain for loose comparison. In those
901
             * cases the SWITCH_* instruction is a NOP. Match does strict comparison and
902
             * thus jumps to the default branch on mismatched types, so we need to
903
             * convert MATCH to a jmp. */
904
6
            if (!correct_type && opline->opcode != ZEND_MATCH) {
905
2
              removed_ops++;
906
2
              MAKE_NOP(opline);
907
2
              opline->extended_value = 0;
908
2
              take_successor_ex(ssa, block_num, block, block->successors[block->successors_count - 1]);
909
2
              goto optimize_nop;
910
2
            }
911
912
4
            uint32_t target;
913
4
            if (correct_type) {
914
2
              HashTable *jmptable = Z_ARRVAL_P(CT_CONSTANT_EX(op_array, opline->op2.constant));
915
2
              zval *jmp_zv = type == IS_LONG
916
2
                ? zend_hash_index_find(jmptable, Z_LVAL_P(zv))
917
2
                : zend_hash_find(jmptable, Z_STR_P(zv));
918
919
2
              if (jmp_zv) {
920
2
                target = ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, Z_LVAL_P(jmp_zv));
921
2
              } else {
922
0
                target = ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value);
923
0
              }
924
2
            } else {
925
2
              ZEND_ASSERT(opline->opcode == ZEND_MATCH);
926
2
              target = ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value);
927
2
            }
928
4
            opline->opcode = ZEND_JMP;
929
4
            opline->extended_value = 0;
930
4
            SET_UNUSED(opline->op1);
931
4
            ZEND_SET_OP_JMP_ADDR(opline, opline->op1, op_array->opcodes + target);
932
4
            SET_UNUSED(opline->op2);
933
4
            take_successor_ex(ssa, block_num, block, ssa->cfg.map[target]);
934
4
            goto optimize_jmp;
935
4
          }
936
182
          break;
937
182
        case ZEND_NOP:
938
1.47k
optimize_nop:
939
1.47k
          compress_block(op_array, block);
940
1.47k
          if (block->len == 0) {
941
900
            if (block_num > 0) {
942
846
              zend_ssa_unlink_block(op_array, ssa, block, block_num);
943
              /* backtrack to previous basic block */
944
5.08k
              do {
945
5.08k
                block_num--;
946
5.08k
              } while (block_num >= 0
947
5.08k
                && !(ssa->cfg.blocks[block_num].flags & ZEND_BB_REACHABLE));
948
846
              if (block_num >= 0) {
949
846
                continue;
950
846
              }
951
846
            }
952
900
          }
953
631
          break;
954
145k
        default:
955
145k
          break;
956
226k
      }
957
226k
    }
958
959
226k
    block_num = next_block_num;
960
226k
  }
961
962
74.0k
  return removed_ops;
963
74.0k
}
964
965
static bool zend_dfa_try_to_replace_result(zend_op_array *op_array, zend_ssa *ssa, int def, int cv_var)
966
6.39k
{
967
6.39k
  int result_var = ssa->ops[def].result_def;
968
6.39k
  uint32_t cv = EX_NUM_TO_VAR(ssa->vars[cv_var].var);
969
970
6.39k
  if (result_var >= 0
971
6.39k
   && !(ssa->var_info[cv_var].type & MAY_BE_REF)
972
4.14k
   && ssa->vars[cv_var].alias == NO_ALIAS
973
4.14k
   && ssa->vars[result_var].phi_use_chain == NULL
974
4.14k
   && ssa->vars[result_var].sym_use_chain == NULL) {
975
4.14k
    int use = ssa->vars[result_var].use_chain;
976
977
4.14k
    if (use >= 0
978
3.88k
     && zend_ssa_next_use(ssa->ops, result_var, use) < 0
979
3.88k
     && op_array->opcodes[use].opcode != ZEND_FREE
980
3.88k
     && op_array->opcodes[use].opcode != ZEND_SEND_VAL
981
3.87k
     && op_array->opcodes[use].opcode != ZEND_SEND_VAL_EX
982
3.87k
     && op_array->opcodes[use].opcode != ZEND_VERIFY_RETURN_TYPE
983
3.87k
     && op_array->opcodes[use].opcode != ZEND_YIELD) {
984
3.86k
      if (use > def) {
985
3.86k
        int i = use;
986
3.86k
        const zend_op *opline = &op_array->opcodes[use];
987
988
7.57k
        while (i > def) {
989
4.65k
          if ((opline->op1_type == IS_CV && opline->op1.var == cv)
990
3.74k
           || (opline->op2_type == IS_CV && opline->op2.var == cv)
991
3.70k
           || (opline->result_type == IS_CV && opline->result.var == cv)) {
992
947
            return false;
993
947
          }
994
3.70k
          opline--;
995
3.70k
          i--;
996
3.70k
        }
997
998
        /* Update opcodes and reconstruct SSA */
999
2.92k
        ssa->vars[result_var].definition = -1;
1000
2.92k
        ssa->vars[result_var].use_chain = -1;
1001
2.92k
        ssa->ops[def].result_def = -1;
1002
1003
2.92k
        op_array->opcodes[def].result_type = IS_UNUSED;
1004
2.92k
        op_array->opcodes[def].result.var = 0;
1005
1006
2.92k
        if (ssa->ops[use].op1_use == result_var) {
1007
1.03k
          ssa->ops[use].op1_use = cv_var;
1008
1.03k
          ssa->ops[use].op1_use_chain = ssa->vars[cv_var].use_chain;
1009
1.03k
          ssa->vars[cv_var].use_chain = use;
1010
1011
1.03k
          op_array->opcodes[use].op1_type = IS_CV;
1012
1.03k
          op_array->opcodes[use].op1.var = cv;
1013
1.88k
        } else if (ssa->ops[use].op2_use == result_var) {
1014
1.88k
          ssa->ops[use].op2_use = cv_var;
1015
1.88k
          ssa->ops[use].op2_use_chain = ssa->vars[cv_var].use_chain;
1016
1.88k
          ssa->vars[cv_var].use_chain = use;
1017
1018
1.88k
          op_array->opcodes[use].op2_type = IS_CV;
1019
1.88k
          op_array->opcodes[use].op2.var = cv;
1020
1.88k
        } else if (ssa->ops[use].result_use == result_var) {
1021
0
          ssa->ops[use].result_use = cv_var;
1022
0
          ssa->ops[use].res_use_chain = ssa->vars[cv_var].use_chain;
1023
0
          ssa->vars[cv_var].use_chain = use;
1024
1025
0
          op_array->opcodes[use].result_type = IS_CV;
1026
0
          op_array->opcodes[use].result.var = cv;
1027
0
        }
1028
1029
2.92k
        return true;
1030
3.86k
      }
1031
3.86k
    }
1032
4.14k
  }
1033
1034
2.52k
  return false;
1035
6.39k
}
1036
1037
void zend_dfa_optimize_op_array(zend_op_array *op_array, zend_optimizer_ctx *ctx, zend_ssa *ssa, zend_call_info **call_map)
1038
37.0k
{
1039
37.0k
  if (ctx->debug_level & ZEND_DUMP_BEFORE_DFA_PASS) {
1040
0
    zend_dump_op_array(op_array, ZEND_DUMP_SSA, "before dfa pass", ssa);
1041
0
  }
1042
1043
37.0k
  if (ssa->var_info) {
1044
37.0k
    int op_1;
1045
37.0k
    int v;
1046
37.0k
    int remove_nops = 0;
1047
37.0k
    zend_op *opline;
1048
37.0k
    zend_ssa_op *ssa_op;
1049
37.0k
    zval tmp;
1050
1051
37.0k
#if ZEND_DEBUG_DFA
1052
37.0k
    ssa_verify_integrity(op_array, ssa, "before dfa");
1053
37.0k
#endif
1054
1055
37.0k
    if (ZEND_OPTIMIZER_PASS_8 & ctx->optimization_level) {
1056
37.0k
      if (sccp_optimize_op_array(ctx, op_array, ssa, call_map)) {
1057
857
        remove_nops = 1;
1058
857
      }
1059
1060
37.0k
      if (zend_dfa_optimize_jmps(op_array, ssa)) {
1061
293
        remove_nops = 1;
1062
293
      }
1063
1064
37.0k
#if ZEND_DEBUG_DFA
1065
37.0k
      ssa_verify_integrity(op_array, ssa, "after sccp");
1066
37.0k
#endif
1067
37.0k
      if (ZEND_FUNC_INFO(op_array)) {
1068
37.0k
        if (zend_dfa_optimize_calls(op_array, ssa)) {
1069
0
          remove_nops = 1;
1070
0
        }
1071
37.0k
      }
1072
37.0k
      if (ctx->debug_level & ZEND_DUMP_AFTER_PASS_8) {
1073
0
        zend_dump_op_array(op_array, ZEND_DUMP_SSA, "after sccp pass", ssa);
1074
0
      }
1075
37.0k
#if ZEND_DEBUG_DFA
1076
37.0k
      ssa_verify_integrity(op_array, ssa, "after calls");
1077
37.0k
#endif
1078
37.0k
    }
1079
1080
37.0k
    if (ZEND_OPTIMIZER_PASS_14 & ctx->optimization_level) {
1081
37.0k
      if (dce_optimize_op_array(op_array, ctx, ssa, 0)) {
1082
2.57k
        remove_nops = 1;
1083
2.57k
      }
1084
37.0k
      if (zend_dfa_optimize_jmps(op_array, ssa)) {
1085
99
        remove_nops = 1;
1086
99
      }
1087
37.0k
      if (ctx->debug_level & ZEND_DUMP_AFTER_PASS_14) {
1088
0
        zend_dump_op_array(op_array, ZEND_DUMP_SSA, "after dce pass", ssa);
1089
0
      }
1090
37.0k
#if ZEND_DEBUG_DFA
1091
37.0k
      ssa_verify_integrity(op_array, ssa, "after dce");
1092
37.0k
#endif
1093
37.0k
    }
1094
1095
654k
    for (v = op_array->last_var; v < ssa->vars_count; v++) {
1096
1097
617k
      op_1 = ssa->vars[v].definition;
1098
1099
617k
      if (op_1 < 0) {
1100
111k
        continue;
1101
111k
      }
1102
1103
505k
      opline = op_array->opcodes + op_1;
1104
505k
      ssa_op = &ssa->ops[op_1];
1105
1106
      /* Convert LONG constants to DOUBLE */
1107
505k
      if (ssa->var_info[v].use_as_double) {
1108
0
        if (opline->opcode == ZEND_ASSIGN
1109
0
         && opline->op2_type == IS_CONST
1110
0
         && ssa->ops[op_1].op1_def == v
1111
0
         && !RETURN_VALUE_USED(opline)
1112
0
        ) {
1113
1114
// op_1: ASSIGN ? -> #v [use_as_double], long(?) => ASSIGN ? -> #v, double(?)
1115
1116
0
          zval *zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1117
0
          ZEND_ASSERT(Z_TYPE_INFO_P(zv) == IS_LONG);
1118
0
          ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1119
0
          opline->op2.constant = zend_optimizer_add_literal(op_array, &tmp);
1120
1121
0
        } else if (opline->opcode == ZEND_QM_ASSIGN
1122
0
         && opline->op1_type == IS_CONST
1123
0
        ) {
1124
1125
// op_1: QM_ASSIGN #v [use_as_double], long(?) => QM_ASSIGN #v, double(?)
1126
1127
0
          zval *zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1128
0
          ZEND_ASSERT(Z_TYPE_INFO_P(zv) == IS_LONG);
1129
0
          ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1130
0
          opline->op1.constant = zend_optimizer_add_literal(op_array, &tmp);
1131
0
        }
1132
1133
505k
      } else {
1134
505k
        if (opline->opcode == ZEND_ADD
1135
499k
         || opline->opcode == ZEND_SUB
1136
495k
         || opline->opcode == ZEND_MUL
1137
491k
         || opline->opcode == ZEND_IS_EQUAL
1138
490k
         || opline->opcode == ZEND_IS_NOT_EQUAL
1139
489k
         || opline->opcode == ZEND_IS_SMALLER
1140
485k
         || opline->opcode == ZEND_IS_SMALLER_OR_EQUAL
1141
505k
        ) {
1142
1143
21.0k
          if (opline->op1_type == IS_CONST && opline->op2_type != IS_CONST) {
1144
2.40k
            zval *zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1145
1146
2.40k
            if ((OP2_INFO() & MAY_BE_ANY) == MAY_BE_DOUBLE
1147
6
             && Z_TYPE_INFO_P(zv) == IS_LONG) {
1148
1149
// op_1: #v.? = ADD long(?), #?.? [double] => #v.? = ADD double(?), #?.? [double]
1150
1151
2
              ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1152
2
              opline->op1.constant = zend_optimizer_add_literal(op_array, &tmp);
1153
2
              zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1154
2
            }
1155
2.40k
            if (opline->opcode == ZEND_ADD) {
1156
896
              zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1157
1158
896
              if (((OP2_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_LONG
1159
34
                && Z_TYPE_INFO_P(zv) == IS_LONG
1160
10
                && Z_LVAL_P(zv) == 0)
1161
896
               || ((OP2_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_DOUBLE
1162
4
                && Z_TYPE_INFO_P(zv) == IS_DOUBLE
1163
0
                && Z_DVAL_P(zv) == 0.0)) {
1164
1165
// op_1: #v.? = ADD 0, #?.? [double,long] => #v.? = QM_ASSIGN #?.?
1166
1167
0
                opline->opcode = ZEND_QM_ASSIGN;
1168
0
                opline->op1_type = opline->op2_type;
1169
0
                opline->op1.var = opline->op2.var;
1170
0
                opline->op2_type = IS_UNUSED;
1171
0
                opline->op2.num = 0;
1172
0
                ssa->ops[op_1].op1_use = ssa->ops[op_1].op2_use;
1173
0
                ssa->ops[op_1].op1_use_chain = ssa->ops[op_1].op2_use_chain;
1174
0
                ssa->ops[op_1].op2_use = -1;
1175
0
                ssa->ops[op_1].op2_use_chain = -1;
1176
0
              }
1177
1.50k
            } else if (opline->opcode == ZEND_MUL
1178
6
             && (OP2_INFO() & ((MAY_BE_ANY|MAY_BE_UNDEF)-(MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1179
0
              zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1180
1181
0
              if ((Z_TYPE_INFO_P(zv) == IS_LONG
1182
0
                && Z_LVAL_P(zv) == 2)
1183
0
               || (Z_TYPE_INFO_P(zv) == IS_DOUBLE
1184
0
                && Z_DVAL_P(zv) == 2.0
1185
0
                && !(OP2_INFO() & MAY_BE_LONG))) {
1186
1187
// op_1: #v.? = MUL 2, #x.? [double,long] => #v.? = ADD #x.?, #x.?
1188
1189
0
                opline->opcode = ZEND_ADD;
1190
0
                opline->op1_type = opline->op2_type;
1191
0
                opline->op1.var = opline->op2.var;
1192
0
                ssa->ops[op_1].op1_use = ssa->ops[op_1].op2_use;
1193
0
                ssa->ops[op_1].op1_use_chain = ssa->ops[op_1].op2_use_chain;
1194
0
              }
1195
0
            }
1196
18.6k
          } else if (opline->op1_type != IS_CONST && opline->op2_type == IS_CONST) {
1197
5.98k
            zval *zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1198
1199
5.98k
            if ((OP1_INFO() & MAY_BE_ANY) == MAY_BE_DOUBLE
1200
109
             && Z_TYPE_INFO_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == IS_LONG) {
1201
1202
// op_1: #v.? = ADD #?.? [double], long(?) => #v.? = ADD #?.? [double], double(?)
1203
1204
69
              ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1205
69
              opline->op2.constant = zend_optimizer_add_literal(op_array, &tmp);
1206
69
              zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1207
69
            }
1208
5.98k
            if (opline->opcode == ZEND_ADD || opline->opcode == ZEND_SUB) {
1209
1.43k
              if (((OP1_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_LONG
1210
318
                && Z_TYPE_INFO_P(zv) == IS_LONG
1211
310
                && Z_LVAL_P(zv) == 0)
1212
1.42k
               || ((OP1_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_DOUBLE
1213
30
                && Z_TYPE_INFO_P(zv) == IS_DOUBLE
1214
30
                && Z_DVAL_P(zv) == 0.0)) {
1215
1216
// op_1: #v.? = ADD #?.? [double,long], 0 => #v.? = QM_ASSIGN #?.?
1217
1218
10
                opline->opcode = ZEND_QM_ASSIGN;
1219
10
                opline->op2_type = IS_UNUSED;
1220
10
                opline->op2.num = 0;
1221
10
              }
1222
4.54k
            } else if (opline->opcode == ZEND_MUL
1223
1.53k
             && (OP1_INFO() & ((MAY_BE_ANY|MAY_BE_UNDEF)-(MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1224
291
              zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1225
1226
291
              if ((Z_TYPE_INFO_P(zv) == IS_LONG
1227
213
                && Z_LVAL_P(zv) == 2)
1228
269
               || (Z_TYPE_INFO_P(zv) == IS_DOUBLE
1229
22
                && Z_DVAL_P(zv) == 2.0
1230
24
                && !(OP1_INFO() & MAY_BE_LONG))) {
1231
1232
// op_1: #v.? = MUL #x.? [double,long], 2 => #v.? = ADD #x.?, #x.?
1233
1234
24
                opline->opcode = ZEND_ADD;
1235
24
                opline->op2_type = opline->op1_type;
1236
24
                opline->op2.var = opline->op1.var;
1237
24
                ssa->ops[op_1].op2_use = ssa->ops[op_1].op1_use;
1238
24
                ssa->ops[op_1].op2_use_chain = ssa->ops[op_1].op1_use_chain;
1239
24
              }
1240
291
            }
1241
5.98k
          }
1242
484k
        } else if (opline->opcode == ZEND_CONCAT) {
1243
4.48k
          if (!(OP1_INFO() & MAY_BE_OBJECT)
1244
2.81k
           && !(OP2_INFO() & MAY_BE_OBJECT)) {
1245
1.71k
            opline->opcode = ZEND_FAST_CONCAT;
1246
1.71k
          }
1247
479k
        } else if (opline->opcode == ZEND_VERIFY_RETURN_TYPE
1248
898
         && opline->op1_type != IS_CONST
1249
830
         && ssa->ops[op_1].op1_def == v
1250
830
         && ssa->ops[op_1].op1_use >= 0) {
1251
830
          int orig_var = ssa->ops[op_1].op1_use;
1252
830
          int ret = ssa->vars[v].use_chain;
1253
1254
830
          if (ssa->ops[op_1].op1_use_chain == -1
1255
822
           && can_elide_return_type_check(ctx->script, op_array, ssa, &ssa->ops[op_1])) {
1256
1257
// op_1: VERIFY_RETURN_TYPE #orig_var.? [T] -> #v.? [T] => NOP
1258
1259
400
            zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1260
1261
400
            if (ret >= 0) {
1262
400
              ssa->ops[ret].op1_use = orig_var;
1263
400
              ssa->ops[ret].op1_use_chain = ssa->vars[orig_var].use_chain;
1264
400
              ssa->vars[orig_var].use_chain = ret;
1265
400
            }
1266
1267
400
            ssa->vars[v].definition = -1;
1268
400
            ssa->vars[v].use_chain = -1;
1269
1270
400
            ssa->ops[op_1].op1_def = -1;
1271
400
            ssa->ops[op_1].op1_use = -1;
1272
1273
400
            MAKE_NOP(opline);
1274
400
            remove_nops = 1;
1275
430
          } else if (ret >= 0
1276
430
           && ssa->ops[ret].op1_use == v
1277
430
           && ssa->ops[ret].op1_use_chain == -1
1278
430
           && can_elide_return_type_check(ctx->script, op_array, ssa, &ssa->ops[op_1])) {
1279
1280
// op_1: VERIFY_RETURN_TYPE #orig_var.? [T] -> #v.? [T] => NOP
1281
1282
4
            zend_ssa_replace_use_chain(ssa, op_1, ret, orig_var);
1283
1284
4
            ssa->ops[ret].op1_use = orig_var;
1285
4
            ssa->ops[ret].op1_use_chain = ssa->ops[op_1].op1_use_chain;
1286
1287
4
            ssa->vars[v].definition = -1;
1288
4
            ssa->vars[v].use_chain = -1;
1289
1290
4
            ssa->ops[op_1].op1_def = -1;
1291
4
            ssa->ops[op_1].op1_use = -1;
1292
1293
4
            MAKE_NOP(opline);
1294
4
            remove_nops = 1;
1295
4
          }
1296
830
        }
1297
505k
      }
1298
1299
505k
      if (opline->opcode == ZEND_QM_ASSIGN
1300
3.68k
       && ssa->ops[op_1].result_def == v
1301
3.68k
       && opline->op1_type & (IS_TMP_VAR|IS_VAR)
1302
503
       && !(ssa->var_info[v].type & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
1303
505k
      ) {
1304
1305
89
        int src_var = ssa->ops[op_1].op1_use;
1306
1307
89
        if (src_var >= 0
1308
89
         && !(ssa->var_info[src_var].type & MAY_BE_REF)
1309
89
         && (ssa->var_info[src_var].type & (MAY_BE_UNDEF|MAY_BE_ANY))
1310
89
         && ssa->vars[src_var].definition >= 0
1311
28
         && ssa->ops[ssa->vars[src_var].definition].result_def == src_var
1312
28
         && ssa->ops[ssa->vars[src_var].definition].result_use < 0
1313
28
         && ssa->vars[src_var].use_chain == op_1
1314
28
         && ssa->ops[op_1].op1_use_chain < 0
1315
28
         && !ssa->vars[src_var].phi_use_chain
1316
28
         && !ssa->vars[src_var].sym_use_chain
1317
28
         && opline_supports_assign_contraction(
1318
28
           op_array, ssa, &op_array->opcodes[ssa->vars[src_var].definition],
1319
28
           src_var, opline->result.var)
1320
28
         && !variable_defined_or_used_in_range(ssa, EX_VAR_TO_NUM(opline->result.var),
1321
28
            ssa->vars[src_var].definition+1, op_1)
1322
89
        ) {
1323
1324
28
          int orig_var = ssa->ops[op_1].result_use;
1325
28
          int op_2 = ssa->vars[src_var].definition;
1326
1327
// op_2: #src_var.T = OP ...                                        => #v.CV = OP ...
1328
// op_1: QM_ASSIGN #src_var.T #orig_var.CV [undef,scalar] -> #v.CV,    NOP
1329
1330
28
          if (orig_var >= 0) {
1331
0
            zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1332
0
          }
1333
1334
          /* Reconstruct SSA */
1335
28
          ssa->vars[v].definition = op_2;
1336
28
          ssa->ops[op_2].result_def = v;
1337
1338
28
          ssa->vars[src_var].definition = -1;
1339
28
          ssa->vars[src_var].use_chain = -1;
1340
1341
28
          ssa->ops[op_1].op1_use = -1;
1342
28
          ssa->ops[op_1].op1_def = -1;
1343
28
          ssa->ops[op_1].op1_use_chain = -1;
1344
28
          ssa->ops[op_1].result_use = -1;
1345
28
          ssa->ops[op_1].result_def = -1;
1346
28
          ssa->ops[op_1].res_use_chain = -1;
1347
1348
          /* Update opcodes */
1349
28
          op_array->opcodes[op_2].result_type = opline->result_type;
1350
28
          op_array->opcodes[op_2].result.var = opline->result.var;
1351
1352
28
          MAKE_NOP(opline);
1353
28
          remove_nops = 1;
1354
1355
28
          if (op_array->opcodes[op_2].opcode == ZEND_SUB
1356
2
           && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1357
2
           && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1358
0
           && op_array->opcodes[op_2].op2_type == IS_CONST
1359
0
           && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1360
0
           && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1361
0
           && ssa->ops[op_2].op1_use >= 0
1362
0
           && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1363
1364
0
            op_array->opcodes[op_2].opcode = ZEND_PRE_DEC;
1365
0
            SET_UNUSED(op_array->opcodes[op_2].op2);
1366
0
            SET_UNUSED(op_array->opcodes[op_2].result);
1367
1368
0
            ssa->ops[op_2].result_def = -1;
1369
0
            ssa->ops[op_2].op1_def = v;
1370
1371
28
          } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1372
0
           && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1373
0
           && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1374
0
           && op_array->opcodes[op_2].op2_type == IS_CONST
1375
0
           && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1376
0
           && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1377
0
           && ssa->ops[op_2].op1_use >= 0
1378
0
           && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1379
1380
0
            op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1381
0
            SET_UNUSED(op_array->opcodes[op_2].op2);
1382
0
            SET_UNUSED(op_array->opcodes[op_2].result);
1383
1384
0
            ssa->ops[op_2].result_def = -1;
1385
0
            ssa->ops[op_2].op1_def = v;
1386
1387
28
          } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1388
0
           && op_array->opcodes[op_2].op2_type == op_array->opcodes[op_2].result_type
1389
0
           && op_array->opcodes[op_2].op2.var == op_array->opcodes[op_2].result.var
1390
0
           && op_array->opcodes[op_2].op1_type == IS_CONST
1391
0
           && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == IS_LONG
1392
0
           && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == 1
1393
0
           && ssa->ops[op_2].op2_use >= 0
1394
0
           && !(ssa->var_info[ssa->ops[op_2].op2_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1395
1396
0
            op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1397
0
            op_array->opcodes[op_2].op1_type = op_array->opcodes[op_2].op2_type;
1398
0
            op_array->opcodes[op_2].op1.var = op_array->opcodes[op_2].op2.var;
1399
0
            SET_UNUSED(op_array->opcodes[op_2].op2);
1400
0
            SET_UNUSED(op_array->opcodes[op_2].result);
1401
1402
0
            ssa->ops[op_2].result_def = -1;
1403
0
            ssa->ops[op_2].op1_def = v;
1404
0
            ssa->ops[op_2].op1_use = ssa->ops[op_2].op2_use;
1405
0
            ssa->ops[op_2].op1_use_chain = ssa->ops[op_2].op2_use_chain;
1406
0
            ssa->ops[op_2].op2_use = -1;
1407
0
            ssa->ops[op_2].op2_use_chain = -1;
1408
0
          }
1409
28
        }
1410
89
      }
1411
1412
505k
      if (ssa->vars[v].var >= op_array->last_var) {
1413
        /* skip TMP and VAR */
1414
442k
        continue;
1415
442k
      }
1416
1417
62.4k
      if (ssa->ops[op_1].op1_def == v
1418
48.9k
       && RETURN_VALUE_USED(opline)) {
1419
10.5k
        if (opline->opcode == ZEND_ASSIGN
1420
5.51k
         || opline->opcode == ZEND_ASSIGN_OP
1421
4.51k
         || opline->opcode == ZEND_PRE_INC
1422
6.39k
         || opline->opcode == ZEND_PRE_DEC) {
1423
6.39k
          zend_dfa_try_to_replace_result(op_array, ssa, op_1, v);
1424
6.39k
        } else if (opline->opcode == ZEND_POST_INC) {
1425
396
          int result_var = ssa->ops[op_1].result_def;
1426
1427
396
          if (result_var >= 0
1428
396
           && (ssa->var_info[result_var].type & ((MAY_BE_ANY|MAY_BE_REF|MAY_BE_UNDEF) - (MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1429
261
            int use = ssa->vars[result_var].use_chain;
1430
1431
261
            if (use >= 0 && op_array->opcodes[use].opcode == ZEND_IS_SMALLER
1432
6
             && ssa->ops[use].op1_use == result_var
1433
6
             && zend_dfa_try_to_replace_result(op_array, ssa, op_1, v)) {
1434
6
              opline->opcode = ZEND_PRE_INC;
1435
6
              op_array->opcodes[use].opcode = ZEND_IS_SMALLER_OR_EQUAL;
1436
6
            }
1437
261
          }
1438
3.75k
        } else if (opline->opcode == ZEND_POST_DEC) {
1439
268
          int result_var = ssa->ops[op_1].result_def;
1440
1441
268
          if (result_var >= 0
1442
268
           && (ssa->var_info[result_var].type & ((MAY_BE_ANY|MAY_BE_REF|MAY_BE_UNDEF) - (MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1443
89
            int use = ssa->vars[result_var].use_chain;
1444
1445
89
            if (use >= 0 && op_array->opcodes[use].opcode == ZEND_IS_SMALLER
1446
0
             && ssa->ops[use].op2_use == result_var
1447
0
             && zend_dfa_try_to_replace_result(op_array, ssa, op_1, v)) {
1448
0
              opline->opcode = ZEND_PRE_DEC;
1449
0
              op_array->opcodes[use].opcode = ZEND_IS_SMALLER_OR_EQUAL;
1450
0
            }
1451
89
          }
1452
268
        }
1453
10.5k
      }
1454
1455
62.4k
      if (opline->opcode == ZEND_ASSIGN
1456
26.2k
       && ssa->ops[op_1].op1_def == v
1457
26.2k
       && !RETURN_VALUE_USED(opline)
1458
62.4k
      ) {
1459
23.4k
        int orig_var = ssa->ops[op_1].op1_use;
1460
1461
23.4k
        if (orig_var >= 0
1462
23.3k
         && !(ssa->var_info[orig_var].type & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
1463
23.4k
        ) {
1464
5.44k
          int src_var = ssa->ops[op_1].op2_use;
1465
1466
5.44k
          if ((opline->op2_type & (IS_TMP_VAR|IS_VAR))
1467
2.92k
           && src_var >= 0
1468
2.92k
           && !(ssa->var_info[src_var].type & MAY_BE_REF)
1469
2.87k
           && (ssa->var_info[src_var].type & (MAY_BE_UNDEF|MAY_BE_ANY))
1470
2.82k
           && ssa->vars[src_var].definition >= 0
1471
2.70k
           && ssa->ops[ssa->vars[src_var].definition].result_def == src_var
1472
2.70k
           && ssa->ops[ssa->vars[src_var].definition].result_use < 0
1473
2.68k
           && ssa->vars[src_var].use_chain == op_1
1474
2.63k
           && ssa->ops[op_1].op2_use_chain < 0
1475
2.63k
           && !ssa->vars[src_var].phi_use_chain
1476
2.63k
           && !ssa->vars[src_var].sym_use_chain
1477
2.63k
           && opline_supports_assign_contraction(
1478
2.63k
             op_array, ssa, &op_array->opcodes[ssa->vars[src_var].definition],
1479
2.63k
             src_var, opline->op1.var)
1480
1.89k
           && !variable_defined_or_used_in_range(ssa, EX_VAR_TO_NUM(opline->op1.var),
1481
1.89k
              ssa->vars[src_var].definition+1, op_1)
1482
5.44k
          ) {
1483
1484
1.89k
            int op_2 = ssa->vars[src_var].definition;
1485
1486
// op_2: #src_var.T = OP ...                                     => #v.CV = OP ...
1487
// op_1: ASSIGN #orig_var.CV [undef,scalar] -> #v.CV, #src_var.T    NOP
1488
1489
1.89k
            zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1490
            /* Reconstruct SSA */
1491
1.89k
            ssa->vars[v].definition = op_2;
1492
1.89k
            ssa->ops[op_2].result_def = v;
1493
1494
1.89k
            ssa->vars[src_var].definition = -1;
1495
1.89k
            ssa->vars[src_var].use_chain = -1;
1496
1497
1.89k
            ssa->ops[op_1].op1_use = -1;
1498
1.89k
            ssa->ops[op_1].op2_use = -1;
1499
1.89k
            ssa->ops[op_1].op1_def = -1;
1500
1.89k
            ssa->ops[op_1].op1_use_chain = -1;
1501
1502
            /* Update opcodes */
1503
1.89k
            op_array->opcodes[op_2].result_type = opline->op1_type;
1504
1.89k
            op_array->opcodes[op_2].result.var = opline->op1.var;
1505
1506
1.89k
            MAKE_NOP(opline);
1507
1.89k
            remove_nops = 1;
1508
1509
1.89k
            if (op_array->opcodes[op_2].opcode == ZEND_SUB
1510
160
             && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1511
136
             && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1512
10
             && op_array->opcodes[op_2].op2_type == IS_CONST
1513
0
             && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1514
0
             && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1515
0
             && ssa->ops[op_2].op1_use >= 0
1516
0
             && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1517
1518
0
              op_array->opcodes[op_2].opcode = ZEND_PRE_DEC;
1519
0
              SET_UNUSED(op_array->opcodes[op_2].op2);
1520
0
              SET_UNUSED(op_array->opcodes[op_2].result);
1521
1522
0
              ssa->ops[op_2].result_def = -1;
1523
0
              ssa->ops[op_2].op1_def = v;
1524
1525
1.89k
            } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1526
978
             && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1527
651
             && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1528
430
             && op_array->opcodes[op_2].op2_type == IS_CONST
1529
24
             && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1530
0
             && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1531
0
             && ssa->ops[op_2].op1_use >= 0
1532
0
             && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1533
1534
0
              op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1535
0
              SET_UNUSED(op_array->opcodes[op_2].op2);
1536
0
              SET_UNUSED(op_array->opcodes[op_2].result);
1537
1538
0
              ssa->ops[op_2].result_def = -1;
1539
0
              ssa->ops[op_2].op1_def = v;
1540
1541
1.89k
            } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1542
978
             && op_array->opcodes[op_2].op2_type == op_array->opcodes[op_2].result_type
1543
501
             && op_array->opcodes[op_2].op2.var == op_array->opcodes[op_2].result.var
1544
96
             && op_array->opcodes[op_2].op1_type == IS_CONST
1545
0
             && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == IS_LONG
1546
0
             && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == 1
1547
0
             && ssa->ops[op_2].op2_use >= 0
1548
0
             && !(ssa->var_info[ssa->ops[op_2].op2_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1549
1550
0
              op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1551
0
              op_array->opcodes[op_2].op1_type = op_array->opcodes[op_2].op2_type;
1552
0
              op_array->opcodes[op_2].op1.var = op_array->opcodes[op_2].op2.var;
1553
0
              SET_UNUSED(op_array->opcodes[op_2].op2);
1554
0
              SET_UNUSED(op_array->opcodes[op_2].result);
1555
1556
0
              ssa->ops[op_2].result_def = -1;
1557
0
              ssa->ops[op_2].op1_def = v;
1558
0
              ssa->ops[op_2].op1_use = ssa->ops[op_2].op2_use;
1559
0
              ssa->ops[op_2].op1_use_chain = ssa->ops[op_2].op2_use_chain;
1560
0
              ssa->ops[op_2].op2_use = -1;
1561
0
              ssa->ops[op_2].op2_use_chain = -1;
1562
0
            }
1563
3.54k
          } else if (opline->op2_type == IS_CONST
1564
2.02k
           || ((opline->op2_type & (IS_TMP_VAR|IS_VAR|IS_CV))
1565
2.02k
               && ssa->ops[op_1].op2_use >= 0
1566
2.02k
               && ssa->ops[op_1].op2_def < 0)
1567
3.54k
          ) {
1568
1569
// op_1: ASSIGN #orig_var.CV [undef,scalar] -> #v.CV, CONST|TMPVAR => QM_ASSIGN v.CV, CONST|TMPVAR
1570
1571
3.54k
            if (ssa->ops[op_1].op1_use != ssa->ops[op_1].op2_use) {
1572
3.24k
              zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1573
3.24k
            } else {
1574
299
              ssa->ops[op_1].op2_use_chain = ssa->ops[op_1].op1_use_chain;
1575
299
            }
1576
1577
            /* Reconstruct SSA */
1578
3.54k
            ssa->ops[op_1].result_def = v;
1579
3.54k
            ssa->ops[op_1].op1_def = -1;
1580
3.54k
            ssa->ops[op_1].op1_use = ssa->ops[op_1].op2_use;
1581
3.54k
            ssa->ops[op_1].op1_use_chain = ssa->ops[op_1].op2_use_chain;
1582
3.54k
            ssa->ops[op_1].op2_use = -1;
1583
3.54k
            ssa->ops[op_1].op2_use_chain = -1;
1584
1585
            /* Update opcode */
1586
3.54k
            opline->result_type = opline->op1_type;
1587
3.54k
            opline->result.var = opline->op1.var;
1588
3.54k
            opline->op1_type = opline->op2_type;
1589
3.54k
            opline->op1.var = opline->op2.var;
1590
3.54k
            opline->op2_type = IS_UNUSED;
1591
3.54k
            opline->op2.var = 0;
1592
3.54k
            opline->opcode = ZEND_QM_ASSIGN;
1593
3.54k
          }
1594
5.44k
        }
1595
1596
38.9k
      } else if (opline->opcode == ZEND_ASSIGN_OP
1597
2.50k
       && opline->extended_value == ZEND_ADD
1598
987
       && ssa->ops[op_1].op1_def == v
1599
987
       && opline->op2_type == IS_CONST
1600
146
       && Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == IS_LONG
1601
63
       && Z_LVAL_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == 1
1602
18
       && ssa->ops[op_1].op1_use >= 0
1603
18
       && !(ssa->var_info[ssa->ops[op_1].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1604
1605
// op_1: ASSIGN_ADD #?.CV [undef,null,int,foat] ->#v.CV, int(1) => PRE_INC #?.CV ->#v.CV
1606
1607
4
        opline->opcode = ZEND_PRE_INC;
1608
4
        opline->extended_value = 0;
1609
4
        SET_UNUSED(opline->op2);
1610
1611
38.9k
      } else if (opline->opcode == ZEND_ASSIGN_OP
1612
2.50k
       && opline->extended_value == ZEND_SUB
1613
161
       && ssa->ops[op_1].op1_def == v
1614
161
       && opline->op2_type == IS_CONST
1615
44
       && Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == IS_LONG
1616
42
       && Z_LVAL_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == 1
1617
2
       && ssa->ops[op_1].op1_use >= 0
1618
2
       && !(ssa->var_info[ssa->ops[op_1].op1_use].type & (MAY_BE_UNDEF|MAY_BE_NULL|MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1619
1620
// op_1: ASSIGN_SUB #?.CV [undef,null,int,foat] -> #v.CV, int(1) => PRE_DEC #?.CV ->#v.CV
1621
1622
0
        opline->opcode = ZEND_PRE_DEC;
1623
0
        opline->extended_value = 0;
1624
0
        SET_UNUSED(opline->op2);
1625
1626
38.9k
      } else if (ssa->ops[op_1].op1_def == v
1627
25.4k
       && !RETURN_VALUE_USED(opline)
1628
17.8k
       && ssa->ops[op_1].op1_use >= 0
1629
17.8k
       && !(ssa->var_info[ssa->ops[op_1].op1_use].type & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
1630
5.88k
       && opline->opcode == ZEND_ASSIGN_OP
1631
1.20k
       && opline->extended_value != ZEND_CONCAT) {
1632
1633
// op_1: ASSIGN_OP #orig_var.CV [undef,null,bool,int,double] -> #v.CV, ? => #v.CV = ADD #orig_var.CV, ?
1634
1635
        /* Reconstruct SSA */
1636
1.05k
        ssa->ops[op_1].result_def = ssa->ops[op_1].op1_def;
1637
1.05k
        ssa->ops[op_1].op1_def = -1;
1638
1639
        /* Update opcode */
1640
1.05k
        opline->opcode = opline->extended_value;
1641
1.05k
        opline->extended_value = 0;
1642
1.05k
        opline->result_type = opline->op1_type;
1643
1.05k
        opline->result.var = opline->op1.var;
1644
1645
1.05k
      }
1646
62.4k
    }
1647
1648
37.0k
#if ZEND_DEBUG_DFA
1649
37.0k
    ssa_verify_integrity(op_array, ssa, "after dfa");
1650
37.0k
#endif
1651
1652
37.0k
    if (remove_nops) {
1653
3.65k
      zend_ssa_remove_nops(op_array, ssa, ctx);
1654
3.65k
#if ZEND_DEBUG_DFA
1655
3.65k
      ssa_verify_integrity(op_array, ssa, "after nop");
1656
3.65k
#endif
1657
3.65k
    }
1658
37.0k
  }
1659
1660
37.0k
  if (ctx->debug_level & ZEND_DUMP_AFTER_DFA_PASS) {
1661
0
    zend_dump_op_array(op_array, ZEND_DUMP_SSA, "after dfa pass", ssa);
1662
0
  }
1663
37.0k
}
1664
1665
void zend_optimize_dfa(zend_op_array *op_array, zend_optimizer_ctx *ctx)
1666
0
{
1667
0
  void *checkpoint = zend_arena_checkpoint(ctx->arena);
1668
0
  zend_ssa ssa;
1669
1670
0
  if (zend_dfa_analyze_op_array(op_array, ctx, &ssa) == FAILURE) {
1671
0
    zend_arena_release(&ctx->arena, checkpoint);
1672
0
    return;
1673
0
  }
1674
1675
0
  zend_dfa_optimize_op_array(op_array, ctx, &ssa, NULL);
1676
1677
  /* Destroy SSA */
1678
0
  zend_arena_release(&ctx->arena, checkpoint);
1679
0
}