Coverage Report

Created: 2026-06-02 06:36

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/php-src/Zend/Optimizer/dfa_pass.c
Line
Count
Source
1
/*
2
   +----------------------------------------------------------------------+
3
   | Zend OPcache                                                         |
4
   +----------------------------------------------------------------------+
5
   | Copyright © The PHP Group and Contributors.                          |
6
   +----------------------------------------------------------------------+
7
   | This source file is subject to the Modified BSD License that is      |
8
   | bundled with this package in the file LICENSE, and is available      |
9
   | through the World Wide Web at <https://www.php.net/license/>.        |
10
   |                                                                      |
11
   | SPDX-License-Identifier: BSD-3-Clause                                |
12
   +----------------------------------------------------------------------+
13
   | Authors: Dmitry Stogov <dmitry@php.net>                              |
14
   +----------------------------------------------------------------------+
15
*/
16
17
#include "Optimizer/zend_optimizer.h"
18
#include "Optimizer/zend_optimizer_internal.h"
19
#include "zend_API.h"
20
#include "zend_constants.h"
21
#include "zend_execute.h"
22
#include "zend_vm.h"
23
#include "zend_bitset.h"
24
#include "zend_cfg.h"
25
#include "zend_ssa.h"
26
#include "zend_func_info.h"
27
#include "zend_call_graph.h"
28
#include "zend_inference.h"
29
#include "zend_dump.h"
30
31
#ifndef ZEND_DEBUG_DFA
32
# define ZEND_DEBUG_DFA ZEND_DEBUG
33
#endif
34
35
#if ZEND_DEBUG_DFA
36
# include "ssa_integrity.c"
37
#endif
38
39
zend_result zend_dfa_analyze_op_array(zend_op_array *op_array, zend_optimizer_ctx *ctx, zend_ssa *ssa)
40
1
{
41
1
  uint32_t build_flags;
42
43
1
  if (op_array->last_try_catch) {
44
    /* TODO: we can't analyze functions with try/catch/finally ??? */
45
0
    return FAILURE;
46
0
  }
47
48
    /* Build SSA */
49
1
  memset(ssa, 0, sizeof(zend_ssa));
50
51
1
  zend_build_cfg(&ctx->arena, op_array, ZEND_CFG_NO_ENTRY_PREDECESSORS, &ssa->cfg);
52
53
1
  if ((ssa->cfg.flags & ZEND_FUNC_INDIRECT_VAR_ACCESS)) {
54
    /* TODO: we can't analyze functions with indirect variable access ??? */
55
0
    return FAILURE;
56
0
  }
57
58
1
  zend_cfg_build_predecessors(&ctx->arena, &ssa->cfg);
59
60
1
  if (ctx->debug_level & ZEND_DUMP_DFA_CFG) {
61
0
    zend_dump_op_array(op_array, ZEND_DUMP_CFG, "dfa cfg", &ssa->cfg);
62
0
  }
63
64
  /* Compute Dominators Tree */
65
1
  zend_cfg_compute_dominators_tree(op_array, &ssa->cfg);
66
67
  /* Identify reducible and irreducible loops */
68
1
  zend_cfg_identify_loops(op_array, &ssa->cfg);
69
70
1
  if (ctx->debug_level & ZEND_DUMP_DFA_DOMINATORS) {
71
0
    zend_dump_dominators(op_array, &ssa->cfg);
72
0
  }
73
74
1
  build_flags = 0;
75
1
  if (ctx->debug_level & ZEND_DUMP_DFA_LIVENESS) {
76
0
    build_flags |= ZEND_SSA_DEBUG_LIVENESS;
77
0
  }
78
1
  if (ctx->debug_level & ZEND_DUMP_DFA_PHI) {
79
0
    build_flags |= ZEND_SSA_DEBUG_PHI_PLACEMENT;
80
0
  }
81
1
  if (zend_build_ssa(&ctx->arena, ctx->script, op_array, build_flags, ssa) == FAILURE) {
82
0
    return FAILURE;
83
0
  }
84
85
1
  if (ctx->debug_level & ZEND_DUMP_DFA_SSA) {
86
0
    zend_dump_op_array(op_array, ZEND_DUMP_SSA, "dfa ssa", ssa);
87
0
  }
88
89
90
1
  zend_ssa_compute_use_def_chains(&ctx->arena, op_array, ssa);
91
92
1
  zend_ssa_find_false_dependencies(op_array, ssa);
93
94
1
  zend_ssa_find_sccs(op_array, ssa);
95
96
1
  if (zend_ssa_inference(&ctx->arena, op_array, ctx->script, ssa, ctx->optimization_level) == FAILURE) {
97
0
    return FAILURE;
98
0
  }
99
100
1
  if (zend_ssa_escape_analysis(ctx->script, op_array, ssa) == FAILURE) {
101
0
    return FAILURE;
102
0
  }
103
104
1
  if (ctx->debug_level & ZEND_DUMP_DFA_SSA_VARS) {
105
0
    zend_dump_ssa_variables(op_array, ssa, 0);
106
0
  }
107
108
1
  return SUCCESS;
109
1
}
110
111
static void zend_ssa_remove_nops(zend_op_array *op_array, zend_ssa *ssa, zend_optimizer_ctx *ctx)
112
0
{
113
0
  zend_basic_block *blocks = ssa->cfg.blocks;
114
0
  zend_basic_block *blocks_end = blocks + ssa->cfg.blocks_count;
115
0
  zend_basic_block *b;
116
0
  zend_func_info *func_info;
117
0
  int j;
118
0
  uint32_t i = 0;
119
0
  uint32_t target = 0;
120
0
  uint32_t *shiftlist;
121
0
  ALLOCA_FLAG(use_heap);
122
123
0
  shiftlist = (uint32_t *)do_alloca(sizeof(uint32_t) * op_array->last, use_heap);
124
0
  memset(shiftlist, 0, sizeof(uint32_t) * op_array->last);
125
  /* remove empty callee_info */
126
0
  func_info = ZEND_FUNC_INFO(op_array);
127
0
  if (func_info) {
128
0
    zend_call_info **call_info = &func_info->callee_info;
129
0
    while ((*call_info)) {
130
0
      if ((*call_info)->caller_init_opline->opcode == ZEND_NOP) {
131
0
        *call_info = (*call_info)->next_callee;
132
0
      } else {
133
0
        call_info = &(*call_info)->next_callee;
134
0
      }
135
0
    }
136
0
  }
137
138
0
  for (b = blocks; b < blocks_end; b++) {
139
0
    if (b->flags & (ZEND_BB_REACHABLE|ZEND_BB_UNREACHABLE_FREE)) {
140
0
      if (b->len) {
141
0
        uint32_t new_start, old_end;
142
0
        while (i < b->start) {
143
0
          shiftlist[i] = i - target;
144
0
          i++;
145
0
        }
146
147
0
        if (b->flags & ZEND_BB_UNREACHABLE_FREE) {
148
          /* Only keep the FREE for the loop var */
149
0
          ZEND_ASSERT(op_array->opcodes[b->start].opcode == ZEND_FREE
150
0
              || op_array->opcodes[b->start].opcode == ZEND_FE_FREE);
151
0
          b->len = 1;
152
0
        }
153
154
0
        new_start = target;
155
0
        old_end = b->start + b->len;
156
0
        while (i < old_end) {
157
0
          shiftlist[i] = i - target;
158
0
          if (EXPECTED(op_array->opcodes[i].opcode != ZEND_NOP)) {
159
0
            if (i != target) {
160
0
              op_array->opcodes[target] = op_array->opcodes[i];
161
0
              ssa->ops[target] = ssa->ops[i];
162
0
              ssa->cfg.map[target] = b - blocks;
163
0
            }
164
0
            target++;
165
0
          }
166
0
          i++;
167
0
        }
168
0
        b->start = new_start;
169
0
        if (target != old_end) {
170
0
          zend_op *opline;
171
0
          zend_op *new_opline;
172
173
0
          b->len = target - b->start;
174
0
          opline = op_array->opcodes + old_end - 1;
175
0
          if (opline->opcode == ZEND_NOP) {
176
0
            continue;
177
0
          }
178
179
0
          new_opline = op_array->opcodes + target - 1;
180
0
          zend_optimizer_migrate_jump(op_array, new_opline, opline);
181
0
        }
182
0
      } else {
183
0
        b->start = target;
184
0
      }
185
0
    } else {
186
0
      b->start = target;
187
0
      b->len = 0;
188
0
    }
189
0
  }
190
191
0
  if (target != op_array->last) {
192
    /* reset rest opcodes */
193
0
    for (i = target; i < op_array->last; i++) {
194
0
      MAKE_NOP(op_array->opcodes + i);
195
0
    }
196
197
    /* update SSA variables */
198
0
    for (j = 0; j < ssa->vars_count; j++) {
199
0
      if (ssa->vars[j].definition >= 0) {
200
0
        ssa->vars[j].definition -= shiftlist[ssa->vars[j].definition];
201
0
      }
202
0
      if (ssa->vars[j].use_chain >= 0) {
203
0
        ssa->vars[j].use_chain -= shiftlist[ssa->vars[j].use_chain];
204
0
      }
205
0
    }
206
0
    for (i = 0; i < op_array->last; i++) {
207
0
      if (ssa->ops[i].op1_use_chain >= 0) {
208
0
        ssa->ops[i].op1_use_chain -= shiftlist[ssa->ops[i].op1_use_chain];
209
0
      }
210
0
      if (ssa->ops[i].op2_use_chain >= 0) {
211
0
        ssa->ops[i].op2_use_chain -= shiftlist[ssa->ops[i].op2_use_chain];
212
0
      }
213
0
      if (ssa->ops[i].res_use_chain >= 0) {
214
0
        ssa->ops[i].res_use_chain -= shiftlist[ssa->ops[i].res_use_chain];
215
0
      }
216
0
    }
217
218
    /* update branch targets */
219
0
    for (b = blocks; b < blocks_end; b++) {
220
0
      if ((b->flags & ZEND_BB_REACHABLE) && b->len != 0) {
221
0
        zend_op *opline = op_array->opcodes + b->start + b->len - 1;
222
0
        zend_optimizer_shift_jump(op_array, opline, shiftlist);
223
0
      }
224
0
    }
225
226
    /* update try/catch array */
227
0
    for (uint32_t j = 0; j < op_array->last_try_catch; j++) {
228
0
      op_array->try_catch_array[j].try_op -= shiftlist[op_array->try_catch_array[j].try_op];
229
0
      op_array->try_catch_array[j].catch_op -= shiftlist[op_array->try_catch_array[j].catch_op];
230
0
      if (op_array->try_catch_array[j].finally_op) {
231
0
        op_array->try_catch_array[j].finally_op -= shiftlist[op_array->try_catch_array[j].finally_op];
232
0
        op_array->try_catch_array[j].finally_end -= shiftlist[op_array->try_catch_array[j].finally_end];
233
0
      }
234
0
    }
235
236
    /* update call graph */
237
0
    if (func_info) {
238
0
      zend_call_info *call_info = func_info->callee_info;
239
0
      while (call_info) {
240
0
        call_info->caller_init_opline -=
241
0
          shiftlist[call_info->caller_init_opline - op_array->opcodes];
242
0
        if (call_info->caller_call_opline) {
243
0
          call_info->caller_call_opline -=
244
0
            shiftlist[call_info->caller_call_opline - op_array->opcodes];
245
0
        }
246
0
        call_info = call_info->next_callee;
247
0
      }
248
0
    }
249
250
0
    op_array->last = target;
251
0
  }
252
0
  free_alloca(shiftlist, use_heap);
253
0
}
254
255
0
static bool safe_instanceof(const zend_class_entry *ce1, const zend_class_entry *ce2) {
256
0
  if (ce1 == ce2) {
257
0
    return true;
258
0
  }
259
0
  if (!(ce1->ce_flags & ZEND_ACC_LINKED)) {
260
    /* This case could be generalized, similarly to unlinked_instanceof */
261
0
    return false;
262
0
  }
263
0
  return instanceof_function(ce1, ce2);
264
0
}
265
266
static inline bool can_elide_list_type(
267
  const zend_script *script, const zend_op_array *op_array,
268
  const zend_ssa_var_info *use_info, const zend_type type)
269
0
{
270
0
  const zend_type *single_type;
271
  /* For intersection: result==false is failure, default is success.
272
   * For union: result==true is success, default is failure. */
273
0
  bool is_intersection = ZEND_TYPE_IS_INTERSECTION(type);
274
0
  ZEND_TYPE_FOREACH(type, single_type) {
275
0
    if (ZEND_TYPE_HAS_LIST(*single_type)) {
276
0
      ZEND_ASSERT(!is_intersection);
277
0
      return can_elide_list_type(script, op_array, use_info, *single_type);
278
0
    }
279
0
    if (ZEND_TYPE_HAS_NAME(*single_type)) {
280
0
      zend_string *lcname = zend_string_tolower(ZEND_TYPE_NAME(*single_type));
281
0
      const zend_class_entry *ce = zend_optimizer_get_class_entry(script, op_array, lcname);
282
0
      zend_string_release(lcname);
283
0
      bool result = ce && safe_instanceof(use_info->ce, ce);
284
0
      if (result == !is_intersection) {
285
0
        return result;
286
0
      }
287
0
    }
288
0
  } ZEND_TYPE_FOREACH_END();
289
0
  return is_intersection;
290
0
}
291
292
static inline bool can_elide_return_type_check(
293
0
    const zend_script *script, zend_op_array *op_array, zend_ssa *ssa, zend_ssa_op *ssa_op) {
294
0
  zend_arg_info *arg_info = &op_array->arg_info[-1];
295
0
  zend_ssa_var_info *use_info = &ssa->var_info[ssa_op->op1_use];
296
0
  uint32_t use_type = use_info->type & (MAY_BE_ANY|MAY_BE_UNDEF);
297
0
  if (use_type & MAY_BE_REF) {
298
0
    return false;
299
0
  }
300
301
0
  if (use_type & MAY_BE_UNDEF) {
302
0
    use_type &= ~MAY_BE_UNDEF;
303
0
    use_type |= MAY_BE_NULL;
304
0
  }
305
306
0
  uint32_t disallowed_types = use_type & ~ZEND_TYPE_PURE_MASK(arg_info->type);
307
0
  if (!disallowed_types) {
308
    /* Only contains allowed types. */
309
0
    return true;
310
0
  }
311
312
0
  if (disallowed_types == MAY_BE_OBJECT && use_info->ce && ZEND_TYPE_IS_COMPLEX(arg_info->type)) {
313
0
    return can_elide_list_type(script, op_array, use_info, arg_info->type);
314
0
  }
315
316
0
  return false;
317
0
}
318
319
static bool opline_supports_assign_contraction(
320
0
    zend_op_array *op_array, zend_ssa *ssa, zend_op *opline, int src_var, uint32_t cv_var) {
321
0
  if (opline->opcode == ZEND_NEW) {
322
    /* see Zend/tests/generators/aborted_yield_during_new.phpt */
323
0
    return false;
324
0
  }
325
326
  /* Frameless calls override the return value, but the return value may overlap with the arguments. */
327
0
  switch (opline->opcode) {
328
0
    case ZEND_FRAMELESS_ICALL_3:
329
0
      if ((opline + 1)->op1_type == IS_CV && (opline + 1)->op1.var == cv_var) return false;
330
0
      ZEND_FALLTHROUGH;
331
0
    case ZEND_FRAMELESS_ICALL_2:
332
0
      if (opline->op2_type == IS_CV && opline->op2.var == cv_var) return false;
333
0
      ZEND_FALLTHROUGH;
334
0
    case ZEND_FRAMELESS_ICALL_1:
335
0
      if (opline->op1_type == IS_CV && opline->op1.var == cv_var) return false;
336
0
      return true;
337
0
  }
338
339
0
  if (opline->opcode == ZEND_DO_ICALL || opline->opcode == ZEND_DO_UCALL
340
0
      || opline->opcode == ZEND_DO_FCALL || opline->opcode == ZEND_DO_FCALL_BY_NAME) {
341
    /* Function calls may dtor the return value after it has already been written -- allow
342
     * direct assignment only for types where a double-dtor does not matter. */
343
0
    uint32_t type = ssa->var_info[src_var].type;
344
0
    uint32_t simple = MAY_BE_NULL|MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_LONG|MAY_BE_DOUBLE;
345
0
    return !((type & MAY_BE_ANY) & ~simple);
346
0
  }
347
348
0
  if (opline->opcode == ZEND_POST_INC || opline->opcode == ZEND_POST_DEC) {
349
    /* POST_INC/DEC write the result variable before performing the inc/dec. For $i = $i++
350
     * eliding the temporary variable would thus yield an incorrect result. */
351
0
    return opline->op1_type != IS_CV || opline->op1.var != cv_var;
352
0
  }
353
354
0
  if (opline->opcode == ZEND_INIT_ARRAY) {
355
    /* INIT_ARRAY initializes the result array before reading key/value. */
356
0
    return (opline->op1_type != IS_CV || opline->op1.var != cv_var)
357
0
      && (opline->op2_type != IS_CV || opline->op2.var != cv_var);
358
0
  }
359
360
0
  if (opline->opcode == ZEND_CAST
361
0
      && (opline->extended_value == IS_ARRAY || opline->extended_value == IS_OBJECT)) {
362
    /* CAST to array/object may initialize the result to an empty array/object before
363
     * reading the expression. */
364
0
    return opline->op1_type != IS_CV || opline->op1.var != cv_var;
365
0
  }
366
367
0
  if ((opline->opcode == ZEND_ASSIGN_OP
368
0
    || opline->opcode == ZEND_ASSIGN_OBJ
369
0
    || opline->opcode == ZEND_ASSIGN_DIM
370
0
    || opline->opcode == ZEND_ASSIGN_OBJ_OP
371
0
    || opline->opcode == ZEND_ASSIGN_DIM_OP)
372
0
   && opline->op1_type == IS_CV
373
0
   && opline->op1.var == cv_var
374
0
   && zend_may_throw(opline, &ssa->ops[ssa->vars[src_var].definition], op_array, ssa)) {
375
0
    return false;
376
0
  }
377
378
0
  return true;
379
0
}
380
381
static bool variable_defined_or_used_in_range(zend_ssa *ssa, int var, int start, int end)
382
0
{
383
0
  while (start < end) {
384
0
    const zend_ssa_op *ssa_op = &ssa->ops[start];
385
0
    if ((ssa_op->op1_def >= 0 && ssa->vars[ssa_op->op1_def].var == var) ||
386
0
      (ssa_op->op2_def >= 0 && ssa->vars[ssa_op->op2_def].var == var) ||
387
0
      (ssa_op->result_def >= 0 && ssa->vars[ssa_op->result_def].var == var) ||
388
0
      (ssa_op->op1_use >= 0 && ssa->vars[ssa_op->op1_use].var == var) ||
389
0
      (ssa_op->op2_use >= 0 && ssa->vars[ssa_op->op2_use].var == var) ||
390
0
      (ssa_op->result_use >= 0 && ssa->vars[ssa_op->result_use].var == var)
391
0
    ) {
392
0
      return true;
393
0
    }
394
0
    start++;
395
0
  }
396
0
  return false;
397
0
}
398
399
static uint32_t zend_dfa_optimize_calls(zend_op_array *op_array, zend_ssa *ssa)
400
1
{
401
1
  const zend_func_info *func_info = ZEND_FUNC_INFO(op_array);
402
1
  uint32_t removed_ops = 0;
403
404
1
  if (func_info->callee_info) {
405
0
    const zend_call_info *call_info = func_info->callee_info;
406
407
0
    do {
408
0
      zend_op *op = call_info->caller_init_opline;
409
410
0
      if ((op->opcode == ZEND_FRAMELESS_ICALL_2
411
0
        || (op->opcode == ZEND_FRAMELESS_ICALL_3 && (op + 1)->op1_type == IS_CONST))
412
0
       && call_info->callee_func
413
0
       && zend_string_equals_literal_ci(call_info->callee_func->common.function_name, "in_array")) {
414
0
        bool strict = false;
415
0
        bool has_opdata = op->opcode == ZEND_FRAMELESS_ICALL_3;
416
0
        ZEND_ASSERT(!call_info->is_prototype);
417
418
0
        if (has_opdata) {
419
0
          if (zend_is_true(CT_CONSTANT_EX(op_array, (op + 1)->op1.constant))) {
420
0
            strict = true;
421
0
          }
422
0
        }
423
424
0
        if (op->op2_type == IS_CONST
425
0
         && Z_TYPE_P(CT_CONSTANT_EX(op_array, op->op2.constant)) == IS_ARRAY) {
426
0
          bool ok = true;
427
428
0
          const HashTable *src = Z_ARRVAL_P(CT_CONSTANT_EX(op_array, op->op2.constant));
429
0
          HashTable *dst;
430
0
          zval *val, tmp;
431
0
          zend_ulong idx;
432
433
0
          ZVAL_TRUE(&tmp);
434
0
          dst = zend_new_array(zend_hash_num_elements(src));
435
0
          if (strict) {
436
0
            ZEND_HASH_FOREACH_VAL(src, val) {
437
0
              if (Z_TYPE_P(val) == IS_STRING) {
438
0
                zend_hash_add(dst, Z_STR_P(val), &tmp);
439
0
              } else if (Z_TYPE_P(val) == IS_LONG) {
440
0
                zend_hash_index_add(dst, Z_LVAL_P(val), &tmp);
441
0
              } else {
442
0
                zend_array_destroy(dst);
443
0
                ok = false;
444
0
                break;
445
0
              }
446
0
            } ZEND_HASH_FOREACH_END();
447
0
          } else {
448
0
            ZEND_HASH_FOREACH_VAL(src, val) {
449
0
              if (Z_TYPE_P(val) != IS_STRING || ZEND_HANDLE_NUMERIC(Z_STR_P(val), idx)) {
450
0
                zend_array_destroy(dst);
451
0
                ok = false;
452
0
                break;
453
0
              }
454
0
              zend_hash_add(dst, Z_STR_P(val), &tmp);
455
0
            } ZEND_HASH_FOREACH_END();
456
0
          }
457
458
0
          if (ok) {
459
0
            ZVAL_ARR(&tmp, dst);
460
461
            /* Update opcode */
462
0
            op->opcode = ZEND_IN_ARRAY;
463
0
            op->extended_value = strict;
464
0
            op->op2.constant = zend_optimizer_add_literal(op_array, &tmp);
465
0
            if (has_opdata) {
466
0
              MAKE_NOP(op + 1);
467
0
              removed_ops++;
468
0
            }
469
0
          }
470
0
        }
471
0
      }
472
0
      call_info = call_info->next_callee;
473
0
    } while (call_info);
474
0
  }
475
476
1
  return removed_ops;
477
1
}
478
479
static zend_always_inline void take_successor_0(zend_ssa *ssa, uint32_t block_num, zend_basic_block *block)
480
0
{
481
0
  if (block->successors_count == 2) {
482
0
    if (block->successors[1] != block->successors[0]) {
483
0
      zend_ssa_remove_predecessor(ssa, block_num, block->successors[1]);
484
0
    }
485
0
    block->successors_count = 1;
486
0
  }
487
0
}
488
489
static zend_always_inline void take_successor_1(zend_ssa *ssa, uint32_t block_num, zend_basic_block *block)
490
0
{
491
0
  if (block->successors_count == 2) {
492
0
    if (block->successors[1] != block->successors[0]) {
493
0
      zend_ssa_remove_predecessor(ssa, block_num, block->successors[0]);
494
0
      block->successors[0] = block->successors[1];
495
0
    }
496
0
    block->successors_count = 1;
497
0
  }
498
0
}
499
500
static zend_always_inline void take_successor_ex(zend_ssa *ssa, uint32_t block_num, zend_basic_block *block, int target_block)
501
0
{
502
0
  for (uint32_t i = 0; i < block->successors_count; i++) {
503
0
    if (block->successors[i] != target_block) {
504
0
      zend_ssa_remove_predecessor(ssa, block_num, block->successors[i]);
505
0
    }
506
0
  }
507
0
  block->successors[0] = target_block;
508
0
  block->successors_count = 1;
509
0
}
510
511
static void compress_block(zend_op_array *op_array, zend_basic_block *block)
512
0
{
513
0
  while (block->len > 0) {
514
0
    zend_op *opline = &op_array->opcodes[block->start + block->len - 1];
515
516
0
    if (opline->opcode == ZEND_NOP) {
517
0
      block->len--;
518
0
    } else {
519
0
      break;
520
0
    }
521
0
  }
522
0
}
523
524
0
static void replace_predecessor(zend_ssa *ssa, int block_id, int old_pred, int new_pred) {
525
0
  zend_basic_block *block = &ssa->cfg.blocks[block_id];
526
0
  int *predecessors = &ssa->cfg.predecessors[block->predecessor_offset];
527
0
  zend_ssa_phi *phi;
528
529
0
  int old_pred_idx = -1;
530
0
  int new_pred_idx = -1;
531
0
  for (uint32_t i = 0; i < block->predecessors_count; i++) {
532
0
    if (predecessors[i] == old_pred) {
533
0
      old_pred_idx = i;
534
0
    }
535
0
    if (predecessors[i] == new_pred) {
536
0
      new_pred_idx = i;
537
0
    }
538
0
  }
539
540
0
  ZEND_ASSERT(old_pred_idx != -1);
541
0
  if (new_pred_idx == -1) {
542
    /* If the new predecessor doesn't exist yet, simply rewire the old one */
543
0
    predecessors[old_pred_idx] = new_pred;
544
0
  } else {
545
    /* Otherwise, rewiring the old predecessor would make the new predecessor appear
546
     * twice, which violates our CFG invariants. Remove the old predecessor instead. */
547
0
    memmove(
548
0
      predecessors + old_pred_idx,
549
0
      predecessors + old_pred_idx + 1,
550
0
      sizeof(int) * (block->predecessors_count - old_pred_idx - 1)
551
0
    );
552
553
    /* Also remove the corresponding phi node entries */
554
0
    for (phi = ssa->blocks[block_id].phis; phi; phi = phi->next) {
555
0
      if (phi->pi >= 0) {
556
0
        if (phi->pi == old_pred || phi->pi == new_pred) {
557
0
          zend_ssa_rename_var_uses(
558
0
            ssa, phi->ssa_var, phi->sources[0], /* update_types */ 0);
559
0
          zend_ssa_remove_phi(ssa, phi);
560
0
        }
561
0
      } else {
562
0
        memmove(
563
0
          phi->sources + old_pred_idx,
564
0
          phi->sources + old_pred_idx + 1,
565
0
          sizeof(int) * (block->predecessors_count - old_pred_idx - 1)
566
0
        );
567
0
      }
568
0
    }
569
570
0
    block->predecessors_count--;
571
0
  }
572
0
}
573
574
static void zend_ssa_replace_control_link(zend_op_array *op_array, zend_ssa *ssa, int from, int to, int new_to)
575
0
{
576
0
  zend_basic_block *src = &ssa->cfg.blocks[from];
577
0
  zend_basic_block *old = &ssa->cfg.blocks[to];
578
0
  zend_basic_block *dst = &ssa->cfg.blocks[new_to];
579
0
  zend_op *opline;
580
581
0
  for (uint32_t i = 0; i < src->successors_count; i++) {
582
0
    if (src->successors[i] == to) {
583
0
      src->successors[i] = new_to;
584
0
    }
585
0
  }
586
587
0
  if (src->len > 0) {
588
0
    opline = op_array->opcodes + src->start + src->len - 1;
589
0
    switch (opline->opcode) {
590
0
      case ZEND_JMP:
591
0
      case ZEND_FAST_CALL:
592
0
        ZEND_ASSERT(ZEND_OP1_JMP_ADDR(opline) == op_array->opcodes + old->start);
593
0
        ZEND_SET_OP_JMP_ADDR(opline, opline->op1, op_array->opcodes + dst->start);
594
0
        break;
595
0
      case ZEND_JMPZ:
596
0
      case ZEND_JMPNZ:
597
0
      case ZEND_JMPZ_EX:
598
0
      case ZEND_JMPNZ_EX:
599
0
      case ZEND_FE_RESET_R:
600
0
      case ZEND_FE_RESET_RW:
601
0
      case ZEND_JMP_SET:
602
0
      case ZEND_COALESCE:
603
0
      case ZEND_ASSERT_CHECK:
604
0
      case ZEND_JMP_NULL:
605
0
      case ZEND_BIND_INIT_STATIC_OR_JMP:
606
0
      case ZEND_JMP_FRAMELESS:
607
0
        if (ZEND_OP2_JMP_ADDR(opline) == op_array->opcodes + old->start) {
608
0
          ZEND_SET_OP_JMP_ADDR(opline, opline->op2, op_array->opcodes + dst->start);
609
0
        }
610
0
        break;
611
0
      case ZEND_CATCH:
612
0
        if (!(opline->extended_value & ZEND_LAST_CATCH)) {
613
0
          if (ZEND_OP2_JMP_ADDR(opline) == op_array->opcodes + old->start) {
614
0
            ZEND_SET_OP_JMP_ADDR(opline, opline->op2, op_array->opcodes + dst->start);
615
0
          }
616
0
        }
617
0
        break;
618
0
      case ZEND_FE_FETCH_R:
619
0
      case ZEND_FE_FETCH_RW:
620
0
        if (ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value) == old->start) {
621
0
          opline->extended_value = ZEND_OPLINE_NUM_TO_OFFSET(op_array, opline, dst->start);
622
0
        }
623
0
        break;
624
0
      case ZEND_SWITCH_LONG:
625
0
      case ZEND_SWITCH_STRING:
626
0
      case ZEND_MATCH:
627
0
        {
628
0
          HashTable *jumptable = Z_ARRVAL(ZEND_OP2_LITERAL(opline));
629
0
          zval *zv;
630
0
          ZEND_HASH_FOREACH_VAL(jumptable, zv) {
631
0
            if (ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, Z_LVAL_P(zv)) == old->start) {
632
0
              Z_LVAL_P(zv) = ZEND_OPLINE_NUM_TO_OFFSET(op_array, opline, dst->start);
633
0
            }
634
0
          } ZEND_HASH_FOREACH_END();
635
0
          if (ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value) == old->start) {
636
0
            opline->extended_value = ZEND_OPLINE_NUM_TO_OFFSET(op_array, opline, dst->start);
637
0
          }
638
0
          break;
639
0
        }
640
0
    }
641
0
  }
642
643
0
  replace_predecessor(ssa, new_to, to, from);
644
0
}
645
646
static void zend_ssa_unlink_block(zend_op_array *op_array, zend_ssa *ssa, zend_basic_block *block, uint32_t block_num)
647
0
{
648
0
  if (block->predecessors_count == 1 && ssa->blocks[block_num].phis == NULL) {
649
0
    int *predecessors;
650
0
    zend_basic_block *fe_fetch_block = NULL;
651
652
0
    ZEND_ASSERT(block->successors_count == 1);
653
0
    predecessors = &ssa->cfg.predecessors[block->predecessor_offset];
654
0
    if (block->predecessors_count == 1 && (block->flags & ZEND_BB_FOLLOW)) {
655
0
      zend_basic_block *pred_block = &ssa->cfg.blocks[predecessors[0]];
656
657
0
      if (pred_block->len > 0 && (pred_block->flags & ZEND_BB_REACHABLE)) {
658
0
        if ((op_array->opcodes[pred_block->start + pred_block->len - 1].opcode == ZEND_FE_FETCH_R
659
0
         || op_array->opcodes[pred_block->start + pred_block->len - 1].opcode == ZEND_FE_FETCH_RW)
660
0
          && op_array->opcodes[pred_block->start + pred_block->len - 1].op2_type == IS_CV) {
661
0
          fe_fetch_block = pred_block;
662
0
          }
663
0
      }
664
0
    }
665
0
    for (uint32_t i = 0; i < block->predecessors_count; i++) {
666
0
      zend_ssa_replace_control_link(op_array, ssa, predecessors[i], block_num, block->successors[0]);
667
0
    }
668
0
    zend_ssa_remove_block(op_array, ssa, block_num);
669
0
    if (fe_fetch_block && fe_fetch_block->successors[0] == fe_fetch_block->successors[1]) {
670
      /* The body of "foreach" loop was removed */
671
0
      int ssa_var = ssa->ops[fe_fetch_block->start + fe_fetch_block->len - 1].op2_def;
672
0
      if (ssa_var >= 0) {
673
0
        zend_ssa_remove_uses_of_var(ssa, ssa_var);
674
0
      }
675
0
    }
676
0
  }
677
0
}
678
679
static int zend_dfa_optimize_jmps(zend_op_array *op_array, zend_ssa *ssa)
680
2
{
681
2
  int removed_ops = 0;
682
2
  uint32_t block_num = 0;
683
684
2
  for (block_num = 1; block_num < ssa->cfg.blocks_count; block_num++) {
685
0
    zend_basic_block *block = &ssa->cfg.blocks[block_num];
686
687
0
    if (!(block->flags & ZEND_BB_REACHABLE)) {
688
0
      continue;
689
0
    }
690
0
    compress_block(op_array, block);
691
0
    if (block->len == 0) {
692
0
      zend_ssa_unlink_block(op_array, ssa, block, block_num);
693
0
    }
694
0
  }
695
696
2
  block_num = 0;
697
2
  while (block_num < ssa->cfg.blocks_count
698
2
    && !(ssa->cfg.blocks[block_num].flags & ZEND_BB_REACHABLE)) {
699
0
    block_num++;
700
0
  }
701
4
  while (block_num < ssa->cfg.blocks_count) {
702
2
    uint32_t next_block_num = block_num + 1;
703
2
    zend_basic_block *block = &ssa->cfg.blocks[block_num];
704
2
    uint32_t op_num;
705
2
    zend_op *opline;
706
2
    zend_ssa_op *ssa_op;
707
2
    bool can_follow = true;
708
709
2
    while (next_block_num < ssa->cfg.blocks_count
710
0
      && !(ssa->cfg.blocks[next_block_num].flags & ZEND_BB_REACHABLE)) {
711
0
      if (ssa->cfg.blocks[next_block_num].flags & ZEND_BB_UNREACHABLE_FREE) {
712
0
        can_follow = false;
713
0
      }
714
0
      next_block_num++;
715
0
    }
716
717
2
    if (block->len) {
718
2
      op_num = block->start + block->len - 1;
719
2
      opline = op_array->opcodes + op_num;
720
2
      ssa_op = ssa->ops + op_num;
721
722
2
      switch (opline->opcode) {
723
0
        case ZEND_JMP:
724
0
optimize_jmp:
725
0
          if (block->successors[0] == next_block_num && can_follow) {
726
0
            MAKE_NOP(opline);
727
0
            removed_ops++;
728
0
            goto optimize_nop;
729
0
          }
730
0
          break;
731
0
        case ZEND_JMPZ:
732
0
optimize_jmpz:
733
0
          if (opline->op1_type == IS_CONST) {
734
0
            if (zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
735
0
              MAKE_NOP(opline);
736
0
              removed_ops++;
737
0
              take_successor_1(ssa, block_num, block);
738
0
              goto optimize_nop;
739
0
            } else {
740
0
              opline->opcode = ZEND_JMP;
741
0
              COPY_NODE(opline->op1, opline->op2);
742
0
              take_successor_0(ssa, block_num, block);
743
0
              goto optimize_jmp;
744
0
            }
745
0
          } else {
746
0
            if (block->successors[0] == next_block_num && can_follow) {
747
0
              take_successor_0(ssa, block_num, block);
748
0
              if (opline->op1_type == IS_CV && (OP1_INFO() & MAY_BE_UNDEF)) {
749
0
                opline->opcode = ZEND_CHECK_VAR;
750
0
                opline->op2.num = 0;
751
0
              } else if (opline->op1_type == IS_CV || !(OP1_INFO() & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
752
0
                zend_ssa_remove_instr(ssa, opline, ssa_op);
753
0
                removed_ops++;
754
0
                goto optimize_nop;
755
0
              } else {
756
0
                opline->opcode = ZEND_FREE;
757
0
                opline->op2.num = 0;
758
0
              }
759
0
            }
760
0
          }
761
0
          break;
762
0
        case ZEND_JMPNZ:
763
0
optimize_jmpnz:
764
0
          if (opline->op1_type == IS_CONST) {
765
0
            if (zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
766
0
              opline->opcode = ZEND_JMP;
767
0
              COPY_NODE(opline->op1, opline->op2);
768
0
              take_successor_0(ssa, block_num, block);
769
0
              goto optimize_jmp;
770
0
            } else {
771
0
              MAKE_NOP(opline);
772
0
              removed_ops++;
773
0
              take_successor_1(ssa, block_num, block);
774
0
              goto optimize_nop;
775
0
            }
776
0
          } else if (block->successors_count == 2) {
777
0
            if (block->successors[0] == next_block_num && can_follow) {
778
0
              take_successor_0(ssa, block_num, block);
779
0
              if (opline->op1_type == IS_CV && (OP1_INFO() & MAY_BE_UNDEF)) {
780
0
                opline->opcode = ZEND_CHECK_VAR;
781
0
                opline->op2.num = 0;
782
0
              } else if (opline->op1_type == IS_CV || !(OP1_INFO() & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
783
0
                zend_ssa_remove_instr(ssa, opline, ssa_op);
784
0
                removed_ops++;
785
0
                goto optimize_nop;
786
0
              } else {
787
0
                opline->opcode = ZEND_FREE;
788
0
                opline->op2.num = 0;
789
0
              }
790
0
            }
791
0
          }
792
0
          break;
793
0
        case ZEND_JMPZ_EX:
794
0
          if (ssa->vars[ssa_op->result_def].use_chain < 0
795
0
              && ssa->vars[ssa_op->result_def].phi_use_chain == NULL) {
796
0
            opline->opcode = ZEND_JMPZ;
797
0
            opline->result_type = IS_UNUSED;
798
0
            zend_ssa_remove_result_def(ssa, ssa_op);
799
0
            goto optimize_jmpz;
800
0
          } else if (opline->op1_type == IS_CONST) {
801
0
            if (zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
802
0
              opline->opcode = ZEND_BOOL;
803
0
              take_successor_1(ssa, block_num, block);
804
0
            }
805
0
          }
806
0
          break;
807
0
        case ZEND_JMPNZ_EX:
808
0
          if (ssa->vars[ssa_op->result_def].use_chain < 0
809
0
              && ssa->vars[ssa_op->result_def].phi_use_chain == NULL) {
810
0
            opline->opcode = ZEND_JMPNZ;
811
0
            opline->result_type = IS_UNUSED;
812
0
            zend_ssa_remove_result_def(ssa, ssa_op);
813
0
            goto optimize_jmpnz;
814
0
          } else if (opline->op1_type == IS_CONST) {
815
0
            if (!zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
816
0
              opline->opcode = ZEND_BOOL;
817
0
              take_successor_1(ssa, block_num, block);
818
0
            }
819
0
          }
820
0
          break;
821
0
        case ZEND_JMP_SET:
822
0
          if (ssa->vars[ssa_op->result_def].use_chain < 0
823
0
              && ssa->vars[ssa_op->result_def].phi_use_chain == NULL) {
824
0
            opline->opcode = ZEND_JMPNZ;
825
0
            opline->result_type = IS_UNUSED;
826
0
            zend_ssa_remove_result_def(ssa, ssa_op);
827
0
            goto optimize_jmpnz;
828
0
          } else if (opline->op1_type == IS_CONST) {
829
0
            if (!zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
830
0
              MAKE_NOP(opline);
831
0
              removed_ops++;
832
0
              take_successor_1(ssa, block_num, block);
833
0
              zend_ssa_remove_result_def(ssa, ssa_op);
834
0
              goto optimize_nop;
835
0
            }
836
0
          }
837
0
          break;
838
0
        case ZEND_COALESCE:
839
0
        {
840
0
          zend_ssa_var *var = &ssa->vars[ssa_op->result_def];
841
0
          if (opline->op1_type == IS_CONST
842
0
              && var->use_chain < 0 && var->phi_use_chain == NULL) {
843
0
            if (Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op1.constant)) == IS_NULL) {
844
0
              zend_ssa_remove_result_def(ssa, ssa_op);
845
0
              MAKE_NOP(opline);
846
0
              removed_ops++;
847
0
              take_successor_1(ssa, block_num, block);
848
0
              goto optimize_nop;
849
0
            } else {
850
0
              opline->opcode = ZEND_JMP;
851
0
              opline->result_type = IS_UNUSED;
852
0
              zend_ssa_remove_result_def(ssa, ssa_op);
853
0
              COPY_NODE(opline->op1, opline->op2);
854
0
              take_successor_0(ssa, block_num, block);
855
0
              goto optimize_jmp;
856
0
            }
857
0
          }
858
0
          break;
859
0
        }
860
0
        case ZEND_JMP_NULL:
861
0
        {
862
0
          zend_ssa_var *var = &ssa->vars[ssa_op->result_def];
863
0
          if (opline->op1_type == IS_CONST
864
0
              && var->use_chain < 0 && var->phi_use_chain == NULL) {
865
0
            if (Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op1.constant)) == IS_NULL) {
866
0
              opline->opcode = ZEND_JMP;
867
0
              opline->result_type = IS_UNUSED;
868
0
              zend_ssa_remove_result_def(ssa, ssa_op);
869
0
              COPY_NODE(opline->op1, opline->op2);
870
0
              take_successor_0(ssa, block_num, block);
871
0
              goto optimize_jmp;
872
0
            } else {
873
0
              zend_ssa_remove_result_def(ssa, ssa_op);
874
0
              MAKE_NOP(opline);
875
0
              removed_ops++;
876
0
              take_successor_1(ssa, block_num, block);
877
0
              goto optimize_nop;
878
0
            }
879
0
          }
880
0
          break;
881
0
        }
882
0
        case ZEND_SWITCH_LONG:
883
0
        case ZEND_SWITCH_STRING:
884
0
        case ZEND_MATCH:
885
0
          if (opline->op1_type == IS_CONST) {
886
0
            zval *zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
887
0
            uint8_t type = Z_TYPE_P(zv);
888
0
            bool correct_type =
889
0
              (opline->opcode == ZEND_SWITCH_LONG && type == IS_LONG)
890
0
              || (opline->opcode == ZEND_SWITCH_STRING && type == IS_STRING)
891
0
              || (opline->opcode == ZEND_MATCH && (type == IS_LONG || type == IS_STRING));
892
893
            /* Switch statements have a fallback chain for loose comparison. In those
894
             * cases the SWITCH_* instruction is a NOP. Match does strict comparison and
895
             * thus jumps to the default branch on mismatched types, so we need to
896
             * convert MATCH to a jmp. */
897
0
            if (!correct_type && opline->opcode != ZEND_MATCH) {
898
0
              removed_ops++;
899
0
              MAKE_NOP(opline);
900
0
              opline->extended_value = 0;
901
0
              take_successor_ex(ssa, block_num, block, block->successors[block->successors_count - 1]);
902
0
              goto optimize_nop;
903
0
            }
904
905
0
            uint32_t target;
906
0
            if (correct_type) {
907
0
              HashTable *jmptable = Z_ARRVAL_P(CT_CONSTANT_EX(op_array, opline->op2.constant));
908
0
              zval *jmp_zv = type == IS_LONG
909
0
                ? zend_hash_index_find(jmptable, Z_LVAL_P(zv))
910
0
                : zend_hash_find(jmptable, Z_STR_P(zv));
911
912
0
              if (jmp_zv) {
913
0
                target = ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, Z_LVAL_P(jmp_zv));
914
0
              } else {
915
0
                target = ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value);
916
0
              }
917
0
            } else {
918
0
              ZEND_ASSERT(opline->opcode == ZEND_MATCH);
919
0
              target = ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value);
920
0
            }
921
0
            opline->opcode = ZEND_JMP;
922
0
            opline->extended_value = 0;
923
0
            SET_UNUSED(opline->op1);
924
0
            ZEND_SET_OP_JMP_ADDR(opline, opline->op1, op_array->opcodes + target);
925
0
            SET_UNUSED(opline->op2);
926
0
            take_successor_ex(ssa, block_num, block, ssa->cfg.map[target]);
927
0
            goto optimize_jmp;
928
0
          }
929
0
          break;
930
0
        case ZEND_NOP:
931
0
optimize_nop:
932
0
          compress_block(op_array, block);
933
0
          if (block->len == 0) {
934
0
            if (block_num > 0) {
935
0
              zend_ssa_unlink_block(op_array, ssa, block, block_num);
936
              /* backtrack to previous basic block */
937
0
              int backtracking_block_num = block_num;
938
0
              do {
939
0
                backtracking_block_num--;
940
0
              } while (backtracking_block_num >= 0
941
0
                && !(ssa->cfg.blocks[backtracking_block_num].flags & ZEND_BB_REACHABLE));
942
0
              if (backtracking_block_num >= 0) {
943
0
                block_num = backtracking_block_num;
944
0
                continue;
945
0
              }
946
0
            }
947
0
          }
948
0
          break;
949
2
        default:
950
2
          break;
951
2
      }
952
2
    }
953
954
2
    block_num = next_block_num;
955
2
  }
956
957
2
  return removed_ops;
958
2
}
959
960
static bool zend_dfa_try_to_replace_result(zend_op_array *op_array, zend_ssa *ssa, int def, int cv_var)
961
0
{
962
0
  int result_var = ssa->ops[def].result_def;
963
0
  uint32_t cv = EX_NUM_TO_VAR(ssa->vars[cv_var].var);
964
965
0
  if (result_var >= 0
966
0
   && !(ssa->var_info[cv_var].type & MAY_BE_REF)
967
0
   && ssa->vars[cv_var].alias == NO_ALIAS
968
0
   && ssa->vars[result_var].phi_use_chain == NULL
969
0
   && ssa->vars[result_var].sym_use_chain == NULL) {
970
0
    int use = ssa->vars[result_var].use_chain;
971
972
0
    if (use >= 0
973
0
     && zend_ssa_next_use(ssa->ops, result_var, use) < 0
974
0
     && op_array->opcodes[use].opcode != ZEND_FREE
975
0
     && op_array->opcodes[use].opcode != ZEND_SEND_VAL
976
0
     && op_array->opcodes[use].opcode != ZEND_SEND_VAL_EX
977
0
     && op_array->opcodes[use].opcode != ZEND_VERIFY_RETURN_TYPE
978
0
     && op_array->opcodes[use].opcode != ZEND_YIELD) {
979
0
      if (use > def) {
980
0
        int i = use;
981
0
        const zend_op *opline = &op_array->opcodes[use];
982
983
0
        while (i > def) {
984
0
          if ((opline->op1_type == IS_CV && opline->op1.var == cv)
985
0
           || (opline->op2_type == IS_CV && opline->op2.var == cv)
986
0
           || (opline->result_type == IS_CV && opline->result.var == cv)) {
987
0
            return false;
988
0
          }
989
0
          opline--;
990
0
          i--;
991
0
        }
992
993
        /* Update opcodes and reconstruct SSA */
994
0
        ssa->vars[result_var].definition = -1;
995
0
        ssa->vars[result_var].use_chain = -1;
996
0
        ssa->ops[def].result_def = -1;
997
998
0
        op_array->opcodes[def].result_type = IS_UNUSED;
999
0
        op_array->opcodes[def].result.var = 0;
1000
1001
0
        if (ssa->ops[use].op1_use == result_var) {
1002
0
          ssa->ops[use].op1_use = cv_var;
1003
0
          ssa->ops[use].op1_use_chain = ssa->vars[cv_var].use_chain;
1004
0
          ssa->vars[cv_var].use_chain = use;
1005
1006
0
          op_array->opcodes[use].op1_type = IS_CV;
1007
0
          op_array->opcodes[use].op1.var = cv;
1008
0
        } else if (ssa->ops[use].op2_use == result_var) {
1009
0
          ssa->ops[use].op2_use = cv_var;
1010
0
          ssa->ops[use].op2_use_chain = ssa->vars[cv_var].use_chain;
1011
0
          ssa->vars[cv_var].use_chain = use;
1012
1013
0
          op_array->opcodes[use].op2_type = IS_CV;
1014
0
          op_array->opcodes[use].op2.var = cv;
1015
0
        } else if (ssa->ops[use].result_use == result_var) {
1016
0
          ssa->ops[use].result_use = cv_var;
1017
0
          ssa->ops[use].res_use_chain = ssa->vars[cv_var].use_chain;
1018
0
          ssa->vars[cv_var].use_chain = use;
1019
1020
0
          op_array->opcodes[use].result_type = IS_CV;
1021
0
          op_array->opcodes[use].result.var = cv;
1022
0
        }
1023
1024
0
        return true;
1025
0
      }
1026
0
    }
1027
0
  }
1028
1029
0
  return false;
1030
0
}
1031
1032
void zend_dfa_optimize_op_array(zend_op_array *op_array, zend_optimizer_ctx *ctx, zend_ssa *ssa, zend_call_info **call_map)
1033
1
{
1034
1
  if (ctx->debug_level & ZEND_DUMP_BEFORE_DFA_PASS) {
1035
0
    zend_dump_op_array(op_array, ZEND_DUMP_SSA, "before dfa pass", ssa);
1036
0
  }
1037
1038
1
  if (ssa->var_info) {
1039
1
    int op_1;
1040
1
    int v;
1041
1
    int remove_nops = 0;
1042
1
    zend_op *opline;
1043
1
    zend_ssa_op *ssa_op;
1044
1
    zval tmp;
1045
1046
1
#if ZEND_DEBUG_DFA
1047
1
    ssa_verify_integrity(op_array, ssa, "before dfa");
1048
1
#endif
1049
1050
1
    if (ZEND_OPTIMIZER_PASS_8 & ctx->optimization_level) {
1051
1
      if (sccp_optimize_op_array(ctx, op_array, ssa, call_map)) {
1052
0
        remove_nops = 1;
1053
0
      }
1054
1055
1
      if (zend_dfa_optimize_jmps(op_array, ssa)) {
1056
0
        remove_nops = 1;
1057
0
      }
1058
1059
1
#if ZEND_DEBUG_DFA
1060
1
      ssa_verify_integrity(op_array, ssa, "after sccp");
1061
1
#endif
1062
1
      if (ZEND_FUNC_INFO(op_array)) {
1063
1
        if (zend_dfa_optimize_calls(op_array, ssa)) {
1064
0
          remove_nops = 1;
1065
0
        }
1066
1
      }
1067
1
      if (ctx->debug_level & ZEND_DUMP_AFTER_PASS_8) {
1068
0
        zend_dump_op_array(op_array, ZEND_DUMP_SSA, "after sccp pass", ssa);
1069
0
      }
1070
1
#if ZEND_DEBUG_DFA
1071
1
      ssa_verify_integrity(op_array, ssa, "after calls");
1072
1
#endif
1073
1
    }
1074
1075
1
    if (ZEND_OPTIMIZER_PASS_14 & ctx->optimization_level) {
1076
1
      if (dce_optimize_op_array(op_array, ctx, ssa, 0)) {
1077
0
        remove_nops = 1;
1078
0
      }
1079
1
      if (zend_dfa_optimize_jmps(op_array, ssa)) {
1080
0
        remove_nops = 1;
1081
0
      }
1082
1
      if (ctx->debug_level & ZEND_DUMP_AFTER_PASS_14) {
1083
0
        zend_dump_op_array(op_array, ZEND_DUMP_SSA, "after dce pass", ssa);
1084
0
      }
1085
1
#if ZEND_DEBUG_DFA
1086
1
      ssa_verify_integrity(op_array, ssa, "after dce");
1087
1
#endif
1088
1
    }
1089
1090
1
    for (v = op_array->last_var; v < ssa->vars_count; v++) {
1091
1092
0
      op_1 = ssa->vars[v].definition;
1093
1094
0
      if (op_1 < 0) {
1095
0
        continue;
1096
0
      }
1097
1098
0
      opline = op_array->opcodes + op_1;
1099
0
      ssa_op = &ssa->ops[op_1];
1100
1101
      /* Convert LONG constants to DOUBLE */
1102
0
      if (ssa->var_info[v].use_as_double) {
1103
0
        if (opline->opcode == ZEND_ASSIGN
1104
0
         && opline->op2_type == IS_CONST
1105
0
         && ssa->ops[op_1].op1_def == v
1106
0
         && !RETURN_VALUE_USED(opline)
1107
0
        ) {
1108
1109
// op_1: ASSIGN ? -> #v [use_as_double], long(?) => ASSIGN ? -> #v, double(?)
1110
1111
0
          zval *zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1112
0
          ZEND_ASSERT(Z_TYPE_INFO_P(zv) == IS_LONG);
1113
0
          ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1114
0
          opline->op2.constant = zend_optimizer_add_literal(op_array, &tmp);
1115
1116
0
        } else if (opline->opcode == ZEND_QM_ASSIGN
1117
0
         && opline->op1_type == IS_CONST
1118
0
        ) {
1119
1120
// op_1: QM_ASSIGN #v [use_as_double], long(?) => QM_ASSIGN #v, double(?)
1121
1122
0
          zval *zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1123
0
          ZEND_ASSERT(Z_TYPE_INFO_P(zv) == IS_LONG);
1124
0
          ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1125
0
          opline->op1.constant = zend_optimizer_add_literal(op_array, &tmp);
1126
0
        }
1127
1128
0
      } else {
1129
0
        if (opline->opcode == ZEND_ADD
1130
0
         || opline->opcode == ZEND_SUB
1131
0
         || opline->opcode == ZEND_MUL
1132
0
         || opline->opcode == ZEND_IS_EQUAL
1133
0
         || opline->opcode == ZEND_IS_NOT_EQUAL
1134
0
         || opline->opcode == ZEND_IS_SMALLER
1135
0
         || opline->opcode == ZEND_IS_SMALLER_OR_EQUAL
1136
0
        ) {
1137
1138
0
          if (opline->op1_type == IS_CONST && opline->op2_type != IS_CONST) {
1139
0
            zval *zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1140
1141
0
            if ((OP2_INFO() & MAY_BE_ANY) == MAY_BE_DOUBLE
1142
0
             && Z_TYPE_INFO_P(zv) == IS_LONG) {
1143
1144
// op_1: #v.? = ADD long(?), #?.? [double] => #v.? = ADD double(?), #?.? [double]
1145
1146
0
              ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1147
0
              opline->op1.constant = zend_optimizer_add_literal(op_array, &tmp);
1148
0
              zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1149
0
            }
1150
0
            if (opline->opcode == ZEND_ADD) {
1151
0
              zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1152
1153
0
              if (((OP2_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_LONG
1154
0
                && Z_TYPE_INFO_P(zv) == IS_LONG
1155
0
                && Z_LVAL_P(zv) == 0)
1156
0
               || ((OP2_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_DOUBLE
1157
0
                && Z_TYPE_INFO_P(zv) == IS_DOUBLE
1158
0
                && Z_DVAL_P(zv) == 0.0)) {
1159
1160
// op_1: #v.? = ADD 0, #?.? [double,long] => #v.? = QM_ASSIGN #?.?
1161
1162
0
                opline->opcode = ZEND_QM_ASSIGN;
1163
0
                opline->op1_type = opline->op2_type;
1164
0
                opline->op1.var = opline->op2.var;
1165
0
                opline->op2_type = IS_UNUSED;
1166
0
                opline->op2.num = 0;
1167
0
                ssa->ops[op_1].op1_use = ssa->ops[op_1].op2_use;
1168
0
                ssa->ops[op_1].op1_use_chain = ssa->ops[op_1].op2_use_chain;
1169
0
                ssa->ops[op_1].op2_use = -1;
1170
0
                ssa->ops[op_1].op2_use_chain = -1;
1171
0
              }
1172
0
            } else if (opline->opcode == ZEND_MUL
1173
0
             && (OP2_INFO() & ((MAY_BE_ANY|MAY_BE_UNDEF)-(MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1174
0
              zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1175
1176
0
              if ((Z_TYPE_INFO_P(zv) == IS_LONG
1177
0
                && Z_LVAL_P(zv) == 2)
1178
0
               || (Z_TYPE_INFO_P(zv) == IS_DOUBLE
1179
0
                && Z_DVAL_P(zv) == 2.0
1180
0
                && !(OP2_INFO() & MAY_BE_LONG))) {
1181
1182
// op_1: #v.? = MUL 2, #x.? [double,long] => #v.? = ADD #x.?, #x.?
1183
1184
0
                opline->opcode = ZEND_ADD;
1185
0
                opline->op1_type = opline->op2_type;
1186
0
                opline->op1.var = opline->op2.var;
1187
0
                ssa->ops[op_1].op1_use = ssa->ops[op_1].op2_use;
1188
0
                ssa->ops[op_1].op1_use_chain = ssa->ops[op_1].op2_use_chain;
1189
0
              }
1190
0
            }
1191
0
          } else if (opline->op1_type != IS_CONST && opline->op2_type == IS_CONST) {
1192
0
            zval *zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1193
1194
0
            if ((OP1_INFO() & MAY_BE_ANY) == MAY_BE_DOUBLE
1195
0
             && Z_TYPE_INFO_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == IS_LONG) {
1196
1197
// op_1: #v.? = ADD #?.? [double], long(?) => #v.? = ADD #?.? [double], double(?)
1198
1199
0
              ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1200
0
              opline->op2.constant = zend_optimizer_add_literal(op_array, &tmp);
1201
0
              zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1202
0
            }
1203
0
            if (opline->opcode == ZEND_ADD || opline->opcode == ZEND_SUB) {
1204
0
              if (((OP1_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_LONG
1205
0
                && Z_TYPE_INFO_P(zv) == IS_LONG
1206
0
                && Z_LVAL_P(zv) == 0)
1207
0
               || ((OP1_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_DOUBLE
1208
0
                && Z_TYPE_INFO_P(zv) == IS_DOUBLE
1209
0
                && Z_DVAL_P(zv) == 0.0)) {
1210
1211
// op_1: #v.? = ADD #?.? [double,long], 0 => #v.? = QM_ASSIGN #?.?
1212
1213
0
                opline->opcode = ZEND_QM_ASSIGN;
1214
0
                opline->op2_type = IS_UNUSED;
1215
0
                opline->op2.num = 0;
1216
0
              }
1217
0
            } else if (opline->opcode == ZEND_MUL
1218
0
             && (OP1_INFO() & ((MAY_BE_ANY|MAY_BE_UNDEF)-(MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1219
0
              zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1220
1221
0
              if ((Z_TYPE_INFO_P(zv) == IS_LONG
1222
0
                && Z_LVAL_P(zv) == 2)
1223
0
               || (Z_TYPE_INFO_P(zv) == IS_DOUBLE
1224
0
                && Z_DVAL_P(zv) == 2.0
1225
0
                && !(OP1_INFO() & MAY_BE_LONG))) {
1226
1227
// op_1: #v.? = MUL #x.? [double,long], 2 => #v.? = ADD #x.?, #x.?
1228
1229
0
                opline->opcode = ZEND_ADD;
1230
0
                opline->op2_type = opline->op1_type;
1231
0
                opline->op2.var = opline->op1.var;
1232
0
                ssa->ops[op_1].op2_use = ssa->ops[op_1].op1_use;
1233
0
                ssa->ops[op_1].op2_use_chain = ssa->ops[op_1].op1_use_chain;
1234
0
              }
1235
0
            }
1236
0
          }
1237
0
        } else if (opline->opcode == ZEND_CONCAT) {
1238
0
          if (!(OP1_INFO() & MAY_BE_OBJECT)
1239
0
           && !(OP2_INFO() & MAY_BE_OBJECT)) {
1240
0
            opline->opcode = ZEND_FAST_CONCAT;
1241
0
          }
1242
0
        } else if (opline->opcode == ZEND_VERIFY_RETURN_TYPE
1243
0
         && opline->op1_type != IS_CONST
1244
0
         && ssa->ops[op_1].op1_def == v
1245
0
         && ssa->ops[op_1].op1_use >= 0) {
1246
0
          int orig_var = ssa->ops[op_1].op1_use;
1247
0
          int ret = ssa->vars[v].use_chain;
1248
1249
0
          if (ssa->ops[op_1].op1_use_chain == -1
1250
0
           && can_elide_return_type_check(ctx->script, op_array, ssa, &ssa->ops[op_1])) {
1251
1252
// op_1: VERIFY_RETURN_TYPE #orig_var.? [T] -> #v.? [T] => NOP
1253
1254
0
            zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1255
1256
0
            if (ret >= 0) {
1257
0
              ssa->ops[ret].op1_use = orig_var;
1258
0
              ssa->ops[ret].op1_use_chain = ssa->vars[orig_var].use_chain;
1259
0
              ssa->vars[orig_var].use_chain = ret;
1260
0
            }
1261
1262
0
            ssa->vars[v].definition = -1;
1263
0
            ssa->vars[v].use_chain = -1;
1264
1265
0
            ssa->ops[op_1].op1_def = -1;
1266
0
            ssa->ops[op_1].op1_use = -1;
1267
1268
0
            MAKE_NOP(opline);
1269
0
            remove_nops = 1;
1270
0
          } else if (ret >= 0
1271
0
           && ssa->ops[ret].op1_use == v
1272
0
           && ssa->ops[ret].op1_use_chain == -1
1273
0
           && can_elide_return_type_check(ctx->script, op_array, ssa, &ssa->ops[op_1])) {
1274
1275
// op_1: VERIFY_RETURN_TYPE #orig_var.? [T] -> #v.? [T] => NOP
1276
1277
0
            zend_ssa_replace_use_chain(ssa, op_1, ret, orig_var);
1278
1279
0
            ssa->ops[ret].op1_use = orig_var;
1280
0
            ssa->ops[ret].op1_use_chain = ssa->ops[op_1].op1_use_chain;
1281
1282
0
            ssa->vars[v].definition = -1;
1283
0
            ssa->vars[v].use_chain = -1;
1284
1285
0
            ssa->ops[op_1].op1_def = -1;
1286
0
            ssa->ops[op_1].op1_use = -1;
1287
1288
0
            MAKE_NOP(opline);
1289
0
            remove_nops = 1;
1290
0
          }
1291
0
        }
1292
0
      }
1293
1294
0
      if (opline->opcode == ZEND_QM_ASSIGN
1295
0
       && ssa->ops[op_1].result_def == v
1296
0
       && opline->op1_type & (IS_TMP_VAR|IS_VAR)
1297
0
       && !(ssa->var_info[v].type & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
1298
0
      ) {
1299
1300
0
        int src_var = ssa->ops[op_1].op1_use;
1301
1302
0
        if (src_var >= 0
1303
0
         && !(ssa->var_info[src_var].type & MAY_BE_REF)
1304
0
         && (ssa->var_info[src_var].type & (MAY_BE_UNDEF|MAY_BE_ANY))
1305
0
         && ssa->vars[src_var].definition >= 0
1306
0
         && ssa->ops[ssa->vars[src_var].definition].result_def == src_var
1307
0
         && ssa->ops[ssa->vars[src_var].definition].result_use < 0
1308
0
         && ssa->vars[src_var].use_chain == op_1
1309
0
         && ssa->ops[op_1].op1_use_chain < 0
1310
0
         && !ssa->vars[src_var].phi_use_chain
1311
0
         && !ssa->vars[src_var].sym_use_chain
1312
0
         && opline_supports_assign_contraction(
1313
0
           op_array, ssa, &op_array->opcodes[ssa->vars[src_var].definition],
1314
0
           src_var, opline->result.var)
1315
0
         && !variable_defined_or_used_in_range(ssa, EX_VAR_TO_NUM(opline->result.var),
1316
0
            ssa->vars[src_var].definition+1, op_1)
1317
0
        ) {
1318
1319
0
          int orig_var = ssa->ops[op_1].result_use;
1320
0
          int op_2 = ssa->vars[src_var].definition;
1321
1322
// op_2: #src_var.T = OP ...                                        => #v.CV = OP ...
1323
// op_1: QM_ASSIGN #src_var.T #orig_var.CV [undef,scalar] -> #v.CV,    NOP
1324
1325
0
          if (orig_var >= 0) {
1326
0
            zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1327
0
          }
1328
1329
          /* Reconstruct SSA */
1330
0
          ssa->vars[v].definition = op_2;
1331
0
          ssa->ops[op_2].result_def = v;
1332
1333
0
          ssa->vars[src_var].definition = -1;
1334
0
          ssa->vars[src_var].use_chain = -1;
1335
1336
0
          ssa->ops[op_1].op1_use = -1;
1337
0
          ssa->ops[op_1].op1_def = -1;
1338
0
          ssa->ops[op_1].op1_use_chain = -1;
1339
0
          ssa->ops[op_1].result_use = -1;
1340
0
          ssa->ops[op_1].result_def = -1;
1341
0
          ssa->ops[op_1].res_use_chain = -1;
1342
1343
          /* Update opcodes */
1344
0
          op_array->opcodes[op_2].result_type = opline->result_type;
1345
0
          op_array->opcodes[op_2].result.var = opline->result.var;
1346
1347
0
          MAKE_NOP(opline);
1348
0
          remove_nops = 1;
1349
1350
0
          if (op_array->opcodes[op_2].opcode == ZEND_SUB
1351
0
           && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1352
0
           && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1353
0
           && op_array->opcodes[op_2].op2_type == IS_CONST
1354
0
           && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1355
0
           && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1356
0
           && ssa->ops[op_2].op1_use >= 0
1357
0
           && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1358
1359
0
            op_array->opcodes[op_2].opcode = ZEND_PRE_DEC;
1360
0
            SET_UNUSED(op_array->opcodes[op_2].op2);
1361
0
            SET_UNUSED(op_array->opcodes[op_2].result);
1362
1363
0
            ssa->ops[op_2].result_def = -1;
1364
0
            ssa->ops[op_2].op1_def = v;
1365
1366
0
          } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1367
0
           && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1368
0
           && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1369
0
           && op_array->opcodes[op_2].op2_type == IS_CONST
1370
0
           && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1371
0
           && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1372
0
           && ssa->ops[op_2].op1_use >= 0
1373
0
           && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1374
1375
0
            op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1376
0
            SET_UNUSED(op_array->opcodes[op_2].op2);
1377
0
            SET_UNUSED(op_array->opcodes[op_2].result);
1378
1379
0
            ssa->ops[op_2].result_def = -1;
1380
0
            ssa->ops[op_2].op1_def = v;
1381
1382
0
          } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1383
0
           && op_array->opcodes[op_2].op2_type == op_array->opcodes[op_2].result_type
1384
0
           && op_array->opcodes[op_2].op2.var == op_array->opcodes[op_2].result.var
1385
0
           && op_array->opcodes[op_2].op1_type == IS_CONST
1386
0
           && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == IS_LONG
1387
0
           && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == 1
1388
0
           && ssa->ops[op_2].op2_use >= 0
1389
0
           && !(ssa->var_info[ssa->ops[op_2].op2_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1390
1391
0
            op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1392
0
            op_array->opcodes[op_2].op1_type = op_array->opcodes[op_2].op2_type;
1393
0
            op_array->opcodes[op_2].op1.var = op_array->opcodes[op_2].op2.var;
1394
0
            SET_UNUSED(op_array->opcodes[op_2].op2);
1395
0
            SET_UNUSED(op_array->opcodes[op_2].result);
1396
1397
0
            ssa->ops[op_2].result_def = -1;
1398
0
            ssa->ops[op_2].op1_def = v;
1399
0
            ssa->ops[op_2].op1_use = ssa->ops[op_2].op2_use;
1400
0
            ssa->ops[op_2].op1_use_chain = ssa->ops[op_2].op2_use_chain;
1401
0
            ssa->ops[op_2].op2_use = -1;
1402
0
            ssa->ops[op_2].op2_use_chain = -1;
1403
0
          }
1404
0
        }
1405
0
      }
1406
1407
0
      if (ssa->vars[v].var >= op_array->last_var) {
1408
        /* skip TMP and VAR */
1409
0
        continue;
1410
0
      }
1411
1412
0
      if (ssa->ops[op_1].op1_def == v
1413
0
       && RETURN_VALUE_USED(opline)) {
1414
0
        if (opline->opcode == ZEND_ASSIGN
1415
0
         || opline->opcode == ZEND_ASSIGN_OP
1416
0
         || opline->opcode == ZEND_PRE_INC
1417
0
         || opline->opcode == ZEND_PRE_DEC) {
1418
0
          zend_dfa_try_to_replace_result(op_array, ssa, op_1, v);
1419
0
        } else if (opline->opcode == ZEND_POST_INC) {
1420
0
          int result_var = ssa->ops[op_1].result_def;
1421
1422
0
          if (result_var >= 0
1423
0
           && (ssa->var_info[result_var].type & ((MAY_BE_ANY|MAY_BE_REF|MAY_BE_UNDEF) - (MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1424
0
            int use = ssa->vars[result_var].use_chain;
1425
1426
0
            if (use >= 0 && op_array->opcodes[use].opcode == ZEND_IS_SMALLER
1427
0
             && ssa->ops[use].op1_use == result_var
1428
0
             && zend_dfa_try_to_replace_result(op_array, ssa, op_1, v)) {
1429
0
              opline->opcode = ZEND_PRE_INC;
1430
0
              op_array->opcodes[use].opcode = ZEND_IS_SMALLER_OR_EQUAL;
1431
0
            }
1432
0
          }
1433
0
        } else if (opline->opcode == ZEND_POST_DEC) {
1434
0
          int result_var = ssa->ops[op_1].result_def;
1435
1436
0
          if (result_var >= 0
1437
0
           && (ssa->var_info[result_var].type & ((MAY_BE_ANY|MAY_BE_REF|MAY_BE_UNDEF) - (MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1438
0
            int use = ssa->vars[result_var].use_chain;
1439
1440
0
            if (use >= 0 && op_array->opcodes[use].opcode == ZEND_IS_SMALLER
1441
0
             && ssa->ops[use].op2_use == result_var
1442
0
             && zend_dfa_try_to_replace_result(op_array, ssa, op_1, v)) {
1443
0
              opline->opcode = ZEND_PRE_DEC;
1444
0
              op_array->opcodes[use].opcode = ZEND_IS_SMALLER_OR_EQUAL;
1445
0
            }
1446
0
          }
1447
0
        }
1448
0
      }
1449
1450
0
      if (opline->opcode == ZEND_ASSIGN
1451
0
       && ssa->ops[op_1].op1_def == v
1452
0
       && !RETURN_VALUE_USED(opline)
1453
0
      ) {
1454
0
        int orig_var = ssa->ops[op_1].op1_use;
1455
1456
0
        if (orig_var >= 0
1457
0
         && !(ssa->var_info[orig_var].type & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
1458
0
        ) {
1459
0
          int src_var = ssa->ops[op_1].op2_use;
1460
1461
0
          if ((opline->op2_type & (IS_TMP_VAR|IS_VAR))
1462
0
           && src_var >= 0
1463
0
           && !(ssa->var_info[src_var].type & MAY_BE_REF)
1464
0
           && (ssa->var_info[src_var].type & (MAY_BE_UNDEF|MAY_BE_ANY))
1465
0
           && ssa->vars[src_var].definition >= 0
1466
0
           && ssa->ops[ssa->vars[src_var].definition].result_def == src_var
1467
0
           && ssa->ops[ssa->vars[src_var].definition].result_use < 0
1468
0
           && ssa->vars[src_var].use_chain == op_1
1469
0
           && ssa->ops[op_1].op2_use_chain < 0
1470
0
           && !ssa->vars[src_var].phi_use_chain
1471
0
           && !ssa->vars[src_var].sym_use_chain
1472
0
           && opline_supports_assign_contraction(
1473
0
             op_array, ssa, &op_array->opcodes[ssa->vars[src_var].definition],
1474
0
             src_var, opline->op1.var)
1475
0
           && !variable_defined_or_used_in_range(ssa, EX_VAR_TO_NUM(opline->op1.var),
1476
0
              ssa->vars[src_var].definition+1, op_1)
1477
0
          ) {
1478
1479
0
            int op_2 = ssa->vars[src_var].definition;
1480
1481
// op_2: #src_var.T = OP ...                                     => #v.CV = OP ...
1482
// op_1: ASSIGN #orig_var.CV [undef,scalar] -> #v.CV, #src_var.T    NOP
1483
1484
0
            zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1485
            /* Reconstruct SSA */
1486
0
            ssa->vars[v].definition = op_2;
1487
0
            ssa->ops[op_2].result_def = v;
1488
1489
0
            ssa->vars[src_var].definition = -1;
1490
0
            ssa->vars[src_var].use_chain = -1;
1491
1492
0
            ssa->ops[op_1].op1_use = -1;
1493
0
            ssa->ops[op_1].op2_use = -1;
1494
0
            ssa->ops[op_1].op1_def = -1;
1495
0
            ssa->ops[op_1].op1_use_chain = -1;
1496
1497
            /* Update opcodes */
1498
0
            op_array->opcodes[op_2].result_type = opline->op1_type;
1499
0
            op_array->opcodes[op_2].result.var = opline->op1.var;
1500
1501
0
            MAKE_NOP(opline);
1502
0
            remove_nops = 1;
1503
1504
0
            if (op_array->opcodes[op_2].opcode == ZEND_SUB
1505
0
             && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1506
0
             && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1507
0
             && op_array->opcodes[op_2].op2_type == IS_CONST
1508
0
             && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1509
0
             && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1510
0
             && ssa->ops[op_2].op1_use >= 0
1511
0
             && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1512
1513
0
              op_array->opcodes[op_2].opcode = ZEND_PRE_DEC;
1514
0
              SET_UNUSED(op_array->opcodes[op_2].op2);
1515
0
              SET_UNUSED(op_array->opcodes[op_2].result);
1516
1517
0
              ssa->ops[op_2].result_def = -1;
1518
0
              ssa->ops[op_2].op1_def = v;
1519
1520
0
            } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1521
0
             && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1522
0
             && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1523
0
             && op_array->opcodes[op_2].op2_type == IS_CONST
1524
0
             && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1525
0
             && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1526
0
             && ssa->ops[op_2].op1_use >= 0
1527
0
             && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1528
1529
0
              op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1530
0
              SET_UNUSED(op_array->opcodes[op_2].op2);
1531
0
              SET_UNUSED(op_array->opcodes[op_2].result);
1532
1533
0
              ssa->ops[op_2].result_def = -1;
1534
0
              ssa->ops[op_2].op1_def = v;
1535
1536
0
            } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1537
0
             && op_array->opcodes[op_2].op2_type == op_array->opcodes[op_2].result_type
1538
0
             && op_array->opcodes[op_2].op2.var == op_array->opcodes[op_2].result.var
1539
0
             && op_array->opcodes[op_2].op1_type == IS_CONST
1540
0
             && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == IS_LONG
1541
0
             && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == 1
1542
0
             && ssa->ops[op_2].op2_use >= 0
1543
0
             && !(ssa->var_info[ssa->ops[op_2].op2_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1544
1545
0
              op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1546
0
              op_array->opcodes[op_2].op1_type = op_array->opcodes[op_2].op2_type;
1547
0
              op_array->opcodes[op_2].op1.var = op_array->opcodes[op_2].op2.var;
1548
0
              SET_UNUSED(op_array->opcodes[op_2].op2);
1549
0
              SET_UNUSED(op_array->opcodes[op_2].result);
1550
1551
0
              ssa->ops[op_2].result_def = -1;
1552
0
              ssa->ops[op_2].op1_def = v;
1553
0
              ssa->ops[op_2].op1_use = ssa->ops[op_2].op2_use;
1554
0
              ssa->ops[op_2].op1_use_chain = ssa->ops[op_2].op2_use_chain;
1555
0
              ssa->ops[op_2].op2_use = -1;
1556
0
              ssa->ops[op_2].op2_use_chain = -1;
1557
0
            }
1558
0
          } else if (opline->op2_type == IS_CONST
1559
0
           || ((opline->op2_type & (IS_TMP_VAR|IS_VAR|IS_CV))
1560
0
               && ssa->ops[op_1].op2_use >= 0
1561
0
               && ssa->ops[op_1].op2_def < 0)
1562
0
          ) {
1563
1564
// op_1: ASSIGN #orig_var.CV [undef,scalar] -> #v.CV, CONST|TMPVAR => QM_ASSIGN v.CV, CONST|TMPVAR
1565
1566
0
            if (ssa->ops[op_1].op1_use != ssa->ops[op_1].op2_use) {
1567
0
              zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1568
0
            } else {
1569
0
              ssa->ops[op_1].op2_use_chain = ssa->ops[op_1].op1_use_chain;
1570
0
            }
1571
1572
            /* Reconstruct SSA */
1573
0
            ssa->ops[op_1].result_def = v;
1574
0
            ssa->ops[op_1].op1_def = -1;
1575
0
            ssa->ops[op_1].op1_use = ssa->ops[op_1].op2_use;
1576
0
            ssa->ops[op_1].op1_use_chain = ssa->ops[op_1].op2_use_chain;
1577
0
            ssa->ops[op_1].op2_use = -1;
1578
0
            ssa->ops[op_1].op2_use_chain = -1;
1579
1580
            /* Update opcode */
1581
0
            opline->result_type = opline->op1_type;
1582
0
            opline->result.var = opline->op1.var;
1583
0
            opline->op1_type = opline->op2_type;
1584
0
            opline->op1.var = opline->op2.var;
1585
0
            opline->op2_type = IS_UNUSED;
1586
0
            opline->op2.var = 0;
1587
0
            opline->opcode = ZEND_QM_ASSIGN;
1588
0
          }
1589
0
        }
1590
1591
0
      } else if (opline->opcode == ZEND_ASSIGN_OP
1592
0
       && opline->extended_value == ZEND_ADD
1593
0
       && ssa->ops[op_1].op1_def == v
1594
0
       && opline->op2_type == IS_CONST
1595
0
       && Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == IS_LONG
1596
0
       && Z_LVAL_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == 1
1597
0
       && ssa->ops[op_1].op1_use >= 0
1598
0
       && !(ssa->var_info[ssa->ops[op_1].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1599
1600
// op_1: ASSIGN_ADD #?.CV [undef,null,int,foat] ->#v.CV, int(1) => PRE_INC #?.CV ->#v.CV
1601
1602
0
        opline->opcode = ZEND_PRE_INC;
1603
0
        opline->extended_value = 0;
1604
0
        SET_UNUSED(opline->op2);
1605
1606
0
      } else if (opline->opcode == ZEND_ASSIGN_OP
1607
0
       && opline->extended_value == ZEND_SUB
1608
0
       && ssa->ops[op_1].op1_def == v
1609
0
       && opline->op2_type == IS_CONST
1610
0
       && Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == IS_LONG
1611
0
       && Z_LVAL_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == 1
1612
0
       && ssa->ops[op_1].op1_use >= 0
1613
0
       && !(ssa->var_info[ssa->ops[op_1].op1_use].type & (MAY_BE_UNDEF|MAY_BE_NULL|MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1614
1615
// op_1: ASSIGN_SUB #?.CV [undef,null,int,foat] -> #v.CV, int(1) => PRE_DEC #?.CV ->#v.CV
1616
1617
0
        opline->opcode = ZEND_PRE_DEC;
1618
0
        opline->extended_value = 0;
1619
0
        SET_UNUSED(opline->op2);
1620
1621
0
      } else if (ssa->ops[op_1].op1_def == v
1622
0
       && !RETURN_VALUE_USED(opline)
1623
0
       && ssa->ops[op_1].op1_use >= 0
1624
0
       && !(ssa->var_info[ssa->ops[op_1].op1_use].type & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
1625
0
       && opline->opcode == ZEND_ASSIGN_OP
1626
0
       && opline->extended_value != ZEND_CONCAT) {
1627
1628
// op_1: ASSIGN_OP #orig_var.CV [undef,null,bool,int,double] -> #v.CV, ? => #v.CV = ADD #orig_var.CV, ?
1629
1630
        /* Reconstruct SSA */
1631
0
        ssa->ops[op_1].result_def = ssa->ops[op_1].op1_def;
1632
0
        ssa->ops[op_1].op1_def = -1;
1633
1634
        /* Update opcode */
1635
0
        opline->opcode = opline->extended_value;
1636
0
        opline->extended_value = 0;
1637
0
        opline->result_type = opline->op1_type;
1638
0
        opline->result.var = opline->op1.var;
1639
1640
0
      }
1641
0
    }
1642
1643
1
#if ZEND_DEBUG_DFA
1644
1
    ssa_verify_integrity(op_array, ssa, "after dfa");
1645
1
#endif
1646
1647
1
    if (remove_nops) {
1648
0
      zend_ssa_remove_nops(op_array, ssa, ctx);
1649
0
#if ZEND_DEBUG_DFA
1650
0
      ssa_verify_integrity(op_array, ssa, "after nop");
1651
0
#endif
1652
0
    }
1653
1
  }
1654
1655
1
  if (ctx->debug_level & ZEND_DUMP_AFTER_DFA_PASS) {
1656
0
    zend_dump_op_array(op_array, ZEND_DUMP_SSA, "after dfa pass", ssa);
1657
0
  }
1658
1
}
1659
1660
void zend_optimize_dfa(zend_op_array *op_array, zend_optimizer_ctx *ctx)
1661
0
{
1662
0
  void *checkpoint = zend_arena_checkpoint(ctx->arena);
1663
0
  zend_ssa ssa;
1664
1665
0
  if (zend_dfa_analyze_op_array(op_array, ctx, &ssa) == FAILURE) {
1666
0
    zend_arena_release(&ctx->arena, checkpoint);
1667
0
    return;
1668
0
  }
1669
1670
0
  zend_dfa_optimize_op_array(op_array, ctx, &ssa, NULL);
1671
1672
  /* Destroy SSA */
1673
0
  zend_arena_release(&ctx->arena, checkpoint);
1674
0
}