Coverage Report

Created: 2026-06-02 06:40

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/php-src/Zend/Optimizer/dfa_pass.c
Line
Count
Source
1
/*
2
   +----------------------------------------------------------------------+
3
   | Zend OPcache                                                         |
4
   +----------------------------------------------------------------------+
5
   | Copyright © The PHP Group and Contributors.                          |
6
   +----------------------------------------------------------------------+
7
   | This source file is subject to the Modified BSD License that is      |
8
   | bundled with this package in the file LICENSE, and is available      |
9
   | through the World Wide Web at <https://www.php.net/license/>.        |
10
   |                                                                      |
11
   | SPDX-License-Identifier: BSD-3-Clause                                |
12
   +----------------------------------------------------------------------+
13
   | Authors: Dmitry Stogov <dmitry@php.net>                              |
14
   +----------------------------------------------------------------------+
15
*/
16
17
#include "Optimizer/zend_optimizer.h"
18
#include "Optimizer/zend_optimizer_internal.h"
19
#include "zend_API.h"
20
#include "zend_constants.h"
21
#include "zend_execute.h"
22
#include "zend_vm.h"
23
#include "zend_bitset.h"
24
#include "zend_cfg.h"
25
#include "zend_ssa.h"
26
#include "zend_func_info.h"
27
#include "zend_call_graph.h"
28
#include "zend_inference.h"
29
#include "zend_dump.h"
30
31
#ifndef ZEND_DEBUG_DFA
32
# define ZEND_DEBUG_DFA ZEND_DEBUG
33
#endif
34
35
#if ZEND_DEBUG_DFA
36
# include "ssa_integrity.c"
37
#endif
38
39
zend_result zend_dfa_analyze_op_array(zend_op_array *op_array, zend_optimizer_ctx *ctx, zend_ssa *ssa)
40
93.0k
{
41
93.0k
  uint32_t build_flags;
42
43
93.0k
  if (op_array->last_try_catch) {
44
    /* TODO: we can't analyze functions with try/catch/finally ??? */
45
18.6k
    return FAILURE;
46
18.6k
  }
47
48
    /* Build SSA */
49
74.3k
  memset(ssa, 0, sizeof(zend_ssa));
50
51
74.3k
  zend_build_cfg(&ctx->arena, op_array, ZEND_CFG_NO_ENTRY_PREDECESSORS, &ssa->cfg);
52
53
74.3k
  if ((ssa->cfg.flags & ZEND_FUNC_INDIRECT_VAR_ACCESS)) {
54
    /* TODO: we can't analyze functions with indirect variable access ??? */
55
3.14k
    return FAILURE;
56
3.14k
  }
57
58
71.2k
  zend_cfg_build_predecessors(&ctx->arena, &ssa->cfg);
59
60
71.2k
  if (ctx->debug_level & ZEND_DUMP_DFA_CFG) {
61
0
    zend_dump_op_array(op_array, ZEND_DUMP_CFG, "dfa cfg", &ssa->cfg);
62
0
  }
63
64
  /* Compute Dominators Tree */
65
71.2k
  zend_cfg_compute_dominators_tree(op_array, &ssa->cfg);
66
67
  /* Identify reducible and irreducible loops */
68
71.2k
  zend_cfg_identify_loops(op_array, &ssa->cfg);
69
70
71.2k
  if (ctx->debug_level & ZEND_DUMP_DFA_DOMINATORS) {
71
0
    zend_dump_dominators(op_array, &ssa->cfg);
72
0
  }
73
74
71.2k
  build_flags = 0;
75
71.2k
  if (ctx->debug_level & ZEND_DUMP_DFA_LIVENESS) {
76
0
    build_flags |= ZEND_SSA_DEBUG_LIVENESS;
77
0
  }
78
71.2k
  if (ctx->debug_level & ZEND_DUMP_DFA_PHI) {
79
0
    build_flags |= ZEND_SSA_DEBUG_PHI_PLACEMENT;
80
0
  }
81
71.2k
  if (zend_build_ssa(&ctx->arena, ctx->script, op_array, build_flags, ssa) == FAILURE) {
82
0
    return FAILURE;
83
0
  }
84
85
71.2k
  if (ctx->debug_level & ZEND_DUMP_DFA_SSA) {
86
0
    zend_dump_op_array(op_array, ZEND_DUMP_SSA, "dfa ssa", ssa);
87
0
  }
88
89
90
71.2k
  zend_ssa_compute_use_def_chains(&ctx->arena, op_array, ssa);
91
92
71.2k
  zend_ssa_find_false_dependencies(op_array, ssa);
93
94
71.2k
  zend_ssa_find_sccs(op_array, ssa);
95
96
71.2k
  if (zend_ssa_inference(&ctx->arena, op_array, ctx->script, ssa, ctx->optimization_level) == FAILURE) {
97
0
    return FAILURE;
98
0
  }
99
100
71.2k
  if (zend_ssa_escape_analysis(ctx->script, op_array, ssa) == FAILURE) {
101
0
    return FAILURE;
102
0
  }
103
104
71.2k
  if (ctx->debug_level & ZEND_DUMP_DFA_SSA_VARS) {
105
0
    zend_dump_ssa_variables(op_array, ssa, 0);
106
0
  }
107
108
71.2k
  return SUCCESS;
109
71.2k
}
110
111
static void zend_ssa_remove_nops(zend_op_array *op_array, zend_ssa *ssa, zend_optimizer_ctx *ctx)
112
7.81k
{
113
7.81k
  zend_basic_block *blocks = ssa->cfg.blocks;
114
7.81k
  zend_basic_block *blocks_end = blocks + ssa->cfg.blocks_count;
115
7.81k
  zend_basic_block *b;
116
7.81k
  zend_func_info *func_info;
117
7.81k
  int j;
118
7.81k
  uint32_t i = 0;
119
7.81k
  uint32_t target = 0;
120
7.81k
  uint32_t *shiftlist;
121
7.81k
  ALLOCA_FLAG(use_heap);
122
123
7.81k
  shiftlist = (uint32_t *)do_alloca(sizeof(uint32_t) * op_array->last, use_heap);
124
7.81k
  memset(shiftlist, 0, sizeof(uint32_t) * op_array->last);
125
  /* remove empty callee_info */
126
7.81k
  func_info = ZEND_FUNC_INFO(op_array);
127
7.81k
  if (func_info) {
128
7.81k
    zend_call_info **call_info = &func_info->callee_info;
129
16.8k
    while ((*call_info)) {
130
9.00k
      if ((*call_info)->caller_init_opline->opcode == ZEND_NOP) {
131
72
        *call_info = (*call_info)->next_callee;
132
8.93k
      } else {
133
8.93k
        call_info = &(*call_info)->next_callee;
134
8.93k
      }
135
9.00k
    }
136
7.81k
  }
137
138
67.5k
  for (b = blocks; b < blocks_end; b++) {
139
59.7k
    if (b->flags & (ZEND_BB_REACHABLE|ZEND_BB_UNREACHABLE_FREE)) {
140
53.6k
      if (b->len) {
141
53.1k
        uint32_t new_start, old_end;
142
67.9k
        while (i < b->start) {
143
14.7k
          shiftlist[i] = i - target;
144
14.7k
          i++;
145
14.7k
        }
146
147
53.1k
        if (b->flags & ZEND_BB_UNREACHABLE_FREE) {
148
          /* Only keep the FREE for the loop var */
149
10
          ZEND_ASSERT(op_array->opcodes[b->start].opcode == ZEND_FREE
150
10
              || op_array->opcodes[b->start].opcode == ZEND_FE_FREE);
151
10
          b->len = 1;
152
10
        }
153
154
53.1k
        new_start = target;
155
53.1k
        old_end = b->start + b->len;
156
506k
        while (i < old_end) {
157
453k
          shiftlist[i] = i - target;
158
453k
          if (EXPECTED(op_array->opcodes[i].opcode != ZEND_NOP)) {
159
428k
            if (i != target) {
160
266k
              op_array->opcodes[target] = op_array->opcodes[i];
161
266k
              ssa->ops[target] = ssa->ops[i];
162
266k
              ssa->cfg.map[target] = b - blocks;
163
266k
            }
164
428k
            target++;
165
428k
          }
166
453k
          i++;
167
453k
        }
168
53.1k
        b->start = new_start;
169
53.1k
        if (target != old_end) {
170
34.9k
          zend_op *opline;
171
34.9k
          zend_op *new_opline;
172
173
34.9k
          b->len = target - b->start;
174
34.9k
          opline = op_array->opcodes + old_end - 1;
175
34.9k
          if (opline->opcode == ZEND_NOP) {
176
187
            continue;
177
187
          }
178
179
34.7k
          new_opline = op_array->opcodes + target - 1;
180
34.7k
          zend_optimizer_migrate_jump(op_array, new_opline, opline);
181
34.7k
        }
182
53.1k
      } else {
183
420
        b->start = target;
184
420
      }
185
53.6k
    } else {
186
6.12k
      b->start = target;
187
6.12k
      b->len = 0;
188
6.12k
    }
189
59.7k
  }
190
191
7.81k
  if (target != op_array->last) {
192
    /* reset rest opcodes */
193
47.5k
    for (i = target; i < op_array->last; i++) {
194
39.7k
      MAKE_NOP(op_array->opcodes + i);
195
39.7k
    }
196
197
    /* update SSA variables */
198
422k
    for (j = 0; j < ssa->vars_count; j++) {
199
414k
      if (ssa->vars[j].definition >= 0) {
200
290k
        ssa->vars[j].definition -= shiftlist[ssa->vars[j].definition];
201
290k
      }
202
414k
      if (ssa->vars[j].use_chain >= 0) {
203
299k
        ssa->vars[j].use_chain -= shiftlist[ssa->vars[j].use_chain];
204
299k
      }
205
414k
    }
206
476k
    for (i = 0; i < op_array->last; i++) {
207
468k
      if (ssa->ops[i].op1_use_chain >= 0) {
208
21.9k
        ssa->ops[i].op1_use_chain -= shiftlist[ssa->ops[i].op1_use_chain];
209
21.9k
      }
210
468k
      if (ssa->ops[i].op2_use_chain >= 0) {
211
27.5k
        ssa->ops[i].op2_use_chain -= shiftlist[ssa->ops[i].op2_use_chain];
212
27.5k
      }
213
468k
      if (ssa->ops[i].res_use_chain >= 0) {
214
0
        ssa->ops[i].res_use_chain -= shiftlist[ssa->ops[i].res_use_chain];
215
0
      }
216
468k
    }
217
218
    /* update branch targets */
219
67.5k
    for (b = blocks; b < blocks_end; b++) {
220
59.7k
      if ((b->flags & ZEND_BB_REACHABLE) && b->len != 0) {
221
53.1k
        zend_op *opline = op_array->opcodes + b->start + b->len - 1;
222
53.1k
        zend_optimizer_shift_jump(op_array, opline, shiftlist);
223
53.1k
      }
224
59.7k
    }
225
226
    /* update try/catch array */
227
7.81k
    for (uint32_t j = 0; j < op_array->last_try_catch; j++) {
228
0
      op_array->try_catch_array[j].try_op -= shiftlist[op_array->try_catch_array[j].try_op];
229
0
      op_array->try_catch_array[j].catch_op -= shiftlist[op_array->try_catch_array[j].catch_op];
230
0
      if (op_array->try_catch_array[j].finally_op) {
231
0
        op_array->try_catch_array[j].finally_op -= shiftlist[op_array->try_catch_array[j].finally_op];
232
0
        op_array->try_catch_array[j].finally_end -= shiftlist[op_array->try_catch_array[j].finally_end];
233
0
      }
234
0
    }
235
236
    /* update call graph */
237
7.81k
    if (func_info) {
238
7.81k
      zend_call_info *call_info = func_info->callee_info;
239
16.7k
      while (call_info) {
240
8.93k
        call_info->caller_init_opline -=
241
8.93k
          shiftlist[call_info->caller_init_opline - op_array->opcodes];
242
8.93k
        if (call_info->caller_call_opline) {
243
8.93k
          call_info->caller_call_opline -=
244
8.93k
            shiftlist[call_info->caller_call_opline - op_array->opcodes];
245
8.93k
        }
246
8.93k
        call_info = call_info->next_callee;
247
8.93k
      }
248
7.81k
    }
249
250
7.81k
    op_array->last = target;
251
7.81k
  }
252
7.81k
  free_alloca(shiftlist, use_heap);
253
7.81k
}
254
255
299
static bool safe_instanceof(const zend_class_entry *ce1, const zend_class_entry *ce2) {
256
299
  if (ce1 == ce2) {
257
187
    return true;
258
187
  }
259
112
  if (!(ce1->ce_flags & ZEND_ACC_LINKED)) {
260
    /* This case could be generalized, similarly to unlinked_instanceof */
261
16
    return false;
262
16
  }
263
96
  return instanceof_function(ce1, ce2);
264
112
}
265
266
static inline bool can_elide_list_type(
267
  const zend_script *script, const zend_op_array *op_array,
268
  const zend_ssa_var_info *use_info, const zend_type type)
269
400
{
270
400
  const zend_type *single_type;
271
  /* For intersection: result==false is failure, default is success.
272
   * For union: result==true is success, default is failure. */
273
400
  bool is_intersection = ZEND_TYPE_IS_INTERSECTION(type);
274
800
  ZEND_TYPE_FOREACH(type, single_type) {
275
800
    if (ZEND_TYPE_HAS_LIST(*single_type)) {
276
40
      ZEND_ASSERT(!is_intersection);
277
40
      return can_elide_list_type(script, op_array, use_info, *single_type);
278
40
    }
279
360
    if (ZEND_TYPE_HAS_NAME(*single_type)) {
280
360
      zend_string *lcname = zend_string_tolower(ZEND_TYPE_NAME(*single_type));
281
360
      const zend_class_entry *ce = zend_optimizer_get_class_entry(script, op_array, lcname);
282
360
      zend_string_release(lcname);
283
360
      bool result = ce && safe_instanceof(use_info->ce, ce);
284
360
      if (result == !is_intersection) {
285
263
        return result;
286
263
      }
287
360
    }
288
360
  } ZEND_TYPE_FOREACH_END();
289
97
  return is_intersection;
290
400
}
291
292
static inline bool can_elide_return_type_check(
293
2.64k
    const zend_script *script, zend_op_array *op_array, zend_ssa *ssa, zend_ssa_op *ssa_op) {
294
2.64k
  zend_arg_info *arg_info = &op_array->arg_info[-1];
295
2.64k
  zend_ssa_var_info *use_info = &ssa->var_info[ssa_op->op1_use];
296
2.64k
  uint32_t use_type = use_info->type & (MAY_BE_ANY|MAY_BE_UNDEF);
297
2.64k
  if (use_type & MAY_BE_REF) {
298
0
    return false;
299
0
  }
300
301
2.64k
  if (use_type & MAY_BE_UNDEF) {
302
76
    use_type &= ~MAY_BE_UNDEF;
303
76
    use_type |= MAY_BE_NULL;
304
76
  }
305
306
2.64k
  uint32_t disallowed_types = use_type & ~ZEND_TYPE_PURE_MASK(arg_info->type);
307
2.64k
  if (!disallowed_types) {
308
    /* Only contains allowed types. */
309
665
    return true;
310
665
  }
311
312
1.98k
  if (disallowed_types == MAY_BE_OBJECT && use_info->ce && ZEND_TYPE_IS_COMPLEX(arg_info->type)) {
313
360
    return can_elide_list_type(script, op_array, use_info, arg_info->type);
314
360
  }
315
316
1.62k
  return false;
317
1.98k
}
318
319
static bool opline_supports_assign_contraction(
320
5.90k
    zend_op_array *op_array, zend_ssa *ssa, zend_op *opline, int src_var, uint32_t cv_var) {
321
5.90k
  if (opline->opcode == ZEND_NEW) {
322
    /* see Zend/tests/generators/aborted_yield_during_new.phpt */
323
1.14k
    return false;
324
1.14k
  }
325
326
  /* Frameless calls override the return value, but the return value may overlap with the arguments. */
327
4.75k
  switch (opline->opcode) {
328
0
    case ZEND_FRAMELESS_ICALL_3:
329
0
      if ((opline + 1)->op1_type == IS_CV && (opline + 1)->op1.var == cv_var) return false;
330
0
      ZEND_FALLTHROUGH;
331
0
    case ZEND_FRAMELESS_ICALL_2:
332
0
      if (opline->op2_type == IS_CV && opline->op2.var == cv_var) return false;
333
0
      ZEND_FALLTHROUGH;
334
0
    case ZEND_FRAMELESS_ICALL_1:
335
0
      if (opline->op1_type == IS_CV && opline->op1.var == cv_var) return false;
336
0
      return true;
337
4.75k
  }
338
339
4.75k
  if (opline->opcode == ZEND_DO_ICALL || opline->opcode == ZEND_DO_UCALL
340
4.73k
      || opline->opcode == ZEND_DO_FCALL || opline->opcode == ZEND_DO_FCALL_BY_NAME) {
341
    /* Function calls may dtor the return value after it has already been written -- allow
342
     * direct assignment only for types where a double-dtor does not matter. */
343
627
    uint32_t type = ssa->var_info[src_var].type;
344
627
    uint32_t simple = MAY_BE_NULL|MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_LONG|MAY_BE_DOUBLE;
345
627
    return !((type & MAY_BE_ANY) & ~simple);
346
627
  }
347
348
4.12k
  if (opline->opcode == ZEND_POST_INC || opline->opcode == ZEND_POST_DEC) {
349
    /* POST_INC/DEC write the result variable before performing the inc/dec. For $i = $i++
350
     * eliding the temporary variable would thus yield an incorrect result. */
351
21
    return opline->op1_type != IS_CV || opline->op1.var != cv_var;
352
21
  }
353
354
4.10k
  if (opline->opcode == ZEND_INIT_ARRAY) {
355
    /* INIT_ARRAY initializes the result array before reading key/value. */
356
58
    return (opline->op1_type != IS_CV || opline->op1.var != cv_var)
357
54
      && (opline->op2_type != IS_CV || opline->op2.var != cv_var);
358
58
  }
359
360
4.04k
  if (opline->opcode == ZEND_CAST
361
90
      && (opline->extended_value == IS_ARRAY || opline->extended_value == IS_OBJECT)) {
362
    /* CAST to array/object may initialize the result to an empty array/object before
363
     * reading the expression. */
364
18
    return opline->op1_type != IS_CV || opline->op1.var != cv_var;
365
18
  }
366
367
4.02k
  if ((opline->opcode == ZEND_ASSIGN_OP
368
4.01k
    || opline->opcode == ZEND_ASSIGN_OBJ
369
4.01k
    || opline->opcode == ZEND_ASSIGN_DIM
370
3.99k
    || opline->opcode == ZEND_ASSIGN_OBJ_OP
371
3.99k
    || opline->opcode == ZEND_ASSIGN_DIM_OP)
372
31
   && opline->op1_type == IS_CV
373
31
   && opline->op1.var == cv_var
374
12
   && zend_may_throw(opline, &ssa->ops[ssa->vars[src_var].definition], op_array, ssa)) {
375
6
    return false;
376
6
  }
377
378
4.02k
  return true;
379
4.02k
}
380
381
static bool variable_defined_or_used_in_range(zend_ssa *ssa, int var, int start, int end)
382
4.12k
{
383
4.16k
  while (start < end) {
384
41
    const zend_ssa_op *ssa_op = &ssa->ops[start];
385
41
    if ((ssa_op->op1_def >= 0 && ssa->vars[ssa_op->op1_def].var == var) ||
386
41
      (ssa_op->op2_def >= 0 && ssa->vars[ssa_op->op2_def].var == var) ||
387
41
      (ssa_op->result_def >= 0 && ssa->vars[ssa_op->result_def].var == var) ||
388
41
      (ssa_op->op1_use >= 0 && ssa->vars[ssa_op->op1_use].var == var) ||
389
41
      (ssa_op->op2_use >= 0 && ssa->vars[ssa_op->op2_use].var == var) ||
390
41
      (ssa_op->result_use >= 0 && ssa->vars[ssa_op->result_use].var == var)
391
41
    ) {
392
0
      return true;
393
0
    }
394
41
    start++;
395
41
  }
396
4.12k
  return false;
397
4.12k
}
398
399
static uint32_t zend_dfa_optimize_calls(zend_op_array *op_array, zend_ssa *ssa)
400
71.2k
{
401
71.2k
  const zend_func_info *func_info = ZEND_FUNC_INFO(op_array);
402
71.2k
  uint32_t removed_ops = 0;
403
404
71.2k
  if (func_info->callee_info) {
405
32.8k
    const zend_call_info *call_info = func_info->callee_info;
406
407
80.2k
    do {
408
80.2k
      zend_op *op = call_info->caller_init_opline;
409
410
80.2k
      if ((op->opcode == ZEND_FRAMELESS_ICALL_2
411
80.2k
        || (op->opcode == ZEND_FRAMELESS_ICALL_3 && (op + 1)->op1_type == IS_CONST))
412
0
       && call_info->callee_func
413
0
       && zend_string_equals_literal_ci(call_info->callee_func->common.function_name, "in_array")) {
414
0
        bool strict = false;
415
0
        bool has_opdata = op->opcode == ZEND_FRAMELESS_ICALL_3;
416
0
        ZEND_ASSERT(!call_info->is_prototype);
417
418
0
        if (has_opdata) {
419
0
          if (zend_is_true(CT_CONSTANT_EX(op_array, (op + 1)->op1.constant))) {
420
0
            strict = true;
421
0
          }
422
0
        }
423
424
0
        if (op->op2_type == IS_CONST
425
0
         && Z_TYPE_P(CT_CONSTANT_EX(op_array, op->op2.constant)) == IS_ARRAY) {
426
0
          bool ok = true;
427
428
0
          const HashTable *src = Z_ARRVAL_P(CT_CONSTANT_EX(op_array, op->op2.constant));
429
0
          HashTable *dst;
430
0
          zval *val, tmp;
431
0
          zend_ulong idx;
432
433
0
          ZVAL_TRUE(&tmp);
434
0
          dst = zend_new_array(zend_hash_num_elements(src));
435
0
          if (strict) {
436
0
            ZEND_HASH_FOREACH_VAL(src, val) {
437
0
              if (Z_TYPE_P(val) == IS_STRING) {
438
0
                zend_hash_add(dst, Z_STR_P(val), &tmp);
439
0
              } else if (Z_TYPE_P(val) == IS_LONG) {
440
0
                zend_hash_index_add(dst, Z_LVAL_P(val), &tmp);
441
0
              } else {
442
0
                zend_array_destroy(dst);
443
0
                ok = false;
444
0
                break;
445
0
              }
446
0
            } ZEND_HASH_FOREACH_END();
447
0
          } else {
448
0
            ZEND_HASH_FOREACH_VAL(src, val) {
449
0
              if (Z_TYPE_P(val) != IS_STRING || ZEND_HANDLE_NUMERIC(Z_STR_P(val), idx)) {
450
0
                zend_array_destroy(dst);
451
0
                ok = false;
452
0
                break;
453
0
              }
454
0
              zend_hash_add(dst, Z_STR_P(val), &tmp);
455
0
            } ZEND_HASH_FOREACH_END();
456
0
          }
457
458
0
          if (ok) {
459
0
            ZVAL_ARR(&tmp, dst);
460
461
            /* Update opcode */
462
0
            op->opcode = ZEND_IN_ARRAY;
463
0
            op->extended_value = strict;
464
0
            op->op2.constant = zend_optimizer_add_literal(op_array, &tmp);
465
0
            if (has_opdata) {
466
0
              MAKE_NOP(op + 1);
467
0
              removed_ops++;
468
0
            }
469
0
          }
470
0
        }
471
0
      }
472
80.2k
      call_info = call_info->next_callee;
473
80.2k
    } while (call_info);
474
32.8k
  }
475
476
71.2k
  return removed_ops;
477
71.2k
}
478
479
static zend_always_inline void take_successor_0(zend_ssa *ssa, uint32_t block_num, zend_basic_block *block)
480
1.79k
{
481
1.79k
  if (block->successors_count == 2) {
482
359
    if (block->successors[1] != block->successors[0]) {
483
52
      zend_ssa_remove_predecessor(ssa, block_num, block->successors[1]);
484
52
    }
485
359
    block->successors_count = 1;
486
359
  }
487
1.79k
}
488
489
static zend_always_inline void take_successor_1(zend_ssa *ssa, uint32_t block_num, zend_basic_block *block)
490
781
{
491
781
  if (block->successors_count == 2) {
492
455
    if (block->successors[1] != block->successors[0]) {
493
378
      zend_ssa_remove_predecessor(ssa, block_num, block->successors[0]);
494
378
      block->successors[0] = block->successors[1];
495
378
    }
496
455
    block->successors_count = 1;
497
455
  }
498
781
}
499
500
static zend_always_inline void take_successor_ex(zend_ssa *ssa, uint32_t block_num, zend_basic_block *block, int target_block)
501
22
{
502
72
  for (uint32_t i = 0; i < block->successors_count; i++) {
503
50
    if (block->successors[i] != target_block) {
504
28
      zend_ssa_remove_predecessor(ssa, block_num, block->successors[i]);
505
28
    }
506
50
  }
507
22
  block->successors[0] = target_block;
508
22
  block->successors_count = 1;
509
22
}
510
511
static void compress_block(zend_op_array *op_array, zend_basic_block *block)
512
249k
{
513
255k
  while (block->len > 0) {
514
253k
    zend_op *opline = &op_array->opcodes[block->start + block->len - 1];
515
516
253k
    if (opline->opcode == ZEND_NOP) {
517
6.28k
      block->len--;
518
247k
    } else {
519
247k
      break;
520
247k
    }
521
253k
  }
522
249k
}
523
524
1.88k
static void replace_predecessor(zend_ssa *ssa, int block_id, int old_pred, int new_pred) {
525
1.88k
  zend_basic_block *block = &ssa->cfg.blocks[block_id];
526
1.88k
  int *predecessors = &ssa->cfg.predecessors[block->predecessor_offset];
527
1.88k
  zend_ssa_phi *phi;
528
529
1.88k
  int old_pred_idx = -1;
530
1.88k
  int new_pred_idx = -1;
531
4.59k
  for (uint32_t i = 0; i < block->predecessors_count; i++) {
532
2.71k
    if (predecessors[i] == old_pred) {
533
1.88k
      old_pred_idx = i;
534
1.88k
    }
535
2.71k
    if (predecessors[i] == new_pred) {
536
425
      new_pred_idx = i;
537
425
    }
538
2.71k
  }
539
540
1.88k
  ZEND_ASSERT(old_pred_idx != -1);
541
1.88k
  if (new_pred_idx == -1) {
542
    /* If the new predecessor doesn't exist yet, simply rewire the old one */
543
1.45k
    predecessors[old_pred_idx] = new_pred;
544
1.45k
  } else {
545
    /* Otherwise, rewiring the old predecessor would make the new predecessor appear
546
     * twice, which violates our CFG invariants. Remove the old predecessor instead. */
547
425
    memmove(
548
425
      predecessors + old_pred_idx,
549
425
      predecessors + old_pred_idx + 1,
550
425
      sizeof(int) * (block->predecessors_count - old_pred_idx - 1)
551
425
    );
552
553
    /* Also remove the corresponding phi node entries */
554
450
    for (phi = ssa->blocks[block_id].phis; phi; phi = phi->next) {
555
25
      if (phi->pi >= 0) {
556
8
        if (phi->pi == old_pred || phi->pi == new_pred) {
557
8
          zend_ssa_rename_var_uses(
558
8
            ssa, phi->ssa_var, phi->sources[0], /* update_types */ 0);
559
8
          zend_ssa_remove_phi(ssa, phi);
560
8
        }
561
17
      } else {
562
17
        memmove(
563
17
          phi->sources + old_pred_idx,
564
17
          phi->sources + old_pred_idx + 1,
565
17
          sizeof(int) * (block->predecessors_count - old_pred_idx - 1)
566
17
        );
567
17
      }
568
25
    }
569
570
425
    block->predecessors_count--;
571
425
  }
572
1.88k
}
573
574
static void zend_ssa_replace_control_link(zend_op_array *op_array, zend_ssa *ssa, int from, int to, int new_to)
575
1.88k
{
576
1.88k
  zend_basic_block *src = &ssa->cfg.blocks[from];
577
1.88k
  zend_basic_block *old = &ssa->cfg.blocks[to];
578
1.88k
  zend_basic_block *dst = &ssa->cfg.blocks[new_to];
579
1.88k
  zend_op *opline;
580
581
4.98k
  for (uint32_t i = 0; i < src->successors_count; i++) {
582
3.09k
    if (src->successors[i] == to) {
583
1.92k
      src->successors[i] = new_to;
584
1.92k
    }
585
3.09k
  }
586
587
1.88k
  if (src->len > 0) {
588
1.67k
    opline = op_array->opcodes + src->start + src->len - 1;
589
1.67k
    switch (opline->opcode) {
590
6
      case ZEND_JMP:
591
6
      case ZEND_FAST_CALL:
592
6
        ZEND_ASSERT(ZEND_OP1_JMP_ADDR(opline) == op_array->opcodes + old->start);
593
6
        ZEND_SET_OP_JMP_ADDR(opline, opline->op1, op_array->opcodes + dst->start);
594
6
        break;
595
516
      case ZEND_JMPZ:
596
715
      case ZEND_JMPNZ:
597
877
      case ZEND_JMPZ_EX:
598
907
      case ZEND_JMPNZ_EX:
599
907
      case ZEND_FE_RESET_R:
600
907
      case ZEND_FE_RESET_RW:
601
1.03k
      case ZEND_JMP_SET:
602
1.27k
      case ZEND_COALESCE:
603
1.27k
      case ZEND_ASSERT_CHECK:
604
1.27k
      case ZEND_JMP_NULL:
605
1.27k
      case ZEND_BIND_INIT_STATIC_OR_JMP:
606
1.27k
      case ZEND_JMP_FRAMELESS:
607
1.27k
        if (ZEND_OP2_JMP_ADDR(opline) == op_array->opcodes + old->start) {
608
378
          ZEND_SET_OP_JMP_ADDR(opline, opline->op2, op_array->opcodes + dst->start);
609
378
        }
610
1.27k
        break;
611
0
      case ZEND_CATCH:
612
0
        if (!(opline->extended_value & ZEND_LAST_CATCH)) {
613
0
          if (ZEND_OP2_JMP_ADDR(opline) == op_array->opcodes + old->start) {
614
0
            ZEND_SET_OP_JMP_ADDR(opline, opline->op2, op_array->opcodes + dst->start);
615
0
          }
616
0
        }
617
0
        break;
618
9
      case ZEND_FE_FETCH_R:
619
9
      case ZEND_FE_FETCH_RW:
620
9
        if (ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value) == old->start) {
621
0
          opline->extended_value = ZEND_OPLINE_NUM_TO_OFFSET(op_array, opline, dst->start);
622
0
        }
623
9
        break;
624
0
      case ZEND_SWITCH_LONG:
625
0
      case ZEND_SWITCH_STRING:
626
6
      case ZEND_MATCH:
627
6
        {
628
6
          HashTable *jumptable = Z_ARRVAL(ZEND_OP2_LITERAL(opline));
629
6
          zval *zv;
630
30
          ZEND_HASH_FOREACH_VAL(jumptable, zv) {
631
30
            if (ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, Z_LVAL_P(zv)) == old->start) {
632
0
              Z_LVAL_P(zv) = ZEND_OPLINE_NUM_TO_OFFSET(op_array, opline, dst->start);
633
0
            }
634
30
          } ZEND_HASH_FOREACH_END();
635
6
          if (ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value) == old->start) {
636
6
            opline->extended_value = ZEND_OPLINE_NUM_TO_OFFSET(op_array, opline, dst->start);
637
6
          }
638
6
          break;
639
0
        }
640
1.67k
    }
641
1.67k
  }
642
643
1.88k
  replace_predecessor(ssa, new_to, to, from);
644
1.88k
}
645
646
static void zend_ssa_unlink_block(zend_op_array *op_array, zend_ssa *ssa, zend_basic_block *block, uint32_t block_num)
647
2.37k
{
648
2.37k
  if (block->predecessors_count == 1 && ssa->blocks[block_num].phis == NULL) {
649
1.88k
    int *predecessors;
650
1.88k
    zend_basic_block *fe_fetch_block = NULL;
651
652
1.88k
    ZEND_ASSERT(block->successors_count == 1);
653
1.88k
    predecessors = &ssa->cfg.predecessors[block->predecessor_offset];
654
1.88k
    if (block->predecessors_count == 1 && (block->flags & ZEND_BB_FOLLOW)) {
655
1.61k
      zend_basic_block *pred_block = &ssa->cfg.blocks[predecessors[0]];
656
657
1.61k
      if (pred_block->len > 0 && (pred_block->flags & ZEND_BB_REACHABLE)) {
658
1.40k
        if ((op_array->opcodes[pred_block->start + pred_block->len - 1].opcode == ZEND_FE_FETCH_R
659
1.39k
         || op_array->opcodes[pred_block->start + pred_block->len - 1].opcode == ZEND_FE_FETCH_RW)
660
9
          && op_array->opcodes[pred_block->start + pred_block->len - 1].op2_type == IS_CV) {
661
9
          fe_fetch_block = pred_block;
662
9
          }
663
1.40k
      }
664
1.61k
    }
665
3.76k
    for (uint32_t i = 0; i < block->predecessors_count; i++) {
666
1.88k
      zend_ssa_replace_control_link(op_array, ssa, predecessors[i], block_num, block->successors[0]);
667
1.88k
    }
668
1.88k
    zend_ssa_remove_block(op_array, ssa, block_num);
669
1.88k
    if (fe_fetch_block && fe_fetch_block->successors[0] == fe_fetch_block->successors[1]) {
670
      /* The body of "foreach" loop was removed */
671
5
      int ssa_var = ssa->ops[fe_fetch_block->start + fe_fetch_block->len - 1].op2_def;
672
5
      if (ssa_var >= 0) {
673
5
        zend_ssa_remove_uses_of_var(ssa, ssa_var);
674
5
      }
675
5
    }
676
1.88k
  }
677
2.37k
}
678
679
static int zend_dfa_optimize_jmps(zend_op_array *op_array, zend_ssa *ssa)
680
142k
{
681
142k
  int removed_ops = 0;
682
142k
  uint32_t block_num = 0;
683
684
399k
  for (block_num = 1; block_num < ssa->cfg.blocks_count; block_num++) {
685
256k
    zend_basic_block *block = &ssa->cfg.blocks[block_num];
686
687
256k
    if (!(block->flags & ZEND_BB_REACHABLE)) {
688
9.70k
      continue;
689
9.70k
    }
690
246k
    compress_block(op_array, block);
691
246k
    if (block->len == 0) {
692
1.12k
      zend_ssa_unlink_block(op_array, ssa, block, block_num);
693
1.12k
    }
694
246k
  }
695
696
142k
  block_num = 0;
697
142k
  while (block_num < ssa->cfg.blocks_count
698
142k
    && !(ssa->cfg.blocks[block_num].flags & ZEND_BB_REACHABLE)) {
699
0
    block_num++;
700
0
  }
701
532k
  while (block_num < ssa->cfg.blocks_count) {
702
389k
    uint32_t next_block_num = block_num + 1;
703
389k
    zend_basic_block *block = &ssa->cfg.blocks[block_num];
704
389k
    uint32_t op_num;
705
389k
    zend_op *opline;
706
389k
    zend_ssa_op *ssa_op;
707
389k
    bool can_follow = true;
708
709
415k
    while (next_block_num < ssa->cfg.blocks_count
710
273k
      && !(ssa->cfg.blocks[next_block_num].flags & ZEND_BB_REACHABLE)) {
711
25.7k
      if (ssa->cfg.blocks[next_block_num].flags & ZEND_BB_UNREACHABLE_FREE) {
712
48
        can_follow = false;
713
48
      }
714
25.7k
      next_block_num++;
715
25.7k
    }
716
717
389k
    if (block->len) {
718
388k
      op_num = block->start + block->len - 1;
719
388k
      opline = op_array->opcodes + op_num;
720
388k
      ssa_op = ssa->ops + op_num;
721
722
388k
      switch (opline->opcode) {
723
29.5k
        case ZEND_JMP:
724
31.0k
optimize_jmp:
725
31.0k
          if (block->successors[0] == next_block_num && can_follow) {
726
1.60k
            MAKE_NOP(opline);
727
1.60k
            removed_ops++;
728
1.60k
            goto optimize_nop;
729
1.60k
          }
730
29.4k
          break;
731
29.4k
        case ZEND_JMPZ:
732
15.7k
optimize_jmpz:
733
15.7k
          if (opline->op1_type == IS_CONST) {
734
550
            if (zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
735
326
              MAKE_NOP(opline);
736
326
              removed_ops++;
737
326
              take_successor_1(ssa, block_num, block);
738
326
              goto optimize_nop;
739
326
            } else {
740
224
              opline->opcode = ZEND_JMP;
741
224
              COPY_NODE(opline->op1, opline->op2);
742
224
              take_successor_0(ssa, block_num, block);
743
224
              goto optimize_jmp;
744
224
            }
745
15.2k
          } else {
746
15.2k
            if (block->successors[0] == next_block_num && can_follow) {
747
165
              take_successor_0(ssa, block_num, block);
748
165
              if (opline->op1_type == IS_CV && (OP1_INFO() & MAY_BE_UNDEF)) {
749
11
                opline->opcode = ZEND_CHECK_VAR;
750
11
                opline->op2.num = 0;
751
154
              } else if (opline->op1_type == IS_CV || !(OP1_INFO() & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
752
100
                zend_ssa_remove_instr(ssa, opline, ssa_op);
753
100
                removed_ops++;
754
100
                goto optimize_nop;
755
100
              } else {
756
54
                opline->opcode = ZEND_FREE;
757
54
                opline->op2.num = 0;
758
54
              }
759
165
            }
760
15.2k
          }
761
15.1k
          break;
762
18.2k
        case ZEND_JMPNZ:
763
19.4k
optimize_jmpnz:
764
19.4k
          if (opline->op1_type == IS_CONST) {
765
838
            if (zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
766
606
              opline->opcode = ZEND_JMP;
767
606
              COPY_NODE(opline->op1, opline->op2);
768
606
              take_successor_0(ssa, block_num, block);
769
606
              goto optimize_jmp;
770
606
            } else {
771
232
              MAKE_NOP(opline);
772
232
              removed_ops++;
773
232
              take_successor_1(ssa, block_num, block);
774
232
              goto optimize_nop;
775
232
            }
776
18.6k
          } else if (block->successors_count == 2) {
777
18.6k
            if (block->successors[0] == next_block_num && can_follow) {
778
142
              take_successor_0(ssa, block_num, block);
779
142
              if (opline->op1_type == IS_CV && (OP1_INFO() & MAY_BE_UNDEF)) {
780
0
                opline->opcode = ZEND_CHECK_VAR;
781
0
                opline->op2.num = 0;
782
142
              } else if (opline->op1_type == IS_CV || !(OP1_INFO() & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
783
120
                zend_ssa_remove_instr(ssa, opline, ssa_op);
784
120
                removed_ops++;
785
120
                goto optimize_nop;
786
120
              } else {
787
22
                opline->opcode = ZEND_FREE;
788
22
                opline->op2.num = 0;
789
22
              }
790
142
            }
791
18.6k
          }
792
18.5k
          break;
793
18.5k
        case ZEND_JMPZ_EX:
794
1.34k
          if (ssa->vars[ssa_op->result_def].use_chain < 0
795
1.33k
              && ssa->vars[ssa_op->result_def].phi_use_chain == NULL) {
796
456
            opline->opcode = ZEND_JMPZ;
797
456
            opline->result_type = IS_UNUSED;
798
456
            zend_ssa_remove_result_def(ssa, ssa_op);
799
456
            goto optimize_jmpz;
800
884
          } else if (opline->op1_type == IS_CONST) {
801
88
            if (zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
802
62
              opline->opcode = ZEND_BOOL;
803
62
              take_successor_1(ssa, block_num, block);
804
62
            }
805
88
          }
806
884
          break;
807
1.20k
        case ZEND_JMPNZ_EX:
808
1.20k
          if (ssa->vars[ssa_op->result_def].use_chain < 0
809
1.19k
              && ssa->vars[ssa_op->result_def].phi_use_chain == NULL) {
810
136
            opline->opcode = ZEND_JMPNZ;
811
136
            opline->result_type = IS_UNUSED;
812
136
            zend_ssa_remove_result_def(ssa, ssa_op);
813
136
            goto optimize_jmpnz;
814
1.06k
          } else if (opline->op1_type == IS_CONST) {
815
122
            if (!zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
816
0
              opline->opcode = ZEND_BOOL;
817
0
              take_successor_1(ssa, block_num, block);
818
0
            }
819
122
          }
820
1.06k
          break;
821
2.53k
        case ZEND_JMP_SET:
822
2.53k
          if (ssa->vars[ssa_op->result_def].use_chain < 0
823
2.53k
              && ssa->vars[ssa_op->result_def].phi_use_chain == NULL) {
824
1.10k
            opline->opcode = ZEND_JMPNZ;
825
1.10k
            opline->result_type = IS_UNUSED;
826
1.10k
            zend_ssa_remove_result_def(ssa, ssa_op);
827
1.10k
            goto optimize_jmpnz;
828
1.43k
          } else if (opline->op1_type == IS_CONST) {
829
10
            if (!zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
830
10
              MAKE_NOP(opline);
831
10
              removed_ops++;
832
10
              take_successor_1(ssa, block_num, block);
833
10
              zend_ssa_remove_result_def(ssa, ssa_op);
834
10
              goto optimize_nop;
835
10
            }
836
10
          }
837
1.42k
          break;
838
4.81k
        case ZEND_COALESCE:
839
4.81k
        {
840
4.81k
          zend_ssa_var *var = &ssa->vars[ssa_op->result_def];
841
4.81k
          if (opline->op1_type == IS_CONST
842
819
              && var->use_chain < 0 && var->phi_use_chain == NULL) {
843
769
            if (Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op1.constant)) == IS_NULL) {
844
119
              zend_ssa_remove_result_def(ssa, ssa_op);
845
119
              MAKE_NOP(opline);
846
119
              removed_ops++;
847
119
              take_successor_1(ssa, block_num, block);
848
119
              goto optimize_nop;
849
650
            } else {
850
650
              opline->opcode = ZEND_JMP;
851
650
              opline->result_type = IS_UNUSED;
852
650
              zend_ssa_remove_result_def(ssa, ssa_op);
853
650
              COPY_NODE(opline->op1, opline->op2);
854
650
              take_successor_0(ssa, block_num, block);
855
650
              goto optimize_jmp;
856
650
            }
857
769
          }
858
4.05k
          break;
859
4.81k
        }
860
59.2k
        case ZEND_JMP_NULL:
861
59.2k
        {
862
59.2k
          zend_ssa_var *var = &ssa->vars[ssa_op->result_def];
863
59.2k
          if (opline->op1_type == IS_CONST
864
76
              && var->use_chain < 0 && var->phi_use_chain == NULL) {
865
44
            if (Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op1.constant)) == IS_NULL) {
866
12
              opline->opcode = ZEND_JMP;
867
12
              opline->result_type = IS_UNUSED;
868
12
              zend_ssa_remove_result_def(ssa, ssa_op);
869
12
              COPY_NODE(opline->op1, opline->op2);
870
12
              take_successor_0(ssa, block_num, block);
871
12
              goto optimize_jmp;
872
32
            } else {
873
32
              zend_ssa_remove_result_def(ssa, ssa_op);
874
32
              MAKE_NOP(opline);
875
32
              removed_ops++;
876
32
              take_successor_1(ssa, block_num, block);
877
32
              goto optimize_nop;
878
32
            }
879
44
          }
880
59.1k
          break;
881
59.2k
        }
882
59.1k
        case ZEND_SWITCH_LONG:
883
106
        case ZEND_SWITCH_STRING:
884
390
        case ZEND_MATCH:
885
390
          if (opline->op1_type == IS_CONST) {
886
22
            zval *zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
887
22
            uint8_t type = Z_TYPE_P(zv);
888
22
            bool correct_type =
889
22
              (opline->opcode == ZEND_SWITCH_LONG && type == IS_LONG)
890
22
              || (opline->opcode == ZEND_SWITCH_STRING && type == IS_STRING)
891
22
              || (opline->opcode == ZEND_MATCH && (type == IS_LONG || type == IS_STRING));
892
893
            /* Switch statements have a fallback chain for loose comparison. In those
894
             * cases the SWITCH_* instruction is a NOP. Match does strict comparison and
895
             * thus jumps to the default branch on mismatched types, so we need to
896
             * convert MATCH to a jmp. */
897
22
            if (!correct_type && opline->opcode != ZEND_MATCH) {
898
10
              removed_ops++;
899
10
              MAKE_NOP(opline);
900
10
              opline->extended_value = 0;
901
10
              take_successor_ex(ssa, block_num, block, block->successors[block->successors_count - 1]);
902
10
              goto optimize_nop;
903
10
            }
904
905
12
            uint32_t target;
906
12
            if (correct_type) {
907
6
              HashTable *jmptable = Z_ARRVAL_P(CT_CONSTANT_EX(op_array, opline->op2.constant));
908
6
              zval *jmp_zv = type == IS_LONG
909
6
                ? zend_hash_index_find(jmptable, Z_LVAL_P(zv))
910
6
                : zend_hash_find(jmptable, Z_STR_P(zv));
911
912
6
              if (jmp_zv) {
913
2
                target = ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, Z_LVAL_P(jmp_zv));
914
4
              } else {
915
4
                target = ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value);
916
4
              }
917
6
            } else {
918
6
              ZEND_ASSERT(opline->opcode == ZEND_MATCH);
919
6
              target = ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value);
920
6
            }
921
12
            opline->opcode = ZEND_JMP;
922
12
            opline->extended_value = 0;
923
12
            SET_UNUSED(opline->op1);
924
12
            ZEND_SET_OP_JMP_ADDR(opline, opline->op1, op_array->opcodes + target);
925
12
            SET_UNUSED(opline->op2);
926
12
            take_successor_ex(ssa, block_num, block, ssa->cfg.map[target]);
927
12
            goto optimize_jmp;
928
12
          }
929
368
          break;
930
368
        case ZEND_NOP:
931
2.66k
optimize_nop:
932
2.66k
          compress_block(op_array, block);
933
2.66k
          if (block->len == 0) {
934
1.34k
            if (block_num > 0) {
935
1.25k
              zend_ssa_unlink_block(op_array, ssa, block, block_num);
936
              /* backtrack to previous basic block */
937
1.25k
              int backtracking_block_num = block_num;
938
11.9k
              do {
939
11.9k
                backtracking_block_num--;
940
11.9k
              } while (backtracking_block_num >= 0
941
11.9k
                && !(ssa->cfg.blocks[backtracking_block_num].flags & ZEND_BB_REACHABLE));
942
1.25k
              if (backtracking_block_num >= 0) {
943
1.25k
                block_num = backtracking_block_num;
944
1.25k
                continue;
945
1.25k
              }
946
1.25k
            }
947
1.34k
          }
948
1.41k
          break;
949
256k
        default:
950
256k
          break;
951
388k
      }
952
388k
    }
953
954
388k
    block_num = next_block_num;
955
388k
  }
956
957
142k
  return removed_ops;
958
142k
}
959
960
static bool zend_dfa_try_to_replace_result(zend_op_array *op_array, zend_ssa *ssa, int def, int cv_var)
961
12.9k
{
962
12.9k
  int result_var = ssa->ops[def].result_def;
963
12.9k
  uint32_t cv = EX_NUM_TO_VAR(ssa->vars[cv_var].var);
964
965
12.9k
  if (result_var >= 0
966
12.9k
   && !(ssa->var_info[cv_var].type & MAY_BE_REF)
967
7.52k
   && ssa->vars[cv_var].alias == NO_ALIAS
968
7.52k
   && ssa->vars[result_var].phi_use_chain == NULL
969
7.49k
   && ssa->vars[result_var].sym_use_chain == NULL) {
970
7.49k
    int use = ssa->vars[result_var].use_chain;
971
972
7.49k
    if (use >= 0
973
6.98k
     && zend_ssa_next_use(ssa->ops, result_var, use) < 0
974
6.98k
     && op_array->opcodes[use].opcode != ZEND_FREE
975
6.98k
     && op_array->opcodes[use].opcode != ZEND_SEND_VAL
976
6.97k
     && op_array->opcodes[use].opcode != ZEND_SEND_VAL_EX
977
6.96k
     && op_array->opcodes[use].opcode != ZEND_VERIFY_RETURN_TYPE
978
6.95k
     && op_array->opcodes[use].opcode != ZEND_YIELD) {
979
6.94k
      if (use > def) {
980
6.94k
        int i = use;
981
6.94k
        const zend_op *opline = &op_array->opcodes[use];
982
983
13.5k
        while (i > def) {
984
8.00k
          if ((opline->op1_type == IS_CV && opline->op1.var == cv)
985
6.70k
           || (opline->op2_type == IS_CV && opline->op2.var == cv)
986
6.61k
           || (opline->result_type == IS_CV && opline->result.var == cv)) {
987
1.38k
            return false;
988
1.38k
          }
989
6.61k
          opline--;
990
6.61k
          i--;
991
6.61k
        }
992
993
        /* Update opcodes and reconstruct SSA */
994
5.55k
        ssa->vars[result_var].definition = -1;
995
5.55k
        ssa->vars[result_var].use_chain = -1;
996
5.55k
        ssa->ops[def].result_def = -1;
997
998
5.55k
        op_array->opcodes[def].result_type = IS_UNUSED;
999
5.55k
        op_array->opcodes[def].result.var = 0;
1000
1001
5.55k
        if (ssa->ops[use].op1_use == result_var) {
1002
1.80k
          ssa->ops[use].op1_use = cv_var;
1003
1.80k
          ssa->ops[use].op1_use_chain = ssa->vars[cv_var].use_chain;
1004
1.80k
          ssa->vars[cv_var].use_chain = use;
1005
1006
1.80k
          op_array->opcodes[use].op1_type = IS_CV;
1007
1.80k
          op_array->opcodes[use].op1.var = cv;
1008
3.75k
        } else if (ssa->ops[use].op2_use == result_var) {
1009
3.75k
          ssa->ops[use].op2_use = cv_var;
1010
3.75k
          ssa->ops[use].op2_use_chain = ssa->vars[cv_var].use_chain;
1011
3.75k
          ssa->vars[cv_var].use_chain = use;
1012
1013
3.75k
          op_array->opcodes[use].op2_type = IS_CV;
1014
3.75k
          op_array->opcodes[use].op2.var = cv;
1015
3.75k
        } else if (ssa->ops[use].result_use == result_var) {
1016
0
          ssa->ops[use].result_use = cv_var;
1017
0
          ssa->ops[use].res_use_chain = ssa->vars[cv_var].use_chain;
1018
0
          ssa->vars[cv_var].use_chain = use;
1019
1020
0
          op_array->opcodes[use].result_type = IS_CV;
1021
0
          op_array->opcodes[use].result.var = cv;
1022
0
        }
1023
1024
5.55k
        return true;
1025
6.94k
      }
1026
6.94k
    }
1027
7.49k
  }
1028
1029
6.01k
  return false;
1030
12.9k
}
1031
1032
void zend_dfa_optimize_op_array(zend_op_array *op_array, zend_optimizer_ctx *ctx, zend_ssa *ssa, zend_call_info **call_map)
1033
71.2k
{
1034
71.2k
  if (ctx->debug_level & ZEND_DUMP_BEFORE_DFA_PASS) {
1035
0
    zend_dump_op_array(op_array, ZEND_DUMP_SSA, "before dfa pass", ssa);
1036
0
  }
1037
1038
71.2k
  if (ssa->var_info) {
1039
71.2k
    int op_1;
1040
71.2k
    int v;
1041
71.2k
    int remove_nops = 0;
1042
71.2k
    zend_op *opline;
1043
71.2k
    zend_ssa_op *ssa_op;
1044
71.2k
    zval tmp;
1045
1046
71.2k
#if ZEND_DEBUG_DFA
1047
71.2k
    ssa_verify_integrity(op_array, ssa, "before dfa");
1048
71.2k
#endif
1049
1050
71.2k
    if (ZEND_OPTIMIZER_PASS_8 & ctx->optimization_level) {
1051
71.2k
      if (sccp_optimize_op_array(ctx, op_array, ssa, call_map)) {
1052
1.52k
        remove_nops = 1;
1053
1.52k
      }
1054
1055
71.2k
      if (zend_dfa_optimize_jmps(op_array, ssa)) {
1056
610
        remove_nops = 1;
1057
610
      }
1058
1059
71.2k
#if ZEND_DEBUG_DFA
1060
71.2k
      ssa_verify_integrity(op_array, ssa, "after sccp");
1061
71.2k
#endif
1062
71.2k
      if (ZEND_FUNC_INFO(op_array)) {
1063
71.2k
        if (zend_dfa_optimize_calls(op_array, ssa)) {
1064
0
          remove_nops = 1;
1065
0
        }
1066
71.2k
      }
1067
71.2k
      if (ctx->debug_level & ZEND_DUMP_AFTER_PASS_8) {
1068
0
        zend_dump_op_array(op_array, ZEND_DUMP_SSA, "after sccp pass", ssa);
1069
0
      }
1070
71.2k
#if ZEND_DEBUG_DFA
1071
71.2k
      ssa_verify_integrity(op_array, ssa, "after calls");
1072
71.2k
#endif
1073
71.2k
    }
1074
1075
71.2k
    if (ZEND_OPTIMIZER_PASS_14 & ctx->optimization_level) {
1076
71.2k
      if (dce_optimize_op_array(op_array, ctx, ssa, 0)) {
1077
5.75k
        remove_nops = 1;
1078
5.75k
      }
1079
71.2k
      if (zend_dfa_optimize_jmps(op_array, ssa)) {
1080
281
        remove_nops = 1;
1081
281
      }
1082
71.2k
      if (ctx->debug_level & ZEND_DUMP_AFTER_PASS_14) {
1083
0
        zend_dump_op_array(op_array, ZEND_DUMP_SSA, "after dce pass", ssa);
1084
0
      }
1085
71.2k
#if ZEND_DEBUG_DFA
1086
71.2k
      ssa_verify_integrity(op_array, ssa, "after dce");
1087
71.2k
#endif
1088
71.2k
    }
1089
1090
1.07M
    for (v = op_array->last_var; v < ssa->vars_count; v++) {
1091
1092
1.00M
      op_1 = ssa->vars[v].definition;
1093
1094
1.00M
      if (op_1 < 0) {
1095
172k
        continue;
1096
172k
      }
1097
1098
830k
      opline = op_array->opcodes + op_1;
1099
830k
      ssa_op = &ssa->ops[op_1];
1100
1101
      /* Convert LONG constants to DOUBLE */
1102
830k
      if (ssa->var_info[v].use_as_double) {
1103
2
        if (opline->opcode == ZEND_ASSIGN
1104
2
         && opline->op2_type == IS_CONST
1105
2
         && ssa->ops[op_1].op1_def == v
1106
2
         && !RETURN_VALUE_USED(opline)
1107
2
        ) {
1108
1109
// op_1: ASSIGN ? -> #v [use_as_double], long(?) => ASSIGN ? -> #v, double(?)
1110
1111
2
          zval *zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1112
2
          ZEND_ASSERT(Z_TYPE_INFO_P(zv) == IS_LONG);
1113
2
          ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1114
2
          opline->op2.constant = zend_optimizer_add_literal(op_array, &tmp);
1115
1116
2
        } else if (opline->opcode == ZEND_QM_ASSIGN
1117
0
         && opline->op1_type == IS_CONST
1118
0
        ) {
1119
1120
// op_1: QM_ASSIGN #v [use_as_double], long(?) => QM_ASSIGN #v, double(?)
1121
1122
0
          zval *zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1123
0
          ZEND_ASSERT(Z_TYPE_INFO_P(zv) == IS_LONG);
1124
0
          ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1125
0
          opline->op1.constant = zend_optimizer_add_literal(op_array, &tmp);
1126
0
        }
1127
1128
830k
      } else {
1129
830k
        if (opline->opcode == ZEND_ADD
1130
823k
         || opline->opcode == ZEND_SUB
1131
817k
         || opline->opcode == ZEND_MUL
1132
811k
         || opline->opcode == ZEND_IS_EQUAL
1133
808k
         || opline->opcode == ZEND_IS_NOT_EQUAL
1134
805k
         || opline->opcode == ZEND_IS_SMALLER
1135
798k
         || opline->opcode == ZEND_IS_SMALLER_OR_EQUAL
1136
830k
        ) {
1137
1138
35.0k
          if (opline->op1_type == IS_CONST && opline->op2_type != IS_CONST) {
1139
3.85k
            zval *zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1140
1141
3.85k
            if ((OP2_INFO() & MAY_BE_ANY) == MAY_BE_DOUBLE
1142
38
             && Z_TYPE_INFO_P(zv) == IS_LONG) {
1143
1144
// op_1: #v.? = ADD long(?), #?.? [double] => #v.? = ADD double(?), #?.? [double]
1145
1146
14
              ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1147
14
              opline->op1.constant = zend_optimizer_add_literal(op_array, &tmp);
1148
14
              zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1149
14
            }
1150
3.85k
            if (opline->opcode == ZEND_ADD) {
1151
754
              zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1152
1153
754
              if (((OP2_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_LONG
1154
101
                && Z_TYPE_INFO_P(zv) == IS_LONG
1155
43
                && Z_LVAL_P(zv) == 0)
1156
754
               || ((OP2_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_DOUBLE
1157
16
                && Z_TYPE_INFO_P(zv) == IS_DOUBLE
1158
0
                && Z_DVAL_P(zv) == 0.0)) {
1159
1160
// op_1: #v.? = ADD 0, #?.? [double,long] => #v.? = QM_ASSIGN #?.?
1161
1162
0
                opline->opcode = ZEND_QM_ASSIGN;
1163
0
                opline->op1_type = opline->op2_type;
1164
0
                opline->op1.var = opline->op2.var;
1165
0
                opline->op2_type = IS_UNUSED;
1166
0
                opline->op2.num = 0;
1167
0
                ssa->ops[op_1].op1_use = ssa->ops[op_1].op2_use;
1168
0
                ssa->ops[op_1].op1_use_chain = ssa->ops[op_1].op2_use_chain;
1169
0
                ssa->ops[op_1].op2_use = -1;
1170
0
                ssa->ops[op_1].op2_use_chain = -1;
1171
0
              }
1172
3.10k
            } else if (opline->opcode == ZEND_MUL
1173
20
             && (OP2_INFO() & ((MAY_BE_ANY|MAY_BE_UNDEF)-(MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1174
0
              zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1175
1176
0
              if ((Z_TYPE_INFO_P(zv) == IS_LONG
1177
0
                && Z_LVAL_P(zv) == 2)
1178
0
               || (Z_TYPE_INFO_P(zv) == IS_DOUBLE
1179
0
                && Z_DVAL_P(zv) == 2.0
1180
0
                && !(OP2_INFO() & MAY_BE_LONG))) {
1181
1182
// op_1: #v.? = MUL 2, #x.? [double,long] => #v.? = ADD #x.?, #x.?
1183
1184
0
                opline->opcode = ZEND_ADD;
1185
0
                opline->op1_type = opline->op2_type;
1186
0
                opline->op1.var = opline->op2.var;
1187
0
                ssa->ops[op_1].op1_use = ssa->ops[op_1].op2_use;
1188
0
                ssa->ops[op_1].op1_use_chain = ssa->ops[op_1].op2_use_chain;
1189
0
              }
1190
0
            }
1191
31.2k
          } else if (opline->op1_type != IS_CONST && opline->op2_type == IS_CONST) {
1192
13.4k
            zval *zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1193
1194
13.4k
            if ((OP1_INFO() & MAY_BE_ANY) == MAY_BE_DOUBLE
1195
274
             && Z_TYPE_INFO_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == IS_LONG) {
1196
1197
// op_1: #v.? = ADD #?.? [double], long(?) => #v.? = ADD #?.? [double], double(?)
1198
1199
130
              ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1200
130
              opline->op2.constant = zend_optimizer_add_literal(op_array, &tmp);
1201
130
              zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1202
130
            }
1203
13.4k
            if (opline->opcode == ZEND_ADD || opline->opcode == ZEND_SUB) {
1204
3.36k
              if (((OP1_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_LONG
1205
902
                && Z_TYPE_INFO_P(zv) == IS_LONG
1206
874
                && Z_LVAL_P(zv) == 0)
1207
3.35k
               || ((OP1_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_DOUBLE
1208
67
                && Z_TYPE_INFO_P(zv) == IS_DOUBLE
1209
37
                && Z_DVAL_P(zv) == 0.0)) {
1210
1211
// op_1: #v.? = ADD #?.? [double,long], 0 => #v.? = QM_ASSIGN #?.?
1212
1213
18
                opline->opcode = ZEND_QM_ASSIGN;
1214
18
                opline->op2_type = IS_UNUSED;
1215
18
                opline->op2.num = 0;
1216
18
              }
1217
10.0k
            } else if (opline->opcode == ZEND_MUL
1218
2.78k
             && (OP1_INFO() & ((MAY_BE_ANY|MAY_BE_UNDEF)-(MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1219
803
              zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1220
1221
803
              if ((Z_TYPE_INFO_P(zv) == IS_LONG
1222
619
                && Z_LVAL_P(zv) == 2)
1223
739
               || (Z_TYPE_INFO_P(zv) == IS_DOUBLE
1224
53
                && Z_DVAL_P(zv) == 2.0
1225
68
                && !(OP1_INFO() & MAY_BE_LONG))) {
1226
1227
// op_1: #v.? = MUL #x.? [double,long], 2 => #v.? = ADD #x.?, #x.?
1228
1229
68
                opline->opcode = ZEND_ADD;
1230
68
                opline->op2_type = opline->op1_type;
1231
68
                opline->op2.var = opline->op1.var;
1232
68
                ssa->ops[op_1].op2_use = ssa->ops[op_1].op1_use;
1233
68
                ssa->ops[op_1].op2_use_chain = ssa->ops[op_1].op1_use_chain;
1234
68
              }
1235
803
            }
1236
13.4k
          }
1237
795k
        } else if (opline->opcode == ZEND_CONCAT) {
1238
8.32k
          if (!(OP1_INFO() & MAY_BE_OBJECT)
1239
5.74k
           && !(OP2_INFO() & MAY_BE_OBJECT)) {
1240
4.31k
            opline->opcode = ZEND_FAST_CONCAT;
1241
4.31k
          }
1242
787k
        } else if (opline->opcode == ZEND_VERIFY_RETURN_TYPE
1243
1.91k
         && opline->op1_type != IS_CONST
1244
1.77k
         && ssa->ops[op_1].op1_def == v
1245
1.77k
         && ssa->ops[op_1].op1_use >= 0) {
1246
1.77k
          int orig_var = ssa->ops[op_1].op1_use;
1247
1.77k
          int ret = ssa->vars[v].use_chain;
1248
1249
1.77k
          if (ssa->ops[op_1].op1_use_chain == -1
1250
1.73k
           && can_elide_return_type_check(ctx->script, op_array, ssa, &ssa->ops[op_1])) {
1251
1252
// op_1: VERIFY_RETURN_TYPE #orig_var.? [T] -> #v.? [T] => NOP
1253
1254
858
            zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1255
1256
858
            if (ret >= 0) {
1257
858
              ssa->ops[ret].op1_use = orig_var;
1258
858
              ssa->ops[ret].op1_use_chain = ssa->vars[orig_var].use_chain;
1259
858
              ssa->vars[orig_var].use_chain = ret;
1260
858
            }
1261
1262
858
            ssa->vars[v].definition = -1;
1263
858
            ssa->vars[v].use_chain = -1;
1264
1265
858
            ssa->ops[op_1].op1_def = -1;
1266
858
            ssa->ops[op_1].op1_use = -1;
1267
1268
858
            MAKE_NOP(opline);
1269
858
            remove_nops = 1;
1270
916
          } else if (ret >= 0
1271
916
           && ssa->ops[ret].op1_use == v
1272
916
           && ssa->ops[ret].op1_use_chain == -1
1273
916
           && can_elide_return_type_check(ctx->script, op_array, ssa, &ssa->ops[op_1])) {
1274
1275
// op_1: VERIFY_RETURN_TYPE #orig_var.? [T] -> #v.? [T] => NOP
1276
1277
30
            zend_ssa_replace_use_chain(ssa, op_1, ret, orig_var);
1278
1279
30
            ssa->ops[ret].op1_use = orig_var;
1280
30
            ssa->ops[ret].op1_use_chain = ssa->ops[op_1].op1_use_chain;
1281
1282
30
            ssa->vars[v].definition = -1;
1283
30
            ssa->vars[v].use_chain = -1;
1284
1285
30
            ssa->ops[op_1].op1_def = -1;
1286
30
            ssa->ops[op_1].op1_use = -1;
1287
1288
30
            MAKE_NOP(opline);
1289
30
            remove_nops = 1;
1290
30
          }
1291
1.77k
        }
1292
830k
      }
1293
1294
830k
      if (opline->opcode == ZEND_QM_ASSIGN
1295
7.33k
       && ssa->ops[op_1].result_def == v
1296
7.33k
       && opline->op1_type & (IS_TMP_VAR|IS_VAR)
1297
925
       && !(ssa->var_info[v].type & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
1298
830k
      ) {
1299
1300
120
        int src_var = ssa->ops[op_1].op1_use;
1301
1302
120
        if (src_var >= 0
1303
120
         && !(ssa->var_info[src_var].type & MAY_BE_REF)
1304
120
         && (ssa->var_info[src_var].type & (MAY_BE_UNDEF|MAY_BE_ANY))
1305
116
         && ssa->vars[src_var].definition >= 0
1306
14
         && ssa->ops[ssa->vars[src_var].definition].result_def == src_var
1307
14
         && ssa->ops[ssa->vars[src_var].definition].result_use < 0
1308
14
         && ssa->vars[src_var].use_chain == op_1
1309
14
         && ssa->ops[op_1].op1_use_chain < 0
1310
14
         && !ssa->vars[src_var].phi_use_chain
1311
14
         && !ssa->vars[src_var].sym_use_chain
1312
14
         && opline_supports_assign_contraction(
1313
14
           op_array, ssa, &op_array->opcodes[ssa->vars[src_var].definition],
1314
14
           src_var, opline->result.var)
1315
14
         && !variable_defined_or_used_in_range(ssa, EX_VAR_TO_NUM(opline->result.var),
1316
14
            ssa->vars[src_var].definition+1, op_1)
1317
120
        ) {
1318
1319
14
          int orig_var = ssa->ops[op_1].result_use;
1320
14
          int op_2 = ssa->vars[src_var].definition;
1321
1322
// op_2: #src_var.T = OP ...                                        => #v.CV = OP ...
1323
// op_1: QM_ASSIGN #src_var.T #orig_var.CV [undef,scalar] -> #v.CV,    NOP
1324
1325
14
          if (orig_var >= 0) {
1326
0
            zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1327
0
          }
1328
1329
          /* Reconstruct SSA */
1330
14
          ssa->vars[v].definition = op_2;
1331
14
          ssa->ops[op_2].result_def = v;
1332
1333
14
          ssa->vars[src_var].definition = -1;
1334
14
          ssa->vars[src_var].use_chain = -1;
1335
1336
14
          ssa->ops[op_1].op1_use = -1;
1337
14
          ssa->ops[op_1].op1_def = -1;
1338
14
          ssa->ops[op_1].op1_use_chain = -1;
1339
14
          ssa->ops[op_1].result_use = -1;
1340
14
          ssa->ops[op_1].result_def = -1;
1341
14
          ssa->ops[op_1].res_use_chain = -1;
1342
1343
          /* Update opcodes */
1344
14
          op_array->opcodes[op_2].result_type = opline->result_type;
1345
14
          op_array->opcodes[op_2].result.var = opline->result.var;
1346
1347
14
          MAKE_NOP(opline);
1348
14
          remove_nops = 1;
1349
1350
14
          if (op_array->opcodes[op_2].opcode == ZEND_SUB
1351
2
           && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1352
2
           && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1353
0
           && op_array->opcodes[op_2].op2_type == IS_CONST
1354
0
           && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1355
0
           && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1356
0
           && ssa->ops[op_2].op1_use >= 0
1357
0
           && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1358
1359
0
            op_array->opcodes[op_2].opcode = ZEND_PRE_DEC;
1360
0
            SET_UNUSED(op_array->opcodes[op_2].op2);
1361
0
            SET_UNUSED(op_array->opcodes[op_2].result);
1362
1363
0
            ssa->ops[op_2].result_def = -1;
1364
0
            ssa->ops[op_2].op1_def = v;
1365
1366
14
          } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1367
0
           && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1368
0
           && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1369
0
           && op_array->opcodes[op_2].op2_type == IS_CONST
1370
0
           && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1371
0
           && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1372
0
           && ssa->ops[op_2].op1_use >= 0
1373
0
           && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1374
1375
0
            op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1376
0
            SET_UNUSED(op_array->opcodes[op_2].op2);
1377
0
            SET_UNUSED(op_array->opcodes[op_2].result);
1378
1379
0
            ssa->ops[op_2].result_def = -1;
1380
0
            ssa->ops[op_2].op1_def = v;
1381
1382
14
          } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1383
0
           && op_array->opcodes[op_2].op2_type == op_array->opcodes[op_2].result_type
1384
0
           && op_array->opcodes[op_2].op2.var == op_array->opcodes[op_2].result.var
1385
0
           && op_array->opcodes[op_2].op1_type == IS_CONST
1386
0
           && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == IS_LONG
1387
0
           && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == 1
1388
0
           && ssa->ops[op_2].op2_use >= 0
1389
0
           && !(ssa->var_info[ssa->ops[op_2].op2_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1390
1391
0
            op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1392
0
            op_array->opcodes[op_2].op1_type = op_array->opcodes[op_2].op2_type;
1393
0
            op_array->opcodes[op_2].op1.var = op_array->opcodes[op_2].op2.var;
1394
0
            SET_UNUSED(op_array->opcodes[op_2].op2);
1395
0
            SET_UNUSED(op_array->opcodes[op_2].result);
1396
1397
0
            ssa->ops[op_2].result_def = -1;
1398
0
            ssa->ops[op_2].op1_def = v;
1399
0
            ssa->ops[op_2].op1_use = ssa->ops[op_2].op2_use;
1400
0
            ssa->ops[op_2].op1_use_chain = ssa->ops[op_2].op2_use_chain;
1401
0
            ssa->ops[op_2].op2_use = -1;
1402
0
            ssa->ops[op_2].op2_use_chain = -1;
1403
0
          }
1404
14
        }
1405
120
      }
1406
1407
830k
      if (ssa->vars[v].var >= op_array->last_var) {
1408
        /* skip TMP and VAR */
1409
692k
        continue;
1410
692k
      }
1411
1412
138k
      if (ssa->ops[op_1].op1_def == v
1413
108k
       && RETURN_VALUE_USED(opline)) {
1414
22.9k
        if (opline->opcode == ZEND_ASSIGN
1415
12.7k
         || opline->opcode == ZEND_ASSIGN_OP
1416
10.8k
         || opline->opcode == ZEND_PRE_INC
1417
12.9k
         || opline->opcode == ZEND_PRE_DEC) {
1418
12.9k
          zend_dfa_try_to_replace_result(op_array, ssa, op_1, v);
1419
12.9k
        } else if (opline->opcode == ZEND_POST_INC) {
1420
948
          int result_var = ssa->ops[op_1].result_def;
1421
1422
948
          if (result_var >= 0
1423
948
           && (ssa->var_info[result_var].type & ((MAY_BE_ANY|MAY_BE_REF|MAY_BE_UNDEF) - (MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1424
456
            int use = ssa->vars[result_var].use_chain;
1425
1426
456
            if (use >= 0 && op_array->opcodes[use].opcode == ZEND_IS_SMALLER
1427
48
             && ssa->ops[use].op1_use == result_var
1428
48
             && zend_dfa_try_to_replace_result(op_array, ssa, op_1, v)) {
1429
48
              opline->opcode = ZEND_PRE_INC;
1430
48
              op_array->opcodes[use].opcode = ZEND_IS_SMALLER_OR_EQUAL;
1431
48
            }
1432
456
          }
1433
9.10k
        } else if (opline->opcode == ZEND_POST_DEC) {
1434
1.17k
          int result_var = ssa->ops[op_1].result_def;
1435
1436
1.17k
          if (result_var >= 0
1437
1.17k
           && (ssa->var_info[result_var].type & ((MAY_BE_ANY|MAY_BE_REF|MAY_BE_UNDEF) - (MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1438
475
            int use = ssa->vars[result_var].use_chain;
1439
1440
475
            if (use >= 0 && op_array->opcodes[use].opcode == ZEND_IS_SMALLER
1441
3
             && ssa->ops[use].op2_use == result_var
1442
3
             && zend_dfa_try_to_replace_result(op_array, ssa, op_1, v)) {
1443
3
              opline->opcode = ZEND_PRE_DEC;
1444
3
              op_array->opcodes[use].opcode = ZEND_IS_SMALLER_OR_EQUAL;
1445
3
            }
1446
475
          }
1447
1.17k
        }
1448
22.9k
      }
1449
1450
138k
      if (opline->opcode == ZEND_ASSIGN
1451
56.4k
       && ssa->ops[op_1].op1_def == v
1452
56.4k
       && !RETURN_VALUE_USED(opline)
1453
138k
      ) {
1454
50.5k
        int orig_var = ssa->ops[op_1].op1_use;
1455
1456
50.5k
        if (orig_var >= 0
1457
50.4k
         && !(ssa->var_info[orig_var].type & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
1458
50.5k
        ) {
1459
11.6k
          int src_var = ssa->ops[op_1].op2_use;
1460
1461
11.6k
          if ((opline->op2_type & (IS_TMP_VAR|IS_VAR))
1462
6.49k
           && src_var >= 0
1463
6.49k
           && !(ssa->var_info[src_var].type & MAY_BE_REF)
1464
6.48k
           && (ssa->var_info[src_var].type & (MAY_BE_UNDEF|MAY_BE_ANY))
1465
6.38k
           && ssa->vars[src_var].definition >= 0
1466
6.03k
           && ssa->ops[ssa->vars[src_var].definition].result_def == src_var
1467
6.03k
           && ssa->ops[ssa->vars[src_var].definition].result_use < 0
1468
5.97k
           && ssa->vars[src_var].use_chain == op_1
1469
5.88k
           && ssa->ops[op_1].op2_use_chain < 0
1470
5.88k
           && !ssa->vars[src_var].phi_use_chain
1471
5.88k
           && !ssa->vars[src_var].sym_use_chain
1472
5.88k
           && opline_supports_assign_contraction(
1473
5.88k
             op_array, ssa, &op_array->opcodes[ssa->vars[src_var].definition],
1474
5.88k
             src_var, opline->op1.var)
1475
4.10k
           && !variable_defined_or_used_in_range(ssa, EX_VAR_TO_NUM(opline->op1.var),
1476
4.10k
              ssa->vars[src_var].definition+1, op_1)
1477
11.6k
          ) {
1478
1479
4.10k
            int op_2 = ssa->vars[src_var].definition;
1480
1481
// op_2: #src_var.T = OP ...                                     => #v.CV = OP ...
1482
// op_1: ASSIGN #orig_var.CV [undef,scalar] -> #v.CV, #src_var.T    NOP
1483
1484
4.10k
            zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1485
            /* Reconstruct SSA */
1486
4.10k
            ssa->vars[v].definition = op_2;
1487
4.10k
            ssa->ops[op_2].result_def = v;
1488
1489
4.10k
            ssa->vars[src_var].definition = -1;
1490
4.10k
            ssa->vars[src_var].use_chain = -1;
1491
1492
4.10k
            ssa->ops[op_1].op1_use = -1;
1493
4.10k
            ssa->ops[op_1].op2_use = -1;
1494
4.10k
            ssa->ops[op_1].op1_def = -1;
1495
4.10k
            ssa->ops[op_1].op1_use_chain = -1;
1496
1497
            /* Update opcodes */
1498
4.10k
            op_array->opcodes[op_2].result_type = opline->op1_type;
1499
4.10k
            op_array->opcodes[op_2].result.var = opline->op1.var;
1500
1501
4.10k
            MAKE_NOP(opline);
1502
4.10k
            remove_nops = 1;
1503
1504
4.10k
            if (op_array->opcodes[op_2].opcode == ZEND_SUB
1505
388
             && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1506
205
             && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1507
24
             && op_array->opcodes[op_2].op2_type == IS_CONST
1508
4
             && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1509
4
             && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1510
0
             && ssa->ops[op_2].op1_use >= 0
1511
0
             && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1512
1513
0
              op_array->opcodes[op_2].opcode = ZEND_PRE_DEC;
1514
0
              SET_UNUSED(op_array->opcodes[op_2].op2);
1515
0
              SET_UNUSED(op_array->opcodes[op_2].result);
1516
1517
0
              ssa->ops[op_2].result_def = -1;
1518
0
              ssa->ops[op_2].op1_def = v;
1519
1520
4.10k
            } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1521
1.60k
             && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1522
884
             && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1523
556
             && op_array->opcodes[op_2].op2_type == IS_CONST
1524
42
             && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1525
10
             && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1526
0
             && ssa->ops[op_2].op1_use >= 0
1527
0
             && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1528
1529
0
              op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1530
0
              SET_UNUSED(op_array->opcodes[op_2].op2);
1531
0
              SET_UNUSED(op_array->opcodes[op_2].result);
1532
1533
0
              ssa->ops[op_2].result_def = -1;
1534
0
              ssa->ops[op_2].op1_def = v;
1535
1536
4.10k
            } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1537
1.60k
             && op_array->opcodes[op_2].op2_type == op_array->opcodes[op_2].result_type
1538
945
             && op_array->opcodes[op_2].op2.var == op_array->opcodes[op_2].result.var
1539
214
             && op_array->opcodes[op_2].op1_type == IS_CONST
1540
4
             && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == IS_LONG
1541
0
             && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == 1
1542
0
             && ssa->ops[op_2].op2_use >= 0
1543
0
             && !(ssa->var_info[ssa->ops[op_2].op2_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1544
1545
0
              op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1546
0
              op_array->opcodes[op_2].op1_type = op_array->opcodes[op_2].op2_type;
1547
0
              op_array->opcodes[op_2].op1.var = op_array->opcodes[op_2].op2.var;
1548
0
              SET_UNUSED(op_array->opcodes[op_2].op2);
1549
0
              SET_UNUSED(op_array->opcodes[op_2].result);
1550
1551
0
              ssa->ops[op_2].result_def = -1;
1552
0
              ssa->ops[op_2].op1_def = v;
1553
0
              ssa->ops[op_2].op1_use = ssa->ops[op_2].op2_use;
1554
0
              ssa->ops[op_2].op1_use_chain = ssa->ops[op_2].op2_use_chain;
1555
0
              ssa->ops[op_2].op2_use = -1;
1556
0
              ssa->ops[op_2].op2_use_chain = -1;
1557
0
            }
1558
7.49k
          } else if (opline->op2_type == IS_CONST
1559
3.75k
           || ((opline->op2_type & (IS_TMP_VAR|IS_VAR|IS_CV))
1560
3.75k
               && ssa->ops[op_1].op2_use >= 0
1561
3.75k
               && ssa->ops[op_1].op2_def < 0)
1562
7.49k
          ) {
1563
1564
// op_1: ASSIGN #orig_var.CV [undef,scalar] -> #v.CV, CONST|TMPVAR => QM_ASSIGN v.CV, CONST|TMPVAR
1565
1566
7.49k
            if (ssa->ops[op_1].op1_use != ssa->ops[op_1].op2_use) {
1567
7.28k
              zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1568
7.28k
            } else {
1569
204
              ssa->ops[op_1].op2_use_chain = ssa->ops[op_1].op1_use_chain;
1570
204
            }
1571
1572
            /* Reconstruct SSA */
1573
7.49k
            ssa->ops[op_1].result_def = v;
1574
7.49k
            ssa->ops[op_1].op1_def = -1;
1575
7.49k
            ssa->ops[op_1].op1_use = ssa->ops[op_1].op2_use;
1576
7.49k
            ssa->ops[op_1].op1_use_chain = ssa->ops[op_1].op2_use_chain;
1577
7.49k
            ssa->ops[op_1].op2_use = -1;
1578
7.49k
            ssa->ops[op_1].op2_use_chain = -1;
1579
1580
            /* Update opcode */
1581
7.49k
            opline->result_type = opline->op1_type;
1582
7.49k
            opline->result.var = opline->op1.var;
1583
7.49k
            opline->op1_type = opline->op2_type;
1584
7.49k
            opline->op1.var = opline->op2.var;
1585
7.49k
            opline->op2_type = IS_UNUSED;
1586
7.49k
            opline->op2.var = 0;
1587
7.49k
            opline->opcode = ZEND_QM_ASSIGN;
1588
7.49k
          }
1589
11.6k
        }
1590
1591
88.0k
      } else if (opline->opcode == ZEND_ASSIGN_OP
1592
5.05k
       && opline->extended_value == ZEND_ADD
1593
1.23k
       && ssa->ops[op_1].op1_def == v
1594
1.23k
       && opline->op2_type == IS_CONST
1595
208
       && Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == IS_LONG
1596
182
       && Z_LVAL_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == 1
1597
76
       && ssa->ops[op_1].op1_use >= 0
1598
76
       && !(ssa->var_info[ssa->ops[op_1].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1599
1600
// op_1: ASSIGN_ADD #?.CV [undef,null,int,foat] ->#v.CV, int(1) => PRE_INC #?.CV ->#v.CV
1601
1602
11
        opline->opcode = ZEND_PRE_INC;
1603
11
        opline->extended_value = 0;
1604
11
        SET_UNUSED(opline->op2);
1605
1606
88.0k
      } else if (opline->opcode == ZEND_ASSIGN_OP
1607
5.04k
       && opline->extended_value == ZEND_SUB
1608
296
       && ssa->ops[op_1].op1_def == v
1609
296
       && opline->op2_type == IS_CONST
1610
166
       && Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == IS_LONG
1611
147
       && Z_LVAL_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == 1
1612
4
       && ssa->ops[op_1].op1_use >= 0
1613
4
       && !(ssa->var_info[ssa->ops[op_1].op1_use].type & (MAY_BE_UNDEF|MAY_BE_NULL|MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1614
1615
// op_1: ASSIGN_SUB #?.CV [undef,null,int,foat] -> #v.CV, int(1) => PRE_DEC #?.CV ->#v.CV
1616
1617
0
        opline->opcode = ZEND_PRE_DEC;
1618
0
        opline->extended_value = 0;
1619
0
        SET_UNUSED(opline->op2);
1620
1621
88.0k
      } else if (ssa->ops[op_1].op1_def == v
1622
57.6k
       && !RETURN_VALUE_USED(opline)
1623
40.2k
       && ssa->ops[op_1].op1_use >= 0
1624
40.2k
       && !(ssa->var_info[ssa->ops[op_1].op1_use].type & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
1625
14.7k
       && opline->opcode == ZEND_ASSIGN_OP
1626
1.85k
       && opline->extended_value != ZEND_CONCAT) {
1627
1628
// op_1: ASSIGN_OP #orig_var.CV [undef,null,bool,int,double] -> #v.CV, ? => #v.CV = ADD #orig_var.CV, ?
1629
1630
        /* Reconstruct SSA */
1631
1.59k
        ssa->ops[op_1].result_def = ssa->ops[op_1].op1_def;
1632
1.59k
        ssa->ops[op_1].op1_def = -1;
1633
1634
        /* Update opcode */
1635
1.59k
        opline->opcode = opline->extended_value;
1636
1.59k
        opline->extended_value = 0;
1637
1.59k
        opline->result_type = opline->op1_type;
1638
1.59k
        opline->result.var = opline->op1.var;
1639
1640
1.59k
      }
1641
138k
    }
1642
1643
71.2k
#if ZEND_DEBUG_DFA
1644
71.2k
    ssa_verify_integrity(op_array, ssa, "after dfa");
1645
71.2k
#endif
1646
1647
71.2k
    if (remove_nops) {
1648
7.81k
      zend_ssa_remove_nops(op_array, ssa, ctx);
1649
7.81k
#if ZEND_DEBUG_DFA
1650
7.81k
      ssa_verify_integrity(op_array, ssa, "after nop");
1651
7.81k
#endif
1652
7.81k
    }
1653
71.2k
  }
1654
1655
71.2k
  if (ctx->debug_level & ZEND_DUMP_AFTER_DFA_PASS) {
1656
0
    zend_dump_op_array(op_array, ZEND_DUMP_SSA, "after dfa pass", ssa);
1657
0
  }
1658
71.2k
}
1659
1660
void zend_optimize_dfa(zend_op_array *op_array, zend_optimizer_ctx *ctx)
1661
0
{
1662
0
  void *checkpoint = zend_arena_checkpoint(ctx->arena);
1663
0
  zend_ssa ssa;
1664
1665
0
  if (zend_dfa_analyze_op_array(op_array, ctx, &ssa) == FAILURE) {
1666
0
    zend_arena_release(&ctx->arena, checkpoint);
1667
0
    return;
1668
0
  }
1669
1670
0
  zend_dfa_optimize_op_array(op_array, ctx, &ssa, NULL);
1671
1672
  /* Destroy SSA */
1673
0
  zend_arena_release(&ctx->arena, checkpoint);
1674
0
}