Coverage Report

Created: 2026-10-28 06:20

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/src/php-src/Zend/Optimizer/dfa_pass.c
Line
Count
Source
1
/*
2
   +----------------------------------------------------------------------+
3
   | Zend OPcache                                                         |
4
   +----------------------------------------------------------------------+
5
   | Copyright © The PHP Group and Contributors.                          |
6
   +----------------------------------------------------------------------+
7
   | This source file is subject to the Modified BSD License that is      |
8
   | bundled with this package in the file LICENSE, and is available      |
9
   | through the World Wide Web at <https://www.php.net/license/>.        |
10
   |                                                                      |
11
   | SPDX-License-Identifier: BSD-3-Clause                                |
12
   +----------------------------------------------------------------------+
13
   | Authors: Dmitry Stogov <dmitry@php.net>                              |
14
   +----------------------------------------------------------------------+
15
*/
16
17
#include "Optimizer/zend_optimizer.h"
18
#include "Optimizer/zend_optimizer_internal.h"
19
#include "zend_API.h"
20
#include "zend_constants.h"
21
#include "zend_execute.h"
22
#include "zend_vm.h"
23
#include "zend_bitset.h"
24
#include "zend_cfg.h"
25
#include "zend_ssa.h"
26
#include "zend_func_info.h"
27
#include "zend_call_graph.h"
28
#include "zend_inference.h"
29
#include "zend_dump.h"
30
31
#ifndef ZEND_DEBUG_DFA
32
# define ZEND_DEBUG_DFA ZEND_DEBUG
33
#endif
34
35
#if ZEND_DEBUG_DFA
36
# include "ssa_integrity.c"
37
#endif
38
39
zend_result zend_dfa_analyze_op_array(zend_op_array *op_array, zend_optimizer_ctx *ctx, zend_ssa *ssa)
40
25.9k
{
41
25.9k
  uint32_t build_flags;
42
43
25.9k
  if (op_array->last_try_catch) {
44
    /* TODO: we can't analyze functions with try/catch/finally ??? */
45
0
    return FAILURE;
46
0
  }
47
48
    /* Build SSA */
49
25.9k
  memset(ssa, 0, sizeof(zend_ssa));
50
51
25.9k
  zend_build_cfg(&ctx->arena, op_array, ZEND_CFG_NO_ENTRY_PREDECESSORS, &ssa->cfg);
52
53
25.9k
  if ((ssa->cfg.flags & ZEND_FUNC_INDIRECT_VAR_ACCESS)) {
54
    /* TODO: we can't analyze functions with indirect variable access ??? */
55
1.19k
    return FAILURE;
56
1.19k
  }
57
58
24.7k
  zend_cfg_build_predecessors(&ctx->arena, &ssa->cfg);
59
60
24.7k
  if (ctx->debug_level & ZEND_DUMP_DFA_CFG) {
61
0
    zend_dump_op_array(op_array, ZEND_DUMP_CFG, "dfa cfg", &ssa->cfg);
62
0
  }
63
64
  /* Compute Dominators Tree */
65
24.7k
  zend_cfg_compute_dominators_tree(op_array, &ssa->cfg);
66
67
  /* Identify reducible and irreducible loops */
68
24.7k
  zend_cfg_identify_loops(op_array, &ssa->cfg);
69
70
24.7k
  if (ctx->debug_level & ZEND_DUMP_DFA_DOMINATORS) {
71
0
    zend_dump_dominators(op_array, &ssa->cfg);
72
0
  }
73
74
24.7k
  build_flags = 0;
75
24.7k
  if (ctx->debug_level & ZEND_DUMP_DFA_LIVENESS) {
76
0
    build_flags |= ZEND_SSA_DEBUG_LIVENESS;
77
0
  }
78
24.7k
  if (ctx->debug_level & ZEND_DUMP_DFA_PHI) {
79
0
    build_flags |= ZEND_SSA_DEBUG_PHI_PLACEMENT;
80
0
  }
81
24.7k
  if (zend_build_ssa(&ctx->arena, ctx->script, op_array, build_flags, ssa) == FAILURE) {
82
0
    return FAILURE;
83
0
  }
84
85
24.7k
  if (ctx->debug_level & ZEND_DUMP_DFA_SSA) {
86
0
    zend_dump_op_array(op_array, ZEND_DUMP_SSA, "dfa ssa", ssa);
87
0
  }
88
89
90
24.7k
  zend_ssa_compute_use_def_chains(&ctx->arena, op_array, ssa);
91
92
24.7k
  zend_ssa_find_false_dependencies(op_array, ssa);
93
94
24.7k
  zend_ssa_find_sccs(op_array, ssa);
95
96
24.7k
  if (zend_ssa_inference(&ctx->arena, op_array, ctx->script, ssa, ctx->optimization_level) == FAILURE) {
97
0
    return FAILURE;
98
0
  }
99
100
24.7k
  if (zend_ssa_escape_analysis(ctx->script, op_array, ssa) == FAILURE) {
101
0
    return FAILURE;
102
0
  }
103
104
24.7k
  if (ctx->debug_level & ZEND_DUMP_DFA_SSA_VARS) {
105
0
    zend_dump_ssa_variables(op_array, ssa, 0);
106
0
  }
107
108
24.7k
  return SUCCESS;
109
24.7k
}
110
111
static void zend_ssa_remove_nops(zend_op_array *op_array, const zend_ssa *ssa, zend_optimizer_ctx *ctx)
112
3.91k
{
113
3.91k
  zend_basic_block *blocks = ssa->cfg.blocks;
114
3.91k
  zend_basic_block *blocks_end = blocks + ssa->cfg.blocks_count;
115
3.91k
  zend_basic_block *b;
116
3.91k
  zend_func_info *func_info;
117
3.91k
  int j;
118
3.91k
  uint32_t i = 0;
119
3.91k
  uint32_t target = 0;
120
3.91k
  uint32_t *shiftlist;
121
3.91k
  ALLOCA_FLAG(use_heap);
122
123
3.91k
  shiftlist = (uint32_t *)do_alloca(sizeof(uint32_t) * op_array->last, use_heap);
124
3.91k
  memset(shiftlist, 0, sizeof(uint32_t) * op_array->last);
125
  /* remove empty callee_info */
126
3.91k
  func_info = ZEND_FUNC_INFO(op_array);
127
3.91k
  if (func_info) {
128
3.91k
    zend_call_info **call_info = &func_info->callee_info;
129
4.00k
    while ((*call_info)) {
130
98
      if ((*call_info)->caller_init_opline->opcode == ZEND_NOP) {
131
0
        *call_info = (*call_info)->next_callee;
132
98
      } else {
133
98
        call_info = &(*call_info)->next_callee;
134
98
      }
135
98
    }
136
3.91k
  }
137
138
9.84k
  for (b = blocks; b < blocks_end; b++) {
139
5.93k
    if (b->flags & (ZEND_BB_REACHABLE|ZEND_BB_UNREACHABLE_FREE)) {
140
5.19k
      if (b->len) {
141
4.96k
        uint32_t new_start, old_end;
142
6.76k
        while (i < b->start) {
143
1.80k
          shiftlist[i] = i - target;
144
1.80k
          i++;
145
1.80k
        }
146
147
4.96k
        if (b->flags & ZEND_BB_UNREACHABLE_FREE) {
148
          /* Only keep the FREE for the loop var */
149
6
          ZEND_ASSERT(op_array->opcodes[b->start].opcode == ZEND_FREE
150
6
              || op_array->opcodes[b->start].opcode == ZEND_FE_FREE);
151
6
          b->len = 1;
152
6
        }
153
154
4.96k
        new_start = target;
155
4.96k
        old_end = b->start + b->len;
156
31.4k
        while (i < old_end) {
157
26.4k
          shiftlist[i] = i - target;
158
26.4k
          if (EXPECTED(op_array->opcodes[i].opcode != ZEND_NOP)) {
159
20.5k
            if (i != target) {
160
6.52k
              op_array->opcodes[target] = op_array->opcodes[i];
161
6.52k
              ssa->ops[target] = ssa->ops[i];
162
6.52k
              ssa->cfg.map[target] = b - blocks;
163
6.52k
            }
164
20.5k
            target++;
165
20.5k
          }
166
26.4k
          i++;
167
26.4k
        }
168
4.96k
        b->start = new_start;
169
4.96k
        if (target != old_end) {
170
4.22k
          zend_op *opline;
171
4.22k
          zend_op *new_opline;
172
173
4.22k
          b->len = target - b->start;
174
4.22k
          opline = op_array->opcodes + old_end - 1;
175
4.22k
          if (opline->opcode == ZEND_NOP) {
176
2
            continue;
177
2
          }
178
179
4.22k
          new_opline = op_array->opcodes + target - 1;
180
4.22k
          zend_optimizer_migrate_jump(op_array, new_opline, opline);
181
4.22k
        }
182
4.96k
      } else {
183
228
        b->start = target;
184
228
      }
185
5.19k
    } else {
186
744
      b->start = target;
187
744
      b->len = 0;
188
744
    }
189
5.93k
  }
190
191
3.91k
  if (target != op_array->last) {
192
    /* reset rest opcodes */
193
11.6k
    for (i = target; i < op_array->last; i++) {
194
7.70k
      MAKE_NOP(op_array->opcodes + i);
195
7.70k
    }
196
197
    /* update SSA variables */
198
23.6k
    for (j = 0; j < ssa->vars_count; j++) {
199
19.7k
      if (ssa->vars[j].definition >= 0) {
200
13.2k
        ssa->vars[j].definition -= shiftlist[ssa->vars[j].definition];
201
13.2k
      }
202
19.7k
      if (ssa->vars[j].use_chain >= 0) {
203
10.5k
        ssa->vars[j].use_chain -= shiftlist[ssa->vars[j].use_chain];
204
10.5k
      }
205
19.7k
    }
206
32.1k
    for (i = 0; i < op_array->last; i++) {
207
28.2k
      if (ssa->ops[i].op1_use_chain >= 0) {
208
322
        ssa->ops[i].op1_use_chain -= shiftlist[ssa->ops[i].op1_use_chain];
209
322
      }
210
28.2k
      if (ssa->ops[i].op2_use_chain >= 0) {
211
194
        ssa->ops[i].op2_use_chain -= shiftlist[ssa->ops[i].op2_use_chain];
212
194
      }
213
28.2k
      if (ssa->ops[i].res_use_chain >= 0) {
214
0
        ssa->ops[i].res_use_chain -= shiftlist[ssa->ops[i].res_use_chain];
215
0
      }
216
28.2k
    }
217
218
    /* update branch targets */
219
9.84k
    for (b = blocks; b < blocks_end; b++) {
220
5.93k
      if ((b->flags & ZEND_BB_REACHABLE) && b->len != 0) {
221
4.95k
        zend_op *opline = op_array->opcodes + b->start + b->len - 1;
222
4.95k
        zend_optimizer_shift_jump(op_array, opline, shiftlist);
223
4.95k
      }
224
5.93k
    }
225
226
    /* update try/catch array */
227
3.90k
    for (uint32_t j = 0; j < op_array->last_try_catch; j++) {
228
0
      op_array->try_catch_array[j].try_op -= shiftlist[op_array->try_catch_array[j].try_op];
229
0
      op_array->try_catch_array[j].catch_op -= shiftlist[op_array->try_catch_array[j].catch_op];
230
0
      if (op_array->try_catch_array[j].finally_op) {
231
0
        op_array->try_catch_array[j].finally_op -= shiftlist[op_array->try_catch_array[j].finally_op];
232
0
        op_array->try_catch_array[j].finally_end -= shiftlist[op_array->try_catch_array[j].finally_end];
233
0
      }
234
0
    }
235
236
    /* update call graph */
237
3.90k
    if (func_info) {
238
3.90k
      zend_call_info *call_info = func_info->callee_info;
239
4.00k
      while (call_info) {
240
98
        call_info->caller_init_opline -=
241
98
          shiftlist[call_info->caller_init_opline - op_array->opcodes];
242
98
        if (call_info->caller_call_opline) {
243
98
          call_info->caller_call_opline -=
244
98
            shiftlist[call_info->caller_call_opline - op_array->opcodes];
245
98
        }
246
98
        call_info = call_info->next_callee;
247
98
      }
248
3.90k
    }
249
250
3.90k
    op_array->last = target;
251
3.90k
  }
252
3.91k
  free_alloca(shiftlist, use_heap);
253
3.91k
}
254
255
0
static bool safe_instanceof(const zend_class_entry *ce1, const zend_class_entry *ce2) {
256
0
  if (ce1 == ce2) {
257
0
    return true;
258
0
  }
259
0
  if (!(ce1->ce_flags & ZEND_ACC_LINKED)) {
260
    /* This case could be generalized, similarly to unlinked_instanceof */
261
0
    return false;
262
0
  }
263
0
  return instanceof_function(ce1, ce2);
264
0
}
265
266
static inline bool can_elide_list_type(
267
  const zend_script *script, const zend_op_array *op_array,
268
  const zend_ssa_var_info *use_info, const zend_type type)
269
0
{
270
0
  const zend_type *single_type;
271
  /* For intersection: result==false is failure, default is success.
272
   * For union: result==true is success, default is failure. */
273
0
  bool is_intersection = ZEND_TYPE_IS_INTERSECTION(type);
274
0
  ZEND_TYPE_FOREACH(type, single_type) {
275
0
    if (ZEND_TYPE_HAS_LIST(*single_type)) {
276
0
      ZEND_ASSERT(!is_intersection);
277
0
      return can_elide_list_type(script, op_array, use_info, *single_type);
278
0
    }
279
0
    if (ZEND_TYPE_HAS_NAME(*single_type)) {
280
0
      zend_string *lcname = zend_string_tolower(ZEND_TYPE_NAME(*single_type));
281
0
      const zend_class_entry *ce = zend_optimizer_get_class_entry(script, op_array, lcname);
282
0
      zend_string_release(lcname);
283
0
      bool result = ce && safe_instanceof(use_info->ce, ce);
284
0
      if (result == !is_intersection) {
285
0
        return result;
286
0
      }
287
0
    }
288
0
  } ZEND_TYPE_FOREACH_END();
289
0
  return is_intersection;
290
0
}
291
292
static inline bool can_elide_return_type_check(
293
42
    const zend_script *script, const zend_op_array *op_array, const zend_ssa *ssa, const zend_ssa_op *ssa_op) {
294
42
  const zend_arg_info *arg_info = &op_array->arg_info[-1];
295
42
  const zend_ssa_var_info *use_info = &ssa->var_info[ssa_op->op1_use];
296
42
  uint32_t use_type = use_info->type & (MAY_BE_ANY|MAY_BE_UNDEF);
297
42
  if (use_type & MAY_BE_REF) {
298
0
    return false;
299
0
  }
300
301
42
  if (use_type & MAY_BE_UNDEF) {
302
0
    use_type &= ~MAY_BE_UNDEF;
303
0
    use_type |= MAY_BE_NULL;
304
0
  }
305
306
42
  uint32_t disallowed_types = use_type & ~ZEND_TYPE_PURE_MASK(arg_info->type);
307
42
  if (!disallowed_types) {
308
    /* Only contains allowed types. */
309
14
    return true;
310
14
  }
311
312
28
  if (disallowed_types == MAY_BE_OBJECT && use_info->ce && ZEND_TYPE_IS_COMPLEX(arg_info->type)) {
313
0
    return can_elide_list_type(script, op_array, use_info, arg_info->type);
314
0
  }
315
316
28
  return false;
317
28
}
318
319
static bool opline_supports_assign_contraction(
320
125
    const zend_op_array *op_array, const zend_ssa *ssa, const zend_op *opline, int src_var, uint32_t cv_var) {
321
125
  if (opline->opcode == ZEND_NEW) {
322
    /* see Zend/tests/generators/aborted_yield_during_new.phpt */
323
8
    return false;
324
8
  }
325
326
  /* Frameless calls override the return value, but the return value may overlap with the arguments. */
327
117
  switch (opline->opcode) {
328
0
    case ZEND_FRAMELESS_ICALL_3:
329
0
      if ((opline + 1)->op1_type == IS_CV && (opline + 1)->op1.var == cv_var) return false;
330
0
      ZEND_FALLTHROUGH;
331
0
    case ZEND_FRAMELESS_ICALL_2:
332
0
      if (opline->op2_type == IS_CV && opline->op2.var == cv_var) return false;
333
0
      ZEND_FALLTHROUGH;
334
0
    case ZEND_FRAMELESS_ICALL_1:
335
0
      if (opline->op1_type == IS_CV && opline->op1.var == cv_var) return false;
336
0
      return true;
337
117
  }
338
339
117
  if (opline->opcode == ZEND_DO_ICALL || opline->opcode == ZEND_DO_UCALL
340
117
      || opline->opcode == ZEND_DO_FCALL || opline->opcode == ZEND_DO_FCALL_BY_NAME) {
341
    /* Function calls may dtor the return value after it has already been written -- allow
342
     * direct assignment only for types where a double-dtor does not matter. */
343
2
    uint32_t type = ssa->var_info[src_var].type;
344
2
    uint32_t simple = MAY_BE_NULL|MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_LONG|MAY_BE_DOUBLE;
345
2
    return !((type & MAY_BE_ANY) & ~simple);
346
2
  }
347
348
115
  if (opline->opcode == ZEND_POST_INC || opline->opcode == ZEND_POST_DEC) {
349
    /* POST_INC/DEC write the result variable before performing the inc/dec. For $i = $i++
350
     * eliding the temporary variable would thus yield an incorrect result. */
351
0
    return opline->op1_type != IS_CV || opline->op1.var != cv_var;
352
0
  }
353
354
115
  if (opline->opcode == ZEND_INIT_ARRAY) {
355
    /* INIT_ARRAY initializes the result array before reading key/value. */
356
0
    return (opline->op1_type != IS_CV || opline->op1.var != cv_var)
357
0
      && (opline->op2_type != IS_CV || opline->op2.var != cv_var);
358
0
  }
359
360
115
  if (opline->opcode == ZEND_CAST
361
14
      && (opline->extended_value == IS_ARRAY || opline->extended_value == IS_OBJECT)) {
362
    /* CAST to array/object may initialize the result to an empty array/object before
363
     * reading the expression. */
364
0
    return opline->op1_type != IS_CV || opline->op1.var != cv_var;
365
0
  }
366
367
115
  if ((opline->opcode == ZEND_ASSIGN_OP
368
115
    || opline->opcode == ZEND_ASSIGN_OBJ
369
115
    || opline->opcode == ZEND_ASSIGN_DIM
370
113
    || opline->opcode == ZEND_ASSIGN_OBJ_OP
371
111
    || opline->opcode == ZEND_ASSIGN_DIM_OP)
372
8
   && opline->op1_type == IS_CV
373
2
   && opline->op1.var == cv_var
374
2
   && zend_may_throw(opline, &ssa->ops[ssa->vars[src_var].definition], op_array, ssa)) {
375
2
    return false;
376
2
  }
377
378
113
  return true;
379
115
}
380
381
static bool variable_defined_or_used_in_range(const zend_ssa *ssa, int var, int start, int end)
382
113
{
383
139
  while (start < end) {
384
26
    const zend_ssa_op *ssa_op = &ssa->ops[start];
385
26
    if ((ssa_op->op1_def >= 0 && ssa->vars[ssa_op->op1_def].var == var) ||
386
26
      (ssa_op->op2_def >= 0 && ssa->vars[ssa_op->op2_def].var == var) ||
387
26
      (ssa_op->result_def >= 0 && ssa->vars[ssa_op->result_def].var == var) ||
388
26
      (ssa_op->op1_use >= 0 && ssa->vars[ssa_op->op1_use].var == var) ||
389
26
      (ssa_op->op2_use >= 0 && ssa->vars[ssa_op->op2_use].var == var) ||
390
26
      (ssa_op->result_use >= 0 && ssa->vars[ssa_op->result_use].var == var)
391
26
    ) {
392
0
      return true;
393
0
    }
394
26
    start++;
395
26
  }
396
113
  return false;
397
113
}
398
399
static uint32_t zend_dfa_optimize_calls(zend_op_array *op_array, zend_ssa *ssa)
400
24.7k
{
401
24.7k
  const zend_func_info *func_info = ZEND_FUNC_INFO(op_array);
402
24.7k
  uint32_t removed_ops = 0;
403
404
24.7k
  if (func_info->callee_info) {
405
1.75k
    const zend_call_info *call_info = func_info->callee_info;
406
407
1.89k
    do {
408
1.89k
      zend_op *op = call_info->caller_init_opline;
409
410
1.89k
      if ((op->opcode == ZEND_FRAMELESS_ICALL_2
411
1.89k
        || (op->opcode == ZEND_FRAMELESS_ICALL_3 && (op + 1)->op1_type == IS_CONST))
412
0
       && call_info->callee_func
413
0
       && zend_string_equals_literal_ci(call_info->callee_func->common.function_name, "in_array")) {
414
0
        bool strict = false;
415
0
        bool has_opdata = op->opcode == ZEND_FRAMELESS_ICALL_3;
416
0
        ZEND_ASSERT(!call_info->is_prototype);
417
418
0
        if (has_opdata) {
419
0
          if (zend_is_true(CT_CONSTANT_EX(op_array, (op + 1)->op1.constant))) {
420
0
            strict = true;
421
0
          }
422
0
        }
423
424
0
        if (op->op2_type == IS_CONST
425
0
         && Z_TYPE_P(CT_CONSTANT_EX(op_array, op->op2.constant)) == IS_ARRAY) {
426
0
          bool ok = true;
427
428
0
          const HashTable *src = Z_ARRVAL_P(CT_CONSTANT_EX(op_array, op->op2.constant));
429
0
          HashTable *dst;
430
0
          zval *val, tmp;
431
0
          zend_ulong idx;
432
433
0
          ZVAL_TRUE(&tmp);
434
0
          dst = zend_new_array(zend_hash_num_elements(src));
435
0
          if (strict) {
436
0
            ZEND_HASH_FOREACH_VAL(src, val) {
437
0
              if (Z_TYPE_P(val) == IS_STRING) {
438
0
                zend_hash_add(dst, Z_STR_P(val), &tmp);
439
0
              } else if (Z_TYPE_P(val) == IS_LONG) {
440
0
                zend_hash_index_add(dst, Z_LVAL_P(val), &tmp);
441
0
              } else {
442
0
                zend_array_destroy(dst);
443
0
                ok = false;
444
0
                break;
445
0
              }
446
0
            } ZEND_HASH_FOREACH_END();
447
0
          } else {
448
0
            ZEND_HASH_FOREACH_VAL(src, val) {
449
0
              if (Z_TYPE_P(val) != IS_STRING || ZEND_HANDLE_NUMERIC(Z_STR_P(val), idx)) {
450
0
                zend_array_destroy(dst);
451
0
                ok = false;
452
0
                break;
453
0
              }
454
0
              zend_hash_add(dst, Z_STR_P(val), &tmp);
455
0
            } ZEND_HASH_FOREACH_END();
456
0
          }
457
458
0
          if (ok) {
459
0
            ZVAL_ARR(&tmp, dst);
460
461
            /* Update opcode */
462
0
            op->opcode = ZEND_IN_ARRAY;
463
0
            op->extended_value = strict;
464
0
            op->op2.constant = zend_optimizer_add_literal(op_array, &tmp);
465
0
            if (has_opdata) {
466
0
              MAKE_NOP(op + 1);
467
0
              removed_ops++;
468
0
            }
469
0
          }
470
0
        }
471
0
      }
472
473
1.89k
      if (call_info->caller_call_opline && call_info->caller_call_opline->opcode == ZEND_CALLABLE_CONVERT_PARTIAL) {
474
        /* Build a bitset of constant pre-bound PFA args: These are args whose value is always the same for all
475
         * instances of a PFA. */
476
32
        uint32_t const_args = 0;
477
54
        for (uint32_t i = 0, l = MIN(sizeof(const_args)*CHAR_BIT, call_info->num_args); i < l; i++) {
478
22
          zend_op *send_opline = call_info->arg_info[i].opline;
479
22
          if (send_opline->op1_type == IS_CONST) {
480
8
            zval *value = CT_CONSTANT_EX(op_array, send_opline->op1.constant);
481
8
            if (Z_TYPE_P(value) == IS_CONSTANT_AST) {
482
              /* Const exprs can evaluate to non-const zvals (e.g. objects), and are not idempotent */
483
0
              continue;
484
0
            }
485
8
            const_args |= (UINT32_C(1) << i);
486
8
          }
487
22
        }
488
489
        /* Pass the bitset to the ZEND_CALLABLE_CONVERT_PARTIAL opline. */
490
32
        zend_op *call_opline = call_info->caller_call_opline;
491
32
        if (call_opline->op2_type == IS_UNUSED) {
492
20
          call_opline->op2.num = const_args;
493
20
        } else {
494
12
          ZEND_ASSERT(call_opline->op2_type == IS_CONST);
495
12
          zval *zv = CT_CONSTANT_EX(op_array, call_opline->op2.constant);
496
12
          Z_EXTRA_P(zv) = const_args;
497
12
        }
498
32
      }
499
500
1.89k
      call_info = call_info->next_callee;
501
1.89k
    } while (call_info);
502
1.75k
  }
503
504
24.7k
  return removed_ops;
505
24.7k
}
506
507
static zend_always_inline void take_successor_0(zend_ssa *ssa, uint32_t block_num, zend_basic_block *block)
508
346
{
509
346
  if (block->successors_count == 2) {
510
106
    if (block->successors[1] != block->successors[0]) {
511
10
      zend_ssa_remove_predecessor(ssa, block_num, block->successors[1]);
512
10
    }
513
106
    block->successors_count = 1;
514
106
  }
515
346
}
516
517
static zend_always_inline void take_successor_1(zend_ssa *ssa, uint32_t block_num, zend_basic_block *block)
518
140
{
519
140
  if (block->successors_count == 2) {
520
92
    if (block->successors[1] != block->successors[0]) {
521
76
      zend_ssa_remove_predecessor(ssa, block_num, block->successors[0]);
522
76
      block->successors[0] = block->successors[1];
523
76
    }
524
92
    block->successors_count = 1;
525
92
  }
526
140
}
527
528
static zend_always_inline void take_successor_ex(zend_ssa *ssa, uint32_t block_num, zend_basic_block *block, int target_block)
529
0
{
530
0
  for (uint32_t i = 0; i < block->successors_count; i++) {
531
0
    if (block->successors[i] != target_block) {
532
0
      zend_ssa_remove_predecessor(ssa, block_num, block->successors[i]);
533
0
    }
534
0
  }
535
0
  block->successors[0] = target_block;
536
0
  block->successors_count = 1;
537
0
}
538
539
static void compress_block(zend_op_array *op_array, zend_basic_block *block)
540
12.9k
{
541
13.9k
  while (block->len > 0) {
542
13.4k
    zend_op *opline = &op_array->opcodes[block->start + block->len - 1];
543
544
13.4k
    if (opline->opcode == ZEND_NOP) {
545
961
      block->len--;
546
12.4k
    } else {
547
12.4k
      break;
548
12.4k
    }
549
13.4k
  }
550
12.9k
}
551
552
290
static void replace_predecessor(zend_ssa *ssa, int block_id, int old_pred, int new_pred) {
553
290
  zend_basic_block *block = &ssa->cfg.blocks[block_id];
554
290
  int *predecessors = &ssa->cfg.predecessors[block->predecessor_offset];
555
290
  zend_ssa_phi *phi;
556
557
290
  int old_pred_idx = -1;
558
290
  int new_pred_idx = -1;
559
810
  for (uint32_t i = 0; i < block->predecessors_count; i++) {
560
520
    if (predecessors[i] == old_pred) {
561
290
      old_pred_idx = i;
562
290
    }
563
520
    if (predecessors[i] == new_pred) {
564
128
      new_pred_idx = i;
565
128
    }
566
520
  }
567
568
290
  ZEND_ASSERT(old_pred_idx != -1);
569
290
  if (new_pred_idx == -1) {
570
    /* If the new predecessor doesn't exist yet, simply rewire the old one */
571
162
    predecessors[old_pred_idx] = new_pred;
572
162
  } else {
573
    /* Otherwise, rewiring the old predecessor would make the new predecessor appear
574
     * twice, which violates our CFG invariants. Remove the old predecessor instead. */
575
128
    memmove(
576
128
      predecessors + old_pred_idx,
577
128
      predecessors + old_pred_idx + 1,
578
128
      sizeof(int) * (block->predecessors_count - old_pred_idx - 1)
579
128
    );
580
581
    /* Also remove the corresponding phi node entries */
582
128
    for (phi = ssa->blocks[block_id].phis; phi; phi = phi->next) {
583
0
      if (phi->pi >= 0) {
584
0
        if (phi->pi == old_pred || phi->pi == new_pred) {
585
0
          zend_ssa_rename_var_uses(
586
0
            ssa, phi->ssa_var, phi->sources[0], /* update_types */ 0);
587
0
          zend_ssa_remove_phi(ssa, phi);
588
0
        }
589
0
      } else {
590
0
        memmove(
591
0
          phi->sources + old_pred_idx,
592
0
          phi->sources + old_pred_idx + 1,
593
0
          sizeof(int) * (block->predecessors_count - old_pred_idx - 1)
594
0
        );
595
0
      }
596
0
    }
597
598
128
    block->predecessors_count--;
599
128
  }
600
290
}
601
602
static void zend_ssa_replace_control_link(const zend_op_array *op_array, zend_ssa *ssa, int from, int to, int new_to)
603
290
{
604
290
  const zend_basic_block *src = &ssa->cfg.blocks[from];
605
290
  const zend_basic_block *old = &ssa->cfg.blocks[to];
606
290
  const zend_basic_block *dst = &ssa->cfg.blocks[new_to];
607
290
  zend_op *opline;
608
609
834
  for (uint32_t i = 0; i < src->successors_count; i++) {
610
544
    if (src->successors[i] == to) {
611
298
      src->successors[i] = new_to;
612
298
    }
613
544
  }
614
615
290
  if (src->len > 0) {
616
274
    opline = op_array->opcodes + src->start + src->len - 1;
617
274
    switch (opline->opcode) {
618
0
      case ZEND_JMP:
619
0
      case ZEND_FAST_CALL:
620
0
        ZEND_ASSERT(ZEND_OP1_JMP_ADDR(opline) == op_array->opcodes + old->start);
621
0
        ZEND_SET_OP_JMP_ADDR(opline, opline->op1, op_array->opcodes + dst->start);
622
0
        break;
623
164
      case ZEND_JMPZ:
624
174
      case ZEND_JMPNZ:
625
182
      case ZEND_JMPZ_EX:
626
182
      case ZEND_JMPNZ_EX:
627
182
      case ZEND_FE_RESET_R:
628
182
      case ZEND_FE_RESET_RW:
629
206
      case ZEND_JMP_SET:
630
230
      case ZEND_COALESCE:
631
230
      case ZEND_ASSERT_CHECK:
632
230
      case ZEND_JMP_NULL:
633
230
      case ZEND_BIND_INIT_STATIC_OR_JMP:
634
230
      case ZEND_JMP_FRAMELESS:
635
230
        if (ZEND_OP2_JMP_ADDR(opline) == op_array->opcodes + old->start) {
636
98
          ZEND_SET_OP_JMP_ADDR(opline, opline->op2, op_array->opcodes + dst->start);
637
98
        }
638
230
        break;
639
0
      case ZEND_CATCH:
640
0
        if (!(opline->extended_value & ZEND_LAST_CATCH)) {
641
0
          if (ZEND_OP2_JMP_ADDR(opline) == op_array->opcodes + old->start) {
642
0
            ZEND_SET_OP_JMP_ADDR(opline, opline->op2, op_array->opcodes + dst->start);
643
0
          }
644
0
        }
645
0
        break;
646
0
      case ZEND_FE_FETCH_R:
647
0
      case ZEND_FE_FETCH_RW:
648
0
        if (ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value) == old->start) {
649
0
          opline->extended_value = ZEND_OPLINE_NUM_TO_OFFSET(op_array, opline, dst->start);
650
0
        }
651
0
        break;
652
0
      case ZEND_SWITCH_LONG:
653
0
      case ZEND_SWITCH_STRING:
654
16
      case ZEND_MATCH:
655
16
        {
656
16
          HashTable *jumptable = Z_ARRVAL(ZEND_OP2_LITERAL(opline));
657
16
          zval *zv;
658
84
          ZEND_HASH_FOREACH_VAL(jumptable, zv) {
659
84
            if (ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, Z_LVAL_P(zv)) == old->start) {
660
12
              Z_LVAL_P(zv) = ZEND_OPLINE_NUM_TO_OFFSET(op_array, opline, dst->start);
661
12
            }
662
84
          } ZEND_HASH_FOREACH_END();
663
16
          if (ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value) == old->start) {
664
8
            opline->extended_value = ZEND_OPLINE_NUM_TO_OFFSET(op_array, opline, dst->start);
665
8
          }
666
16
          break;
667
0
        }
668
274
    }
669
274
  }
670
671
290
  replace_predecessor(ssa, new_to, to, from);
672
290
}
673
674
static void zend_ssa_unlink_block(const zend_op_array *op_array, zend_ssa *ssa, const zend_basic_block *block, uint32_t block_num)
675
350
{
676
350
  if (block->predecessors_count == 1 && ssa->blocks[block_num].phis == NULL) {
677
290
    int *predecessors;
678
290
    zend_basic_block *fe_fetch_block = NULL;
679
680
290
    ZEND_ASSERT(block->successors_count == 1);
681
290
    predecessors = &ssa->cfg.predecessors[block->predecessor_offset];
682
290
    if (block->predecessors_count == 1 && (block->flags & ZEND_BB_FOLLOW)) {
683
190
      zend_basic_block *pred_block = &ssa->cfg.blocks[predecessors[0]];
684
685
190
      if (pred_block->len > 0 && (pred_block->flags & ZEND_BB_REACHABLE)) {
686
174
        if ((op_array->opcodes[pred_block->start + pred_block->len - 1].opcode == ZEND_FE_FETCH_R
687
174
         || op_array->opcodes[pred_block->start + pred_block->len - 1].opcode == ZEND_FE_FETCH_RW)
688
0
          && op_array->opcodes[pred_block->start + pred_block->len - 1].op2_type == IS_CV) {
689
0
          fe_fetch_block = pred_block;
690
0
          }
691
174
      }
692
190
    }
693
580
    for (uint32_t i = 0; i < block->predecessors_count; i++) {
694
290
      zend_ssa_replace_control_link(op_array, ssa, predecessors[i], block_num, block->successors[0]);
695
290
    }
696
290
    zend_ssa_remove_block(op_array, ssa, block_num);
697
290
    if (fe_fetch_block && fe_fetch_block->successors[0] == fe_fetch_block->successors[1]) {
698
      /* The body of "foreach" loop was removed */
699
0
      int ssa_var = ssa->ops[fe_fetch_block->start + fe_fetch_block->len - 1].op2_def;
700
0
      if (ssa_var >= 0) {
701
0
        zend_ssa_remove_uses_of_var(ssa, ssa_var);
702
0
      }
703
0
    }
704
290
  }
705
350
}
706
707
static int zend_dfa_optimize_jmps(zend_op_array *op_array, zend_ssa *ssa)
708
49.5k
{
709
49.5k
  int removed_ops = 0;
710
49.5k
  uint32_t block_num = 0;
711
712
62.9k
  for (block_num = 1; block_num < ssa->cfg.blocks_count; block_num++) {
713
13.4k
    zend_basic_block *block = &ssa->cfg.blocks[block_num];
714
715
13.4k
    if (!(block->flags & ZEND_BB_REACHABLE)) {
716
1.04k
      continue;
717
1.04k
    }
718
12.3k
    compress_block(op_array, block);
719
12.3k
    if (block->len == 0) {
720
186
      zend_ssa_unlink_block(op_array, ssa, block, block_num);
721
186
    }
722
12.3k
  }
723
724
49.5k
  block_num = 0;
725
49.5k
  while (block_num < ssa->cfg.blocks_count
726
49.5k
    && !(ssa->cfg.blocks[block_num].flags & ZEND_BB_REACHABLE)) {
727
0
    block_num++;
728
0
  }
729
111k
  while (block_num < ssa->cfg.blocks_count) {
730
61.9k
    uint32_t next_block_num = block_num + 1;
731
61.9k
    zend_basic_block *block = &ssa->cfg.blocks[block_num];
732
61.9k
    uint32_t op_num;
733
61.9k
    zend_op *opline;
734
61.9k
    zend_ssa_op *ssa_op;
735
61.9k
    bool can_follow = true;
736
737
63.5k
    while (next_block_num < ssa->cfg.blocks_count
738
13.9k
      && !(ssa->cfg.blocks[next_block_num].flags & ZEND_BB_REACHABLE)) {
739
1.54k
      if (ssa->cfg.blocks[next_block_num].flags & ZEND_BB_UNREACHABLE_FREE) {
740
12
        can_follow = false;
741
12
      }
742
1.54k
      next_block_num++;
743
1.54k
    }
744
745
61.9k
    if (block->len) {
746
60.4k
      op_num = block->start + block->len - 1;
747
60.4k
      opline = op_array->opcodes + op_num;
748
60.4k
      ssa_op = ssa->ops + op_num;
749
750
60.4k
      switch (opline->opcode) {
751
2.45k
        case ZEND_JMP:
752
2.70k
optimize_jmp:
753
2.70k
          if (block->successors[0] == next_block_num && can_follow) {
754
376
            MAKE_NOP(opline);
755
376
            removed_ops++;
756
376
            goto optimize_nop;
757
376
          }
758
2.33k
          break;
759
2.33k
        case ZEND_JMPZ:
760
1.00k
optimize_jmpz:
761
1.00k
          if (opline->op1_type == IS_CONST) {
762
12
            if (zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
763
6
              MAKE_NOP(opline);
764
6
              removed_ops++;
765
6
              take_successor_1(ssa, block_num, block);
766
6
              goto optimize_nop;
767
6
            } else {
768
6
              opline->opcode = ZEND_JMP;
769
6
              COPY_NODE(opline->op1, opline->op2);
770
6
              take_successor_0(ssa, block_num, block);
771
6
              goto optimize_jmp;
772
6
            }
773
988
          } else {
774
988
            if (block->successors[0] == next_block_num && can_follow) {
775
90
              take_successor_0(ssa, block_num, block);
776
90
              if (opline->op1_type == IS_CV && (OP1_INFO() & MAY_BE_UNDEF)) {
777
2
                opline->opcode = ZEND_CHECK_VAR;
778
2
                opline->op2.num = 0;
779
88
              } else if (opline->op1_type == IS_CV || !(OP1_INFO() & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
780
20
                zend_ssa_remove_instr(ssa, opline, ssa_op);
781
20
                removed_ops++;
782
20
                goto optimize_nop;
783
68
              } else {
784
68
                opline->opcode = ZEND_FREE;
785
68
                opline->op2.num = 0;
786
68
              }
787
90
            }
788
988
          }
789
968
          break;
790
1.34k
        case ZEND_JMPNZ:
791
1.47k
optimize_jmpnz:
792
1.47k
          if (opline->op1_type == IS_CONST) {
793
130
            if (zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
794
100
              opline->opcode = ZEND_JMP;
795
100
              COPY_NODE(opline->op1, opline->op2);
796
100
              take_successor_0(ssa, block_num, block);
797
100
              goto optimize_jmp;
798
100
            } else {
799
30
              MAKE_NOP(opline);
800
30
              removed_ops++;
801
30
              take_successor_1(ssa, block_num, block);
802
30
              goto optimize_nop;
803
30
            }
804
1.34k
          } else if (block->successors_count == 2) {
805
1.34k
            if (block->successors[0] == next_block_num && can_follow) {
806
6
              take_successor_0(ssa, block_num, block);
807
6
              if (opline->op1_type == IS_CV && (OP1_INFO() & MAY_BE_UNDEF)) {
808
0
                opline->opcode = ZEND_CHECK_VAR;
809
0
                opline->op2.num = 0;
810
6
              } else if (opline->op1_type == IS_CV || !(OP1_INFO() & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
811
6
                zend_ssa_remove_instr(ssa, opline, ssa_op);
812
6
                removed_ops++;
813
6
                goto optimize_nop;
814
6
              } else {
815
0
                opline->opcode = ZEND_FREE;
816
0
                opline->op2.num = 0;
817
0
              }
818
6
            }
819
1.34k
          }
820
1.33k
          break;
821
1.33k
        case ZEND_JMPZ_EX:
822
354
          if (ssa->vars[ssa_op->result_def].use_chain < 0
823
352
              && ssa->vars[ssa_op->result_def].phi_use_chain == NULL) {
824
32
            opline->opcode = ZEND_JMPZ;
825
32
            opline->result_type = IS_UNUSED;
826
32
            zend_ssa_remove_result_def(ssa, ssa_op);
827
32
            goto optimize_jmpz;
828
322
          } else if (opline->op1_type == IS_CONST) {
829
14
            if (zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
830
0
              opline->opcode = ZEND_BOOL;
831
0
              take_successor_1(ssa, block_num, block);
832
0
            }
833
14
          }
834
322
          break;
835
322
        case ZEND_JMPNZ_EX:
836
42
          if (ssa->vars[ssa_op->result_def].use_chain < 0
837
42
              && ssa->vars[ssa_op->result_def].phi_use_chain == NULL) {
838
12
            opline->opcode = ZEND_JMPNZ;
839
12
            opline->result_type = IS_UNUSED;
840
12
            zend_ssa_remove_result_def(ssa, ssa_op);
841
12
            goto optimize_jmpnz;
842
30
          } else if (opline->op1_type == IS_CONST) {
843
4
            if (!zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
844
0
              opline->opcode = ZEND_BOOL;
845
0
              take_successor_1(ssa, block_num, block);
846
0
            }
847
4
          }
848
30
          break;
849
366
        case ZEND_JMP_SET:
850
366
          if (ssa->vars[ssa_op->result_def].use_chain < 0
851
366
              && ssa->vars[ssa_op->result_def].phi_use_chain == NULL) {
852
118
            opline->opcode = ZEND_JMPNZ;
853
118
            opline->result_type = IS_UNUSED;
854
118
            zend_ssa_remove_result_def(ssa, ssa_op);
855
118
            goto optimize_jmpnz;
856
248
          } else if (opline->op1_type == IS_CONST) {
857
6
            if (!zend_is_true(CT_CONSTANT_EX(op_array, opline->op1.constant))) {
858
6
              MAKE_NOP(opline);
859
6
              removed_ops++;
860
6
              take_successor_1(ssa, block_num, block);
861
6
              zend_ssa_remove_result_def(ssa, ssa_op);
862
6
              goto optimize_nop;
863
6
            }
864
6
          }
865
242
          break;
866
1.00k
        case ZEND_COALESCE:
867
1.00k
        {
868
1.00k
          const zend_ssa_var *var = &ssa->vars[ssa_op->result_def];
869
1.00k
          if (opline->op1_type == IS_CONST
870
196
              && var->use_chain < 0 && var->phi_use_chain == NULL) {
871
168
            if (Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op1.constant)) == IS_NULL) {
872
38
              zend_ssa_remove_result_def(ssa, ssa_op);
873
38
              MAKE_NOP(opline);
874
38
              removed_ops++;
875
38
              take_successor_1(ssa, block_num, block);
876
38
              goto optimize_nop;
877
130
            } else {
878
130
              opline->opcode = ZEND_JMP;
879
130
              opline->result_type = IS_UNUSED;
880
130
              zend_ssa_remove_result_def(ssa, ssa_op);
881
130
              COPY_NODE(opline->op1, opline->op2);
882
130
              take_successor_0(ssa, block_num, block);
883
130
              goto optimize_jmp;
884
130
            }
885
168
          }
886
834
          break;
887
1.00k
        }
888
834
        case ZEND_JMP_NULL:
889
590
        {
890
590
          const zend_ssa_var *var = &ssa->vars[ssa_op->result_def];
891
590
          if (opline->op1_type == IS_CONST
892
142
              && var->use_chain < 0 && var->phi_use_chain == NULL) {
893
74
            if (Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op1.constant)) == IS_NULL) {
894
14
              opline->opcode = ZEND_JMP;
895
14
              opline->result_type = IS_UNUSED;
896
14
              zend_ssa_remove_result_def(ssa, ssa_op);
897
14
              COPY_NODE(opline->op1, opline->op2);
898
14
              take_successor_0(ssa, block_num, block);
899
14
              goto optimize_jmp;
900
60
            } else {
901
60
              zend_ssa_remove_result_def(ssa, ssa_op);
902
60
              MAKE_NOP(opline);
903
60
              removed_ops++;
904
60
              take_successor_1(ssa, block_num, block);
905
60
              goto optimize_nop;
906
60
            }
907
74
          }
908
516
          break;
909
590
        }
910
516
        case ZEND_SWITCH_LONG:
911
0
        case ZEND_SWITCH_STRING:
912
48
        case ZEND_MATCH:
913
48
          if (opline->op1_type == IS_CONST) {
914
0
            zval *zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
915
0
            uint8_t type = Z_TYPE_P(zv);
916
0
            bool correct_type =
917
0
              (opline->opcode == ZEND_SWITCH_LONG && type == IS_LONG)
918
0
              || (opline->opcode == ZEND_SWITCH_STRING && type == IS_STRING)
919
0
              || (opline->opcode == ZEND_MATCH && (type == IS_LONG || type == IS_STRING));
920
921
            /* Switch statements have a fallback chain for loose comparison. In those
922
             * cases the SWITCH_* instruction is a NOP. Match does strict comparison and
923
             * thus jumps to the default branch on mismatched types, so we need to
924
             * convert MATCH to a jmp. */
925
0
            if (!correct_type && opline->opcode != ZEND_MATCH) {
926
0
              removed_ops++;
927
0
              MAKE_NOP(opline);
928
0
              opline->extended_value = 0;
929
0
              take_successor_ex(ssa, block_num, block, block->successors[block->successors_count - 1]);
930
0
              goto optimize_nop;
931
0
            }
932
933
0
            uint32_t target;
934
0
            if (correct_type) {
935
0
              const HashTable *jmptable = Z_ARRVAL_P(CT_CONSTANT_EX(op_array, opline->op2.constant));
936
0
              const zval *jmp_zv = type == IS_LONG
937
0
                ? zend_hash_index_find(jmptable, Z_LVAL_P(zv))
938
0
                : zend_hash_find(jmptable, Z_STR_P(zv));
939
940
0
              if (jmp_zv) {
941
0
                target = ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, Z_LVAL_P(jmp_zv));
942
0
              } else {
943
0
                target = ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value);
944
0
              }
945
0
            } else {
946
0
              ZEND_ASSERT(opline->opcode == ZEND_MATCH);
947
0
              target = ZEND_OFFSET_TO_OPLINE_NUM(op_array, opline, opline->extended_value);
948
0
            }
949
0
            opline->opcode = ZEND_JMP;
950
0
            opline->extended_value = 0;
951
0
            SET_UNUSED(opline->op1);
952
0
            ZEND_SET_OP_JMP_ADDR(opline, opline->op1, op_array->opcodes + target);
953
0
            SET_UNUSED(opline->op2);
954
0
            take_successor_ex(ssa, block_num, block, ssa->cfg.map[target]);
955
0
            goto optimize_jmp;
956
0
          }
957
48
          break;
958
48
        case ZEND_NOP:
959
569
optimize_nop:
960
569
          compress_block(op_array, block);
961
569
          if (block->len == 0) {
962
296
            if (block_num > 0) {
963
164
              zend_ssa_unlink_block(op_array, ssa, block, block_num);
964
              /* backtrack to previous basic block */
965
164
              int backtracking_block_num = block_num;
966
230
              do {
967
230
                backtracking_block_num--;
968
230
              } while (backtracking_block_num >= 0
969
230
                && !(ssa->cfg.blocks[backtracking_block_num].flags & ZEND_BB_REACHABLE));
970
164
              if (backtracking_block_num >= 0) {
971
164
                block_num = backtracking_block_num;
972
164
                continue;
973
164
              }
974
164
            }
975
296
          }
976
405
          break;
977
53.2k
        default:
978
53.2k
          break;
979
60.4k
      }
980
60.4k
    }
981
982
61.8k
    block_num = next_block_num;
983
61.8k
  }
984
985
49.5k
  return removed_ops;
986
49.5k
}
987
988
static bool zend_dfa_try_to_replace_result(const zend_op_array *op_array, const zend_ssa *ssa, int def, int cv_var)
989
952
{
990
952
  int result_var = ssa->ops[def].result_def;
991
952
  uint32_t cv = EX_NUM_TO_VAR(ssa->vars[cv_var].var);
992
993
952
  if (result_var >= 0
994
952
   && !(ssa->var_info[cv_var].type & MAY_BE_REF)
995
118
   && ssa->vars[cv_var].alias == NO_ALIAS
996
118
   && ssa->vars[result_var].phi_use_chain == NULL
997
116
   && ssa->vars[result_var].sym_use_chain == NULL) {
998
116
    int use = ssa->vars[result_var].use_chain;
999
1000
116
    if (use >= 0
1001
86
     && zend_ssa_next_use(ssa->ops, result_var, use) < 0
1002
86
     && op_array->opcodes[use].opcode != ZEND_FREE
1003
86
     && op_array->opcodes[use].opcode != ZEND_SEND_VAL
1004
86
     && op_array->opcodes[use].opcode != ZEND_SEND_VAL_EX
1005
86
     && op_array->opcodes[use].opcode != ZEND_VERIFY_RETURN_TYPE
1006
86
     && op_array->opcodes[use].opcode != ZEND_YIELD) {
1007
86
      if (use > def) {
1008
86
        int i = use;
1009
86
        const zend_op *opline = &op_array->opcodes[use];
1010
1011
158
        while (i > def) {
1012
86
          if ((opline->op1_type == IS_CV && opline->op1.var == cv)
1013
72
           || (opline->op2_type == IS_CV && opline->op2.var == cv)
1014
72
           || (opline->result_type == IS_CV && opline->result.var == cv)) {
1015
14
            return false;
1016
14
          }
1017
72
          opline--;
1018
72
          i--;
1019
72
        }
1020
1021
        /* Update opcodes and reconstruct SSA */
1022
72
        ssa->vars[result_var].definition = -1;
1023
72
        ssa->vars[result_var].use_chain = -1;
1024
72
        ssa->ops[def].result_def = -1;
1025
1026
72
        op_array->opcodes[def].result_type = IS_UNUSED;
1027
72
        op_array->opcodes[def].result.var = 0;
1028
1029
72
        if (ssa->ops[use].op1_use == result_var) {
1030
16
          ssa->ops[use].op1_use = cv_var;
1031
16
          ssa->ops[use].op1_use_chain = ssa->vars[cv_var].use_chain;
1032
16
          ssa->vars[cv_var].use_chain = use;
1033
1034
16
          op_array->opcodes[use].op1_type = IS_CV;
1035
16
          op_array->opcodes[use].op1.var = cv;
1036
56
        } else if (ssa->ops[use].op2_use == result_var) {
1037
56
          ssa->ops[use].op2_use = cv_var;
1038
56
          ssa->ops[use].op2_use_chain = ssa->vars[cv_var].use_chain;
1039
56
          ssa->vars[cv_var].use_chain = use;
1040
1041
56
          op_array->opcodes[use].op2_type = IS_CV;
1042
56
          op_array->opcodes[use].op2.var = cv;
1043
56
        } else if (ssa->ops[use].result_use == result_var) {
1044
0
          ssa->ops[use].result_use = cv_var;
1045
0
          ssa->ops[use].res_use_chain = ssa->vars[cv_var].use_chain;
1046
0
          ssa->vars[cv_var].use_chain = use;
1047
1048
0
          op_array->opcodes[use].result_type = IS_CV;
1049
0
          op_array->opcodes[use].result.var = cv;
1050
0
        }
1051
1052
72
        return true;
1053
86
      }
1054
86
    }
1055
116
  }
1056
1057
866
  return false;
1058
952
}
1059
1060
void zend_dfa_optimize_op_array(zend_op_array *op_array, zend_optimizer_ctx *ctx, zend_ssa *ssa, zend_call_info **call_map)
1061
24.7k
{
1062
24.7k
  if (ctx->debug_level & ZEND_DUMP_BEFORE_DFA_PASS) {
1063
0
    zend_dump_op_array(op_array, ZEND_DUMP_SSA, "before dfa pass", ssa);
1064
0
  }
1065
1066
24.7k
  if (ssa->var_info) {
1067
24.7k
    int op_1;
1068
24.7k
    int v;
1069
24.7k
    int remove_nops = 0;
1070
24.7k
    zend_op *opline;
1071
24.7k
    zend_ssa_op *ssa_op;
1072
24.7k
    zval tmp;
1073
1074
24.7k
#if ZEND_DEBUG_DFA
1075
24.7k
    ssa_verify_integrity(op_array, ssa, "before dfa");
1076
24.7k
#endif
1077
1078
24.7k
    if (ZEND_OPTIMIZER_PASS_8 & ctx->optimization_level) {
1079
24.7k
      if (sccp_optimize_op_array(ctx, op_array, ssa, call_map)) {
1080
603
        remove_nops = 1;
1081
603
      }
1082
1083
24.7k
      if (zend_dfa_optimize_jmps(op_array, ssa)) {
1084
296
        remove_nops = 1;
1085
296
      }
1086
1087
24.7k
#if ZEND_DEBUG_DFA
1088
24.7k
      ssa_verify_integrity(op_array, ssa, "after sccp");
1089
24.7k
#endif
1090
24.7k
      if (ZEND_FUNC_INFO(op_array)) {
1091
24.7k
        if (zend_dfa_optimize_calls(op_array, ssa)) {
1092
0
          remove_nops = 1;
1093
0
        }
1094
24.7k
      }
1095
24.7k
      if (ctx->debug_level & ZEND_DUMP_AFTER_PASS_8) {
1096
0
        zend_dump_op_array(op_array, ZEND_DUMP_SSA, "after sccp pass", ssa);
1097
0
      }
1098
24.7k
#if ZEND_DEBUG_DFA
1099
24.7k
      ssa_verify_integrity(op_array, ssa, "after calls");
1100
24.7k
#endif
1101
24.7k
    }
1102
1103
24.7k
    if (ZEND_OPTIMIZER_PASS_14 & ctx->optimization_level) {
1104
24.7k
      if (dce_optimize_op_array(op_array, ctx, ssa, 0)) {
1105
3.30k
        remove_nops = 1;
1106
3.30k
      }
1107
24.7k
      if (zend_dfa_optimize_jmps(op_array, ssa)) {
1108
130
        remove_nops = 1;
1109
130
      }
1110
24.7k
      if (ctx->debug_level & ZEND_DUMP_AFTER_PASS_14) {
1111
0
        zend_dump_op_array(op_array, ZEND_DUMP_SSA, "after dce pass", ssa);
1112
0
      }
1113
24.7k
#if ZEND_DEBUG_DFA
1114
24.7k
      ssa_verify_integrity(op_array, ssa, "after dce");
1115
24.7k
#endif
1116
24.7k
    }
1117
1118
96.3k
    for (v = op_array->last_var; v < ssa->vars_count; v++) {
1119
1120
71.5k
      op_1 = ssa->vars[v].definition;
1121
1122
71.5k
      if (op_1 < 0) {
1123
6.20k
        continue;
1124
6.20k
      }
1125
1126
65.3k
      opline = op_array->opcodes + op_1;
1127
65.3k
      ssa_op = &ssa->ops[op_1];
1128
1129
      /* Convert LONG constants to DOUBLE */
1130
65.3k
      if (ssa->var_info[v].use_as_double) {
1131
0
        if (opline->opcode == ZEND_ASSIGN
1132
0
         && opline->op2_type == IS_CONST
1133
0
         && ssa->ops[op_1].op1_def == v
1134
0
         && !RETURN_VALUE_USED(opline)
1135
0
        ) {
1136
1137
// op_1: ASSIGN ? -> #v [use_as_double], long(?) => ASSIGN ? -> #v, double(?)
1138
1139
0
          zval *zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1140
0
          ZEND_ASSERT(Z_TYPE_INFO_P(zv) == IS_LONG);
1141
0
          ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1142
0
          opline->op2.constant = zend_optimizer_add_literal(op_array, &tmp);
1143
1144
0
        } else if (opline->opcode == ZEND_QM_ASSIGN
1145
0
         && opline->op1_type == IS_CONST
1146
0
        ) {
1147
1148
// op_1: QM_ASSIGN #v [use_as_double], long(?) => QM_ASSIGN #v, double(?)
1149
1150
0
          zval *zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1151
0
          ZEND_ASSERT(Z_TYPE_INFO_P(zv) == IS_LONG);
1152
0
          ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1153
0
          opline->op1.constant = zend_optimizer_add_literal(op_array, &tmp);
1154
0
        }
1155
1156
65.3k
      } else {
1157
65.3k
        if (opline->opcode == ZEND_ADD
1158
62.9k
         || opline->opcode == ZEND_SUB
1159
60.1k
         || opline->opcode == ZEND_MUL
1160
57.3k
         || opline->opcode == ZEND_IS_EQUAL
1161
57.3k
         || opline->opcode == ZEND_IS_NOT_EQUAL
1162
57.2k
         || opline->opcode == ZEND_IS_SMALLER
1163
55.5k
         || opline->opcode == ZEND_IS_SMALLER_OR_EQUAL
1164
65.3k
        ) {
1165
1166
9.92k
          if (opline->op1_type == IS_CONST && opline->op2_type != IS_CONST) {
1167
1.30k
            zval *zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1168
1169
1.30k
            if ((OP2_INFO() & MAY_BE_ANY) == MAY_BE_DOUBLE
1170
32
             && Z_TYPE_INFO_P(zv) == IS_LONG) {
1171
1172
// op_1: #v.? = ADD long(?), #?.? [double] => #v.? = ADD double(?), #?.? [double]
1173
1174
24
              ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1175
24
              opline->op1.constant = zend_optimizer_add_literal(op_array, &tmp);
1176
24
              zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1177
24
            }
1178
1.30k
            if (opline->opcode == ZEND_ADD) {
1179
416
              zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1180
1181
416
              if (((OP2_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_LONG
1182
37
                && Z_TYPE_INFO_P(zv) == IS_LONG
1183
21
                && Z_LVAL_P(zv) == 0)
1184
413
               || ((OP2_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_DOUBLE
1185
14
                && Z_TYPE_INFO_P(zv) == IS_DOUBLE
1186
14
                && Z_DVAL_P(zv) == 0.0)) {
1187
1188
// op_1: #v.? = ADD 0, #?.? [double,long] => #v.? = QM_ASSIGN #?.?
1189
1190
5
                opline->opcode = ZEND_QM_ASSIGN;
1191
5
                opline->op1_type = opline->op2_type;
1192
5
                opline->op1.var = opline->op2.var;
1193
5
                opline->op2_type = IS_UNUSED;
1194
5
                opline->op2.num = 0;
1195
5
                ssa->ops[op_1].op1_use = ssa->ops[op_1].op2_use;
1196
5
                ssa->ops[op_1].op1_use_chain = ssa->ops[op_1].op2_use_chain;
1197
5
                ssa->ops[op_1].op2_use = -1;
1198
5
                ssa->ops[op_1].op2_use_chain = -1;
1199
5
              }
1200
891
            } else if (opline->opcode == ZEND_MUL
1201
6
             && (OP2_INFO() & ((MAY_BE_ANY|MAY_BE_UNDEF)-(MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1202
0
              zv = CT_CONSTANT_EX(op_array, opline->op1.constant);
1203
1204
0
              if ((Z_TYPE_INFO_P(zv) == IS_LONG
1205
0
                && Z_LVAL_P(zv) == 2)
1206
0
               || (Z_TYPE_INFO_P(zv) == IS_DOUBLE
1207
0
                && Z_DVAL_P(zv) == 2.0
1208
0
                && !(OP2_INFO() & MAY_BE_LONG))) {
1209
1210
// op_1: #v.? = MUL 2, #x.? [double,long] => #v.? = ADD #x.?, #x.?
1211
1212
0
                opline->opcode = ZEND_ADD;
1213
0
                opline->op1_type = opline->op2_type;
1214
0
                opline->op1.var = opline->op2.var;
1215
0
                ssa->ops[op_1].op1_use = ssa->ops[op_1].op2_use;
1216
0
                ssa->ops[op_1].op1_use_chain = ssa->ops[op_1].op2_use_chain;
1217
0
              }
1218
0
            }
1219
8.61k
          } else if (opline->op1_type != IS_CONST && opline->op2_type == IS_CONST) {
1220
4.77k
            zval *zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1221
1222
4.77k
            if ((OP1_INFO() & MAY_BE_ANY) == MAY_BE_DOUBLE
1223
168
             && Z_TYPE_INFO_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == IS_LONG) {
1224
1225
// op_1: #v.? = ADD #?.? [double], long(?) => #v.? = ADD #?.? [double], double(?)
1226
1227
114
              ZVAL_DOUBLE(&tmp, zval_get_double(zv));
1228
114
              opline->op2.constant = zend_optimizer_add_literal(op_array, &tmp);
1229
114
              zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1230
114
            }
1231
4.77k
            if (opline->opcode == ZEND_ADD || opline->opcode == ZEND_SUB) {
1232
2.14k
              if (((OP1_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_LONG
1233
308
                && Z_TYPE_INFO_P(zv) == IS_LONG
1234
274
                && Z_LVAL_P(zv) == 0)
1235
2.11k
               || ((OP1_INFO() & (MAY_BE_ANY|MAY_BE_UNDEF)) == MAY_BE_DOUBLE
1236
134
                && Z_TYPE_INFO_P(zv) == IS_DOUBLE
1237
112
                && Z_DVAL_P(zv) == 0.0)) {
1238
1239
// op_1: #v.? = ADD #?.? [double,long], 0 => #v.? = QM_ASSIGN #?.?
1240
1241
48
                opline->opcode = ZEND_QM_ASSIGN;
1242
48
                opline->op2_type = IS_UNUSED;
1243
48
                opline->op2.num = 0;
1244
48
              }
1245
2.62k
            } else if (opline->opcode == ZEND_MUL
1246
2.21k
             && (OP1_INFO() & ((MAY_BE_ANY|MAY_BE_UNDEF)-(MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1247
240
              zv = CT_CONSTANT_EX(op_array, opline->op2.constant);
1248
1249
240
              if ((Z_TYPE_INFO_P(zv) == IS_LONG
1250
170
                && Z_LVAL_P(zv) == 2)
1251
228
               || (Z_TYPE_INFO_P(zv) == IS_DOUBLE
1252
62
                && Z_DVAL_P(zv) == 2.0
1253
12
                && !(OP1_INFO() & MAY_BE_LONG))) {
1254
1255
// op_1: #v.? = MUL #x.? [double,long], 2 => #v.? = ADD #x.?, #x.?
1256
1257
12
                opline->opcode = ZEND_ADD;
1258
12
                opline->op2_type = opline->op1_type;
1259
12
                opline->op2.var = opline->op1.var;
1260
12
                ssa->ops[op_1].op2_use = ssa->ops[op_1].op1_use;
1261
12
                ssa->ops[op_1].op2_use_chain = ssa->ops[op_1].op1_use_chain;
1262
12
              }
1263
240
            }
1264
4.77k
          }
1265
55.4k
        } else if (opline->opcode == ZEND_CONCAT) {
1266
774
          if (!(OP1_INFO() & MAY_BE_OBJECT)
1267
303
           && !(OP2_INFO() & MAY_BE_OBJECT)) {
1268
110
            opline->opcode = ZEND_FAST_CONCAT;
1269
110
          }
1270
54.6k
        } else if (opline->opcode == ZEND_VERIFY_RETURN_TYPE
1271
28
         && opline->op1_type != IS_CONST
1272
28
         && ssa->ops[op_1].op1_def == v
1273
28
         && ssa->ops[op_1].op1_use >= 0) {
1274
28
          int orig_var = ssa->ops[op_1].op1_use;
1275
28
          int ret = ssa->vars[v].use_chain;
1276
1277
28
          if (ssa->ops[op_1].op1_use_chain == -1
1278
28
           && can_elide_return_type_check(ctx->script, op_array, ssa, &ssa->ops[op_1])) {
1279
1280
// op_1: VERIFY_RETURN_TYPE #orig_var.? [T] -> #v.? [T] => NOP
1281
1282
14
            zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1283
1284
14
            if (ret >= 0) {
1285
14
              ssa->ops[ret].op1_use = orig_var;
1286
14
              ssa->ops[ret].op1_use_chain = ssa->vars[orig_var].use_chain;
1287
14
              ssa->vars[orig_var].use_chain = ret;
1288
14
            }
1289
1290
14
            ssa->vars[v].definition = -1;
1291
14
            ssa->vars[v].use_chain = -1;
1292
1293
14
            ssa->ops[op_1].op1_def = -1;
1294
14
            ssa->ops[op_1].op1_use = -1;
1295
1296
14
            MAKE_NOP(opline);
1297
14
            remove_nops = 1;
1298
14
          } else if (ret >= 0
1299
14
           && ssa->ops[ret].op1_use == v
1300
14
           && ssa->ops[ret].op1_use_chain == -1
1301
14
           && can_elide_return_type_check(ctx->script, op_array, ssa, &ssa->ops[op_1])) {
1302
1303
// op_1: VERIFY_RETURN_TYPE #orig_var.? [T] -> #v.? [T] => NOP
1304
1305
0
            zend_ssa_replace_use_chain(ssa, op_1, ret, orig_var);
1306
1307
0
            ssa->ops[ret].op1_use = orig_var;
1308
0
            ssa->ops[ret].op1_use_chain = ssa->ops[op_1].op1_use_chain;
1309
1310
0
            ssa->vars[v].definition = -1;
1311
0
            ssa->vars[v].use_chain = -1;
1312
1313
0
            ssa->ops[op_1].op1_def = -1;
1314
0
            ssa->ops[op_1].op1_use = -1;
1315
1316
0
            MAKE_NOP(opline);
1317
0
            remove_nops = 1;
1318
0
          }
1319
28
        }
1320
65.3k
      }
1321
1322
65.3k
      if (opline->opcode == ZEND_QM_ASSIGN
1323
589
       && ssa->ops[op_1].result_def == v
1324
589
       && opline->op1_type & (IS_TMP_VAR|IS_VAR)
1325
275
       && !(ssa->var_info[v].type & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
1326
65.3k
      ) {
1327
1328
57
        int src_var = ssa->ops[op_1].op1_use;
1329
1330
57
        if (src_var >= 0
1331
57
         && !(ssa->var_info[src_var].type & MAY_BE_REF)
1332
57
         && (ssa->var_info[src_var].type & (MAY_BE_UNDEF|MAY_BE_ANY))
1333
57
         && ssa->vars[src_var].definition >= 0
1334
53
         && ssa->ops[ssa->vars[src_var].definition].result_def == src_var
1335
53
         && ssa->ops[ssa->vars[src_var].definition].result_use < 0
1336
53
         && ssa->vars[src_var].use_chain == op_1
1337
53
         && ssa->ops[op_1].op1_use_chain < 0
1338
53
         && !ssa->vars[src_var].phi_use_chain
1339
53
         && !ssa->vars[src_var].sym_use_chain
1340
53
         && opline_supports_assign_contraction(
1341
53
           op_array, ssa, &op_array->opcodes[ssa->vars[src_var].definition],
1342
53
           src_var, opline->result.var)
1343
53
         && !variable_defined_or_used_in_range(ssa, EX_VAR_TO_NUM(opline->result.var),
1344
53
            ssa->vars[src_var].definition+1, op_1)
1345
57
        ) {
1346
1347
53
          int orig_var = ssa->ops[op_1].result_use;
1348
53
          int op_2 = ssa->vars[src_var].definition;
1349
1350
// op_2: #src_var.T = OP ...                                        => #v.CV = OP ...
1351
// op_1: QM_ASSIGN #src_var.T #orig_var.CV [undef,scalar] -> #v.CV,    NOP
1352
1353
53
          if (orig_var >= 0) {
1354
0
            zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1355
0
          }
1356
1357
          /* Reconstruct SSA */
1358
53
          ssa->vars[v].definition = op_2;
1359
53
          ssa->ops[op_2].result_def = v;
1360
1361
53
          ssa->vars[src_var].definition = -1;
1362
53
          ssa->vars[src_var].use_chain = -1;
1363
1364
53
          ssa->ops[op_1].op1_use = -1;
1365
53
          ssa->ops[op_1].op1_def = -1;
1366
53
          ssa->ops[op_1].op1_use_chain = -1;
1367
53
          ssa->ops[op_1].result_use = -1;
1368
53
          ssa->ops[op_1].result_def = -1;
1369
53
          ssa->ops[op_1].res_use_chain = -1;
1370
1371
          /* Update opcodes */
1372
53
          op_array->opcodes[op_2].result_type = opline->result_type;
1373
53
          op_array->opcodes[op_2].result.var = opline->result.var;
1374
1375
53
          MAKE_NOP(opline);
1376
53
          remove_nops = 1;
1377
1378
53
          if (op_array->opcodes[op_2].opcode == ZEND_SUB
1379
12
           && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1380
6
           && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1381
0
           && op_array->opcodes[op_2].op2_type == IS_CONST
1382
0
           && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1383
0
           && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1384
0
           && ssa->ops[op_2].op1_use >= 0
1385
0
           && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1386
1387
0
            op_array->opcodes[op_2].opcode = ZEND_PRE_DEC;
1388
0
            SET_UNUSED(op_array->opcodes[op_2].op2);
1389
0
            SET_UNUSED(op_array->opcodes[op_2].result);
1390
1391
0
            ssa->ops[op_2].result_def = -1;
1392
0
            ssa->ops[op_2].op1_def = v;
1393
1394
53
          } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1395
10
           && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1396
8
           && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1397
0
           && op_array->opcodes[op_2].op2_type == IS_CONST
1398
0
           && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1399
0
           && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1400
0
           && ssa->ops[op_2].op1_use >= 0
1401
0
           && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1402
1403
0
            op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1404
0
            SET_UNUSED(op_array->opcodes[op_2].op2);
1405
0
            SET_UNUSED(op_array->opcodes[op_2].result);
1406
1407
0
            ssa->ops[op_2].result_def = -1;
1408
0
            ssa->ops[op_2].op1_def = v;
1409
1410
53
          } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1411
10
           && op_array->opcodes[op_2].op2_type == op_array->opcodes[op_2].result_type
1412
2
           && op_array->opcodes[op_2].op2.var == op_array->opcodes[op_2].result.var
1413
0
           && op_array->opcodes[op_2].op1_type == IS_CONST
1414
0
           && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == IS_LONG
1415
0
           && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == 1
1416
0
           && ssa->ops[op_2].op2_use >= 0
1417
0
           && !(ssa->var_info[ssa->ops[op_2].op2_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1418
1419
0
            op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1420
0
            op_array->opcodes[op_2].op1_type = op_array->opcodes[op_2].op2_type;
1421
0
            op_array->opcodes[op_2].op1.var = op_array->opcodes[op_2].op2.var;
1422
0
            SET_UNUSED(op_array->opcodes[op_2].op2);
1423
0
            SET_UNUSED(op_array->opcodes[op_2].result);
1424
1425
0
            ssa->ops[op_2].result_def = -1;
1426
0
            ssa->ops[op_2].op1_def = v;
1427
0
            ssa->ops[op_2].op1_use = ssa->ops[op_2].op2_use;
1428
0
            ssa->ops[op_2].op1_use_chain = ssa->ops[op_2].op2_use_chain;
1429
0
            ssa->ops[op_2].op2_use = -1;
1430
0
            ssa->ops[op_2].op2_use_chain = -1;
1431
0
          }
1432
53
        }
1433
57
      }
1434
1435
65.3k
      if (ssa->vars[v].var >= op_array->last_var) {
1436
        /* skip TMP and VAR */
1437
60.9k
        continue;
1438
60.9k
      }
1439
1440
4.37k
      if (ssa->ops[op_1].op1_def == v
1441
4.02k
       && RETURN_VALUE_USED(opline)) {
1442
1.91k
        if (opline->opcode == ZEND_ASSIGN
1443
1.39k
         || opline->opcode == ZEND_ASSIGN_OP
1444
1.10k
         || opline->opcode == ZEND_PRE_INC
1445
963
         || opline->opcode == ZEND_PRE_DEC) {
1446
952
          zend_dfa_try_to_replace_result(op_array, ssa, op_1, v);
1447
961
        } else if (opline->opcode == ZEND_POST_INC) {
1448
41
          int result_var = ssa->ops[op_1].result_def;
1449
1450
41
          if (result_var >= 0
1451
41
           && (ssa->var_info[result_var].type & ((MAY_BE_ANY|MAY_BE_REF|MAY_BE_UNDEF) - (MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1452
4
            int use = ssa->vars[result_var].use_chain;
1453
1454
4
            if (use >= 0 && op_array->opcodes[use].opcode == ZEND_IS_SMALLER
1455
0
             && ssa->ops[use].op1_use == result_var
1456
0
             && zend_dfa_try_to_replace_result(op_array, ssa, op_1, v)) {
1457
0
              opline->opcode = ZEND_PRE_INC;
1458
0
              op_array->opcodes[use].opcode = ZEND_IS_SMALLER_OR_EQUAL;
1459
0
            }
1460
4
          }
1461
920
        } else if (opline->opcode == ZEND_POST_DEC) {
1462
26
          int result_var = ssa->ops[op_1].result_def;
1463
1464
26
          if (result_var >= 0
1465
26
           && (ssa->var_info[result_var].type & ((MAY_BE_ANY|MAY_BE_REF|MAY_BE_UNDEF) - (MAY_BE_LONG|MAY_BE_DOUBLE))) == 0) {
1466
0
            int use = ssa->vars[result_var].use_chain;
1467
1468
0
            if (use >= 0 && op_array->opcodes[use].opcode == ZEND_IS_SMALLER
1469
0
             && ssa->ops[use].op2_use == result_var
1470
0
             && zend_dfa_try_to_replace_result(op_array, ssa, op_1, v)) {
1471
0
              opline->opcode = ZEND_PRE_DEC;
1472
0
              op_array->opcodes[use].opcode = ZEND_IS_SMALLER_OR_EQUAL;
1473
0
            }
1474
0
          }
1475
26
        }
1476
1.91k
      }
1477
1478
4.37k
      if (opline->opcode == ZEND_ASSIGN
1479
1.41k
       && ssa->ops[op_1].op1_def == v
1480
1.41k
       && !RETURN_VALUE_USED(opline)
1481
4.37k
      ) {
1482
940
        int orig_var = ssa->ops[op_1].op1_use;
1483
1484
940
        if (orig_var >= 0
1485
940
         && !(ssa->var_info[orig_var].type & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
1486
940
        ) {
1487
100
          int src_var = ssa->ops[op_1].op2_use;
1488
1489
100
          if ((opline->op2_type & (IS_TMP_VAR|IS_VAR))
1490
74
           && src_var >= 0
1491
74
           && !(ssa->var_info[src_var].type & MAY_BE_REF)
1492
74
           && (ssa->var_info[src_var].type & (MAY_BE_UNDEF|MAY_BE_ANY))
1493
72
           && ssa->vars[src_var].definition >= 0
1494
72
           && ssa->ops[ssa->vars[src_var].definition].result_def == src_var
1495
72
           && ssa->ops[ssa->vars[src_var].definition].result_use < 0
1496
72
           && ssa->vars[src_var].use_chain == op_1
1497
72
           && ssa->ops[op_1].op2_use_chain < 0
1498
72
           && !ssa->vars[src_var].phi_use_chain
1499
72
           && !ssa->vars[src_var].sym_use_chain
1500
72
           && opline_supports_assign_contraction(
1501
72
             op_array, ssa, &op_array->opcodes[ssa->vars[src_var].definition],
1502
72
             src_var, opline->op1.var)
1503
60
           && !variable_defined_or_used_in_range(ssa, EX_VAR_TO_NUM(opline->op1.var),
1504
60
              ssa->vars[src_var].definition+1, op_1)
1505
100
          ) {
1506
1507
60
            int op_2 = ssa->vars[src_var].definition;
1508
1509
// op_2: #src_var.T = OP ...                                     => #v.CV = OP ...
1510
// op_1: ASSIGN #orig_var.CV [undef,scalar] -> #v.CV, #src_var.T    NOP
1511
1512
60
            zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1513
            /* Reconstruct SSA */
1514
60
            ssa->vars[v].definition = op_2;
1515
60
            ssa->ops[op_2].result_def = v;
1516
1517
60
            ssa->vars[src_var].definition = -1;
1518
60
            ssa->vars[src_var].use_chain = -1;
1519
1520
60
            ssa->ops[op_1].op1_use = -1;
1521
60
            ssa->ops[op_1].op2_use = -1;
1522
60
            ssa->ops[op_1].op1_def = -1;
1523
60
            ssa->ops[op_1].op1_use_chain = -1;
1524
1525
            /* Update opcodes */
1526
60
            op_array->opcodes[op_2].result_type = opline->op1_type;
1527
60
            op_array->opcodes[op_2].result.var = opline->op1.var;
1528
1529
60
            MAKE_NOP(opline);
1530
60
            remove_nops = 1;
1531
1532
60
            if (op_array->opcodes[op_2].opcode == ZEND_SUB
1533
6
             && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1534
4
             && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1535
0
             && op_array->opcodes[op_2].op2_type == IS_CONST
1536
0
             && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1537
0
             && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1538
0
             && ssa->ops[op_2].op1_use >= 0
1539
0
             && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1540
1541
0
              op_array->opcodes[op_2].opcode = ZEND_PRE_DEC;
1542
0
              SET_UNUSED(op_array->opcodes[op_2].op2);
1543
0
              SET_UNUSED(op_array->opcodes[op_2].result);
1544
1545
0
              ssa->ops[op_2].result_def = -1;
1546
0
              ssa->ops[op_2].op1_def = v;
1547
1548
60
            } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1549
16
             && op_array->opcodes[op_2].op1_type == op_array->opcodes[op_2].result_type
1550
2
             && op_array->opcodes[op_2].op1.var == op_array->opcodes[op_2].result.var
1551
0
             && op_array->opcodes[op_2].op2_type == IS_CONST
1552
0
             && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == IS_LONG
1553
0
             && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op2.constant)) == 1
1554
0
             && ssa->ops[op_2].op1_use >= 0
1555
0
             && !(ssa->var_info[ssa->ops[op_2].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1556
1557
0
              op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1558
0
              SET_UNUSED(op_array->opcodes[op_2].op2);
1559
0
              SET_UNUSED(op_array->opcodes[op_2].result);
1560
1561
0
              ssa->ops[op_2].result_def = -1;
1562
0
              ssa->ops[op_2].op1_def = v;
1563
1564
60
            } else if (op_array->opcodes[op_2].opcode == ZEND_ADD
1565
16
             && op_array->opcodes[op_2].op2_type == op_array->opcodes[op_2].result_type
1566
10
             && op_array->opcodes[op_2].op2.var == op_array->opcodes[op_2].result.var
1567
2
             && op_array->opcodes[op_2].op1_type == IS_CONST
1568
0
             && Z_TYPE_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == IS_LONG
1569
0
             && Z_LVAL_P(CT_CONSTANT_EX(op_array, op_array->opcodes[op_2].op1.constant)) == 1
1570
0
             && ssa->ops[op_2].op2_use >= 0
1571
0
             && !(ssa->var_info[ssa->ops[op_2].op2_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1572
1573
0
              op_array->opcodes[op_2].opcode = ZEND_PRE_INC;
1574
0
              op_array->opcodes[op_2].op1_type = op_array->opcodes[op_2].op2_type;
1575
0
              op_array->opcodes[op_2].op1.var = op_array->opcodes[op_2].op2.var;
1576
0
              SET_UNUSED(op_array->opcodes[op_2].op2);
1577
0
              SET_UNUSED(op_array->opcodes[op_2].result);
1578
1579
0
              ssa->ops[op_2].result_def = -1;
1580
0
              ssa->ops[op_2].op1_def = v;
1581
0
              ssa->ops[op_2].op1_use = ssa->ops[op_2].op2_use;
1582
0
              ssa->ops[op_2].op1_use_chain = ssa->ops[op_2].op2_use_chain;
1583
0
              ssa->ops[op_2].op2_use = -1;
1584
0
              ssa->ops[op_2].op2_use_chain = -1;
1585
0
            }
1586
60
          } else if (opline->op2_type == IS_CONST
1587
40
           || ((opline->op2_type & (IS_TMP_VAR|IS_VAR|IS_CV))
1588
40
               && ssa->ops[op_1].op2_use >= 0
1589
40
               && ssa->ops[op_1].op2_def < 0)
1590
40
          ) {
1591
1592
// op_1: ASSIGN #orig_var.CV [undef,scalar] -> #v.CV, CONST|TMPVAR => QM_ASSIGN v.CV, CONST|TMPVAR
1593
1594
40
            if (ssa->ops[op_1].op1_use != ssa->ops[op_1].op2_use) {
1595
36
              zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
1596
36
            } else {
1597
4
              ssa->ops[op_1].op2_use_chain = ssa->ops[op_1].op1_use_chain;
1598
4
            }
1599
1600
            /* Reconstruct SSA */
1601
40
            ssa->ops[op_1].result_def = v;
1602
40
            ssa->ops[op_1].op1_def = -1;
1603
40
            ssa->ops[op_1].op1_use = ssa->ops[op_1].op2_use;
1604
40
            ssa->ops[op_1].op1_use_chain = ssa->ops[op_1].op2_use_chain;
1605
40
            ssa->ops[op_1].op2_use = -1;
1606
40
            ssa->ops[op_1].op2_use_chain = -1;
1607
1608
            /* Update opcode */
1609
40
            opline->result_type = opline->op1_type;
1610
40
            opline->result.var = opline->op1.var;
1611
40
            opline->op1_type = opline->op2_type;
1612
40
            opline->op1.var = opline->op2.var;
1613
40
            opline->op2_type = IS_UNUSED;
1614
40
            opline->op2.var = 0;
1615
40
            opline->opcode = ZEND_QM_ASSIGN;
1616
40
          }
1617
100
        }
1618
1619
3.43k
      } else if (opline->opcode == ZEND_ASSIGN_OP
1620
564
       && opline->extended_value == ZEND_ADD
1621
140
       && ssa->ops[op_1].op1_def == v
1622
140
       && opline->op2_type == IS_CONST
1623
26
       && Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == IS_LONG
1624
13
       && Z_LVAL_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == 1
1625
4
       && ssa->ops[op_1].op1_use >= 0
1626
4
       && !(ssa->var_info[ssa->ops[op_1].op1_use].type & (MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1627
1628
// op_1: ASSIGN_ADD #?.CV [undef,null,int,foat] ->#v.CV, int(1) => PRE_INC #?.CV ->#v.CV
1629
1630
0
        opline->opcode = ZEND_PRE_INC;
1631
0
        opline->extended_value = 0;
1632
0
        SET_UNUSED(opline->op2);
1633
1634
3.43k
      } else if (opline->opcode == ZEND_ASSIGN_OP
1635
564
       && opline->extended_value == ZEND_SUB
1636
70
       && ssa->ops[op_1].op1_def == v
1637
70
       && opline->op2_type == IS_CONST
1638
19
       && Z_TYPE_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == IS_LONG
1639
11
       && Z_LVAL_P(CT_CONSTANT_EX(op_array, opline->op2.constant)) == 1
1640
4
       && ssa->ops[op_1].op1_use >= 0
1641
4
       && !(ssa->var_info[ssa->ops[op_1].op1_use].type & (MAY_BE_UNDEF|MAY_BE_NULL|MAY_BE_FALSE|MAY_BE_TRUE|MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))) {
1642
1643
// op_1: ASSIGN_SUB #?.CV [undef,null,int,foat] -> #v.CV, int(1) => PRE_DEC #?.CV ->#v.CV
1644
1645
0
        opline->opcode = ZEND_PRE_DEC;
1646
0
        opline->extended_value = 0;
1647
0
        SET_UNUSED(opline->op2);
1648
1649
3.43k
      } else if (ssa->ops[op_1].op1_def == v
1650
3.08k
       && !RETURN_VALUE_USED(opline)
1651
1.24k
       && ssa->ops[op_1].op1_use >= 0
1652
1.24k
       && !(ssa->var_info[ssa->ops[op_1].op1_use].type & (MAY_BE_STRING|MAY_BE_ARRAY|MAY_BE_OBJECT|MAY_BE_RESOURCE|MAY_BE_REF))
1653
134
       && opline->opcode == ZEND_ASSIGN_OP
1654
62
       && opline->extended_value != ZEND_CONCAT) {
1655
1656
// op_1: ASSIGN_OP #orig_var.CV [undef,null,bool,int,double] -> #v.CV, ? => #v.CV = ADD #orig_var.CV, ?
1657
1658
        /* Reconstruct SSA */
1659
54
        ssa->ops[op_1].result_def = ssa->ops[op_1].op1_def;
1660
54
        ssa->ops[op_1].op1_def = -1;
1661
1662
        /* Update opcode */
1663
54
        opline->opcode = opline->extended_value;
1664
54
        opline->extended_value = 0;
1665
54
        opline->result_type = opline->op1_type;
1666
54
        opline->result.var = opline->op1.var;
1667
1668
54
      }
1669
4.37k
    }
1670
1671
24.7k
#if ZEND_DEBUG_DFA
1672
24.7k
    ssa_verify_integrity(op_array, ssa, "after dfa");
1673
24.7k
#endif
1674
1675
24.7k
    if (remove_nops) {
1676
3.91k
      zend_ssa_remove_nops(op_array, ssa, ctx);
1677
3.91k
#if ZEND_DEBUG_DFA
1678
3.91k
      ssa_verify_integrity(op_array, ssa, "after nop");
1679
3.91k
#endif
1680
3.91k
    }
1681
24.7k
  }
1682
1683
24.7k
  if (ctx->debug_level & ZEND_DUMP_AFTER_DFA_PASS) {
1684
0
    zend_dump_op_array(op_array, ZEND_DUMP_SSA, "after dfa pass", ssa);
1685
0
  }
1686
24.7k
}
1687
1688
void zend_optimize_dfa(zend_op_array *op_array, zend_optimizer_ctx *ctx)
1689
0
{
1690
0
  void *checkpoint = zend_arena_checkpoint(ctx->arena);
1691
0
  zend_ssa ssa;
1692
1693
0
  if (zend_dfa_analyze_op_array(op_array, ctx, &ssa) == FAILURE) {
1694
0
    zend_arena_release(&ctx->arena, checkpoint);
1695
0
    return;
1696
0
  }
1697
1698
0
  zend_dfa_optimize_op_array(op_array, ctx, &ssa, NULL);
1699
1700
  /* Destroy SSA */
1701
0
  zend_arena_release(&ctx->arena, checkpoint);
1702
0
}