/src/wolfssl-normal-math/src/x509.c

Source
/* x509.c
 *
 * Copyright (C) 2006-2026 wolfSSL Inc.
 *
 * This file is part of wolfSSL.
 *
 * wolfSSL is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 3 of the License, or
 * (at your option) any later version.
 *
 * wolfSSL is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1335, USA
 */

#include <wolfssl/wolfcrypt/libwolfssl_sources.h>

#if !defined(WOLFSSL_X509_INCLUDED)
    #ifndef WOLFSSL_IGNORE_FILE_WARN
        #warning x509.c does not need to be compiled separately from ssl.c
    #endif
#else

#ifndef WOLFCRYPT_ONLY

#ifndef NO_CERTS

#if defined(OPENSSL_EXTRA) || defined(OPENSSL_EXTRA_X509_SMALL)
    #include <wolfssl/openssl/x509v3.h>
#endif
#ifdef OPENSSL_EXTRA
    #include <wolfssl/wolfio.h>
#endif

/* 16 times MAX_X509_SIZE should be more than enough to read any X509
 * certificate file */
#define MAX_BIO_READ_BUFFER (MAX_X509_SIZE * 16)

#if defined(OPENSSL_ALL) || defined(OPENSSL_EXTRA)
unsigned int wolfSSL_X509_get_extension_flags(WOLFSSL_X509* x509)
{
    unsigned int flags = 0;

    WOLFSSL_ENTER("wolfSSL_X509_get_extension_flags");

    if (x509 != NULL) {
        if (x509->keyUsageSet) {
            flags |= WOLFSSL_EXFLAG_KUSAGE;
        }
        if (x509->extKeyUsageSrc != NULL) {
            flags |= WOLFSSL_EXFLAG_XKUSAGE;
        }
    }

    WOLFSSL_LEAVE("wolfSSL_X509_get_extension_flags", flags);

    return flags;
}

unsigned int wolfSSL_X509_get_key_usage(WOLFSSL_X509* x509)
{
    unsigned int ret = 0;

    WOLFSSL_ENTER("wolfSSL_X509_get_key_usage");

    if (x509 == NULL) {
        WOLFSSL_MSG("x509 is NULL");
    }
    else {
        if (x509->keyUsageSet) {
            ret = wolfSSL_X509_get_keyUsage(x509);
        }
        else {
            ret = (unsigned int)-1;
        }
    }

    WOLFSSL_LEAVE("wolfSSL_X509_get_key_usage", ret);

    return ret;
}

unsigned int wolfSSL_X509_get_extended_key_usage(WOLFSSL_X509* x509)
{
    int ret = 0;

    WOLFSSL_ENTER("wolfSSL_X509_get_extended_key_usage");

    if (x509 != NULL) {
        if (x509->extKeyUsage & EXTKEYUSE_OCSP_SIGN)
            ret |= WOLFSSL_XKU_OCSP_SIGN;
        if (x509->extKeyUsage & EXTKEYUSE_TIMESTAMP)
            ret |= WOLFSSL_XKU_TIMESTAMP;
        if (x509->extKeyUsage & EXTKEYUSE_EMAILPROT)
            ret |= WOLFSSL_XKU_SMIME;
        if (x509->extKeyUsage & EXTKEYUSE_CODESIGN)
            ret |= WOLFSSL_XKU_CODE_SIGN;
        if (x509->extKeyUsage & EXTKEYUSE_CLIENT_AUTH)
            ret |= WOLFSSL_XKU_SSL_CLIENT;
        if (x509->extKeyUsage & EXTKEYUSE_SERVER_AUTH)
            ret |= WOLFSSL_XKU_SSL_SERVER;
        if (x509->extKeyUsage & EXTKEYUSE_ANY)
            ret |= WOLFSSL_XKU_ANYEKU;
    }

    WOLFSSL_LEAVE("wolfSSL_X509_get_extended_key_usage", ret);

    return (unsigned int)ret;
}

/* Returns the number of X509V3 extensions in X509 object, or 0 on failure */
int wolfSSL_X509_get_ext_count(const WOLFSSL_X509* passedCert)
{
    int extCount = 0;
    int length = 0;
    int outSz = 0;
    const byte* rawCert;
    int sz = 0;
    word32 idx = 0;
    const byte* input;
    WC_DECLARE_VAR(cert, DecodedCert, 1, 0);

    WOLFSSL_ENTER("wolfSSL_X509_get_ext_count");
    if (passedCert == NULL) {
        WOLFSSL_MSG("\tNot passed a certificate");
        return WOLFSSL_FAILURE;
    }

    rawCert = wolfSSL_X509_get_der((WOLFSSL_X509*)passedCert, &outSz);
    if (rawCert == NULL) {
        WOLFSSL_MSG("\tpassedCert has no internal DerBuffer set.");
        return WOLFSSL_FAILURE;
    }

#ifdef WOLFSSL_SMALL_STACK
    cert = (DecodedCert *)XMALLOC(sizeof(*cert), NULL, DYNAMIC_TYPE_DCERT);
    if (cert == NULL) {
        WOLFSSL_MSG("out of memory");
        return WOLFSSL_FAILURE;
    }
#endif

    InitDecodedCert(cert, rawCert, (word32)outSz, 0);

    if (ParseCert(cert,
#ifdef WOLFSSL_CERT_REQ
            passedCert->isCSR ? CERTREQ_TYPE :
#endif
                    CA_TYPE,
            NO_VERIFY, NULL) < 0) {
        WOLFSSL_MSG("\tCertificate parsing failed");
        goto out;
    }

    input = cert->extensions;
    sz = cert->extensionsSz;

    if (input == NULL || sz == 0) {
        WOLFSSL_MSG("\tsz or input NULL error");
        goto out;
    }

#ifdef WOLFSSL_CERT_REQ
    if (!passedCert->isCSR)
#endif
    {
        if (input[idx++] != ASN_EXTENSIONS) {
            WOLFSSL_MSG("\tfail: should be an EXTENSIONS");
            goto out;
        }

        if (GetLength(input, &idx, &length, (word32)sz) < 0) {
            WOLFSSL_MSG("\tfail: invalid length");
            goto out;
        }
    }

    if (GetSequence(input, &idx, &length, (word32)sz) < 0) {
        WOLFSSL_MSG("\tfail: should be a SEQUENCE (1)");
        goto out;
    }

    while (idx < (word32)sz) {
        if (GetSequence(input, &idx, &length, (word32)sz) < 0) {
            WOLFSSL_MSG("\tfail: should be a SEQUENCE");
            FreeDecodedCert(cert);
            return WOLFSSL_FAILURE;
        }
        idx += length;
        extCount++;
    }

out:

    FreeDecodedCert(cert);
    WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
    return extCount;
}

/* Creates and returns pointer to a new X509_EXTENSION object in memory */
WOLFSSL_X509_EXTENSION* wolfSSL_X509_EXTENSION_new(void)
{
    WOLFSSL_X509_EXTENSION* newExt;

    WOLFSSL_ENTER("wolfSSL_X509_EXTENSION_new");

    newExt = (WOLFSSL_X509_EXTENSION*)XMALLOC(sizeof(WOLFSSL_X509_EXTENSION),
              NULL, DYNAMIC_TYPE_X509_EXT);
    if (newExt == NULL)
        return NULL;
    XMEMSET(newExt, 0, sizeof(WOLFSSL_X509_EXTENSION));

    return newExt;
}


/* Clear out and free internal pointers of ASN.1 STRING object.
 *
 * @param [in] asn1  ASN.1 STRING object.
 */
static void wolfSSL_ASN1_STRING_clear(WOLFSSL_ASN1_STRING* asn1)
{
    /* Check we have an object to free. */
    if (asn1 != NULL) {
        /* Dispose of dynamic data. */
        if ((asn1->length > 0) && asn1->isDynamic) {
            XFREE(asn1->data, NULL, DYNAMIC_TYPE_OPENSSL);
        }
        XMEMSET(asn1, 0, sizeof(WOLFSSL_ASN1_STRING));
    }
}


void wolfSSL_X509_EXTENSION_free(WOLFSSL_X509_EXTENSION* x)
{
    WOLFSSL_ENTER("wolfSSL_X509_EXTENSION_free");
    if (x == NULL)
        return;

    if (x->obj != NULL) {
        wolfSSL_ASN1_OBJECT_free(x->obj);
    }

    wolfSSL_ASN1_STRING_clear(&x->value);
    wolfSSL_sk_pop_free(x->ext_sk, NULL);

    XFREE(x, NULL, DYNAMIC_TYPE_X509_EXT);
}

WOLFSSL_X509_EXTENSION* wolfSSL_X509_EXTENSION_dup(WOLFSSL_X509_EXTENSION* src)
{
    WOLFSSL_X509_EXTENSION* ret = NULL;
    int err = 0;

    WOLFSSL_ENTER("wolfSSL_X509_EXTENSION_dup");

    if (src == NULL) {
        err = 1;
    }

    if (err == 0) {
        ret = wolfSSL_X509_EXTENSION_new();
        if (ret == NULL) {
            err = 1;
        }
    }
    if (err == 0 && src->obj != NULL) {
        ret->obj = wolfSSL_ASN1_OBJECT_dup(src->obj);
        if (ret->obj == NULL) {
            err = 1;
        }
    }
    if (err == 0) {
        ret->crit = src->crit;
        if (wolfSSL_ASN1_STRING_copy(&ret->value, &src->value) !=
                WOLFSSL_SUCCESS) {
            err = 1;
        }
    }

    if (err == 1 && ret != NULL) {
        wolfSSL_X509_EXTENSION_free(ret);
        ret = NULL;
    }

    return ret;
}

WOLFSSL_X509_EXTENSION* wolfSSL_X509_EXTENSION_create_by_OBJ(
    WOLFSSL_X509_EXTENSION* ex, WOLFSSL_ASN1_OBJECT *obj, int crit,
    WOLFSSL_ASN1_STRING *data)
{
    int err = 0;
    WOLFSSL_X509_EXTENSION *ret = ex;
    WOLFSSL_ASN1_OBJECT *newObj = NULL;

    WOLFSSL_ENTER("wolfSSL_X509_EXTENSION_create_by_OBJ");

    if ((obj == NULL) || (data == NULL)) {
       return NULL;
    }

    if (ret == NULL) {
        ret = wolfSSL_X509_EXTENSION_new();
        if (ret == NULL) {
            err = 1;
        }
    }

    /* Duplicate the source object before freeing the existing one so that a
     * caller passing the extension's own object (e.g. obtained via
     * wolfSSL_X509_EXTENSION_get_object(ex)) does not read freed memory. */
    if (err == 0) {
        newObj = wolfSSL_ASN1_OBJECT_dup(obj);
        if (newObj == NULL) {
            err = 1;
        }
    }

    if ((err == 0) && (ret == ex)) {
        /* Prevent potential memory leaks and dangling pointers. */
        wolfSSL_ASN1_OBJECT_free(ret->obj);
        ret->obj = NULL;
        wolfSSL_ASN1_STRING_clear(&ret->value);
    }

    if (err == 0) {
        ret->crit = crit;
        ret->obj = newObj;
        newObj = NULL;
    }

    if (err == 0) {
        if (wolfSSL_ASN1_STRING_copy(&ret->value, data) != WOLFSSL_SUCCESS) {
            err = 1;
        }
    }

    if (err == 1) {
        /* Free the duplicate if it was created but not assigned to ret. */
        wolfSSL_ASN1_OBJECT_free(newObj);
        if (ret != ex) {
            wolfSSL_X509_EXTENSION_free(ret);
        }
        ret = NULL;
    }
    return ret;
}

/* Creates and returns a new WOLFSSL_X509_EXTENSION stack. */
WOLFSSL_STACK* wolfSSL_sk_new_x509_ext(void)
{
    WOLFSSL_STACK* sk;
    WOLFSSL_ENTER("wolfSSL_sk_new_x509_ext");

    sk = wolfSSL_sk_new_null();
    if (sk) {
        sk->type = STACK_TYPE_X509_EXT;
    }
    return sk;
}

/* This function does NOT return 1 on success. It returns 0 on fail, and the
 * number of items in the stack upon success. This is for compatibility with
 * OpenSSL. */
int wolfSSL_sk_X509_EXTENSION_push(WOLFSSL_STACK* sk,
    WOLFSSL_X509_EXTENSION* ext)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_EXTENSION_push");

    return wolfSSL_sk_push(sk, ext);
}

static WOLFSSL_STACK* generateExtStack(const WOLFSSL_X509 *x)
{
    int numOfExt, i;
    WOLFSSL_X509 *x509 = (WOLFSSL_X509*)x;
    WOLFSSL_STACK* ret;
    WOLFSSL_STACK* tmp;

    if (!x509) {
        WOLFSSL_MSG("Bad parameter");
        return NULL;
    }

    /* Save x509->ext_sk */
    tmp = x509->ext_sk;
    x509->ext_sk = NULL;
    numOfExt = wolfSSL_X509_get_ext_count(x509);

    for (i = 0; i < numOfExt; i++) {
        /* Build the extension stack */
        (void)wolfSSL_X509_set_ext(x509, i);
    }

    /* Restore */
    ret = x509->ext_sk;
    x509->ext_sk = tmp;
    return ret;
}

/**
 * @param x Certificate to extract extensions from
 * @return STACK_OF(X509_EXTENSION)*
 */
const WOLFSSL_STACK *wolfSSL_X509_get0_extensions(const WOLFSSL_X509 *x)
{
    int numOfExt;
    WOLFSSL_X509 *x509 = (WOLFSSL_X509*)x;
    WOLFSSL_ENTER("wolfSSL_X509_get0_extensions");

    if (!x509) {
        WOLFSSL_MSG("Bad parameter");
        return NULL;
    }

    numOfExt = wolfSSL_X509_get_ext_count(x509);

    if (numOfExt != wolfSSL_sk_num(x509->ext_sk_full)) {
        wolfSSL_sk_pop_free(x509->ext_sk_full, NULL);
        x509->ext_sk_full = generateExtStack(x);
    }

    return x509->ext_sk_full;
}

/**
 * Caller is responsible for freeing the returned stack.
 */
const WOLFSSL_STACK *wolfSSL_X509_REQ_get_extensions(const WOLFSSL_X509 *x)
{
    return generateExtStack(x);
}

/* Gets the X509_EXTENSION* ext based on it's location in WOLFSSL_X509* x509.
 *
 * x509   : The X509 structure to look for the extension.
 * loc    : Location of the extension. If the extension is found at the given
 * location, a new X509_EXTENSION structure is populated with extension-specific
 * data based on the extension type.

 * Returns NULL on error or pointer to X509_EXTENSION structure containing the
 * extension. The returned X509_EXTENSION should not be free'd by caller.
 * The returned X509_EXTENSION is pushed onto a stack inside the x509 argument.
 * This is later free'd when x509 is free'd.
 *
 * NOTE: for unknown extension NIDs, a X509_EXTENSION is populated with the
 * extension oid as the ASN1_OBJECT (QT compatibility)
 */
WOLFSSL_X509_EXTENSION* wolfSSL_X509_get_ext(const WOLFSSL_X509* x509, int loc)
{
    WOLFSSL_X509_EXTENSION* ext = NULL;
    WOLFSSL_ENTER("wolfSSL_X509_get_ext");
    if (x509 == NULL)
        return NULL;

   ext = wolfSSL_X509_set_ext((WOLFSSL_X509*) x509, loc);
   return ext;
}

int wolfSSL_X509_get_ext_by_OBJ(const WOLFSSL_X509 *x,
        const WOLFSSL_ASN1_OBJECT *obj, int lastpos)
{
    const WOLF_STACK_OF(WOLFSSL_X509_EXTENSION) *sk;

    if (!x || !obj) {
        WOLFSSL_MSG("Bad parameter");
        return WOLFSSL_FATAL_ERROR;
    }

    sk = wolfSSL_X509_get0_extensions(x);
    if (!sk) {
        WOLFSSL_MSG("No extensions");
        return WOLFSSL_FATAL_ERROR;
    }
    lastpos++;
    if (lastpos < 0)
        lastpos = 0;
    for (; lastpos < wolfSSL_sk_num(sk); lastpos++) {
        const WOLFSSL_X509_EXTENSION *ext =
            wolfSSL_sk_X509_EXTENSION_value(sk, lastpos);
        if (ext == NULL)
            continue;
        if (wolfSSL_OBJ_cmp(ext->obj, obj) == 0)
            return lastpos;
    }
    return WOLFSSL_FATAL_ERROR;
}


int wolfSSL_X509_OBJECT_set1_X509(WOLFSSL_X509_OBJECT *a, WOLFSSL_X509 *obj)
{
    WOLFSSL_STUB("wolfSSL_X509_OBJECT_set1_X509");
    (void)a;
    (void)obj;
    return 0;
}

int wolfSSL_X509_OBJECT_set1_X509_CRL(WOLFSSL_X509_OBJECT *a,
    WOLFSSL_X509_CRL *obj)
{
    WOLFSSL_STUB("wolfSSL_X509_OBJECT_set1_X509_CRL");
    (void)a;
    (void)obj;
    return 0;
}

#endif /* OPENSSL_ALL || OPENSSL_EXTRA */

#if defined(OPENSSL_ALL) || defined(OPENSSL_EXTRA) || \
    defined(WOLFSSL_WPAS_SMALL)
/* Set a general name from the DNS entry data.
 *
 * @param [in]      dns  DNS entry.
 * @param [in, out] gn   General name to place data in.
 * @return  1 on success.
 * @return  0 on failure.
 */
static int wolfssl_dns_entry_othername_to_gn(DNS_entry* dns,
    WOLFSSL_GENERAL_NAME* gn)
{
    int ret = 0;
    WOLFSSL_ASN1_OBJECT* obj = NULL;
    WOLFSSL_ASN1_TYPE* type = NULL;
    WOLFSSL_ASN1_STRING* str = NULL;
    byte tag = 0;
    unsigned char* p = (unsigned char *)dns->name;
    long len = dns->len;

#ifdef WOLFSSL_FPKI
    if (dns->oidSum != 0) {
        /* UPN OID: 1.3.6.1.4.1.311.20.2.3 */
        static const unsigned char upn_oid[] = {
            0x2B, 0x06, 0x01, 0x04, 0x01, 0x82, 0x37, 0x14, 0x02, 0x03
        };
        /* FASCN OID: 2.16.840.1.101.3.6.6 */
        static const unsigned char fascn_oid[] = {
            0x60, 0x86, 0x48, 0x01, 0x65, 0x03, 0x06, 0x06
        };
        const unsigned char* oid;
        word32 oidSz;

        if ((oid = OidFromId(dns->oidSum, oidCertAltNameType, &oidSz)) ==
                NULL) {
            if (dns->oidSum == UPN_OID) {
                oid = upn_oid;
                oidSz = (word32)sizeof(upn_oid);
            }
            else if (dns->oidSum == FASCN_OID) {
                oid = fascn_oid;
                oidSz = (word32)sizeof(fascn_oid);
            }
            else {
                goto err;
            }
        }
        if ((obj = wolfSSL_c2i_ASN1_OBJECT(NULL, &oid, oidSz)) == NULL) {
            goto err;
        }

        tag = WOLFSSL_V_ASN1_UTF8STRING;
    }
    else
#endif
    {
        word32 idx = 0;
        int nameLen;

        /* Create an object id for general name from DER encoding. */
        obj = wolfSSL_d2i_ASN1_OBJECT(NULL, (const unsigned char**)&p, len);
        if (obj == NULL)
            goto err;
        /* Pointer moved on and now update length of remaining data. */
        len -= (long)((size_t)p - (size_t)dns->name);

        /* Next is "value      [0] EXPLICIT ANY DEFINED BY type-id" */
        if (GetASNHeader(p, ASN_CONTEXT_SPECIFIC | ASN_CONSTRUCTED | 0,
                &idx, &nameLen, (word32)len) < 0)
            goto err;
        p += idx;
        len -= idx;

        /* Set the tag to object so that it gets output in raw form */
        tag = WOLFSSL_V_ASN1_SEQUENCE;
    }

    /* Create a WOLFSSL_ASN1_STRING from the DER. */
    str = wolfSSL_ASN1_STRING_type_new(tag);
    if (str == NULL) {
        goto err;
    }
    wolfSSL_ASN1_STRING_set(str, p, (int)len);

    /* Wrap string in a WOLFSSL_ASN1_TYPE. */
    type = wolfSSL_ASN1_TYPE_new();
    if (type == NULL)
        goto err;
    wolfSSL_ASN1_TYPE_set(type, tag, str);
    str = NULL; /* type now owns str */

    if (wolfSSL_GENERAL_NAME_set_type(gn, WOLFSSL_GEN_OTHERNAME)
            != WOLFSSL_SUCCESS) {
        goto err;
    }

    /* Store the object and string in general name. */
    gn->d.otherName->type_id = obj;
    gn->d.otherName->value = type;
    type = NULL; /* gn->d.otherName owns type */

    ret = 1;
err:
    if (ret != 1) {
        wolfSSL_ASN1_OBJECT_free(obj);
        wolfSSL_ASN1_TYPE_free(type);
        wolfSSL_ASN1_STRING_free(str);
    }
    return ret;
}
#endif /* OPENSSL_ALL || WOLFSSL_WPAS_SMALL */

#if defined(OPENSSL_ALL) || defined(OPENSSL_EXTRA)
static int DNS_to_GENERAL_NAME(WOLFSSL_GENERAL_NAME* gn, DNS_entry* dns)
{
    switch (dns->type) {
        case WOLFSSL_GEN_OTHERNAME:
            /* Sets gn->type internally */
            if (!wolfssl_dns_entry_othername_to_gn(dns, gn)) {
                WOLFSSL_MSG("OTHERNAME set failed");
                return WOLFSSL_FAILURE;
            }
            break;

        case WOLFSSL_GEN_EMAIL:
        case WOLFSSL_GEN_DNS:
        case WOLFSSL_GEN_URI:
        case WOLFSSL_GEN_IPADD:
        case WOLFSSL_GEN_IA5:
            gn->type = dns->type;
            gn->d.ia5->length = dns->len;
            if (wolfSSL_ASN1_STRING_set(gn->d.ia5, dns->name,
                    gn->d.ia5->length) != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("ASN1_STRING_set failed");
                return WOLFSSL_FAILURE;
            }
            break;


        case WOLFSSL_GEN_DIRNAME:
            gn->type = dns->type;
            /* wolfSSL_GENERAL_NAME_new() mallocs this by default */
            wolfSSL_ASN1_STRING_free(gn->d.ia5);
            gn->d.ia5 = NULL;

            gn->d.dirn = wolfSSL_X509_NAME_new();;
            /* @TODO extract dir name info from DNS_entry */
            break;

        case WOLFSSL_GEN_RID:
            /* registeredID is parsed into altNames unconditionally so
             * ConfirmNameConstraints can enforce RID name constraints
             * (RFC 5280 Sec. 4.2.1.10). The body uses only the raw OID
             * bytes carried in dns->name/dns->len and constructs a
             * proper ASN1_OBJECT, so this case is independent of
             * WOLFSSL_RID_ALT_NAME (which only gates the human-readable
             * ridString form). */
            gn->type = dns->type;
            /* wolfSSL_GENERAL_NAME_new() mallocs this by default */
            wolfSSL_ASN1_STRING_free(gn->d.ia5);
            gn->d.ia5 = NULL;

            gn->d.registeredID = wolfSSL_ASN1_OBJECT_new();
            if (gn->d.registeredID == NULL) {
                return WOLFSSL_FAILURE;
            }
            {
                /* Store DER-encoded OID (tag + length + content) in obj */
                word32 derSz = 1 + SetLength(dns->len, NULL) + dns->len;
                byte* der = (byte*)XMALLOC(derSz,
                    gn->d.registeredID->heap, DYNAMIC_TYPE_ASN1);
                if (der == NULL) {
                    return WOLFSSL_FAILURE;
                }
                {
                    word32 idx = 0;
                    der[idx++] = ASN_OBJECT_ID;
                    idx += SetLength(dns->len, der + idx);
                    XMEMCPY(der + idx, dns->name, dns->len);
                }
                gn->d.registeredID->obj = der;
                gn->d.registeredID->objSz = derSz;
            }
            gn->d.registeredID->dynamic |= WOLFSSL_ASN1_DYNAMIC_DATA;
            gn->d.registeredID->grp = oidCertExtType;
            break;

        case WOLFSSL_GEN_X400:
            /* Unsupported: fall through */
        case WOLFSSL_GEN_EDIPARTY:
            /* Unsupported: fall through */
        default:
            WOLFSSL_MSG("Unsupported type conversion");
            return WOLFSSL_FAILURE;
    }
    return WOLFSSL_SUCCESS;
}


static int wolfssl_x509_alt_names_to_gn(WOLFSSL_X509* x509,
    WOLFSSL_X509_EXTENSION* ext)
{
    int ret = 0;
    WOLFSSL_GENERAL_NAME* gn = NULL;
    DNS_entry* dns = NULL;
    WOLFSSL_STACK* sk;

    sk = (WOLFSSL_GENERAL_NAMES*)XMALLOC(sizeof(WOLFSSL_GENERAL_NAMES), NULL,
        DYNAMIC_TYPE_ASN1);
    if (sk == NULL) {
        goto err;
    }
    XMEMSET(sk, 0, sizeof(WOLFSSL_GENERAL_NAMES));
    sk->type = STACK_TYPE_GEN_NAME;

    if (x509->subjAltNameSet && x509->altNames != NULL) {
        /* alt names are DNS_entry structs */
        dns = x509->altNames;
        /* Currently only support GEN_DNS type */
        while (dns != NULL) {
            gn = wolfSSL_GENERAL_NAME_new();
            if (gn == NULL) {
                WOLFSSL_MSG("Error creating GENERAL_NAME");
                wolfSSL_sk_pop_free(sk, NULL);
                goto err;
            }

            if (DNS_to_GENERAL_NAME(gn, dns) != WOLFSSL_SUCCESS) {
                wolfSSL_GENERAL_NAME_free(gn);
                wolfSSL_sk_pop_free(sk, NULL);
                goto err;
            }

            if (wolfSSL_sk_GENERAL_NAME_push(sk, gn) <= 0) {
                WOLFSSL_MSG("Error pushing onto stack");
                wolfSSL_GENERAL_NAME_free(gn);
                wolfSSL_sk_pop_free(sk, NULL);
                goto err;
            }

            dns = dns->next;
        }
    }
    ext->ext_sk = sk;
    ext->crit = x509->subjAltNameCrit;

    ret = 1;
err:
    return ret;
}

/* Pushes a new X509_EXTENSION* ext onto the stack inside WOLFSSL_X509* x509.
 * This is currently a helper function for wolfSSL_X509_get_ext
 * Caller does not free the returned WOLFSSL_X509_EXTENSION*
 */
WOLFSSL_X509_EXTENSION* wolfSSL_X509_set_ext(WOLFSSL_X509* x509, int loc)
{
    int extCount = 0, length = 0, outSz = 0, sz = 0, ret = 0;
    int objSz = 0, isSet = 0;
    const byte* rawCert;
    const byte* input;
    byte* oidBuf;
    word32 oid, idx = 0, tmpIdx = 0, nid;
    WOLFSSL_X509_EXTENSION* ext = NULL;
    WC_DECLARE_VAR(cert, DecodedCert, 1, 0);

    WOLFSSL_ENTER("wolfSSL_X509_set_ext");

    if (x509 == NULL) {
        WOLFSSL_MSG("\tNot passed a certificate");
        return NULL;
    }

    if (loc < 0 || (loc > wolfSSL_X509_get_ext_count(x509))) {
        WOLFSSL_MSG("\tBad location argument");
        return NULL;
    }

    ext = wolfSSL_X509_EXTENSION_new();
    if (ext == NULL) {
        WOLFSSL_MSG("\tX509_EXTENSION_new() failed");
        return NULL;
    }

    rawCert = wolfSSL_X509_get_der((WOLFSSL_X509*)x509, &outSz);
    if (rawCert == NULL) {
        WOLFSSL_MSG("\tX509_get_der() failed");
        wolfSSL_X509_EXTENSION_free(ext);
        return NULL;
    }

#ifdef WOLFSSL_SMALL_STACK
    cert = (DecodedCert*)XMALLOC(sizeof(DecodedCert), NULL, DYNAMIC_TYPE_DCERT);
    if (cert == NULL) {
        WOLFSSL_MSG("Failed to allocate memory for DecodedCert");
        wolfSSL_X509_EXTENSION_free(ext);
        return NULL;
    }
#endif

    InitDecodedCert(cert, rawCert, (word32)outSz, 0);

    if (ParseCert(cert,
#ifdef WOLFSSL_CERT_REQ
            x509->isCSR ? CERTREQ_TYPE :
#endif
                    CA_TYPE,
            NO_VERIFY, NULL) < 0) {
        WOLFSSL_MSG("\tCertificate parsing failed");
        wolfSSL_X509_EXTENSION_free(ext);
        FreeDecodedCert(cert);
        WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
        return NULL;
    }

    input = cert->extensions;
    sz = cert->extensionsSz;

    if (input == NULL || sz == 0) {
        WOLFSSL_MSG("\tfail: should be an EXTENSIONS");
        wolfSSL_X509_EXTENSION_free(ext);
        FreeDecodedCert(cert);
        WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
        return NULL;
    }

#ifdef WOLFSSL_CERT_REQ
    if (!x509->isCSR)
#endif
    {
        if (input[idx++] != ASN_EXTENSIONS) {
            WOLFSSL_MSG("\tfail: should be an EXTENSIONS");
            wolfSSL_X509_EXTENSION_free(ext);
            FreeDecodedCert(cert);
            WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
            return NULL;
        }

        if (GetLength(input, &idx, &length, (word32)sz) < 0) {
            WOLFSSL_MSG("\tfail: invalid length");
            wolfSSL_X509_EXTENSION_free(ext);
            FreeDecodedCert(cert);
            WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
            return NULL;
        }
    }

    if (GetSequence(input, &idx, &length, (word32)sz) < 0) {
        WOLFSSL_MSG("\tfail: should be a SEQUENCE (1)");
        wolfSSL_X509_EXTENSION_free(ext);
        FreeDecodedCert(cert);
        WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
        return NULL;
    }

    while (idx < (word32)sz) {
        oid = 0;

        if (GetSequence(input, &idx, &length, (word32)sz) < 0) {
            WOLFSSL_MSG("\tfail: should be a SEQUENCE");
            wolfSSL_X509_EXTENSION_free(ext);
            FreeDecodedCert(cert);
            WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
            return NULL;
        }

        tmpIdx = idx;
        ret = GetObjectId(input, &idx, &oid, oidCertExtType, (word32)sz);
        if (ret < 0) {
            WOLFSSL_MSG("\tfail: OBJECT ID");
            wolfSSL_X509_EXTENSION_free(ext);
            FreeDecodedCert(cert);
            WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
            return NULL;
        }
        idx = tmpIdx;
        nid = (word32)oid2nid(oid, oidCertExtType);

        /* Continue while loop until extCount == loc or idx > sz */
        if (extCount != loc) {
            idx += length;
            extCount++;
            continue;
        }
        /* extCount == loc. Now get the extension. */
        /* Check if extension has been set */
        isSet = wolfSSL_X509_ext_isSet_by_NID((WOLFSSL_X509*)x509, (int)nid);

        if (wolfSSL_OBJ_nid2ln((int)nid) != NULL) {
            /* This is NOT an unknown OID. */
            ext->obj = wolfSSL_OBJ_nid2obj((int)nid);
            if (ext->obj == NULL) {
                WOLFSSL_MSG("\tfail: Invalid OBJECT");
                wolfSSL_X509_EXTENSION_free(ext);
                FreeDecodedCert(cert);
                WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
                return NULL;
            }
        }

        if (ext->obj) {
            ext->obj->nid = (int)nid;
        }

        switch (oid) {
            case BASIC_CA_OID:
            {
                WOLFSSL_ASN1_INTEGER* a;
                word32 dataIdx = idx;
                word32 dummyOid;
                int dataLen = 0;

                if (!isSet)
                    break;

                /* Set pathlength */
                a = wolfSSL_ASN1_INTEGER_new();

                /* Set the data */
                ret = GetObjectId(input, &dataIdx, &dummyOid, oidCertExtType,
                        (word32)sz) == 0;
                if (ret && dataIdx < (word32)sz) {
                    /* Skip the critical information */
                    if (input[dataIdx] == ASN_BOOLEAN) {
                        dataIdx++;
                        ret = GetLength(input, &dataIdx, &dataLen, sz) >= 0;
                        dataIdx += dataLen;
                    }
                }
                if (ret) {
                    ret = GetOctetString(input, &dataIdx, &dataLen,
                            (word32)sz) > 0;
                }
                if (ret) {
                    ret = wolfSSL_ASN1_STRING_set(&ext->value, input + dataIdx,
                            dataLen) == 1;
                }

                if (a == NULL || !ret) {
                    wolfSSL_X509_EXTENSION_free(ext);
                    FreeDecodedCert(cert);
                    WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
                    return NULL;
                }
                /* RFC 5280 4.2.1.9: only populate pathLen when the
                 * pathLenConstraint field was actually present. When it is
                 * absent no limit is imposed, and pathlen must remain NULL so
                 * it is distinguishable from a pathLenConstraint of 0. */
                if (x509->basicConstPlSet) {
                    a->length = (int)x509->pathLength;

                    /* Save ASN1_INTEGER in x509 extension */
                    ext->obj->pathlen = a;
                }
                else {
                    wolfSSL_ASN1_INTEGER_free(a);
                    ext->obj->pathlen = NULL;
                }

                ext->obj->ca = x509->isCa;
                break;
            }

            case AUTH_INFO_OID:
            {
                WOLFSSL_STACK* sk;

                if (!isSet)
                    break;

                /* Create a stack to hold both the caIssuer and ocsp objects
                    in X509_EXTENSION structure */
                sk = wolfSSL_sk_new_asn1_obj();
                if (sk == NULL) {
                    WOLFSSL_MSG("Failed to malloc stack");
                    wolfSSL_X509_EXTENSION_free(ext);
                    FreeDecodedCert(cert);
                    WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
                    return NULL;
                }

                /* Add CaIssuers object to stack */
                if (x509->authInfoCaIssuer != NULL &&
                    x509->authInfoCaIssuerSz > 0)
                {
                    WOLFSSL_ASN1_OBJECT* obj;
                    obj = wolfSSL_ASN1_OBJECT_new();
                    if (obj == NULL) {
                        WOLFSSL_MSG("Error creating ASN1 object");
                        wolfSSL_sk_ASN1_OBJECT_pop_free(sk, NULL);
                        wolfSSL_X509_EXTENSION_free(ext);
                        FreeDecodedCert(cert);
                        WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
                        return NULL;
                    }
                    obj->obj = (byte*)x509->authInfoCaIssuer;
                    obj->objSz = (unsigned int)x509->authInfoCaIssuerSz;
                    obj->grp = oidCertAuthInfoType;
                    obj->nid = WC_NID_ad_ca_issuers;

                    ret = wolfSSL_sk_ASN1_OBJECT_push(sk, obj) > 0
                            ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
                    if (ret != WOLFSSL_SUCCESS) {
                        WOLFSSL_MSG("Error pushing ASN1 object onto stack");
                        wolfSSL_ASN1_OBJECT_free(obj);
                        wolfSSL_sk_ASN1_OBJECT_pop_free(sk, NULL);
                        wolfSSL_X509_EXTENSION_free(ext);
                        FreeDecodedCert(cert);
                        WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
                        return NULL;
                    }
                }

                /* Add OCSP object to stack */
                if (x509->authInfo != NULL &&
                    x509->authInfoSz > 0)
                {
                    WOLFSSL_ASN1_OBJECT* obj;
                    obj = wolfSSL_ASN1_OBJECT_new();
                    if (obj == NULL) {
                        WOLFSSL_MSG("Error creating ASN1 object");
                        wolfSSL_sk_ASN1_OBJECT_pop_free(sk, NULL);
                        wolfSSL_X509_EXTENSION_free(ext);
                        FreeDecodedCert(cert);
                        WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
                        return NULL;
                    }
                    obj->obj = x509->authInfo;
                    obj->objSz = (unsigned int)x509->authInfoSz;
                    obj->grp = oidCertAuthInfoType;
                    obj->nid = WC_NID_ad_OCSP;

                    ret = wolfSSL_sk_ASN1_OBJECT_push(sk, obj) > 0
                            ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
                    if (ret != WOLFSSL_SUCCESS) {
                        WOLFSSL_MSG("Error pushing ASN1 object onto stack");
                        wolfSSL_ASN1_OBJECT_free(obj);
                        wolfSSL_sk_ASN1_OBJECT_pop_free(sk, NULL);
                        wolfSSL_X509_EXTENSION_free(ext);
                        FreeDecodedCert(cert);
                        WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
                        return NULL;
                    }
                }
                ext->ext_sk = sk;
                break;
            }

            case ALT_NAMES_OID:
                if (!isSet)
                    break;
                if (!wolfssl_x509_alt_names_to_gn(x509, ext)) {
                    wolfSSL_X509_EXTENSION_free(ext);
                    FreeDecodedCert(cert);
                    WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
                    return NULL;
                }
                break;
        }

        /* The ASN1_OBJECT in the extension is set in the same way
         * for recognized and for unrecognized extension types, as
         * the full OCTET STRING */

        /* Get OID from input */
        if (GetASNObjectId(input, &idx, &length, (word32)sz) != 0) {
            WOLFSSL_MSG("Failed to Get ASN Object Id");
            wolfSSL_X509_EXTENSION_free(ext);
            FreeDecodedCert(cert);
            WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
            return NULL;
        }
        oidBuf = (byte*)XMALLOC(length+1+MAX_LENGTH_SZ, NULL,
                            DYNAMIC_TYPE_TMP_BUFFER);
        if (oidBuf == NULL) {
            WOLFSSL_MSG("Failed to malloc tmp buffer");
            wolfSSL_X509_EXTENSION_free(ext);
            FreeDecodedCert(cert);
            WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
            return NULL;
        }
        oidBuf[0] = ASN_OBJECT_ID;
        objSz++;
        objSz += SetLength(length, oidBuf + 1);
        objSz += length;

        /* Set object size and reallocate space in object buffer */
        if (ext->obj == NULL) {
            ext->obj = wolfSSL_ASN1_OBJECT_new();
            if (ext->obj == NULL) {
                XFREE(oidBuf, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                wolfSSL_X509_EXTENSION_free(ext);
                FreeDecodedCert(cert);
                WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
                return NULL;
            }
        }

        if (((ext->obj->dynamic & WOLFSSL_ASN1_DYNAMIC_DATA) != 0) ||
            (ext->obj->obj == NULL)) {
            byte* tmp;
        #ifdef WOLFSSL_NO_REALLOC
            /* Don't carry the old OID over: objSz is the mapped NID's
             * canonical length, which can exceed the certificate's OID. The
             * buffer is rewritten from oidBuf below. */
            tmp = (byte*)XMALLOC(objSz, NULL, DYNAMIC_TYPE_ASN1);
            if (ext->obj->obj != NULL) {
                XFREE((byte*)ext->obj->obj, NULL, DYNAMIC_TYPE_ASN1);
            }
            ext->obj->obj = tmp;
        #else
            tmp = (byte*)XREALLOC((byte*)ext->obj->obj, objSz, NULL,
                                  DYNAMIC_TYPE_ASN1);
            if (tmp == NULL)
                XFREE((byte*)ext->obj->obj, NULL, DYNAMIC_TYPE_ASN1);
            ext->obj->obj = tmp;
        #endif
            if (ext->obj->obj == NULL) {
                wolfSSL_X509_EXTENSION_free(ext);
                FreeDecodedCert(cert);
                XFREE(oidBuf, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
                return NULL;
            }
            ext->obj->dynamic |= WOLFSSL_ASN1_DYNAMIC_DATA;
        }
        else {
            ext->obj->dynamic &= ~WOLFSSL_ASN1_DYNAMIC_DATA;
        }
        ext->obj->objSz = (unsigned int)objSz;

        /* Get OID from input and copy to ASN1_OBJECT buffer */
        XMEMCPY(oidBuf+2, input+idx, length);
        XMEMCPY((byte*)ext->obj->obj, oidBuf, ext->obj->objSz);
        XFREE(oidBuf, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        oidBuf = NULL;
        ext->obj->grp = oidCertExtType;
        ext->crit = 0;

        tmpIdx = idx + length;

        /* Get CRITICAL. If not present, defaults to false.
         * It present, must be a valid TRUE */
        if ((tmpIdx < (word32)sz) &&
            (input[tmpIdx] == ASN_BOOLEAN))
        {
            if (((tmpIdx + 2) >= (word32)sz) ||
                /* Check bool length */
                (input[tmpIdx+1] != 1) ||
                /* Assert true if CRITICAL present */
                (input[tmpIdx+2] != 0xff))
            {
                WOLFSSL_MSG("Error decoding unknown extension data");
                wolfSSL_X509_EXTENSION_free(ext);
                FreeDecodedCert(cert);
                WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
                return NULL;
            }

            ext->crit = 1;
            tmpIdx += 3;
        }

        /* Get extension data and copy as ASN1_STRING */
        if ((tmpIdx >= (word32)sz) ||
            (input[tmpIdx] != ASN_OCTET_STRING))
        {
            WOLFSSL_MSG("Error decoding unknown extension data");
            wolfSSL_X509_EXTENSION_free(ext);
            FreeDecodedCert(cert);
            WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
            return NULL;
        }

        tmpIdx++;

        if (GetLength(input, &tmpIdx, &length, (word32)sz) <= 0) {
            WOLFSSL_MSG("Error: Invalid Input Length.");
            wolfSSL_X509_EXTENSION_free(ext);
            FreeDecodedCert(cert);
            WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
            return NULL;
        }
        ext->value.data = (char*)XMALLOC(length, NULL,
            DYNAMIC_TYPE_ASN1);
        ext->value.isDynamic = 1;
        if (ext->value.data == NULL) {
            WOLFSSL_MSG("Failed to malloc ASN1_STRING data");
            wolfSSL_X509_EXTENSION_free(ext);
            FreeDecodedCert(cert);
            WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
            return NULL;
        }
        XMEMCPY(ext->value.data,input+tmpIdx,length);
        ext->value.length = length;

        break; /* Got the Extension. Now exit while loop. */

    } /* while(idx < sz) */

    /* Store the new extension in a stack inside x509
     * The extensions on the stack are free'd internally when FreeX509 is called
     */
    if (x509->ext_sk == NULL)
        x509->ext_sk = wolfSSL_sk_new_x509_ext();
    if (wolfSSL_sk_insert(x509->ext_sk, ext, -1) <= 0) {
        wolfSSL_X509_EXTENSION_free(ext);
        ext = NULL;
    }

    FreeDecodedCert(cert);
    WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
    return ext;
}

/**
 * @param str String to copy
 * @param buf Output buffer. If this contains a pointer then it is free'd
 *            with the DYNAMIC_TYPE_X509_EXT hint.
 * @param len Output length
 * @return WOLFSSL_SUCCESS on success and WOLFSSL_FAILURE on error
 */
static int asn1_string_copy_to_buffer(WOLFSSL_ASN1_STRING* str, byte** buf,
        word32* len, void* heap)
{
    if (str->data && str->length > 0) {
        if (*buf)
            XFREE(*buf, heap, DYNAMIC_TYPE_X509_EXT);
        *len = 0;
        *buf = (byte*)XMALLOC(str->length, heap, DYNAMIC_TYPE_X509_EXT);
        if (!*buf) {
            WOLFSSL_MSG("malloc error");
            return WOLFSSL_FAILURE;
        }
        *len = (word32)str->length;
        XMEMCPY(*buf, str->data, str->length);
    }

    (void)heap;
    return WOLFSSL_SUCCESS;
}

/* Handle WC_NID_subject_alt_name for wolfSSL_X509_add_ext: iterate the
 * GENERAL_NAME stack on the extension and add each entry to x509->altNames.
 * Only types whose union member is WOLFSSL_ASN1_STRING* (DNS/RFC822/URI/IP/
 * IA5) are read via gn->d.ia5; ASN_OTHER_TYPE is handled via SetOthername.
 * Other types (DIRNAME/RID/X400/EDIPARTY) are rejected to avoid the
 * type-confused union access that would XMEMCPY from a wild pointer in
 * wolfSSL_X509_add_altname_ex. */
static int wolfssl_x509_add_subj_alt_name_ext(WOLFSSL_X509 *x509,
    WOLFSSL_X509_EXTENSION *ext)
{
    WOLFSSL_GENERAL_NAMES* gns = ext->ext_sk;
    while (gns) {
        WOLFSSL_GENERAL_NAME* gn = gns->data.gn;
        if ((gn != NULL) && (gn->type == ASN_OTHER_TYPE)) {
            char *buf = NULL;
            int ret = 0;
            word32 len = 0;

            len = SetOthername(gn->d.otherName, NULL);
            if (len == WC_NO_ERR_TRACE(WOLFSSL_FAILURE)) {
                return WOLFSSL_FAILURE;
            }

            buf = (char*)XMALLOC(len, x509->heap, DYNAMIC_TYPE_X509_EXT);
            if (buf == NULL) {
                WOLFSSL_MSG("Couldn't allocate memory for othername");
                return WOLFSSL_FAILURE;
            }

            /* SetOthername() cannot fail; already passed above. */
            SetOthername(gn->d.otherName, (byte*)buf);

            ret = wolfSSL_X509_add_altname_ex(x509, buf, len,
                                              ASN_OTHER_TYPE);
            XFREE(buf, x509->heap, DYNAMIC_TYPE_X509_EXT);
            if (ret == WC_NO_ERR_TRACE(WOLFSSL_FAILURE)) {
                 WOLFSSL_MSG("wolfSSL_X509_add_altname_ex() failed");
                 return WOLFSSL_FAILURE;
            }
        }
        /* Only types whose union member are WOLFSSL_ASN1_STRING. */
        else if (gn == NULL) {
            WOLFSSL_MSG("Subject alternative name missing");
            return WOLFSSL_FAILURE;
        }
        else {
            if ((gn->type != ASN_RFC822_TYPE && gn->type != ASN_DNS_TYPE &&
                 gn->type != ASN_URI_TYPE && gn->type != ASN_IP_TYPE &&
                 gn->type != WOLFSSL_GEN_IA5) || (gn->d.ia5 == NULL)) {
                WOLFSSL_MSG("Subject alternative name unsupported "
                            "GeneralName type or missing name");
                return WOLFSSL_FAILURE;
            }
            if (wolfSSL_X509_add_altname_ex(x509, gn->d.ia5->data,
                         gn->d.ia5->length, gn->type) != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("Failed to add subject alternative name");
                return WOLFSSL_FAILURE;
            }
        }
        gns = gns->next;
    }
    x509->subjAltNameSet = 1;
    x509->subjAltNameCrit = (byte)ext->crit;
    return WOLFSSL_SUCCESS;
}

#ifdef WOLFSSL_CUSTOM_OID
/* Handle the default (unrecognized NID) case of wolfSSL_X509_add_ext when
 * custom-OID extensions are enabled: copy the extension OID text and value
 * into the next free slot in x509->custom_exts, taking ownership of the
 * allocations on success. */
static int wolfssl_x509_add_custom_ext(WOLFSSL_X509 *x509,
    WOLFSSL_X509_EXTENSION *ext)
{
    char *oid = NULL;
    byte *val = NULL;
    int err = 0;

    if ((ext->obj == NULL) || (ext->value.length == 0) ||
        (ext->value.data == NULL)) {
        WOLFSSL_MSG("Extension has insufficient information.");
        return WOLFSSL_FAILURE;
    }

    if ((x509->customExtCount < 0) ||
        (x509->customExtCount >= NUM_CUSTOM_EXT)) {
        WOLFSSL_MSG("Bad value for customExtCount.");
        return WOLFSSL_FAILURE;
    }

    /* This is a viable custom extension. */
    oid = (char*)XMALLOC(MAX_OID_STRING_SZ, x509->heap,
        DYNAMIC_TYPE_X509_EXT);
    val = (byte*)XMALLOC(ext->value.length, x509->heap,
        DYNAMIC_TYPE_X509_EXT);
    if ((oid == NULL) || (val == NULL)) {
        WOLFSSL_MSG("Memory allocation failure.\n");
        err = 1;
    }

    if (err == 0) {
        XMEMCPY(val, ext->value.data, ext->value.length);
        if (wolfSSL_OBJ_obj2txt(oid, MAX_OID_STRING_SZ, ext->obj, 1) < 0) {
            err = 1;
        }
    }

    if (err == 1) {
        XFREE(val, x509->heap, DYNAMIC_TYPE_X509_EXT);
        XFREE(oid, x509->heap, DYNAMIC_TYPE_X509_EXT);
        return WOLFSSL_FAILURE;
    }

    /* ext->crit is WOLFSSL_ASN1_BOOLEAN */
    if (ext->crit != 0 && ext->crit != -1) {
        XFREE(val, x509->heap, DYNAMIC_TYPE_X509_EXT);
        XFREE(oid, x509->heap, DYNAMIC_TYPE_X509_EXT);
        return WOLFSSL_FAILURE;
    }

    /* x509->custom_exts now owns the buffers and they must be managed. */
    x509->custom_exts[x509->customExtCount].oid = oid;
    x509->custom_exts[x509->customExtCount].crit = (byte)ext->crit;
    x509->custom_exts[x509->customExtCount].val = val;
    x509->custom_exts[x509->customExtCount].valSz = ext->value.length;
    x509->customExtCount++;
    return WOLFSSL_SUCCESS;
}
#endif /* WOLFSSL_CUSTOM_OID */

int wolfSSL_X509_add_ext(WOLFSSL_X509 *x509, WOLFSSL_X509_EXTENSION *ext,
    int loc)
{
    int nid;

    WOLFSSL_ENTER("wolfSSL_X509_add_ext");

    if (!x509 || !ext || loc >= 0) {
        WOLFSSL_MSG("Bad parameter");
        return WOLFSSL_FAILURE;
    }
    nid = (ext->obj != NULL) ? ext->obj->type : ext->value.nid;

    switch (nid) {
    case WC_NID_authority_key_identifier:
        if (x509->authKeyIdSrc != NULL) {
            /* If authKeyId points into authKeyIdSrc then free it and
             * revert to old functionality */
            XFREE(x509->authKeyIdSrc, x509->heap, DYNAMIC_TYPE_X509_EXT);
            x509->authKeyIdSrc = NULL;
            x509->authKeyId = NULL;
        }
        if (asn1_string_copy_to_buffer(&ext->value, &x509->authKeyId,
                &x509->authKeyIdSz, x509->heap) != WOLFSSL_SUCCESS) {
            WOLFSSL_MSG("asn1_string_copy_to_buffer error");
            return WOLFSSL_FAILURE;
        }
        x509->authKeyIdCrit = (byte)ext->crit;
        break;
    case WC_NID_subject_key_identifier:
        if (asn1_string_copy_to_buffer(&ext->value, &x509->subjKeyId,
                &x509->subjKeyIdSz, x509->heap) != WOLFSSL_SUCCESS) {
            WOLFSSL_MSG("asn1_string_copy_to_buffer error");
            return WOLFSSL_FAILURE;
        }
        x509->subjKeyIdCrit = (byte)ext->crit;
        break;
    case WC_NID_subject_alt_name:
        if (wolfssl_x509_add_subj_alt_name_ext(x509, ext) != WOLFSSL_SUCCESS) {
            return WOLFSSL_FAILURE;
        }
        break;
    case WC_NID_key_usage:
        if (ext && ext->value.data) {
            if (ext->value.length == sizeof(word16)) {
                /* if ext->value is already word16, set directly */
                word16 ku;
                XMEMCPY(&ku, ext->value.data, sizeof(word16));
                x509->keyUsage = ku;
#ifdef BIG_ENDIAN_ORDER
                x509->keyUsage = rotlFixed16(x509->keyUsage, 8U);
#endif
                x509->keyUsageCrit = (byte)ext->crit;
                x509->keyUsageSet = 1;
            }
            else if (ext->value.length > 0) {
                /* ext->value is comma-delimited string, convert to word16 */
                if (ParseKeyUsageStr(ext->value.data, &x509->keyUsage,
                                     x509->heap) != 0) {
                    return WOLFSSL_FAILURE;
                }
                x509->keyUsageCrit = (byte)ext->crit;
                x509->keyUsageSet = 1;
            }
            else {
                return WOLFSSL_FAILURE;
            }
        }
        break;
    case WC_NID_ext_key_usage:
        if (ext && ext->value.data) {
            if (ext->value.length == sizeof(byte)) {
                /* if ext->value is already 1 byte, set directly */
                x509->extKeyUsage = *(byte*)ext->value.data;
                x509->extKeyUsageCrit = (byte)ext->crit;
            }
            else if (ext->value.length > 0) {
                /* ext->value is comma-delimited string, convert to word16 */
                if (ParseExtKeyUsageStr(ext->value.data, &x509->extKeyUsage,
                                        x509->heap) != 0) {
                    return WOLFSSL_FAILURE;
                }
                x509->extKeyUsageCrit = (byte)ext->crit;
            }
            else {
                return WOLFSSL_FAILURE;
            }
        }
        break;
    case WC_NID_basic_constraints:
        if (ext->obj) {
            x509->isCa = (byte)ext->obj->ca;
            x509->basicConstCrit = (byte)ext->crit;
            if (ext->obj->pathlen) {
                x509->pathLength = (word32)ext->obj->pathlen->length;
                x509->basicConstPlSet = 1;
                x509->pathLengthSet = 1;
            }
            x509->basicConstSet = 1;
        }
        break;
    default:
#ifdef WOLFSSL_CUSTOM_OID
        if (wolfssl_x509_add_custom_ext(x509, ext) != WOLFSSL_SUCCESS) {
            return WOLFSSL_FAILURE;
        }
        break;
#else
        WOLFSSL_MSG("Unsupported extension to add");
        return WOLFSSL_FAILURE;
#endif /* WOLFSSL_CUSTOM_OID */
    } /* switch (nid) */

    return WOLFSSL_SUCCESS;
}

/* Returns pointer to ASN1_STRING in X509_EXTENSION object */
static WOLFSSL_ASN1_STRING* wolfSSL_X509_EXTENSION_get_data_internal(
    WOLFSSL_X509_EXTENSION* ext)
{
    WOLFSSL_ENTER("wolfSSL_X509_EXTENSION_get_data_internal");
    if (ext == NULL)
        return NULL;

    return &ext->value;
}


#ifndef NO_BIO

#ifndef MAX_INDENT
    #define MAX_INDENT 40
#endif


/* Return 0 on success and 1 on failure. Copies ext data to bio, using indent
 *  to pad the output. flag is ignored. */
int wolfSSL_X509V3_EXT_print(WOLFSSL_BIO *out, WOLFSSL_X509_EXTENSION *ext,
        unsigned long flag, int indent)
{
    WOLFSSL_ASN1_OBJECT* obj;
    WOLFSSL_ASN1_STRING* str;
    int nid;
    int rc = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
    char tmp[CTC_NAME_SIZE*2 + 1];
    const int tmpSz = sizeof(tmp);
    int tmpLen = 0;
    WOLFSSL_ENTER("wolfSSL_X509V3_EXT_print");

    if (indent < 0) indent = 0;
    if (indent > MAX_INDENT) indent = MAX_INDENT;

    if ((out == NULL) || (ext == NULL)) {
        WOLFSSL_MSG("NULL parameter error");
        return rc;
    }

    obj = wolfSSL_X509_EXTENSION_get_object(ext);
    if (obj == NULL) {
        WOLFSSL_MSG("Error getting ASN1_OBJECT from X509_EXTENSION");
        return rc;
    }

    str = wolfSSL_X509_EXTENSION_get_data_internal(ext);
    if (str == NULL) {
        WOLFSSL_MSG("Error getting ASN1_STRING from X509_EXTENSION");
        return rc;
    }

    /* Print extension based on the type */
    nid = wolfSSL_OBJ_obj2nid(obj);
    switch (nid) {
        case BASIC_CA_OID:
        {
            char isCa[] = "TRUE";
            char notCa[] = "FALSE";
            if ((tmpLen = XSNPRINTF(tmp, tmpSz, "%*sCA:%s", indent, "",
                                     obj->ca ? isCa : notCa))
                >= tmpSz)
                return rc;
            break;
        }
        case ALT_NAMES_OID:
        {
            WOLFSSL_STACK* sk;
            char* val;
            int valLen;
            int len;

            sk = ext->ext_sk;
            while (sk != NULL) {
                if (sk->type == STACK_TYPE_GEN_NAME && sk->data.gn) {
                    /* str is GENERAL_NAME for subject alternative name ext */
                    str = sk->data.gn->d.ia5;
                    len = str->length + 2; /* + 2 for NULL char and "," */
                    if (len > tmpSz) {
                        WOLFSSL_MSG("len greater than buffer size");
                        return rc;
                    }

                    val = (char*)XMALLOC(len + indent, NULL,
                                                       DYNAMIC_TYPE_TMP_BUFFER);
                    if (val == NULL) {
                        WOLFSSL_MSG("Memory error");
                        return rc;
                    }
                    valLen = XSNPRINTF(val, (size_t)len + indent,
                            "%*s%.*s", indent, "", str->length, str->data);
                    if ((valLen < 0) || (valLen >= len + indent)
                            || ((tmpLen + valLen) >= tmpSz)) {
                        XFREE(val, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                        return rc;
                    }
                    XMEMCPY(tmp + tmpLen, val, valLen);
                    tmpLen += valLen;
                    XFREE(val, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                }
                sk = sk->next;
            }
            break;
        }
        case AUTH_KEY_OID:
        case SUBJ_KEY_OID:
        {
            char* asn1str;
            asn1str = wolfSSL_i2s_ASN1_STRING(NULL, str);
            if (asn1str == NULL) {
                WOLFSSL_MSG("wolfSSL_i2s_ASN1_STRING returned NULL");
                return rc;
            }
            tmpLen = XSNPRINTF(tmp, tmpSz, "%*s%s", indent, "", asn1str);
            XFREE(asn1str, NULL, DYNAMIC_TYPE_TMP_BUFFER);
            if (tmpLen >= tmpSz)
                tmpLen = tmpSz - 1;
            break;
        }
        case AUTH_INFO_OID:
        case CERT_POLICY_OID:
        case CRL_DIST_OID:
        case KEY_USAGE_OID:
            WOLFSSL_MSG("X509V3_EXT_print not yet implemented for ext type");
            break;

        default:
            if ((tmpLen = XSNPRINTF(
                     tmp, tmpSz, "%*s%s", indent, "", str->strData))
                >= tmpSz)
                return rc;
    }

    if (wolfSSL_BIO_write(out, tmp, tmpLen) == tmpLen) {
        rc = WOLFSSL_SUCCESS;
    }
    (void) flag;

    return rc;
}
#endif /* !NO_BIO */

#ifndef NO_WOLFSSL_STUB
int wolfSSL_X509V3_EXT_add_nconf(WOLFSSL_CONF *conf, WOLFSSL_X509V3_CTX *ctx,
        const char *section, WOLFSSL_X509 *cert)
{
    WOLFSSL_ENTER("wolfSSL_X509V3_EXT_add_nconf");
    WOLFSSL_STUB("wolfSSL_X509V3_EXT_add_nconf");
    (void)conf;
    (void)ctx;
    (void)section;
    (void)cert;
    return WOLFSSL_SUCCESS;
}
#endif

/* Find extension by NID in a stack of extensions.
 *
 * @param sk Stack of extensions
 * @param nid ID to search for
 * @param lastpos Start search from this position (not inclusive, -1 means start from beginning)
 * @return Index of matching extension or -1 on error/not found
 */
int wolfSSL_X509v3_get_ext_by_NID(const WOLF_STACK_OF(WOLFSSL_X509_EXTENSION)* sk,
                                 int nid, int lastpos)
{
    int i;
    WOLFSSL_ENTER("wolfSSL_X509v3_get_ext_by_NID");

    if (sk == NULL) {
        WOLFSSL_MSG("Stack pointer is NULL");
        return WOLFSSL_FATAL_ERROR;
    }

    if (lastpos < -1 || lastpos >= wolfSSL_sk_num(sk)) {
        WOLFSSL_MSG("Invalid position argument");
        return WOLFSSL_FATAL_ERROR;
    }

    for (i = lastpos + 1; i < wolfSSL_sk_num(sk); i++) {
        WOLFSSL_X509_EXTENSION* ext = wolfSSL_sk_X509_EXTENSION_value(sk, i);
        if (ext && ext->obj) {
            if (wolfSSL_OBJ_obj2nid(ext->obj) == nid)
                return i;
        }
    }

    /* Not found */
    return -1;
}

/* Get extension from a stack of extensions by location.
 *
 * @param sk Stack of extensions
 * @param loc Index of extension to retrieve
 * @return Pointer to extension or NULL on error
 */
WOLFSSL_X509_EXTENSION* wolfSSL_X509v3_get_ext(
    const WOLF_STACK_OF(WOLFSSL_X509_EXTENSION)* sk, int loc)
{
    WOLFSSL_ENTER("wolfSSL_X509v3_get_ext");

    if (sk == NULL) {
        WOLFSSL_MSG("Stack pointer is NULL");
        return NULL;
    }

    if (loc < 0 || loc >= wolfSSL_sk_num(sk)) {
        WOLFSSL_MSG("Invalid location argument");
        return NULL;
    }

    return wolfSSL_sk_X509_EXTENSION_value(sk, loc);
}

/* Returns crit flag in X509_EXTENSION object */
int wolfSSL_X509_EXTENSION_get_critical(const WOLFSSL_X509_EXTENSION* ex)
{
    WOLFSSL_ENTER("wolfSSL_X509_EXTENSION_get_critical");
    if (ex == NULL)
        return BAD_FUNC_ARG;
    return ex->crit;
}

/* Sets if the extension is critical
 * returns WOLFSSL_SUCCESS on success
 */
int wolfSSL_X509_EXTENSION_set_critical(WOLFSSL_X509_EXTENSION* ex, int crit)
{
    WOLFSSL_ENTER("wolfSSL_X509_EXTENSION_set_critical");
    if (ex == NULL)
        return WOLFSSL_FAILURE;
    ex->crit = crit;
    return WOLFSSL_SUCCESS;
}

/* Creates v3_ext_method for a given X509v3 extension
 *
 * ex   : The X509_EXTENSION used to create v3_ext_method. If the extension is
 * not NULL, get the NID of the extension object and populate the
 * extension type-specific X509V3_EXT_* function(s) in v3_ext_method.
 *
 * Returns NULL on error or pointer to the v3_ext_method populated with
 * extension type-specific X509V3_EXT_* function(s).
 *
 * NOTE: WC_NID_subject_key_identifier is currently the only extension
 * implementing the X509V3_EXT_* functions, as it is the only type called
 * directly by QT. The other extension types return a pointer to a
 * v3_ext_method struct that contains only the NID.
 */
#if defined(OPENSSL_VERSION_NUMBER) && OPENSSL_VERSION_NUMBER >= 0x10100000L
const WOLFSSL_v3_ext_method* wolfSSL_X509V3_EXT_get(WOLFSSL_X509_EXTENSION* ex)
#else
WOLFSSL_v3_ext_method* wolfSSL_X509V3_EXT_get(WOLFSSL_X509_EXTENSION* ex)
#endif
{
    int nid;
    WOLFSSL_v3_ext_method method;

    WOLFSSL_ENTER("wolfSSL_X509V3_EXT_get");
    if ((ex == NULL) || (ex->obj == NULL)) {
        WOLFSSL_MSG("Passed an invalid X509_EXTENSION*");
        return NULL;
    }
    /* Initialize method to 0 */
    XMEMSET(&method, 0, sizeof(struct WOLFSSL_v3_ext_method));

    nid = ex->obj->nid;
    if (nid <= 0) {
        WOLFSSL_MSG("Failed to get nid from passed extension object");
        return NULL;
    }
    switch (nid) {
        case WC_NID_basic_constraints:
            break;
        case WC_NID_subject_key_identifier:
            method.i2s = (WOLFSSL_X509V3_EXT_I2S)wolfSSL_i2s_ASN1_STRING;
            break;
        case WC_NID_subject_alt_name:
            WOLFSSL_MSG("i2v function not yet implemented for Subject "
                        "Alternative Name");
            break;
        case WC_NID_key_usage:
            WOLFSSL_MSG("i2v function not yet implemented for Key Usage");
            break;
        case WC_NID_authority_key_identifier:
            WOLFSSL_MSG("i2v function not yet implemented for Auth Key Id");
            break;
        case WC_NID_info_access:
            WOLFSSL_MSG("i2v function not yet implemented for Info Access");
            break;
        case WC_NID_ext_key_usage:
            WOLFSSL_MSG("i2v function not yet implemented for Ext Key Usage");
            break;
        case WC_NID_certificate_policies:
            WOLFSSL_MSG("r2i function not yet implemented for Cert Policies");
            break;
        case WC_NID_crl_distribution_points:
            WOLFSSL_MSG("r2i function not yet implemented for CRL Dist Points");
            break;
        default:
            /* If extension type is unknown, return NULL -- QT makes call to
                X509_EXTENSION_get_data() if there is no v3_ext_method */
            WOLFSSL_MSG("X509V3_EXT_get(): Unknown extension type found");
            return NULL;
    }

    method.ext_nid = nid;
    ex->ext_method = method;

#if defined(OPENSSL_VERSION_NUMBER) && OPENSSL_VERSION_NUMBER >= 0x10100000L
    return (const WOLFSSL_v3_ext_method*)&ex->ext_method;
#else
    return (WOLFSSL_v3_ext_method*)&ex->ext_method;
#endif
}

/* Create an Authority Info Access (AIA) from the contents of the extension.
 *
 * AIA is a stack of Access Descriptions.
 *
 * RFC 5280: 4.2.2.1
 *
 * @param [in] ext  X509v3 extension.
 * @return  Stack of Access Descriptions as an AIA on success.
 * @return  NULL on error.
 */
static WOLFSSL_AUTHORITY_INFO_ACCESS* wolfssl_x509v3_ext_aia_d2i(
    WOLFSSL_X509_EXTENSION* ext)
{
    int err = 0;
    int ret;
    WOLFSSL_AUTHORITY_INFO_ACCESS* aia = NULL;
    WOLFSSL_STACK* sk;
    WOLFSSL_ACCESS_DESCRIPTION* ad = NULL;

    /* Get the type specific data of this extension. */
    sk = ext->ext_sk;
    if (sk == NULL) {
        WOLFSSL_MSG("ACCESS_DESCRIPTION stack NULL");
        err = 1;
    }

    if (!err) {
        /* AUTHORITY_INFO_ACCESS is a stack of ACCESS_DESCRIPTION entries. */
        aia = wolfSSL_sk_new_null();
        if (aia == NULL) {
            WOLFSSL_MSG("Failed to malloc AUTHORITY_INFO_ACCESS");
            err = 1;
        }
    }
    if (!err) {
        /* AIA is a stack of Access Descriptions. */
        aia->type = STACK_TYPE_ACCESS_DESCRIPTION;
    }

    while ((!err) && (sk != NULL)) {
        WOLFSSL_ASN1_OBJECT* aiaEntry;

        /* Looking for objects in extension's data. */
        if (sk->type != STACK_TYPE_OBJ) {
            sk = sk->next;
            continue;
        }

        /* Get ASN.1 Object from the stack entry's data. */
        aiaEntry = sk->data.obj;

        /* ACCESS_DESCRIPTION has two members: method and location.
         *  method: ASN1_OBJECT as either AIA_OCSP_OID or AIA_CA_ISSUER_OID
         *  location: GENERAL_NAME structure containing the URI.
         */

        /* Allocate a new Access Description. */
        ad = (WOLFSSL_ACCESS_DESCRIPTION*)XMALLOC(
            sizeof(WOLFSSL_ACCESS_DESCRIPTION), NULL, DYNAMIC_TYPE_X509_EXT);
        if (ad == NULL) {
            WOLFSSL_MSG("Failed to malloc ACCESS_DESCRIPTION");
            err = 1;
            break;
        }
        XMEMSET(ad, 0, sizeof(WOLFSSL_ACCESS_DESCRIPTION));

        /* Create new ASN1_OBJECT from NID. */
        ad->method = wolfSSL_OBJ_nid2obj(aiaEntry->nid);
        if (ad->method == NULL) {
            WOLFSSL_MSG("OBJ_nid2obj() failed");
            err = 1;
            break;
        }

        /* Allocate memory for GENERAL NAME. */
        ad->location = wolfSSL_GENERAL_NAME_new();
        if (ad->location == NULL) {
            WOLFSSL_MSG("Failed to malloc GENERAL_NAME");
            err = 1;
            break;
        }

        /* Set the type of general name to URI (only type supported). */
        ret = wolfSSL_GENERAL_NAME_set_type(ad->location, WOLFSSL_GEN_URI);
        if (ret != WOLFSSL_SUCCESS) {
            err = 1;
            break;
        }

        /* Set the URI into GENERAL_NAME. */
        ret = wolfSSL_ASN1_STRING_set(ad->location->d.uniformResourceIdentifier,
            aiaEntry->obj, aiaEntry->objSz);
        if (ret != WOLFSSL_SUCCESS) {
            WOLFSSL_MSG("ASN1_STRING_set() failed");
            err = 1;
            break;
        }
        /* Push onto AUTHORITY_INFO_ACCESS stack. */
        ret = wolfSSL_sk_ACCESS_DESCRIPTION_push(aia, ad) > 0
                ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
        if (ret != WOLFSSL_SUCCESS) {
            WOLFSSL_MSG("Error pushing ASN1 AD onto stack");
            err = 1;
            break;
        }
        /* Set to NULL so that it doesn't get freed now it is in AIA stack. */
        ad = NULL;

        sk = sk->next;
    }

    if (err) {
        /* Dispose of Access Description if not put in stack. */
        if (ad != NULL) {
            wolfSSL_ASN1_OBJECT_free(ad->method);
            wolfSSL_GENERAL_NAME_free(ad->location);
            XFREE(ad, NULL, DYNAMIC_TYPE_X509_EXT);
        }
        /* Dispose of incomplete Access Description stack. */
        wolfSSL_sk_ACCESS_DESCRIPTION_pop_free(aia, NULL);
        aia = NULL;
    }
    return aia;
}

/* Parses and returns an x509v3 extension internal structure.
 *
 * ext   : The X509_EXTENSION for parsing internal structure. If extension is
 * not NULL, get the NID of the extension object and create a new
 * extension-specific internal structure based on the extension type.
 *
 * Returns NULL on error or if NID is not found, otherwise returns a pointer to
 * the extension type-specific X509_EXTENSION internal structure.
 * Return is expected to be free'd by caller.
 */
void* wolfSSL_X509V3_EXT_d2i(WOLFSSL_X509_EXTENSION* ext)
{
    const WOLFSSL_v3_ext_method* method;
    int ret;
    WOLFSSL_ASN1_OBJECT* object;
    WOLFSSL_BASIC_CONSTRAINTS* bc;
    WOLFSSL_AUTHORITY_KEYID* akey;
    WOLFSSL_ASN1_STRING* asn1String = NULL, *newString = NULL;
    WOLFSSL_STACK* sk;
    void *data = NULL;
    WC_DECLARE_VAR(cert, DecodedCert, 1, 0);

    WOLFSSL_ENTER("wolfSSL_X509V3_EXT_d2i");

    if (ext == NULL) {
        WOLFSSL_MSG("Bad function Argument");
        return NULL;
    }

    object = wolfSSL_X509_EXTENSION_get_object(ext);
    if (object == NULL) {
        WOLFSSL_MSG("X509_EXTENSION_get_object failed");
        return NULL;
    }
    /* extract extension info */
    method = wolfSSL_X509V3_EXT_get(ext);
    if (method == NULL) {
        WOLFSSL_MSG("wolfSSL_X509V3_EXT_get error");
        return NULL;
    }

#ifdef WOLFSSL_SMALL_STACK
    cert = (DecodedCert *)XMALLOC(sizeof(*cert), NULL,
            DYNAMIC_TYPE_X509_EXT);
    if (cert == NULL) {
        WOLFSSL_MSG("\tout of memory");
        return NULL;
    }
#endif

    InitDecodedCert(cert, NULL, 0, NULL);

    if ((object->type != WC_NID_basic_constraints) &&
        (object->type != WC_NID_subject_alt_name) &&
        (object->type != WC_NID_info_access)) {

        asn1String = wolfSSL_X509_EXTENSION_get_data_internal(ext);
        if (asn1String == NULL) {
            WOLFSSL_MSG("X509_EXTENSION_get_data() failed");
            goto out;
        }

        ret = DecodeExtensionType((const byte*)asn1String->data,
                asn1String->length, object->type, (byte)ext->crit, cert, NULL);
        if (ret != 0) {
            WOLFSSL_MSG("DecodeExtensionType() failed");
            goto out;
        }
    }

    /* Return pointer to proper internal structure based on NID */
    switch (object->type) {
        /* basicConstraints */
        case WC_NID_basic_constraints:
            WOLFSSL_MSG("basicConstraints");
            /* Allocate new BASIC_CONSTRAINTS structure */
            bc = wolfSSL_BASIC_CONSTRAINTS_new();
            if (bc == NULL) {
                WOLFSSL_MSG("Failed to malloc basic constraints");
                break;
            }
            /* Copy pathlen and CA into BASIC_CONSTRAINTS from object */
            bc->ca = object->ca;
            /* RFC 5280 4.2.1.9:
             *   "A pathLenConstraint of zero indicates that no non-self-issued
             *    intermediate CA certificates may follow in a valid
             *    certification path."
             * Check for length of 0 or greater.
             */
            if ((object->pathlen != NULL) && (object->pathlen->length >= 0)) {
                bc->pathlen = wolfSSL_ASN1_INTEGER_dup(object->pathlen);
                if (bc->pathlen == NULL) {
                    WOLFSSL_MSG("Failed to duplicate ASN1_INTEGER");
                    wolfSSL_BASIC_CONSTRAINTS_free(bc);
                    break;
                }
            }
            else
                bc->pathlen = NULL;

            data = bc;
            break;

        /* subjectKeyIdentifier */
        case WC_NID_subject_key_identifier:
        {
            WOLFSSL_MSG("subjectKeyIdentifier");

            newString = wolfSSL_ASN1_STRING_new();
            if (newString == NULL) {
                WOLFSSL_MSG("Failed to malloc ASN1_STRING");
                break;
            }
            ret = wolfSSL_ASN1_STRING_set(newString, cert->extSubjKeyId,
                                          cert->extSubjKeyIdSz);
            if (ret != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("ASN1_STRING_set() failed");
                wolfSSL_ASN1_STRING_free(newString);
                break;
            };

            newString->type = asn1String->type;
            data = newString;
            break;
        }

        /* authorityKeyIdentifier */
        case WC_NID_authority_key_identifier:
        {
            WOLFSSL_MSG("AuthorityKeyIdentifier");

            akey = (WOLFSSL_AUTHORITY_KEYID*)
                    XMALLOC(sizeof(WOLFSSL_AUTHORITY_KEYID), NULL,
                    DYNAMIC_TYPE_X509_EXT);
            if (akey == NULL) {
                WOLFSSL_MSG("Failed to malloc authority key id");
                break;
            }

            XMEMSET(akey, 0, sizeof(WOLFSSL_AUTHORITY_KEYID));

            akey->keyid = wolfSSL_ASN1_STRING_new();
            if (akey->keyid == NULL) {
                WOLFSSL_MSG("ASN1_STRING_new() failed");
                wolfSSL_AUTHORITY_KEYID_free(akey);
                break;
            }

            ret = wolfSSL_ASN1_STRING_set(akey->keyid, cert->extAuthKeyId,
                                          cert->extAuthKeyIdSz);
            if (ret != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("ASN1_STRING_set() failed");
                wolfSSL_AUTHORITY_KEYID_free(akey);
                break;
            };
            akey->keyid->type   = asn1String->type;

            /* For now, set issuer and serial to NULL. This may need to be
                updated for future use */
            akey->issuer = NULL;
            akey->serial = NULL;

            data = akey;
            break;
        }

        /* keyUsage */
        case WC_NID_key_usage:
        {
            WOLFSSL_MSG("keyUsage");

            /* This may need to be updated for future use. The i2v method for
                keyUsage is not currently set. For now, return the ASN1_STRING
                representation of KeyUsage bit string */
            newString = wolfSSL_ASN1_STRING_new();
            if (newString == NULL) {
                WOLFSSL_MSG("Failed to malloc ASN1_STRING");
                break;
            }
            ret = wolfSSL_ASN1_STRING_set(newString, (byte*)&cert->extKeyUsage,
                                                                sizeof(word16));
            if (ret != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("ASN1_STRING_set() failed");
                wolfSSL_ASN1_STRING_free(newString);
                break;
            };
            newString->type = asn1String->type;
            data = newString;
            break;
        }

        /* extKeyUsage */
        case WC_NID_ext_key_usage:
            WOLFSSL_MSG("extKeyUsage not supported yet");
            break;

        /* certificatePolicies */
        case WC_NID_certificate_policies:
            WOLFSSL_MSG("certificatePolicies not supported yet");
            break;

        /* cRLDistributionPoints */
        case WC_NID_crl_distribution_points:
            WOLFSSL_MSG("cRLDistributionPoints not supported yet");
            break;

        case WC_NID_subject_alt_name:
            if (ext->ext_sk == NULL) {
                WOLFSSL_MSG("Subject alt name stack NULL");
                break;
            }
            sk = wolfSSL_sk_dup(ext->ext_sk);
            if (sk == NULL) {
                WOLFSSL_MSG("Failed to duplicate subject alt names stack.");
                break;
            }
            data = sk;
            break;

        /* authorityInfoAccess */
        case WC_NID_info_access:
            WOLFSSL_MSG("AuthorityInfoAccess");
            data = wolfssl_x509v3_ext_aia_d2i(ext);
            break;

        default:
            WOLFSSL_MSG("Extension NID not in table, returning NULL");
            break;
    }

out:

    FreeDecodedCert(cert);
    WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_X509_EXT);

    return data;
}

/* Looks for the extension matching the passed in nid
 *
 * x509 : certificate to get parse through for extension.
 * nid : Extension OID to be found.
 * lastPos : Start search from extension after lastPos.
 *           Set to -1 to search from index 0.
 * return >= 0 If successful the extension index is returned.
 * return WOLFSSL_FATAL_ERROR If extension is not found or error is encountered.
 */
int wolfSSL_X509_get_ext_by_NID(const WOLFSSL_X509* x509, int nid, int lastPos)
{
    int extCount = 0, length = 0, outSz = 0, sz = 0, ret = 0;
    int isSet = 0, found = 0, loc;
    const byte* rawCert;
    const byte* input;
    word32 oid, idx = 0, tmpIdx = 0, foundNID;
    WC_DECLARE_VAR(cert, DecodedCert, 1, 0);

    WOLFSSL_ENTER("wolfSSL_X509_get_ext_by_NID");

    if (x509 == NULL) {
        WOLFSSL_MSG("\tNot passed a certificate");
        return WOLFSSL_FATAL_ERROR;
    }

    if (lastPos < -1 || (lastPos > (wolfSSL_X509_get_ext_count(x509) - 1))) {
        WOLFSSL_MSG("\tBad location argument");
        return WOLFSSL_FATAL_ERROR;
    }

    loc = lastPos + 1;

    rawCert = wolfSSL_X509_get_der((WOLFSSL_X509*)x509, &outSz);
    if (rawCert == NULL) {
        WOLFSSL_MSG("\tX509_get_der() failed");
        return WOLFSSL_FATAL_ERROR;
    }

#ifdef WOLFSSL_SMALL_STACK
    cert = (DecodedCert *)XMALLOC(sizeof(*cert), x509->heap,
                                  DYNAMIC_TYPE_DCERT);
    if (cert == NULL) {
        WOLFSSL_MSG("\tout of memory");
        return WOLFSSL_FATAL_ERROR;
    }
#endif

    InitDecodedCert( cert, rawCert, (word32)outSz, 0);

    if (ParseCert(cert,
#ifdef WOLFSSL_CERT_REQ
            x509->isCSR ? CERTREQ_TYPE :
#endif
            CA_TYPE,
            NO_VERIFY, NULL) < 0) {
        WOLFSSL_MSG("\tCertificate parsing failed");
        goto out;
    }

    input = cert->extensions;
    sz = cert->extensionsSz;

    if (input == NULL || sz == 0) {
        WOLFSSL_MSG("\tfail: should be an EXTENSIONS");
        goto out;
    }

#ifdef WOLFSSL_CERT_REQ
    if (!x509->isCSR)
#endif
    {
        if (input[idx++] != ASN_EXTENSIONS) {
            WOLFSSL_MSG("\tfail: should be an EXTENSIONS");
            goto out;
        }

        if (GetLength(input, &idx, &length, (word32)sz) < 0) {
            WOLFSSL_MSG("\tfail: invalid length");
            goto out;
        }
    }

    if (GetSequence(input, &idx, &length, (word32)sz) < 0) {
        WOLFSSL_MSG("\tfail: should be a SEQUENCE (1)");
        goto out;
    }

    while (idx < (word32)sz) {
        oid = 0;

        if (GetSequence(input, &idx, &length, (word32)sz) < 0) {
            WOLFSSL_MSG("\tfail: should be a SEQUENCE");
            goto out;
        }

        tmpIdx = idx;
        ret = GetObjectId(input, &idx, &oid, oidCertExtType, (word32)sz);
        if (ret < 0) {
            WOLFSSL_MSG("\tfail: OBJECT ID");
            goto out;
        }
        idx = tmpIdx;
        foundNID = (word32)oid2nid(oid, oidCertExtType);

        if (extCount >= loc) {
            /* extCount >= loc. Now check if extension has been set */
            isSet = wolfSSL_X509_ext_isSet_by_NID((WOLFSSL_X509*)x509,
                (int)foundNID);
            if (isSet && ((word32)nid == foundNID)) {
                found = 1;
                break;
            }
        }

        idx += length;
        extCount++;
    } /* while(idx < sz) */

out:

    FreeDecodedCert(cert);
    WC_FREE_VAR_EX(cert, x509->heap, DYNAMIC_TYPE_DCERT);

    return found ? extCount : WOLFSSL_FATAL_ERROR;
}

#endif /* OPENSSL_ALL || OPENSSL_EXTRA */

#if defined(OPENSSL_EXTRA) && !defined(IGNORE_NAME_CONSTRAINTS)
/*
 * Convert a Base_entry linked list to a STACK of GENERAL_SUBTREE.
 *
 * Base_entry stores name constraint data from DecodedCert. This function
 * converts it to GENERAL_SUBTREE format.
 *
 * Supported types: ASN_DNS_TYPE, ASN_RFC822_TYPE, ASN_DIR_TYPE, ASN_IP_TYPE,
 *                  ASN_URI_TYPE
 *
 * Returns 0 on success, negative on error.
 */
static int ConvertBaseEntryToSubtreeStack(Base_entry* list, WOLFSSL_STACK* sk,
                                          void* heap)
{
    Base_entry* entry = list;
    WOLFSSL_GENERAL_SUBTREE* subtree = NULL;
    WOLFSSL_GENERAL_NAME* gn = NULL;
    (void)heap;

    while (entry != NULL) {

        if (entry->type != ASN_DNS_TYPE && entry->type != ASN_RFC822_TYPE &&
            entry->type != ASN_DIR_TYPE && entry->type != ASN_IP_TYPE &&
            entry->type != ASN_URI_TYPE) {
            entry = entry->next;
            continue;
        }

        /* Allocate subtree and general name */
        subtree = (WOLFSSL_GENERAL_SUBTREE*)XMALLOC(
            sizeof(WOLFSSL_GENERAL_SUBTREE), heap, DYNAMIC_TYPE_OPENSSL);
        if (subtree == NULL) {
            WOLFSSL_MSG("Failed to allocate GENERAL_SUBTREE");
            return MEMORY_E;
        }
        XMEMSET(subtree, 0, sizeof(WOLFSSL_GENERAL_SUBTREE));

        gn = wolfSSL_GENERAL_NAME_new();
        if (gn == NULL) {
            WOLFSSL_MSG("Failed to allocate GENERAL_NAME");
            XFREE(subtree, heap, DYNAMIC_TYPE_OPENSSL);
            return MEMORY_E;
        }

        /* Free default ia5 string allocated by GENERAL_NAME_new */
        wolfSSL_ASN1_STRING_free(gn->d.ia5);
        gn->d.ia5 = NULL;

        switch (entry->type) {
            case ASN_DNS_TYPE:
            case ASN_RFC822_TYPE:
            case ASN_URI_TYPE:
            {
                if (entry->type == ASN_DNS_TYPE) {
                    gn->type = WOLFSSL_GEN_DNS;
                }
                else if (entry->type == ASN_RFC822_TYPE) {
                    gn->type = WOLFSSL_GEN_EMAIL;
                }
                else {
                    gn->type = WOLFSSL_GEN_URI;
                }
                gn->d.ia5 = wolfSSL_ASN1_STRING_new();
                if (gn->d.ia5 == NULL) {
                    WOLFSSL_MSG("Failed to allocate ASN1_STRING");
                    wolfSSL_GENERAL_NAME_free(gn);
                    XFREE(subtree, heap, DYNAMIC_TYPE_OPENSSL);
                    return MEMORY_E;
                }
                if (wolfSSL_ASN1_STRING_set(gn->d.ia5, entry->name,
                        entry->nameSz) != WOLFSSL_SUCCESS) {
                    WOLFSSL_MSG("Failed to set ASN1_STRING");
                    wolfSSL_GENERAL_NAME_free(gn);
                    XFREE(subtree, heap, DYNAMIC_TYPE_OPENSSL);
                    return MEMORY_E;
                }
                gn->d.ia5->type = WOLFSSL_V_ASN1_IA5STRING;
                break;
            }

            case ASN_DIR_TYPE:
            {
                byte* seqBuf = NULL;
                unsigned char* p = NULL;
                int seqLen = 0;

                /* Wrap in SEQUENCE and parse as X509_NAME */
                gn->type = WOLFSSL_GEN_DIRNAME;
                seqBuf = (byte*)XMALLOC((word32)entry->nameSz + MAX_SEQ_SZ,
                                        heap, DYNAMIC_TYPE_TMP_BUFFER);
                if (seqBuf == NULL) {
                    WOLFSSL_MSG("Failed to allocate sequence buffer");
                    wolfSSL_GENERAL_NAME_free(gn);
                    XFREE(subtree, heap, DYNAMIC_TYPE_OPENSSL);
                    return MEMORY_E;
                }

                seqLen = SetSequence(entry->nameSz, seqBuf);
                XMEMCPY(seqBuf + seqLen, entry->name, entry->nameSz);

                p = seqBuf;
                gn->d.directoryName = wolfSSL_d2i_X509_NAME(NULL, &p,
                    (long)entry->nameSz + seqLen);
                XFREE(seqBuf, heap, DYNAMIC_TYPE_TMP_BUFFER);

                if (gn->d.directoryName == NULL) {
                    WOLFSSL_MSG("Failed to parse directoryName");
                    wolfSSL_GENERAL_NAME_free(gn);
                    XFREE(subtree, heap, DYNAMIC_TYPE_OPENSSL);
                    return ASN_PARSE_E;
                }
                break;
            }

            case ASN_IP_TYPE:
            {
                /* For IP address, store raw bytes as OCTET_STRING. */
                gn->type = WOLFSSL_GEN_IPADD;
                gn->d.iPAddress = wolfSSL_ASN1_STRING_new();
                if (gn->d.iPAddress == NULL) {
                    WOLFSSL_MSG("Failed to allocate ASN1_STRING for IP");
                    wolfSSL_GENERAL_NAME_free(gn);
                    XFREE(subtree, heap, DYNAMIC_TYPE_OPENSSL);
                    return MEMORY_E;
                }
                if (wolfSSL_ASN1_STRING_set(gn->d.iPAddress, entry->name,
                        entry->nameSz) != WOLFSSL_SUCCESS) {
                    WOLFSSL_MSG("Failed to set IP ASN1_STRING");
                    wolfSSL_GENERAL_NAME_free(gn);
                    XFREE(subtree, heap, DYNAMIC_TYPE_OPENSSL);
                    return MEMORY_E;
                }
                gn->d.iPAddress->type = WOLFSSL_V_ASN1_OCTET_STRING;
                break;
            }
        }

        subtree->base = gn;

        if (wolfSSL_sk_push(sk, subtree) <= 0) {
            WOLFSSL_MSG("Failed to push subtree onto stack");
            wolfSSL_GENERAL_NAME_free(gn);
            XFREE(subtree, heap, DYNAMIC_TYPE_OPENSSL);
            return MEMORY_E;
        }
        entry = entry->next;
    }

    return 0;
}
#endif /* OPENSSL_EXTRA && !IGNORE_NAME_CONSTRAINTS */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL)
/* Looks for the extension matching the passed in nid
 *
 * c   : if not null then is set to status value -2 if multiple occurrences
 *       of the extension are found, -1 if not found, 0 if found and not
 *       critical, and 1 if found and critical.
 * nid : Extension OID to be found.
 * idx : if NULL return first extension found match, otherwise start search at
 *       idx location and set idx to the location of extension returned.
 * returns NULL or a pointer to an WOLFSSL_ASN1_BIT_STRING (for KEY_USAGE_OID)
 * or WOLFSSL_STACK (for other)
 * holding extension structure
 *
 * NOTE code for decoding extensions is in asn.c DecodeCertExtensions --
 * use already decoded extension in this function to avoid decoding twice.
 * Currently we do not make use of idx since getting pre decoded extensions.
 */
void* wolfSSL_X509_get_ext_d2i(const WOLFSSL_X509* x509, int nid, int* c,
    int* idx)
{
    void* ret = NULL;
    WOLFSSL_STACK* sk = NULL;
    WOLFSSL_ASN1_OBJECT* obj = NULL;
    WOLFSSL_GENERAL_NAME* gn = NULL;
#ifdef OPENSSL_EXTRA
    WOLFSSL_DIST_POINT* dp = NULL;
#endif
    WOLFSSL_BASIC_CONSTRAINTS* bc = NULL;

    WOLFSSL_ENTER("wolfSSL_X509_get_ext_d2i");

    if (x509 == NULL) {
        return NULL;
    }

    if (c != NULL) {
        *c = -1; /* default to not found */
    }

    switch (nid) {
        case BASIC_CA_OID:
            if (x509->basicConstSet) {
                bc = wolfSSL_BASIC_CONSTRAINTS_new();
                if (!bc) {
                    WOLFSSL_MSG("wolfSSL_BASIC_CONSTRAINTS_new error");
                    return NULL;
                }

#if defined(OPENSSL_ALL) || defined(WOLFSSL_QT) || \
        defined(WOLFSSL_APACHE_HTTPD)
                bc->ca = x509->isCa;
#endif
                /* RFC 5280 4.2.1.9: only populate pathLen when the
                 * pathLenConstraint field was present. When absent, no limit
                 * is imposed and pathlen must remain NULL so it is
                 * distinguishable from a pathLenConstraint of 0. */
                if (x509->basicConstPlSet) {
                    WOLFSSL_ASN1_INTEGER* a = wolfSSL_ASN1_INTEGER_new();
                    if (a == NULL) {
                        WOLFSSL_MSG("wolfSSL_ASN1_INTEGER_new error");
                        wolfSSL_BASIC_CONSTRAINTS_free(bc);
                        return NULL;
                    }
                    a->length = (int)x509->pathLength;
                    bc->pathlen = a;
                }

                if (c != NULL) {
                    *c = x509->basicConstCrit;
                }
            }
            else {
                WOLFSSL_MSG("No Basic Constraint set");
            }
            return bc;

        case ALT_NAMES_OID:
        {
            DNS_entry* dns = NULL;

            if (x509->subjAltNameSet && x509->altNames != NULL) {
                /* Malloc GENERAL_NAME stack */
                sk = wolfSSL_sk_new_null();
                if (sk == NULL)
                    return NULL;
                sk->type = STACK_TYPE_GEN_NAME;

                /* alt names are DNS_entry structs */
                if (c != NULL) {
                    if (x509->altNames->next != NULL) {
                        *c = -2; /* more then one found */
                    }
                    else {
                        *c = x509->subjAltNameCrit;
                    }
                }

                dns = x509->altNames;
                /* Currently only support GEN_DNS type */
                while (dns != NULL) {
                    gn = wolfSSL_GENERAL_NAME_new();
                    if (gn == NULL) {
                        WOLFSSL_MSG("Error creating GENERAL_NAME");
                        goto err;
                    }

                    switch (dns->type) {
                        case ASN_DIR_TYPE:
                            gn->type = dns->type;
                            {
                                int localIdx = 0;
                                unsigned char* n = (unsigned char*)XMALLOC(
                                        dns->len + MAX_SEQ_SZ, x509->heap,
                                        DYNAMIC_TYPE_TMP_BUFFER);
                                if (n == NULL) {
                                    goto err;
                                }

                                localIdx += SetSequence(dns->len, n);
                                XMEMCPY(n + localIdx, dns->name, dns->len);
                                gn->d.dirn =  wolfSSL_d2i_X509_NAME(NULL, &n,
                                        dns->len + localIdx);
                                XFREE(n, x509->heap, DYNAMIC_TYPE_TMP_BUFFER);
                                if (gn->d.dirn == NULL) {
                                    WOLFSSL_MSG("Convert altDirName to X509 "
                                            "NAME failed");
                                    goto err;
                                }
                            }
                            break;

                        case ASN_OTHER_TYPE:
                            /* gn->type set internally */
                            if (!wolfssl_dns_entry_othername_to_gn(dns, gn)) {
                                goto err;
                            }
                            break;

                        case ASN_IP_TYPE:
                            gn->type = dns->type;
                            if (wolfSSL_ASN1_STRING_set(gn->d.iPAddress,
                                    dns->name, dns->len) != WOLFSSL_SUCCESS) {
                                WOLFSSL_MSG("ASN1_STRING_set failed");
                                goto err;
                            }
                            gn->d.iPAddress->type = WOLFSSL_V_ASN1_OCTET_STRING;
                            break;

                        case ASN_RID_TYPE:
                            /* Always handle registeredID: the union
                             * member d.registeredID is populated from
                             * raw OID body bytes. WOLFSSL_RID_ALT_NAME
                             * only gates the human-readable ridString,
                             * which this path does not need. */
                            gn->type = dns->type;
                            /* Free ia5 before using union for registeredID */
                            wolfSSL_ASN1_STRING_free(gn->d.ia5);
                            gn->d.ia5 = NULL;

                            gn->d.registeredID = wolfSSL_ASN1_OBJECT_new();
                            if (gn->d.registeredID == NULL) {
                                goto err;
                            }
                            {
                                /* Store DER-encoded OID (tag+length+content) */
                                word32 derSz = 1 + SetLength(dns->len, NULL)
                                               + dns->len;
                                byte* der = (byte*)XMALLOC(derSz,
                                    gn->d.registeredID->heap,
                                    DYNAMIC_TYPE_ASN1);
                                if (der == NULL) {
                                    goto err;
                                }
                                {
                                    word32 derIdx = 0;
                                    der[derIdx++] = ASN_OBJECT_ID;
                                    derIdx += SetLength(dns->len, der + derIdx);
                                    XMEMCPY(der + derIdx, dns->name, dns->len);
                                }
                                gn->d.registeredID->obj = der;
                                gn->d.registeredID->objSz = derSz;
                            }
                            gn->d.registeredID->dynamic |=
                                WOLFSSL_ASN1_DYNAMIC_DATA;
                            gn->d.registeredID->grp = oidCertExtType;
                            break;

                        default:
                            gn->type = dns->type;
                            if (wolfSSL_ASN1_STRING_set(gn->d.dNSName,
                                    dns->name, dns->len) != WOLFSSL_SUCCESS) {
                                WOLFSSL_MSG("ASN1_STRING_set failed");
                                goto err;
                            }
                            gn->d.dNSName->type = WOLFSSL_V_ASN1_IA5STRING;
                    }

                    dns = dns->next;
                    /* Using wolfSSL_sk_insert to maintain backwards
                     * compatibility with earlier versions of _push API that
                     * pushed items to the start of the list instead of the
                     * end. */
                    if (wolfSSL_sk_insert(sk, gn, 0) <= 0) {
                        WOLFSSL_MSG("Error pushing ASN1 object onto stack");
                        goto err;
                    }
                    /* null so that it doesn't get pushed again after switch */
                    gn = NULL;
                }
            }
            else {
                WOLFSSL_MSG("No Alt Names set");
            }

            break;
        }

        case CRL_DIST_OID:
    #if defined(OPENSSL_EXTRA)
            if (x509->CRLdistSet && x509->CRLInfo != NULL) {
                if (c != NULL) {
                    *c = x509->CRLdistCrit;
                }

                sk = wolfSSL_sk_new_null();
                if (sk == NULL) {
                    return NULL;
                }
                sk->type = STACK_TYPE_DIST_POINT;

                gn = wolfSSL_GENERAL_NAME_new();
                if (gn == NULL) {
                    WOLFSSL_MSG("Error creating GENERAL_NAME");
                    goto err;
                }

                if (wolfSSL_GENERAL_NAME_set_type(gn, WOLFSSL_GEN_URI) !=
                        WOLFSSL_SUCCESS) {
                    WOLFSSL_MSG("Error setting GENERAL_NAME type");
                    goto err;
                }

                if (wolfSSL_ASN1_STRING_set(gn->d.uniformResourceIdentifier,
                        x509->CRLInfo, x509->CRLInfoSz) != WOLFSSL_SUCCESS) {
                    WOLFSSL_MSG("ASN1_STRING_set failed");
                    goto err;
                }

                /* wolfSSL only decodes one dist point */
                dp = wolfSSL_DIST_POINT_new();
                if (dp == NULL) {
                    WOLFSSL_MSG("Error creating DIST_POINT");
                    goto err;
                }

                /* push GENERAL_NAME onto fullname stack */
                if (wolfSSL_sk_GENERAL_NAME_push(dp->distpoint->name.fullname,
                                                 gn) <= 0) {
                    WOLFSSL_MSG("wolfSSL_sk_GENERAL_NAME_push error");
                    goto err;
                }
                /* gn now owned by stack. */
                gn = NULL;

                /* push DIST_POINT onto stack */
                if (wolfSSL_sk_DIST_POINT_push(sk, dp) <= 0) {
                    WOLFSSL_MSG("Error pushing DIST_POINT onto stack");
                    goto err;
                }
                /* dp now owned by stack. */
                dp = NULL;

            }
            else {
                WOLFSSL_MSG("No CRL dist set");
            }
    #endif /* OPENSSL_EXTRA */
            break;

        case AUTH_INFO_OID:
            if (x509->authInfoSet && x509->authInfo != NULL) {
                if (c != NULL) {
                    *c = x509->authInfoCrit;
                }
                obj = wolfSSL_ASN1_OBJECT_new();
                if (obj == NULL) {
                    WOLFSSL_MSG("Issue creating WOLFSSL_ASN1_OBJECT struct");
                    return NULL;
                }
                obj->type  = AUTH_INFO_OID;
                obj->grp   = oidCertExtType;
                obj->obj   = x509->authInfo;
                obj->objSz = (unsigned int)x509->authInfoSz;
            }
            else {
                WOLFSSL_MSG("No Auth Info set");
            }
            break;

        case AUTH_KEY_OID:
            if (x509->authKeyIdSet) {
                WOLFSSL_AUTHORITY_KEYID* akey = wolfSSL_AUTHORITY_KEYID_new();
                if (!akey) {
                    WOLFSSL_MSG(
                        "Issue creating WOLFSSL_AUTHORITY_KEYID struct");
                    return NULL;
                }

                if (c != NULL) {
                    *c = x509->authKeyIdCrit;
                }
                obj = wolfSSL_ASN1_OBJECT_new();
                if (obj == NULL) {
                    WOLFSSL_MSG("Issue creating WOLFSSL_ASN1_OBJECT struct");
                    wolfSSL_AUTHORITY_KEYID_free(akey);
                    return NULL;
                }
                obj->type  = AUTH_KEY_OID;
                obj->grp   = oidCertExtType;
                obj->obj   = x509->authKeyId;
                obj->objSz = x509->authKeyIdSz;
                akey->issuer = obj;
                return akey;
            }
            else {
                WOLFSSL_MSG("No Auth Key set");
            }
            break;

        case SUBJ_KEY_OID:
            if (x509->subjKeyIdSet) {
                if (c != NULL) {
                    *c = x509->subjKeyIdCrit;
                }
                obj = wolfSSL_ASN1_OBJECT_new();
                if (obj == NULL) {
                    WOLFSSL_MSG("Issue creating WOLFSSL_ASN1_OBJECT struct");
                    return NULL;
                }
                obj->type  = SUBJ_KEY_OID;
                obj->grp   = oidCertExtType;
                obj->obj   = x509->subjKeyId;
                obj->objSz = x509->subjKeyIdSz;
            }
            else {
                WOLFSSL_MSG("No Subject Key set");
            }
            break;

        case CERT_POLICY_OID:
        {
        #ifdef WOLFSSL_CERT_EXT
            int i;

            if (x509->certPoliciesNb > 0) {
                if (c != NULL) {
                    if (x509->certPoliciesNb > 1) {
                        *c = -2;
                    }
                    else {
                        *c = 0;
                    }
                }

                sk = wolfSSL_sk_new_asn1_obj();
                if (sk == NULL) {
                    return NULL;
                }

                for (i = 0; i < x509->certPoliciesNb - 1; i++) {
                    obj = wolfSSL_ASN1_OBJECT_new();
                    if (obj == NULL) {
                        WOLFSSL_MSG(
                            "Issue creating WOLFSSL_ASN1_OBJECT struct");
                        wolfSSL_sk_ASN1_OBJECT_pop_free(sk, NULL);
                        return NULL;
                    }
                    obj->type  = CERT_POLICY_OID;
                    obj->grp   = oidCertExtType;
                    obj->obj   = (byte*)(x509->certPolicies[i]);
                    obj->objSz = MAX_CERTPOL_SZ;
                    if (wolfSSL_sk_ASN1_OBJECT_push(sk, obj) <= 0) {
                        WOLFSSL_MSG("Error pushing ASN1 object onto stack");
                        wolfSSL_ASN1_OBJECT_free(obj);
                        wolfSSL_sk_ASN1_OBJECT_pop_free(sk, NULL);
                        sk = NULL;
                    }
                }

                obj = wolfSSL_ASN1_OBJECT_new();
                if (obj == NULL) {
                    WOLFSSL_MSG("Issue creating WOLFSSL_ASN1_OBJECT struct");
                    wolfSSL_sk_ASN1_OBJECT_pop_free(sk, NULL);
                    return NULL;
                }
                obj->type  = CERT_POLICY_OID;
                obj->grp   = oidCertExtType;
                obj->obj   = (byte*)(x509->certPolicies[i]);
                obj->objSz = MAX_CERTPOL_SZ;

                if (wolfSSL_sk_ASN1_OBJECT_push(sk, obj) <= 0) {
                    WOLFSSL_MSG("Error pushing ASN1 object onto stack");
                    wolfSSL_ASN1_OBJECT_free(obj);
                    wolfSSL_sk_ASN1_OBJECT_pop_free(sk, NULL);
                    sk = NULL;
                }

                obj = NULL;
            }
            else {
                WOLFSSL_MSG("No Cert Policy set");
            }
        #endif /* WOLFSSL_CERT_EXT */
        #ifdef WOLFSSL_SEP
            if (x509->certPolicySet) {
                if (c != NULL) {
                    *c = x509->certPolicyCrit;
                }
                obj = wolfSSL_ASN1_OBJECT_new();
                if (obj == NULL) {
                    WOLFSSL_MSG("Issue creating WOLFSSL_ASN1_OBJECT struct");
                    return NULL;
                }
                obj->type  = CERT_POLICY_OID;
                obj->grp   = oidCertExtType;
            }
            else {
                WOLFSSL_MSG("No Cert Policy set");
            }
        #endif
            break;
        }
        case KEY_USAGE_OID:
        {
            WOLFSSL_ASN1_STRING* asn1str = NULL;
            if (x509->keyUsageSet) {
                if (c != NULL) {
                    *c = x509->keyUsageCrit;
                }

                asn1str = wolfSSL_ASN1_STRING_new();
                if (asn1str == NULL) {
                    WOLFSSL_MSG("Failed to malloc ASN1_STRING");
                    return NULL;
                }

                if (wolfSSL_ASN1_STRING_set(asn1str, &x509->keyUsage,
                        sizeof(word16)) != WOLFSSL_SUCCESS) {
                    WOLFSSL_MSG("wolfSSL_ASN1_STRING_set error");
                    wolfSSL_ASN1_STRING_free(asn1str);
                    return NULL;
                }

                asn1str->type = KEY_USAGE_OID;
            }
            else {
                WOLFSSL_MSG("No Key Usage set");
            }
            /* don't add stack of and return bit string directly */
            return asn1str;
        }
        case INHIBIT_ANY_OID:
            WOLFSSL_MSG("INHIBIT ANY extension not supported");
            break;

        case EXT_KEY_USAGE_OID:
            if (x509->extKeyUsageSrc != NULL) {
                const byte* ekuSrc = x509->extKeyUsageSrc;
                word32 i;

                sk = wolfSSL_sk_new_asn1_obj();
                if (sk == NULL) {
                    WOLFSSL_MSG("Issue creating stack");
                    return NULL;
                }

                for (i = 0; i < x509->extKeyUsageCount; i++) {
                    long ekuSrcLen = (long)(x509->extKeyUsageSz -
                            (word32)(ekuSrc - x509->extKeyUsageSrc));
                    WOLFSSL_ASN1_OBJECT* ekuObj = wolfSSL_d2i_ASN1_OBJECT(NULL,
                            &ekuSrc, ekuSrcLen);
                    if (ekuObj == NULL) {
                        wolfSSL_sk_ASN1_OBJECT_pop_free(sk, NULL);
                        WOLFSSL_MSG("d2i obj error");
                        return NULL;
                    }
                    ekuObj->type  = EXT_KEY_USAGE_OID;
                    ekuObj->grp   = oidCertExtType;
                    /* Push to end to maintain order */
                    if (wolfSSL_sk_insert(sk, ekuObj, -1) <= 0) {
                        wolfSSL_ASN1_OBJECT_free(ekuObj);
                        wolfSSL_sk_ASN1_OBJECT_pop_free(sk, NULL);
                        WOLFSSL_MSG("d2i obj error");
                        return NULL;
                    }
                }

                if ((word32)(ekuSrc - x509->extKeyUsageSrc)
                        != x509->extKeyUsageSz ||
                        i != x509->extKeyUsageCount) {
                    wolfSSL_sk_ASN1_OBJECT_pop_free(sk, NULL);
                    WOLFSSL_MSG("incorrect eku count or buffer not exhausted");
                    return NULL;
                }

                if (c != NULL) {
                    if (x509->extKeyUsageCount > 1) {
                        *c = -2;
                    }
                    else {
                        *c = x509->extKeyUsageCrit;
                    }
                }
            }
            else {
                WOLFSSL_MSG("No Extended Key Usage set");
            }
            break;

    #if defined(OPENSSL_EXTRA) && !defined(IGNORE_NAME_CONSTRAINTS)
        case NAME_CONS_OID:
        {
            WOLFSSL_NAME_CONSTRAINTS* nc = NULL;

            /* Check if name constraints exist in stored X509 */
            if (x509->permittedNames == NULL && x509->excludedNames == NULL) {
                WOLFSSL_MSG("No Name Constraints set");
                break;
            }

            if (c != NULL) {
                *c = x509->nameConstraintCrit;
            }

            nc = (WOLFSSL_NAME_CONSTRAINTS*)XMALLOC(
                sizeof(WOLFSSL_NAME_CONSTRAINTS), x509->heap,
                DYNAMIC_TYPE_OPENSSL);
            if (nc == NULL) {
                WOLFSSL_MSG("Failed to allocate NAME_CONSTRAINTS");
                break;
            }
            XMEMSET(nc, 0, sizeof(WOLFSSL_NAME_CONSTRAINTS));

            /* Convert permitted names */
            if (x509->permittedNames != NULL) {
                nc->permittedSubtrees = wolfSSL_sk_new_null();
                if (nc->permittedSubtrees == NULL) {
                    WOLFSSL_MSG("Failed to allocate permitted stack");
                    wolfSSL_NAME_CONSTRAINTS_free(nc);
                    break;
                }
                nc->permittedSubtrees->type = STACK_TYPE_GENERAL_SUBTREE;

                if (ConvertBaseEntryToSubtreeStack(x509->permittedNames,
                        nc->permittedSubtrees, x509->heap) != 0) {
                    WOLFSSL_MSG("Failed to convert permitted names");
                    wolfSSL_NAME_CONSTRAINTS_free(nc);
                    break;
                }
            }

            /* Convert excluded names */
            if (x509->excludedNames != NULL) {
                nc->excludedSubtrees = wolfSSL_sk_new_null();
                if (nc->excludedSubtrees == NULL) {
                    WOLFSSL_MSG("Failed to allocate excluded stack");
                    wolfSSL_NAME_CONSTRAINTS_free(nc);
                    break;
                }
                nc->excludedSubtrees->type = STACK_TYPE_GENERAL_SUBTREE;

                if (ConvertBaseEntryToSubtreeStack(x509->excludedNames,
                        nc->excludedSubtrees, x509->heap) != 0) {
                    WOLFSSL_MSG("Failed to convert excluded names");
                    wolfSSL_NAME_CONSTRAINTS_free(nc);
                    break;
                }
            }

            return nc;
        }
    #endif /* OPENSSL_EXTRA && !IGNORE_NAME_CONSTRAINTS */

        case PRIV_KEY_USAGE_PERIOD_OID:
            WOLFSSL_MSG("Private Key Usage Period extension not supported");
            break;

        case SUBJ_INFO_ACC_OID:
            WOLFSSL_MSG("Subject Info Access extension not supported");
            break;

        case POLICY_MAP_OID:
            WOLFSSL_MSG("Policy Map extension not supported");
            break;

        case POLICY_CONST_OID:
            WOLFSSL_MSG("Policy Constraint extension not supported");
            break;

        case ISSUE_ALT_NAMES_OID:
            WOLFSSL_MSG("Issue Alt Names extension not supported");
            break;

        case TLS_FEATURE_OID:
            WOLFSSL_MSG("TLS Feature extension not supported");
            break;

        default:
            WOLFSSL_MSG("Unsupported/Unknown extension OID");
    }

    /* make sure stack of is allocated */
    if ((obj || gn) && sk == NULL) {
        sk = wolfSSL_sk_new_asn1_obj();
        if (sk == NULL) {
            goto err;
        }
    }
    if (obj) {
        if (wolfSSL_sk_ASN1_OBJECT_push(sk, obj) <= 0) {
            WOLFSSL_MSG("Error pushing ASN1_OBJECT object onto "
                        "stack.");
            goto err;
        }
    }

    ret = sk;

    (void)idx;

    return ret;

err:
    if (obj) {
        wolfSSL_ASN1_OBJECT_free(obj);
    }
    if (gn) {
        wolfSSL_GENERAL_NAME_free(gn);
    }
    #ifdef OPENSSL_EXTRA
    if (dp) {
        wolfSSL_DIST_POINT_free(dp);
    }
    #endif
    if (sk) {
        wolfSSL_sk_pop_free(sk, NULL);
    }
    return NULL;
}
#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL */

#ifdef OPENSSL_EXTRA
int wolfSSL_X509_add_altname_ex(WOLFSSL_X509* x509, const char* name,
        word32 nameSz, int type)
{
    DNS_entry* newAltName = NULL;
    char* nameCopy = NULL;

    if (x509 == NULL)
        return WOLFSSL_FAILURE;

    if ((name == NULL) || (nameSz == 0))
        return WOLFSSL_SUCCESS;

    newAltName = AltNameNew(x509->heap);
    if (newAltName == NULL)
        return WOLFSSL_FAILURE;

    nameCopy = (char*)XMALLOC(nameSz + 1, x509->heap, DYNAMIC_TYPE_ALTNAME);
    if (nameCopy == NULL) {
        XFREE(newAltName, x509->heap, DYNAMIC_TYPE_ALTNAME);
        return WOLFSSL_FAILURE;
    }

    XMEMCPY(nameCopy, name, nameSz);

    nameCopy[nameSz] = '\0';

    newAltName->next = x509->altNames;
    newAltName->type = type;
    newAltName->len = (int)nameSz;
    newAltName->name = nameCopy;
    newAltName->nameStored = 1;
    x509->altNames = newAltName;

    return WOLFSSL_SUCCESS;
}

int wolfSSL_X509_add_altname(WOLFSSL_X509* x509, const char* name, int type)
{
    word32 nameSz;

    if (name == NULL)
        return WOLFSSL_SUCCESS;

    nameSz = (word32)XSTRLEN(name);
    if (nameSz == 0)
        return WOLFSSL_SUCCESS;

    if (type == ASN_IP_TYPE) {
#ifdef WOLFSSL_IP_ALT_NAME
        byte ip4[4];
        byte ip6[16];
        int ptonRet;

        /* Check if this is an ip4 address */
    #ifdef FREESCALE_MQX
        ptonRet = XINET_PTON(WOLFSSL_IP4, name, ip4, sizeof(ip4));
        if (ptonRet == RTCS_OK) {
    #else
        ptonRet = XINET_PTON(WOLFSSL_IP4, name, ip4);
        if (ptonRet == 1) {
    #endif
            return wolfSSL_X509_add_altname_ex(x509, (const char*)ip4, 4,
                type);
        }

        /* Check for ip6 */
    #ifdef FREESCALE_MQX
        ptonRet = XINET_PTON(WOLFSSL_IP6, name, ip6, sizeof(ip6));
        if (ptonRet == RTCS_OK) {
    #else
        ptonRet = XINET_PTON(WOLFSSL_IP6, name, ip6);
        if (ptonRet == 1) {
    #endif
            return wolfSSL_X509_add_altname_ex(x509, (const char*)ip6, 16,
                type);
        }

        WOLFSSL_MSG("IP address parse failed");
        return WOLFSSL_FAILURE;
#else
        WOLFSSL_MSG("WOLFSSL_IP_ALT_NAME not enabled");
        return WOLFSSL_FAILURE;
#endif
    }

    return wolfSSL_X509_add_altname_ex(x509, name, nameSz, type);
}

#ifndef NO_WOLFSSL_STUB
WOLFSSL_X509_EXTENSION *wolfSSL_X509_delete_ext(WOLFSSL_X509 *x509, int loc)
{
    WOLFSSL_STUB("wolfSSL_X509_delete_ext");
    (void)x509;
    (void)loc;
    return NULL;
}

/* currently LHASH is not implemented (and not needed for Apache port) */
WOLFSSL_X509_EXTENSION* wolfSSL_X509V3_EXT_conf_nid(
        WOLF_LHASH_OF(CONF_VALUE)* conf, WOLFSSL_X509V3_CTX* ctx, int nid,
        char* value)
{
    WOLFSSL_STUB("wolfSSL_X509V3_EXT_conf_nid");

    if (conf != NULL) {
        WOLFSSL_MSG("Handling LHASH not implemented yet");
        return NULL;
    }

    (void)conf;
    (void)ctx;
    (void)nid;
    (void)value;
    return NULL;
}

void wolfSSL_X509V3_set_ctx_nodb(WOLFSSL_X509V3_CTX* ctx)
{
    WOLFSSL_STUB("wolfSSL_X509V3_set_ctx_nodb");
    (void)ctx;
}
#endif /* !NO_WOLFSSL_STUB */

#ifdef OPENSSL_EXTRA
static WOLFSSL_X509_EXTENSION* createExtFromStr(int nid, const char *value)
{
    WOLFSSL_X509_EXTENSION* ext;

    ext = wolfSSL_X509_EXTENSION_new();
    if (ext == NULL) {
        WOLFSSL_MSG("memory error");
        return NULL;
    }
    ext->value.nid = nid;

    switch (nid) {
        case WC_NID_subject_key_identifier:
        case WC_NID_authority_key_identifier:
            if (wolfSSL_ASN1_STRING_set(&ext->value, value, -1)
                    != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("wolfSSL_ASN1_STRING_set error");
                goto err_cleanup;
            }
            ext->value.type = CTC_UTF8;
            break;
        case WC_NID_subject_alt_name:
        {
            WOLFSSL_GENERAL_NAMES* gns;
            WOLFSSL_GENERAL_NAME* gn;

            if (wolfSSL_ASN1_STRING_set(&ext->value, value, -1)
                    != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("wolfSSL_ASN1_STRING_set error");
                goto err_cleanup;
            }
            ext->value.type = ASN_DNS_TYPE;

            /* add stack of general names */
            gns = wolfSSL_sk_new_null();
            if (gns == NULL) {
                WOLFSSL_MSG("wolfSSL_sk_new_null error");
                goto err_cleanup;
            }
            ext->ext_sk = gns; /* wolfSSL_X509_EXTENSION_free will handle
                                * free'ing gns */
            gns->type = STACK_TYPE_GEN_NAME;
            gn = wolfSSL_GENERAL_NAME_new();
            if (gn == NULL) {
                WOLFSSL_MSG("wolfSSL_GENERAL_NAME_new error");
                goto err_cleanup;
            }
            if (wolfSSL_sk_GENERAL_NAME_push(gns, gn) <= 0) {
                WOLFSSL_MSG("wolfSSL_sk_GENERAL_NAME_push error");
                wolfSSL_GENERAL_NAME_free(gn);
                goto err_cleanup;
            }
            if (wolfSSL_ASN1_STRING_set(gn->d.ia5, value, -1)
                    != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("wolfSSL_ASN1_STRING_set failed");
                goto err_cleanup;
            }
            gn->type = ASN_DNS_TYPE;
            break;
        }
        case WC_NID_key_usage:
            if (wolfSSL_ASN1_STRING_set(&ext->value, value, -1)
                    != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("wolfSSL_ASN1_STRING_set error");
                goto err_cleanup;
            }
            ext->value.type = KEY_USAGE_OID;
            break;
        case WC_NID_ext_key_usage:
            if (wolfSSL_ASN1_STRING_set(&ext->value, value, -1)
                    != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("wolfSSL_ASN1_STRING_set error");
                goto err_cleanup;
            }
            ext->value.type = EXT_KEY_USAGE_OID;
            break;
        default:
            WOLFSSL_MSG("invalid or unsupported NID");
            goto err_cleanup;
    }
    return ext;
err_cleanup:
    wolfSSL_X509_EXTENSION_free(ext);
    return NULL;
}

/**
 * Create a WOLFSSL_X509_EXTENSION from the input arguments.
 * @param conf  Not used
 * @param ctx   Not used
 * @param nid   Interprets the value parameter as the x509 extension that
 *              corresponds to this NID.
 * @param value A NULL terminated string that is taken as the value of the
 *              newly created extension object.
 * @return WOLFSSL_X509_EXTENSION* on success or NULL on failure.
 */
WOLFSSL_X509_EXTENSION* wolfSSL_X509V3_EXT_nconf_nid(WOLFSSL_CONF* conf,
        WOLFSSL_X509V3_CTX *ctx, int nid, const char *value)
{
    WOLFSSL_ENTER("wolfSSL_X509V3_EXT_nconf_nid");

    if (value == NULL) {
        WOLFSSL_MSG("value NULL parameter");
        return NULL;
    }

    if (conf != NULL || ctx != NULL) {
        WOLFSSL_MSG("wolfSSL_X509V3_EXT_nconf_nid does not handle either "
                    "conf or ctx parameters");
    }

    return createExtFromStr(nid, value);
}

/**
 * Create a WOLFSSL_X509_EXTENSION from the input arguments.
 * @param conf  Not used
 * @param ctx   Not used
 * @param sName The textual representation of the NID that the value parameter
 *              should be interpreted as.
 * @param value A NULL terminated string that is taken as the value of the
 *              newly created extension object.
 * @return WOLFSSL_X509_EXTENSION* on success or NULL on failure.
 */
WOLFSSL_X509_EXTENSION* wolfSSL_X509V3_EXT_nconf(WOLFSSL_CONF *conf,
        WOLFSSL_X509V3_CTX *ctx, const char *sName, const char *value)
{
    const WOLFSSL_ObjectInfo* info = wolfssl_object_info;
    size_t i;

    WOLFSSL_ENTER("wolfSSL_X509V3_EXT_nconf");

    if (value == NULL || sName == NULL) {
        WOLFSSL_MSG("NULL parameter");
        return NULL;
    }

    if (conf != NULL || ctx != NULL) {
        WOLFSSL_MSG("wolfSSL_X509V3_EXT_nconf does not handle either "
                    "conf or ctx parameters");
    }

    for (i = 0; i < wolfssl_object_info_sz; i++, info++) {
        if (XSTRCMP(info->sName, sName) == 0)
            return createExtFromStr(info->nid, value);
    }

    WOLFSSL_MSG("value didn't match any known NID");
    return NULL;
}

static void wolfSSL_X509V3_EXT_METHOD_populate(WOLFSSL_v3_ext_method *method,
                                               int nid)
{
    if (!method)
        return;

    WOLFSSL_ENTER("wolfSSL_X509V3_EXT_METHOD_populate");
    switch (nid) {
    case WC_NID_subject_key_identifier:
        method->i2s = (WOLFSSL_X509V3_EXT_I2S)wolfSSL_i2s_ASN1_STRING;
        FALL_THROUGH;
    case WC_NID_authority_key_identifier:
    case WC_NID_key_usage:
    case WC_NID_certificate_policies:
    case WC_NID_policy_mappings:
    case WC_NID_subject_alt_name:
    case WC_NID_issuer_alt_name:
    case WC_NID_basic_constraints:
    case WC_NID_name_constraints:
    case WC_NID_policy_constraints:
    case WC_NID_ext_key_usage:
    case WC_NID_crl_distribution_points:
    case WC_NID_inhibit_any_policy:
    case WC_NID_info_access:
        WOLFSSL_MSG("Nothing to populate for current NID");
        break;
    default:
        WOLFSSL_MSG("Unknown or unsupported NID");
        break;
    }

    return;
}

/**
 * @param nid One of the WC_NID_* constants defined in asn.h
 * @param crit
 * @param data This data is copied to the returned extension.
 * @return
 */
WOLFSSL_X509_EXTENSION *wolfSSL_X509V3_EXT_i2d(int nid, int crit,
                                               void *data)
{
    WOLFSSL_X509_EXTENSION *ext = NULL;
    WOLFSSL_ASN1_STRING* asn1str = NULL;

    WOLFSSL_ENTER("wolfSSL_X509V3_EXT_i2d");

    if (!data) {
        return NULL;
    }

    if (!(ext = wolfSSL_X509_EXTENSION_new())) {
        return NULL;
    }

    wolfSSL_X509V3_EXT_METHOD_populate(&ext->ext_method, nid);

    switch (nid) {
    case WC_NID_subject_key_identifier:
        /* WOLFSSL_ASN1_STRING */
    case WC_NID_key_usage:
        /* WOLFSSL_ASN1_STRING */
    {
        asn1str = (WOLFSSL_ASN1_STRING*)data;
        ext->value = *asn1str;
        if (asn1str->isDynamic) {
            ext->value.data = (char*)XMALLOC(asn1str->length, NULL,
                                             DYNAMIC_TYPE_OPENSSL);
            if (!ext->value.data) {
                WOLFSSL_MSG("malloc failed");
                /* Zero so that no existing memory is freed */
                XMEMSET(&ext->value, 0, sizeof(WOLFSSL_ASN1_STRING));
                goto err_cleanup;
            }
            XMEMCPY(ext->value.data, asn1str->data, asn1str->length);
        }
        else {
            ext->value.data = ext->value.strData;
        }

        if (!(ext->obj = wolfSSL_OBJ_nid2obj(nid))) {
            WOLFSSL_MSG("wolfSSL_ASN1_OBJECT_new failed");
            goto err_cleanup;
        }

        break;
    }
    case WC_NID_subject_alt_name:
        /* typedef STACK_OF(GENERAL_NAME) GENERAL_NAMES */
    case WC_NID_issuer_alt_name:
        /* typedef STACK_OF(GENERAL_NAME) GENERAL_NAMES */
    case WC_NID_ext_key_usage:
        /* typedef STACK_OF(ASN1_OBJECT) EXTENDED_KEY_USAGE */
    case WC_NID_info_access:
        /* typedef STACK_OF(ACCESS_DESCRIPTION) AUTHORITY_INFO_ACCESS */
    {
        WOLFSSL_STACK* sk = (WOLFSSL_STACK*)data;

        if (ext->ext_sk) {
            wolfSSL_sk_pop_free(ext->ext_sk, NULL);
        }

        if (!(ext->ext_sk = wolfSSL_sk_dup(sk))) {
            WOLFSSL_MSG("wolfSSL_sk_dup failed");
            goto err_cleanup;
        }

        if (!(ext->obj = wolfSSL_OBJ_nid2obj(nid))) {
            WOLFSSL_MSG("wolfSSL_ASN1_OBJECT_new failed");
            goto err_cleanup;
        }

        break;
    }
    case WC_NID_basic_constraints:
    {
        /* WOLFSSL_BASIC_CONSTRAINTS */
        WOLFSSL_BASIC_CONSTRAINTS* bc = (WOLFSSL_BASIC_CONSTRAINTS*)data;

        if (!(ext->obj = wolfSSL_ASN1_OBJECT_new())) {
            WOLFSSL_MSG("wolfSSL_ASN1_OBJECT_new failed");
            goto err_cleanup;
        }

        ext->obj->ca = bc->ca;
        if (bc->pathlen) {
            ext->obj->pathlen = wolfSSL_ASN1_INTEGER_dup(bc->pathlen);
            if (!ext->obj->pathlen) {
                WOLFSSL_MSG("wolfSSL_ASN1_INTEGER_dup failed");
                goto err_cleanup;
            }
        }
        break;
    }
    case WC_NID_authority_key_identifier:
    {
        /* AUTHORITY_KEYID */
        WOLFSSL_AUTHORITY_KEYID* akey = (WOLFSSL_AUTHORITY_KEYID*)data;

        if (akey->keyid) {
            if (wolfSSL_ASN1_STRING_set(&ext->value, akey->keyid->data,
                                    akey->keyid->length) != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("wolfSSL_ASN1_STRING_set failed");
                goto err_cleanup;
            }
            ext->value.type = akey->keyid->type;

            if (!(ext->obj = wolfSSL_OBJ_nid2obj(nid))) {
                WOLFSSL_MSG("wolfSSL_ASN1_OBJECT_new failed");
                goto err_cleanup;
            }

        }
        else if (akey->issuer) {
            ext->obj = wolfSSL_ASN1_OBJECT_dup(akey->issuer);
            if (!ext->obj) {
                WOLFSSL_MSG("wolfSSL_ASN1_OBJECT_dup failed");
                goto err_cleanup;
            }
        }
        else {
            WOLFSSL_MSG("WC_NID_authority_key_identifier empty data");
            goto err_cleanup;
        }
        break;
    }
    case WC_NID_inhibit_any_policy:
        /* ASN1_INTEGER */
    case WC_NID_certificate_policies:
        /* STACK_OF(POLICYINFO) */
    case WC_NID_policy_mappings:
        /* STACK_OF(POLICY_MAPPING) */
    case WC_NID_name_constraints:
        /* NAME_CONSTRAINTS */
    case WC_NID_policy_constraints:
        /* POLICY_CONSTRAINTS */
    case WC_NID_crl_distribution_points:
        /* typedef STACK_OF(DIST_POINT) CRL_DIST_POINTS */
    default:
        WOLFSSL_MSG("Unknown or unsupported NID");
        break;
    }

    ext->crit = crit;

    return ext;
err_cleanup:
    if (ext) {
        wolfSSL_X509_EXTENSION_free(ext);
    }
    return NULL;
}

/* Returns pointer to ASN1_OBJECT from an X509_EXTENSION object */
WOLFSSL_ASN1_OBJECT* wolfSSL_X509_EXTENSION_get_object(
    WOLFSSL_X509_EXTENSION* ext)
{
    WOLFSSL_ENTER("wolfSSL_X509_EXTENSION_get_object");
    if (ext == NULL)
        return NULL;
    return ext->obj;
}


/**
 * duplicates the 'obj' input and sets it into the 'ext' structure
 * returns WOLFSSL_SUCCESS on success
 */
int wolfSSL_X509_EXTENSION_set_object(WOLFSSL_X509_EXTENSION* ext,
        const WOLFSSL_ASN1_OBJECT* obj)
{
    WOLFSSL_ASN1_OBJECT *current;

    WOLFSSL_ENTER("wolfSSL_X509_EXTENSION_set_object");
    if (ext == NULL)
        return WOLFSSL_FAILURE;

    current = wolfSSL_X509_EXTENSION_get_object(ext);
    if (current != NULL) {
        wolfSSL_ASN1_OBJECT_free(current);
    }
    ext->obj = wolfSSL_ASN1_OBJECT_dup((WOLFSSL_ASN1_OBJECT*)obj);
    return WOLFSSL_SUCCESS;
}
#endif /* OPENSSL_ALL */

#ifdef WOLFSSL_OLD_EXTDATA_FMT
/*
 * Replace the current string in 'asn1str', which is the full X.509
 * extension octet string with some data specific for the extension
 * type. The extension is the one given in 'oid'.
 * Return 0 in case of success, or a negative error code.
 */
static int wolfSSL_ASN1_STRING_into_old_ext_fmt(WOLFSSL_ASN1_STRING *asn1str,
                                                word32 oid)
{
    switch (oid)
    {
        case AUTH_INFO_OID:
            wolfSSL_ASN1_STRING_clear(asn1str);
            asn1str->data = NULL;
            asn1str->length = 0;
            return 0;

        case AUTH_KEY_OID:
        {
            int ret = 0;
            const byte *extAuthKeyId = NULL;
            word32 extAuthKeyIdSz = 0;
            char *data = NULL;

            ret = DecodeAuthKeyId((const byte *)asn1str->data, asn1str->length,
                    &extAuthKeyId, &extAuthKeyIdSz, NULL, NULL, NULL, NULL);

            if (ret != 0)
                return ret;

            data = (char*)XMALLOC((size_t)(extAuthKeyIdSz), NULL,
                                  DYNAMIC_TYPE_OPENSSL);
            if (data == NULL)
                return MEMORY_ERROR;

            XMEMCPY(data, extAuthKeyId, (size_t)extAuthKeyIdSz);
            wolfSSL_ASN1_STRING_set(asn1str, data, extAuthKeyIdSz);
            XFREE(data, NULL, DYNAMIC_TYPE_OPENSSL);
            return 0;
        }

        case SUBJ_KEY_OID:
        {
            int ret = 0;
            const byte *extSubjKeyId = NULL;
            word32 extSubjKeyIdSz = 0;
            char *data = NULL;

            ret = DecodeSubjKeyId((const byte *)asn1str->data, asn1str->length,
                    &extSubjKeyId, &extSubjKeyIdSz);
            if (ret != 0)
                return ret;

            data = (char*)XMALLOC((size_t)(extSubjKeyIdSz), NULL,
                                  DYNAMIC_TYPE_OPENSSL);
            if (data == NULL)
                return MEMORY_ERROR;

            XMEMCPY(data, extSubjKeyId, (size_t)extSubjKeyIdSz);
            wolfSSL_ASN1_STRING_set(asn1str, data, extSubjKeyIdSz);
            XFREE(data, NULL, DYNAMIC_TYPE_OPENSSL);
            return 0;
        }

        case CERT_POLICY_OID:
            wolfSSL_ASN1_STRING_clear(asn1str);
            asn1str->data = NULL;
            asn1str->length = 0;
            return 0;

        case KEY_USAGE_OID:
        {
            int ret = 0;
            word16 extKeyUsage = 0;

            ret = DecodeKeyUsage((const byte *)asn1str->data, asn1str->length,
                    &extKeyUsage);
            if (ret != 0)
                return ret;

            wolfSSL_ASN1_STRING_set(asn1str, (byte*)&extKeyUsage,
                                    sizeof(extKeyUsage));
            return 0;
        }

        case EXT_KEY_USAGE_OID:
        {
            int ret = 0;
            const byte *extExtKeyUsageSrc = NULL;
            word32 extExtKeyUsageSz = 0;
            word32 extExtKeyUsageCount = 0;
            byte extExtKeyUsage = 0;
            byte extExtKeyUsageSsh = 0;
            char *data = NULL;

            ret = DecodeExtKeyUsage((const byte*)asn1str->data, asn1str->length,
                    &extExtKeyUsageSrc, &extExtKeyUsageSz, &extExtKeyUsageCount,
                    &extExtKeyUsage, &extExtKeyUsageSsh, NULL);
            if (ret != 0)
                return ret;

            data = (char*)XMALLOC((size_t)(extExtKeyUsageSz), NULL,
                                  DYNAMIC_TYPE_OPENSSL);
            if (data == NULL)
                return MEMORY_ERROR;

            XMEMCPY(data, extExtKeyUsageSrc, (size_t)extExtKeyUsageSz);
            wolfSSL_ASN1_STRING_set(asn1str, data, extExtKeyUsageSz);
            XFREE(data, NULL, DYNAMIC_TYPE_OPENSSL);
            return 0;
        }

        case CRL_DIST_OID:
            wolfSSL_ASN1_STRING_clear(asn1str);
            asn1str->data = NULL;
            asn1str->length = 0;
            return 0;

        default:
            /* Do nothing, it is already set */
            return 0;
    }
}
#endif /* WOLFSSL_OLD_EXTDATA_FMT */

/* Returns pointer to ASN1_STRING in X509_EXTENSION object */
WOLFSSL_ASN1_STRING* wolfSSL_X509_EXTENSION_get_data(
    WOLFSSL_X509_EXTENSION* ext)
{
    WOLFSSL_ASN1_STRING *ret;

    ret =  wolfSSL_X509_EXTENSION_get_data_internal(ext);

#ifdef WOLFSSL_OLD_EXTDATA_FMT
    if (ret)
    {
        int error;
        error = wolfSSL_ASN1_STRING_into_old_ext_fmt (ret, ext->obj->type);
        if (error != 0)
        {
            WOLFSSL_MSG("Error calling wolfSSL_ASN1_STRING_into_old_ext_fmt");
            return NULL;
        }
    }
#endif

    return ret;
}


/**
 * Creates a duplicate of input 'data' and sets it into 'ext' structure
 * returns WOLFSSL_SUCCESS on success
 */
int wolfSSL_X509_EXTENSION_set_data(WOLFSSL_X509_EXTENSION* ext,
        WOLFSSL_ASN1_STRING* data)
{
    if (ext == NULL || data == NULL)
        return WOLFSSL_FAILURE;

    /* wolfSSL_ASN1_STRING_copy() defers to wolfSSL_ASN1_STRING_set(), which
     * owns the free of any existing dynamic buffer and only releases it once
     * the new contents have been copied.  Freeing it here as well would leave
     * ext->value.data dangling for that copy, so leave the buffer alone; the
     * self-aliased case (data == &ext->value) keeps working too. */
    return wolfSSL_ASN1_STRING_copy(&ext->value, data);
}

#if !defined(NO_PWDBASED)
int wolfSSL_X509_digest(const WOLFSSL_X509* x509, const WOLFSSL_EVP_MD* digest,
        unsigned char* buf, unsigned int* len)
{
    int ret;

    WOLFSSL_ENTER("wolfSSL_X509_digest");

    if (x509 == NULL || digest == NULL) {
        WOLFSSL_MSG("Null argument found");
        return WOLFSSL_FAILURE;
    }

    if (x509->derCert == NULL) {
        WOLFSSL_MSG("No DER certificate stored in X509");
        return WOLFSSL_FAILURE;
    }

    ret = wolfSSL_EVP_Digest(x509->derCert->buffer, x509->derCert->length, buf,
                              len, digest, NULL);
    WOLFSSL_LEAVE("wolfSSL_X509_digest", ret);
    return ret;
}

int wolfSSL_X509_pubkey_digest(const WOLFSSL_X509 *x509,
        const WOLFSSL_EVP_MD *digest, unsigned char* buf, unsigned int* len)
{
    int ret;

    WOLFSSL_ENTER("wolfSSL_X509_pubkey_digest");

    if (x509 == NULL || digest == NULL) {
        WOLFSSL_MSG("Null argument found");
        return WOLFSSL_FAILURE;
    }

    if (x509->pubKey.buffer == NULL || x509->pubKey.length == 0) {
        WOLFSSL_MSG("No DER public key stored in X509");
        return WOLFSSL_FAILURE;
    }

    ret = wolfSSL_EVP_Digest(x509->pubKey.buffer, x509->pubKey.length, buf,
                              len, digest, NULL);
    WOLFSSL_LEAVE("wolfSSL_X509_pubkey_digest", ret);
    return ret;
}
#endif

#endif /* OPENSSL_EXTRA */

#ifdef OPENSSL_EXTRA

    #ifndef NO_WOLFSSL_STUB
    const char* wolfSSL_X509_get_default_cert_file_env(void)
    {
        WOLFSSL_STUB("X509_get_default_cert_file_env");
        return "";
    }

    const char* wolfSSL_X509_get_default_cert_file(void)
    {
        WOLFSSL_STUB("X509_get_default_cert_file");
        return "";
    }

    const char* wolfSSL_X509_get_default_cert_dir_env(void)
    {
        WOLFSSL_STUB("X509_get_default_cert_dir_env");
        return "";
    }

    const char* wolfSSL_X509_get_default_cert_dir(void)
    {
        WOLFSSL_STUB("X509_get_default_cert_dir");
        return "";
    }
    #endif

#endif /* OPENSSL_EXTRA */

#if defined(KEEP_PEER_CERT) || defined(SESSION_CERTS) || \
    defined(KEEP_OUR_CERT) || \
    defined(OPENSSL_EXTRA)  || defined(OPENSSL_EXTRA_X509_SMALL)

/* user externally called free X509, if dynamic go ahead with free, otherwise
 * don't */
static void ExternalFreeX509(WOLFSSL_X509* x509)
{
#if defined(OPENSSL_EXTRA_X509_SMALL) || defined(OPENSSL_EXTRA)
    int doFree = 0;
#endif

    WOLFSSL_ENTER("ExternalFreeX509");
    if (x509) {
#ifdef HAVE_EX_DATA_CLEANUP_HOOKS
        wolfSSL_CRYPTO_cleanup_ex_data(&x509->ex_data);
#endif
        if (x509->dynamicMemory) {
        #if defined(OPENSSL_EXTRA_X509_SMALL) || defined(OPENSSL_EXTRA)
            int ret;
            wolfSSL_RefDec(&x509->ref, &doFree, &ret);
            if (ret != 0) {
                WOLFSSL_MSG("Couldn't lock x509 mutex");
            }
            if (doFree)
        #endif /* OPENSSL_EXTRA_X509_SMALL || OPENSSL_EXTRA */
            {
                FreeX509(x509);
                XFREE(x509, x509->heap, DYNAMIC_TYPE_X509);
            }
        }
        else {
            WOLFSSL_MSG("free called on non dynamic object, not freeing");
        }
    }
}

/* Frees an external WOLFSSL_X509 structure */
WOLFSSL_ABI
void wolfSSL_X509_free(WOLFSSL_X509* x509)
{
    WOLFSSL_ENTER("wolfSSL_X509_free");
    ExternalFreeX509(x509);
}
#endif

#if defined(KEEP_PEER_CERT) || defined(SESSION_CERTS) || \
    defined(OPENSSL_EXTRA)  || defined(OPENSSL_EXTRA_X509_SMALL)

/* copy name into in buffer, at most sz bytes, if buffer is null will
   malloc buffer, call responsible for freeing                     */
WOLFSSL_ABI
char* wolfSSL_X509_NAME_oneline(WOLFSSL_X509_NAME* name, char* in, int sz)
{
    int copySz;

    WOLFSSL_ENTER("wolfSSL_X509_NAME_oneline");

    if (name == NULL) {
        WOLFSSL_MSG("WOLFSSL_X509_NAME pointer was NULL");
        return NULL;
    }

    if (name->sz == 0)
        return in;

    if (!in) {
    #ifdef WOLFSSL_STATIC_MEMORY
        WOLFSSL_MSG("Using static memory -- please pass in a buffer");
        return NULL;
    #else
        in = (char*)XMALLOC(name->sz, NULL, DYNAMIC_TYPE_OPENSSL);
        if (!in)
            return in;
        copySz = name->sz;
    #endif
    }
    else {
        copySz = (int)min((word32)sz, (word32)name->sz);
        if (copySz <= 0)
            return in;
    }

    XMEMCPY(in, name->name, copySz - 1);
    in[copySz - 1] = 0;

    return in;
}

#ifdef OPENSSL_EXTRA
/* Given an X509_NAME, convert it to canonical form and then hash
 * with the provided hash type. Returns the first 4 bytes of the hash
 * as unsigned long on success, and 0 otherwise. */
static unsigned long X509NameHash(WOLFSSL_X509_NAME* name,
    enum wc_HashType hashType)
{
    unsigned long  hash = 0;
    unsigned char* canonName = NULL;
    byte           digest[WC_MAX_DIGEST_SIZE];
    int            size = 0;
    int            rc;

    WOLFSSL_ENTER("X509NameHash");

    if (name == NULL) {
        WOLFSSL_ERROR_MSG("WOLFSSL_X509_NAME pointer was NULL");
        return 0;
    }

    if (name->sz == 0) {
        WOLFSSL_ERROR_MSG("Nothing to hash in WOLFSSL_X509_NAME");
        return 0;
    }

    size = wolfSSL_i2d_X509_NAME_canon(name, &canonName);

    if (size <= 0 || canonName == NULL) {
        WOLFSSL_ERROR_MSG("wolfSSL_i2d_X509_NAME_canon error");
        return 0;
    }

    rc = wc_Hash(hashType, (const byte*)canonName, (word32)size, digest,
        sizeof(digest));

    if (rc == 0) {
        hash = (((unsigned long)digest[3] << 24) |
                ((unsigned long)digest[2] << 16) |
                ((unsigned long)digest[1] <<  8) |
                ((unsigned long)digest[0]));
    }
    else if (rc == WC_NO_ERR_TRACE(HASH_TYPE_E)) {
        WOLFSSL_ERROR_MSG("Hash function not compiled in");
    }
    else {
        WOLFSSL_ERROR_MSG("Error hashing name");
    }

    XFREE(canonName, NULL, DYNAMIC_TYPE_OPENSSL);
    return hash;
}

unsigned long wolfSSL_X509_NAME_hash(WOLFSSL_X509_NAME* name)
{
    return X509NameHash(name, WC_HASH_TYPE_SHA);
}

/******************************************************************************
* wolfSSL_X509_subject_name_hash
* wolfSSL_X509_issuer_name_hash
* Compute the hash digest of the subject / issuer name.
* These functions prefer SHA-1 (if available) for compatibility. Otherwise
* they use SHA-256.
*
* RETURNS:
* The first 4 bytes of SHA-1 (or SHA-256) hash in little endian order as
* unsigned long.
* Otherwise, returns zero.
*
* Note:
* Returns the same hash value as OpenSSL's X509_X_name_hash() API
* if SHA-1 support is compiled in. SHA-256 will be used if SHA-1 is
* not available.
*/
unsigned long wolfSSL_X509_subject_name_hash(const WOLFSSL_X509* x509)
{
    if (x509 == NULL) {
        WOLFSSL_ERROR_MSG("WOLFSSL_X509 pointer was NULL");
        return 0;
    }

    #ifndef NO_SHA
    return X509NameHash((WOLFSSL_X509_NAME*) &x509->subject, WC_HASH_TYPE_SHA);
    #elif !defined(NO_SHA256)
    return X509NameHash((WOLFSSL_X509_NAME*) &x509->subject,
                        WC_HASH_TYPE_SHA256);
    #else
    WOLFSSL_ERROR_MSG("Hash function not compiled in");
    return 0;
    #endif
}

unsigned long wolfSSL_X509_issuer_name_hash(const WOLFSSL_X509* x509)
{
    if (x509 == NULL) {
        WOLFSSL_ERROR_MSG("WOLFSSL_X509 pointer was NULL");
        return 0;
    }

    #ifndef NO_SHA
    return X509NameHash((WOLFSSL_X509_NAME*) &x509->issuer, WC_HASH_TYPE_SHA);
    #elif !defined(NO_SHA256)
    return X509NameHash((WOLFSSL_X509_NAME*) &x509->issuer,
                        WC_HASH_TYPE_SHA256);
    #else
    WOLFSSL_ERROR_MSG("Hash function not compiled in");
    return 0;
    #endif
}
#endif /* OPENSSL_EXTRA */

#if defined(OPENSSL_EXTRA) && defined(XSNPRINTF)
/* Copies X509 subject name into a buffer, with comma-separated name entries
 *   (matching OpenSSL v1.0.0 format)
 * Example Output for Issuer:
 *
 * C=US, ST=Montana, L=Bozeman, O=Sawtooth, OU=Consulting,
 *  CN=www.wolfssl.com, emailAddress=facts@wolfssl.com
 */
char* wolfSSL_X509_get_name_oneline(WOLFSSL_X509_NAME* name, char* in, int sz)
{
    int count, i;
    int totalLen = 0;
    char tmpBuf[256];
    WOLFSSL_ENTER("wolfSSL_X509_get_name_oneline");

    if (name == NULL) {
        WOLFSSL_MSG("wolfSSL_X509_get_name_oneline failed");
        return NULL;
    }
    #ifdef WOLFSSL_STATIC_MEMORY
    if (!in) {
        WOLFSSL_MSG("Using static memory -- please pass in a buffer");
        return NULL;
    }
    #endif

    /* Loop through X509 name entries and copy new format to buffer */
    count = wolfSSL_X509_NAME_entry_count(name);
    for (i = 0; i < count; i++) {
        WOLFSSL_X509_NAME_ENTRY* entry;
        int nameSz;
        int strSz;
        int strLen;
        char *str;
        const int tmpBufSz = sizeof(tmpBuf);
        char buf[80];
        const char* sn;

        /* Get name entry and size */
        entry = wolfSSL_X509_NAME_get_entry(name, i);
        if (entry == NULL) {
            WOLFSSL_MSG("wolfSSL_X509_NAME_get_entry failed");
            return NULL;
        }
        nameSz = wolfSSL_X509_NAME_get_text_by_NID(name, entry->nid, buf,
                                                                   sizeof(buf));
        if (nameSz < 0) {
            WOLFSSL_MSG("wolfSSL_X509_NAME_get_text_by_NID failed");
            return NULL;
        }

        /* Get short name */
        sn = wolfSSL_OBJ_nid2sn(entry->nid);
        if (sn == NULL) {
            WOLFSSL_MSG("OBJ_nid2sn failed");
            return NULL;
        }

        /* Copy sn and name text to buffer
         * Add extra strSz for '=', ',', ' ' and '\0' characters in XSNPRINTF.
         */
        if (i != count - 1) {
            strSz = (int)XSTRLEN(sn) + nameSz + 4;
            str = (char*)XMALLOC(strSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
            if (str == NULL) {
                WOLFSSL_MSG("Memory error");
                return NULL;
            }
            strLen = XSNPRINTF(str, (size_t)strSz, "%s=%s, ", sn, buf);
            if ((strLen  < 0) || (strLen  >= strSz)) {
                WOLFSSL_MSG("buffer overrun");
                XFREE(str, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                return NULL;
            }
        }
        else {
            /* Copy last name entry
            * Add extra strSz for '=' and '\0' characters in XSNPRINTF.
            */
            strSz = (int)XSTRLEN(sn) + nameSz + 2;
            str = (char*)XMALLOC(strSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
            if (str == NULL) {
                WOLFSSL_MSG("Memory error");
                return NULL;
            }
            strLen = XSNPRINTF(str, (size_t)strSz, "%s=%s", sn, buf);
            if ((strLen  < 0) || (strLen  >= strSz)) {
                WOLFSSL_MSG("buffer overrun");
                XFREE(str, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                return NULL;
            }
        }
        /* Copy string to tmpBuf */
        if (totalLen + strLen > tmpBufSz) {
            WOLFSSL_MSG("buffer overrun");
            XFREE(str, NULL, DYNAMIC_TYPE_TMP_BUFFER);
            return NULL;
        }
        XMEMCPY(tmpBuf + totalLen, str, strLen);
        totalLen += strLen;
        XFREE(str, NULL, DYNAMIC_TYPE_TMP_BUFFER);
    }

    /* Allocate space based on total string size if no buffer was provided */
    if (!in) {
        in = (char*)XMALLOC(totalLen+1, NULL, DYNAMIC_TYPE_OPENSSL);
        if (in == NULL) {
            WOLFSSL_MSG("Memory error");
            return in;
        }
    }
    else {
        if (totalLen + 1 > sz) {
            WOLFSSL_MSG("buffer overrun");
            return NULL;
        }
    }

    XMEMCPY(in, tmpBuf, totalLen); /* cppcheck-suppress uninitvar */
    in[totalLen] = '\0';

    return in;
}
#endif


/* Wraps wolfSSL_X509_d2i
 *
 * returns a WOLFSSL_X509 structure pointer on success and NULL on fail
 */
WOLFSSL_X509* wolfSSL_d2i_X509(WOLFSSL_X509** x509, const unsigned char** in,
        int len)
{
    WOLFSSL_X509* newX509 = NULL;
    WOLFSSL_ENTER("wolfSSL_d2i_X509");

    if (in == NULL) {
        WOLFSSL_MSG("NULL input for wolfSSL_d2i_X509");
        return NULL;
    }

    newX509 = wolfSSL_X509_d2i(x509, *in, len);
    if (newX509 != NULL) {
        *in += newX509->derCert->length;
    }
    return newX509;
}

static WOLFSSL_X509* d2i_X509orX509REQ(WOLFSSL_X509** x509,
                                  const byte* in, int len, int req, void* heap)
{
    WOLFSSL_X509 *newX509 = NULL;
    int type = req ? CERTREQ_TYPE : CERT_TYPE;

    WOLFSSL_ENTER("wolfSSL_X509_d2i");

    if (in != NULL && len > 0
    #ifndef WOLFSSL_CERT_REQ
            && req == 0
    #else
            && (req == 0 || req == 1)
    #endif
            ) {
        WC_DECLARE_VAR(cert, DecodedCert, 1, 0);

        WC_ALLOC_VAR_EX(cert, DecodedCert, 1, NULL, DYNAMIC_TYPE_DCERT,
            return NULL);

        InitDecodedCert(cert, (byte*)in, (word32)len, heap);
    #ifdef WOLFSSL_CERT_REQ
        cert->isCSR = (byte)req;
    #endif
        if (ParseCertRelative(cert, type, 0, NULL, NULL) == 0) {
            newX509 = wolfSSL_X509_new_ex(heap);
            if (newX509 != NULL) {
                if (CopyDecodedToX509(newX509, cert) != 0) {
                    wolfSSL_X509_free(newX509);
                    newX509 = NULL;
                }
            }
        }
        FreeDecodedCert(cert);
        WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
    }

    if (x509 != NULL)
        *x509 = newX509;

    return newX509;
}

int wolfSSL_X509_get_isCA(WOLFSSL_X509* x509)
{
    int isCA = 0;

    WOLFSSL_ENTER("wolfSSL_X509_get_isCA");

    if (x509 != NULL)
        isCA = x509->isCa;

    WOLFSSL_LEAVE("wolfSSL_X509_get_isCA", isCA);

    return isCA;
}

WOLFSSL_X509* wolfSSL_X509_d2i_ex(WOLFSSL_X509** x509, const byte* in, int len,
    void* heap)
{
    return d2i_X509orX509REQ(x509, in, len, 0, heap);
}

WOLFSSL_X509* wolfSSL_X509_d2i(WOLFSSL_X509** x509, const byte* in, int len)
{
    return wolfSSL_X509_d2i_ex(x509, in, len, NULL);
}

#ifdef WOLFSSL_CERT_REQ
WOLFSSL_X509* wolfSSL_X509_REQ_d2i(WOLFSSL_X509** x509,
        const unsigned char* in, int len)
{
    return d2i_X509orX509REQ(x509, in, len, 1, NULL);
}

WOLFSSL_X509* wolfSSL_d2i_X509_REQ_INFO(WOLFSSL_X509** req,
        const unsigned char** in, int len)
{
    WOLFSSL_X509* ret = NULL;
    WOLFSSL_ENTER("wolfSSL_d2i_X509_REQ_INFO");

    if (in == NULL) {
        WOLFSSL_MSG("NULL input for wolfSSL_d2i_X509");
        return NULL;
    }

    ret = wolfSSL_X509_REQ_d2i(req, *in, len);
    if (ret != NULL) {
        *in += ret->derCert->length;
    }
    return ret;
}
#endif

#endif /* KEEP_PEER_CERT || SESSION_CERTS || OPENSSL_EXTRA ||
          OPENSSL_EXTRA_X509_SMALL */

#if defined(OPENSSL_EXTRA) || defined(OPENSSL_EXTRA_X509_SMALL)
/* returns the number of entries in the WOLFSSL_X509_NAME */
int wolfSSL_X509_NAME_entry_count(WOLFSSL_X509_NAME* name)
{
    int count = 0;

    WOLFSSL_ENTER("wolfSSL_X509_NAME_entry_count");

    if (name != NULL)
        count = name->entrySz;

    WOLFSSL_LEAVE("wolfSSL_X509_NAME_entry_count", count);
    return count;
}
#endif /* OPENSSL_EXTRA || OPENSSL_EXTRA_X509_SMALL */

#if defined(OPENSSL_EXTRA) || \
    defined(KEEP_OUR_CERT) || defined(KEEP_PEER_CERT)

/* return the next, if any, altname from the peer cert */
WOLFSSL_ABI
char* wolfSSL_X509_get_next_altname(WOLFSSL_X509* cert)
{
    char* ret = NULL;
    WOLFSSL_ENTER("wolfSSL_X509_get_next_altname");

    /* don't have any to work with */
    if (cert == NULL || cert->altNames == NULL)
        return NULL;

    /* already went through them */
    if (cert->altNamesNext == NULL) {
#ifdef WOLFSSL_MULTICIRCULATE_ALTNAMELIST
        /* Reset altNames List to head
         * so that caller can circulate the list again
         */
        cert->altNamesNext = cert->altNames;
#endif
        return NULL;
    }

    /* In default builds iPAddress entries hold raw 4/16 octet payloads
     * and registeredID entries hold raw OID body bytes (no human-readable
     * ipString/ridString), so returning them as a C string would truncate
     * at any embedded NUL byte. Such entries are still parsed into
     * altNames for name-constraint enforcement; skip them here so
     * string-iteration callers see the same set of entries as before.
     *
     * With WOLFSSL_MULTICIRCULATE_ALTNAMELIST, a list consisting only of
     * skipped entries collapses to "no entries" on the first pass and
     * resets to head on the next call; the cycle shape matches the
     * pre-fix behavior where such entries were never parsed. */
#if !defined(WOLFSSL_IP_ALT_NAME) || !defined(WOLFSSL_RID_ALT_NAME)
    while (cert->altNamesNext != NULL) {
        int skip = 0;
#ifndef WOLFSSL_IP_ALT_NAME
        if (cert->altNamesNext->type == ASN_IP_TYPE)
            skip = 1;
#endif
#ifndef WOLFSSL_RID_ALT_NAME
        if (cert->altNamesNext->type == ASN_RID_TYPE)
            skip = 1;
#endif
        if (!skip)
            break;
        cert->altNamesNext = cert->altNamesNext->next;
    }
    if (cert->altNamesNext == NULL)
        return NULL;
#endif /* !WOLFSSL_IP_ALT_NAME || !WOLFSSL_RID_ALT_NAME */

    /* unsafe cast required for ABI compatibility. */
    ret = (char *)(wc_ptr_t)cert->altNamesNext->name;
#ifdef WOLFSSL_IP_ALT_NAME
    /* return the IP address as a string */
    if (cert->altNamesNext->type == ASN_IP_TYPE) {
        ret = cert->altNamesNext->ipString;
    }
#endif
#ifdef WOLFSSL_RID_ALT_NAME
    /* return the registeredID as a string */
    if (cert->altNamesNext->type == ASN_RID_TYPE) {
        ret = cert->altNamesNext->ridString;
    }
#endif
    cert->altNamesNext = cert->altNamesNext->next;

    return ret;
}

int wolfSSL_X509_get_signature(WOLFSSL_X509* x509,
                                                unsigned char* buf, int* bufSz)
{
    WOLFSSL_ENTER("wolfSSL_X509_get_signature");
    if (x509 == NULL || bufSz == NULL || (*bufSz < (int)x509->sig.length &&
                buf != NULL))
        return WOLFSSL_FATAL_ERROR;

    if (buf != NULL)
        XMEMCPY(buf, x509->sig.buffer, x509->sig.length);
    *bufSz = (int)x509->sig.length;

    return WOLFSSL_SUCCESS;
}


/* Getter function that copies over the DER public key buffer to "buf" and
    * sets the size in bufSz. If "buf" is NULL then just bufSz is set to needed
    * buffer size. "bufSz" passed in should initially be set by the user to be
    * the size of "buf". This gets checked to make sure the buffer is large
    * enough to hold the public key.
    *
    * Note: this is the X.509 form of key with "header" info.
    * return WOLFSSL_SUCCESS on success
    */
int wolfSSL_X509_get_pubkey_buffer(WOLFSSL_X509* x509,
                                            unsigned char* buf, int* bufSz)
{
    WC_DECLARE_VAR(cert, DecodedCert, 1, 0);
    const byte*  der;
    int length = 0;
    int    ret = 0, derSz = 0;
    int badDate = 0;
    const byte* pubKeyX509 = NULL;
    int   pubKeyX509Sz = 0;

    WOLFSSL_ENTER("wolfSSL_X509_get_pubkey_buffer");
    if (x509 == NULL || bufSz == NULL) {
        WOLFSSL_LEAVE("wolfSSL_X509_get_pubkey_buffer", BAD_FUNC_ARG);
        return WOLFSSL_FATAL_ERROR;
    }


#ifdef WOLFSSL_SMALL_STACK
    cert = (DecodedCert*)XMALLOC(sizeof(DecodedCert),
                                    x509->heap, DYNAMIC_TYPE_TMP_BUFFER);
    if (cert == NULL) {
        WOLFSSL_LEAVE("wolfSSL_X509_get_pubkey_buffer", MEMORY_E);
        return WOLFSSL_FATAL_ERROR;
    }
#endif

    der = wolfSSL_X509_get_der(x509, &derSz);
    if (der != NULL) {
        InitDecodedCert(cert, der, (word32)derSz, NULL);
        ret = wc_GetPubX509(cert, 0, &badDate);
        if (ret >= 0) {
            word32 idx = cert->srcIdx;
            pubKeyX509 = cert->source + cert->srcIdx;
            ret = GetSequence(cert->source, &cert->srcIdx, &length,
                    cert->maxIdx);
            pubKeyX509Sz = length + (cert->srcIdx - idx);
        }
        FreeDecodedCert(cert);
    }
    WC_FREE_VAR_EX(cert, x509->heap, DYNAMIC_TYPE_TMP_BUFFER);

    if (ret < 0) {
        WOLFSSL_LEAVE("wolfSSL_X509_get_pubkey_buffer", ret);
        return WOLFSSL_FATAL_ERROR;
    }

    if (buf != NULL && pubKeyX509 != NULL) {
        if (pubKeyX509Sz > *bufSz) {
            WOLFSSL_LEAVE("wolfSSL_X509_get_pubkey_buffer", BUFFER_E);
            return WOLFSSL_FATAL_ERROR;
        }
        XMEMCPY(buf, pubKeyX509, pubKeyX509Sz);
    }
    *bufSz = pubKeyX509Sz;

    return WOLFSSL_SUCCESS;
}


/* Getter function for the public key OID value
    * return public key OID stored in WOLFSSL_X509 structure */
int wolfSSL_X509_get_pubkey_type(WOLFSSL_X509* x509)
{
    if (x509 == NULL)
        return WOLFSSL_FAILURE;
    return x509->pubKeyOID;
}

#endif /* OPENSSL_EXTRA || KEEP_OUR_CERT || KEEP_PEER_CERT || SESSION_CERTS */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL) || \
    defined(KEEP_OUR_CERT) || defined(KEEP_PEER_CERT) || defined(SESSION_CERTS)

/* write X509 serial number in unsigned binary to buffer
    buffer needs to be at least EXTERNAL_SERIAL_SIZE (32) for all cases
    return WOLFSSL_SUCCESS on success */
int wolfSSL_X509_get_serial_number(WOLFSSL_X509* x509,
                                    byte* in, int* inOutSz)
{
    WOLFSSL_ENTER("wolfSSL_X509_get_serial_number");
    if (x509 == NULL || inOutSz == NULL) {
        WOLFSSL_MSG("Null argument passed in");
        return BAD_FUNC_ARG;
    }

    if (in != NULL) {
        if (*inOutSz < x509->serialSz) {
            WOLFSSL_MSG("Serial buffer too small");
            return BUFFER_E;
        }
        XMEMCPY(in, x509->serial, x509->serialSz);
    }
    *inOutSz = x509->serialSz;

    return WOLFSSL_SUCCESS;
}

/* not an openssl compatibility function - getting for derCert */
const byte* wolfSSL_X509_get_der(WOLFSSL_X509* x509, int* outSz)
{
    WOLFSSL_ENTER("wolfSSL_X509_get_der");

    if (x509 == NULL || x509->derCert == NULL || outSz == NULL)
        return NULL;

    if (x509->derCert->length > (word32)INT_MAX) {
        return NULL;
    }

    *outSz = (int)x509->derCert->length;
    return x509->derCert->buffer;
}

#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL || KEEP_OUR_CERT ||
        * KEEP_PEER_CERT || SESSION_CERTS */

#if defined(OPENSSL_EXTRA_X509_SMALL) || defined(OPENSSL_EXTRA) || \
    defined(OPENSSL_ALL) || defined(KEEP_OUR_CERT) || \
    defined(KEEP_PEER_CERT) || defined(SESSION_CERTS)

/* used by JSSE (not a standard compatibility function) */
WOLFSSL_ABI
const byte* wolfSSL_X509_notBefore(WOLFSSL_X509* x509)
{
    WOLFSSL_ENTER("wolfSSL_X509_notBefore");

    if (x509 == NULL) {
        return NULL;
    }

    if (x509->notBefore.length < 0 ||
            x509->notBefore.length > (int)sizeof(x509->notBeforeData) - 2) {
        return NULL;
    }

    XMEMSET(x509->notBeforeData, 0, sizeof(x509->notBeforeData));
    x509->notBeforeData[0] = (byte)x509->notBefore.type;
    x509->notBeforeData[1] = (byte)x509->notBefore.length;
    XMEMCPY(&x509->notBeforeData[2], x509->notBefore.data,
        x509->notBefore.length);

    return x509->notBeforeData;
}

/* used by JSSE (not a standard compatibility function) */
WOLFSSL_ABI
const byte* wolfSSL_X509_notAfter(WOLFSSL_X509* x509)
{
    WOLFSSL_ENTER("wolfSSL_X509_notAfter");

    if (x509 == NULL) {
        return NULL;
    }

    if (x509->notAfter.length < 0 ||
            x509->notAfter.length > (int)sizeof(x509->notAfterData) - 2) {
        return NULL;
    }

    XMEMSET(x509->notAfterData, 0, sizeof(x509->notAfterData));
    x509->notAfterData[0] = (byte)x509->notAfter.type;
    x509->notAfterData[1] = (byte)x509->notAfter.length;
    XMEMCPY(&x509->notAfterData[2], x509->notAfter.data, x509->notAfter.length);

    return x509->notAfterData;
}

int wolfSSL_X509_version(WOLFSSL_X509* x509)
{
    WOLFSSL_ENTER("wolfSSL_X509_version");

    if (x509 == NULL)
        return 0;

    return x509->version;
}
#endif

#ifdef OPENSSL_EXTRA

/* get the buffer to be signed (tbs) from the WOLFSSL_X509 certificate
    *
    * outSz : gets set to the size of the buffer
    * returns a pointer to the internal buffer at the location of TBS on
    *         on success and NULL on failure.
    */
const unsigned char* wolfSSL_X509_get_tbs(WOLFSSL_X509* x509, int* outSz)
{
    int sz = 0, len;
    unsigned int idx = 0, tmpIdx;
    const unsigned char* der = NULL;
    const unsigned char* tbs = NULL;

    if (x509 == NULL || outSz == NULL) {
        return NULL;
    }

    der = wolfSSL_X509_get_der(x509, &sz);
    if (der == NULL) {
        return NULL;
    }

    if (GetSequence(der, &idx, &len, (word32)sz) < 0) {
        return NULL;
    }
    tbs = der + idx;
    tmpIdx = idx;
    if (GetSequence(der, &idx, &len, (word32)sz) < 0) {
        return NULL;
    }
    *outSz = len + (idx - tmpIdx);
    return tbs;
}

#ifdef WOLFSSL_SEP

/* copy oid into in buffer, at most *inOutSz bytes, if buffer is null will
   malloc buffer, call responsible for freeing. Actual size returned in
   *inOutSz. Requires inOutSz be non-null */
byte* wolfSSL_X509_get_device_type(WOLFSSL_X509* x509, byte* in, int *inOutSz)
{
    int copySz;

    WOLFSSL_ENTER("wolfSSL_X509_get_dev_type");
    if (x509 == NULL) return NULL;
    if (inOutSz == NULL) return NULL;
    if (!x509->deviceTypeSz) return in;

    copySz = min(*inOutSz, x509->deviceTypeSz);

    if (!in) {
    #ifdef WOLFSSL_STATIC_MEMORY
        WOLFSSL_MSG("Using static memory -- please pass in a buffer");
        return NULL;
    #else
        in = (byte*)XMALLOC(x509->deviceTypeSz, 0, DYNAMIC_TYPE_OPENSSL);
        if (!in) return in;
        copySz = x509->deviceTypeSz;
    #endif
    }

    XMEMCPY(in, x509->deviceType, copySz);
    *inOutSz = copySz;

    return in;
}


byte* wolfSSL_X509_get_hw_type(WOLFSSL_X509* x509, byte* in, int* inOutSz)
{
    int copySz;

    WOLFSSL_ENTER("wolfSSL_X509_get_hw_type");
    if (x509 == NULL) return NULL;
    if (inOutSz == NULL) return NULL;
    if (!x509->hwTypeSz) return in;

    copySz = min(*inOutSz, x509->hwTypeSz);

    if (!in) {
    #ifdef WOLFSSL_STATIC_MEMORY
        WOLFSSL_MSG("Using static memory -- please pass in a buffer");
        return NULL;
    #else
        in = (byte*)XMALLOC(x509->hwTypeSz, 0, DYNAMIC_TYPE_OPENSSL);
        if (!in) return in;
        copySz = x509->hwTypeSz;
    #endif
    }

    XMEMCPY(in, x509->hwType, copySz);
    *inOutSz = copySz;

    return in;
}


byte* wolfSSL_X509_get_hw_serial_number(WOLFSSL_X509* x509,byte* in,
                                        int* inOutSz)
{
    int copySz;

    WOLFSSL_ENTER("wolfSSL_X509_get_hw_serial_number");
    if (x509 == NULL) return NULL;
    if (inOutSz == NULL) return NULL;
    if (!x509->hwTypeSz) return in;

    copySz = min(*inOutSz, x509->hwSerialNumSz);

    if (!in) {
    #ifdef WOLFSSL_STATIC_MEMORY
        WOLFSSL_MSG("Using static memory -- please pass in a buffer");
        return NULL;
    #else
        in = (byte*)XMALLOC(x509->hwSerialNumSz, 0, DYNAMIC_TYPE_OPENSSL);
        if (!in) return in;
        copySz = x509->hwSerialNumSz;
    #endif
    }

    XMEMCPY(in, x509->hwSerialNum, copySz);
    *inOutSz = copySz;

    return in;
}

#endif /* WOLFSSL_SEP */
#endif /* OPENSSL_EXTRA */

/* require OPENSSL_EXTRA since wolfSSL_X509_free is wrapped by OPENSSL_EXTRA */
#if defined(OPENSSL_EXTRA)

WOLFSSL_ASN1_TIME* wolfSSL_X509_get_notBefore(const WOLFSSL_X509* x509)
{
    WOLFSSL_ENTER("wolfSSL_X509_get_notBefore");

    if (x509 == NULL)
        return NULL;

    return (WOLFSSL_ASN1_TIME*)&x509->notBefore;
}


WOLFSSL_ASN1_TIME* wolfSSL_X509_get_notAfter(const WOLFSSL_X509* x509)
{
    WOLFSSL_ENTER("wolfSSL_X509_get_notAfter");

    if (x509 == NULL)
        return NULL;

    return (WOLFSSL_ASN1_TIME*)&x509->notAfter;
}


/* return number of elements on success 0 on fail */
int wolfSSL_sk_X509_push(WOLF_STACK_OF(WOLFSSL_X509_NAME)* sk,
    WOLFSSL_X509* x509)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_push");

    if (sk == NULL || x509 == NULL) {
        return WOLFSSL_FAILURE;
    }

    return wolfSSL_sk_push(sk, x509);
}


/* Return and remove the last x509 pushed on stack */
WOLFSSL_X509* wolfSSL_sk_X509_pop(WOLF_STACK_OF(WOLFSSL_X509_NAME)* sk)
{
    return (WOLFSSL_X509*)wolfSSL_sk_pop(sk);
}

/* Getter function for WOLFSSL_X509 pointer
 *
 * sk is the stack to retrieve pointer from
 * i  is the index value in stack
 *
 * returns a pointer to a WOLFSSL_X509 structure on success and NULL on
 *         fail
 */
WOLFSSL_X509* wolfSSL_sk_X509_value(WOLF_STACK_OF(WOLFSSL_X509)* sk, int i)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_value");

    for (; sk != NULL && i > 0; i--)
        sk = sk->next;

    if (i != 0 || sk == NULL)
        return NULL;
    return sk->data.x509;
}


/* Return and remove the first x509 pushed on stack */
WOLFSSL_X509* wolfSSL_sk_X509_shift(WOLF_STACK_OF(WOLFSSL_X509)* sk)
{
    return (WOLFSSL_X509*)wolfSSL_sk_pop_node(sk, 0);
}

#endif /* OPENSSL_EXTRA */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL)
/* Free's all nodes in X509 stack. This is different then wolfSSL_sk_X509_free
 * in that it free's the underlying objects pushed to the stack.
 *
 * sk  stack to free nodes in
 * f   X509 free function
 */
void wolfSSL_sk_X509_pop_free(WOLF_STACK_OF(WOLFSSL_X509)* sk,
    void (*f) (WOLFSSL_X509*))
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_pop_free");
    wolfSSL_sk_pop_free(sk, (wolfSSL_sk_freefunc)f);
}


/* free just the stack structure */
void wolfSSL_sk_X509_free(WOLF_STACK_OF(WOLFSSL_X509)* sk)
{
    wolfSSL_sk_free(sk);
}

#ifdef HAVE_CRL
WOLFSSL_STACK* wolfSSL_sk_X509_CRL_new(void)
{
    WOLFSSL_STACK* s = wolfSSL_sk_new_node(NULL);
    if (s != NULL)
        s->type = STACK_TYPE_X509_CRL;
    return s;
}

WOLFSSL_STACK* wolfSSL_sk_X509_CRL_new_null(void)
{
    WOLFSSL_STACK* s = wolfSSL_sk_new_null();
    if (s != NULL)
        s->type = STACK_TYPE_X509_CRL;
    return s;
}

void wolfSSL_sk_X509_CRL_pop_free(WOLF_STACK_OF(WOLFSSL_X509_CRL)* sk,
    void (*f) (WOLFSSL_X509_CRL*))
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_CRL_pop_free");
    wolfSSL_sk_pop_free(sk, (wolfSSL_sk_freefunc)f);
}

void wolfSSL_sk_X509_CRL_free(WOLF_STACK_OF(WOLFSSL_X509_CRL)* sk)
{
    wolfSSL_sk_X509_CRL_pop_free(sk, NULL);
}

/* return number of elements on success 0 on fail */
int wolfSSL_sk_X509_CRL_push(WOLF_STACK_OF(WOLFSSL_X509_CRL)* sk,
    WOLFSSL_X509_CRL* crl)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_CRL_push");

    if (sk == NULL || crl == NULL) {
        return WOLFSSL_FAILURE;
    }

    return wolfSSL_sk_push(sk, crl);
}

WOLFSSL_X509_CRL* wolfSSL_sk_X509_CRL_value(WOLF_STACK_OF(WOLFSSL_X509)* sk,
                                            int i)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_CRL_value");
    if (sk)
        return (WOLFSSL_X509_CRL*)wolfSSL_sk_value(sk, i);
    return NULL;
}

int wolfSSL_sk_X509_CRL_num(WOLF_STACK_OF(WOLFSSL_X509)* sk)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_CRL_num");
    if (sk)
        return wolfSSL_sk_num(sk);
    return 0;
}
#endif /* HAVE_CRL */

#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_QT)
/* return number of elements on success 0 on fail */
int wolfSSL_sk_ACCESS_DESCRIPTION_push(WOLF_STACK_OF(ACCESS_DESCRIPTION)* sk,
                                              WOLFSSL_ACCESS_DESCRIPTION* a)
{
    WOLFSSL_ENTER("wolfSSL_sk_ACCESS_DESCRIPTION_push");

    return wolfSSL_sk_push(sk, a);
}

/* Frees all nodes in ACCESS_DESCRIPTION stack
*
* sk stack of nodes to free
* f  free function to use
*/
void wolfSSL_sk_ACCESS_DESCRIPTION_pop_free(WOLFSSL_STACK* sk,
    void (*f) (WOLFSSL_ACCESS_DESCRIPTION*))
{
   WOLFSSL_ENTER("wolfSSL_sk_ACCESS_DESCRIPTION_pop_free");
   wolfSSL_sk_pop_free(sk, (wolfSSL_sk_freefunc)f);
}

void wolfSSL_sk_ACCESS_DESCRIPTION_free(WOLFSSL_STACK* sk)
{
    wolfSSL_sk_free(sk);
}


/* AUTHORITY_INFO_ACCESS object is a stack of ACCESS_DESCRIPTION objects,
 * to free the stack the WOLFSSL_ACCESS_DESCRIPTION stack free function is
 * used */
void wolfSSL_AUTHORITY_INFO_ACCESS_free(
        WOLF_STACK_OF(WOLFSSL_ACCESS_DESCRIPTION)* sk)
{
    WOLFSSL_ENTER("wolfSSL_AUTHORITY_INFO_ACCESS_free");
    wolfSSL_sk_ACCESS_DESCRIPTION_free(sk);
}

void wolfSSL_AUTHORITY_INFO_ACCESS_pop_free(
        WOLF_STACK_OF(WOLFSSL_ACCESS_DESCRIPTION)* sk,
        void (*f) (WOLFSSL_ACCESS_DESCRIPTION*))
{
    WOLFSSL_ENTER("wolfSSL_AUTHORITY_INFO_ACCESS_free");
    wolfSSL_sk_ACCESS_DESCRIPTION_pop_free(sk, f);
}


void wolfSSL_ACCESS_DESCRIPTION_free(WOLFSSL_ACCESS_DESCRIPTION* a)
{
    WOLFSSL_ENTER("wolfSSL_ACCESS_DESCRIPTION_free");
    if (a == NULL)
        return;

    if (a->method)
        wolfSSL_ASN1_OBJECT_free(a->method);
    if (a->location)
        wolfSSL_GENERAL_NAME_free(a->location);
    XFREE(a, NULL, DYNAMIC_TYPE_X509_EXT);

    /* a = NULL, don't try to a or double free it */
}
#endif /* OPENSSL_EXTRA || WOLFSSL_QT */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL)

/* Creates and returns new GENERAL_NAME structure */
WOLFSSL_GENERAL_NAME* wolfSSL_GENERAL_NAME_new(void)
{
    WOLFSSL_GENERAL_NAME* gn;
    WOLFSSL_ENTER("GENERAL_NAME_new");

    gn = (WOLFSSL_GENERAL_NAME*)XMALLOC(sizeof(WOLFSSL_GENERAL_NAME), NULL,
                                                             DYNAMIC_TYPE_ASN1);
    if (gn == NULL) {
        return NULL;
    }
    XMEMSET(gn, 0, sizeof(WOLFSSL_GENERAL_NAME));

    gn->d.ia5 = wolfSSL_ASN1_STRING_new();
    if (gn->d.ia5 == NULL) {
        WOLFSSL_MSG("Issue creating ASN1_STRING struct");
        wolfSSL_GENERAL_NAME_free(gn);
        return NULL;
    }
    gn->type = WOLFSSL_GEN_IA5;
    return gn;
}

WOLFSSL_GENERAL_NAME* wolfSSL_GENERAL_NAME_dup(WOLFSSL_GENERAL_NAME* gn)
{
    WOLFSSL_GENERAL_NAME* dupl = NULL;

    WOLFSSL_ENTER("wolfSSL_GENERAL_NAME_dup");

    if (!gn) {
        WOLFSSL_MSG("Bad parameter");
        return NULL;
    }

    if (!(dupl = wolfSSL_GENERAL_NAME_new())) {
        WOLFSSL_MSG("wolfSSL_GENERAL_NAME_new error");
        return NULL;
    }

    wolfSSL_ASN1_STRING_free(dupl->d.ia5);
    dupl->d.ia5 = NULL;
    switch (gn->type) {
    /* WOLFSSL_ASN1_STRING types */
    case WOLFSSL_GEN_DNS:
        if (!(dupl->d.dNSName = wolfSSL_ASN1_STRING_dup(gn->d.dNSName))) {
            WOLFSSL_MSG("wolfSSL_ASN1_STRING_dup error");
            goto error;
        }
        break;
    case WOLFSSL_GEN_IPADD:
        if (!(dupl->d.iPAddress = wolfSSL_ASN1_STRING_dup(gn->d.iPAddress))) {
            WOLFSSL_MSG("wolfSSL_ASN1_STRING_dup error");
            goto error;
        }
        break;
    case WOLFSSL_GEN_EMAIL:
        if (!(dupl->d.rfc822Name = wolfSSL_ASN1_STRING_dup(gn->d.rfc822Name))) {
            WOLFSSL_MSG("wolfSSL_ASN1_STRING_dup error");
            goto error;
        }
        break;
    case WOLFSSL_GEN_URI:
        if (!(dupl->d.uniformResourceIdentifier =
                wolfSSL_ASN1_STRING_dup(gn->d.uniformResourceIdentifier))) {
            WOLFSSL_MSG("wolfSSL_ASN1_STRING_dup error");
            goto error;
        }
        break;
    case WOLFSSL_GEN_OTHERNAME:
        if (gn->d.otherName->value->type != WOLFSSL_V_ASN1_UTF8STRING) {
            WOLFSSL_MSG("Unsupported othername value type");
            goto error;
        }
        dupl->d.otherName = (WOLFSSL_ASN1_OTHERNAME*)XMALLOC(
            sizeof(WOLFSSL_ASN1_OTHERNAME), NULL, DYNAMIC_TYPE_ASN1);
        if (dupl->d.otherName == NULL) {
            WOLFSSL_MSG("XMALLOC error");
            goto error;
        }
        dupl->d.otherName->type_id = wolfSSL_ASN1_OBJECT_dup(
            gn->d.otherName->type_id);
        dupl->d.otherName->value = (WOLFSSL_ASN1_TYPE*)XMALLOC(
            sizeof(WOLFSSL_ASN1_TYPE), NULL, DYNAMIC_TYPE_ASN1);
        if (dupl->d.otherName->value != NULL) {
            dupl->d.otherName->value->type = gn->d.otherName->value->type;
            dupl->d.otherName->value->value.utf8string =
                wolfSSL_ASN1_STRING_dup(
                                      gn->d.otherName->value->value.utf8string);
        }
        if ((dupl->d.otherName->type_id == NULL) ||
            (dupl->d.otherName->value == NULL) ||
            (dupl->d.otherName->value->value.utf8string == NULL)) {
            wolfSSL_ASN1_OBJECT_free(dupl->d.otherName->type_id);
            wolfSSL_ASN1_TYPE_free(dupl->d.otherName->value);
            XFREE(dupl->d.otherName, NULL, DYNAMIC_TYPE_ASN1);
            dupl->d.otherName = NULL;
            WOLFSSL_MSG("error duping othername");
            goto error;
        }
        break;
    case WOLFSSL_GEN_X400:
    case WOLFSSL_GEN_DIRNAME:
    case WOLFSSL_GEN_EDIPARTY:
    case WOLFSSL_GEN_RID:
    default:
        WOLFSSL_MSG("Unrecognized or unsupported GENERAL_NAME type");
        goto error;
    }
    dupl->type = gn->type;

    return dupl;
error:
    wolfSSL_GENERAL_NAME_free(dupl);
    return NULL;
}

/* Set an Othername in a general name.
 *
 * @param [out] gen     Pointer to the GENERAL_NAME where the othername is set.
 * @param [in]  oid     Object ID (ie UPN).
 * @param [in]  name    The actual name.
 * @return  WOLFSSL_FAILURE on invalid parameter or memory error,
 *          WOLFSSL_SUCCESS otherwise.
 */
int wolfSSL_GENERAL_NAME_set0_othername(WOLFSSL_GENERAL_NAME* gen,
                                        WOLFSSL_ASN1_OBJECT* oid,
                                        WOLFSSL_ASN1_TYPE* value)
{
    WOLFSSL_ASN1_OBJECT *x = NULL;

    if ((gen == NULL) || (oid == NULL) || (value == NULL)) {
        return WOLFSSL_FAILURE;
    }

    x = wolfSSL_ASN1_OBJECT_dup(oid);
    if (x == NULL) {
        WOLFSSL_MSG("wolfSSL_ASN1_OBJECT_dup() failed");
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_GENERAL_NAME_set_type(gen, WOLFSSL_GEN_OTHERNAME)
            != WOLFSSL_SUCCESS) {
        wolfSSL_ASN1_OBJECT_free(x);
        return WOLFSSL_FAILURE;
    }

    gen->d.otherName->type_id = x;
    gen->d.otherName->value = value;
    return WOLFSSL_SUCCESS;
}

/* return number of elements on success 0 on fail */
int wolfSSL_sk_GENERAL_NAME_push(WOLFSSL_GENERAL_NAMES* sk,
                                 WOLFSSL_GENERAL_NAME* gn)
{
    WOLFSSL_ENTER("wolfSSL_sk_GENERAL_NAME_push");

    return wolfSSL_sk_push(sk, gn);
}

#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL */

#ifdef OPENSSL_EXTRA

/* Returns the general name at index i from the stack
 *
 * sk  stack to get general name from
 * idx index to get
 *
 * return a pointer to the internal node of the stack
 */
WOLFSSL_GENERAL_NAME* wolfSSL_sk_GENERAL_NAME_value(WOLFSSL_STACK* sk, int idx)
{
    return (WOLFSSL_GENERAL_NAME*)wolfSSL_sk_value(sk, idx);
}

/* Gets the number of nodes in the stack
 *
 * sk  stack to get the number of nodes from
 *
 * returns the number of nodes, -1 if no nodes
 */
int wolfSSL_sk_GENERAL_NAME_num(WOLFSSL_STACK* sk)
{
    WOLFSSL_ENTER("wolfSSL_sk_GENERAL_NAME_num");

    return wolfSSL_sk_num(sk);
}

/* Allocates an empty GENERAL NAME stack */
WOLFSSL_STACK* wolfSSL_sk_GENERAL_NAME_new(void *cmpFunc) {
    WOLFSSL_STACK* sk = NULL;
    (void)cmpFunc;
    WOLFSSL_ENTER("wolfSSL_sk_GENERAL_NAME_new");

    sk = wolfSSL_sk_new_null();
    if (sk != NULL) {
        sk->type = STACK_TYPE_GEN_NAME;
    }

    return sk;
}
#endif /* OPENSSL_EXTRA */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL)

/* Frees all nodes in a GENERAL NAME stack
 *
 * sk stack of nodes to free
 * f  free function to use, not called with wolfSSL
 */
void wolfSSL_sk_GENERAL_NAME_pop_free(WOLFSSL_STACK* sk,
        void (*f) (WOLFSSL_GENERAL_NAME*))
{
    WOLFSSL_ENTER("wolfSSL_sk_GENERAL_NAME_pop_free");
    wolfSSL_sk_pop_free(sk, (wolfSSL_sk_freefunc)f);
}

void wolfSSL_sk_GENERAL_NAME_free(WOLFSSL_STACK* sk)
{
    WOLFSSL_ENTER("wolfSSL_sk_GENERAL_NAME_free");
    wolfSSL_sk_X509_pop_free(sk, NULL);
}
#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL */

#ifdef OPENSSL_EXTRA
static void wolfSSL_DIST_POINT_NAME_free(WOLFSSL_DIST_POINT_NAME* dpn)
{
    if (dpn != NULL) {
        if (dpn->name.fullname != NULL) {
            wolfSSL_sk_X509_pop_free(dpn->name.fullname, NULL);
        }
        XFREE(dpn, NULL, DYNAMIC_TYPE_OPENSSL);
    }
}


/* returns new pointer on success and NULL on fail */
static WOLFSSL_DIST_POINT_NAME* wolfSSL_DIST_POINT_NAME_new(void)
{
    WOLFSSL_DIST_POINT_NAME* dpn = NULL;
    WOLFSSL_GENERAL_NAMES* gns = NULL;

    dpn = (WOLFSSL_DIST_POINT_NAME*)XMALLOC(sizeof(WOLFSSL_DIST_POINT_NAME),
                                            NULL, DYNAMIC_TYPE_OPENSSL);
    if (dpn == NULL) {
        return NULL;
    }
    XMEMSET(dpn, 0, sizeof(WOLFSSL_DIST_POINT_NAME));

    gns = wolfSSL_sk_new_null();
    if (gns == NULL) {
        WOLFSSL_MSG("wolfSSL_sk_new_null error");
        XFREE(dpn, NULL, DYNAMIC_TYPE_OPENSSL);
        return NULL;
    }
    gns->type = STACK_TYPE_GEN_NAME;

    /* DIST_POINT_NAME type may be 0 or 1, indicating whether fullname or
     * relativename is used. See: RFC 5280 section 4.2.1.13 */
    dpn->name.fullname = gns;
    dpn->type = 0;

    return dpn;
}


/* Creates and returns new DIST_POINT structure */
WOLFSSL_DIST_POINT* wolfSSL_DIST_POINT_new(void)
{
    WOLFSSL_DIST_POINT* dp = NULL;
    WOLFSSL_DIST_POINT_NAME* dpn = NULL;

    WOLFSSL_ENTER("wolfSSL_DIST_POINT_new");

    dp = (WOLFSSL_DIST_POINT*)XMALLOC(sizeof(WOLFSSL_DIST_POINT), NULL,
                                      DYNAMIC_TYPE_OPENSSL);
    if (dp == NULL) {
        return NULL;
    }
    XMEMSET(dp, 0, sizeof(WOLFSSL_DIST_POINT));

    dpn = wolfSSL_DIST_POINT_NAME_new();
    if (dpn == NULL) {
        XFREE(dp, NULL, DYNAMIC_TYPE_OPENSSL);
        return NULL;
    }
    dp->distpoint = dpn;

    return dp;
}


/* Frees DIST_POINT objects.
*/
void wolfSSL_DIST_POINT_free(WOLFSSL_DIST_POINT* dp)
{
    WOLFSSL_ENTER("wolfSSL_DIST_POINT_free");
    if (dp != NULL) {
        wolfSSL_DIST_POINT_NAME_free(dp->distpoint);
        XFREE(dp, NULL, DYNAMIC_TYPE_OPENSSL);
    }
}

void wolfSSL_DIST_POINTS_free(WOLFSSL_DIST_POINTS *dps)
{
    WOLFSSL_ENTER("wolfSSL_DIST_POINTS_free");

    if (dps == NULL) {
        return;
    }

    wolfSSL_sk_free(dps);
}

/* return number of elements on success 0 on fail */
int wolfSSL_sk_DIST_POINT_push(WOLFSSL_DIST_POINTS* sk, WOLFSSL_DIST_POINT* dp)
{
    WOLFSSL_ENTER("wolfSSL_sk_DIST_POINT_push");

    if (sk == NULL || dp == NULL) {
        return WOLFSSL_FAILURE;
    }

    return wolfSSL_sk_push(sk, dp);
}

/* Returns the CRL dist point at index i from the stack
 *
 * sk  stack to get general name from
 * idx index to get
 *
 * return a pointer to the internal node of the stack
 */
WOLFSSL_DIST_POINT* wolfSSL_sk_DIST_POINT_value(WOLFSSL_STACK* sk, int idx)
{
    if (sk == NULL) {
        return NULL;
    }

    return (WOLFSSL_DIST_POINT*)wolfSSL_sk_value(sk, idx);
}

/* Gets the number of nodes in the stack
 *
 * sk  stack to get the number of nodes from
 *
 * returns the number of nodes, -1 if no nodes
 */
int wolfSSL_sk_DIST_POINT_num(WOLFSSL_STACK* sk)
{
    WOLFSSL_ENTER("wolfSSL_sk_DIST_POINT_num");

    if (sk == NULL) {
        return WOLFSSL_FATAL_ERROR;
    }

    return wolfSSL_sk_num(sk);
}

/* Frees all nodes in a DIST_POINT stack
 *
 * sk stack of nodes to free
 * f  free function to use
 */
void wolfSSL_sk_DIST_POINT_pop_free(WOLFSSL_STACK* sk,
        void (*f) (WOLFSSL_DIST_POINT*))
{
    WOLFSSL_ENTER("wolfSSL_sk_DIST_POINT_pop_free");
    wolfSSL_sk_pop_free(sk, (wolfSSL_sk_freefunc)f);
}

void wolfSSL_sk_DIST_POINT_free(WOLFSSL_STACK* sk)
{
    WOLFSSL_ENTER("wolfSSL_sk_DIST_POINT_free");
    wolfSSL_sk_free(sk);
}

/* returns the number of nodes in stack on success and WOLFSSL_FATAL_ERROR
 * on fail */
int wolfSSL_sk_ACCESS_DESCRIPTION_num(WOLFSSL_STACK* sk)
{
    if (sk == NULL) {
        return WOLFSSL_FATAL_ERROR;
    }

    return (int)sk->num;
}

/* returns NULL on fail and pointer to internal data on success */
WOLFSSL_ACCESS_DESCRIPTION* wolfSSL_sk_ACCESS_DESCRIPTION_value(
        WOLFSSL_STACK* sk, int idx)
{
    WOLFSSL_STACK* ret;

    if (sk == NULL) {
        return NULL;
    }

    ret = wolfSSL_sk_get_node(sk, idx);
    if (ret != NULL) {
        return ret->data.access;
    }
    return NULL;
}
#endif /* OPENSSL_EXTRA */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL)
/* free's the internal type for the general name */
static void wolfSSL_GENERAL_NAME_type_free(WOLFSSL_GENERAL_NAME* name)
{
    if (name != NULL) {
        switch (name->type) {
        case WOLFSSL_GEN_IA5:
            wolfSSL_ASN1_STRING_free(name->d.ia5);
            name->d.ia5 = NULL;
            break;
        case WOLFSSL_GEN_EMAIL:
            wolfSSL_ASN1_STRING_free(name->d.rfc822Name);
            name->d.rfc822Name = NULL;
            break;
        case WOLFSSL_GEN_DNS:
            wolfSSL_ASN1_STRING_free(name->d.dNSName);
            name->d.dNSName = NULL;
            break;
        case WOLFSSL_GEN_DIRNAME:
            wolfSSL_X509_NAME_free(name->d.dirn);
            name->d.dirn = NULL;
            break;
        case WOLFSSL_GEN_URI:
            wolfSSL_ASN1_STRING_free(name->d.uniformResourceIdentifier);
            name->d.uniformResourceIdentifier = NULL;
            break;
        case WOLFSSL_GEN_IPADD:
            wolfSSL_ASN1_STRING_free(name->d.iPAddress);
            name->d.iPAddress = NULL;
            break;
        case WOLFSSL_GEN_RID:
            wolfSSL_ASN1_OBJECT_free(name->d.registeredID);
            name->d.registeredID = NULL;
            break;
        case WOLFSSL_GEN_OTHERNAME:
            if (name->d.otherName != NULL) {
                wolfSSL_ASN1_OBJECT_free(name->d.otherName->type_id);
                wolfSSL_ASN1_TYPE_free(name->d.otherName->value);
                XFREE(name->d.otherName, NULL, DYNAMIC_TYPE_ASN1);
                name->d.otherName = NULL;
            }
            break;
        case WOLFSSL_GEN_X400:
            /* Unsupported: fall through */
        case WOLFSSL_GEN_EDIPARTY:
            /* Unsupported: fall through */
        default:
            WOLFSSL_MSG("wolfSSL_GENERAL_NAME_type_free: possible leak");
            break;
        }
    }
}

/* sets the general name type and free's the existing one
 * can fail with a memory error if malloc fails or bad arg error
 * otherwise return WOLFSSL_SUCCESS */
int wolfSSL_GENERAL_NAME_set_type(WOLFSSL_GENERAL_NAME* name, int typ)
{
    int ret = WOLFSSL_SUCCESS;

    if (name != NULL) {
        wolfSSL_GENERAL_NAME_type_free(name);
        name->type = typ;

        switch (typ) {
            case WOLFSSL_GEN_URI:
                name->d.uniformResourceIdentifier = wolfSSL_ASN1_STRING_new();
                if (name->d.uniformResourceIdentifier == NULL)
                    ret = MEMORY_E;
                break;
            case WOLFSSL_GEN_OTHERNAME:
                name->d.otherName = (WOLFSSL_ASN1_OTHERNAME*)XMALLOC(
                    sizeof(WOLFSSL_ASN1_OTHERNAME), NULL, DYNAMIC_TYPE_ASN1);
                if (name->d.otherName == NULL) {
                    ret = MEMORY_E;
                }
                else {
                    XMEMSET(name->d.otherName, 0, sizeof(WOLFSSL_ASN1_OTHERNAME));
                }
                break;
            default:
                name->type = WOLFSSL_GEN_IA5;
                name->d.ia5 = wolfSSL_ASN1_STRING_new();
                if (name->d.ia5 == NULL)
                    ret = MEMORY_E;
        }
    }
    else {
        ret = BAD_FUNC_ARG;
    }

    return ret;
}

/* Set the value in a general name. This is a compat layer API.
 *
 * @param [out] a       Pointer to the GENERAL_NAME where the othername is set.
 * @param [in]  type    The type of this general name.
 * @param [in]  value   The ASN.1 string that is the value.
 * @return none
 * @note the set0 indicates we take ownership so the user does NOT free value.
 */
void wolfSSL_GENERAL_NAME_set0_value(WOLFSSL_GENERAL_NAME *a, int type,
                                     void *value)
{
    WOLFSSL_ASN1_STRING *val = (WOLFSSL_ASN1_STRING *)value;
    if (a == NULL) {
        WOLFSSL_MSG("a is NULL");
        return;
    }

    if (val == NULL) {
        WOLFSSL_MSG("value is NULL");
        return;
    }

    if (type != WOLFSSL_GEN_DNS) {
        WOLFSSL_MSG("Only WOLFSSL_GEN_DNS is supported");
        return;
    }

    wolfSSL_GENERAL_NAME_type_free(a);
    a->type = type;
    /* Only when WOLFSSL_GEN_DNS. */
    a->d.dNSName = val;
}

/* Frees GENERAL_NAME objects.
*/
void wolfSSL_GENERAL_NAME_free(WOLFSSL_GENERAL_NAME* name)
{
    WOLFSSL_ENTER("wolfSSL_GENERAL_NAME_Free");
    if (name != NULL) {
        wolfSSL_GENERAL_NAME_type_free(name);
        XFREE(name, NULL, DYNAMIC_TYPE_OPENSSL);
    }
}
#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL*/

#ifdef OPENSSL_EXTRA
void wolfSSL_GENERAL_NAMES_free(WOLFSSL_GENERAL_NAMES *gens)
{
    WOLFSSL_ENTER("wolfSSL_GENERAL_NAMES_free");

    if (gens == NULL) {
        return;
    }

    wolfSSL_sk_GENERAL_NAME_free(gens);
}

void wolfSSL_EXTENDED_KEY_USAGE_free(WOLFSSL_STACK * sk)
{
    WOLFSSL_ENTER("wolfSSL_EXTENDED_KEY_USAGE_free");

    if (sk == NULL) {
        return;
    }

    wolfSSL_sk_X509_pop_free(sk, NULL);
}

#if !defined(IGNORE_NAME_CONSTRAINTS)
/*
 * Allocate and initialize an empty GENERAL_SUBTREE structure.
 * Returns NULL on allocation failure.
 */
WOLFSSL_GENERAL_SUBTREE* wolfSSL_GENERAL_SUBTREE_new(void)
{
    WOLFSSL_GENERAL_SUBTREE* subtree;

    WOLFSSL_ENTER("wolfSSL_GENERAL_SUBTREE_new");

    subtree = (WOLFSSL_GENERAL_SUBTREE*)XMALLOC(sizeof(WOLFSSL_GENERAL_SUBTREE),
                                                NULL, DYNAMIC_TYPE_OPENSSL);
    if (subtree == NULL) {
        WOLFSSL_MSG("Failed to allocate GENERAL_SUBTREE");
        return NULL;
    }
    XMEMSET(subtree, 0, sizeof(WOLFSSL_GENERAL_SUBTREE));
    return subtree;
}

/*
 * Create an empty NAME_CONSTRAINTS structure.
 * Returns NULL on allocation failure.
 */
WOLFSSL_NAME_CONSTRAINTS* wolfSSL_NAME_CONSTRAINTS_new(void)
{
    WOLFSSL_NAME_CONSTRAINTS* nc;

    WOLFSSL_ENTER("wolfSSL_NAME_CONSTRAINTS_new");

    nc = (WOLFSSL_NAME_CONSTRAINTS*)XMALLOC(sizeof(WOLFSSL_NAME_CONSTRAINTS),
                                            NULL, DYNAMIC_TYPE_OPENSSL);
    if (nc == NULL) {
        WOLFSSL_MSG("Failed to allocate NAME_CONSTRAINTS");
        return NULL;
    }
    XMEMSET(nc, 0, sizeof(WOLFSSL_NAME_CONSTRAINTS));
    return nc;
}

/* Free a GENERAL_SUBTREE and its contents. */
void wolfSSL_GENERAL_SUBTREE_free(WOLFSSL_GENERAL_SUBTREE* subtree)
{
    if (subtree == NULL) {
        return;
    }
    wolfSSL_GENERAL_NAME_free(subtree->base);
    XFREE(subtree, NULL, DYNAMIC_TYPE_OPENSSL);
}

/* Free a NAME_CONSTRAINTS structure and all its contents. */
void wolfSSL_NAME_CONSTRAINTS_free(WOLFSSL_NAME_CONSTRAINTS* nc)
{
    WOLFSSL_ENTER("wolfSSL_NAME_CONSTRAINTS_free");

    if (nc == NULL) {
        return;
    }

    if (nc->permittedSubtrees != NULL) {
        wolfSSL_sk_pop_free(nc->permittedSubtrees,
            (wolfSSL_sk_freefunc)wolfSSL_GENERAL_SUBTREE_free);
    }

    if (nc->excludedSubtrees != NULL) {
        wolfSSL_sk_pop_free(nc->excludedSubtrees,
            (wolfSSL_sk_freefunc)wolfSSL_GENERAL_SUBTREE_free);
    }

    XFREE(nc, NULL, DYNAMIC_TYPE_OPENSSL);
}

/* Get number of items in GENERAL_SUBTREE stack. */
int wolfSSL_sk_GENERAL_SUBTREE_num(const WOLFSSL_STACK* sk)
{
    WOLFSSL_ENTER("wolfSSL_sk_GENERAL_SUBTREE_num");

    return wolfSSL_sk_num(sk);
}

/* Get GENERAL_SUBTREE at index from stack. */
WOLFSSL_GENERAL_SUBTREE* wolfSSL_sk_GENERAL_SUBTREE_value(
    const WOLFSSL_STACK* sk, int idx)
{
    WOLFSSL_ENTER("wolfSSL_sk_GENERAL_SUBTREE_value");

    return (WOLFSSL_GENERAL_SUBTREE*)wolfSSL_sk_value(sk, idx);
}

/* Check IP address string matches constraint.
 *
 * name: IP address string (ex "192.168.1.50")
 * nameSz: length of name string
 * gn: GENERAL_NAME containing IP constraint (IP + mask bytes)
 *
 * Return 1 on match, otherwise 0
 */
static int MatchIpName(const char* name, int nameSz, WOLFSSL_GENERAL_NAME* gn)
{
    int ipLen = 0;
    int constraintLen;
    char ipStr[WOLFSSL_MAX_IPSTR];
    unsigned char ipBytes[16]; /* Max 16 bytes for IPv6 */
    const unsigned char* constraintData;

    if (name == NULL || nameSz <= 0 || gn == NULL || gn->d.iPAddress == NULL) {
        return 0;
    }

    constraintData = wolfSSL_ASN1_STRING_get0_data(gn->d.iPAddress);
    constraintLen = wolfSSL_ASN1_STRING_length(gn->d.iPAddress);
    if (constraintData == NULL || constraintLen <= 0) {
        return 0;
    }

    /* Null-terminate IP string */
    if (nameSz >= (int)sizeof(ipStr)) {
        return 0;
    }
    XMEMCPY(ipStr, name, nameSz);
    ipStr[nameSz] = '\0';

    /* IPv4 constraint 8 bytes (IP + mask),
     * IPv6 constraint 32 bytes (IP + mask) */
    if (constraintLen == 8) {
    #ifdef FREESCALE_MQX
        if (XINET_PTON(WOLFSSL_IP4, ipStr, ipBytes, sizeof(ipBytes)) == RTCS_OK) {
    #else
        if (XINET_PTON(WOLFSSL_IP4, ipStr, ipBytes) == 1) {
    #endif
            ipLen = 4;
        }
    }
    else if (constraintLen == 32) {
    #ifdef FREESCALE_MQX
        if (XINET_PTON(WOLFSSL_IP6, ipStr, ipBytes, sizeof(ipBytes)) == RTCS_OK) {
    #else
        if (XINET_PTON(WOLFSSL_IP6, ipStr, ipBytes) == 1) {
    #endif
            ipLen = 16;
        }
    }

    if (ipLen == 0) {
        return 0;
    }

    return wolfssl_local_MatchIpSubnet(ipBytes, ipLen,
        constraintData, constraintLen);
}

/* Helper to check if name string matches a single GENERAL_NAME constraint.
 * permitted selects subtree semantics for wildcard DNS names: containment
 * for permitted subtrees, intersection for excluded subtrees.
 * Returns 1 if matches, 0 if not. */
static int MatchNameConstraint(int type, const char* name, int nameSz,
    WOLFSSL_GENERAL_NAME* gn, int permitted)
{
    const char* baseStr;
    int baseLen;

    if (gn == NULL || gn->type != type) {
        return 0;
    }

    switch (type) {
        case WOLFSSL_GEN_IPADD:
            return MatchIpName(name, nameSz, gn);

        case WOLFSSL_GEN_DNS:
        case WOLFSSL_GEN_EMAIL:
        case WOLFSSL_GEN_URI:
            if (gn->d.ia5 == NULL) {
                return 0;
            }
            baseStr = (const char*)wolfSSL_ASN1_STRING_get0_data(gn->d.ia5);
            baseLen = wolfSSL_ASN1_STRING_length(gn->d.ia5);
            if (baseStr == NULL || baseLen <= 0) {
                return 0;
            }

            if (type == WOLFSSL_GEN_EMAIL) {
                return wolfssl_local_MatchBaseName(ASN_RFC822_TYPE, name,
                    nameSz, baseStr, baseLen);
            }
            else if (type == WOLFSSL_GEN_URI) {
                return wolfssl_local_MatchUriNameConstraint(name, nameSz,
                    baseStr, baseLen);
            }
            else {
                /* WOLFSSL_GEN_DNS uses DNS-style matching */
                return wolfssl_local_MatchDnsNameConstraint(name, nameSz,
                    baseStr, baseLen, permitted);
            }

        default:
            /* Unsupported type */
            return 0;
    }
}

static int NameConstraintsHasType(const WOLFSSL_STACK* sk, int type)
{
    int i;
    int num;

    if (sk == NULL) {
        return 0;
    }

    num = wolfSSL_sk_GENERAL_SUBTREE_num(sk);
    for (i = 0; i < num; i++) {
        WOLFSSL_GENERAL_SUBTREE* subtree;

        subtree = wolfSSL_sk_GENERAL_SUBTREE_value(sk, i);
        if (subtree != NULL && subtree->base != NULL &&
                subtree->base->type == type) {
            return 1;
        }
    }

    return 0;
}

/*
 * Check if a name string satisfies given name constraints.
 *
 * nc: NAME_CONSTRAINTS struct containing permitted/excluded subtrees
 * type: GeneralName type (WOLFSSL_GEN_DNS, WOLFSSL_GEN_EMAIL, etc.)
 * name: The name string to check
 * nameSz: Length of name string
 *
 * Returns 1 if name satisfies constraints (permitted and not excluded),
 * otherwise 0 if name does not satisfy constraints or on error
 *
 * A name satisfies constraints if permitted subtrees exist for the type,
 * name matches at least one, and name does not match any excluded subtree.
 */
int wolfSSL_NAME_CONSTRAINTS_check_name(WOLFSSL_NAME_CONSTRAINTS* nc,
    int type, const char* name, int nameSz)
{
    int i, num;
    int hasPermittedType = 0;
    int matchedPermitted = 0;
    WOLFSSL_GENERAL_SUBTREE* subtree;
    WOLFSSL_GENERAL_NAME* gn;

    WOLFSSL_ENTER("wolfSSL_NAME_CONSTRAINTS_check_name");

    if (nc == NULL || name == NULL || nameSz <= 0) {
        WOLFSSL_MSG("Bad argument to NAME_CONSTRAINTS_check_name");
        return 0;
    }

    if (type == WOLFSSL_GEN_URI &&
            (NameConstraintsHasType(nc->permittedSubtrees, type) ||
             NameConstraintsHasType(nc->excludedSubtrees, type)) &&
            !wolfssl_local_UriNameHasDnsHost(name, nameSz)) {
        WOLFSSL_MSG("URI name constraint applied to URI without DNS host");
        return 0;
    }

    /* Check permitted subtrees */
    if (nc->permittedSubtrees != NULL) {
        num = wolfSSL_sk_GENERAL_SUBTREE_num(nc->permittedSubtrees);
        for (i = 0; i < num; i++) {
            subtree = wolfSSL_sk_GENERAL_SUBTREE_value(
                nc->permittedSubtrees, i);
            if (subtree == NULL || subtree->base == NULL) {
                continue;
            }

            gn = subtree->base;
            if (gn->type != type) {
                continue;
            }
            hasPermittedType = 1;

            if (MatchNameConstraint(type, name, nameSz, gn, 1)) {
                matchedPermitted = 1;
                break;
            }
        }
    }

    /* If permitted constraints exist for this type but none matched, fail */
    if (hasPermittedType && !matchedPermitted) {
        WOLFSSL_MSG("Name not in permitted subtrees");
        return 0;
    }

    /* Check excluded subtrees */
    if (nc->excludedSubtrees != NULL) {
        num = wolfSSL_sk_GENERAL_SUBTREE_num(nc->excludedSubtrees);
        for (i = 0; i < num; i++) {
            subtree = wolfSSL_sk_GENERAL_SUBTREE_value(nc->excludedSubtrees, i);
            if (subtree == NULL || subtree->base == NULL) {
                continue;
            }

            gn = subtree->base;
            if (gn->type != type) {
                continue;
            }

            if (MatchNameConstraint(type, name, nameSz, gn, 0)) {
                WOLFSSL_MSG("Name in excluded subtrees");
                return 0;
            }
        }
    }

    return 1;
}
#endif /* !IGNORE_NAME_CONSTRAINTS */

#if defined(OPENSSL_ALL) && !defined(NO_BIO)
/* Outputs name string of the given WOLFSSL_GENERAL_NAME_OBJECT to WOLFSSL_BIO.
 * Can handle following GENERAL_NAME_OBJECT types:
 *  - GEN_OTHERNAME #
 *  - GEN_EMAIL
 *  - GEN_DNS
 *  - GEN_X400  #
 *  - GEN_DIRNAME
 *  - GEN_EDIPARTY #
 *  - GEN_URI
 *  - GEN_RID
 * The each name string to be output has "typename:namestring" format.
 * For instance, email name string will be output as "email:facts@wolfssl.com".
 * However,some types above marked with "#" will be output with
 * "typename:<unsupported>".
 *
 * Parameters:
 *  - out: WOLFSSL_BIO object which is the output destination
 *  - gen: WOLFSSL_GENERAL_NAME object to be output its name
 *
 * Returns WOLFSSL_SUCCESS on success, WOLFSSL_FAILURE on failure.
 */
int wolfSSL_GENERAL_NAME_print(WOLFSSL_BIO* out, WOLFSSL_GENERAL_NAME* gen)
{
    int ret, i;
    unsigned int wd;
    unsigned char* p;
    (void)wd;
    (void)p;
    (void)i;
    WOLFSSL_ENTER("wolfSSL_GENERAL_NAME_print");

    if (out == NULL || gen == NULL)
        return WOLFSSL_FAILURE;

    ret = WOLFSSL_FAILURE;
    switch (gen->type)
    {
    case GEN_OTHERNAME:
        ret = wolfSSL_BIO_printf(out, "othername:<unsupported>");
        ret = (ret > 0) ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
        break;

    case GEN_EMAIL:
        ret = wolfSSL_BIO_printf(out, "email:");
        ret = (ret > 0) ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
        if (ret == WOLFSSL_SUCCESS) {
            ret = wolfSSL_ASN1_STRING_print(out, gen->d.rfc822Name);
        }
        break;

    case GEN_DNS:
        ret = wolfSSL_BIO_printf(out, "DNS:");
        ret = (ret > 0) ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
        if (ret == WOLFSSL_SUCCESS) {
            ret = wolfSSL_ASN1_STRING_print(out, gen->d.dNSName);
        }
        break;

    case GEN_X400:
        ret = wolfSSL_BIO_printf(out, "X400Name:<unsupported>");
        ret = (ret > 0) ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
        break;

    case GEN_DIRNAME:
        ret = wolfSSL_BIO_printf(out, "DirName:");
        ret = (ret > 0) ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
        if (ret == WOLFSSL_SUCCESS) {
            ret = wolfSSL_X509_NAME_print_ex(out, gen->d.directoryName, 0,
                                                         XN_FLAG_ONELINE);
        }
        break;

    case GEN_EDIPARTY:
        ret = wolfSSL_BIO_printf(out, "EdiPartyName:<unsupported>");
        ret = (ret > 0) ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
        break;

    case GEN_URI:
        ret = wolfSSL_BIO_printf(out, "URI:");
        ret = (ret > 0) ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
        if (ret == WOLFSSL_SUCCESS) {
            ret = wolfSSL_ASN1_STRING_print(out,
                                    gen->d.uniformResourceIdentifier);
        }
        break;

    case GEN_IPADD:
        ret = wolfSSL_BIO_printf(out, "IP Address");
        ret = (ret > 0) ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
        if (ret == WOLFSSL_SUCCESS) {

            if (!gen->d.iPAddress->length) {
                ret = WOLFSSL_FAILURE;
                break;
            }
            p = (unsigned char*)gen->d.iPAddress->strData;

            if (gen->d.iPAddress->length == 4) {
                ret = wolfSSL_BIO_printf(out, ":%d.%d.%d.%d",
                                  p[0],p[1],p[2],p[3]);
            }
            else if (gen->d.iPAddress->length == 16) {

                for (i = 0; i < 16 && ret == WOLFSSL_SUCCESS;) {
                    wd = p[i] << 8 | p[i+1];

                    i += 2;
                    ret = wolfSSL_BIO_printf(out, ":%X", wd);
                    ret = (ret > 0) ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
                }
            }
            else {
                ret = wolfSSL_BIO_printf(out, "<unsupported>");
            }
            ret = (ret > 0) ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
        }
        break;

    case GEN_RID:
        ret = wolfSSL_BIO_printf(out, "Registered ID:");
        ret = (ret > 0) ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
        if (ret == WOLFSSL_SUCCESS) {
            ret = wolfSSL_i2a_ASN1_OBJECT(out, gen->d.registeredID);
        }
        break;

    default:
        /* unsupported type */
        break;
    }

    if (ret == WC_NO_ERR_TRACE(WOLFSSL_FAILURE))
        return WOLFSSL_FAILURE;
    else
        return WOLFSSL_SUCCESS;
}
#endif /* OPENSSL_ALL */

WOLF_STACK_OF(WOLFSSL_X509_EXTENSION)* wolfSSL_sk_X509_EXTENSION_new_null(void)
{
    WOLFSSL_STACK* sk = wolfSSL_sk_new_node(NULL);
    if (sk) {
        sk->type = STACK_TYPE_X509_EXT;
    }

    return (WOLF_STACK_OF(WOLFSSL_X509_EXTENSION)*)sk;;
}

/* returns the number of nodes on the stack */
int wolfSSL_sk_X509_EXTENSION_num(WOLF_STACK_OF(WOLFSSL_X509_EXTENSION)* sk)
{
    if (sk != NULL) {
        return (int)sk->num;
    }
    return WOLFSSL_FATAL_ERROR;
}


/* returns null on failure and pointer to internal value on success */
WOLFSSL_X509_EXTENSION* wolfSSL_sk_X509_EXTENSION_value(
        const WOLF_STACK_OF(WOLFSSL_X509_EXTENSION)* sk, int idx)
{
    return (WOLFSSL_X509_EXTENSION*)wolfSSL_sk_value(sk, idx);
}

/* frees all of the nodes and the values in stack */
void wolfSSL_sk_X509_EXTENSION_pop_free(
        WOLF_STACK_OF(WOLFSSL_X509_EXTENSION)* sk,
        void (*f) (WOLFSSL_X509_EXTENSION*))
{
    wolfSSL_sk_pop_free(sk, (wolfSSL_sk_freefunc)f);
}

void wolfSSL_sk_X509_EXTENSION_free(WOLF_STACK_OF(WOLFSSL_X509_EXTENSION)* sk)
{
    wolfSSL_sk_pop_free(sk, NULL);
}

#endif /* OPENSSL_EXTRA */

#if defined(OPENSSL_EXTRA) && !defined(NO_FILESYSTEM) && \
    !defined(NO_STDIO_FILESYSTEM)

WOLFSSL_X509* wolfSSL_X509_d2i_fp(WOLFSSL_X509** x509, XFILE file)
{
    WOLFSSL_X509* newX509 = NULL;

    WOLFSSL_ENTER("wolfSSL_X509_d2i_fp");

    if (file != XBADFILE) {
        byte* fileBuffer = NULL;
        long sz = 0;

        if (XFSEEK(file, 0, XSEEK_END) != 0)
            return NULL;
        sz = XFTELL(file);
        if (XFSEEK(file, 0, XSEEK_SET) != 0)
            return NULL;

        if (sz > MAX_WOLFSSL_FILE_SIZE || sz < 0) {
            WOLFSSL_MSG("X509_d2i file size error");
            return NULL;
        }

        fileBuffer = (byte*)XMALLOC(sz, NULL, DYNAMIC_TYPE_FILE);
        if (fileBuffer != NULL) {
            int ret = (int)XFREAD(fileBuffer, 1, (size_t)sz, file);
            if (ret == sz) {
                newX509 = wolfSSL_X509_d2i(NULL, fileBuffer, (int)sz);
            }
            XFREE(fileBuffer, NULL, DYNAMIC_TYPE_FILE);
        }
    }

    if (x509 != NULL)
        *x509 = newX509;

    return newX509;
}

#endif /* OPENSSL_EXTRA && !NO_FILESYSTEM && !NO_STDIO_FILESYSTEM */

#if defined(OPENSSL_EXTRA) || defined(OPENSSL_EXTRA_X509_SMALL) || \
    defined(WOLFSSL_WPAS_SMALL) || defined(KEEP_PEER_CERT) || \
    defined(SESSION_CERTS)

#ifndef NO_FILESYSTEM
WOLFSSL_ABI
WOLFSSL_X509* wolfSSL_X509_load_certificate_file(const char* fname, int format)
{
#ifdef WOLFSSL_SMALL_STACK
    byte  staticBuffer[1]; /* force heap usage */
#else
    byte  staticBuffer[FILE_BUFFER_SIZE];
#endif
    byte* fileBuffer = staticBuffer;
    int   dynamic = 0;
    int   ret;
    long  sz = 0;
    XFILE file;

    WOLFSSL_X509* x509 = NULL;

    /* Check the inputs */
    if ((fname == NULL) ||
        (format != WOLFSSL_FILETYPE_ASN1 && format != WOLFSSL_FILETYPE_PEM))
        return NULL;

    file = XFOPEN(fname, "rb");
    if (file == XBADFILE)
        return NULL;

    if (XFSEEK(file, 0, XSEEK_END) != 0) {
        XFCLOSE(file);
        return NULL;
    }
    sz = XFTELL(file);
    if (XFSEEK(file, 0, XSEEK_SET) != 0) {
        XFCLOSE(file);
        return NULL;
    }

    if (sz > MAX_WOLFSSL_FILE_SIZE || sz < 0) {
        WOLFSSL_MSG("X509_load_certificate_file size error");
        XFCLOSE(file);
        return NULL;
    }

    if (sz > (long)sizeof(staticBuffer)) {
        fileBuffer = (byte*)XMALLOC(sz, NULL, DYNAMIC_TYPE_FILE);
        if (fileBuffer == NULL) {
            XFCLOSE(file);
            return NULL;
        }
        dynamic = 1;
    }

    ret = (int)XFREAD(fileBuffer, 1, (size_t)sz, file);
    if (ret != sz) {
        XFCLOSE(file);
        if (dynamic)
            XFREE(fileBuffer, NULL, DYNAMIC_TYPE_FILE);
        return NULL;
    }

    XFCLOSE(file);

    x509 = wolfSSL_X509_load_certificate_buffer(fileBuffer, (int)sz, format);

    if (dynamic)
        XFREE(fileBuffer, NULL, DYNAMIC_TYPE_FILE);

    return x509;
}
#endif /* !NO_FILESYSTEM */

static WOLFSSL_X509* loadX509orX509REQFromBuffer(
    const unsigned char* buf, int sz, int format, int type,
    wc_pem_password_cb *cb, void *u)
{

    int ret = 0;
    WOLFSSL_X509* x509 = NULL;
    DerBuffer* der = NULL;

    WOLFSSL_ENTER("wolfSSL_X509_load_certificate_ex");

    if (format == WOLFSSL_FILETYPE_PEM) {
        EncryptedInfo info;
        XMEMSET(&info, 0, sizeof(EncryptedInfo));
    #ifdef WOLFSSL_ENCRYPTED_KEYS
        info.passwd_cb       = cb;
        info.passwd_userdata = u;
    #endif

    #ifdef WOLFSSL_PEM_TO_DER
        ret = PemToDer(buf, sz, type, &der, NULL, &info, NULL);
        if (ret != 0) {
            FreeDer(&der);
        }
    #else
        ret = NOT_COMPILED_IN;
    #endif
    }
    else {
        ret = AllocDer(&der, (word32)sz, type, NULL);
        if (ret == 0) {
            XMEMCPY(der->buffer, buf, sz);
        }
    }

    /* At this point we want `der` to have the certificate in DER format */
    /* ready to be decoded. */
    if (der != NULL && der->buffer != NULL) {
        WC_DECLARE_VAR(cert, DecodedCert, 1, 0);

        WC_ALLOC_VAR_EX(cert, DecodedCert, 1, NULL, DYNAMIC_TYPE_DCERT,
            ret=MEMORY_ERROR);
        if (WC_VAR_OK(cert))
        {
            InitDecodedCert(cert, der->buffer, der->length, NULL);
            /* For TRUSTED_CERT_TYPE the DER buffer holds the certificate
             * followed by auxiliary trust info. ParseCertRelative() recognizes
             * the type: it parses only the certificate, permits the trailing
             * aux data, and treats it as CERT_TYPE for verification.
             * CopyDecodedToX509() bounds the stored DER to the certificate. */
            ret = ParseCertRelative(cert, type, 0, NULL, NULL);
            if (ret == 0) {
                x509 = (WOLFSSL_X509*)XMALLOC(sizeof(WOLFSSL_X509), NULL,
                                                             DYNAMIC_TYPE_X509);
                if (x509 != NULL) {
                    InitX509(x509, 1, NULL);
                    ret = CopyDecodedToX509(x509, cert);
                    if (ret != 0) {
                        wolfSSL_X509_free(x509);
                        x509 = NULL;
                    }
                }
                else {
                    ret = MEMORY_ERROR;
                }
            }

            FreeDecodedCert(cert);
            WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
        }

        FreeDer(&der);
    }

    if (ret != 0) {
        WOLFSSL_ERROR(ret);
    }

    /* unused parameter when built without WOLFSSL_ENCRYPTED_KEYS */
    (void)cb;
    (void)u;
    return x509;
}

WOLFSSL_X509* wolfSSL_X509_load_certificate_buffer(
    const unsigned char* buf, int sz, int format)
{
    return loadX509orX509REQFromBuffer(buf, sz,
            format, CERT_TYPE, NULL, NULL);
}

#ifdef WOLFSSL_CERT_REQ
WOLFSSL_X509* wolfSSL_X509_REQ_load_certificate_buffer(
    const unsigned char* buf, int sz, int format)
{
    return loadX509orX509REQFromBuffer(buf, sz,
            format, CERTREQ_TYPE, NULL, NULL);
}
#endif

#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL || KEEP_PEER_CERT || \
          SESSION_CERTS */

#if defined(OPENSSL_EXTRA_X509_SMALL) || defined(KEEP_PEER_CERT) || \
    defined(SESSION_CERTS)
/* Smaller subset of X509 compatibility functions. Avoid increasing the size of
 * this subset and its memory usage */

/* returns a pointer to a new WOLFSSL_X509 structure on success and NULL on
 * fail
 */
WOLFSSL_X509* wolfSSL_X509_new_ex(void* heap)
{
    WOLFSSL_X509* x509;

    x509 = (WOLFSSL_X509*)XMALLOC(sizeof(WOLFSSL_X509), heap,
            DYNAMIC_TYPE_X509);
    if (x509 != NULL) {
        InitX509(x509, 1, heap);
    }

    return x509;
}

WOLFSSL_X509* wolfSSL_X509_new(void)
{
    return wolfSSL_X509_new_ex(NULL);
}

WOLFSSL_ABI
WOLFSSL_X509_NAME* wolfSSL_X509_get_subject_name(WOLFSSL_X509* cert)
{
    WOLFSSL_ENTER("wolfSSL_X509_get_subject_name");
    if (cert)
        return &cert->subject;
    return NULL;
}

WOLFSSL_ABI
WOLFSSL_X509_NAME* wolfSSL_X509_get_issuer_name(WOLFSSL_X509* cert)
{
    WOLFSSL_ENTER("wolfSSL_X509_get_issuer_name");
    if (cert)
        return &cert->issuer;
    return NULL;
}


int wolfSSL_X509_get_signature_type(WOLFSSL_X509* x509)
{
    int type = 0;

    WOLFSSL_ENTER("wolfSSL_X509_get_signature_type");

    if (x509 != NULL)
        type = x509->sigOID;

    return type;
}

#if defined(OPENSSL_EXTRA_X509_SMALL)

int wolfSSL_X509_NAME_get_sz(WOLFSSL_X509_NAME* name)
{
    WOLFSSL_ENTER("wolfSSL_X509_NAME_get_sz");
    if (!name)
        return WOLFSSL_FATAL_ERROR;
    return name->sz;
}

/* Searches for the first ENTRY of type NID
 * idx is the location to start searching from, the value at when the entry was
 *     found is stored into idx
 * returns a pointer to the entry on success and null on fail */
static WOLFSSL_X509_NAME_ENTRY* GetEntryByNID(WOLFSSL_X509_NAME* name, int nid,
        int* idx)
{
    int i;
    WOLFSSL_X509_NAME_ENTRY* ret = NULL;

    for (i = *idx; i < MAX_NAME_ENTRIES; i++) {
        if (name->entry[i].nid == nid) {
            ret = &name->entry[i];
            *idx = i;
            break;
        }
    }
    return ret;
}


/* Used to get a string from the WOLFSSL_X509_NAME structure that
 * corresponds with the NID value passed in. This finds the first entry with
 * matching NID value, if searching for the case where there is multiple
 * entries with the same NID value than other functions should be used
 * (i.e. wolfSSL_X509_NAME_get_index_by_NID, wolfSSL_X509_NAME_get_entry)
 *
 * name structure to get string from
 * nid  NID value to search for
 * buf  [out] buffer to hold results. If NULL then the buffer size minus the
 *      null char is returned.
 * len  size of "buf" passed in
 *
 * returns the length of string found, not including the NULL terminator.
 *         It's possible the function could return a negative value in the
 *         case that len is less than or equal to 0. A negative value is
 *         considered an error case.
 */
int wolfSSL_X509_NAME_get_text_by_NID(WOLFSSL_X509_NAME* name,
                                      int nid, char* buf, int len)
{
    WOLFSSL_X509_NAME_ENTRY* e;
    unsigned char *text = NULL;
    int textSz = 0;
    int idx    = 0;

    WOLFSSL_ENTER("wolfSSL_X509_NAME_get_text_by_NID");

    if (name == NULL) {
        WOLFSSL_MSG("NULL argument passed in");
        return WOLFSSL_FATAL_ERROR;
    }

    e = GetEntryByNID(name, nid, &idx);
    if (e == NULL) {
        WOLFSSL_MSG("Entry type not found");
        return WOLFSSL_FATAL_ERROR;
    }
    text   = wolfSSL_ASN1_STRING_data(e->value);
    textSz = wolfSSL_ASN1_STRING_length(e->value);

    if (text == NULL) {
        WOLFSSL_MSG("Unable to get entry text");
        return WOLFSSL_FATAL_ERROR;
    }

    /* if buf is NULL return size of buffer needed (minus null char) */
    if (buf == NULL) {
        WOLFSSL_MSG("Buffer is NULL, returning buffer size only");
        return textSz;
    }
    if (len <= 0) {
        return 0;
    }

    /* + 1 to account for null char */
    textSz = (int)min((word32)textSz + 1, (word32)len);
    if (textSz > 0) {
        XMEMCPY(buf, text, textSz - 1);
        buf[textSz - 1] = '\0';
    }

    WOLFSSL_LEAVE("wolfSSL_X509_NAME_get_text_by_NID", textSz);
    return (textSz - 1); /* do not include null character in size */
}

/* Creates a new WOLFSSL_EVP_PKEY structure that has the public key from x509
 *
 * returns a pointer to the created WOLFSSL_EVP_PKEY on success and NULL on fail
 */
WOLFSSL_EVP_PKEY* wolfSSL_X509_get_pubkey(WOLFSSL_X509* x509)
{
    WOLFSSL_EVP_PKEY* key = NULL;
    int ret = 0;

    (void)ret;

    WOLFSSL_ENTER("wolfSSL_X509_get_pubkey");
    if (x509 != NULL) {
        key = wolfSSL_EVP_PKEY_new_ex(x509->heap);
        if (key != NULL) {
            if (x509->pubKeyOID == RSAk) {
                key->type = WC_EVP_PKEY_RSA;
            }
            else if (x509->pubKeyOID == DSAk) {
                key->type = WC_EVP_PKEY_DSA;
            }
        #ifdef WOLFSSL_HAVE_MLDSA
            else if (x509->pubKeyOID == ML_DSA_44k ||
                     x509->pubKeyOID == ML_DSA_65k ||
                     x509->pubKeyOID == ML_DSA_87k
        #ifdef WOLFSSL_MLDSA_FIPS204_DRAFT
                     || x509->pubKeyOID == DILITHIUM_LEVEL2k ||
                     x509->pubKeyOID == DILITHIUM_LEVEL3k ||
                     x509->pubKeyOID == DILITHIUM_LEVEL5k
        #endif
                     ) {
                key->type = WC_EVP_PKEY_DILITHIUM;
                WOLFSSL_ATOMIC_STORE(key->mldsaOID, x509->pubKeyOID);
            }
        #endif
        #if defined(HAVE_ED25519) && defined(HAVE_ED25519_KEY_IMPORT)
            else if (x509->pubKeyOID == ED25519k) {
                key->type = WC_EVP_PKEY_ED25519;
            }
        #endif
            else {
                key->type = WC_EVP_PKEY_EC;
            }
            key->save_type = 0;
            key->pkey.ptr = (char*)XMALLOC(
                        x509->pubKey.length, x509->heap,
                                                       DYNAMIC_TYPE_PUBLIC_KEY);
            if (key->pkey.ptr == NULL) {
                wolfSSL_EVP_PKEY_free(key);
                return NULL;
            }
            XMEMCPY(key->pkey.ptr, x509->pubKey.buffer, x509->pubKey.length);
            key->pkey_sz = (int)x509->pubKey.length;

            #ifdef HAVE_ECC
                key->pkey_curve = (int)x509->pkCurveOID;
            #endif /* HAVE_ECC */

            /* decode RSA key */
            #ifndef NO_RSA
            if (key->type == WC_EVP_PKEY_RSA) {
                key->ownRsa = 1;
                key->rsa = wolfSSL_RSA_new();
                if (key->rsa == NULL) {
                    wolfSSL_EVP_PKEY_free(key);
                    return NULL;
                }

                if (wolfSSL_RSA_LoadDer_ex(key->rsa,
                            (const unsigned char*)key->pkey.ptr, key->pkey_sz,
                            WOLFSSL_RSA_LOAD_PUBLIC) != WOLFSSL_SUCCESS) {
                    wolfSSL_EVP_PKEY_free(key);
                    return NULL;
                }
            }
            #endif /* NO_RSA */

            /* decode ECC key */
            #if defined(HAVE_ECC) && defined(OPENSSL_EXTRA)
            if (key->type == WC_EVP_PKEY_EC) {
                word32 idx = 0;

                key->ownEcc = 1;
                key->ecc = wolfSSL_EC_KEY_new();
                if (key->ecc == NULL || key->ecc->internal == NULL) {
                    wolfSSL_EVP_PKEY_free(key);
                    return NULL;
                }

                /* not using wolfSSL_EC_KEY_LoadDer because public key in x509
                 * is in the format of x963 (no sequence at start of buffer) */
                ret = wc_EccPublicKeyDecode((const unsigned char*)key->pkey.ptr,
                                            &idx, (ecc_key*)key->ecc->internal,
                                            key->pkey_sz);
                if (ret < 0) {
                    WOLFSSL_ERROR_VERBOSE(ret);
                    WOLFSSL_MSG("wc_EccPublicKeyDecode failed");
                    wolfSSL_EVP_PKEY_free(key);
                    return NULL;
                }

                if (SetECKeyExternal(key->ecc) != WOLFSSL_SUCCESS) {
                    WOLFSSL_MSG("SetECKeyExternal failed");
                    wolfSSL_EVP_PKEY_free(key);
                    return NULL;
                }

                key->ecc->inSet = 1;
            }
            #endif /* HAVE_ECC && OPENSSL_EXTRA */

            #ifndef NO_DSA
            if (key->type == WC_EVP_PKEY_DSA) {
                key->ownDsa = 1;
                key->dsa = wolfSSL_DSA_new();
                if (key->dsa == NULL) {
                    wolfSSL_EVP_PKEY_free(key);
                    return NULL;
                }

                if (wolfSSL_DSA_LoadDer_ex(key->dsa,
                            (const unsigned char*)key->pkey.ptr, key->pkey_sz, \
                            WOLFSSL_DSA_LOAD_PUBLIC) != WOLFSSL_SUCCESS) {
                    wolfSSL_DSA_free(key->dsa);
                    key->dsa = NULL;
                    wolfSSL_EVP_PKEY_free(key);
                    return NULL;
                }
            }
            #endif /* NO_DSA */

            /* decode Ed25519 key */
            #if defined(HAVE_ED25519) && defined(HAVE_ED25519_KEY_IMPORT)
            if (key->type == WC_EVP_PKEY_ED25519) {
                key->ed25519 = wolfSSL_ED25519_new(x509->heap, INVALID_DEVID);
                if (key->ed25519 == NULL) {
                    wolfSSL_EVP_PKEY_free(key);
                    return NULL;
                }
                key->ownEd25519 = 1;

                /* The X.509 public key buffer holds the raw Ed25519 key
                 * (CopyDecodedToX509 / StoreKey store the BIT STRING
                 * contents), so import it directly. */
                if (wc_ed25519_import_public(
                            (const unsigned char*)key->pkey.ptr,
                            (word32)key->pkey_sz, key->ed25519) != 0) {
                    WOLFSSL_MSG("wc_ed25519_import_public failed");
                    wolfSSL_EVP_PKEY_free(key);
                    return NULL;
                }
            }
            #endif /* HAVE_ED25519 */
        }
    }
    return key;
}
#endif /* OPENSSL_EXTRA_X509_SMALL */

/* End of smaller subset of X509 compatibility functions. Avoid increasing the
 * size of this subset and its memory usage */
#endif /* OPENSSL_EXTRA_X509_SMALL || KEEP_PEER_CERT || SESSION_CERTS */

#if defined(OPENSSL_ALL) || defined(OPENSSL_EXTRA)
/*
 * Converts a and b to DER and then does an XMEMCMP to check if they match.
 * Returns 0 when certificates match and WOLFSSL_FATAL_ERROR when they don't.
 */
int wolfSSL_X509_cmp(const WOLFSSL_X509 *a, const WOLFSSL_X509 *b)
{
        const byte* derA;
        const byte* derB;
        int outSzA = 0;
        int outSzB = 0;

        if (a == NULL || b == NULL) {
            return BAD_FUNC_ARG;
        }

        derA = wolfSSL_X509_get_der((WOLFSSL_X509*)a, &outSzA);
        if (derA == NULL) {
            WOLFSSL_MSG("wolfSSL_X509_get_der - certificate A has failed");
            return WOLFSSL_FATAL_ERROR;
        }
        derB = wolfSSL_X509_get_der((WOLFSSL_X509*)b, &outSzB);
        if (derB == NULL) {
            WOLFSSL_MSG("wolfSSL_X509_get_der - certificate B has failed");
            return WOLFSSL_FATAL_ERROR;
        }

        if (outSzA != outSzB || XMEMCMP(derA, derB, outSzA) != 0) {
            WOLFSSL_LEAVE("wolfSSL_X509_cmp", WOLFSSL_FATAL_ERROR);
            return WOLFSSL_FATAL_ERROR;
        }

        WOLFSSL_LEAVE("wolfSSL_X509_cmp", 0);

        return 0;
    }
#endif /* OPENSSL_ALL */

#if defined(OPENSSL_EXTRA)
    int wolfSSL_X509_ext_isSet_by_NID(WOLFSSL_X509* x509, int nid)
    {
        int isSet = 0;

        WOLFSSL_ENTER("wolfSSL_X509_ext_isSet_by_NID");

        if (x509 != NULL) {
            switch (nid) {
                case WC_NID_basic_constraints:
                    isSet = x509->basicConstSet; break;
                case WC_NID_subject_alt_name:
                    isSet = x509->subjAltNameSet; break;
                case WC_NID_authority_key_identifier:
                    isSet = x509->authKeyIdSet; break;
                case WC_NID_subject_key_identifier:
                    isSet = x509->subjKeyIdSet; break;
                case WC_NID_key_usage:
                    isSet = x509->keyUsageSet; break;
                case WC_NID_crl_distribution_points:
                    isSet = x509->CRLdistSet; break;
                case WC_NID_ext_key_usage:
                    isSet = ((x509->extKeyUsageSrc) ? 1 : 0); break;
                case WC_NID_info_access:
                    isSet = x509->authInfoSet; break;
            #if defined(WOLFSSL_SEP) || defined(WOLFSSL_QT)
                case WC_NID_certificate_policies:
                    isSet = x509->certPolicySet; break;
            #endif /* WOLFSSL_SEP || WOLFSSL_QT */
                default:
                    WOLFSSL_MSG("NID not in table");
            }
        }

        WOLFSSL_LEAVE("wolfSSL_X509_ext_isSet_by_NID", isSet);

        return isSet;
    }


    int wolfSSL_X509_ext_get_critical_by_NID(WOLFSSL_X509* x509, int nid)
    {
        int crit = 0;

        WOLFSSL_ENTER("wolfSSL_X509_ext_get_critical_by_NID");

        if (x509 != NULL) {
            switch (nid) {
                case WC_NID_basic_constraints:
                    crit = x509->basicConstCrit; break;
                case WC_NID_subject_alt_name:
                    crit = x509->subjAltNameCrit; break;
                case WC_NID_authority_key_identifier:
                    crit = x509->authKeyIdCrit; break;
                case WC_NID_subject_key_identifier:
                    crit = x509->subjKeyIdCrit; break;
                case WC_NID_key_usage:
                    crit = x509->keyUsageCrit; break;
                case WC_NID_crl_distribution_points:
                    crit= x509->CRLdistCrit; break;
                case WC_NID_ext_key_usage:
                    crit= x509->extKeyUsageCrit; break;
            #ifdef WOLFSSL_SEP
                case WC_NID_certificate_policies:
                    crit = x509->certPolicyCrit; break;
            #endif /* WOLFSSL_SEP */
            }
        }

        WOLFSSL_LEAVE("wolfSSL_X509_ext_get_critical_by_NID", crit);

        return crit;
    }


    int wolfSSL_X509_get_isSet_pathLength(WOLFSSL_X509* x509)
    {
        int isSet = 0;

        WOLFSSL_ENTER("wolfSSL_X509_get_isSet_pathLength");

        if (x509 != NULL)
            isSet = x509->basicConstPlSet;

        WOLFSSL_LEAVE("wolfSSL_X509_get_isSet_pathLength", isSet);

        return isSet;
    }


    word32 wolfSSL_X509_get_pathLength(WOLFSSL_X509* x509)
    {
        word32 pathLength = 0;

        WOLFSSL_ENTER("wolfSSL_X509_get_pathLength");

        if (x509 != NULL)
            pathLength = x509->pathLength;

        WOLFSSL_LEAVE("wolfSSL_X509_get_pathLength", pathLength);

        return pathLength;
    }


    unsigned int wolfSSL_X509_get_keyUsage(WOLFSSL_X509* x509)
    {
        word16 usage = 0;

        WOLFSSL_ENTER("wolfSSL_X509_get_keyUsage");

        if (x509 != NULL)
            usage = x509->keyUsage;

        WOLFSSL_LEAVE("wolfSSL_X509_get_keyUsage", usage);

        return usage;
    }


    byte* wolfSSL_X509_get_authorityKeyID(WOLFSSL_X509* x509,
                                          byte* dst, int* dstLen)
    {
        byte *id = NULL;
        int copySz = 0;

        WOLFSSL_ENTER("wolfSSL_X509_get_authorityKeyID");

        if (x509 != NULL) {
            if (x509->authKeyIdSet) {
                copySz = (int)min(dstLen != NULL ? (word32)*dstLen : 0,
                                  x509->authKeyIdSz);
                id = x509->authKeyId;
            }

            if (dst != NULL && dstLen != NULL && id != NULL && copySz > 0) {
                XMEMCPY(dst, id, copySz);
                id = dst;
                *dstLen = copySz;
            }
        }

        WOLFSSL_LEAVE("wolfSSL_X509_get_authorityKeyID", copySz);

        return id;
    }

    byte* wolfSSL_X509_get_subjectKeyID(WOLFSSL_X509* x509,
                                        byte* dst, int* dstLen)
    {
        byte *id = NULL;
        int copySz = 0;

        WOLFSSL_ENTER("wolfSSL_X509_get_subjectKeyID");

        if (x509 != NULL) {
            if (x509->subjKeyIdSet) {
                copySz = (int)min(dstLen != NULL ? (word32) *dstLen : 0,
                                  x509->subjKeyIdSz);
                id = x509->subjKeyId;
            }

            if (dst != NULL && dstLen != NULL && id != NULL && copySz > 0) {
                XMEMCPY(dst, id, copySz);
                id = dst;
                *dstLen = copySz;
            }
        }

        WOLFSSL_LEAVE("wolfSSL_X509_get_subjectKeyID", copySz);

        return id;
    }

    const WOLFSSL_ASN1_STRING *wolfSSL_X509_get0_subject_key_id(
            WOLFSSL_X509 *x509)
    {
        WOLFSSL_ASN1_STRING* ret = NULL;

        WOLFSSL_ENTER("wolfSSL_X509_get0_subject_key_id");

        if (x509 != NULL && x509->subjKeyIdSet) {
            if (x509->subjKeyIdStr == NULL) {
                x509->subjKeyIdStr = wolfSSL_ASN1_STRING_new();
                if (x509->subjKeyIdStr != NULL) {
                    if (wolfSSL_ASN1_STRING_set(x509->subjKeyIdStr,
                            x509->subjKeyId, x509->subjKeyIdSz) == 1) {
                    }
                    else {
                        wolfSSL_ASN1_STRING_free(x509->subjKeyIdStr);
                        x509->subjKeyIdStr = NULL;
                    }
                }
            }
            ret = x509->subjKeyIdStr;
        }

        WOLFSSL_LEAVE("wolfSSL_X509_get0_subject_key_id", ret != NULL);

        return ret;
    }
#endif /* OPENSSL_EXTRA */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL) || \
    defined(OPENSSL_EXTRA_X509_SMALL)

    /* Looks up the index of the first entry encountered with matching NID
     * The search starts from index 'pos'
     * returns a negative value on failure and positive index value on success*/
    int wolfSSL_X509_NAME_get_index_by_NID(WOLFSSL_X509_NAME* name,
                                          int nid, int pos)
    {
        int value = nid, i;

        WOLFSSL_ENTER("wolfSSL_X509_NAME_get_index_by_NID");

        if (name == NULL) {
            return BAD_FUNC_ARG;
        }

        i = pos + 1; /* start search after index passed in */
        if (i < 0) {
            i = 0;
        }

        for (;i < name->entrySz && i < MAX_NAME_ENTRIES; i++) {
            if (name->entry[i].nid == value) {
                return i;
            }
        }
        return WOLFSSL_FATAL_ERROR;
    }


    WOLFSSL_ASN1_STRING*  wolfSSL_X509_NAME_ENTRY_get_data(
                                                    WOLFSSL_X509_NAME_ENTRY* in)
    {
        WOLFSSL_ENTER("wolfSSL_X509_NAME_ENTRY_get_data");
        if (in == NULL)
            return NULL;

        return in->value;
    }

#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL */

#ifdef OPENSSL_EXTRA
#ifndef NO_BIO

#ifndef MAX_WIDTH
    #define MAX_WIDTH 80
#endif

#define ACERT_NUM_DIR_TAGS 4

/* Convenience struct and function for printing the Holder sub fields
 * of an X509 Attribute struct. */
struct acert_dir_print_t {
    const char * pfx;
    const byte   tag[3];
};

static struct acert_dir_print_t acert_dir_print[ACERT_NUM_DIR_TAGS] =
{
    { "C=", {0x55, 0x04, ASN_COUNTRY_NAME} },
    { "O=", {0x55, 0x04, ASN_ORG_NAME} },
    { "OU=", {0x55, 0x04, ASN_ORGUNIT_NAME} },
    { "CN=", {0x55, 0x04, ASN_COMMON_NAME} },
};

/* Print an entry of ASN_DIR_TYPE into dst of length max_len.
 *
 * Returns total_len of str on success.
 * Returns < 0 on failure.
 * */
static int X509PrintDirType(char * dst, int max_len, const DNS_entry * entry)
{
    word32       k = 0;
    word32       i = 0;
    const char * src = entry->name;
    word32       src_len = 0;
    int          total_len = 0;
    int          bytes_left = max_len;
    int          fld_len = 0;
    int          match_found = 0;

    XMEMSET(dst, 0, max_len);

    /* The entry holds raw DER which may contain zero bytes, and under
     * WC_ASN_NO_HEAP it is not NUL terminated, so use the stored length. */
    if (entry->len > 0) {
        src_len = (word32)entry->len;
    }

    /* loop over printable DIR tags. */
    for (k = 0; k < ACERT_NUM_DIR_TAGS; ++k) {
        const char * pfx = acert_dir_print[k].pfx;
        const byte * tag = acert_dir_print[k].tag;
        byte         asn_tag;

        /* Walk through entry looking for matches. A match needs three bytes
         * of name OID plus a tag and a length, so the last offset worth
         * testing is the one with exactly five bytes left. Written as an
         * addition so a short entry simply skips the loop rather than
         * underflowing the bound. */
        for (i = 0; i + 5 <= src_len; ++i) {
            if (XMEMCMP(tag, &src[i], 3) == 0) {
                if (bytes_left < 5) {
                    /* Not enough space left for name oid + tag + len. */
                    break;
                }

                if (match_found) {
                    /* append a {',', ' '} before doing anything else. */
                    *dst++ = ',';
                    *dst++ = ' ';
                    total_len += 2;
                    bytes_left -= 2;
                }

                i += 3;

                /* Get the ASN Tag. */
                if (GetASNTag((const byte *)src, &i, &asn_tag, src_len) < 0) {
                    WOLFSSL_MSG("error: GetASNTag failed");
                    break;
                }

                /* Check it is printable. */
                if ((asn_tag != ASN_PRINTABLE_STRING) &&
                    (asn_tag != ASN_IA5_STRING) &&
                    (asn_tag != ASN_UTF8STRING)) {
                    /* Don't know what this is but we can't print it. */
                    WOLFSSL_MSG("error: asn tag not printable string");
                    break;
                }

                /* Now get the length of the printable string. */
                if (GetLength((const byte *)src, &i, &fld_len, src_len) < 0) {
                    break;
                }

                /* Make sure we have space to fit it. */
                if ((int) XSTRLEN(pfx) > bytes_left) {
                    /* Not enough space left. */
                    break;
                }

                /* Copy it in, decrement available space. */
                XSTRNCPY(dst, pfx, bytes_left);
                dst += XSTRLEN(pfx);
                total_len += (int)XSTRLEN(pfx);
                bytes_left -= (int)XSTRLEN(pfx);

                if (fld_len > bytes_left) {
                    /* Not enough space left. */
                    break;
                }

                XMEMCPY(dst, &src[i], fld_len);
                i += fld_len;
                dst += fld_len;
                total_len += fld_len;
                bytes_left -= fld_len;

                match_found = 1;
            }
        }
    }

    return total_len;
}
static int X509_print_name_entry(WOLFSSL_BIO* bio,
                                 const DNS_entry* entry, int indent)
{
    int  ret = WOLFSSL_SUCCESS;
    int  nameCount = 0;
    char scratch[MAX_WIDTH];
    int  len;

    if (bio == NULL || entry == NULL) {
        return WOLFSSL_FAILURE;
    }

    len = XSNPRINTF(scratch, MAX_WIDTH, "%*s", indent, "");
    if (len >= MAX_WIDTH) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, scratch, (int)XSTRLEN(scratch)) <= 0) {
        return WOLFSSL_FAILURE;
    }

    while (entry != NULL) {
        ++nameCount;
        if (nameCount > 1) {
            if (wolfSSL_BIO_write(bio, ", ", 2) <= 0) {
                ret = WOLFSSL_FAILURE;
                break;
            }
        }

        if (entry->type == ASN_DNS_TYPE) {
            len = XSNPRINTF(scratch, MAX_WIDTH, "DNS:%s", entry->name);
        }
    #if defined(OPENSSL_ALL) || defined(WOLFSSL_IP_ALT_NAME)
        else if (entry->type == ASN_IP_TYPE) {
            len = XSNPRINTF(scratch, MAX_WIDTH, "IP Address:%s",
                    entry->ipString);
        }
    #else
        else if (entry->type == ASN_IP_TYPE) {
            /* iPAddress entries are now always parsed into altNames so
             * name constraints can be enforced. Without the
             * human-readable ipString field, emit a fixed label so this
             * print path does not fail. */
            len = XSNPRINTF(scratch, MAX_WIDTH, "IP Address:<unavailable>");
        }
    #endif /* OPENSSL_ALL || WOLFSSL_IP_ALT_NAME */
        else if (entry->type == ASN_RFC822_TYPE) {
            len = XSNPRINTF(scratch, MAX_WIDTH, "email:%s",
                    entry->name);
        }
        else if (entry->type == ASN_DIR_TYPE) {
            len = X509PrintDirType(scratch, MAX_WIDTH, entry);
            if (len == 0) {
                /* Nothing in the encoding was printable. Emit a placeholder,
                 * as the other unsupported entry types do, rather than
                 * failing the print of the whole certificate. */
                len = XSNPRINTF(scratch, MAX_WIDTH, "DirName:<unprintable>");
            }
        }
        else if (entry->type == ASN_URI_TYPE) {
            len = XSNPRINTF(scratch, MAX_WIDTH, "URI:%s",
                entry->name);
        }
    #ifdef WOLFSSL_RID_ALT_NAME
        else if (entry->type == ASN_RID_TYPE) {
            len = XSNPRINTF(scratch, MAX_WIDTH, "Registered ID:%s",
                entry->ridString);
        }
    #else
        else if (entry->type == ASN_RID_TYPE) {
            /* registeredID entries are now always parsed into altNames
             * so name constraints can be enforced. Without the
             * human-readable ridString field, emit a fixed label so
             * this print path does not fail. */
            len = XSNPRINTF(scratch, MAX_WIDTH, "Registered ID:<unavailable>");
        }
    #endif /* WOLFSSL_RID_ALT_NAME */
        else if (entry->type == ASN_OTHER_TYPE) {
            len = XSNPRINTF(scratch, MAX_WIDTH,
                "othername <unsupported>");
        }
        else {
            WOLFSSL_MSG("Bad alt name type.");
            ret = WOLFSSL_FAILURE;
            break;
        }
        if (len >= MAX_WIDTH) {
            ret = WOLFSSL_FAILURE;
            break;
        }
        if (wolfSSL_BIO_write(bio, scratch, (int)XSTRLEN(scratch))
                <= 0) {
            ret = WOLFSSL_FAILURE;
            break;
        }

        entry = entry->next;
    }

    if (ret == WOLFSSL_SUCCESS && wolfSSL_BIO_write(bio, "\n", 1) <= 0) {
        ret = WOLFSSL_FAILURE;
    }

    return ret;
}

#ifdef XSNPRINTF
static int X509PrintKeyUsage(WOLFSSL_BIO* bio, WOLFSSL_X509* x509, int indent)
{
    int ret = WOLFSSL_SUCCESS;
    const int usages[] = {
        KEYUSE_DIGITAL_SIG,
        KEYUSE_CONTENT_COMMIT,
        KEYUSE_KEY_ENCIPHER,
        KEYUSE_DATA_ENCIPHER,
        KEYUSE_KEY_AGREE,
        KEYUSE_KEY_CERT_SIGN,
        KEYUSE_CRL_SIGN,
        KEYUSE_ENCIPHER_ONLY,
        KEYUSE_DECIPHER_ONLY
    };
    const char* usageStrs[] = {
        "Digital Signature",
        "Non Repudiation",
        "Key Encipherment",
        "Data Encipherment",
        "Key Agreement",
        "Certificate Sign",
        "CRL Sign",
        "Encipher Only",
        "Decipher Only"
    };

    if (indent < 0) indent = 0;
    if (indent > MAX_INDENT) indent = MAX_INDENT;

    if (bio == NULL || x509 == NULL) {
        ret = WOLFSSL_FAILURE;
    }

    if (ret == WOLFSSL_SUCCESS && x509->keyUsageSet && x509->keyUsage != 0) {
        char scratch[MAX_WIDTH];
        int len;
        word32 i = 0;
        int usageCount = 0;

        len = XSNPRINTF(scratch, MAX_WIDTH, "%*s", indent, "");
        if (len >= MAX_WIDTH)
            ret = WOLFSSL_FAILURE;
        if (ret == WOLFSSL_SUCCESS) {
            if (wolfSSL_BIO_write(bio, scratch, (int)XSTRLEN(scratch)) <= 0) {
                ret = WOLFSSL_FAILURE;
            }
        }
        for (; ret == WOLFSSL_SUCCESS && i < sizeof(usages) / sizeof(usages[i]);
             i++) {
            if (x509->keyUsage & usages[i]) {
                ++usageCount;
                if (usageCount > 1 && wolfSSL_BIO_write(bio, ", ", 2) <= 0) {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
                if (wolfSSL_BIO_write(bio, usageStrs[i],
                                      (int)XSTRLEN(usageStrs[i])) <= 0) {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
            }
        }
        if (ret == WOLFSSL_SUCCESS && wolfSSL_BIO_write(bio, "\n", 1) <= 0) {
            ret = WOLFSSL_FAILURE;
        }
    }

    return ret;
}

static int X509PrintExtendedKeyUsage(WOLFSSL_BIO* bio, WOLFSSL_X509* x509,
        int indent)
{
    int ret = WOLFSSL_SUCCESS;
    const int usages[] = {
        EXTKEYUSE_OCSP_SIGN,
        EXTKEYUSE_TIMESTAMP,
        EXTKEYUSE_EMAILPROT,
        EXTKEYUSE_CODESIGN,
        EXTKEYUSE_CLIENT_AUTH,
        EXTKEYUSE_SERVER_AUTH,
        EXTKEYUSE_ANY
    };
    const char* usageStrs[] = {
        "OCSP Signing",
        "Time Stamping",
        "E-mail Protection",
        "Code Signing",
        "TLS Web Client Authentication",
        "TLS Web Server Authentication",
        "Any Extended Key Usage"
    };

    if (bio == NULL || x509 == NULL) {
        ret = WOLFSSL_FAILURE;
    }

    if (ret == WOLFSSL_SUCCESS && x509->extKeyUsageCount > 0
            && x509->extKeyUsage != 0) {
        char scratch[MAX_WIDTH];
        int len;
        word32 i = 0;
        int usageCount = 0;

        len = XSNPRINTF(scratch, MAX_WIDTH, "%*s", indent, "");
        if (len >= MAX_WIDTH)
            ret = WOLFSSL_FAILURE;
        if (ret == WOLFSSL_SUCCESS) {
            if (wolfSSL_BIO_write(bio, scratch, (int)XSTRLEN(scratch)) <= 0) {
                ret = WOLFSSL_FAILURE;
            }
        }
        for (; ret == WOLFSSL_SUCCESS && i < sizeof(usages) / sizeof(usages[i]);
             i++) {
            if (x509->extKeyUsage & usages[i]) {
                ++usageCount;
                if (usageCount > 1 && wolfSSL_BIO_write(bio, ", ", 2) <= 0) {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
                if (wolfSSL_BIO_write(bio, usageStrs[i],
                                      (int)XSTRLEN(usageStrs[i])) <= 0) {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
            }
        }
        if (ret == WOLFSSL_SUCCESS && wolfSSL_BIO_write(bio, "\n", 1) <= 0) {
            ret = WOLFSSL_FAILURE;
        }
    }

    return ret;
}


/* print serial number out
 * return WOLFSSL_SUCCESS on success
 */
static int X509PrintSerial_ex(WOLFSSL_BIO* bio, byte* serial, int sz,
        int delimiter, int indent)
{
    char scratch[MAX_WIDTH];
    const int scratchSz = sizeof(scratch);
    int scratchLen;

    if ((scratchLen = XSNPRINTF(scratch, MAX_WIDTH, "%*sSerial Number:",
                                 indent, "")) >= MAX_WIDTH) {
        WOLFSSL_MSG("buffer overrun");
        return WOLFSSL_FAILURE;
    }
    if (wolfSSL_BIO_write(bio, scratch, scratchLen) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (sz > (int)sizeof(byte)) {
        int i;

        /* serial is larger than int size so print off hex values */
        if ((scratchLen = XSNPRINTF(
                 scratch, MAX_WIDTH, "\n%*s", indent + 4, ""))
                >= MAX_WIDTH) {
            WOLFSSL_MSG("buffer overrun");
            return WOLFSSL_FAILURE;
        }
        for (i = 0; i < sz; i++) {
            int valLen;

            if ((valLen = XSNPRINTF(
                     scratch + scratchLen, scratchSz - scratchLen,
                     "%02x%s", serial[i], (i < sz - 1) ?
                     (delimiter ? ":" : "") : "\n"))
                >= scratchSz - scratchLen) {
                WOLFSSL_MSG("buffer overrun");
                return WOLFSSL_FAILURE;
            }
            scratchLen += valLen;
        }
        if (wolfSSL_BIO_write(bio, scratch, scratchLen) <= 0) {
            return WOLFSSL_FAILURE;
        }
    }

    /* if serial can fit into byte then print on the same line */
    else  {
        if ((scratchLen = XSNPRINTF(scratch, MAX_WIDTH, " %d (0x%x)\n",
                (char)serial[0], serial[0])) >= MAX_WIDTH) {
            WOLFSSL_MSG("buffer overrun");
            return WOLFSSL_FAILURE;
        }
        if (wolfSSL_BIO_write(bio, scratch, scratchLen) <= 0) {
            return WOLFSSL_FAILURE;
        }
    }
    return WOLFSSL_SUCCESS;
}

static int X509PrintSerial(WOLFSSL_BIO* bio, WOLFSSL_X509* x509, int indent)
{
    unsigned char serial[32];
    int  sz = sizeof(serial);

    if (indent < 0) indent = 0;
    if (indent > MAX_INDENT) indent = MAX_INDENT;

    XMEMSET(serial, 0, sz);
    if (wolfSSL_X509_get_serial_number(x509, serial, &sz) == WOLFSSL_SUCCESS) {
        X509PrintSerial_ex(bio, serial, sz, 1, indent);
    }
    return WOLFSSL_SUCCESS;
}

#ifndef NO_ASN_TIME
static int X509PrintValidity(WOLFSSL_BIO* bio, WOLFSSL_ASN1_TIME * notBefore,
                             WOLFSSL_ASN1_TIME * notAfter, int indent)
{
    char tmp[80];
    (void) indent;

    if (wolfSSL_BIO_write(bio, "        Validity\n",
                  (int)XSTRLEN("        Validity\n")) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, "            Not Before: ",
                  (int)XSTRLEN("            Not Before: ")) <= 0) {
        return WOLFSSL_FAILURE;
    }
    if (notBefore->length > 0) {
        if (GetTimeString(notBefore->data, ASN_UTC_TIME,
            tmp, sizeof(tmp), notBefore->length) != WOLFSSL_SUCCESS) {
            if (GetTimeString(notBefore->data, ASN_GENERALIZED_TIME,
            tmp, sizeof(tmp), notBefore->length) != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("Error getting not before date");
                return WOLFSSL_FAILURE;
            }
        }
    }
    else {
        XSTRNCPY(tmp, "Not Set", sizeof(tmp)-1);
    }
    tmp[sizeof(tmp) - 1] = '\0'; /* make sure null terminated */
    if (wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, "\n            Not After : ",
                  (int)XSTRLEN("\n            Not After : ")) <= 0) {
        return WOLFSSL_FAILURE;
    }
    if (notAfter->length > 0) {
        if (GetTimeString(notAfter->data, ASN_UTC_TIME,
            tmp, sizeof(tmp), notAfter->length) != WOLFSSL_SUCCESS) {
            if (GetTimeString(notAfter->data, ASN_GENERALIZED_TIME,
                tmp, sizeof(tmp), notAfter->length) != WOLFSSL_SUCCESS) {
                WOLFSSL_MSG("Error getting not after date");
                return WOLFSSL_FAILURE;
            }
        }
    }
    else {
        XSTRNCPY(tmp, "Not Set", sizeof(tmp)-1);
    }
    tmp[sizeof(tmp) - 1] = '\0'; /* make sure null terminated */
    if (wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, "\n\0", (int)XSTRLEN("\n\0")) <= 0) {
        return WOLFSSL_FAILURE;
    }

    return WOLFSSL_SUCCESS;
}
#endif /* ifndef NO_ASN_TIME */

static int X509PrintSubjAltName(WOLFSSL_BIO* bio, WOLFSSL_X509* x509,
                                int indent)
{
    if (!x509 || !x509->altNames || !x509->subjAltNameSet)
        return WOLFSSL_FAILURE;
    return X509_print_name_entry(bio, x509->altNames, indent);
}

/* iterate through certificate extensions printing them out in human readable
 * form
 * return WOLFSSL_SUCCESS on success
 */
static int X509PrintExtensions(WOLFSSL_BIO* bio, WOLFSSL_X509* x509, int indent)
{
    int  ret = WOLFSSL_SUCCESS;
    char scratch[MAX_WIDTH];
    const int scratchSz = sizeof(scratch);
    int scratchLen;
    int  count, i;
    char* buf = NULL;

    if (indent < 0) indent = 0;
    if (indent > MAX_INDENT) indent = MAX_INDENT;

    count = wolfSSL_X509_get_ext_count(x509);
    if (count <= 0)
        return WOLFSSL_SUCCESS;

#ifdef WOLFSSL_CERT_REQ
    if (x509->isCSR) {
        if ((scratchLen = XSNPRINTF(scratch, MAX_WIDTH, "%*s%s\n", indent, "",
                      "Requested extensions:")) >= MAX_WIDTH) {
            return WOLFSSL_FAILURE;
        }
    }
    else
#endif
    {
        if ((scratchLen = XSNPRINTF(scratch, MAX_WIDTH, "%*s%s\n", indent, "",
                                     "X509v3 extensions:")) >= MAX_WIDTH) {
            return WOLFSSL_FAILURE;
        }
    }
    if (wolfSSL_BIO_write(bio, scratch, scratchLen) <= 0) {
        return WOLFSSL_FAILURE;
    }

    buf = (char*)XMALLOC(MAX_WIDTH, x509->heap, DYNAMIC_TYPE_TMP_BUFFER);
    if (buf == NULL) {
        return WOLFSSL_FAILURE;
    }

    for (i = 0; (i < count) && (ret != WC_NO_ERR_TRACE(WOLFSSL_FAILURE)); i++) {
        WOLFSSL_X509_EXTENSION* ext;

        ext = wolfSSL_X509_get_ext(x509, i);
        if (ext != NULL) {
            WOLFSSL_ASN1_OBJECT* obj;
            int nid;
            char val[6];
            int valLen;
            word32 j;

            obj = wolfSSL_X509_EXTENSION_get_object(ext);
            if (obj == NULL) {
                ret = WOLFSSL_FAILURE;
                break;
            }
            if (wolfSSL_OBJ_obj2txt(buf, MAX_WIDTH, obj, 0)
                == WC_NO_ERR_TRACE(WOLFSSL_FAILURE))
            {
                ret = WOLFSSL_FAILURE;
                break;
            }
            if ((scratchLen = XSNPRINTF(
                     scratch, MAX_WIDTH, "%*s%s%s\n", indent + 4, "",
                     buf,
                     (wolfSSL_X509_EXTENSION_get_critical(ext)
                      ? ": critical"
                      : ": ")))
                >= MAX_WIDTH)
            {
                ret = WOLFSSL_FAILURE;
                break;
            }

            if (wolfSSL_BIO_write(bio, scratch, scratchLen) <= 0) {
                ret = WOLFSSL_FAILURE;
                break;
            }
            nid = wolfSSL_OBJ_obj2nid(obj);
            switch (nid) {
            case WC_NID_subject_alt_name:
                ret = X509PrintSubjAltName(bio, x509, indent + 8);
                break;

            case WC_NID_subject_key_identifier:
                if (!x509->subjKeyIdSet || x509->subjKeyId == NULL ||
                    x509->subjKeyIdSz == 0)
                {
                    ret = WOLFSSL_FAILURE;
                    break;
                }

                if ((scratchLen = XSNPRINTF(
                         scratch, scratchSz,
                         "%*s", indent + 8, "")) >= scratchSz)
                {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
                for (j = 0; j < x509->subjKeyIdSz; j++) {
                    if ((valLen = XSNPRINTF(
                             val, sizeof(val), "%02X%s",
                             x509->subjKeyId[j],
                             (j < x509->subjKeyIdSz - 1) ? ":" : "\n"))
                        >= (int)sizeof(val))
                    {
                        ret = WOLFSSL_FAILURE;
                        break;
                    }
                    if (scratchLen + valLen >= scratchSz) {
                        if (wolfSSL_BIO_write(bio, scratch,
                                              scratchLen) <= 0) {
                            ret = WOLFSSL_FAILURE;
                            break;
                        }
                        scratchLen = 0;
                    }
                    XMEMCPY(scratch + scratchLen, val, valLen);
                    scratchLen += valLen;
                }
                if (ret == WC_NO_ERR_TRACE(WOLFSSL_FAILURE))
                    break;
                if (wolfSSL_BIO_write(bio, scratch,
                                      scratchLen) <= 0) {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
                break;

            case WC_NID_authority_key_identifier:
                if (!x509->authKeyIdSet || x509->authKeyId == NULL ||
                    x509->authKeyIdSz == 0) {
                    ret = WOLFSSL_FAILURE;
                    break;
                }

                if ((scratchLen = XSNPRINTF(
                         scratch, scratchSz, "%*s%s",
                         indent + 8, "", "keyid:")) >= scratchSz)
                {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
                for (j = 0; j < x509->authKeyIdSz; j++) {
                    if ((valLen = XSNPRINTF(
                             val, sizeof(val), "%02X%s",
                             x509->authKeyId[j],
                             (j < x509->authKeyIdSz - 1) ? ":" : "\n\n"))
                        >= (int)sizeof(val))
                    {
                        ret = WOLFSSL_FAILURE;
                        break;
                    }
                    if (scratchLen >= scratchSz - valLen) {
                        if (wolfSSL_BIO_write(bio, scratch,
                                              scratchLen) <= 0)
                        {
                            ret = WOLFSSL_FAILURE;
                            break;
                        }
                        scratchLen = 0;
                    }
                    if (scratchLen + valLen >= scratchSz) {
                        ret = WOLFSSL_FAILURE;
                        break;
                    }
                    XMEMCPY(scratch + scratchLen, val, valLen);
                    scratchLen += valLen;
                }
                if (ret == WC_NO_ERR_TRACE(WOLFSSL_FAILURE))
                    break;
                if (wolfSSL_BIO_write(bio, scratch,
                                      scratchLen) <= 0) {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
                break;

            case WC_NID_basic_constraints:
                if (!x509->basicConstSet) {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
                /* Match OpenSSL output: print "CA:TRUE"/"CA:FALSE" and append
                 * ", pathlen:N" only when a pathLenConstraint is present
                 * (RFC 5280 4.2.1.9). An absent constraint imposes no limit
                 * and must not be shown as pathlen:0. */
                if (x509->basicConstPlSet) {
                    scratchLen = XSNPRINTF(scratch, scratchSz,
                        "%*sCA:%s, pathlen:%u\n",
                        indent + 8, "", (x509->isCa) ? "TRUE" : "FALSE",
                        (unsigned int)x509->pathLength);
                }
                else {
                    scratchLen = XSNPRINTF(scratch, scratchSz,
                        "%*sCA:%s\n",
                        indent + 8, "", (x509->isCa) ? "TRUE" : "FALSE");
                }
                if (scratchLen >= scratchSz) {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
                if (wolfSSL_BIO_write(bio, scratch,
                                      scratchLen) <= 0) {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
                break;

            case WC_NID_key_usage:
                ret = X509PrintKeyUsage(bio, x509, indent + 8);
                break;

            case WC_NID_ext_key_usage:
                ret = X509PrintExtendedKeyUsage(bio, x509, indent + 8);
                break;

            default:
                /* extension nid not yet supported */
                if ((scratchLen = XSNPRINTF(
                         scratch, MAX_WIDTH,
                         "%*sNID %d print not yet supported\n",
                         indent + 8, "", nid)) >= MAX_WIDTH)
                {
                    ret = WOLFSSL_FAILURE;
                    break;
                }

                if (wolfSSL_BIO_write(bio, scratch, scratchLen) <= 0) {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
            }
        }
    }

    XFREE(buf, x509->heap, DYNAMIC_TYPE_TMP_BUFFER);

    return ret;
}


/* print out the signature in human readable format for use with
 * wolfSSL_X509_print()
 * return WOLFSSL_SUCCESS on success
 */
static int X509PrintSignature_ex(WOLFSSL_BIO* bio, byte* sig,
        int sigSz, int sigNid, int algOnly, int indent)
{
    char scratch[MAX_WIDTH];
    int scratchLen;
    WOLFSSL_ASN1_OBJECT* obj = NULL;
    int ret = WOLFSSL_SUCCESS;
    char tmp[100];
    int tmpLen = 0;

    if (sigSz <= 0) {
        return WOLFSSL_SUCCESS;
    }

    if ((scratchLen = XSNPRINTF(scratch, MAX_WIDTH, "%*s%s", indent, "",
                                "Signature Algorithm: ")) >= MAX_WIDTH) {
        ret = WOLFSSL_FAILURE;
    }

    if (ret == WOLFSSL_SUCCESS) {
        if (wolfSSL_BIO_write(bio, scratch, scratchLen) <= 0)
            ret = WOLFSSL_FAILURE;
    }

    if (ret == WOLFSSL_SUCCESS) {
        obj = wolfSSL_OBJ_nid2obj(sigNid);
        if (obj == NULL)
            ret = WOLFSSL_FAILURE;
    }
    if (ret == WOLFSSL_SUCCESS) {
        if (wolfSSL_OBJ_obj2txt(scratch, MAX_WIDTH, obj, 0)
            == WC_NO_ERR_TRACE(WOLFSSL_FAILURE))
        {
            ret = WOLFSSL_FAILURE;
        }
    }

    if (ret == WOLFSSL_SUCCESS) {
        if ((tmpLen = XSNPRINTF(tmp, sizeof(tmp),"%s\n", scratch))
            >= (int)sizeof(tmp))
        {
            ret = WOLFSSL_FAILURE;
        }
    }
    if (ret == WOLFSSL_SUCCESS) {
        if (wolfSSL_BIO_write(bio, tmp, tmpLen) <= 0)
            ret = WOLFSSL_FAILURE;
    }

    /* Leave function if the desired content to print
     * is only the signature algorithm */
    if (algOnly) {
        if (obj != NULL)
            wolfSSL_ASN1_OBJECT_free(obj);

        return ret;
    }

    if (ret == WOLFSSL_SUCCESS) {
        if ((tmpLen = XSNPRINTF(tmp, sizeof(tmp), "%*s", indent + 5, ""))
            >= (int)sizeof(tmp))
        {
            ret = WOLFSSL_FAILURE;
        }
    }

    if (ret == WOLFSSL_SUCCESS) {
        int i;

        for (i = 0; i < sigSz; i++) {
            char val[6];
            int valLen;

            if (i == 0) {
                if ((valLen = XSNPRINTF(val, sizeof(val), "%02x", sig[i]))
                    >= (int)sizeof(val))
                {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
            }
            else if (((i % 18) == 0)) {
                if (wolfSSL_BIO_write(bio, tmp, tmpLen)
                    <= 0) {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
                if ((tmpLen = XSNPRINTF(tmp, sizeof(tmp), ":\n%*s",
                                        indent + 5, ""))
                    >= (int)sizeof(tmp))
                {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
                if ((valLen = XSNPRINTF(val, sizeof(val), "%02x", sig[i]))
                    >= (int)sizeof(val))
                {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
            }
            else {
                if ((valLen = XSNPRINTF(val, sizeof(val), ":%02x", sig[i]))
                    >= (int)sizeof(val))
                {
                    ret = WOLFSSL_FAILURE;
                    break;
                }
            }
            if ((tmpLen < 0) || (valLen < 0) ||
                    (valLen >= ((int)sizeof(tmp) - tmpLen - 1))) {
                ret = WOLFSSL_FAILURE;
                break;
            }
            XMEMCPY(tmp + tmpLen, val, valLen);
            tmpLen += valLen;
            tmp[tmpLen] = 0;
        }
    }

    /* print out remaining sig values */
    if (ret == WOLFSSL_SUCCESS) {
        if (tmpLen > 0) {
            if (wolfSSL_BIO_write(bio, tmp, tmpLen)
                <= 0)
            {
                ret = WOLFSSL_FAILURE;
            }
        }
    }

    if (obj != NULL)
        wolfSSL_ASN1_OBJECT_free(obj);

    return ret;
}

static int X509PrintSignature(WOLFSSL_BIO* bio, WOLFSSL_X509* x509,
        int algOnly, int indent)
{
    int sigSz = 0;
    if (wolfSSL_X509_get_signature(x509, NULL, &sigSz) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (sigSz > 0) {
        unsigned char* sig;
        int sigNid;

        sigNid = wolfSSL_X509_get_signature_nid(x509);
        if (sigNid <= 0) {
            return WOLFSSL_FAILURE;
        }

        sig = (unsigned char*)XMALLOC(sigSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        if (sig == NULL) {
            return WOLFSSL_FAILURE;
        }

        if (wolfSSL_X509_get_signature(x509, sig, &sigSz) <= 0) {
            XFREE(sig, NULL, DYNAMIC_TYPE_TMP_BUFFER);
            return WOLFSSL_FAILURE;
        }

        if (X509PrintSignature_ex(bio, sig, sigSz, sigNid, algOnly, indent)
                != WOLFSSL_SUCCESS) {
            XFREE(sig, NULL, DYNAMIC_TYPE_TMP_BUFFER);
            return WOLFSSL_FAILURE;
        }

        XFREE(sig, NULL, DYNAMIC_TYPE_TMP_BUFFER);

    }

    return WOLFSSL_SUCCESS;
}


/* print out the public key in human readable format for use with
 * wolfSSL_X509_print()
 * return WOLFSSL_SUCCESS on success
 */
static int X509PrintPubKey(WOLFSSL_BIO* bio, WOLFSSL_X509* x509, int indent)
{
    char scratch[MAX_WIDTH];
    WOLFSSL_EVP_PKEY* pubKey;
    int len;
    int ret = WOLFSSL_SUCCESS;

    if (indent < 0) indent = 0;
    if (indent > MAX_INDENT) indent = MAX_INDENT;

    if (bio == NULL || x509 == NULL)
        return BAD_FUNC_ARG;

    len = XSNPRINTF(scratch, MAX_WIDTH, "%*sSubject Public Key Info:\n", indent,
        "");
    if (len >= MAX_WIDTH)
        return WOLFSSL_FAILURE;
    if (wolfSSL_BIO_write(bio, scratch, len) <= 0)
        return WOLFSSL_FAILURE;

    switch (x509->pubKeyOID) {
    #ifndef NO_RSA
        case RSAk:
            len = XSNPRINTF(scratch, MAX_WIDTH,
                    "%*sPublic Key Algorithm: rsaEncryption\n", indent + 4, "");
            if (len >= MAX_WIDTH)
                return WOLFSSL_FAILURE;
            if (wolfSSL_BIO_write(bio, scratch, len) <= 0)
                return WOLFSSL_FAILURE;
            break;
    #endif
    #ifdef HAVE_ECC
        case ECDSAk:
            len = XSNPRINTF(scratch, MAX_WIDTH,
                    "%*sPublic Key Algorithm: EC\n", indent + 4, "");
            if ((len < 0) || (len >= MAX_WIDTH))
                return WOLFSSL_FAILURE;
            if (wolfSSL_BIO_write(bio, scratch, len) <= 0)
                return WOLFSSL_FAILURE;
            break;
    #endif
        default:
                WOLFSSL_MSG("Unknown key type");
                return WOLFSSL_FAILURE;
    }

    pubKey = wolfSSL_X509_get_pubkey(x509);
    if (pubKey == NULL)
        return WOLFSSL_FAILURE;

    ret = wolfSSL_EVP_PKEY_print_public(bio, pubKey, indent + 8, NULL);

    wolfSSL_EVP_PKEY_free(pubKey);

    return ret;
}


/* human readable print out of x509 name formatted for use with
 * wolfSSL_X509_print()
 * return WOLFSSL_SUCCESS on success
 */
static int X509PrintName(WOLFSSL_BIO* bio, WOLFSSL_X509_NAME* name,
        char* type, int indent)
{
    if (name != NULL) {
        char scratch[MAX_WIDTH];
        int scratchLen;

        if ((scratchLen = XSNPRINTF(scratch, MAX_WIDTH,
                                     "%*s%s", indent, "", type))
            >= MAX_WIDTH)
        {
            return WOLFSSL_FAILURE;
        }
        if (wolfSSL_BIO_write(bio, scratch, scratchLen) <= 0) {
            return WOLFSSL_FAILURE;
        }
        if (wolfSSL_X509_NAME_print_ex(bio, name, 1, 0) <= 0) {
            return WOLFSSL_FAILURE;
        }
        if (wolfSSL_BIO_write(bio, "\n", (int)XSTRLEN("\n")) <= 0) {
            return WOLFSSL_FAILURE;
        }
    }
    return WOLFSSL_SUCCESS;
}


/* human readable print out of x509 version
 * return WOLFSSL_SUCCESS on success
 */
static int X509PrintVersion(WOLFSSL_BIO* bio, int version, int indent)
{
    char scratch[MAX_WIDTH];
    int scratchLen;

    if (indent < 0) indent = 0;
    if (indent > MAX_INDENT) indent = MAX_INDENT;

    scratchLen = XSNPRINTF(scratch, MAX_WIDTH, "%*s%s", indent, "", "Version:");
    if ((scratchLen < 0) || (scratchLen >= MAX_WIDTH)) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, scratch, scratchLen) <= 0) {
        return WOLFSSL_FAILURE;
    }

    scratchLen = XSNPRINTF(scratch, MAX_WIDTH, " %d (0x%x)\n",
                    version, (byte)version-1);
    if ((scratchLen < 0) || (scratchLen >= MAX_WIDTH)) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, scratch, scratchLen) <= 0) {
        return WOLFSSL_FAILURE;
    }
    return WOLFSSL_SUCCESS;
}

#ifdef WOLFSSL_CERT_REQ
/* Print out of REQ attributes
 * return WOLFSSL_SUCCESS on success
 */
static int X509PrintReqAttributes(WOLFSSL_BIO* bio, WOLFSSL_X509* x509,
        int indent)
{
    WOLFSSL_X509_ATTRIBUTE* attr;
    char scratch[MAX_WIDTH];
    int scratchLen;
    int i = 0;

    if (indent < 0) indent = 0;
    if (indent > MAX_INDENT) indent = MAX_INDENT;

    if ((scratchLen = XSNPRINTF(scratch, MAX_WIDTH,
                                 "%*s%s", indent, "", "Attributes: \n"))
        >= MAX_WIDTH)
    {
        return WOLFSSL_FAILURE;
    }
    if (wolfSSL_BIO_write(bio, scratch, scratchLen) <= 0) {
        return WOLFSSL_FAILURE;
    }
    do {
        attr = wolfSSL_X509_REQ_get_attr(x509, i);
        if (attr != NULL) {
            char lName[NAME_SZ/4]; /* NAME_SZ default is 80 */
            int lNameSz = NAME_SZ/4;
            const byte* data;

            if (wolfSSL_OBJ_obj2txt(lName, lNameSz, attr->object, 0)
                == WC_NO_ERR_TRACE(WOLFSSL_FAILURE))
            {
                return WOLFSSL_FAILURE;
            }
            lNameSz = (int)XSTRLEN(lName);
            data = wolfSSL_ASN1_STRING_get0_data(
                    attr->value->value.asn1_string);
            if (data == NULL) {
                WOLFSSL_MSG("No REQ attribute found when expected");
                return WOLFSSL_FAILURE;
            }
            if ((scratchLen = XSNPRINTF(scratch, MAX_WIDTH,
                          "%*s%s%*s:%s\n", indent+4, "",
                          lName, (NAME_SZ/4)-lNameSz, "", data))
                >= MAX_WIDTH)
            {
                return WOLFSSL_FAILURE;
            }
            if (wolfSSL_BIO_write(bio, scratch, scratchLen) <= 0) {
                WOLFSSL_MSG("Error writing REQ attribute");
                return WOLFSSL_FAILURE;
            }
        }
        i++;
    } while (attr != NULL);

    return WOLFSSL_SUCCESS;
}


/*
 * return WOLFSSL_SUCCESS on success
 */
int wolfSSL_X509_REQ_print(WOLFSSL_BIO* bio, WOLFSSL_X509* x509)
{
    char subjType[] = "Subject: ";

    if (bio == NULL || x509 == NULL) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, "Certificate Request:\n",
                  (int)XSTRLEN("Certificate Request:\n")) <= 0) {
            return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, "    Data:\n",
                  (int)XSTRLEN("    Data:\n")) <= 0) {
            return WOLFSSL_FAILURE;
    }

    /* print version of cert.  Note that we increment by 1 because for REQs,
     * the value stored in x509->version is the actual value of the field; not
     * the version. */
    if (X509PrintVersion(bio, (int)wolfSSL_X509_REQ_get_version(x509) + 1, 8)
            != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    if (X509PrintSerial(bio, x509, 8) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print subject */
    if (X509PrintName(bio, wolfSSL_X509_get_subject_name(x509), subjType, 8)
            != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* get and print public key */
    if (X509PrintPubKey(bio, x509, 8) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print out extensions */
    if (X509PrintExtensions(bio, x509, 4) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print out req attributes */
    if (X509PrintReqAttributes(bio, x509, 4) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print out signature */
    if (X509PrintSignature(bio, x509, 0, 4) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* done with print out */
    if (wolfSSL_BIO_write(bio, "\n\0", (int)XSTRLEN("\n\0")) <= 0) {
        return WOLFSSL_FAILURE;
    }

    return WOLFSSL_SUCCESS;
}
#endif /* WOLFSSL_CERT_REQ */


/* Writes the human readable form of x509 to bio.
 *
 * bio  WOLFSSL_BIO to write to.
 * x509 Certificate to write.
 *
 * returns WOLFSSL_SUCCESS on success and WOLFSSL_FAILURE on failure
 */
int wolfSSL_X509_print_ex(WOLFSSL_BIO* bio, WOLFSSL_X509* x509,
    unsigned long nmflags, unsigned long cflag)
{
    char issuType[] = "Issuer:";
    char subjType[] = "Subject:";

    WOLFSSL_ENTER("wolfSSL_X509_print_ex");

    /* flags currently not supported */
    (void)nmflags;
    (void)cflag;

    if (bio == NULL || x509 == NULL) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, "Certificate:\n",
                  (int)XSTRLEN("Certificate:\n")) <= 0) {
            return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, "    Data:\n",
                  (int)XSTRLEN("    Data:\n")) <= 0) {
            return WOLFSSL_FAILURE;
    }

    /* print version of cert */
    if (X509PrintVersion(bio, wolfSSL_X509_version(x509), 8)
            != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print serial number out */
    if (X509PrintSerial(bio, x509, 8) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print out signature algo*/
    if (X509PrintSignature(bio, x509, 1, 8) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print issuer */
    if (X509PrintName(bio, wolfSSL_X509_get_issuer_name(x509), issuType, 8)
            != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    #ifndef NO_ASN_TIME
    /* print validity */
    if (X509PrintValidity(bio, &x509->notBefore, &x509->notAfter, 8)
        != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }
    #endif /* NO_ASN_TIME */

    /* print subject */
    if (X509PrintName(bio, wolfSSL_X509_get_subject_name(x509), subjType, 8)
            != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* get and print public key */
    if (X509PrintPubKey(bio, x509, 8) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print out extensions */
    if (X509PrintExtensions(bio, x509, 8) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print out signature */
    if (X509PrintSignature(bio, x509, 0, 4) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* done with print out */
    if (wolfSSL_BIO_write(bio, "\n\0", (int)XSTRLEN("\n\0")) <= 0) {
        return WOLFSSL_FAILURE;
    }

    return WOLFSSL_SUCCESS;
}
int wolfSSL_X509_print(WOLFSSL_BIO* bio, WOLFSSL_X509* x509)
{
    return wolfSSL_X509_print_ex(bio, x509, 0, 0);
}

#if defined(WOLFSSL_ACERT)
/* Retrieve sig NID from an ACERT.
 *
 * returns  NID on success
 * returns  0 on failure
 */
int wolfSSL_X509_ACERT_get_signature_nid(const WOLFSSL_X509_ACERT *x509)
{
    if (x509 == NULL) {
        return 0;
    }

    return oid2nid((word32)x509->sigOID, oidSigType);
}

static int X509AcertPrintSignature(WOLFSSL_BIO* bio, WOLFSSL_X509_ACERT* x509,
                                   int algOnly, int indent)
{
    int sigSz = 0;
    if (wolfSSL_X509_ACERT_get_signature(x509, NULL, &sigSz) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (sigSz > 0) {
        unsigned char* sig;
        int sigNid;

        sigNid = wolfSSL_X509_ACERT_get_signature_nid(x509);
        if (sigNid <= 0) {
            return WOLFSSL_FAILURE;
        }

        sig = (unsigned char*)XMALLOC(sigSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        if (sig == NULL) {
            return WOLFSSL_FAILURE;
        }

        if (wolfSSL_X509_ACERT_get_signature(x509, sig, &sigSz) <= 0) {
            XFREE(sig, NULL, DYNAMIC_TYPE_TMP_BUFFER);
            return WOLFSSL_FAILURE;
        }

        if (X509PrintSignature_ex(bio, sig, sigSz, sigNid, algOnly, indent)
                != WOLFSSL_SUCCESS) {
            XFREE(sig, NULL, DYNAMIC_TYPE_TMP_BUFFER);
            return WOLFSSL_FAILURE;
        }

        if (sig != NULL) {
            XFREE(sig, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        }

    }

    return WOLFSSL_SUCCESS;
}

static int X509AcertPrintSerial(WOLFSSL_BIO* bio, WOLFSSL_X509_ACERT* x509,
                                int indent)
{
    unsigned char serial[32];
    int  sz = sizeof(serial);

    XMEMSET(serial, 0, sz);
    if (wolfSSL_X509_ACERT_get_serial_number(x509, serial, &sz)
        == WOLFSSL_SUCCESS) {
        X509PrintSerial_ex(bio, serial, sz, 1, indent);
    }
    return WOLFSSL_SUCCESS;
}

int wolfSSL_X509_ACERT_print(WOLFSSL_BIO* bio, WOLFSSL_X509_ACERT* x509)
{
    const char * hdr =                "Attribute Certificate:\n";
    const char * data_hdr =           "    Data:\n";
    const char * holder_hdr =         "        Holder:\n";
    const char * holder_issuer_hdr =  "            Issuer:";
    const char * holder_name_hdr =    "            Name:";
    const char * attcert_issuer_hdr = "        Issuer:";

    if (bio == NULL || x509 == NULL) {
        return WOLFSSL_FAILURE;
    }

    /* print acert header */
    if (wolfSSL_BIO_write(bio, hdr, (int)XSTRLEN(hdr)) <= 0) {
        return WOLFSSL_FAILURE;
    }

    /* print data header */
    if (wolfSSL_BIO_write(bio, data_hdr, (int)XSTRLEN(data_hdr)) <= 0) {
        return WOLFSSL_FAILURE;
    }

    /* print version of cert */
    if (X509PrintVersion(bio, wolfSSL_X509_ACERT_version(x509), 8)
            != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print serial number out */
    if (X509AcertPrintSerial(bio, x509, 8) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print holder field */
    if (wolfSSL_BIO_write(bio, holder_hdr, (int)XSTRLEN(holder_hdr)) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (x509->holderEntityName != NULL) {
        /* print issuer header */
        if (wolfSSL_BIO_write(bio, holder_name_hdr,
            (int)XSTRLEN(holder_name_hdr)) <= 0) {
            return WOLFSSL_FAILURE;
        }

        if (X509_print_name_entry(bio, x509->holderEntityName, 1)
                != WOLFSSL_SUCCESS) {
            return WOLFSSL_FAILURE;
        }
    }

    if (x509->holderIssuerName != NULL) {
        /* print issuer header */
        if (wolfSSL_BIO_write(bio, holder_issuer_hdr,
            (int)XSTRLEN(holder_issuer_hdr)) <= 0) {
            return WOLFSSL_FAILURE;
        }

        if (X509_print_name_entry(bio, x509->holderIssuerName, 1)
            != WOLFSSL_SUCCESS) {
            return WOLFSSL_FAILURE;
        }
    }

    if (x509->holderSerialSz > 0) {
        X509PrintSerial_ex(bio, x509->holderSerial, x509->holderSerialSz,
                           1, 12);
    }

    /* print issuer header */
    if (wolfSSL_BIO_write(bio, attcert_issuer_hdr,
        (int)XSTRLEN(attcert_issuer_hdr)) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (x509->AttCertIssuerName != NULL) {
        if (X509_print_name_entry(bio, x509->AttCertIssuerName, 1)
                != WOLFSSL_SUCCESS) {
            return WOLFSSL_FAILURE;
        }
    }
    else {
        const char * msg = " Issuer type not supported.\n";
        if (wolfSSL_BIO_write(bio, msg, (int)XSTRLEN(msg)) <= 0) {
            return WOLFSSL_FAILURE;
        }
    }

    #ifndef NO_ASN_TIME
    /* print validity */
    if (X509PrintValidity(bio, &x509->notBefore, &x509->notAfter, 8)
        != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }
    #endif /* NO_ASN_TIME */

    /* print raw attributes */
    if (x509->rawAttr && x509->rawAttrLen > 0) {
        char attr_hdr[128]; /* buffer for XSNPRINTF */

        if (XSNPRINTF(attr_hdr, 128, "%*s%s: %d bytes\n", 8, "",
                    "Attributes", x509->rawAttrLen) >= 128) {
            return WOLFSSL_FAILURE;
        }

        if (wolfSSL_BIO_write(bio, attr_hdr, (int)XSTRLEN(attr_hdr)) <= 0) {
                return WOLFSSL_FAILURE;
        }
    }

    /* print out sig algo and signature */
    if (X509AcertPrintSignature(bio, x509, 0, 8) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* done with print out */
    if (wolfSSL_BIO_write(bio, "\n\0", (int)XSTRLEN("\n\0")) <= 0) {
        return WOLFSSL_FAILURE;
    }

    return WOLFSSL_SUCCESS;
}
#endif /* WOLFSSL_ACERT */

#ifndef NO_FILESYSTEM
int wolfSSL_X509_print_fp(XFILE fp, WOLFSSL_X509 *x509)
{
    WOLFSSL_BIO* bio;
    int ret;

    WOLFSSL_ENTER("wolfSSL_X509_print_fp");

    if (!fp || !x509) {
        WOLFSSL_MSG("Bad parameter");
        return WOLFSSL_FAILURE;
    }

    if (!(bio = wolfSSL_BIO_new(wolfSSL_BIO_s_file()))) {
        WOLFSSL_MSG("wolfSSL_BIO_new wolfSSL_BIO_s_file error");
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_set_fp(bio, fp, WOLFSSL_BIO_NOCLOSE) != WOLFSSL_SUCCESS) {
        WOLFSSL_MSG("wolfSSL_BIO_set_fp error");
        wolfSSL_BIO_free(bio);
        return WOLFSSL_FAILURE;
    }

    ret = wolfSSL_X509_print(bio, x509);

    wolfSSL_BIO_free(bio);

    return ret;
}
#endif /* NO_FILESYSTEM */

#endif /* XSNPRINTF */

int wolfSSL_X509_signature_print(WOLFSSL_BIO *bp,
        const WOLFSSL_X509_ALGOR *sigalg, const WOLFSSL_ASN1_STRING *sig)
{
    int length = 0;
    word32 idx = 0;
    int i;

    (void)sig;

    WOLFSSL_ENTER("wolfSSL_X509_signature_print");

    if (!bp || !sigalg) {
        WOLFSSL_MSG("Bad parameter");
        return WOLFSSL_FAILURE;
    }

    if ((sigalg->algorithm->obj == NULL) ||
        (sigalg->algorithm->obj[idx] != ASN_OBJECT_ID)) {
        WOLFSSL_MSG("Bad ASN1 Object");
        return WOLFSSL_FAILURE;
    }
    idx++; /* skip object id */

    if (GetLength((const byte*)sigalg->algorithm->obj, &idx, &length,
                  sigalg->algorithm->objSz) < 0 || length < 0) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_puts(bp, "    Raw Signature Algorithm:") <= 0) {
        WOLFSSL_MSG("wolfSSL_BIO_puts error");
        return WOLFSSL_FAILURE;
    }

    for (i = 0; i < length; ++i) {
        char hex_digits[4];
        if (XSNPRINTF(hex_digits, sizeof(hex_digits), "%c%02X", i>0 ? ':' : ' ',
                  (unsigned int)sigalg->algorithm->obj[idx+i])
            >= (int)sizeof(hex_digits))
        {
            WOLFSSL_MSG("buffer overrun");
            return WOLFSSL_FAILURE;
        }
        if (wolfSSL_BIO_puts(bp, hex_digits) <= 0)
            return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_puts(bp, "\n") <= 0)
        return WOLFSSL_FAILURE;

    return WOLFSSL_SUCCESS;
}
#endif /* !NO_BIO */

#ifndef NO_WOLFSSL_STUB
void wolfSSL_X509_get0_signature(const WOLFSSL_ASN1_BIT_STRING **psig,
        const WOLFSSL_X509_ALGOR **palg, const WOLFSSL_X509 *x509)
{
    (void)psig;
    (void)palg;
    (void)x509;
    WOLFSSL_STUB("wolfSSL_X509_get0_signature");
}
#endif

#endif /* OPENSSL_EXTRA */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL)
const char* wolfSSL_X509_verify_cert_error_string(long err)
{
    return wolfSSL_ERR_reason_error_string((unsigned long)err);
}
#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL */

#ifdef OPENSSL_EXTRA

/* Add directory path that will be used for loading certs and CRLs
 * which have the <hash>.rn name format.
 * type may be WOLFSSL_FILETYPE_PEM or WOLFSSL_FILETYPE_ASN1.
 * returns WOLFSSL_SUCCESS on successful, otherwise negative or zero. */
int wolfSSL_X509_LOOKUP_add_dir(WOLFSSL_X509_LOOKUP* lookup, const char* dir,
                               long type)
{
    return wolfSSL_X509_LOOKUP_ctrl(lookup, WOLFSSL_X509_L_ADD_DIR, dir, type,
                                    NULL);
}

int wolfSSL_X509_LOOKUP_load_file(WOLFSSL_X509_LOOKUP* lookup,
                                 const char* file, long type)
{
#if !defined(NO_FILESYSTEM) && \
    (defined(WOLFSSL_PEM_TO_DER) || defined(WOLFSSL_DER_TO_PEM))
    int           ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
    XFILE         fp;
    long          sz;
    byte*         pem = NULL;
    byte*         curr = NULL;
    byte*         prev = NULL;
    const char* header = NULL;
    const char* footer = NULL;

    if (type != WOLFSSL_FILETYPE_PEM)
        return WS_RETURN_CODE(BAD_FUNC_ARG, (int)WOLFSSL_FAILURE);

    fp = XFOPEN(file, "rb");
    if (fp == XBADFILE)
        return WS_RETURN_CODE(BAD_FUNC_ARG, (int)WOLFSSL_FAILURE);

    if (XFSEEK(fp, 0, XSEEK_END) != 0) {
        XFCLOSE(fp);
        return WS_RETURN_CODE(WOLFSSL_BAD_FILE,WOLFSSL_FAILURE);
    }
    sz = XFTELL(fp);
    if (XFSEEK(fp, 0, XSEEK_SET) != 0) {
        XFCLOSE(fp);
        return WS_RETURN_CODE(WOLFSSL_BAD_FILE,WOLFSSL_FAILURE);
    }

    if (sz > MAX_WOLFSSL_FILE_SIZE || sz <= 0) {
        WOLFSSL_MSG("X509_LOOKUP_load_file size error");
        goto end;
    }

    pem = (byte*)XMALLOC(sz, 0, DYNAMIC_TYPE_PEM);
    if (pem == NULL) {
        ret = MEMORY_ERROR;
        goto end;
    }

    /* Read in file which may be CRLs or certificates. */
    if (XFREAD(pem, (size_t)sz, 1, fp) != 1)
        goto end;

    prev = curr = pem;
    do {
        /* get PEM header and footer based on type */
        if (wc_PemGetHeaderFooter(CRL_TYPE, &header, &footer) == 0 &&
                XSTRNSTR((char*)curr, header, sz) != NULL) {
#ifdef HAVE_CRL
            WOLFSSL_CERT_MANAGER* cm = lookup->store->cm;

            if (cm->crl == NULL) {
                if (wolfSSL_CertManagerEnableCRL(cm, WOLFSSL_CRL_CHECK)
                    != WOLFSSL_SUCCESS) {
                    WOLFSSL_MSG("Enable CRL failed");
                    goto end;
                }
            }

            ret = BufferLoadCRL(cm->crl, curr, sz, WOLFSSL_FILETYPE_PEM,
                NO_VERIFY);
            if (ret != WOLFSSL_SUCCESS)
                goto end;
#endif
            curr = (byte*)XSTRNSTR((char*)curr, footer, sz);
        }
        else if (wc_PemGetHeaderFooter(CERT_TYPE, &header, &footer) == 0 &&
                XSTRNSTR((char*)curr, header, sz) != NULL) {
            ret = X509StoreLoadCertBuffer(lookup->store, curr,
                                        (word32)sz, WOLFSSL_FILETYPE_PEM);
            if (ret != WOLFSSL_SUCCESS)
                goto end;
            curr = (byte*)XSTRNSTR((char*)curr, footer, sz);
        }
        else
            goto end;

        if (curr == NULL)
            goto end;

        curr++;
        sz -= (long)(curr - prev);
        prev = curr;
    }
    while (ret == WOLFSSL_SUCCESS);

end:
    XFREE(pem, 0, DYNAMIC_TYPE_PEM);
    XFCLOSE(fp);
    return WS_RETURN_CODE(ret, (int)WOLFSSL_FAILURE);
#else
    (void)lookup;
    (void)file;
    (void)type;
    return WS_RETURN_CODE(WOLFSSL_FAILURE,WOLFSSL_FAILURE);
#endif
}

WOLFSSL_X509_LOOKUP_METHOD* wolfSSL_X509_LOOKUP_hash_dir(void)
{
    /* Method implementation in functions. */
    static WOLFSSL_X509_LOOKUP_METHOD meth = { 1 };
    return &meth;
}

WOLFSSL_X509_LOOKUP_METHOD* wolfSSL_X509_LOOKUP_file(void)
{
    /* Method implementation in functions. */
    static WOLFSSL_X509_LOOKUP_METHOD meth = { 0 };
    return &meth;
}

/* set directory path to load certificate or CRL which have the hash.N form */
/* for late use                                                             */
/* @param ctx    a pointer to WOLFSSL_BY_DIR structure                      */
/* @param argc   directory path                                             */
/* @param argl   file type, either WOLFSSL_FILETYPE_PEM or                  */
/*                                          WOLFSSL_FILETYPE_ASN1           */
/* @return WOLFSSL_SUCCESS on successful, otherwise negative or zero        */
/* Note: on failure, path elements parsed before the failing one have       */
/*       already been added to ctx->dir_entry                               */
static int x509AddCertDir(WOLFSSL_BY_DIR *ctx, const char *argc, long argl)
{
#if defined(OPENSSL_ALL) && !defined(NO_FILESYSTEM) && !defined(NO_WOLFSSL_DIR)
    WOLFSSL_BY_DIR_entry *entry;
    size_t pathLen;
    int i, num;
    const char* c;
    WC_DECLARE_VAR(buf, char, MAX_FILENAME_SZ, 0);

    WOLFSSL_ENTER("x509AddCertDir");

    pathLen = 0;
    c = argc;
    /* sanity check, zero length */
    if (ctx == NULL || c == NULL || *c == '\0')
        return WOLFSSL_FAILURE;

#ifdef WOLFSSL_SMALL_STACK
    buf = (char*)XMALLOC(MAX_FILENAME_SZ, NULL, DYNAMIC_TYPE_OPENSSL);
    if (buf == NULL) {
        WOLFSSL_LEAVE("x509AddCertDir", MEMORY_E);
        return MEMORY_E;
    }
#endif

    XMEMSET(buf, 0, MAX_FILENAME_SZ);

    do {
        if (*c == SEPARATOR_CHAR || *c == '\0') {

            num = wolfSSL_sk_BY_DIR_entry_num(ctx->dir_entry);

            for (i=0; i<num; i++) {

                entry = wolfSSL_sk_BY_DIR_entry_value(ctx->dir_entry, i);

                if (XSTRLEN(entry->dir_name) == pathLen &&
                    XSTRNCMP(entry->dir_name, buf, pathLen) == 0) {
                    WOLFSSL_MSG("dir entry found");
                    break;
                }
            }

            if (num == -1 || i == num) {
                WOLFSSL_MSG("no entry found");

                if (ctx->dir_entry == NULL) {
                    ctx->dir_entry = wolfSSL_sk_BY_DIR_entry_new_null();

                    if (ctx->dir_entry == NULL) {
                        WOLFSSL_MSG("failed to allocate dir_entry");
                            WC_FREE_VAR_EX(buf, 0, DYNAMIC_TYPE_OPENSSL);
                        return 0;
                    }
                }

                entry = wolfSSL_BY_DIR_entry_new();
                if (entry == NULL) {
                    WOLFSSL_MSG("failed to allocate dir entry");
                        WC_FREE_VAR_EX(buf, 0, DYNAMIC_TYPE_OPENSSL);
                    return 0;
                }
                entry->dir_type = (int)argl;
                entry->dir_name = (char*)XMALLOC(pathLen + 1/* \0 termination*/
                                                , NULL, DYNAMIC_TYPE_OPENSSL);
                entry->hashes = wolfSSL_sk_BY_DIR_HASH_new_null();
                if (entry->dir_name == NULL || entry->hashes == NULL) {
                    WOLFSSL_MSG("failed to allocate dir name");
                    wolfSSL_BY_DIR_entry_free(entry);
                        WC_FREE_VAR_EX(buf, 0, DYNAMIC_TYPE_OPENSSL);
                    return 0;
                }

                XMEMCPY(entry->dir_name, buf, pathLen);
                entry->dir_name[pathLen] = '\0';

                if (wolfSSL_sk_BY_DIR_entry_push(ctx->dir_entry, entry) <= 0) {
                    wolfSSL_BY_DIR_entry_free(entry);
                        WC_FREE_VAR_EX(buf, 0, DYNAMIC_TYPE_OPENSSL);
                    return 0;
                }
            }
            /* skip separator */
            if (*c == SEPARATOR_CHAR) c++;

            pathLen = 0;
            XMEMSET(buf, 0, MAX_FILENAME_SZ);
        }
        if (pathLen >= MAX_FILENAME_SZ) {
            WOLFSSL_MSG("dir name too long for internal buffer");
            WC_FREE_VAR_EX(buf, 0, DYNAMIC_TYPE_OPENSSL);
            return 0;
        }
        buf[pathLen++] = *c;

    } while(*c++ != '\0');

    WC_FREE_VAR_EX(buf, 0, DYNAMIC_TYPE_OPENSSL);

    return WOLFSSL_SUCCESS;
#else
    (void)ctx;
    (void)argc;
    (void)argl;
    return WOLFSSL_NOT_IMPLEMENTED;
#endif
}

/* set additional data to X509_LOOKUP                                   */
/* @param ctx    a pointer to X509_LOOKUP structure                     */
/* @param cmd    control command :                                      */
/*               X509_L_FILE_LOAD, X509_L_ADD_DIR X509_L_ADD_STORE or   */
/*               X509_L_LOAD_STORE                                      */
/* @param argc   arguments for the control command                      */
/* @param argl   arguments for the control command                      */
/* @param **ret  return value of the control command                    */
/* @return WOLFSSL_SUCCESS on successful, otherwise WOLFSSL_FAILURE     */
/* note: WOLFSSL_X509_L_ADD_STORE and WOLFSSL_X509_L_LOAD_STORE have not*/
/*       yet implemented. It returns WOLFSSL_NOT_IMPLEMENTED            */
/*       when those control commands are passed.                        */
/* Note: on failure, path elements parsed before the failing one have   */
/*       already been added to ctx->dir_entry                           */
int wolfSSL_X509_LOOKUP_ctrl(WOLFSSL_X509_LOOKUP *ctx, int cmd,
        const char *argc, long argl, char **ret)
{
    int lret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);

    WOLFSSL_ENTER("wolfSSL_X509_LOOKUP_ctrl");
#if !defined(NO_FILESYSTEM)
    if (ctx != NULL) {
        switch (cmd) {
        case WOLFSSL_X509_L_FILE_LOAD:
            /* expects to return a number of processed cert or crl file */
            lret = wolfSSL_X509_load_cert_crl_file(ctx, argc, (int)argl) > 0 ?
                            WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
            break;
        case WOLFSSL_X509_L_ADD_DIR:
            /* store directory location to use it later */
#if !defined(NO_WOLFSSL_DIR)
            lret = x509AddCertDir(ctx->dirs, argc, argl);
#else
            (void)x509AddCertDir;
            lret = WOLFSSL_NOT_IMPLEMENTED;
#endif
            break;
        case WOLFSSL_X509_L_ADD_STORE:
        case WOLFSSL_X509_L_LOAD_STORE:
            return WOLFSSL_NOT_IMPLEMENTED;

        default:
            break;
        }
    }
    (void)ret;
#else
    (void)ctx;
    (void)argc;
    (void)argl;
    (void)ret;
    (void)cmd;
    (void)x509AddCertDir;
    lret = WOLFSSL_NOT_IMPLEMENTED;
#endif
    return lret;
}


#if defined(WOLFSSL_CERT_GEN)
static int wolfssl_x509_make_der(WOLFSSL_X509* x509, int req,
        unsigned char* der, int* derSz, int includeSig);
#endif

#ifdef WOLFSSL_CERT_GEN
#ifndef NO_BIO
/* Converts the X509 to DER format and outputs it into bio.
 *
 * bio  is the structure to hold output DER
 * x509 certificate to create DER from
 * req  if set then a CSR is generated
 *
 * returns WOLFSSL_SUCCESS on success
 */
static int loadX509orX509REQFromBio(WOLFSSL_BIO* bio, WOLFSSL_X509* x509,
    int req)
{
    int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
    /* Get large buffer to hold cert der */
    int derSz = X509_BUFFER_SZ;
    WC_DECLARE_VAR(der, byte, X509_BUFFER_SZ, 0);
    WOLFSSL_ENTER("wolfSSL_i2d_X509_bio");

    if (bio == NULL || x509 == NULL) {
        return WOLFSSL_FAILURE;
    }

#ifdef WOLFSSL_SMALL_STACK
    der = (byte*)XMALLOC(derSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
    if (!der) {
        WOLFSSL_MSG("malloc failed");
        return WOLFSSL_FAILURE;
    }
#endif

    if (wolfssl_x509_make_der(x509, req, der, &derSz, 1) != WOLFSSL_SUCCESS) {
        goto cleanup;
    }

    if (wolfSSL_BIO_write(bio, der, derSz) != derSz) {
        goto cleanup;
    }

    ret = WOLFSSL_SUCCESS;
cleanup:
    WC_FREE_VAR_EX(der, NULL, DYNAMIC_TYPE_TMP_BUFFER);

    return ret;
}

/* Converts the X509 to DER format and outputs it into bio.
 *
 * bio  is the structure to hold output DER
 * x509 certificate to create DER from
 *
 * returns WOLFSSL_SUCCESS on success
 */
int wolfSSL_i2d_X509_bio(WOLFSSL_BIO* bio, WOLFSSL_X509* x509)
{
    return loadX509orX509REQFromBio(bio, x509, 0);
}

#ifdef WOLFSSL_CERT_REQ
int wolfSSL_i2d_X509_REQ_bio(WOLFSSL_BIO* bio, WOLFSSL_X509* x509)
{
    return loadX509orX509REQFromBio(bio, x509, 1);
}
#endif /* WOLFSSL_CERT_REQ */
#endif /* !NO_BIO */
#endif /* WOLFSSL_CERT_GEN */

/* Converts an internal structure to a DER buffer
 *
 * x509 structure to get DER buffer from
 * out  buffer to hold result. If NULL then *out is NULL then a new buffer is
 *      created.
 *
 * returns the size of the DER result on success
 */
int wolfSSL_i2d_X509(WOLFSSL_X509* x509, unsigned char** out)
{
    const unsigned char* der;
    int derSz = 0;
    int advance = 1;

    WOLFSSL_ENTER("wolfSSL_i2d_X509");

    if (x509 == NULL) {
        WOLFSSL_LEAVE("wolfSSL_i2d_X509", BAD_FUNC_ARG);
        return BAD_FUNC_ARG;
    }

    der = wolfSSL_X509_get_der(x509, &derSz);
    if (der == NULL || derSz <= 0) {
        WOLFSSL_LEAVE("wolfSSL_i2d_X509", MEMORY_E);
        return MEMORY_E;
    }

    if (out != NULL && *out == NULL) {
        *out = (unsigned char*)XMALLOC(derSz, NULL, DYNAMIC_TYPE_OPENSSL);
        if (*out == NULL) {
            WOLFSSL_LEAVE("wolfSSL_i2d_X509", MEMORY_E);
            return MEMORY_E;
        }
        advance = 0;
    }

    if (out != NULL) {
        XMEMCPY(*out, der, derSz);
        if (advance)
            *out += derSz;
    }

    WOLFSSL_LEAVE("wolfSSL_i2d_X509", derSz);
    return derSz;
}

#ifdef WOLFSSL_DUAL_ALG_CERTS
/* Generate a der preTBS from a decoded cert, and write
 * to buffer.
 *
 * @param [in]  cert  The decoded cert to parse.
 * @param [out] der   The der buffer to write in.
 * @param [in]  derSz The der buffer size.
 *
 * @return  preTBS der size on success.
 * */
int wc_GeneratePreTBS(DecodedCert* cert, byte *der, int derSz) {
    int ret = 0;
    WOLFSSL_X509 *x = NULL;
    byte certIsCSR = 0;

    WOLFSSL_ENTER("wc_GeneratePreTBS");

    if ((cert == NULL) || (der == NULL) || (derSz <= 0)) {
        return BAD_FUNC_ARG;
    }

#ifdef WOLFSSL_CERT_REQ
    certIsCSR = cert->isCSR;
#endif

    x = wolfSSL_X509_new();
    if (x == NULL) {
        ret = MEMORY_E;
    }
    else {
        ret = CopyDecodedToX509(x, cert);
    }

    if (ret == 0) {
        /* Remove the altsigval extension. */
        XFREE(x->altSigValDer, x->heap, DYNAMIC_TYPE_X509_EXT);
        x->altSigValDer = NULL;
        x->altSigValLen = 0;
        /* Remove sigOID so it won't be encoded. */
        x->sigOID = 0;
        /* We now have a PreTBS. Encode it. */
        ret = wolfssl_x509_make_der(x, certIsCSR, der, &derSz, 0);
        if (ret == WOLFSSL_SUCCESS) {
            ret = derSz;
        }
    }

    if (x != NULL) {
        wolfSSL_X509_free(x);
        x = NULL;
    }

    return ret;
}
#endif /* WOLFSSL_DUAL_ALG_CERTS */

#ifndef NO_BIO
/**
 * Converts the DER from bio and creates a WOLFSSL_X509 structure from it.
 * @param bio  is the structure holding DER
 * @param x509 certificate to create from DER. Can be NULL
 * @param req  1 for a CSR and 0 for a x509 cert
 * @return pointer to WOLFSSL_X509 structure on success and NULL on fail
 */
static WOLFSSL_X509* d2i_X509orX509REQ_bio(WOLFSSL_BIO* bio,
                                            WOLFSSL_X509** x509, int req)
{
    WOLFSSL_X509* localX509 = NULL;
    byte* mem  = NULL;
    int    size;

    WOLFSSL_ENTER("wolfSSL_d2i_X509_bio");

    if (bio == NULL) {
        WOLFSSL_MSG("Bad Function Argument bio is NULL");
        return NULL;
    }

    size = wolfSSL_BIO_get_len(bio);
    if (size <= 0) {
        WOLFSSL_MSG("wolfSSL_BIO_get_len error. Possibly no pending data.");
        WOLFSSL_ERROR(WOLFSSL_ASN1_R_HEADER_TOO_LONG_E);
        return NULL;
    }

    if (!(mem = (byte*)XMALLOC(size, NULL, DYNAMIC_TYPE_OPENSSL))) {
        WOLFSSL_MSG("malloc error");
        return NULL;
    }

    if ((size = wolfSSL_BIO_read(bio, mem, size)) == 0) {
        WOLFSSL_MSG("wolfSSL_BIO_read error");
        XFREE(mem, NULL, DYNAMIC_TYPE_OPENSSL);
        return NULL;
    }

    if (req) {
#ifdef WOLFSSL_CERT_REQ
        localX509 = wolfSSL_X509_REQ_d2i(NULL, mem, size);
#else
        WOLFSSL_MSG("CSR not compiled in");
#endif
    }
    else {
        localX509 = wolfSSL_X509_d2i_ex(NULL, mem, size, bio->heap);
    }
    if (localX509 == NULL) {
        WOLFSSL_MSG("wolfSSL_X509_d2i error");
        XFREE(mem, NULL, DYNAMIC_TYPE_OPENSSL);
        return NULL;
    }

    if (x509 != NULL) {
        *x509 = localX509;
    }

    XFREE(mem, NULL, DYNAMIC_TYPE_OPENSSL);
    return localX509;
}

WOLFSSL_X509* wolfSSL_d2i_X509_bio(WOLFSSL_BIO* bio, WOLFSSL_X509** x509)
{
    return d2i_X509orX509REQ_bio(bio, x509, 0);
}

#ifdef WOLFSSL_CERT_REQ
WOLFSSL_X509* wolfSSL_d2i_X509_REQ_bio(WOLFSSL_BIO* bio, WOLFSSL_X509** x509)
{
    return d2i_X509orX509REQ_bio(bio, x509, 1);
}
#endif
#endif /* !NO_BIO */

#endif /* OPENSSL_EXTRA */

#ifdef OPENSSL_EXTRA
/* Use the public key to verify the signature. Note: this only verifies
 * the certificate signature.
 * returns WOLFSSL_SUCCESS on successful signature verification */
static int verifyX509orX509REQ(WOLFSSL_X509* x509, WOLFSSL_EVP_PKEY* pkey,
    int req)
{
    int ret;
    const byte* der;
    int derSz = 0;
    int type;
    const byte* pubKey;
    int pubKeySz;
#if defined(HAVE_ED25519) && defined(HAVE_ED25519_KEY_EXPORT)
    byte edPubKey[ED25519_PUB_KEY_SIZE];
    word32 edPubKeySz = (word32)sizeof(edPubKey);
#endif

    (void)req;

    if (x509 == NULL || pkey == NULL) {
        return WOLFSSL_FATAL_ERROR;
    }

    der = wolfSSL_X509_get_der(x509, &derSz);
    if (der == NULL) {
        WOLFSSL_MSG("Error getting WOLFSSL_X509 DER");
        return WOLFSSL_FATAL_ERROR;
    }

    /* Most key types verify against the cached public-key DER. */
    pubKey   = (const byte*)pkey->pkey.ptr;
    pubKeySz = pkey->pkey_sz;

    switch (pkey->type) {
        case WC_EVP_PKEY_RSA:
            type = RSAk;
            break;

        case WC_EVP_PKEY_EC:
            type = ECDSAk;
            break;

        case WC_EVP_PKEY_DSA:
            type = DSAk;
            break;

    #if defined(WOLFSSL_HAVE_MLDSA)
        case WC_EVP_PKEY_DILITHIUM:
            type = WOLFSSL_ATOMIC_LOAD(pkey->mldsaOID);
            if (type == 0) {
                WOLFSSL_MSG("ML-DSA pkey missing key OID");
                return WOLFSSL_FATAL_ERROR;
            }
            break;
    #endif
    #if defined(HAVE_ED25519) && defined(HAVE_ED25519_KEY_EXPORT)
        case WC_EVP_PKEY_ED25519:
            /* The signature check needs the raw public key; for Ed25519
             * pkey->pkey.ptr holds a PKCS#8 private blob (or nothing), so
             * export the public key from the ed25519_key instead. */
            if (pkey->ed25519 == NULL ||
                    wc_ed25519_export_public(pkey->ed25519, edPubKey,
                        &edPubKeySz) != 0) {
                WOLFSSL_MSG("Unable to export Ed25519 public key");
                return WOLFSSL_FATAL_ERROR;
            }
            pubKey   = edPubKey;
            pubKeySz = (int)edPubKeySz;
            type     = ED25519k;
            break;
    #endif

        default:
            WOLFSSL_MSG("Unknown pkey key type");
            return WOLFSSL_FATAL_ERROR;
    }

#ifdef WOLFSSL_CERT_REQ
    if (req)
        ret = CheckCSRSignaturePubKey(der, (word32)derSz, x509->heap,
                (unsigned char*)pubKey, pubKeySz, type);
    else
#endif
        ret = CheckCertSignaturePubKey(der, (word32)derSz, x509->heap,
                (unsigned char*)pubKey, pubKeySz, type);
    if (ret == 0) {
        return WOLFSSL_SUCCESS;
    }
    return WOLFSSL_FAILURE;
}

int wolfSSL_X509_verify(WOLFSSL_X509* x509, WOLFSSL_EVP_PKEY* pkey)
{
    return verifyX509orX509REQ(x509, pkey, 0);
}

#ifdef WOLFSSL_CERT_REQ
int wolfSSL_X509_REQ_verify(WOLFSSL_X509* x509, WOLFSSL_EVP_PKEY* pkey)
{
    return verifyX509orX509REQ(x509, pkey, 1);
}
#endif /* WOLFSSL_CERT_REQ */

#if !defined(NO_FILESYSTEM)
static void *wolfSSL_d2i_X509_fp_ex(XFILE file, void **x509, int type)
{
    void *newx509 = NULL;
    byte *fileBuffer = NULL;
    long sz = 0;

    /* init variable */
    if (x509)
        *x509 = NULL;

    /* argument check */
    if (file == XBADFILE) {
        return NULL;
    }

    /* determine file size */
    if (XFSEEK(file, 0, XSEEK_END) != 0) {
        return NULL;
    }
    sz = XFTELL(file);
    if (XFSEEK(file, 0, XSEEK_SET) != 0) {
        return NULL;
    }

    if (sz > MAX_WOLFSSL_FILE_SIZE || sz <= 0) {
        WOLFSSL_MSG("d2i_X509_fp_ex file size error");
        return NULL;
    }

    fileBuffer = (byte *)XMALLOC(sz, NULL, DYNAMIC_TYPE_FILE);
    if (fileBuffer != NULL) {
        if ((long)XFREAD(fileBuffer, 1, (size_t)sz, file) != sz) {
            WOLFSSL_MSG("File read failed");
            goto err_exit;
        }
        if (type == CERT_TYPE) {
            newx509 = (void *)wolfSSL_X509_d2i(NULL, fileBuffer, (int)sz);
        }
    #ifdef HAVE_CRL
        else if (type == CRL_TYPE) {
            newx509 = (void *)wolfSSL_d2i_X509_CRL(NULL, fileBuffer, (int)sz);
        }
    #endif
    #ifdef WOLFSSL_CERT_REQ
        else if (type == CERTREQ_TYPE) {
             newx509 = (void *)wolfSSL_X509_REQ_d2i(NULL, fileBuffer, (int)sz);
        }
    #endif
    #if !defined(NO_ASN) && !defined(NO_PWDBASED) && defined(HAVE_PKCS12)
        else if (type == PKCS12_TYPE) {
            if ((newx509 = wc_PKCS12_new()) == NULL) {
                goto err_exit;
            }
            if (wc_d2i_PKCS12(fileBuffer, (word32)sz,
                                                     (WC_PKCS12*)newx509) < 0) {
                goto err_exit;
            }
        }
    #endif
        else {
            goto err_exit;
        }
        if (newx509 == NULL) {
            WOLFSSL_MSG("X509 failed");
            goto err_exit;
        }
    }

    if (x509)
        *x509 = newx509;

    goto _exit;

err_exit:
#if !defined(NO_ASN) && !defined(NO_PWDBASED) && defined(HAVE_PKCS12)
    if ((newx509 != NULL) && (type == PKCS12_TYPE)) {
        wc_PKCS12_free((WC_PKCS12*)newx509);
        newx509 = NULL;
    }
#endif
_exit:
    XFREE(fileBuffer, NULL, DYNAMIC_TYPE_FILE);

    return newx509;
}

#ifdef WOLFSSL_CERT_REQ
WOLFSSL_X509* wolfSSL_d2i_X509_REQ_fp(XFILE fp, WOLFSSL_X509 **req)
{
    return (WOLFSSL_X509 *)wolfSSL_d2i_X509_fp_ex(fp, (void **)req,
                                                  CERTREQ_TYPE);
}
#endif /* WOLFSSL_CERT_REQ */

WOLFSSL_X509 *wolfSSL_d2i_X509_fp(XFILE fp, WOLFSSL_X509 **x509)
{
    WOLFSSL_ENTER("wolfSSL_d2i_X509_fp");
    return (WOLFSSL_X509 *)wolfSSL_d2i_X509_fp_ex(fp, (void **)x509, CERT_TYPE);
}

/* load certificate or CRL file, and add it to the STORE           */
/* @param ctx    a pointer to X509_LOOKUP structure                */
/* @param file   file name to load                                 */
/* @param type   WOLFSSL_FILETYPE_PEM or WOLFSSL_FILETYPE_ASN1     */
/* @return a number of loading CRL or certificate, otherwise zero  */
int wolfSSL_X509_load_cert_crl_file(WOLFSSL_X509_LOOKUP *ctx,
    const char *file, int type)
{
    WOLFSSL_X509 *x509 = NULL;

    int cnt = 0;

    WOLFSSL_ENTER("wolfSSL_X509_load_cert_crl_file");

    /* stanity check */
    if (ctx == NULL || file == NULL) {
        WOLFSSL_MSG("bad arguments");
        return 0;
    }

    if (type != WOLFSSL_FILETYPE_PEM) {
        x509 = wolfSSL_X509_load_certificate_file(file, type);
        if (x509 != NULL) {
            if (wolfSSL_X509_STORE_add_cert(ctx->store, x509)
                                    == WOLFSSL_SUCCESS) {
                cnt++;
            }
            else {
                WOLFSSL_MSG("wolfSSL_X509_STORE_add_cert error");
            }
            wolfSSL_X509_free(x509);
            x509 = NULL;
        }
        else {
            WOLFSSL_MSG("wolfSSL_X509_load_certificate_file error");
        }

    }
    else {
#if defined(OPENSSL_ALL)
    #if !defined(NO_BIO)
        STACK_OF(WOLFSSL_X509_INFO) *info;
        WOLFSSL_X509_INFO *info_tmp;
        int i;
        int num = 0;
        WOLFSSL_BIO *bio = wolfSSL_BIO_new_file(file, "rb");
        if (!bio) {
            WOLFSSL_MSG("wolfSSL_BIO_new error");
            return cnt;
        }

        info = wolfSSL_PEM_X509_INFO_read_bio(bio, NULL, NULL, NULL);

        wolfSSL_BIO_free(bio);

        if (!info) {
            WOLFSSL_MSG("wolfSSL_PEM_X509_INFO_read_bio error");
            return cnt;
        }
        num = wolfSSL_sk_X509_INFO_num(info);
        for (i=0; i < num; i++) {
            info_tmp = wolfSSL_sk_X509_INFO_value(info, i);

            if (info_tmp == NULL)
                continue;

            if (info_tmp->x509) {
                if (wolfSSL_X509_STORE_add_cert(ctx->store, info_tmp->x509) ==
                    WOLFSSL_SUCCESS) {
                    cnt ++;
                }
                else {
                    WOLFSSL_MSG("wolfSSL_X509_STORE_add_cert failed");
                }
            }
#ifdef HAVE_CRL
            if (info_tmp->crl) {
                if (wolfSSL_X509_STORE_add_crl(ctx->store, info_tmp->crl) ==
                    WOLFSSL_SUCCESS) {
                    cnt ++;
                }
                else {
                    WOLFSSL_MSG("wolfSSL_X509_STORE_add_crl failed");
                }
            }
#endif
        }
        wolfSSL_sk_X509_INFO_pop_free(info, wolfSSL_X509_INFO_free);
    #elif defined(HAVE_CRL)
        /* Only supports one certificate or CRL in the file. */
        WOLFSSL_X509_CRL* crl = NULL;
        XFILE fp = XFOPEN(file, "rb");
        if (fp == XBADFILE) {
            WOLFSSL_MSG("XFOPEN error");
            return cnt;
        }

        x509 = wolfSSL_PEM_read_X509(fp, NULL, NULL, NULL);
        if (x509 != NULL) {
            if (wolfSSL_X509_STORE_add_cert(ctx->store, x509) ==
                WOLFSSL_SUCCESS) {
                cnt++;
            }
            else {
                WOLFSSL_MSG("wolfSSL_X509_STORE_add_cert failed");
            }
        }
        else {
            if (XFSEEK(fp, 0, XSEEK_SET) != 0) {
                WOLFSSL_MSG("XFSEEK error");
                return cnt;
            }
            crl = wolfSSL_PEM_read_X509_CRL(fp, NULL, NULL, NULL);
            if (crl != NULL) {
                if (wolfSSL_X509_STORE_add_crl(ctx->store, crl) ==
                    WOLFSSL_SUCCESS) {
                    cnt++;
                }
                else {
                    WOLFSSL_MSG("wolfSSL_X509_STORE_add_crl failed");
                }
            }
            else {
                WOLFSSL_MSG("Certificate and CRL not recognized");
                return cnt;
            }
        }

        wolfSSL_X509_free(x509);
        wolfSSL_X509_CRL_free(crl);
    #endif
#else
    (void)cnt;
#endif /* OPENSSL_ALL && !NO_BIO */
    }

    WOLFSSL_LEAVE("wolfSSL_X509_load_ceretificate_crl_file", cnt);
    return cnt;
}
#endif /* !NO_FILESYSTEM */


#ifdef HAVE_CRL

#ifndef NO_BIO
WOLFSSL_X509_CRL *wolfSSL_d2i_X509_CRL_bio(WOLFSSL_BIO *bp,
                                                    WOLFSSL_X509_CRL **x)
{
    int derSz;
    byte* der = NULL;
    WOLFSSL_X509_CRL* crl = NULL;

    if (bp == NULL)
        return NULL;

    if ((derSz = wolfSSL_BIO_get_len(bp)) > 0) {
        der = (byte*)XMALLOC(derSz, 0, DYNAMIC_TYPE_DER);
        if (der != NULL) {
            if (wolfSSL_BIO_read(bp, der, derSz) == derSz) {
                crl = wolfSSL_d2i_X509_CRL(x, der, derSz);
            }
        }
    }

    XFREE(der, 0, DYNAMIC_TYPE_DER);

    return crl;
}
#endif

#if !defined(NO_FILESYSTEM) && !defined(NO_STDIO_FILESYSTEM)
WOLFSSL_X509_CRL *wolfSSL_d2i_X509_CRL_fp(XFILE fp, WOLFSSL_X509_CRL **crl)
{
    WOLFSSL_ENTER("wolfSSL_d2i_X509_CRL_fp");
    return (WOLFSSL_X509_CRL *)wolfSSL_d2i_X509_fp_ex(fp, (void **)crl,
        CRL_TYPE);
}

/* Read CRL file, and add it to store and corresponding cert manager     */
/* @param ctx   a pointer of X509_LOOKUP back to the X509_STORE          */
/* @param file  a file to read                                           */
/* @param type  WOLFSSL_FILETYPE_PEM or WOLFSSL_FILETYPE_ASN1            */
/* @return WOLFSSL_SUCCESS(1) on successful, otherwise WOLFSSL_FAILURE(0)*/
int wolfSSL_X509_load_crl_file(WOLFSSL_X509_LOOKUP *ctx,
                                             const char *file, int type)
{
#ifndef NO_BIO
    int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
    int count = 0;
    WOLFSSL_BIO *bio = NULL;
    WOLFSSL_X509_CRL *crl = NULL;

    WOLFSSL_ENTER("wolfSSL_X509_load_crl_file");

    if (ctx == NULL || file == NULL)
        return ret;

    if ((bio = wolfSSL_BIO_new(wolfSSL_BIO_s_file())) == NULL)
        return ret;

    if (wolfSSL_BIO_read_filename(bio, file) <= 0) {
        wolfSSL_BIO_free(bio);
        return ret;
    }

    if (wolfSSL_BIO_read_filename(bio, file) <= 0) {
        wolfSSL_BIO_free(bio);
        return ret;
    }

    if (type == WOLFSSL_FILETYPE_PEM) {
        do {
            crl = wolfSSL_PEM_read_bio_X509_CRL(bio, NULL, NULL, NULL);
            if (crl == NULL) {
                if (count <= 0) {
                    WOLFSSL_MSG("Load crl failed");
                }
                break;
            }

            ret = wolfSSL_X509_STORE_add_crl(ctx->store, crl);
            if (ret == WC_NO_ERR_TRACE(WOLFSSL_FAILURE)) {
                WOLFSSL_MSG("Adding crl failed");
                break;
            }
            count++;
            wolfSSL_X509_CRL_free(crl);
            crl = NULL;
        }   while(crl == NULL);

        ret = count;
    }
    else if (type == WOLFSSL_FILETYPE_ASN1) {
        crl = wolfSSL_d2i_X509_CRL_bio(bio, NULL);
        if (crl == NULL) {
            WOLFSSL_MSG("Load crl failed");
        }
        else {
            ret = wolfSSL_X509_STORE_add_crl(ctx->store, crl);
            if (ret == WC_NO_ERR_TRACE(WOLFSSL_FAILURE)) {
                WOLFSSL_MSG("Adding crl failed");
            }
            else {
                ret = 1;/* handled a file */
            }
        }
    }
    else {
        WOLFSSL_MSG("Invalid file type");
    }

    wolfSSL_X509_CRL_free(crl);
    wolfSSL_BIO_free(bio);

    WOLFSSL_LEAVE("wolfSSL_X509_load_crl_file", ret);
    return ret;
#else
    int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
    int count = 0;
    XFILE fp;
    WOLFSSL_X509_CRL *crl = NULL;

    WOLFSSL_ENTER("wolfSSL_X509_load_crl_file");

    if (ctx == NULL || file == NULL)
        return ret;

    if ((fp = XFOPEN(file, "rb")) == XBADFILE)
        return ret;

    if (type == WOLFSSL_FILETYPE_PEM) {
        do {
            crl = wolfSSL_PEM_read_X509_CRL(fp, NULL, NULL, NULL);
            if (crl == NULL) {
                if (count <= 0) {
                    WOLFSSL_MSG("Load crl failed");
                }
                break;
            }

            ret = wolfSSL_X509_STORE_add_crl(ctx->store, crl);
            if (ret == WC_NO_ERR_TRACE(WOLFSSL_FAILURE)) {
                WOLFSSL_MSG("Adding crl failed");
                break;
            }
            count++;
            wolfSSL_X509_CRL_free(crl);
            crl = NULL;
        }
        while(crl == NULL);

        ret = count;
    }
    else if (type == WOLFSSL_FILETYPE_ASN1) {
        crl = wolfSSL_d2i_X509_CRL_fp(fp, NULL);
        if (crl == NULL) {
            WOLFSSL_MSG("Load crl failed");
        }
        else {
            ret = wolfSSL_X509_STORE_add_crl(ctx->store, crl);
            if (ret == WC_NO_ERR_TRACE(WOLFSSL_FAILURE)) {
                WOLFSSL_MSG("Adding crl failed");
            }
            else {
                ret = 1;/* handled a file */
            }
        }
    }
    else {
        WOLFSSL_MSG("Invalid file type");
    }

    wolfSSL_X509_CRL_free(crl);
    XFCLOSE(fp);

    WOLFSSL_LEAVE("wolfSSL_X509_load_crl_file", ret);
    return ret;
#endif /* !NO_BIO */
}
#endif /* !NO_FILESYSTEM */


WOLFSSL_X509_CRL* wolfSSL_d2i_X509_CRL(WOLFSSL_X509_CRL** crl,
        const unsigned char* in, int len)
{
    WOLFSSL_X509_CRL *newcrl = NULL;
    int ret = WOLFSSL_SUCCESS;

    WOLFSSL_ENTER("wolfSSL_d2i_X509_CRL");

    if (in == NULL) {
        WOLFSSL_MSG("Bad argument value");
    }
    else {
        newcrl =(WOLFSSL_X509_CRL*)XMALLOC(sizeof(WOLFSSL_X509_CRL), NULL,
                DYNAMIC_TYPE_CRL);
        if (newcrl == NULL) {
            WOLFSSL_MSG("New CRL allocation failed");
        }
        else {
            ret = InitCRL(newcrl, NULL);
            if (ret < 0) {
                WOLFSSL_MSG("Init tmp CRL failed");
                /* A failed InitCRL() has already released whatever it took,
                 * so dispose of the memory here and keep this object away
                 * from the wolfSSL_X509_CRL_free() below, which would destroy
                 * the lock and the condition variable a second time. */
                XFREE(newcrl, NULL, DYNAMIC_TYPE_CRL);
                newcrl = NULL;
            }
            else {
                ret = BufferLoadCRL(newcrl, in, len, WOLFSSL_FILETYPE_ASN1,
                    NO_VERIFY);
                if (ret != WOLFSSL_SUCCESS) {
                    WOLFSSL_MSG("Buffer Load CRL failed");
                }
                else {
                    if (crl) {
                        *crl = newcrl;
                    }
                }
            }
        }
    }

    if ((ret != WOLFSSL_SUCCESS) && (newcrl != NULL)) {
        wolfSSL_X509_CRL_free(newcrl);
        newcrl = NULL;
    }

    return newcrl;
}

/* Retrieve issuer X509_NAME from CRL
 * return X509_NAME*  on success
 * return NULL on failure
 */
WOLFSSL_X509_NAME* wolfSSL_X509_CRL_get_issuer_name(const WOLFSSL_X509_CRL* crl)
{
    if (crl == NULL || crl->crlList == NULL)
        return NULL;

    return crl->crlList->issuer;
}

/* Set issuer name of CRL
 * return WOLFSSL_SUCCESS on success
 * return WOLFSSL_FAILURE on failure
 */
int wolfSSL_X509_CRL_set_issuer_name(WOLFSSL_X509_CRL* crl,
                                     const WOLFSSL_X509_NAME* name)
{
    WOLFSSL_X509_NAME* newName;

    if (crl == NULL || crl->crlList == NULL || name == NULL)
        return WOLFSSL_FAILURE;

    newName = wolfSSL_X509_NAME_dup(name);
    if (newName == NULL)
        return WOLFSSL_FAILURE;

    if (crl->crlList->issuer != NULL) {
        FreeX509Name(crl->crlList->issuer);
        XFREE(crl->crlList->issuer, crl->heap, DYNAMIC_TYPE_X509);
    }
    crl->crlList->issuer = newName;

    return WOLFSSL_SUCCESS;
}

/* Retrieve version from CRL
 * return version on success
 * return 0 on failure
 */
int wolfSSL_X509_CRL_version(WOLFSSL_X509_CRL* crl)
{
    if (crl == NULL || crl->crlList == NULL)
        return 0;

    return crl->crlList->version;
}

/* Set version of CRL
 * Caller passes the RFC 5280 value: 0 for v1, 1 for v2.
 * Internally wolfSSL stores version + 1 (v1 = 1, v2 = 2) to match
 * what ParseCRL produces, so apply the same normalization here.
 * return WOLFSSL_SUCCESS on success
 * return WOLFSSL_FAILURE on failure
 */
int wolfSSL_X509_CRL_set_version(WOLFSSL_X509_CRL* crl, long version)
{
    if (crl == NULL || crl->crlList == NULL)
        return WOLFSSL_FAILURE;

    /* Only v1 (0) and v2 (1) are defined by RFC 5280. */
    if (version < 0 || version > 1)
        return WOLFSSL_FAILURE;

    /* Store as version + 1 to match internal convention. */
    crl->crlList->version = (int)version + 1;
    return WOLFSSL_SUCCESS;
}

/* Retrieve sig OID from CRL
 * return OID on success
 * return 0 on failure
 */
int wolfSSL_X509_CRL_get_signature_type(WOLFSSL_X509_CRL* crl)
{
    if (crl == NULL || crl->crlList == NULL)
        return 0;

    return crl->crlList->signatureOID;
}

/* Set signature type of CRL
 * return WOLFSSL_SUCCESS on success
 * return WOLFSSL_FAILURE on failure
 */
int wolfSSL_X509_CRL_set_signature_type(WOLFSSL_X509_CRL* crl,
                                        int signatureType)
{
    if (crl == NULL || crl->crlList == NULL)
        return WOLFSSL_FAILURE;

    crl->crlList->signatureOID = signatureType;
    return WOLFSSL_SUCCESS;
}

/* Retrieve sig NID from CRL
 * return NID on success
 * return 0 on failure
 */
int wolfSSL_X509_CRL_get_signature_nid(const WOLFSSL_X509_CRL* crl)
{
    if (crl == NULL || crl->crlList == NULL)
        return 0;

    return oid2nid(crl->crlList->signatureOID, oidSigType);
}

/* Set signature NID of CRL
 * return WOLFSSL_SUCCESS on success
 * return negative value on failure
 */
int wolfSSL_X509_CRL_set_signature_nid(WOLFSSL_X509_CRL* crl, int nid)
{
    int ret = WOLFSSL_SUCCESS;
    word32 oid;

    if (crl == NULL || crl->crlList == NULL || nid <= 0) {
        ret = BAD_FUNC_ARG;
    }

    if (ret == WOLFSSL_SUCCESS) {
        oid = nid2oid(nid, oidSigType);
        if (oid == (word32)-1 || oid == (word32)WOLFSSL_FATAL_ERROR) {
            ret = WOLFSSL_FATAL_ERROR;
        }
        else {
            crl->crlList->signatureOID = oid;
        }
    }

    return ret;
}

/* Retrieve signature from CRL
 * return WOLFSSL_SUCCESS on success and negative values on failure
 */
int wolfSSL_X509_CRL_get_signature(WOLFSSL_X509_CRL* crl,
    unsigned char* buf, int* bufSz)
{
    WOLFSSL_ENTER("wolfSSL_X509_CRL_get_signature");

    if (crl == NULL || crl->crlList == NULL ||
        crl->crlList->signature == NULL || bufSz == NULL)
        return BAD_FUNC_ARG;

    if (buf != NULL) {
        if (*bufSz < (int)crl->crlList->signatureSz) {
            WOLFSSL_MSG("Signature buffer too small");
            return BUFFER_E;
        }
        else {
            XMEMCPY(buf, crl->crlList->signature, crl->crlList->signatureSz);
        }
    }
    *bufSz = (int)crl->crlList->signatureSz;

    return WOLFSSL_SUCCESS;
}

int wolfSSL_X509_CRL_set_signature(WOLFSSL_X509_CRL* crl,
    unsigned char* buf, int bufSz)
{
    byte* newSig;

    if (crl == NULL || crl->crlList == NULL || buf == NULL || bufSz <= 0) {
        return BAD_FUNC_ARG;
    }

    /* Ensure signature buffer is allocated and large enough. */
    if (crl->crlList->signature == NULL) {
        crl->crlList->signature = (byte*)XMALLOC((word32)bufSz, crl->heap,
                                                 DYNAMIC_TYPE_CRL_ENTRY);
        if (crl->crlList->signature == NULL) {
            return MEMORY_E;
        }
        crl->crlList->signatureSz = (word32)bufSz;
    }
    else if ((word32)bufSz > crl->crlList->signatureSz) {
        newSig = (byte*)XMALLOC((word32)bufSz, crl->heap,
                                DYNAMIC_TYPE_CRL_ENTRY);
        if (newSig == NULL) {
            return MEMORY_E;
        }
        XFREE(crl->crlList->signature, crl->heap, DYNAMIC_TYPE_CRL_ENTRY);
        crl->crlList->signature = newSig;
        crl->crlList->signatureSz = (word32)bufSz;
    }
    else {
        /* Reuse existing buffer, clear contents in case new signature
         * is smaller. Note that we do not shrink the buffer. */
        XMEMSET(crl->crlList->signature, 0, crl->crlList->signatureSz);
    }

    XMEMCPY(crl->crlList->signature, buf, bufSz);
    crl->crlList->signatureSz = (word32)bufSz;
    return WOLFSSL_SUCCESS;
}

/* Retrieve serial number from RevokedCert
 * return WOLFSSL_SUCCESS on success and negative values on failure
 */
int wolfSSL_X509_REVOKED_get_serial_number(RevokedCert* rev,
    byte* in, int* inOutSz)
{
    WOLFSSL_ENTER("wolfSSL_X509_REVOKED_get_serial_number");
    if (rev == NULL || inOutSz == NULL) {
        return BAD_FUNC_ARG;
    }

    if (in != NULL) {
        if (*inOutSz < rev->serialSz) {
            WOLFSSL_MSG("Serial buffer too small");
            return BUFFER_E;
        }
        XMEMCPY(in, rev->serialNumber, rev->serialSz);
    }
    *inOutSz = rev->serialSz;

    return WOLFSSL_SUCCESS;
}

const WOLFSSL_ASN1_INTEGER* wolfSSL_X509_REVOKED_get0_serial_number(const
                                                      WOLFSSL_X509_REVOKED *rev)
{
    WOLFSSL_ENTER("wolfSSL_X509_REVOKED_get0_serial_number");

    if (rev != NULL) {
        return rev->serialNumber;
    }
    else
        return NULL;
}

const WOLFSSL_ASN1_TIME* wolfSSL_X509_REVOKED_get0_revocation_date(const
                                                      WOLFSSL_X509_REVOKED *rev)
{
    WOLFSSL_ENTER("wolfSSL_X509_REVOKED_get0_revocation_date");

    if (rev != NULL) {
        return rev->revocationDate;
    }
    return NULL;
}


#ifndef NO_BIO
/* print serial number out
*  return WOLFSSL_SUCCESS on success
*/
static int X509RevokedPrintSerial(WOLFSSL_BIO* bio, RevokedCert* rev,
    int indent)
{
    unsigned char serial[32];
    int  sz = sizeof(serial);

    if (indent < 0) indent = 0;
    if (indent > MAX_INDENT) indent = MAX_INDENT;

    XMEMSET(serial, 0, sz);
    if (wolfSSL_X509_REVOKED_get_serial_number(rev, serial, &sz)
            == WOLFSSL_SUCCESS) {
        X509PrintSerial_ex(bio, serial, sz, 0, indent);
    }
    return WOLFSSL_SUCCESS;
}


/* print out the signature in human readable format for use with
* wolfSSL_X509_CRL_print()
 * return WOLFSSL_SUCCESS on success
 */
static int X509CRLPrintSignature(WOLFSSL_BIO* bio, WOLFSSL_X509_CRL* crl,
        int algOnly, int indent)
{
    int sigSz = 0;

    if (wolfSSL_X509_CRL_get_signature(crl, NULL, &sigSz) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (sigSz > 0) {
        unsigned char* sig;
        int sigNid = wolfSSL_X509_CRL_get_signature_nid(crl);

        sig = (unsigned char*)XMALLOC(sigSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        if (sig == NULL) {
            return WOLFSSL_FAILURE;
        }

        if (wolfSSL_X509_CRL_get_signature(crl, sig, &sigSz) <= 0) {
            XFREE(sig, NULL, DYNAMIC_TYPE_TMP_BUFFER);
            return WOLFSSL_FAILURE;
        }

        if (X509PrintSignature_ex(bio, sig, sigSz, sigNid, algOnly, indent)
                != WOLFSSL_SUCCESS) {
            XFREE(sig, NULL, DYNAMIC_TYPE_TMP_BUFFER);
            return WOLFSSL_FAILURE;
        }

        XFREE(sig, NULL, DYNAMIC_TYPE_TMP_BUFFER);

    }

    return WOLFSSL_SUCCESS;
}
#endif /* !NO_BIO */

#if !defined(NO_BIO) && defined(XSNPRINTF)
/* print out the extensions in human readable format for use with
 * wolfSSL_X509_CRL_print()
 * return WOLFSSL_SUCCESS on success
 */
static int X509CRLPrintExtensions(WOLFSSL_BIO* bio, WOLFSSL_X509_CRL* crl,
        int indent)
{
    char tmp[MAX_WIDTH]; /* buffer for XSNPRINTF */
    int  ret = 0;

    if (indent < 0) indent = 0;
    if (indent > MAX_INDENT) indent = MAX_INDENT;

    if (XSNPRINTF(tmp, MAX_WIDTH, "%*s%s\n", indent, "",
                "CRL extensions:") >= MAX_WIDTH) {
        ret = WOLFSSL_FAILURE;
    }

    if (ret == 0 && wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
        ret = WOLFSSL_FAILURE;
    }

    if (ret == 0 && crl->crlList->crlNumberSet) {
        char dec_string[49]; /* 20 octets can express numbers up to approx
                                49 decimal digits */
        int freeMp = 0;
    #ifdef WOLFSSL_SMALL_STACK
        mp_int* dec_num = (mp_int*)XMALLOC(sizeof(*dec_num), NULL,
                            DYNAMIC_TYPE_BIGINT);
        if (dec_num == NULL) {
            ret = MEMORY_E;
        }
    #else
        mp_int dec_num[1];
    #endif

        if (ret == 0 && (mp_init(dec_num) != MP_OKAY)) {
             ret = MP_INIT_E;
        }
        else if (ret == 0) {
            freeMp = 1;
        }

        if (ret == 0 && mp_read_radix(dec_num, (char *)crl->crlList->crlNumber,
                    MP_RADIX_HEX) != MP_OKAY) {
            ret = WOLFSSL_FAILURE;
        }

        if (ret == 0 && mp_toradix(dec_num, dec_string, MP_RADIX_DEC)
                    != MP_OKAY) {
            ret = WOLFSSL_FAILURE;
        }

        if (ret == 0 && XSNPRINTF(tmp, MAX_WIDTH, "%*s%s\n", indent + 4, "",
                    "X509v3 CRL Number:") >= MAX_WIDTH) {
            ret = WOLFSSL_FAILURE;
        }

        if (ret == 0 && wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
            ret = WOLFSSL_FAILURE;
        }

        if (ret == 0 && XSNPRINTF(tmp, MAX_WIDTH, "%*s%s\n", indent + 8, "",
            dec_string) >= MAX_WIDTH) {
            ret = WOLFSSL_FAILURE;
        }

        if (ret == 0 && wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
            ret = WOLFSSL_FAILURE;
        }

        XMEMSET(tmp, 0, sizeof(tmp));

        if (freeMp) {
            mp_free(dec_num);
        }

        WC_FREE_VAR_EX(dec_num, NULL, DYNAMIC_TYPE_BIGINT);
    }

#if !defined(NO_SKID)
    if (ret == 0 && crl->crlList->extAuthKeyIdSet &&
            crl->crlList->extAuthKeyId[0] != 0) {
        word32 i;
        char val[5];
        int valSz = 5;

        if (XSNPRINTF(tmp, MAX_WIDTH, "%*s%s", indent + 4, "",
                    "X509v3 Authority Key Identifier:") >= MAX_WIDTH) {
            ret = WOLFSSL_FAILURE;
        }

        if (ret == 0) {
            XSTRNCAT(tmp, "\n", MAX_WIDTH - XSTRLEN(tmp) - 1);
        }

        if (ret == 0 && wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
            ret = WOLFSSL_FAILURE;
        }
        XMEMSET(tmp, 0, MAX_WIDTH);

        if (ret == 0 && XSNPRINTF(tmp, MAX_WIDTH - 1, "%*s%s",
                    indent + 8, "", "keyid") >= MAX_WIDTH) {
            ret = WOLFSSL_FAILURE;
        }


        for (i = 0; i < XSTRLEN((char*)crl->crlList->extAuthKeyId); i++) {
            /* check if buffer is almost full */
            if (ret == 0 && XSTRLEN(tmp) >= sizeof(tmp) - valSz) {
                if (wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
                    ret = WOLFSSL_FAILURE;
                }
                tmp[0] = '\0';
            }
            if (ret == 0 && XSNPRINTF(val, (size_t)valSz, ":%02X",
                    crl->crlList->extAuthKeyId[i]) >= valSz) {
                WOLFSSL_MSG("buffer overrun");
                ret = WOLFSSL_FAILURE;
            }
            if (ret == 0) {
                XSTRNCAT(tmp, val, valSz);
            }
        }
        if (ret == 0) {
            XSTRNCAT(tmp, "\n", XSTRLEN("\n") + 1);
        }
        if (ret == 0 && wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
            ret = WOLFSSL_FAILURE;
        }
    }
#endif

    if (ret == 0) {
        ret = WOLFSSL_SUCCESS;
    }

    return ret;
}

/* iterate through a CRL's Revoked Certs and print out in human
 * readable format for use with wolfSSL_X509_CRL_print()
 * return WOLFSSL_SUCCESS on success
 */
static int X509CRLPrintRevoked(WOLFSSL_BIO* bio, WOLFSSL_X509_CRL* crl,
        int indent)
{
    char tmp[MAX_WIDTH]; /* buffer for XSNPRINTF */
    int i;

    if (crl->crlList->totalCerts > 0) {
        RevokedCert* revoked = crl->crlList->certs;

        if (XSNPRINTF(tmp, MAX_WIDTH, "%*s%s\n", indent, "",
                    "Revoked Certificates:") >= MAX_WIDTH) {
            return WOLFSSL_FAILURE;
        }

        if (wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
            return WOLFSSL_FAILURE;
        }
        XMEMSET(tmp, 0, MAX_WIDTH);

        for (i = 0; i < crl->crlList->totalCerts; i++) {
            if (revoked->serialSz > 0) {
                if (X509RevokedPrintSerial(bio, revoked, indent + 4)
                        != WOLFSSL_SUCCESS) {
                    return WOLFSSL_FAILURE;
                }
            }
        #ifndef NO_ASN_TIME
             if (XSNPRINTF(tmp, MAX_WIDTH, "%*s%s", indent + 8, "",
                         "Revocation Date: ") >= MAX_WIDTH) {
                return WOLFSSL_FAILURE;
            }

            if (wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
                return WOLFSSL_FAILURE;
            }

            if (revoked->revDate[0] != 0) {
                if (GetTimeString(revoked->revDate, ASN_UTC_TIME,
                    tmp, MAX_WIDTH, MAX_DATE_SIZE) != WOLFSSL_SUCCESS) {
                    if (GetTimeString(revoked->revDate, ASN_GENERALIZED_TIME,
                    tmp, MAX_WIDTH, MAX_DATE_SIZE) != WOLFSSL_SUCCESS) {
                        WOLFSSL_MSG("Error getting revocation date");
                        return WOLFSSL_FAILURE;
                    }
                }
            }
            else {
                XSTRNCPY(tmp, "Not Set", MAX_WIDTH-1);
            }
            tmp[MAX_WIDTH - 1] = '\0'; /* make sure null terminated */
            if (wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
                return WOLFSSL_FAILURE;
            }

            if (wolfSSL_BIO_write(bio, "\n", (int)XSTRLEN("\n")) <= 0) {
                return WOLFSSL_FAILURE;
            }
        #endif
            revoked = revoked->next;
        }
    }
    else {
        if (wolfSSL_BIO_write(bio, "No Revoked Certificates.\n",
                       (int)XSTRLEN("No Revoked Certificates.\n")) <= 0) {
            return WOLFSSL_FAILURE;
        }
    }

    return WOLFSSL_SUCCESS;
}

#ifndef NO_ASN_TIME
/* print out the last/next update times in human readable
 * format for use with wolfSSL_X509_CRL_print()
 * return WOLFSSL_SUCCESS on success
 */
static int X509CRLPrintDates(WOLFSSL_BIO* bio, WOLFSSL_X509_CRL* crl,
        int indent)
{
    char tmp[MAX_WIDTH]; /* buffer for XSNPRINTF */

    if (XSNPRINTF(tmp, MAX_WIDTH, "%*s%s", indent, "",
                "Last Update: ") >= MAX_WIDTH) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (crl->crlList->lastDate[0] != 0) {
        if (GetTimeString(crl->crlList->lastDate, crl->crlList->lastDateFormat,
            tmp, MAX_WIDTH, MAX_DATE_SIZE) != WOLFSSL_SUCCESS) {
            WOLFSSL_MSG("Error getting last update date");
            return WOLFSSL_FAILURE;
        }
    }
    else {
        XSTRNCPY(tmp, "Not Set", sizeof(tmp)-1);
    }
    tmp[sizeof(tmp) - 1] = '\0'; /* make sure null terminated */
    if (wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, "\n", (int)XSTRLEN("\n")) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (XSNPRINTF(tmp, MAX_WIDTH, "%*s%s", indent, "",
                "Next Update: ") >= MAX_WIDTH) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (crl->crlList->nextDate[0] != 0) {
        if (GetTimeString(crl->crlList->nextDate, crl->crlList->nextDateFormat,
            tmp, MAX_WIDTH, MAX_DATE_SIZE) != WOLFSSL_SUCCESS) {
            WOLFSSL_MSG("Error getting next update date");
            return WOLFSSL_FAILURE;
        }
    }
    else {
        XSTRNCPY(tmp, "Not Set", sizeof(tmp)-1);
    }
    tmp[sizeof(tmp) - 1] = '\0'; /* make sure null terminated */
    if (wolfSSL_BIO_write(bio, tmp, (int)XSTRLEN(tmp)) <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, "\n", (int)XSTRLEN("\n")) <= 0) {
        return WOLFSSL_FAILURE;
    }

    return WOLFSSL_SUCCESS;
}
#endif

/* Writes the human readable form of x509 to bio.
 *
 * bio  WOLFSSL_BIO to write to.
 * crl Certificate revocation list to write.
 *
 * returns WOLFSSL_SUCCESS on success and WOLFSSL_FAILURE on failure
 */
int wolfSSL_X509_CRL_print(WOLFSSL_BIO* bio, WOLFSSL_X509_CRL* crl)
{
    char issuType[] = "Issuer: ";

    if (bio == NULL || crl == NULL || crl->crlList == NULL) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, "Certificate Revocation List (CRL):\n",
                  (int)XSTRLEN("Certificate Revocation List (CRL):\n")) <= 0) {
            return WOLFSSL_FAILURE;
    }

    /* print version */
    if (X509PrintVersion(bio, wolfSSL_X509_CRL_version(crl), 8)
            != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print signature algo */
    if (X509CRLPrintSignature(bio, crl, 1, 8) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print issuer name */
    if (X509PrintName(bio, wolfSSL_X509_CRL_get_issuer_name(crl), issuType, 8)
            != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

#ifndef NO_ASN_TIME
    /* print last and next update times */
    if (X509CRLPrintDates(bio, crl, 8) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }
#endif

    /* print CRL extensions */
    if (X509CRLPrintExtensions(bio, crl, 8) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    /* print CRL Revoked Certs */
    if (X509CRLPrintRevoked(bio, crl, 0) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    if (X509CRLPrintSignature(bio, crl, 0, 4) != WOLFSSL_SUCCESS) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_BIO_write(bio, "\n\0", (int)XSTRLEN("\n\0")) <= 0) {
        return WOLFSSL_FAILURE;
    }

    return WOLFSSL_SUCCESS;
}
#endif /* !NO_BIO && XSNPRINTF */
#endif /* HAVE_CRL */
#endif /* OPENSSL_EXTRA */

#if defined(HAVE_CRL) && (defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL))
void wolfSSL_X509_CRL_free(WOLFSSL_X509_CRL *crl)
{
    WOLFSSL_ENTER("wolfSSL_X509_CRL_free");

    if (crl)
        FreeCRL(crl, 1);
}
#endif /* HAVE_CRL && (OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL) */

#if defined(HAVE_CRL) && defined(OPENSSL_EXTRA)
WOLFSSL_ASN1_TIME* wolfSSL_X509_CRL_get_lastUpdate(WOLFSSL_X509_CRL* crl)
{
    if ((crl != NULL) && (crl->crlList != NULL) &&
        (crl->crlList->lastDateAsn1.data[0] != 0)) {
        return &crl->crlList->lastDateAsn1;
    }
    return NULL;
}

int wolfSSL_X509_CRL_set_lastUpdate(WOLFSSL_X509_CRL* crl,
                                    const WOLFSSL_ASN1_TIME* time)
{
    if (crl != NULL && crl->crlList != NULL && time != NULL) {
        crl->crlList->lastDateAsn1 = *time;
        return WOLFSSL_SUCCESS;
    }
    return WOLFSSL_FAILURE;
}

WOLFSSL_ASN1_TIME* wolfSSL_X509_CRL_get_nextUpdate(WOLFSSL_X509_CRL* crl)
{
    if ((crl != NULL) && (crl->crlList != NULL) &&
        (crl->crlList->nextDateAsn1.data[0] != 0)) {
        return &crl->crlList->nextDateAsn1;
    }
    return NULL;
}

int wolfSSL_X509_CRL_set_nextUpdate(WOLFSSL_X509_CRL* crl,
                                    const WOLFSSL_ASN1_TIME* time)
{
    if (crl != NULL && crl->crlList != NULL && time != NULL) {
        crl->crlList->nextDateAsn1 = *time;
        return WOLFSSL_SUCCESS;
    }
    return WOLFSSL_FAILURE;
}

#ifndef NO_WOLFSSL_STUB
int wolfSSL_X509_CRL_verify(WOLFSSL_X509_CRL* crl, WOLFSSL_EVP_PKEY* key)
{
    (void)crl;
    (void)key;
    WOLFSSL_STUB("X509_CRL_verify");
    return 0;
}
#endif

/* Encode CRL to DER format in memory.
 *
 * If *out is NULL, allocates memory and returns it via *out.
 * If *out is not NULL, writes DER data starting at *out.
 *
 * @param crl  CRL to encode
 * @param out  Pointer to output buffer pointer
 * @return     Size of DER encoding on success, WOLFSSL_FAILURE on failure
 */
int wolfSSL_i2d_X509_CRL(WOLFSSL_X509_CRL* crl, unsigned char** out)
{
    int ret;
    long derSz = 0;
    byte* der = NULL;
    int alloced = 0;

    WOLFSSL_ENTER("wolfSSL_i2d_X509_CRL");

    if (crl == NULL) {
        return BAD_FUNC_ARG;
    }

    /* Get required size */
    ret = BufferStoreCRL(crl, NULL, &derSz, WOLFSSL_FILETYPE_ASN1);
    if (ret != WOLFSSL_SUCCESS || derSz <= 0) {
        WOLFSSL_MSG("BufferStoreCRL failed to get size");
        return WOLFSSL_FAILURE;
    }

    if (out == NULL) {
        /* Just return size */
        return (int)derSz;
    }

    if (*out == NULL) {
        /* Allocate output buffer */
        der = (byte*)XMALLOC((size_t)derSz, NULL, DYNAMIC_TYPE_OPENSSL);
        if (der == NULL) {
            WOLFSSL_MSG("Memory allocation failed");
            return MEMORY_E;
        }
        alloced = 1;
    }
    else {
        der = *out;
    }

    /* Encode CRL to DER */
    ret = BufferStoreCRL(crl, der, &derSz, WOLFSSL_FILETYPE_ASN1);
    if (ret != WOLFSSL_SUCCESS) {
        WOLFSSL_MSG("BufferStoreCRL failed to encode");
        if (alloced) {
            XFREE(der, NULL, DYNAMIC_TYPE_OPENSSL);
        }
        return WOLFSSL_FAILURE;
    }

    if (alloced) {
        *out = der;
    }
    else {
        *out += derSz;
    }

    return (int)derSz;
}
#endif /* HAVE_CRL && OPENSSL_EXTRA */

#if defined(WOLFSSL_CERT_EXT) && \
    (defined(OPENSSL_EXTRA) || defined(OPENSSL_EXTRA_X509_SMALL))
/* Set CRL Distribution Points from pre-encoded DER.
 *
 * x509  - Certificate to modify
 * der   - Pre-encoded CRLDistributionPoints DER
 * derSz - Size of DER in bytes
 *
 * Returns WOLFSSL_SUCCESS or WOLFSSL_FAILURE
 */
int wolfSSL_X509_CRL_set_dist_points(WOLFSSL_X509* x509,
    const unsigned char* der, int derSz)
{
    WOLFSSL_ENTER("wolfSSL_X509_CRL_set_dist_points");

    if (x509 == NULL || der == NULL || derSz <= 0) {
        return WOLFSSL_FAILURE;
    }

    if (x509->rawCRLInfo != NULL) {
        XFREE(x509->rawCRLInfo, x509->heap, DYNAMIC_TYPE_X509_EXT);
    }
    x509->rawCRLInfo = (byte*)XMALLOC((word32)derSz, x509->heap,
                                       DYNAMIC_TYPE_X509_EXT);
    if (x509->rawCRLInfo == NULL) {
        return WOLFSSL_FAILURE;
    }

    XMEMCPY(x509->rawCRLInfo, der, (word32)derSz);
    x509->rawCRLInfoSz = derSz;
    x509->CRLdistSet = 1;

    return WOLFSSL_SUCCESS;
}

/* Add CRL Distribution Point URI.
 * Encodes URI into proper CRLDistributionPoints DER format.
 *
 * x509     - Certificate to modify
 * uri      - URI string (e.g., "http://crl.example.com/ca.crl")
 * critical - Whether extension is critical
 *
 * Returns WOLFSSL_SUCCESS or WOLFSSL_FAILURE
 */
int wolfSSL_X509_CRL_add_dist_point(WOLFSSL_X509* x509,
    const char* uri, int critical)
{
    word32 uriLen;
    byte* derBuf = NULL;
    word32 derSz;
    word32 idx;
    word32 uriTagLen;    /* [6] tag + length + URI */
    word32 genNamesLen;  /* [0] IMPLICIT GeneralNames wrapper */
    word32 distPtNmLen;  /* [0] EXPLICIT distributionPoint wrapper */
    word32 distPtSeqLen; /* SEQUENCE for DistributionPoint */
    word32 outerSeqLen;  /* SEQUENCE for CRLDistributionPoints */
    int ret = WOLFSSL_SUCCESS;

    WOLFSSL_ENTER("wolfSSL_X509_CRL_add_dist_point");

    if (x509 == NULL || uri == NULL) {
        return WOLFSSL_FAILURE;
    }

    uriLen = (word32)XSTRLEN(uri);
    if (uriLen == 0) {
        WOLFSSL_MSG("URI empty");
        return WOLFSSL_FAILURE;
    }

    /*
     * Encode CRL Distribution Points in DER format:
     * CRLDistributionPoints ::= SEQUENCE OF DistributionPoint
     * DistributionPoint ::= SEQUENCE {
     *     distributionPoint [0] EXPLICIT DistributionPointName OPTIONAL
     * }
     * DistributionPointName ::= CHOICE {
     *     fullName [0] IMPLICIT GeneralNames
     * }
     * GeneralNames ::= SEQUENCE OF GeneralName
     * GeneralName ::= [6] IMPLICIT IA5String (uniformResourceIdentifier)
     */

    /* Calculate sizes from innermost to outermost */
    /* [6] tag (1 byte) + length encoding + URI data */
    uriTagLen = ASN_TAG_SZ + SetLength(uriLen, NULL) + uriLen;
    /* [0] CONSTRUCTED tag (1 byte) + length encoding + uriTagLen */
    genNamesLen = ASN_TAG_SZ + SetLength(uriTagLen, NULL) + uriTagLen;
    /* [0] CONSTRUCTED tag (1 byte) + length encoding + genNamesLen */
    distPtNmLen = ASN_TAG_SZ + SetLength(genNamesLen, NULL) + genNamesLen;
    /* SEQUENCE header + distPtNmLen */
    distPtSeqLen = SetSequence(distPtNmLen, NULL) + distPtNmLen;
    /* Outer SEQUENCE header + distPtSeqLen */
    outerSeqLen = SetSequence(distPtSeqLen, NULL) + distPtSeqLen;

    derSz = outerSeqLen;

    /* Allocate buffer for DER encoding */
    derBuf = (byte*)XMALLOC(derSz, x509->heap, DYNAMIC_TYPE_X509_EXT);
    if (derBuf == NULL) {
        return WOLFSSL_FAILURE;
    }

    /* Build forward using SetSequence/SetHeader/SetLength */
    idx = 0;

    /* SEQUENCE for CRLDistributionPoints (outer) */
    idx += SetSequence(distPtSeqLen, derBuf + idx);

    /* SEQUENCE for DistributionPoint */
    idx += SetSequence(distPtNmLen, derBuf + idx);

    /* [0] EXPLICIT wrapper for distributionPoint */
    derBuf[idx++] = (ASN_CONTEXT_SPECIFIC | ASN_CONSTRUCTED);
    idx += SetLength(genNamesLen, derBuf + idx);

    /* [0] IMPLICIT wrapper for GeneralNames (constructed) */
    derBuf[idx++] = (ASN_CONTEXT_SPECIFIC | ASN_CONSTRUCTED);
    idx += SetLength(uriTagLen, derBuf + idx);

    /* [6] IMPLICIT IA5String tag for URI (context-specific, primitive) */
    derBuf[idx++] = (ASN_CONTEXT_SPECIFIC | 6); /* [6] tag */
    idx += SetLength(uriLen, derBuf + idx);

    /* Copy URI string */
    XMEMCPY(derBuf + idx, uri, uriLen);
    idx += uriLen;

    /* Store the encoded CRL info in x509 */
    {
        ret = wolfSSL_X509_CRL_set_dist_points(x509, derBuf, (int)idx);
        if (ret == WOLFSSL_SUCCESS && critical) {
            x509->CRLdistCrit = 1;
        }
    }

    XFREE(derBuf, x509->heap, DYNAMIC_TYPE_X509_EXT);

    return ret;
}
#endif /* WOLFSSL_CERT_EXT && (OPENSSL_EXTRA || OPENSSL_EXTRA_X509_SMALL) */

#ifdef OPENSSL_EXTRA


WOLFSSL_X509_VERIFY_PARAM* wolfSSL_X509_VERIFY_PARAM_new(void)
{
    WOLFSSL_X509_VERIFY_PARAM *param = NULL;
    param = (WOLFSSL_X509_VERIFY_PARAM*)XMALLOC(
            sizeof(WOLFSSL_X509_VERIFY_PARAM), NULL, DYNAMIC_TYPE_OPENSSL);
    if (param != NULL)
        XMEMSET(param, 0, sizeof(WOLFSSL_X509_VERIFY_PARAM ));

    return(param);
}


void wolfSSL_X509_VERIFY_PARAM_free(WOLFSSL_X509_VERIFY_PARAM *param)
{
    XFREE(param, NULL, DYNAMIC_TYPE_OPENSSL);
}


/* Sets flags by OR'ing with existing value. */
int wolfSSL_X509_VERIFY_PARAM_set_flags(WOLFSSL_X509_VERIFY_PARAM *param,
        unsigned long flags)
{
    int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);

    if (param != NULL) {
        param->flags |= flags;
        ret = WOLFSSL_SUCCESS;
    }

    return ret;
}


int wolfSSL_X509_VERIFY_PARAM_get_flags(WOLFSSL_X509_VERIFY_PARAM *param)
{
    int ret = 0;

    if (param != NULL) {
        ret = (int)param->flags;
    }

    return ret;
}


int wolfSSL_X509_VERIFY_PARAM_clear_flags(WOLFSSL_X509_VERIFY_PARAM *param,
        unsigned long flags)
{
    int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);

    if (param != NULL) {
        param->flags &= ~flags;
        ret = WOLFSSL_SUCCESS;
    }

    return ret;
}

/* note WOLFSSL_X509_VERIFY_PARAM does not record purpose, trust, depth, or
 * auth_level.
 */
static const WOLFSSL_X509_VERIFY_PARAM x509_verify_param_builtins[] = {
    {
     "ssl_client",              /* name */
     0,                         /* check_time */
     0,                         /* inherit_flags */
     0,                         /* flags */
     "",                        /* hostname */
     0,                         /* hostFlags */
     ""                         /* ipasc */
    },
    {
     "ssl_server",              /* name */
     0,                         /* check_time */
     0,                         /* inherit_flags */
     0,                         /* flags */
     "",                        /* hostname */
     0,                         /* hostFlags */
     ""                         /* ipasc */
    }
};

const WOLFSSL_X509_VERIFY_PARAM *wolfSSL_X509_VERIFY_PARAM_lookup(
    const char *name)
{
    const WOLFSSL_X509_VERIFY_PARAM *param = &x509_verify_param_builtins[0],
        *param_end = &x509_verify_param_builtins[
                                         XELEM_CNT(x509_verify_param_builtins)];

    if (name == NULL) {
        return NULL;
    }
    while (param < param_end) {
        if (XSTRCMP(name, param->name) == 0)
            return param;
        ++param;
    }
    return NULL;
}

/* inherits properties of param "to" to param "from"
*
* WOLFSSL_VPARAM_DEFAULT          any values in "src" is copied
*                                 if "src" value is new for "to".
* WOLFSSL_VPARAM_OVERWRITE        all values of "form" are copied to "to"
* WOLFSSL_VPARAM_RESET_FLAGS      the flag values are copied, not Ored
* WOLFSSL_VPARAM_LOCKED           don't copy any values
* WOLFSSL_VPARAM_ONCE             the current inherit_flags is zerroed
*/
int wolfSSL_X509_VERIFY_PARAM_inherit(WOLFSSL_X509_VERIFY_PARAM *to,
                                         const WOLFSSL_X509_VERIFY_PARAM *from)
{
    int ret = WOLFSSL_SUCCESS;
    int isOverWrite = 0;
    int isDefault = 0;
    unsigned int flags;

    /* sanity check */
    if (!to || !from) {
        /* be compatible to openssl return value */
        return WOLFSSL_SUCCESS;
    }
    flags = to->inherit_flags | from->inherit_flags;

    if (flags & WOLFSSL_VPARAM_LOCKED) {
        return WOLFSSL_SUCCESS;
    }

    if (flags & WOLFSSL_VPARAM_ONCE) {
        to->inherit_flags = 0;
    }

    isOverWrite = (flags & WOLFSSL_VPARAM_OVERWRITE);
    isDefault = (flags & WOLFSSL_VPARAM_DEFAULT);

    /* copy check_time if check time is not set */
    if ((to->flags & WOLFSSL_USE_CHECK_TIME) == 0 || isOverWrite) {
           to->check_time = from->check_time;
           to->flags &= ~WOLFSSL_USE_CHECK_TIME;
    }
    /* host name */
    if (isOverWrite ||
        (from->hostName[0] != 0 && (to->hostName[0] == 0 || isDefault))) {
            if (!(ret = wolfSSL_X509_VERIFY_PARAM_set1_host(to, from->hostName,
                (unsigned int)XSTRLEN(from->hostName))))
                return ret;
        to->hostFlags = from->hostFlags;
    }
    /* ip ascii */
    if (isOverWrite ||
        (from->ipasc[0] != 0 && (to->ipasc[0] == 0 || isDefault))) {

            if (!(ret = wolfSSL_X509_VERIFY_PARAM_set1_ip_asc(to, from->ipasc)))
                return ret;
    }

    if (flags & WOLFSSL_VPARAM_RESET_FLAGS)
        to->flags = 0;

    to->flags |= from->flags;

    return ret;
}

/******************************************************************************
* wolfSSL_X509_VERIFY_PARAM_set1_host - sets the DNS hostname to name
* hostnames is cleared if name is NULL or empty.
*
* RETURNS:
*
*/
int wolfSSL_X509_VERIFY_PARAM_set1_host(WOLFSSL_X509_VERIFY_PARAM* pParam,
                                         const char* name,
                                         unsigned int nameSz)
{
    WOLFSSL_ENTER("wolfSSL_X509_VERIFY_PARAM_set1_host");

    if (pParam == NULL)
        return WOLFSSL_FAILURE;

    /* If name is NULL, clear hostname. */
    if (name == NULL) {
        XMEMSET(pParam->hostName, 0, WOLFSSL_HOST_NAME_MAX);
        return WOLFSSL_SUCCESS;
    }

    /* If name is NULL-terminated, namelen can be set to zero. */
    if (nameSz == 0) {
        nameSz = (unsigned int)XSTRLEN(name);
    }

    if (nameSz > 0 && name[nameSz - 1] == '\0')
        nameSz--;

    if (nameSz > WOLFSSL_HOST_NAME_MAX-1) {
        WOLFSSL_MSG("Truncating name");
        nameSz = WOLFSSL_HOST_NAME_MAX-1;
    }

    if (nameSz > 0) {
        XMEMCPY(pParam->hostName, name, nameSz);
        XMEMSET(pParam->hostName + nameSz, 0,
                WOLFSSL_HOST_NAME_MAX - nameSz);
    }

    pParam->hostName[nameSz] = '\0';

    return WOLFSSL_SUCCESS;
}

/* Set VERIFY PARAM from "from" pointer to "to" pointer */
int wolfSSL_X509_VERIFY_PARAM_set1(WOLFSSL_X509_VERIFY_PARAM *to,
                                   const WOLFSSL_X509_VERIFY_PARAM *from)
{
    int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
    unsigned int _inherit_flags;

    if (!to) {
        return ret;
    }
    /* keeps the inherit flags for save */
    _inherit_flags = to->inherit_flags;

    /* Ored DEFAULT inherit flag property to copy "from" contents to "to"
    *  contents
    */
    to->inherit_flags |= WOLFSSL_VPARAM_DEFAULT;

    ret = wolfSSL_X509_VERIFY_PARAM_inherit(to, from);

    /* restore inherit flag */
    to->inherit_flags = _inherit_flags;

    return ret;
}

/* Set the host flag in the X509_VERIFY_PARAM structure */
void wolfSSL_X509_VERIFY_PARAM_set_hostflags(WOLFSSL_X509_VERIFY_PARAM* param,
                                             unsigned int flags)
{
    if (param != NULL) {
        param->hostFlags = flags;
    }
}

/* Sets the expected IP address to ipasc.
 *
 * param is a pointer to the X509_VERIFY_PARAM structure
 * ipasc is a NULL-terminated string with N.N.N.N for IPv4 and
 *       HH:HH ... HH:HH for IPv6. There is no validation performed on the
 *       parameter, and it must be an exact match with the IP in the cert.
 *
 * return 1 for success and 0 for failure*/
int wolfSSL_X509_VERIFY_PARAM_set1_ip_asc(WOLFSSL_X509_VERIFY_PARAM *param,
        const char *ipasc)
{
    int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);

    if (param != NULL) {
        if (ipasc == NULL) {
            param->ipasc[0] = '\0';
        }
        else {
            XSTRLCPY(param->ipasc, ipasc, WOLFSSL_MAX_IPSTR);
            param->ipasc[WOLFSSL_MAX_IPSTR-1] = '\0';
        }
        ret = WOLFSSL_SUCCESS;
    }

    return ret;
}
/* Sets the expected IP address to ip(asc)
 *          by re-constructing IP address in ascii
 * @param  param is a pointer to the X509_VERIFY_PARAM structure
 * @param  ip    in binary format of ip address
 * @param  iplen size of ip, 4 for ipv4, 16 for ipv6
 * @return 1 for success and 0 for failure
 */
int wolfSSL_X509_VERIFY_PARAM_set1_ip(WOLFSSL_X509_VERIFY_PARAM* param,
    const unsigned char* ip, size_t iplen)
{
    int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
#ifndef NO_FILESYSTEM
    char* buf = NULL;
    char* p = NULL;
    word32 val = 0;
    int i;
    const size_t max_ipv6_len = 40;
    byte write_zero = 0;
#endif

    /* sanity check */
    if (param == NULL || (iplen != 0 && iplen != 4 && iplen != 16)) {
        WOLFSSL_MSG("bad function arg");
        return ret;
    }
    if (ip == NULL && iplen != 0) {
        WOLFSSL_MSG("bad function arg");
        return ret;
    }
#ifndef NO_FILESYSTEM
    if (iplen == 4) {
        /* ipv4 www.xxx.yyy.zzz max 15 length + Null termination */
        buf = (char*)XMALLOC(16, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        if (!buf) {
            WOLFSSL_MSG("failed malloc");
            return ret;
        }

        (void)XSNPRINTF(buf, 16, "%d.%d.%d.%d", ip[0], ip[1], ip[2], ip[3]);
        buf[15] = '\0'; /* null terminate */
    }
    else if (iplen == 16) {
        /* ipv6 normal address scheme
        *   y1:y2:y3:y4:y5:y6:y7:y8, len(yx):4, len(y1-y8):32. len(":"):7
        *   Max len is 32 + 7 + 1(Termination) = 40 bytes
        *
        *   ipv6 dual address
        *   Or y1:y2:y3:y4:y:y6:x.x.x.x yx is 4, y1-y6 is 24, ":" is 6
        *   x.x.x.x is 15.
        *   Max len is 24 + 6 + 15 + 1(Termination) = 46 bytes
        *
        *   Expect data in ip[16]
        *   e.g (aaaa):(bbbb):(cccc):....(hhhh)
        *   (aaaa) = (ip[0<<8)|ip[1]
        *   ......
        *   (hhhh) = (ip[14]<<8)|(ip[15])
        *
        *   e.g ::(gggg):(hhhh)
        *   ip[0]-[11] = 0
        *   (gggg) = (ip[12]<<8) |(ip[13])
        *   (hhhh) = (ip[14]<<8) |(ip[15])
        *
        *   Because it is not able to know which ivp6 scheme uses from data to
        *   reconstruct IP address, this function assumes
        *   ivp6 normal address scheme, not dual address scheme,
        *   to re-construct IP address in ascii.
        */
        buf = (char*)XMALLOC(max_ipv6_len, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        if (!buf) {
            WOLFSSL_MSG("failed malloc");
            return ret;
        }
        p = buf;
        for (i = 0; i < 16; i += 2) {
            val = (((word32)(ip[i]<<8)) | (ip[i+1])) & 0xFFFF;
            if (val == 0) {
                if (!write_zero) {
                    *p = ':';
                }
                p++;
                *p = '\0';
                write_zero = 1;
            }
            else {
                if (i != 0) {
                    *p++ = ':';
                }
                (void)XSNPRINTF(p, max_ipv6_len - (size_t)(p - buf), "%x", val);
            }
            /* sanity check */
            if (XSTRLEN(buf) > max_ipv6_len) {
                WOLFSSL_MSG("The target ip address exceeds buffer length(40)");
                XFREE(buf, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                buf = NULL;
                break;
            }
            /* move the pointer to the last */
            /* XSTRLEN includes NULL because of XSPRINTF use */
            p = buf + (XSTRLEN(buf));
        }
        /* termination */
        if (i == 16 && buf) {
            p--;
            if ((*p) == ':') {
                /* when the last character is :, the following segments are zero
                 * Therefore, adding : and null termination */
                p++;
                *p++ = ':';
                *p = '\0';
            }
        }
    }
    else {
        WOLFSSL_MSG("iplen is zero, do nothing");
        return WOLFSSL_SUCCESS;
    }

    if (buf) {
        /* set address to ip asc */
        ret = wolfSSL_X509_VERIFY_PARAM_set1_ip_asc(param, buf);
        XFREE(buf, NULL, DYNAMIC_TYPE_TMP_BUFFER);
    }
#else
    (void)param;
    (void)ip;
    (void)iplen;
#endif

    return ret;
}

#ifndef NO_WOLFSSL_STUB
void wolfSSL_X509_OBJECT_free_contents(WOLFSSL_X509_OBJECT* obj)
{
    (void)obj;
    WOLFSSL_STUB("X509_OBJECT_free_contents");
}
#endif

#ifndef NO_ASN_TIME
int wolfSSL_X509_cmp_current_time(const WOLFSSL_ASN1_TIME* asnTime)
{
    return wolfSSL_X509_cmp_time(asnTime, NULL);
}

/* return WOLFSSL_FATAL_ERROR if asnTime is earlier than or equal to cmpTime,
 * and 1 otherwise
 * return 0 on error
 */
int wolfSSL_X509_cmp_time(const WOLFSSL_ASN1_TIME* asnTime, time_t* cmpTime)
{
    int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
    time_t tmpTime, *pTime = &tmpTime;
    struct tm ts, *tmpTs, *ct;
#if defined(NEED_TMP_TIME)
    /* for use with gmtime_r */
    struct tm tmpTimeStorage;

    tmpTs = &tmpTimeStorage;
#else
    tmpTs = NULL;
#endif
    (void)tmpTs;

    if (asnTime == NULL) {
        return WOLFSSL_FAILURE;
    }

    if (cmpTime == NULL) {
        /* Use current time */
        *pTime = wc_Time(0);
    }
    else {
        pTime = cmpTime;
    }

    if (wolfSSL_ASN1_TIME_to_tm((WOLFSSL_ASN1_TIME*)asnTime, &ts) !=
                                                              WOLFSSL_SUCCESS) {
        WOLFSSL_MSG("Failed to convert WOLFSSL_ASN1_TIME to struct tm.");
        return WOLFSSL_FAILURE;
    }

    /* Convert to time struct*/
    ct = XGMTIME(pTime, tmpTs);

    if (ct == NULL)
        return GETTIME_ERROR;

    /* DateGreaterThan returns 1 for >; 0 for <= */
    ret = DateGreaterThan(&ts, ct) ? 1 : -1;

    return ret;
}
#endif /* !NO_ASN_TIME */

#if (defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL)) && \
    !defined(NO_ASN_TIME) && !defined(USER_TIME) && !defined(TIME_OVERRIDES)
WOLFSSL_ASN1_TIME *wolfSSL_X509_time_adj_ex(WOLFSSL_ASN1_TIME *asnTime,
    int offset_day, long offset_sec, time_t *in_tm)
{
    /* get current time if in_tm is null */
    time_t t = in_tm ? *in_tm : wc_Time(0);
    return wolfSSL_ASN1_TIME_adj(asnTime, t, offset_day, offset_sec);
}

WOLFSSL_ASN1_TIME *wolfSSL_X509_time_adj(WOLFSSL_ASN1_TIME *asnTime,
    long offset_sec, time_t *in_tm)
{
    return wolfSSL_X509_time_adj_ex(asnTime, 0, offset_sec, in_tm);
}

WOLFSSL_ASN1_TIME* wolfSSL_X509_gmtime_adj(WOLFSSL_ASN1_TIME *s, long adj)
{
    return wolfSSL_X509_time_adj(s, adj, NULL);
}
#endif

int wolfSSL_sk_X509_REVOKED_num(WOLFSSL_STACK* sk)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_REVOKED_num");
    if (sk != NULL) {
        return (int)sk->num;
    }
    return 0;
}

/* Free a WOLFSSL_X509_REVOKED and all its owned memory. */
void wolfSSL_X509_REVOKED_free(WOLFSSL_X509_REVOKED* rev)
{
    if (rev == NULL) {
        return;
    }

    wolfSSL_ASN1_INTEGER_free(rev->serialNumber);
    wolfSSL_ASN1_TIME_free(rev->revocationDate);

    if (rev->extensions != NULL) {
        wolfSSL_sk_pop_free(rev->extensions, NULL);
    }
    if (rev->issuer != NULL) {
        wolfSSL_sk_pop_free(rev->issuer, NULL);
    }

    XFREE(rev, NULL, DYNAMIC_TYPE_OPENSSL);
}

#ifdef HAVE_CRL
/* Build a WOLFSSL_X509_REVOKED from an internal RevokedCert.
 * Caller takes ownership of the returned object. */
static WOLFSSL_X509_REVOKED* RevokedCertToRevoked(RevokedCert* rc, int seq)
{
    WOLFSSL_X509_REVOKED* rev;
    WOLFSSL_ASN1_INTEGER* serial;

    if (rc == NULL) {
        return NULL;
    }

    rev = (WOLFSSL_X509_REVOKED*)XMALLOC(sizeof(WOLFSSL_X509_REVOKED), NULL,
                                          DYNAMIC_TYPE_OPENSSL);
    if (rev == NULL) {
        return NULL;
    }
    XMEMSET(rev, 0, sizeof(WOLFSSL_X509_REVOKED));

    /* Serial number */
    serial = wolfSSL_ASN1_INTEGER_new();
    if (serial == NULL) {
        XFREE(rev, NULL, DYNAMIC_TYPE_OPENSSL);
        return NULL;
    }
    if (rc->serialSz > 0 && rc->serialSz <= EXTERNAL_SERIAL_SIZE) {
        serial->data = (unsigned char*)XMALLOC((size_t)rc->serialSz, NULL,
                                               DYNAMIC_TYPE_OPENSSL);
        if (serial->data == NULL) {
            wolfSSL_ASN1_INTEGER_free(serial);
            XFREE(rev, NULL, DYNAMIC_TYPE_OPENSSL);
            return NULL;
        }
        XMEMCPY(serial->data, rc->serialNumber, (size_t)rc->serialSz);
        serial->length = rc->serialSz;
        serial->dataMax = rc->serialSz;
        serial->isDynamic = 1;
    }
    rev->serialNumber = serial;

    /* Revocation date */
    {
        WOLFSSL_ASN1_TIME* revDate = wolfSSL_ASN1_TIME_new();
        if (revDate != NULL) {
            int dateLen = 0;
            /* Determine date length from the format byte */
            if (rc->revDateFormat == ASN_UTC_TIME ||
                    rc->revDateFormat == ASN_GENERALIZED_TIME) {
                /* Find actual length: dates are null-terminated strings in
                 * revDate buffer up to MAX_DATE_SIZE */
                while (dateLen < MAX_DATE_SIZE && rc->revDate[dateLen] != 0)
                    dateLen++;
            }
            if (dateLen > 0 && dateLen < MAX_DATE_SIZE) {
                XMEMCPY(revDate->data, rc->revDate, (size_t)dateLen);
                revDate->length = dateLen;
                revDate->type = rc->revDateFormat;
            }
        }
        rev->revocationDate = revDate;
    }

    /* Reason code */
    rev->reason = rc->reasonCode;

    /* Sequence (load order) */
    rev->sequence = seq;

    /* issuer: left as NULL (indirect CRL not yet supported) */
    /* extensions: left as NULL for now (raw DER available in RevokedCert
     * but decoded STACK_OF(X509_EXTENSION) build not yet implemented) */

    return rev;
}
#endif /* HAVE_CRL */

WOLFSSL_STACK* wolfSSL_X509_CRL_get_REVOKED(WOLFSSL_X509_CRL* crl)
{
    WOLFSSL_ENTER("wolfSSL_X509_CRL_get_REVOKED");

    if (crl == NULL) {
        return NULL;
    }

#if defined(OPENSSL_EXTRA) && defined(HAVE_CRL)
    /* Return cached stack if already built */
    if (crl->revokedStack != NULL) {
        return crl->revokedStack;
    }

    /* Build the stack from the internal RevokedCert linked list */
    if (crl->crlList != NULL) {
        WOLFSSL_STACK* sk;
        RevokedCert* rc;
        int seq = 0;

        sk = wolfSSL_sk_new_null();
        if (sk == NULL) {
            return NULL;
        }
        sk->type = STACK_TYPE_X509_REVOKED;

        for (rc = crl->crlList->certs; rc != NULL; rc = rc->next) {
            WOLFSSL_X509_REVOKED* rev = RevokedCertToRevoked(rc, seq);
            if (rev == NULL) {
                /* Clean up on failure */
                wolfSSL_sk_pop_free(sk, NULL);
                return NULL;
            }
            /* Push to stack. wolfSSL_sk_push returns total count on success. */
            if (wolfSSL_sk_push(sk, rev) <= 0) {
                wolfSSL_X509_REVOKED_free(rev);
                wolfSSL_sk_pop_free(sk, NULL);
                return NULL;
            }
            seq++;
        }

        crl->revokedStack = sk;
        return sk;
    }
#endif /* OPENSSL_EXTRA && HAVE_CRL */

    return NULL;
}

WOLFSSL_X509_REVOKED* wolfSSL_sk_X509_REVOKED_value(
                                    WOLFSSL_STACK* sk, int idx)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_REVOKED_value");

    if (sk == NULL) {
        return NULL;
    }

    return (WOLFSSL_X509_REVOKED*)wolfSSL_sk_value(sk, idx);
}

/* Extension accessors for WOLFSSL_X509_REVOKED */
int wolfSSL_X509_REVOKED_get_ext_count(const WOLFSSL_X509_REVOKED* rev)
{
    WOLFSSL_ENTER("wolfSSL_X509_REVOKED_get_ext_count");
    if (rev != NULL && rev->extensions != NULL) {
        return (int)rev->extensions->num;
    }
    return 0;
}

WOLFSSL_X509_EXTENSION* wolfSSL_X509_REVOKED_get_ext(
                                     const WOLFSSL_X509_REVOKED* rev, int loc)
{
    WOLFSSL_ENTER("wolfSSL_X509_REVOKED_get_ext");
    if (rev != NULL && rev->extensions != NULL) {
        return (WOLFSSL_X509_EXTENSION*)wolfSSL_sk_value(rev->extensions, loc);
    }
    return NULL;
}

#endif /* OPENSSL_EXTRA */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL)

WOLFSSL_ASN1_INTEGER* wolfSSL_X509_get_serialNumber(WOLFSSL_X509* x509)
{
    WOLFSSL_ASN1_INTEGER* a;
    int i = 0;

    WOLFSSL_ENTER("wolfSSL_X509_get_serialNumber");

    if (x509 == NULL) {
        WOLFSSL_MSG("NULL function argument");
        return NULL;
    }

    if (x509->serialNumber != NULL)
       return x509->serialNumber;

    if (x509->serialSz < 0) {
        WOLFSSL_MSG("Invalid serial number size");
        return NULL;
    }

    a = wolfSSL_ASN1_INTEGER_new();
    if (a == NULL)
        return NULL;

    /* Make sure there is space for the data, ASN.1 type and length. */
    if (x509->serialSz > (WOLFSSL_ASN1_INTEGER_MAX - 2)) {
        /* dynamically create data buffer, +2 for type and length */
        a->data = (unsigned char*)XMALLOC(x509->serialSz + 2, NULL,
                DYNAMIC_TYPE_OPENSSL);
        if (a->data == NULL) {
            wolfSSL_ASN1_INTEGER_free(a);
            return NULL;
        }
        a->dataMax   = (unsigned int)x509->serialSz + 2;
        a->isDynamic = 1;
    }
    else {
        /* Use array instead of dynamic memory */
        a->data    = a->intData;
        a->dataMax = WOLFSSL_ASN1_INTEGER_MAX;
    }

    #if defined(WOLFSSL_QT) || defined(WOLFSSL_HAPROXY)
        XMEMCPY(&a->data[i], x509->serial, x509->serialSz);
        a->length = x509->serialSz;
    #else
        a->data[i++] = ASN_INTEGER;
        i += SetLength(x509->serialSz, a->data + i);
        XMEMCPY(&a->data[i], x509->serial, x509->serialSz);
        a->length = x509->serialSz + 2;
    #endif

    x509->serialNumber = a;

    return a;
}

#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL */

#if defined(OPENSSL_EXTRA) || defined(OPENSSL_EXTRA_X509_SMALL)

#if defined(OPENSSL_ALL) || defined(OPENSSL_EXTRA) || \
    defined(WOLFSSL_APACHE_HTTPD) || defined(WOLFSSL_HAPROXY) || \
    defined(WOLFSSL_WPAS)
WOLFSSL_X509_ALGOR* wolfSSL_X509_ALGOR_new(void)
{
    WOLFSSL_X509_ALGOR* ret;
    ret = (WOLFSSL_X509_ALGOR*)XMALLOC(sizeof(WOLFSSL_X509_ALGOR), NULL,
                                       DYNAMIC_TYPE_OPENSSL);
    if (ret) {
        XMEMSET(ret, 0, sizeof(WOLFSSL_X509_ALGOR));
    }
    return ret;
}

void wolfSSL_X509_ALGOR_free(WOLFSSL_X509_ALGOR *alg)
{
    if (alg) {
        wolfSSL_ASN1_OBJECT_free(alg->algorithm);
        wolfSSL_ASN1_TYPE_free(alg->parameter);
        XFREE(alg, NULL, DYNAMIC_TYPE_OPENSSL);
    }
}

/* Returns X509_ALGOR struct with signature algorithm */
const WOLFSSL_X509_ALGOR* wolfSSL_X509_get0_tbs_sigalg(const WOLFSSL_X509 *x509)
{
    WOLFSSL_ENTER("wolfSSL_X509_get0_tbs_sigalg");

    if (x509 == NULL) {
        WOLFSSL_MSG("x509 struct NULL error");
        return NULL;
    }

    return &x509->algor;
}

/* Sets paobj pointer to X509_ALGOR signature algorithm */
void wolfSSL_X509_ALGOR_get0(const WOLFSSL_ASN1_OBJECT **paobj, int *pptype,
                            const void **ppval, const WOLFSSL_X509_ALGOR *algor)
{
    WOLFSSL_ENTER("wolfSSL_X509_ALGOR_get0");

    if (!algor) {
        WOLFSSL_MSG("algor object is NULL");
        return;
    }

    if (paobj)
        *paobj = algor->algorithm;
    if (ppval && algor->parameter)
        *ppval = algor->parameter->value.ptr;
    if (pptype) {
        if (algor->parameter) {
            *pptype = algor->parameter->type;
        }
        else {
            /* Default to WOLFSSL_V_ASN1_OBJECT */
            *pptype = WOLFSSL_V_ASN1_OBJECT;
        }
    }
}

/**
 * Populate algor members.
 *
 * @param algor The object to be set
 * @param aobj The value to be set in algor->algorithm
 * @param ptype The type of algor->parameter
 * @param pval The value of algor->parameter
 * @return WOLFSSL_SUCCESS on success
 *         WOLFSSL_FAILURE on missing parameters or bad malloc
 */
int wolfSSL_X509_ALGOR_set0(WOLFSSL_X509_ALGOR *algor,
                            WOLFSSL_ASN1_OBJECT *aobj, int ptype, void *pval)
{
    if (!algor) {
        return WOLFSSL_FAILURE;
    }

    if (!algor->parameter) {
        algor->parameter = wolfSSL_ASN1_TYPE_new();
        if (!algor->parameter) {
            return WOLFSSL_FAILURE;
        }
    }

    if (aobj) {
        algor->algorithm = aobj;
    }
    wolfSSL_ASN1_TYPE_set(algor->parameter, ptype, pval);

    return WOLFSSL_SUCCESS;
}

/**
 * Serialize object to DER encoding
 *
 * @param alg Object to serialize
 * @param pp  Output
 * @return Length on success
 *         Negative number on failure
 */
int wolfSSL_i2d_X509_ALGOR(const WOLFSSL_X509_ALGOR* alg,
        unsigned char** pp)
{
    int len;
    word32 oid = 0;
    word32 idx = 0;
    unsigned char* buf = NULL;

    if (alg == NULL || alg->algorithm == 0) {
        WOLFSSL_MSG("alg is NULL or algorithm not set");
        return WOLFSSL_FATAL_ERROR;
    }

    if (GetObjectId(alg->algorithm->obj, &idx, &oid,
            (word32)alg->algorithm->grp, alg->algorithm->objSz) < 0) {
        WOLFSSL_MSG("Issue getting OID of object");
        return WOLFSSL_FATAL_ERROR;
    }

    len = (int)SetAlgoID((int)oid, NULL, alg->algorithm->grp, 0);
    if (len == 0) {
        WOLFSSL_MSG("SetAlgoID error");
        return WOLFSSL_FATAL_ERROR;
    }

    if (pp != NULL) {
        if (*pp != NULL)
            buf = *pp;
        else {
            buf = (byte*)XMALLOC((size_t)len, NULL, DYNAMIC_TYPE_ASN1);
            if (buf == NULL)
                return WOLFSSL_FATAL_ERROR;
        }

        len = (int)SetAlgoID((int)oid, buf, alg->algorithm->grp, 0);
        if (len == 0) {
            WOLFSSL_MSG("SetAlgoID error");
            if (*pp == NULL)
                XFREE(buf, NULL, DYNAMIC_TYPE_ASN1);
            return WOLFSSL_FATAL_ERROR;
        }

        if (*pp != NULL)
            *pp += len;
        else
            *pp = buf;
    }

    return len;
}

WOLFSSL_X509_ALGOR* wolfSSL_d2i_X509_ALGOR(WOLFSSL_X509_ALGOR** out,
        const byte** src, long len)
{
    WOLFSSL_X509_ALGOR* ret = NULL;
    word32 idx = 0;
    word32 oid = 0;
    int grp;

    WOLFSSL_ENTER("wolfSSL_d2i_X509_ALGOR");

    if (src == NULL || *src == NULL || len <= 0)
        return NULL;

    if (GetAlgoId(*src, &idx, &oid, oidIgnoreType, (word32)len) != 0)
        return NULL;

    /* Try to guess the type */
    for (grp = 0; grp < oidIgnoreType; grp++) {
        word32 oidSz;
        if (OidFromId(oid, (word32)grp, &oidSz) != NULL)
            break;
    }
    if (grp == oidIgnoreType)
        return NULL;

    ret = wolfSSL_X509_ALGOR_new();
    if (ret == NULL)
        return NULL;

    ret->algorithm = wolfSSL_OBJ_nid2obj(oid2nid(oid, grp));
    if (ret->algorithm == NULL) {
        wolfSSL_X509_ALGOR_free(ret);
        return NULL;
    }
    *src += idx;

    if (out != NULL) {
        if (*out != NULL)
            wolfSSL_X509_ALGOR_free(*out);
        *out = ret;
    }

    return ret;
}

/**
 * Allocate a new WOLFSSL_X509_PUBKEY object.
 *
 * @return New zero'ed WOLFSSL_X509_PUBKEY object
 */
WOLFSSL_X509_PUBKEY *wolfSSL_X509_PUBKEY_new(void)
{
    WOLFSSL_X509_PUBKEY *ret;
    ret = (WOLFSSL_X509_PUBKEY*)XMALLOC(sizeof(WOLFSSL_X509_PUBKEY), NULL,
                                        DYNAMIC_TYPE_OPENSSL);
    if (!ret) {
        return NULL;
    }
    XMEMSET(ret, 0, sizeof(WOLFSSL_X509_PUBKEY));
    ret->algor = wolfSSL_X509_ALGOR_new();
    if (!ret->algor) {
        wolfSSL_X509_PUBKEY_free(ret);
        return NULL;
    }
    return ret;
}

/**
 * Free WOLFSSL_X509_PUBKEY and all its members.
 *
 * @param at Object to free
 */
void wolfSSL_X509_PUBKEY_free(WOLFSSL_X509_PUBKEY *x)
{
    if (x) {
        if (x->algor) {
            wolfSSL_X509_ALGOR_free(x->algor);
        }
        if (x->pkey) {
            wolfSSL_EVP_PKEY_free(x->pkey);
        }
        XFREE(x, NULL, DYNAMIC_TYPE_OPENSSL);
    }
}

/* Returns X509_PUBKEY structure containing X509_ALGOR and EVP_PKEY */
WOLFSSL_X509_PUBKEY* wolfSSL_X509_get_X509_PUBKEY(const WOLFSSL_X509* x509)
{
    WOLFSSL_ENTER("wolfSSL_X509_get_X509_PUBKEY");

    if (x509 == NULL) {
        WOLFSSL_MSG("x509 struct NULL error");
        return NULL;
    }

    return (WOLFSSL_X509_PUBKEY*)&x509->key;
}

/* Sets ppkalg pointer to X509_PUBKEY algorithm. Returns WOLFSSL_SUCCESS on
    success or WOLFSSL_FAILURE on error. */
int wolfSSL_X509_PUBKEY_get0_param(WOLFSSL_ASN1_OBJECT **ppkalg,
     const unsigned char **pk, int *ppklen, WOLFSSL_X509_ALGOR **pa,
     WOLFSSL_X509_PUBKEY *pub)
{
    WOLFSSL_ENTER("wolfSSL_X509_PUBKEY_get0_param");

    if (!pub || !pub->pubKeyOID) {
        WOLFSSL_MSG("X509_PUBKEY struct not populated");
        return WOLFSSL_FAILURE;
    }

    if (!pub->algor) {
        if (!(pub->algor = wolfSSL_X509_ALGOR_new())) {
            return WOLFSSL_FAILURE;
        }
        pub->algor->algorithm = wolfSSL_OBJ_nid2obj(pub->pubKeyOID);
        if (pub->algor->algorithm == NULL) {
            WOLFSSL_MSG("Failed to create object from NID");
            return WOLFSSL_FAILURE;
        }
    }

    if (pa)
        *pa = pub->algor;
    if (ppkalg)
        *ppkalg = pub->algor->algorithm;
    if (pk)
        *pk = (unsigned char*)pub->pkey->pkey.ptr;
    if (ppklen)
        *ppklen = pub->pkey->pkey_sz;

    return WOLFSSL_SUCCESS;
}

/* Returns a pointer to the pkey when passed a key */
WOLFSSL_EVP_PKEY* wolfSSL_X509_PUBKEY_get(WOLFSSL_X509_PUBKEY* key)
{
    WOLFSSL_ENTER("wolfSSL_X509_PUBKEY_get");
    if (key == NULL || key->pkey == NULL) {
        WOLFSSL_LEAVE("wolfSSL_X509_PUBKEY_get", BAD_FUNC_ARG);
        return NULL;
    }
    if (wolfSSL_EVP_PKEY_up_ref(key->pkey) != WOLFSSL_SUCCESS) {
        WOLFSSL_LEAVE("wolfSSL_X509_PUBKEY_get", BAD_MUTEX_E);
        return NULL;
    }
    WOLFSSL_LEAVE("wolfSSL_X509_PUBKEY_get", WOLFSSL_SUCCESS);
    return key->pkey;
}

int wolfSSL_X509_PUBKEY_set(WOLFSSL_X509_PUBKEY **x, WOLFSSL_EVP_PKEY *key)
{
    WOLFSSL_X509_PUBKEY *pk = NULL;
    int ptype;
    void *pval;
#ifndef NO_DSA
    WOLFSSL_ASN1_STRING *str;
#endif
#ifdef HAVE_ECC
    int nid;
    const WOLFSSL_EC_GROUP *group;
#endif
    WOLFSSL_ASN1_OBJECT *keyTypeObj;

    WOLFSSL_ENTER("wolfSSL_X509_PUBKEY_set");

    if (!x || !key) {
        return WOLFSSL_FAILURE;
    }

    if (!(pk = wolfSSL_X509_PUBKEY_new())) {
        return WOLFSSL_FAILURE;
    }

    switch (key->type) {
#ifndef NO_RSA
    case WC_EVP_PKEY_RSA:
        pval = NULL;
        ptype = WOLFSSL_V_ASN1_NULL;
        pk->pubKeyOID = RSAk;
        break;
#endif
#ifndef NO_DSA
    case WC_EVP_PKEY_DSA:
        if (!key->dsa->p || !key->dsa->q || !key->dsa->g)
            goto error;

        str = wolfSSL_ASN1_STRING_new();
        if (str == NULL)
            goto error;

        str->length = wolfSSL_i2d_DSAparams(key->dsa,
             (unsigned char **)&str->data);
        if (str->length <= 0) {
            wolfSSL_ASN1_STRING_free(str);
            goto error;
        }
        str->isDynamic = 1;

        pval = str;
        ptype = WOLFSSL_V_ASN1_SEQUENCE;
        pk->pubKeyOID = DSAk;
        break;
#endif
#ifdef HAVE_ECC
    case WC_EVP_PKEY_EC:
        group = wolfSSL_EC_KEY_get0_group(key->ecc);
        if (!group)
            goto error;

        nid = wolfSSL_EC_GROUP_get_curve_name(group);
        if (nid <= 0) {
            /* TODO: Add support for no nid case */
            WOLFSSL_MSG("nid not found");
            goto error;
        }

        pval = wolfSSL_OBJ_nid2obj(nid);
        if (!pval)
            goto error;

        ptype = WOLFSSL_V_ASN1_OBJECT;
        pk->pubKeyOID = ECDSAk;
        break;
#endif
    default:
        WOLFSSL_MSG("Unknown key type");
        goto error;
    }

    keyTypeObj = wolfSSL_OBJ_nid2obj(key->type);
    if (keyTypeObj == NULL) {
        if (ptype == WOLFSSL_V_ASN1_OBJECT)
            wolfSSL_ASN1_OBJECT_free((WOLFSSL_ASN1_OBJECT *)pval);
        else
            wolfSSL_ASN1_STRING_free((WOLFSSL_ASN1_STRING *)pval);
        goto error;
    }
    if (!wolfSSL_X509_ALGOR_set0(pk->algor, keyTypeObj, ptype, pval)) {
        WOLFSSL_MSG("Failed to create algorithm object");
        wolfSSL_ASN1_OBJECT_free(keyTypeObj);
        if (ptype == WOLFSSL_V_ASN1_OBJECT)
            wolfSSL_ASN1_OBJECT_free((WOLFSSL_ASN1_OBJECT *)pval);
        else
            wolfSSL_ASN1_STRING_free((WOLFSSL_ASN1_STRING *)pval);
        goto error;
    }

    if (!wolfSSL_EVP_PKEY_up_ref(key)) {
        WOLFSSL_MSG("Failed to up key reference");
        goto error;
    }
    pk->pkey = key;

    wolfSSL_X509_PUBKEY_free(*x);
    *x = pk;
    return WOLFSSL_SUCCESS;
error:
    if (pk) {
        wolfSSL_X509_PUBKEY_free(pk);
    }
    return WOLFSSL_FAILURE;
}

#endif /* OPENSSL_ALL || OPENSSL_EXTRA || WOLFSSL_APACHE_HTTPD ||
        * WOLFSSL_HAPROXY || WOLFSSL_WPAS */

#if defined(OPENSSL_EXTRA) && !defined(NO_CERTS) && !defined(NO_ASN) && \
    !defined(NO_PWDBASED)

int wolfSSL_i2d_X509_PUBKEY(WOLFSSL_X509_PUBKEY* x509_PubKey,
    unsigned char** der)
{
    if (x509_PubKey == NULL)
        return WOLFSSL_FATAL_ERROR;
    return wolfSSL_i2d_PublicKey(x509_PubKey->pkey, der);
}

#endif /* OPENSSL_EXTRA && !NO_CERTS && !NO_ASN && !NO_PWDBASED */

#endif /* OPENSSL_EXTRA || OPENSSL_EXTRA_X509_SMALL */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL)
WOLFSSL_BASIC_CONSTRAINTS* wolfSSL_BASIC_CONSTRAINTS_new(void)
{
    WOLFSSL_BASIC_CONSTRAINTS* bc;
    bc = (WOLFSSL_BASIC_CONSTRAINTS*)
          XMALLOC(sizeof(WOLFSSL_BASIC_CONSTRAINTS), NULL,
          DYNAMIC_TYPE_X509_EXT);
    if (bc == NULL) {
        WOLFSSL_MSG("Failed to malloc basic constraints");
        return NULL;
    }
    XMEMSET(bc, 0, sizeof(WOLFSSL_BASIC_CONSTRAINTS));
    return bc;
}

/* frees the wolfSSL_BASIC_CONSTRAINTS object */
void wolfSSL_BASIC_CONSTRAINTS_free(WOLFSSL_BASIC_CONSTRAINTS *bc)
{
    WOLFSSL_ENTER("wolfSSL_BASIC_CONSTRAINTS_free");
    if (bc == NULL) {
        WOLFSSL_MSG("Argument is NULL");
        return;
    }
    if (bc->pathlen) {
        wolfSSL_ASN1_INTEGER_free(bc->pathlen);
    }
    XFREE(bc, NULL, DYNAMIC_TYPE_OPENSSL);
}

WOLFSSL_AUTHORITY_KEYID* wolfSSL_AUTHORITY_KEYID_new(void)
{
    WOLFSSL_AUTHORITY_KEYID* akey = (WOLFSSL_AUTHORITY_KEYID*)XMALLOC(
          sizeof(WOLFSSL_AUTHORITY_KEYID), NULL, DYNAMIC_TYPE_OPENSSL);
    if (!akey) {
        WOLFSSL_MSG("Issue creating WOLFSSL_AUTHORITY_KEYID struct");
        return NULL;
    }
    XMEMSET(akey, 0, sizeof(WOLFSSL_AUTHORITY_KEYID));
    return akey;
}

/* frees the wolfSSL_AUTHORITY_KEYID object */
void wolfSSL_AUTHORITY_KEYID_free(WOLFSSL_AUTHORITY_KEYID *id)
{
    WOLFSSL_ENTER("wolfSSL_AUTHORITY_KEYID_free");
    if (id == NULL) {
        WOLFSSL_MSG("Argument is NULL");
        return;
    }
    if (id->keyid) {
        wolfSSL_ASN1_STRING_free(id->keyid);
    }
    if (id->issuer) {
        wolfSSL_ASN1_OBJECT_free(id->issuer);
    }
    if (id->serial) {
        wolfSSL_ASN1_INTEGER_free(id->serial);
    }
    XFREE(id, NULL, DYNAMIC_TYPE_OPENSSL);
}

#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL */

#ifdef KEEP_PEER_CERT
char*  wolfSSL_X509_get_subjectCN(WOLFSSL_X509* x509)
{
    if (x509 == NULL)
        return NULL;

    return x509->subjectCN;
}
#endif /* KEEP_PEER_CERT */

#if defined(OPENSSL_EXTRA_X509_SMALL) || defined(OPENSSL_EXTRA)
/* increments ref count of WOLFSSL_X509. Return 1 on success, 0 on error */
int wolfSSL_X509_up_ref(WOLFSSL_X509* x509)
{
    if (x509) {
        int ret;
        wolfSSL_RefInc(&x509->ref, &ret);
        if (ret != 0) {
            WOLFSSL_MSG("Failed to lock x509 mutex");
            return WOLFSSL_FAILURE;
        }

        return WOLFSSL_SUCCESS;
    }

    return WOLFSSL_FAILURE;
}
#endif /* OPENSSL_EXTRA_X509_SMALL || OPENSSL_EXTRA */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL)
WOLF_STACK_OF(WOLFSSL_X509)* wolfSSL_X509_chain_up_ref(
        WOLF_STACK_OF(WOLFSSL_X509)* chain)
{
    /* wolfSSL_sk_dup takes care of doing a deep copy */
    return wolfSSL_sk_dup(chain);
}
#endif

#if defined(OPENSSL_EXTRA)

WOLF_STACK_OF(WOLFSSL_X509_OBJECT)* wolfSSL_sk_X509_OBJECT_deep_copy(
    const WOLF_STACK_OF(WOLFSSL_X509_OBJECT)* sk,
    WOLFSSL_X509_OBJECT* (*c)(const WOLFSSL_X509_OBJECT*),
    void (*f)(WOLFSSL_X509_OBJECT*))
{
    (void)f; /* free function */
    (void)c; /* copy function */
    return wolfSSL_sk_dup((WOLFSSL_STACK*)sk);
}
#endif

#if defined(OPENSSL_EXTRA) || defined(OPENSSL_EXTRA_X509_SMALL)
    void wolfSSL_X509_NAME_free(WOLFSSL_X509_NAME *name)
    {
        WOLFSSL_ENTER_VERBOSE("wolfSSL_X509_NAME_free");
        FreeX509Name(name);
        if (name != NULL) {
            XFREE(name, name->heap, DYNAMIC_TYPE_X509);
        }
    }


    /* Malloc's a new WOLFSSL_X509_NAME structure
     *
     * returns NULL on failure, otherwise returns a new structure.
     */
    WOLFSSL_X509_NAME* wolfSSL_X509_NAME_new_ex(void *heap)
    {
        WOLFSSL_X509_NAME* name;

        WOLFSSL_ENTER_VERBOSE("wolfSSL_X509_NAME_new_ex");

        name = (WOLFSSL_X509_NAME*)XMALLOC(sizeof(WOLFSSL_X509_NAME), heap,
                DYNAMIC_TYPE_X509);
        if (name != NULL) {
            InitX509Name(name, 1, heap);
        }
        return name;
    }

    WOLFSSL_X509_NAME* wolfSSL_X509_NAME_new(void) {
        return wolfSSL_X509_NAME_new_ex(NULL);
    }

    /* Creates a duplicate of a WOLFSSL_X509_NAME structure.
       Returns a new WOLFSSL_X509_NAME structure or NULL on failure */
    WOLFSSL_X509_NAME* wolfSSL_X509_NAME_dup(const WOLFSSL_X509_NAME *name)
    {
        WOLFSSL_X509_NAME* copy = NULL;

        WOLFSSL_ENTER("wolfSSL_X509_NAME_dup");

        if (name == NULL) {
            WOLFSSL_MSG("NULL parameter");
            return NULL;
        }

        if (!(copy = wolfSSL_X509_NAME_new_ex(name->heap))) {
            return NULL;
        }

        /* copy contents */
        InitX509Name(copy, 1, name->heap);
        if (wolfSSL_X509_NAME_copy(name, copy) != WOLFSSL_SUCCESS) {
            wolfSSL_X509_NAME_free(copy);
            return NULL;
        }

        return copy;
    }

#ifdef WOLFSSL_CERT_GEN

#if defined(WOLFSSL_CERT_REQ) || defined(WOLFSSL_CERT_EXT) || \
    defined(OPENSSL_EXTRA)
    /* Helper function to copy cert name from a WOLFSSL_X509_NAME structure to
    * a Cert structure.
    *
    * returns length of DER on success and a negative error value on failure
    */
    static int CopyX509NameToCert(WOLFSSL_X509_NAME* n, byte* out)
    {
        unsigned char* der = NULL;
        int length = WC_NO_ERR_TRACE(BAD_FUNC_ARG), ret;
        word32 idx = 0;

        ret = wolfSSL_i2d_X509_NAME(n, &der);
        if (ret > (int)sizeof(CertName) || ret < 0) {
            WOLFSSL_MSG("Name conversion error");
            ret = MEMORY_E;
        }

        if (ret > 0) {
            /* strip off sequence, this gets added on certificate creation */
            ret = GetSequence(der, &idx, &length, (word32)ret);
        }

        if (ret > 0) {
            XMEMCPY(out, der + idx, length);
        }

        XFREE(der, NULL, DYNAMIC_TYPE_OPENSSL);

        return length;
    }
#endif

#ifdef WOLFSSL_CERT_REQ
    static int ReqCertFromX509(Cert* cert, WOLFSSL_X509* req)
    {
        int ret;

        if (wc_InitCert(cert) != 0)
            return WOLFSSL_FAILURE;


        ret = CopyX509NameToCert(&req->subject, cert->sbjRaw);
        if (ret < 0) {
            WOLFSSL_MSG("REQ subject conversion error");
            ret = MEMORY_E;
        }
        else {
            ret = WOLFSSL_SUCCESS;
        }

        if (ret == WOLFSSL_SUCCESS) {
            cert->version = req->version;
            cert->isCA = req->isCa;
            cert->basicConstSet = req->basicConstSet;
            cert->basicConstCrit = req->basicConstCrit;
            if (req->pathLengthSet) {
                if (req->pathLength > WOLFSSL_MAX_PATH_LEN) {
                    WOLFSSL_MSG("Basic Constraints path length too large");
                    WOLFSSL_ERROR_VERBOSE(ASN_PATHLEN_SIZE_E);
                    ret = WOLFSSL_FAILURE;
                }
                else {
                    cert->pathLen = (byte)req->pathLength;
                    cert->pathLenSet = req->pathLengthSet;
                }
            }
    #ifdef WOLFSSL_CERT_EXT
            if (req->subjKeyIdSz != 0) {
                if (req->subjKeyIdSz > CTC_MAX_SKID_SIZE) {
                    WOLFSSL_MSG("Subject Key ID too large");
                    WOLFSSL_ERROR_VERBOSE(BUFFER_E);
                    ret = WOLFSSL_FAILURE;
                }
                else if (req->subjKeyId == NULL) {
                    WOLFSSL_MSG("Subject Key ID missing");
                    WOLFSSL_ERROR_VERBOSE(BAD_FUNC_ARG);
                    ret = WOLFSSL_FAILURE;
                }
                else {
                    XMEMCPY(cert->skid, req->subjKeyId, req->subjKeyIdSz);
                    cert->skidSz = (int)req->subjKeyIdSz;
                }
            }
            if (req->keyUsageSet)
                cert->keyUsage = req->keyUsage;

            cert->extKeyUsage = req->extKeyUsage;
    #endif
        }

        if (ret == WOLFSSL_SUCCESS) {
        #if defined(OPENSSL_ALL)
            int idx;
        #endif

            XMEMCPY(cert->challengePw, req->challengePw, CTC_NAME_SIZE);
            cert->challengePwPrintableString = req->challengePw[0] != 0;

        #if defined(OPENSSL_ALL)
            idx = wolfSSL_X509_REQ_get_attr_by_NID(req,
                    WC_NID_pkcs9_unstructuredName, -1);
            if (idx != WC_NO_ERR_TRACE(WOLFSSL_FATAL_ERROR)) {
                WOLFSSL_X509_ATTRIBUTE *attr;
                attr = wolfSSL_X509_REQ_get_attr(req, idx);
                if (attr != NULL) {
                    const unsigned char *attrData;
                    int attrDataSz;

                    attrData = wolfSSL_ASN1_STRING_get0_data(
                            attr->value->value.asn1_string);
                    attrDataSz = wolfSSL_ASN1_STRING_length(
                            attr->value->value.asn1_string);

                    /* +1 to make sure is terminated string */
                    if (attrDataSz + 1 > CTC_NAME_SIZE) {
                        WOLFSSL_MSG("attribute size was too large to copy");
                        ret = REQ_ATTRIBUTE_E;
                    }
                    else {
                        XMEMCPY(cert->unstructuredName, attrData, attrDataSz);
                        cert->unstructuredName[attrDataSz] = '\0';
                    }
                }
            }

        #ifdef WOLFSSL_CUSTOM_OID
            if (ret == WOLFSSL_SUCCESS) {
                if ((req->customExtCount < 0) ||
                    (req->customExtCount >= NUM_CUSTOM_EXT)) {
                    WOLFSSL_MSG("Bad value for customExtCount.");
                    ret = WOLFSSL_FAILURE;
                }

                if (ret == WOLFSSL_SUCCESS) {
                    for (idx = 0; idx < req->customExtCount; idx++) {
                        /* Note that ownership is NOT transferred.
                         * req->custom_exts buffers still need to be cleaned
                         * up. */
                        cert->customCertExt[idx] = req->custom_exts[idx];
                    }
                    cert->customCertExtCount = req->customExtCount;
                }
            }
        #endif /* WOLFSSL_CUSTOM_OID */
        #endif /* OPENSSL_ALL */

    #ifdef WOLFSSL_ALT_NAMES
            if (ret == WOLFSSL_SUCCESS) {
                cert->altNamesSz = FlattenAltNames(cert->altNames,
                        sizeof(cert->altNames), req->altNames);
            }
    #endif /* WOLFSSL_ALT_NAMES */
        }

        return ret;
    }
#endif /* WOLFSSL_CERT_REQ */

/* converts WOLFSSL_AN1_TIME to Cert form, returns positive size on
 * success */
static int CertDateFromX509(byte* out, int outSz, WOLFSSL_ASN1_TIME* t)
{
    int sz, i;

    if (t->length + 1 >= outSz) {
        return BUFFER_E;
    }

    out[0] = (byte) t->type;
    sz = (int)SetLength((word32)t->length, out + 1) + 1;  /* gen tag */
    for (i = 0; i < t->length; i++) {
        out[sz + i] = t->data[i];
    }
    return t->length + sz;
}

/* convert a WOLFSSL_X509 to a Cert structure for writing out */
static int CertFromX509(Cert* cert, WOLFSSL_X509* x509)
{
    int ret;
#ifdef WOLFSSL_CERT_EXT
    int i;
#endif

    WOLFSSL_ENTER("wolfSSL_X509_to_Cert");

    if (x509 == NULL || cert == NULL) {
        return BAD_FUNC_ARG;
    }

    wc_InitCert(cert);

    cert->version = (int)wolfSSL_X509_get_version(x509);

    if (x509->notBefore.length > 0) {
        cert->beforeDateSz = CertDateFromX509(cert->beforeDate,
                    CTC_DATE_SIZE, &x509->notBefore);
        if (cert->beforeDateSz <= 0) {
            WOLFSSL_MSG("Error converting WOLFSSL_X509 not before date");
            return WOLFSSL_FAILURE;
        }
    }
    else {
        cert->beforeDateSz = 0;
    }

    if (x509->notAfter.length > 0) {
        cert->afterDateSz = CertDateFromX509(cert->afterDate,
                    CTC_DATE_SIZE, &x509->notAfter);
        if (cert->afterDateSz <= 0) {
            WOLFSSL_MSG("Error converting WOLFSSL_X509 not after date");
            return WOLFSSL_FAILURE;
        }
    }
    else {
        cert->afterDateSz = 0;
    }

#ifdef WOLFSSL_ALT_NAMES
    cert->altNamesSz = FlattenAltNames(cert->altNames,
            sizeof(cert->altNames), x509->altNames);
#endif /* WOLFSSL_ALT_NAMES */

    cert->sigType = wolfSSL_X509_get_signature_type(x509);
    cert->keyType = x509->pubKeyOID;
    cert->isCA    = wolfSSL_X509_get_isCA(x509);
    cert->basicConstCrit = x509->basicConstCrit;
    cert->basicConstSet = x509->basicConstSet;
    if (x509->pathLengthSet) {
        if (x509->pathLength > WOLFSSL_MAX_PATH_LEN) {
            WOLFSSL_MSG("Basic Constraints path length too large");
            WOLFSSL_ERROR_VERBOSE(ASN_PATHLEN_SIZE_E);
            return WOLFSSL_FAILURE;
        }
        cert->pathLen = (byte)x509->pathLength;
        cert->pathLenSet = x509->pathLengthSet;
    }

#ifdef WOLFSSL_CERT_EXT
    if (x509->subjKeyIdSz <= CTC_MAX_SKID_SIZE) {
        if (x509->subjKeyId) {
            XMEMCPY(cert->skid, x509->subjKeyId, x509->subjKeyIdSz);
        }
        cert->skidSz = (int)x509->subjKeyIdSz;
    }
    else {
        WOLFSSL_MSG("Subject Key ID too large");
        WOLFSSL_ERROR_VERBOSE(BUFFER_E);
        return WOLFSSL_FAILURE;
    }

    #ifdef WOLFSSL_AKID_NAME
    cert->rawAkid = 0;
    if (x509->authKeyIdSrc) {
        if (x509->authKeyIdSrcSz > sizeof(cert->akid)) {
            WOLFSSL_MSG("Auth Key ID too large");
            WOLFSSL_ERROR_VERBOSE(BUFFER_E);
            return WOLFSSL_FAILURE;
        }
        XMEMCPY(cert->akid, x509->authKeyIdSrc, x509->authKeyIdSrcSz);
        cert->akidSz = (int)x509->authKeyIdSrcSz;
        cert->rawAkid = 1;
    }
    else
    #endif
    if (x509->authKeyId) {
        if (x509->authKeyIdSz > sizeof(cert->akid)) {
            WOLFSSL_MSG("Auth Key ID too large");
            WOLFSSL_ERROR_VERBOSE(BUFFER_E);
            return WOLFSSL_FAILURE;
        }
        XMEMCPY(cert->akid, x509->authKeyId, x509->authKeyIdSz);
        cert->akidSz = (int)x509->authKeyIdSz;
    }

    for (i = 0; i < x509->certPoliciesNb; i++) {
        /* copy the smaller of MAX macros, by default they are currently equal*/
        if ((int)CTC_MAX_CERTPOL_SZ <= (int)MAX_CERTPOL_SZ) {
            XMEMCPY(cert->certPolicies[i], x509->certPolicies[i],
                    CTC_MAX_CERTPOL_SZ);
        }
        else {
            XMEMCPY(cert->certPolicies[i], x509->certPolicies[i],
                    MAX_CERTPOL_SZ);
        }
    }
    cert->certPoliciesNb = (word16)x509->certPoliciesNb;

    cert->keyUsage = x509->keyUsage;
    cert->extKeyUsage = x509->extKeyUsage;
    cert->nsCertType = x509->nsCertType;

    if (x509->rawCRLInfo != NULL) {
        if (x509->rawCRLInfoSz > CTC_MAX_CRLINFO_SZ) {
            WOLFSSL_MSG("CRL Info too large");
            WOLFSSL_ERROR_VERBOSE(BUFFER_E);
            return WOLFSSL_FAILURE;
        }
        XMEMCPY(cert->crlInfo, x509->rawCRLInfo, x509->rawCRLInfoSz);
        cert->crlInfoSz = x509->rawCRLInfoSz;
    }

#ifdef WOLFSSL_DUAL_ALG_CERTS
    /* We point to instance in x509 so DON'T need to be free'd. */
    cert->sapkiDer = x509->sapkiDer;
    cert->sapkiLen = x509->sapkiLen;
    cert->sapkiCrit = x509->sapkiCrit;
    cert->altSigAlgDer = x509->altSigAlgDer;
    cert->altSigAlgLen  = x509->altSigAlgLen;
    cert->altSigAlgCrit = x509->altSigAlgCrit;
    cert->altSigValDer = x509->altSigValDer;
    cert->altSigValLen = x509->altSigValLen;
    cert->altSigValCrit = x509->altSigValCrit;
#endif /* WOLFSSL_DUAL_ALG_CERTS */

#if defined(WOLFSSL_ASN_TEMPLATE) && defined(WOLFSSL_CUSTOM_OID) && \
    defined(HAVE_OID_ENCODING)

    if ((x509->customExtCount < 0) ||
            (x509->customExtCount >= NUM_CUSTOM_EXT)) {
        WOLFSSL_MSG("Bad value for customExtCount.");
        return WOLFSSL_FAILURE;
    }

    for (i = 0; i < x509->customExtCount; i++) {
        if (wc_SetCustomExtension(cert, x509->custom_exts[i].crit,
                x509->custom_exts[i].oid, x509->custom_exts[i].val,
                x509->custom_exts[i].valSz))
        {
            return WOLFSSL_FAILURE;
        }
    }
#endif /* WOLFSSL_ASN_TEMPLATE && WOLFSSL_CUSTOM_OID && HAVE_OID_ENCODING */

#endif /* WOLFSSL_CERT_EXT */

#ifdef WOLFSSL_CERT_REQ
    /* copy over challenge password for REQ certs */
    XMEMCPY(cert->challengePw, x509->challengePw, CTC_NAME_SIZE);
#endif

    /* Only makes sense to do this for OPENSSL_EXTRA because without
     * this define the function will error out below */
    #ifdef OPENSSL_EXTRA
    if (x509->serialSz == 0 && x509->serialNumber != NULL &&
            /* Check if the buffer contains more than just the
             * ASN tag and length */
            x509->serialNumber->length > 2) {
        if (wolfSSL_X509_set_serialNumber(x509, x509->serialNumber)
                != WOLFSSL_SUCCESS) {
            WOLFSSL_MSG("Failed to set serial number");
            return WOLFSSL_FAILURE;
        }
    }
    #endif

    /* set serial number */
    if (x509->serialSz > 0) {
    #if defined(OPENSSL_EXTRA)
        byte serial[EXTERNAL_SERIAL_SIZE];
        int  serialSz = EXTERNAL_SERIAL_SIZE;

        ret = wolfSSL_X509_get_serial_number(x509, serial, &serialSz);
        if (ret != WOLFSSL_SUCCESS) {
            WOLFSSL_MSG("Serial size error");
            return WOLFSSL_FAILURE;
        }

        if (serialSz > EXTERNAL_SERIAL_SIZE ||
                serialSz > CTC_SERIAL_SIZE) {
            WOLFSSL_MSG("Serial size too large error");
            WOLFSSL_ERROR_VERBOSE(BUFFER_E);
            return WOLFSSL_FAILURE;
        }
        XMEMCPY(cert->serial, serial, serialSz);
        cert->serialSz = serialSz;
    #else
        WOLFSSL_MSG("Getting X509 serial number not supported");
        return WOLFSSL_FAILURE;
    #endif
    }

    /* copy over Name structures */
    if (x509->issuerSet)
        cert->selfSigned = 0;

#if defined(WOLFSSL_CERT_EXT) || defined(OPENSSL_EXTRA)
    ret = CopyX509NameToCert(&x509->subject, cert->sbjRaw);
    if (ret < 0) {
        WOLFSSL_MSG("Subject conversion error");
        return MEMORY_E;
    }
    if (cert->selfSigned) {
        XMEMCPY(cert->issRaw, cert->sbjRaw, sizeof(CertName));
    }
    else {
        ret = CopyX509NameToCert(&x509->issuer, cert->issRaw);
        if (ret < 0) {
            WOLFSSL_MSG("Issuer conversion error");
            return MEMORY_E;
        }
    }
#endif

    cert->heap = x509->heap;

    (void)ret;
    return WOLFSSL_SUCCESS;
}


#if defined(WOLFSSL_HAVE_MLDSA) && defined(WOLFSSL_MLDSA_PRIVATE_KEY) && \
    !defined(WOLFSSL_MLDSA_NO_ASN1) && !defined(WOLFSSL_MLDSA_NO_SIGN)
    /* ML-DSA X.509 signing needs private key decode and sign support; keep
     * every gate that decides "can we sign with ML-DSA" identical so that
     * verify-only builds reject the key type up front. */
    #define WOLFSSL_MLDSA_X509_SIGN
#endif

    /* returns the sig type to use on success i.e CTC_SHAwRSA and WOLFSSL_FALURE
     * on fail case */
    static int wolfSSL_sigTypeFromPKEY(WOLFSSL_EVP_MD* md,
            WOLFSSL_EVP_PKEY* pkey)
    {
    #if !defined(NO_PWDBASED) && defined(OPENSSL_EXTRA)
        int hashType;
        int sigType = WOLFSSL_FAILURE;
    #endif

        if (pkey == NULL) {
            return WOLFSSL_FAILURE;
        }

    #if defined(HAVE_ED25519)
        /* Ed25519 carries its own hash and needs no hash/PWDBASED info, so
         * resolve it outside the guard below (works in --disable-pwdbased).
         * OpenSSL rejects a non-NULL digest for Ed25519 -- match that rather
         * than silently ignoring the caller's md. */
        if (pkey->type == WC_EVP_PKEY_ED25519) {
            if (md != NULL)
                return WOLFSSL_FAILURE;
            return CTC_ED25519;
        }
    #endif

    #if !defined(NO_PWDBASED) && defined(OPENSSL_EXTRA)
    #ifdef WOLFSSL_MLDSA_X509_SIGN
        if (pkey->type == WC_EVP_PKEY_DILITHIUM) {
            /* ML-DSA does not use a separate hash. A NULL md matches
             * OpenSSL's X509_sign(x, pkey, NULL); unlike OpenSSL, a
             * non-NULL md is deliberately ignored rather than rejected to
             * keep hash-passing callers working. */
            if (md != NULL) {
                WOLFSSL_MSG("Ignoring md for ML-DSA signing");
            }
            switch (WOLFSSL_ATOMIC_LOAD(pkey->mldsaOID)) {
                case ML_DSA_44k:
                    sigType = CTC_ML_DSA_44;
                    break;
                case ML_DSA_65k:
                    sigType = CTC_ML_DSA_65;
                    break;
                case ML_DSA_87k:
                    sigType = CTC_ML_DSA_87;
                    break;
            #ifdef WOLFSSL_MLDSA_FIPS204_DRAFT
                case DILITHIUM_LEVEL2k:
                    sigType = CTC_DILITHIUM_LEVEL2;
                    break;
                case DILITHIUM_LEVEL3k:
                    sigType = CTC_DILITHIUM_LEVEL3;
                    break;
                case DILITHIUM_LEVEL5k:
                    sigType = CTC_DILITHIUM_LEVEL5;
                    break;
            #endif
                default:
                    return WOLFSSL_FAILURE;
            }
            return sigType;
        }
    #endif /* WOLFSSL_MLDSA_X509_SIGN */

        /* Every remaining key type signs a digest, and
         * wolfSSL_EVP_get_hashinfo() below dereferences md without a NULL
         * check of its own.  (Checked after ML-DSA, which accepts a NULL md.)
         */
        if (md == NULL) {
            return WOLFSSL_FAILURE;
        }

        /* Convert key type and hash algorithm to a signature algorithm */
        if (wolfSSL_EVP_get_hashinfo(md, &hashType, NULL)
            == WC_NO_ERR_TRACE(WOLFSSL_FAILURE))
        {
            return WOLFSSL_FAILURE;
        }

        if (pkey->type == WC_EVP_PKEY_RSA) {
            switch (hashType) {
                case WC_HASH_TYPE_SHA:
                    sigType = CTC_SHAwRSA;
                    break;
                case WC_HASH_TYPE_SHA224:
                    sigType = CTC_SHA224wRSA;
                    break;
                case WC_HASH_TYPE_SHA256:
                    sigType = CTC_SHA256wRSA;
                    break;
                case WC_HASH_TYPE_SHA384:
                    sigType = CTC_SHA384wRSA;
                    break;
                case WC_HASH_TYPE_SHA512:
                    sigType = CTC_SHA512wRSA;
                    break;
            #ifdef WOLFSSL_SHA3
                case WC_HASH_TYPE_SHA3_224:
                    sigType = CTC_SHA3_224wRSA;
                    break;
                case WC_HASH_TYPE_SHA3_256:
                    sigType = CTC_SHA3_256wRSA;
                    break;
                case WC_HASH_TYPE_SHA3_384:
                    sigType = CTC_SHA3_384wRSA;
                    break;
                case WC_HASH_TYPE_SHA3_512:
                    sigType = CTC_SHA3_512wRSA;
                    break;
            #endif
                default:
                    return WOLFSSL_FAILURE;
            }
        }
        else if (pkey->type == WC_EVP_PKEY_EC) {
            switch (hashType) {
                case WC_HASH_TYPE_SHA:
                    sigType = CTC_SHAwECDSA;
                    break;
                case WC_HASH_TYPE_SHA224:
                    sigType = CTC_SHA224wECDSA;
                    break;
                case WC_HASH_TYPE_SHA256:
                    sigType = CTC_SHA256wECDSA;
                    break;
                case WC_HASH_TYPE_SHA384:
                    sigType = CTC_SHA384wECDSA;
                    break;
                case WC_HASH_TYPE_SHA512:
                    sigType = CTC_SHA512wECDSA;
                    break;
            #ifdef WOLFSSL_SHA3
                case WC_HASH_TYPE_SHA3_224:
                    sigType = CTC_SHA3_224wECDSA;
                    break;
                case WC_HASH_TYPE_SHA3_256:
                    sigType = CTC_SHA3_256wECDSA;
                    break;
                case WC_HASH_TYPE_SHA3_384:
                    sigType = CTC_SHA3_384wECDSA;
                    break;
                case WC_HASH_TYPE_SHA3_512:
                    sigType = CTC_SHA3_512wECDSA;
                    break;
            #endif
                default:
                    return WOLFSSL_FAILURE;
            }
        }
        else
            return WOLFSSL_FAILURE;
        return sigType;
#else
        (void)md;
        (void)pkey;
        WOLFSSL_MSG("Cannot get hashinfo when NO_PWDBASED is defined");
        return WOLFSSL_FAILURE;
#endif /* !NO_PWDBASED && OPENSSL_EXTRA */
    }


    /* generates DER buffer from WOLFSSL_X509
     * If req == 1 then creates a request DER buffer
     *
     * updates derSz with certificate body size on success
     * return WOLFSSL_SUCCESS on success
     */
    static int wolfssl_x509_make_der(WOLFSSL_X509* x509, int req,
            unsigned char* der, int* derSz, int includeSig)
    {
        int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
        int totalLen;
        Cert* cert = NULL;
        void* key = NULL;
        int type = -1;
    #ifndef NO_RSA
        RsaKey* rsa = NULL;
    #endif
    #ifdef HAVE_ECC
        ecc_key* ecc = NULL;
    #endif
    #ifndef NO_DSA
        DsaKey* dsa = NULL;
    #endif
    #if defined(HAVE_ED25519) && defined(HAVE_ED25519_KEY_IMPORT)
        ed25519_key* ed25519 = NULL;
    #endif
    #if defined(HAVE_FALCON)
        falcon_key* falcon = NULL;
    #endif
    #if defined(WOLFSSL_HAVE_MLDSA)
        wc_MlDsaKey* mldsa = NULL;
    #endif
    #if defined(WOLFSSL_HAVE_SLHDSA)
        SlhDsaKey* slhdsa = NULL;
    #endif
        WC_RNG rng;
        word32 idx = 0;

        if (x509 == NULL || der == NULL || derSz == NULL)
            return BAD_FUNC_ARG;

    #ifndef WOLFSSL_CERT_REQ
        if (req) {
            WOLFSSL_MSG("WOLFSSL_CERT_REQ needed for certificate request");
            return WOLFSSL_FAILURE;
        }
    #endif

        /* allocate Cert struct on heap since it is large */
        cert = (Cert*)XMALLOC(sizeof(Cert), NULL, DYNAMIC_TYPE_CERT);
        if (cert == NULL) {
            WOLFSSL_MSG("Failed to allocate memory for Cert struct");
            return WOLFSSL_FAILURE;
        }
        XMEMSET(cert, 0, sizeof(Cert));

    #ifdef WOLFSSL_CERT_REQ
        if (req) {
            if (ReqCertFromX509(cert, x509) != WOLFSSL_SUCCESS) {
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return WOLFSSL_FAILURE;
            }
        }
        else
    #endif
        {
            /* Create a Cert that has the certificate fields. */
            if (CertFromX509(cert, x509) != WOLFSSL_SUCCESS) {
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return WOLFSSL_FAILURE;
            }
        }

        /* Create a public key object from requests public key. */
    #ifndef NO_RSA
        if (x509->pubKeyOID == RSAk) {

            rsa = (RsaKey*)XMALLOC(sizeof(RsaKey), NULL, DYNAMIC_TYPE_RSA);
            if (rsa == NULL) {
                WOLFSSL_MSG("Failed to allocate memory for RsaKey");
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return WOLFSSL_FAILURE;
            }

            type = RSA_TYPE;
            ret = wc_InitRsaKey(rsa, x509->heap);
            if (ret != 0) {
                XFREE(rsa, NULL, DYNAMIC_TYPE_RSA);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }
            ret = wc_RsaPublicKeyDecode(x509->pubKey.buffer, &idx, rsa,
                                                           x509->pubKey.length);
            if (ret != 0) {
                WOLFSSL_ERROR_VERBOSE(ret);
                wc_FreeRsaKey(rsa);
                XFREE(rsa, NULL, DYNAMIC_TYPE_RSA);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }
            key = (void*)rsa;
        }
    #endif
    #ifdef HAVE_ECC
        if (x509->pubKeyOID == ECDSAk) {

            ecc = (ecc_key*)XMALLOC(sizeof(ecc_key), NULL, DYNAMIC_TYPE_ECC);
            if (ecc == NULL) {
                WOLFSSL_MSG("Failed to allocate memory for ecc_key");
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return WOLFSSL_FAILURE;
            }

            type = ECC_TYPE;
            ret = wc_ecc_init(ecc);
            if (ret != 0) {
                XFREE(ecc, NULL, DYNAMIC_TYPE_ECC);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }
            ret = wc_EccPublicKeyDecode(x509->pubKey.buffer, &idx, ecc,
                                                           x509->pubKey.length);
            if (ret != 0) {
                WOLFSSL_ERROR_VERBOSE(ret);
                wc_ecc_free(ecc);
                XFREE(ecc, NULL, DYNAMIC_TYPE_ECC);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }
            key = (void*)ecc;
        }
    #endif
    #ifndef NO_DSA
        if (x509->pubKeyOID == DSAk) {

            dsa = (DsaKey*)XMALLOC(sizeof(DsaKey), NULL, DYNAMIC_TYPE_DSA);
            if (dsa == NULL) {
                WOLFSSL_MSG("Failed to allocate memory for DsaKey");
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return WOLFSSL_FAILURE;
            }

            type = DSA_TYPE;
            ret = wc_InitDsaKey(dsa);
            if (ret != 0) {
                XFREE(dsa, NULL, DYNAMIC_TYPE_DSA);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }
            ret = wc_DsaPublicKeyDecode(x509->pubKey.buffer, &idx, dsa,
                                                           x509->pubKey.length);
            if (ret != 0) {
                WOLFSSL_ERROR_VERBOSE(ret);
                wc_FreeDsaKey(dsa);
                XFREE(dsa, NULL, DYNAMIC_TYPE_DSA);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }
            key = (void*)dsa;
        }
    #endif
    #if defined(HAVE_ED25519) && defined(HAVE_ED25519_KEY_IMPORT)
        if (x509->pubKeyOID == ED25519k) {
            ed25519 = wolfSSL_ED25519_new(x509->heap, INVALID_DEVID);
            if (ed25519 == NULL) {
                WOLFSSL_MSG("Failed to allocate memory for ed25519_key");
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return WOLFSSL_FAILURE;
            }

            type = ED25519_TYPE;
            /* The X.509 public key buffer holds the raw Ed25519 key. */
            ret = wc_ed25519_import_public(x509->pubKey.buffer,
                                           x509->pubKey.length, ed25519);
            if (ret != 0) {
                WOLFSSL_ERROR_VERBOSE(ret);
                wolfSSL_ED25519_free(ed25519);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }
            key = (void*)ed25519;
        }
    #endif
    #if defined(HAVE_FALCON)
        if ((x509->pubKeyOID == FALCON_LEVEL1k) ||
            (x509->pubKeyOID == FALCON_LEVEL5k)) {
            falcon = (falcon_key*)XMALLOC(sizeof(falcon_key), NULL,
                                          DYNAMIC_TYPE_FALCON);
            if (falcon == NULL) {
                WOLFSSL_MSG("Failed to allocate memory for falcon_key");
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return WOLFSSL_FAILURE;
            }

            ret = wc_falcon_init(falcon);
            if (ret != 0) {
                XFREE(falcon, NULL, DYNAMIC_TYPE_FALCON);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }

            if (x509->pubKeyOID == FALCON_LEVEL1k) {
                type = FALCON_LEVEL1_TYPE;
                wc_falcon_set_level(falcon, 1);
            }
            else if (x509->pubKeyOID == FALCON_LEVEL5k) {
                type = FALCON_LEVEL5_TYPE;
                wc_falcon_set_level(falcon, 5);
            }

            ret = wc_Falcon_PublicKeyDecode(x509->pubKey.buffer, &idx, falcon,
                                            x509->pubKey.length);
            if (ret != 0) {
                WOLFSSL_ERROR_VERBOSE(ret);
                wc_falcon_free(falcon);
                XFREE(falcon, NULL, DYNAMIC_TYPE_FALCON);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }
            key = (void*)falcon;
        }
    #endif
    #if defined(WOLFSSL_HAVE_MLDSA)
        if ((x509->pubKeyOID == ML_DSA_44k) ||
            (x509->pubKeyOID == ML_DSA_65k) ||
            (x509->pubKeyOID == ML_DSA_87k)
            #ifdef WOLFSSL_MLDSA_FIPS204_DRAFT
         || (x509->pubKeyOID == DILITHIUM_LEVEL2k)
         || (x509->pubKeyOID == DILITHIUM_LEVEL3k)
         || (x509->pubKeyOID == DILITHIUM_LEVEL5k)
            #endif /* WOLFSSL_MLDSA_FIPS204_DRAFT */
            ) {
            mldsa = (wc_MlDsaKey*)XMALLOC(sizeof(wc_MlDsaKey), NULL,
                                          DYNAMIC_TYPE_MLDSA);
            if (mldsa == NULL) {
                WOLFSSL_MSG("Failed to allocate memory for wc_MlDsaKey");
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return WOLFSSL_FAILURE;
            }

            ret = wc_MlDsaKey_Init(mldsa, NULL, INVALID_DEVID);
            if (ret != 0) {
                XFREE(mldsa, NULL, DYNAMIC_TYPE_MLDSA);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }

            if (x509->pubKeyOID == ML_DSA_44k) {
                type = ML_DSA_44_TYPE;
                wc_MlDsaKey_SetParams(mldsa, WC_ML_DSA_44);
            }
            else if (x509->pubKeyOID == ML_DSA_65k) {
                type = ML_DSA_65_TYPE;
                wc_MlDsaKey_SetParams(mldsa, WC_ML_DSA_65);
            }
            else if (x509->pubKeyOID == ML_DSA_87k) {
                type = ML_DSA_87_TYPE;
                wc_MlDsaKey_SetParams(mldsa, WC_ML_DSA_87);
            }
            #ifdef WOLFSSL_MLDSA_FIPS204_DRAFT
            else if (x509->pubKeyOID == DILITHIUM_LEVEL2k) {
                type = DILITHIUM_LEVEL2_TYPE;
                wc_MlDsaKey_SetParams(mldsa, WC_ML_DSA_44_DRAFT);
            }
            else if (x509->pubKeyOID == DILITHIUM_LEVEL3k) {
                type = DILITHIUM_LEVEL3_TYPE;
                wc_MlDsaKey_SetParams(mldsa, WC_ML_DSA_65_DRAFT);
            }
            else if (x509->pubKeyOID == DILITHIUM_LEVEL5k) {
                type = DILITHIUM_LEVEL5_TYPE;
                wc_MlDsaKey_SetParams(mldsa, WC_ML_DSA_87_DRAFT);
            }
            #endif /* WOLFSSL_MLDSA_FIPS204_DRAFT */

            ret = wc_MlDsaKey_PublicKeyDecode(mldsa, x509->pubKey.buffer,
                                    x509->pubKey.length, &idx);
            if (ret != 0) {
                WOLFSSL_ERROR_VERBOSE(ret);
                wc_MlDsaKey_Free(mldsa);
                XFREE(mldsa, NULL, DYNAMIC_TYPE_MLDSA);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }
            key = (void*)mldsa;
        }
    #endif
    #if defined(WOLFSSL_HAVE_SLHDSA)
        if (wc_IsSlhDsaOid(x509->pubKeyOID)) {
            int paramInt = wc_SlhDsaOidToParam(x509->pubKeyOID);
            int certType = wc_SlhDsaOidToCertType(x509->pubKeyOID);

            /* The OID is a recognised SLH-DSA OID but the parameter set
             * isn't built in; surface NOT_COMPILED_IN directly so
             * callers can render an accurate diagnostic. */
            if (paramInt == WC_NO_ERR_TRACE(NOT_COMPILED_IN) ||
                    certType == WC_NO_ERR_TRACE(NOT_COMPILED_IN)) {
                WOLFSSL_MSG("SLH-DSA variant not compiled in");
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return NOT_COMPILED_IN;
            }
            /* Defensive: wc_IsSlhDsaOid already implies both lookups
             * succeed, but check explicitly so any future drift between the
             * three OID helpers surfaces as a clean failure rather than
             * undefined behaviour from casting -1 to enum SlhDsaParam. */
            if (paramInt < 0 || certType < 0) {
                WOLFSSL_MSG("SLH-DSA OID helper mismatch");
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return WOLFSSL_FAILURE;
            }

            slhdsa = (SlhDsaKey*)XMALLOC(sizeof(SlhDsaKey), NULL,
                                          DYNAMIC_TYPE_SLHDSA);
            if (slhdsa == NULL) {
                WOLFSSL_MSG("Failed to allocate memory for SlhDsaKey");
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return WOLFSSL_FAILURE;
            }

            type = certType;

            ret = wc_SlhDsaKey_Init(slhdsa, (enum SlhDsaParam)paramInt, NULL,
                                    INVALID_DEVID);
            if (ret != 0) {
                XFREE(slhdsa, NULL, DYNAMIC_TYPE_SLHDSA);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }

            ret = wc_SlhDsaKey_PublicKeyDecode(x509->pubKey.buffer, &idx,
                                               slhdsa, x509->pubKey.length);
            if (ret != 0) {
                WOLFSSL_ERROR_VERBOSE(ret);
                wc_SlhDsaKey_Free(slhdsa);
                XFREE(slhdsa, NULL, DYNAMIC_TYPE_SLHDSA);
                XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
                return ret;
            }
            key = (void*)slhdsa;
        }
    #endif
        if (key == NULL) {
            WOLFSSL_MSG("No public key found for certificate");
            XFREE(cert, NULL, DYNAMIC_TYPE_CERT);
            return WOLFSSL_FAILURE;
        }

        /* Make the body of the certificate request. */
    #ifdef WOLFSSL_CERT_REQ
        if (req) {
            ret = wc_MakeCertReq_ex(cert, der, *derSz, type, key);
        }
        else
    #endif
        {
            ret = wc_InitRng(&rng);
            if (ret != 0) {
                ret = WOLFSSL_FAILURE;
                goto cleanup;
            }

            ret = wc_MakeCert_ex(cert, der, *derSz, type, key, &rng);
            wc_FreeRng(&rng);
        }
        if (ret <= 0) {
            WOLFSSL_ERROR_VERBOSE(ret);
            ret = WOLFSSL_FAILURE;
            goto cleanup;
        }

        if ((x509->serialSz == 0) &&
                (cert->serialSz <= EXTERNAL_SERIAL_SIZE) &&
                (cert->serialSz > 0)) {
        #if defined(OPENSSL_EXTRA)
            WOLFSSL_ASN1_INTEGER *i = wolfSSL_ASN1_INTEGER_new();

            if (i == NULL) {
                WOLFSSL_MSG("wolfSSL_ASN1_INTEGER_new error");
                ret = WOLFSSL_FAILURE;
                goto cleanup;
            }
            else {
                i->length = cert->serialSz + 2;
                i->data[0] = ASN_INTEGER;
                i->data[1] = (unsigned char)cert->serialSz;
                XMEMCPY(i->data + 2, cert->serial, cert->serialSz);
                if (wolfSSL_X509_set_serialNumber(x509, i) != WOLFSSL_SUCCESS) {
                    WOLFSSL_MSG("Issue setting generated serial number");
                    wolfSSL_ASN1_INTEGER_free(i);
                    ret = WOLFSSL_FAILURE;
                    goto cleanup;
                }
                wolfSSL_ASN1_INTEGER_free(i);
            }
        #else
            WOLFSSL_MSG("ASN1_INTEGER API not in build");

            ret = WOLFSSL_FAILURE;
            goto cleanup;
        #endif /* OPENSSL_EXTRA */
        }

        if (includeSig) {
            if (!x509->sig.buffer) {
                WOLFSSL_MSG("No signature buffer");
                ret = WOLFSSL_FAILURE;
                goto cleanup;
            }
            totalLen = AddSignature(NULL, ret, NULL, x509->sig.length,
                                  x509->sigOID);
            if (totalLen > *derSz) {
                WOLFSSL_MSG("Output der buffer too short");
                ret = WOLFSSL_FAILURE;
                goto cleanup;
            }
            ret = AddSignature(der, ret, x509->sig.buffer,
                               x509->sig.length, x509->sigOID);
        }

        *derSz = ret;
        ret = WOLFSSL_SUCCESS;
cleanup:
        /* Dispose of the public key object. */
    #ifndef NO_RSA
        if (x509->pubKeyOID == RSAk) {
            wc_FreeRsaKey(rsa);
            XFREE(rsa, NULL, DYNAMIC_TYPE_RSA);
        }
    #endif
    #ifdef HAVE_ECC
        if (x509->pubKeyOID == ECDSAk) {
            wc_ecc_free(ecc);
            XFREE(ecc, NULL, DYNAMIC_TYPE_ECC);
        }
    #endif
    #if defined(HAVE_ED25519) && defined(HAVE_ED25519_KEY_IMPORT)
        if (x509->pubKeyOID == ED25519k) {
            wolfSSL_ED25519_free(ed25519);
        }
    #endif
    #ifndef NO_DSA
        if (x509->pubKeyOID == DSAk) {
            wc_FreeDsaKey(dsa);
            XFREE(dsa, NULL, DYNAMIC_TYPE_DSA);
        }
    #endif
    #if defined(HAVE_FALCON)
        if ((x509->pubKeyOID == FALCON_LEVEL1k) ||
            (x509->pubKeyOID == FALCON_LEVEL5k)) {
            wc_falcon_free(falcon);
            XFREE(falcon, NULL, DYNAMIC_TYPE_FALCON);
        }
    #endif
    #if defined(WOLFSSL_HAVE_MLDSA)
        if ((x509->pubKeyOID == ML_DSA_44k) ||
            (x509->pubKeyOID == ML_DSA_65k) ||
            (x509->pubKeyOID == ML_DSA_87k)
        #ifdef WOLFSSL_MLDSA_FIPS204_DRAFT
         || (x509->pubKeyOID == DILITHIUM_LEVEL2k)
         || (x509->pubKeyOID == DILITHIUM_LEVEL3k)
         || (x509->pubKeyOID == DILITHIUM_LEVEL5k)
        #endif
        ) {
            wc_MlDsaKey_Free(mldsa);
            XFREE(mldsa, NULL, DYNAMIC_TYPE_MLDSA);
        }
    #endif
    #if defined(WOLFSSL_HAVE_SLHDSA)
        /* wc_IsSlhDsaOid returns 1 even for OIDs whose backend is
         * NOT_COMPILED_IN; the early-return at the top of the SLH-DSA
         * branch keeps slhdsa==NULL in that case. Guard the cleanup so
         * future restructuring (a goto cleanup from inside the
         * unbuilt-variant handler) cannot dereference a NULL key. */
        if (wc_IsSlhDsaOid(x509->pubKeyOID) && slhdsa != NULL) {
            wc_SlhDsaKey_Free(slhdsa);
            XFREE(slhdsa, NULL, DYNAMIC_TYPE_SLHDSA);
        }
    #endif
        XFREE(cert, NULL, DYNAMIC_TYPE_CERT);

        return ret;
    }


    /* signs a der buffer for the WOLFSSL_X509 structure using the PKEY and MD
     * hash passed in
     *
     * WARNING: this free's and replaces the existing DER buffer in the
     *          WOLFSSL_X509 with the newly signed buffer.
     * returns size of signed buffer on success and negative values on fail
     */
    static int wolfSSL_X509_resign_cert(WOLFSSL_X509* x509, int req,
            unsigned char* der, int derSz, int certBodySz, WOLFSSL_EVP_MD* md,
            WOLFSSL_EVP_PKEY* pkey)
    {
        int ret;
        void* key = NULL;
        int type = -1;
        int sigType;
        WC_RNG rng;
    #ifdef WOLFSSL_MLDSA_X509_SIGN
        wc_MlDsaKey* mldsa = NULL;
    #endif

        (void)req;
        WOLFSSL_ENTER("wolfSSL_X509_resign_cert");

        sigType = wolfSSL_sigTypeFromPKEY(md, pkey);
        if (sigType == WC_NO_ERR_TRACE(WOLFSSL_FAILURE)) {
            WOLFSSL_MSG("Error getting signature type from pkey");
            return WOLFSSL_FATAL_ERROR;
        }


        /* Get the private key object and type from pkey. */
    #ifndef NO_RSA
        if (pkey->type == WC_EVP_PKEY_RSA) {
            type = RSA_TYPE;
            key = pkey->rsa->internal;
        }
    #endif
    #ifdef HAVE_ECC
        if (pkey->type == WC_EVP_PKEY_EC) {
            type = ECC_TYPE;
            key = pkey->ecc->internal;
        }
    #endif
    #ifdef WOLFSSL_MLDSA_X509_SIGN
        if (pkey->type == WC_EVP_PKEY_DILITHIUM) {
            /* Decode the ML-DSA private key held as DER in pkey.ptr. */
            word32 idx = 0;
            int oidSum = 0;
            int decRet;

            mldsa = (wc_MlDsaKey*)XMALLOC(sizeof(wc_MlDsaKey), x509->heap,
                    DYNAMIC_TYPE_MLDSA);
            if (mldsa == NULL) {
                WOLFSSL_MSG("Failed to allocate memory for wc_MlDsaKey");
                return WOLFSSL_FATAL_ERROR;
            }
            if (wc_MlDsaKey_Init(mldsa, x509->heap, INVALID_DEVID) != 0) {
                WOLFSSL_MSG("wc_MlDsaKey_Init error");
                XFREE(mldsa, x509->heap, DYNAMIC_TYPE_MLDSA);
                return WOLFSSL_FATAL_ERROR;
            }
            PRIVATE_KEY_UNLOCK();
            decRet = wc_MlDsaKey_PrivateKeyDecode(mldsa,
                    (const byte*)pkey->pkey.ptr, (word32)pkey->pkey_sz,
                    &idx);
            PRIVATE_KEY_LOCK();
            /* Map the parameter set to its OID with mldsa_get_oid_sum():
             * unlike wc_MlDsaKey_GetParams() it distinguishes FIPS204-draft
             * levels. */
            if (decRet != 0 ||
                    mldsa_get_oid_sum(mldsa, &oidSum) != 0) {
                WOLFSSL_MSG("Error decoding ML-DSA private key");
                wc_MlDsaKey_Free(mldsa);
                XFREE(mldsa, x509->heap, DYNAMIC_TYPE_MLDSA);
                return WOLFSSL_FATAL_ERROR;
            }
            /* sigType above came from the cached pkey->mldsaOID; require
             * the decoded key to agree so a stale cache cannot emit a
             * certificate whose signatureAlgorithm disagrees with the
             * actual signature. */
            if (oidSum != WOLFSSL_ATOMIC_LOAD(pkey->mldsaOID)) {
                WOLFSSL_MSG("ML-DSA key does not match cached pkey OID");
                wc_MlDsaKey_Free(mldsa);
                XFREE(mldsa, x509->heap, DYNAMIC_TYPE_MLDSA);
                return WOLFSSL_FATAL_ERROR;
            }
            switch (oidSum) {
                case ML_DSA_44k:
                    type = ML_DSA_44_TYPE;
                    break;
                case ML_DSA_65k:
                    type = ML_DSA_65_TYPE;
                    break;
                case ML_DSA_87k:
                    type = ML_DSA_87_TYPE;
                    break;
            #ifdef WOLFSSL_MLDSA_FIPS204_DRAFT
                case DILITHIUM_LEVEL2k:
                    type = DILITHIUM_LEVEL2_TYPE;
                    break;
                case DILITHIUM_LEVEL3k:
                    type = DILITHIUM_LEVEL3_TYPE;
                    break;
                case DILITHIUM_LEVEL5k:
                    type = DILITHIUM_LEVEL5_TYPE;
                    break;
            #endif
                default:
                    WOLFSSL_MSG("Unsupported ML-DSA parameter set");
                    wc_MlDsaKey_Free(mldsa);
                    XFREE(mldsa, x509->heap, DYNAMIC_TYPE_MLDSA);
                    return WOLFSSL_FATAL_ERROR;
            }
            key = mldsa;
        }
    #endif /* WOLFSSL_MLDSA_X509_SIGN */
    #if defined(HAVE_ED25519)
        if (pkey->type == WC_EVP_PKEY_ED25519) {
            /* Reject a missing key here, as the other Ed25519 entry points do,
             * so a public-only or uninitialised EVP_PKEY fails clearly instead
             * of reaching wc_SignCert_ex() with a NULL key and coming back as
             * an algorithm-id error. */
            if (pkey->ed25519 == NULL) {
                WOLFSSL_MSG("No Ed25519 key in EVP_PKEY");
                return WOLFSSL_FATAL_ERROR;
            }
            type = ED25519_TYPE;
            key = pkey->ed25519;
        }
    #endif

        /* Sign the certificate (request) body. */
        ret = wc_InitRng(&rng);
        if (ret != 0) {
        #ifdef WOLFSSL_MLDSA_X509_SIGN
            if (mldsa != NULL) {
                wc_MlDsaKey_Free(mldsa);
                XFREE(mldsa, x509->heap, DYNAMIC_TYPE_MLDSA);
            }
        #endif
            return ret;
        }
        ret = wc_SignCert_ex(certBodySz, sigType, der, (word32)derSz, type, key,
            &rng);
        wc_FreeRng(&rng);
    #ifdef WOLFSSL_MLDSA_X509_SIGN
        if (mldsa != NULL) {
            wc_MlDsaKey_Free(mldsa);
            XFREE(mldsa, x509->heap, DYNAMIC_TYPE_MLDSA);
        }
    #endif
        if (ret < 0) {
            WOLFSSL_LEAVE("wolfSSL_X509_resign_cert", ret);
            return ret;
        }
        derSz = ret;

        /* Extract signature from buffer */
        {
            word32 idx = 0;
            int    len = 0;

            /* Read top level sequence */
            if (GetSequence(der, &idx, &len, (word32)derSz) < 0) {
                WOLFSSL_MSG("GetSequence error");
                return WOLFSSL_FATAL_ERROR;
            }
            /* Move idx to signature */
            idx += certBodySz;
            /* Read signature algo sequence */
            if (GetSequence(der, &idx, &len, (word32)derSz) < 0) {
                WOLFSSL_MSG("GetSequence error");
                return WOLFSSL_FATAL_ERROR;
            }
            idx += len;
            /* Read signature bit string */
            if (CheckBitString(der, &idx, &len, (word32)derSz, 0, NULL) != 0) {
                WOLFSSL_MSG("CheckBitString error");
                return WOLFSSL_FATAL_ERROR;
            }
            /* Sanity check */
            if (idx + len != (word32)derSz) {
                WOLFSSL_MSG("unexpected asn1 structure");
                return WOLFSSL_FATAL_ERROR;
            }
            x509->sig.length = 0;
            if (x509->sig.buffer)
                XFREE(x509->sig.buffer, x509->heap, DYNAMIC_TYPE_SIGNATURE);
            x509->sig.buffer = (byte*)XMALLOC(len, x509->heap,
                                              DYNAMIC_TYPE_SIGNATURE);
            if (!x509->sig.buffer) {
                WOLFSSL_MSG("malloc error");
                return WOLFSSL_FATAL_ERROR;
            }
            XMEMCPY(x509->sig.buffer, der + idx, len);
            x509->sig.length = (unsigned int)len;
        }

        /* Put in the new certificate encoding into the x509 object. */
        FreeDer(&x509->derCert);
        type = CERT_TYPE;
    #ifdef WOLFSSL_CERT_REQ
        if (req) {
            type = CERTREQ_TYPE;
        }
    #endif
        if (AllocDer(&x509->derCert, (word32)derSz, type, NULL) != 0)
            return WOLFSSL_FATAL_ERROR;
        XMEMCPY(x509->derCert->buffer, der, derSz);
        x509->derCert->length = (word32)derSz;

        return ret;
    }


#ifndef WC_MAX_X509_GEN
    /* able to override max size until dynamic buffer created */
    #define WC_MAX_X509_GEN 4096
#endif
#if defined(WOLFSSL_HAVE_MLDSA) && !defined(WC_MAX_X509_GEN_MLDSA)
    /* Base size plus the largest compiled-in ML-DSA signature and its
     * ASN.1 overhead; the subject key is added in x509_gen_buf_sz(). */
    #define WC_MAX_X509_GEN_MLDSA \
        (WC_MAX_X509_GEN + MLDSA_MAX_SIG_SIZE + MAX_ALGO_SZ + \
         MAX_SEQ_SZ * 2)
#endif

/* DER buffer size for certificate/CSR signing: chosen from the signing
 * key type, plus the subject public key held in the x509 so that a
 * large (e.g. ML-DSA) SPKI fits under a classic signing key too. */
static int x509_gen_buf_sz(const WOLFSSL_X509* x509,
    const WOLFSSL_EVP_PKEY* pkey)
{
    int sz = WC_MAX_X509_GEN;

#ifdef WOLFSSL_HAVE_MLDSA
    if (pkey != NULL && pkey->type == WC_EVP_PKEY_DILITHIUM) {
        sz = WC_MAX_X509_GEN_MLDSA;
    }
#else
    (void)pkey;
#endif
    return sz + (int)x509->pubKey.length;
}

/* returns the size of signature on success */
int wolfSSL_X509_sign(WOLFSSL_X509* x509, WOLFSSL_EVP_PKEY* pkey,
        const WOLFSSL_EVP_MD* md)
{
    int  ret;
    byte *der = NULL;
    int  bufSz = 0;
    int  derSz = 0;
    int  sigType;

    WOLFSSL_ENTER("wolfSSL_X509_sign");

    if (x509 == NULL || pkey == NULL) {
        ret = WOLFSSL_FAILURE;
        goto out;
    }

    bufSz = x509_gen_buf_sz(x509, pkey);
    derSz = bufSz;
    der = (byte *)XMALLOC((size_t)bufSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
    if (der == NULL) {
        ret = WOLFSSL_FAILURE;
        goto out;
    }

    /* Resolves the (pkey, md) combination - most key types require an explicit
     * digest, Ed25519 requires a NULL one, ML-DSA ignores it - and only
     * updates sigOID on success, so the object is unmodified on a rejected
     * key/md combination. */
    sigType = wolfSSL_sigTypeFromPKEY((WOLFSSL_EVP_MD*)md, pkey);
    if (sigType == WC_NO_ERR_TRACE(WOLFSSL_FAILURE)) {
        WOLFSSL_MSG("Unsupported key/md combination for signing");
        ret = WOLFSSL_FAILURE;
        goto out;
    }
    x509->sigOID = sigType;
    if ((ret = wolfssl_x509_make_der(x509, 0, der, &derSz, 0)) !=
            WOLFSSL_SUCCESS) {
        WOLFSSL_MSG("Unable to make DER for X509");
        WOLFSSL_LEAVE("wolfSSL_X509_sign", ret);
        (void)ret;
        ret = WOLFSSL_FAILURE;
        goto out;
    }

    ret = wolfSSL_X509_resign_cert(x509, 0, der, bufSz, derSz,
            (WOLFSSL_EVP_MD*)md, pkey);
    if (ret <= 0) {
        WOLFSSL_LEAVE("wolfSSL_X509_sign", ret);
        ret = WOLFSSL_FAILURE;
        goto out;
    }

out:
    XFREE(der, NULL, DYNAMIC_TYPE_TMP_BUFFER);

    return ret;
}

#if defined(OPENSSL_EXTRA)
int wolfSSL_X509_sign_ctx(WOLFSSL_X509 *x509, WOLFSSL_EVP_MD_CTX *ctx)
{
    WOLFSSL_ENTER("wolfSSL_X509_sign_ctx");

    if (!x509 || !ctx || !ctx->pctx || !ctx->pctx->pkey) {
        WOLFSSL_MSG("Bad parameter");
        return WOLFSSL_FAILURE;
    }

    return wolfSSL_X509_sign(x509, ctx->pctx->pkey,
        wolfSSL_EVP_MD_CTX_md(ctx));
}
#endif /* OPENSSL_EXTRA */
#endif /* WOLFSSL_CERT_GEN */


#if defined(OPENSSL_ALL) || defined(OPENSSL_EXTRA) || \
    defined(OPENSSL_EXTRA_X509_SMALL) || defined(WOLFSSL_WPAS_SMALL)
/* Converts from WC_NID_* value to wolfSSL value if needed.
 *
 * @param [in] nid  Numeric Id of a domain name component.
 * @return  Domain name tag values - wolfSSL internal values.
 * @return  -1 when nid isn't known.
 */
static int ConvertNIDToWolfSSL(int nid)
{
    switch (nid) {
        case WC_NID_commonName : return ASN_COMMON_NAME;
    #ifdef WOLFSSL_CERT_NAME_ALL
        case WC_NID_name :       return ASN_NAME;
        case WC_NID_givenName:   return ASN_GIVEN_NAME;
        case WC_NID_dnQualifier :   return ASN_DNQUALIFIER;
        case WC_NID_initials:   return ASN_INITIALS;
    #endif /* WOLFSSL_CERT_NAME_ALL */
        case WC_NID_surname :    return ASN_SUR_NAME;
        case WC_NID_countryName: return ASN_COUNTRY_NAME;
        case WC_NID_localityName: return ASN_LOCALITY_NAME;
        case WC_NID_stateOrProvinceName: return ASN_STATE_NAME;
        case WC_NID_streetAddress: return ASN_STREET_ADDR;
        case WC_NID_organizationName: return ASN_ORG_NAME;
        case WC_NID_organizationalUnitName: return ASN_ORGUNIT_NAME;
        case WC_NID_emailAddress: return ASN_EMAIL_NAME;
        case WC_NID_pkcs9_contentType: return ASN_CONTENT_TYPE;
        case WC_NID_serialNumber: return ASN_SERIAL_NUMBER;
        case WC_NID_userId: return ASN_USER_ID;
        case WC_NID_x500UniqueIdentifier: return ASN_X500_UNIQUE_ID;
        case WC_NID_businessCategory: return ASN_BUS_CAT;
        case WC_NID_domainComponent: return ASN_DOMAIN_COMPONENT;
        case WC_NID_postalCode: return ASN_POSTAL_CODE;
        case WC_NID_rfc822Mailbox: return ASN_RFC822_MAILBOX;
        case WC_NID_favouriteDrink: return ASN_FAVOURITE_DRINK;
        default:
            WOLFSSL_MSG("Attribute NID not found");
            return WOLFSSL_FATAL_ERROR;
    }
}
#endif /* OPENSSL_ALL || OPENSSL_EXTRA ||
          OPENSSL_EXTRA_X509_SMALL || WOLFSSL_WPAS_SMALL*/

#if defined(OPENSSL_ALL) || defined(OPENSSL_EXTRA) || \
    defined(OPENSSL_EXTRA_X509_SMALL)
/* This is to convert the x509 name structure into canonical DER format     */
/*  , which has the following rules:                                        */
/*   convert to UTF8                                                        */
/*   convert to lower case                                                  */
/*   multi-spaces collapsed                                                 */
/*   leading SEQUENCE header is skipped                                     */
/* @param  name a pointer to X509_NAME that is to be converted              */
/* @param  out  a pointer to converted data                                 */
/* @return a number of converted bytes, otherwise <=0 error code            */
int wolfSSL_i2d_X509_NAME_canon(WOLFSSL_X509_NAME* name, unsigned char** out)
{
    int  totalBytes = 0, i, idx;
    byte *output, *local = NULL;
    WC_DECLARE_VAR(names, EncodedName, MAX_NAME_ENTRIES, 0);

    if (name == NULL)
        return BAD_FUNC_ARG;

    WC_ALLOC_VAR_EX(names, EncodedName, MAX_NAME_ENTRIES, NULL,
        DYNAMIC_TYPE_TMP_BUFFER, return MEMORY_E);

    XMEMSET(names, 0, sizeof(EncodedName) * MAX_NAME_ENTRIES);

    for (i = 0; i < MAX_NAME_ENTRIES; i++) {
        WOLFSSL_X509_NAME_ENTRY* entry;
        int ret;

        entry = wolfSSL_X509_NAME_get_entry(name, i);
        if (entry != NULL && entry->set >= 1) {
            const char* nameStr;
            WOLFSSL_ASN1_STRING* data;
            WOLFSSL_ASN1_STRING* cano_data;

            cano_data = wolfSSL_ASN1_STRING_new();
            if (cano_data == NULL) {
                WC_FREE_VAR_EX(names, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                return MEMORY_E;
            }

            data = wolfSSL_X509_NAME_ENTRY_get_data(entry);
            if (data == NULL) {
                WC_FREE_VAR_EX(names, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                wolfSSL_ASN1_STRING_free(cano_data);
                WOLFSSL_MSG("Error getting entry data");
                return WOLFSSL_FATAL_ERROR;
            }
            if (wolfSSL_ASN1_STRING_canon(cano_data, data) != WOLFSSL_SUCCESS) {
                WC_FREE_VAR_EX(names, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                wolfSSL_ASN1_STRING_free(cano_data);
                return WOLFSSL_FAILURE;
            }
            nameStr = (const char*)wolfSSL_ASN1_STRING_data(cano_data);

            /* allow for blank values in the name structure, eg OU= */
            if (nameStr)
            {
                ret = wc_EncodeNameCanonical(&names[i], nameStr, CTC_UTF8,
                    (byte)ConvertNIDToWolfSSL(entry->nid));
                if (ret < 0) {
                    WC_FREE_VAR_EX(names, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                    wolfSSL_ASN1_STRING_free(cano_data);
                    WOLFSSL_MSG("EncodeName failed");
                    return WOLFSSL_FATAL_ERROR;
                }
                totalBytes += ret;
            }

            wolfSSL_ASN1_STRING_free(cano_data);
        }
    }

    if (out == NULL) {
        /* If out is NULL, caller just wants length. */
        WC_FREE_VAR_EX(names, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        return totalBytes;
    }

    /* skip header */
    /* check if using buffer passed in */
    if (*out == NULL) {
        *out = local = (unsigned char*)XMALLOC(totalBytes, NULL,
                DYNAMIC_TYPE_OPENSSL);
        if (*out == NULL) {
            return MEMORY_E;
        }
    }
    output = *out;
    idx = 0;

    for (i = 0; i < MAX_NAME_ENTRIES; i++) {
        if (names[i].used) {
            XMEMCPY(output + idx, names[i].encoded, names[i].totalLen);
            idx += names[i].totalLen;
        }
    }

    WC_FREE_VAR_EX(names, NULL, DYNAMIC_TYPE_TMP_BUFFER);

    /* used existing buffer passed in, so increment pointer */
    if (local == NULL) {
        *out += totalBytes;
    }
    return totalBytes;
}
#endif /* OPENSSL_ALL || OPENSSL_EXTRA || OPENSSL_EXTRA_X509_SMALL */

#ifdef WOLFSSL_CERT_GEN
/* Guarded by either
 * A) WOLFSSL_WPAS_SMALL is on or
 * B) (OPENSSL_EXTRA or OPENSSL_EXTRA_X509_SMALL) + WOLFSSL_CERT_GEN +
 *    (WOLFSSL_CERT_REQ or WOLFSSL_CERT_EXT or OPENSSL_EXTRA) has been
 *    defined
 */
#if defined(WOLFSSL_WPAS_SMALL) || \
    (defined(OPENSSL_EXTRA) || defined(OPENSSL_EXTRA_X509_SMALL)) && \
    defined(WOLFSSL_CERT_GEN) && \
    (defined(WOLFSSL_CERT_REQ) || defined(WOLFSSL_CERT_EXT) || \
     defined(OPENSSL_EXTRA))

/* Converts the x509 name structure into DER format.
 *
 * out  pointer to either a pre setup buffer or a pointer to null for
 *      creating a dynamic buffer. In the case that a pre-existing buffer is
 *      used out will be incremented the size of the DER buffer on success. If
 *      out is NULL, the function returns the necessary output buffer length.
 *
 * returns the size of the buffer on success, or negative value with failure
 */
int wolfSSL_i2d_X509_NAME(WOLFSSL_X509_NAME* name, unsigned char** out)
{
    int  totalBytes = 0, i, idx;
    byte temp[MAX_SEQ_SZ];
    byte *output, *local = NULL;
    WC_DECLARE_VAR(names, EncodedName, MAX_NAME_ENTRIES, 0);

    if (name == NULL)
        return BAD_FUNC_ARG;

    WC_ALLOC_VAR_EX(names, EncodedName, MAX_NAME_ENTRIES, NULL,
        DYNAMIC_TYPE_TMP_BUFFER, return MEMORY_E);

    XMEMSET(names, 0, sizeof(EncodedName) * MAX_NAME_ENTRIES);

    for (i = 0; i < MAX_NAME_ENTRIES; i++) {
        WOLFSSL_X509_NAME_ENTRY* entry;
        int ret;

        entry = wolfSSL_X509_NAME_get_entry(name, i);
        if (entry != NULL && entry->set >= 1) {
            const char* nameStr;
            int type;
            WOLFSSL_ASN1_STRING* data;

            data = wolfSSL_X509_NAME_ENTRY_get_data(entry);
            if (data == NULL) {
                WC_FREE_VAR_EX(names, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                WOLFSSL_MSG("Error getting entry data");
                return WOLFSSL_FATAL_ERROR;
            }

            nameStr = (const char*)wolfSSL_ASN1_STRING_data(data);
            type    = wolfSSL_ASN1_STRING_type(data);

            switch (type) {
                case WOLFSSL_MBSTRING_UTF8:
                    type = CTC_UTF8;
                    break;
                case WOLFSSL_MBSTRING_ASC:
                case WOLFSSL_V_ASN1_PRINTABLESTRING:
                    type = CTC_PRINTABLE;
                    break;
                default:
                    WOLFSSL_MSG(
                        "Unknown encoding type conversion UTF8 by default");
                    type = CTC_UTF8;
            }
            ret = wc_EncodeName(&names[i], nameStr, (char)type,
                (byte)ConvertNIDToWolfSSL(entry->nid));
            if (ret < 0) {
                WC_FREE_VAR_EX(names, NULL, DYNAMIC_TYPE_TMP_BUFFER);
                WOLFSSL_MSG("EncodeName failed");
                return WOLFSSL_FATAL_ERROR;
            }
            totalBytes += ret;
        }
    }

    /* header */
    idx = (int)SetSequence((word32)totalBytes, temp);
    if (totalBytes + idx > ASN_NAME_MAX) {
        WC_FREE_VAR_EX(names, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        WOLFSSL_MSG("Total Bytes is greater than ASN_NAME_MAX");
        return BUFFER_E;
    }

    if (out == NULL) {
        /* If out is NULL, caller just wants length. */
        totalBytes += idx;
        WC_FREE_VAR_EX(names, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        return totalBytes;
    }

    /* check if using buffer passed in */
    if (*out == NULL) {
        *out = local = (unsigned char*)XMALLOC(totalBytes + idx, name->heap,
                DYNAMIC_TYPE_OPENSSL);
        if (*out == NULL) {
            return MEMORY_E;
        }
    }
    output = *out;

    idx = (int)SetSequence((word32)totalBytes, output);
    totalBytes += idx;
    for (i = 0; i < MAX_NAME_ENTRIES; i++) {
        if (names[i].used) {
            XMEMCPY(output + idx, names[i].encoded, names[i].totalLen);
            idx += names[i].totalLen;
        }
    }

    WC_FREE_VAR_EX(names, NULL, DYNAMIC_TYPE_TMP_BUFFER);

    /* used existing buffer passed in, so increment pointer */
    if (local == NULL) {
        *out += totalBytes;
    }
    return totalBytes;
}
#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL */
#endif /* WOLFSSL_CERT_GEN */

#if defined(OPENSSL_EXTRA) || defined(OPENSSL_ALL) || \
    defined (WOLFSSL_WPAS_SMALL)

    WOLFSSL_X509_NAME *wolfSSL_d2i_X509_NAME(WOLFSSL_X509_NAME **name,
                                             unsigned char **in, long length)
    {
        WOLFSSL_X509_NAME* tmp = NULL;
        WC_DECLARE_VAR(cert, DecodedCert, 1, 0);

        WOLFSSL_ENTER("wolfSSL_d2i_X509_NAME");

        if (!in || !*in || length <= 0) {
            WOLFSSL_MSG("Bad argument");
            return NULL;
        }

        WC_ALLOC_VAR_EX(cert, DecodedCert, 1, NULL, DYNAMIC_TYPE_DCERT,
            return NULL);

        /* Set the X509_NAME buffer as the input data for cert.
         * in is NOT a full certificate. Just the name. */
        InitDecodedCert(cert, *in, (word32)length, NULL);

        /* Parse the X509 subject name */
        if (GetName(cert, ASN_SUBJECT, (int)length) != 0) {
            WOLFSSL_MSG("WOLFSSL_X509_NAME parse error");
            goto cleanup;
        }

        if (!(tmp = wolfSSL_X509_NAME_new_ex(cert->heap))) {
            WOLFSSL_MSG("wolfSSL_X509_NAME_new_ex error");
            goto cleanup;
        }

        if (wolfSSL_X509_NAME_copy((WOLFSSL_X509_NAME*)cert->subjectName,
                    tmp) != WOLFSSL_SUCCESS) {
            wolfSSL_X509_NAME_free(tmp);
            tmp = NULL;
            goto cleanup;
        }

        if (name)
            *name = tmp;
cleanup:
        FreeDecodedCert(cert);
        WC_FREE_VAR_EX(cert, NULL, DYNAMIC_TYPE_DCERT);
        return tmp;
    }
#endif /* OPENSSL_EXTRA || OPENSSL_ALL || WOLFSSL_WPAS_SMALL */


#if defined(OPENSSL_EXTRA) || defined(OPENSSL_ALL)

    /* Compares the two X509 names. If the size of x is larger then y then a
     * positive value is returned if x is smaller a negative value is returned.
     * In the case that the sizes are equal a the value of strcmp between the
     * two names is returned.
     *
     * x First name for comparison
     * y Second name to compare with x
     */
    int wolfSSL_X509_NAME_cmp(const WOLFSSL_X509_NAME* x,
            const WOLFSSL_X509_NAME* y)
    {
        const char* _x;
        const char* _y;
        WOLFSSL_ENTER("wolfSSL_X509_NAME_cmp");

        if (x == NULL || y == NULL) {
            WOLFSSL_MSG("Bad argument passed in");
            return -2;
        }

        if (x == y) {
            return 0; /* match */
        }

        if (x->sz != y->sz) {
            return x->sz - y->sz;
        }

        /*
         * If the name member is not set or is immediately null terminated then
         * compare the staticName member
         */
        _x = (x->name && *x->name) ? x->name : x->staticName;
        _y = (y->name && *y->name) ? y->name : y->staticName;

        return XSTRNCASECMP(_x, _y, x->sz); /* y sz is the same */
    }

#ifndef NO_BIO

static WOLFSSL_X509 *loadX509orX509REQFromPemBio(WOLFSSL_BIO *bp,
        WOLFSSL_X509 **x, wc_pem_password_cb *cb, void *u, int type)
{
    WOLFSSL_X509* x509 = NULL;
#if defined(WOLFSSL_PEM_TO_DER) || defined(WOLFSSL_DER_TO_PEM)
    unsigned char* pem = NULL;
    int pemSz;
    long  i = 0, l, footerSz;
    const char* footer = NULL;
    int streaming = 0;  /* Flag to indicate if source is streaming (FIFO) */
    const char* altFooter = NULL;
    long altFooterSz = 0;

    WOLFSSL_ENTER("loadX509orX509REQFromPemBio");

    if (bp == NULL || (type != CERT_TYPE && type != CERTREQ_TYPE &&
                       type != TRUSTED_CERT_TYPE)) {
        WOLFSSL_LEAVE("wolfSSL_PEM_read_bio_X509", BAD_FUNC_ARG);
        return NULL;
    }

    if ((l = wolfSSL_BIO_get_len(bp)) <= 0) {
        /* No certificate size available - could be FIFO or other streaming
         * source. Use MAX_X509_SIZE as initial buffer, will resize if needed. */
        l = MAX_X509_SIZE;
        streaming = 1;
    }

    pemSz = (int)l;
    pem   = (unsigned char*)XMALLOC(pemSz, 0, DYNAMIC_TYPE_PEM);
    if (pem == NULL)
        return NULL;
    XMEMSET(pem, 0, pemSz);

    i = 0;
    if (wc_PemGetHeaderFooter(type, NULL, &footer) != 0) {
        XFREE(pem, 0, DYNAMIC_TYPE_PEM);
        return NULL;
    }
    footerSz = (long)XSTRLEN(footer);

    /* For TRUSTED_CERT_TYPE, also prepare to check for regular CERT footer
     * as the file might contain regular certificates instead of TRUSTED
     * format */
    if (type == TRUSTED_CERT_TYPE) {
        wc_PemGetHeaderFooter(CERT_TYPE, NULL, &altFooter);
        if (altFooter != NULL) {
            altFooterSz = (long)XSTRLEN(altFooter);
        }
    }

    /* TODO: Inefficient
     * reading in one byte at a time until see the footer
     */
    while ((l = wolfSSL_BIO_read(bp, (char *)&pem[i], 1)) == 1) {
        int foundFooter = 0;
        i++;
        /* Check if buffer is full and we're reading from streaming source */
        if (i >= pemSz && streaming) {
            /* Double the buffer size for streaming sources */
            int newSz = pemSz * 2;
            unsigned char* newPem;

            /* Sanity check: don't grow beyond reasonable limit */
            if (newSz > MAX_BIO_READ_BUFFER) {
                WOLFSSL_MSG("PEM data too large for streaming source");
                XFREE(pem, 0, DYNAMIC_TYPE_PEM);
                return NULL;
            }

            newPem = (unsigned char*)XREALLOC(pem, newSz, 0, DYNAMIC_TYPE_PEM);
            if (newPem == NULL) {
                WOLFSSL_MSG("Failed to resize PEM buffer");
                XFREE(pem, 0, DYNAMIC_TYPE_PEM);
                return NULL;
            }

            pem = newPem;
            pemSz = newSz;
        }
        else if (i >= pemSz) {
            /* Buffer full for non-streaming source - this shouldn't happen */
            break;
        }

        /* Check for the expected footer OR alternate footer (for
         * TRUSTED_CERT_TYPE) */
        if (i > footerSz &&
            XMEMCMP((char *)&pem[i-footerSz], footer, footerSz) == 0) {
            foundFooter = 1;
        }
        else if (i > altFooterSz && altFooter != NULL &&
            XMEMCMP((char *)&pem[i-altFooterSz], altFooter, altFooterSz) == 0) {
            foundFooter = 1;
        }

        if (foundFooter) {
            if (i < pemSz && wolfSSL_BIO_read(bp, (char *)&pem[i], 1) == 1) {
                /* attempt to read newline following footer */
                i++;
                if (i < pemSz && pem[i-1] == '\r') {
                    /* found \r , Windows line ending is \r\n so try to read one
                     * more byte for \n, ignoring return value */
                    (void)wolfSSL_BIO_read(bp, (char *)&pem[i++], 1);
                }
            }
            break;
        }
    }
    if (l == 0 && i == 0) {
        WOLFSSL_ERROR(ASN_NO_PEM_HEADER);
    }
    if (i > pemSz) {
        WOLFSSL_MSG("Error parsing PEM");
    }
    else {
        pemSz = (int)i;
    #ifdef WOLFSSL_CERT_REQ
        if (type == CERTREQ_TYPE)
            x509 = loadX509orX509REQFromBuffer(pem, pemSz, WOLFSSL_FILETYPE_PEM,
                CERTREQ_TYPE, cb, u);
        else
    #endif
        /* Use TRUSTED_CERT_TYPE if input was TRUSTED CERTIFICATE format,
         * otherwise use CERT_TYPE for regular certificates */
        if (type == TRUSTED_CERT_TYPE)
            x509 = loadX509orX509REQFromBuffer(pem, pemSz, WOLFSSL_FILETYPE_PEM,
                TRUSTED_CERT_TYPE, cb, u);
        else
            x509 = loadX509orX509REQFromBuffer(pem, pemSz, WOLFSSL_FILETYPE_PEM,
                CERT_TYPE, cb, u);
    }

    if (x != NULL) {
        *x = x509;
    }

    XFREE(pem, NULL, DYNAMIC_TYPE_PEM);

#endif /* WOLFSSL_PEM_TO_DER || WOLFSSL_DER_TO_PEM */
    (void)bp;
    (void)x;
    (void)cb;
    (void)u;

    return x509;
}


WC_MAYBE_UNUSED
static unsigned char* ReadPemFromBioToBuffer(WOLFSSL_BIO *bp, int *pemSz)
{
    unsigned char* pem = NULL;

    WOLFSSL_ENTER("ReadPemFromBioToBuffer");

    if (bp == NULL || pemSz == NULL) {
        WOLFSSL_LEAVE("ReadPemFromBioToBuffer", BAD_FUNC_ARG);
        return NULL;
    }

    if ((*pemSz = wolfSSL_BIO_get_len(bp)) <= 0) {
        /* No certificate size available - could be FIFO or other streaming
         * source. Use MAX_X509_SIZE as initial buffer, read in loop. */
        int totalRead = 0;
        int readSz;

        *pemSz = MAX_X509_SIZE;
        pem = (unsigned char*)XMALLOC(*pemSz, 0, DYNAMIC_TYPE_PEM);
        if (pem == NULL) {
            return NULL;
        }

        /* Read from streaming source until EOF or buffer full */
        while ((readSz = wolfSSL_BIO_read(bp, pem + totalRead,
                                          *pemSz - totalRead)) > 0) {
            totalRead += readSz;

            /* If buffer is full, try to grow it */
            if (totalRead >= *pemSz) {
                int newSz = *pemSz * 2;
                unsigned char* newPem;

                /* Sanity check */
                if (newSz > MAX_BIO_READ_BUFFER) {
                    WOLFSSL_MSG("PEM data too large for streaming source");
                    XFREE(pem, NULL, DYNAMIC_TYPE_PEM);
                    return NULL;
                }

                newPem = (unsigned char*)XREALLOC(pem, newSz, 0,
                        DYNAMIC_TYPE_PEM);
                if (newPem == NULL) {
                    XFREE(pem, NULL, DYNAMIC_TYPE_PEM);
                    return NULL;
                }
                pem = newPem;
                *pemSz = newSz;
            }
        }

        *pemSz = totalRead;
        if (*pemSz <= 0) {
            XFREE(pem, NULL, DYNAMIC_TYPE_PEM);
            return NULL;
        }
    }
    else {
        /* Known size - allocate and read */
        pem = (unsigned char*)XMALLOC(*pemSz, 0, DYNAMIC_TYPE_PEM);
        if (pem == NULL) {
            return NULL;
        }

        XMEMSET(pem, 0, *pemSz);

        *pemSz = wolfSSL_BIO_read(bp, pem, *pemSz);
        if (*pemSz <= 0) {
            XFREE(pem, NULL, DYNAMIC_TYPE_PEM);
            return NULL;
        }
    }

    WOLFSSL_LEAVE("ReadPemFromBioToBuffer", 0);
    return pem;
}



#if defined(WOLFSSL_ACERT)
    WOLFSSL_X509_ACERT *wolfSSL_PEM_read_bio_X509_ACERT(WOLFSSL_BIO *bp,
                                                        WOLFSSL_X509_ACERT **x,
                                                        wc_pem_password_cb *cb,
                                                        void *u)
    {
        WOLFSSL_X509_ACERT* x509 = NULL;
#if defined(WOLFSSL_PEM_TO_DER) || defined(WOLFSSL_DER_TO_PEM)
        unsigned char * pem = NULL;
        int             pemSz;

        WOLFSSL_ENTER("wolfSSL_PEM_read_bio_X509_ACERT");

        if (bp == NULL) {
            return NULL;
        }

        pem = ReadPemFromBioToBuffer(bp, &pemSz);
        if (pem == NULL) {
            return NULL;
        }

        x509 = wolfSSL_X509_ACERT_load_certificate_buffer(pem, pemSz,
                                                          WOLFSSL_FILETYPE_PEM);

        if (x != NULL) {
            *x = x509;
        }

        XFREE(pem, NULL, DYNAMIC_TYPE_PEM);

#endif /* WOLFSSL_PEM_TO_DER || WOLFSSL_DER_TO_PEM */
        (void)bp;
        (void)x;
        (void)cb;
        (void)u;

        return x509;

    }
#endif /* WOLFSSL_ACERT */

    WOLFSSL_X509 *wolfSSL_PEM_read_bio_X509(WOLFSSL_BIO *bp, WOLFSSL_X509 **x,
                                            wc_pem_password_cb *cb, void *u)
    {
        return loadX509orX509REQFromPemBio(bp, x, cb, u, CERT_TYPE);
    }

    /*
     * bp : bio to read X509 from
     * x  : x509 to write to
     * cb : password call back for reading PEM
     * u  : password
     * _AUX is for working with a trusted X509 certificate
     */
    WOLFSSL_X509 *wolfSSL_PEM_read_bio_X509_AUX(WOLFSSL_BIO *bp,
                               WOLFSSL_X509 **x, wc_pem_password_cb *cb,
                               void *u)
    {
        WOLFSSL_ENTER("wolfSSL_PEM_read_bio_X509_AUX");

        /* AUX info is; trusted/rejected uses, friendly name, private key id,
         * and potentially a stack of "other" info. wolfSSL does not store
         * friendly name or private key id yet in WOLFSSL_X509 for human
         * readability and does not support extra trusted/rejected uses for
         * root CA. Use TRUSTED_CERT_TYPE to properly parse TRUSTED CERTIFICATE
         * format and strip auxiliary data. */
        return loadX509orX509REQFromPemBio(bp, x, cb, u, TRUSTED_CERT_TYPE);
    }

#ifdef WOLFSSL_CERT_REQ
WOLFSSL_X509 *wolfSSL_PEM_read_bio_X509_REQ(WOLFSSL_BIO *bp, WOLFSSL_X509 **x,
                                                wc_pem_password_cb *cb, void *u)
{
    return loadX509orX509REQFromPemBio(bp, x, cb, u, CERTREQ_TYPE);
}

#ifndef NO_FILESYSTEM
    WOLFSSL_X509* wolfSSL_PEM_read_X509_REQ(XFILE fp, WOLFSSL_X509** x,
                                            wc_pem_password_cb* cb, void* u)
    {
        int err = 0;
        WOLFSSL_X509* ret = NULL;
        WOLFSSL_BIO* bio = NULL;

        WOLFSSL_ENTER("wolfSSL_PEM_read_X509_REQ");

        if (fp == XBADFILE) {
            WOLFSSL_MSG("Invalid file.");
            err = 1;
        }

        if (err == 0) {
            bio = wolfSSL_BIO_new(wolfSSL_BIO_s_file());
            if (bio == NULL) {
                WOLFSSL_MSG("Failed to create new BIO with input file.");
                err = 1;
            }
        }
        if (err == 0 && wolfSSL_BIO_set_fp(bio, fp, WOLFSSL_BIO_CLOSE)
                != WOLFSSL_SUCCESS) {
            WOLFSSL_MSG("Failed to set BIO file pointer.");
            err = 1;
        }
        if (err == 0) {
            ret = wolfSSL_PEM_read_bio_X509_REQ(bio, x, cb, u);
        }

        wolfSSL_BIO_free(bio);

        return ret;
    }
#endif /* !NO_FILESYSTEM */
#endif /* WOLFSSL_CERT_REQ */

    WOLFSSL_X509_CRL *wolfSSL_PEM_read_bio_X509_CRL(WOLFSSL_BIO *bp,
            WOLFSSL_X509_CRL **x, wc_pem_password_cb *cb, void *u)
    {
#if defined(WOLFSSL_PEM_TO_DER) && defined(HAVE_CRL)
        WOLFSSL_X509_CRL* crl = NULL;

        WOLFSSL_ENTER("wolfSSL_PEM_read_bio_X509_CRL");

        /* OpenSSL's PEM_read_bio_X509_CRL skips intervening cert/key blocks
         * and returns the next CRL in the stream (NULL only at EOF). Mirror
         * that by looping over the per-block reader until we get a CRL or
         * the BIO has nothing left to parse. */
        for (;;) {
            WOLFSSL_X509*      x509   = NULL;
            WOLFSSL_X509_PKEY* x_pkey = NULL;
            if (wolfSSL_PEM_X509_X509_CRL_X509_PKEY_read_bio(bp, cb,
                        &x509, &crl, &x_pkey) != WOLFSSL_SUCCESS) {
                break;
            }
            if (crl != NULL) {
                break;
            }
            wolfSSL_X509_free(x509);
            wolfSSL_X509_PKEY_free(x_pkey);
        }

        if (x != NULL) {
            if (*x != NULL && *x != crl) {
                wolfSSL_X509_CRL_free(*x);
            }
            *x = crl;
        }

        (void)u;

        return crl;
#else
        (void)bp;
        (void)x;
        (void)cb;
        (void)u;

        return NULL;
#endif
    }

#endif /* !NO_BIO */

#if !defined(NO_FILESYSTEM)
static void* wolfSSL_PEM_read_X509_ex(XFILE fp, void **x,
    wc_pem_password_cb *cb, void *u, int type)
{
    unsigned char* pem = NULL;
    int pemSz;
    long i = 0, l;
    void *newx509;
    int derSz;
    DerBuffer* der = NULL;

    WOLFSSL_ENTER("wolfSSL_PEM_read_X509");

    if (fp == XBADFILE) {
        WOLFSSL_LEAVE("wolfSSL_PEM_read_X509", BAD_FUNC_ARG);
        return NULL;
    }
    /* Read cert from file */
    i = XFTELL(fp);
    if (i < 0) {
        WOLFSSL_LEAVE("wolfSSL_PEM_read_X509", BAD_FUNC_ARG);
        return NULL;
    }

    if (XFSEEK(fp, 0, XSEEK_END) != 0)
        return NULL;
    l = XFTELL(fp);
    if (l < 0)
        return NULL;
    if (XFSEEK(fp, i, SEEK_SET) != 0)
        return NULL;
    pemSz = (int)(l - i);

    /* check calculated length */
    if (pemSz > MAX_WOLFSSL_FILE_SIZE || pemSz <= 0) {
        WOLFSSL_MSG("PEM_read_X509_ex file size error");
        return NULL;
    }

    /* allocate pem buffer */
    pem = (unsigned char*)XMALLOC(pemSz, NULL, DYNAMIC_TYPE_PEM);
    if (pem == NULL)
        return NULL;

    if ((int)XFREAD((char *)pem, 1, (size_t)pemSz, fp) != pemSz)
        goto err_exit;

    switch (type) {
        case CERT_TYPE:
            newx509 = (void *)wolfSSL_X509_load_certificate_buffer(pem,
                pemSz, WOLFSSL_FILETYPE_PEM);
            break;

    #ifdef HAVE_CRL
        case CRL_TYPE:
            if ((PemToDer(pem, pemSz, CRL_TYPE, &der, NULL, NULL, NULL)) < 0)
                goto err_exit;
            derSz = (int)der->length;
            newx509 = (void*)wolfSSL_d2i_X509_CRL((WOLFSSL_X509_CRL **)x,
                (const unsigned char *)der->buffer, derSz);
            if (newx509 == NULL)
                goto err_exit;
            FreeDer(&der);
            break;
    #endif

        default:
            goto err_exit;
    }
    if (x != NULL) {
        *x = newx509;
    }
    XFREE(pem, NULL, DYNAMIC_TYPE_PEM);
    return newx509;

err_exit:
    XFREE(pem, NULL, DYNAMIC_TYPE_PEM);
    if (der != NULL)
        FreeDer(&der);

    /* unused */
    (void)cb;
    (void)u;
    (void)derSz;

    return NULL;
}

WOLFSSL_X509* wolfSSL_PEM_read_X509(XFILE fp, WOLFSSL_X509 **x,
                                                wc_pem_password_cb *cb, void *u)
{
    return (WOLFSSL_X509* )wolfSSL_PEM_read_X509_ex(fp, (void **)x, cb, u,
         CERT_TYPE);
}

#if defined(HAVE_CRL)
WOLFSSL_X509_CRL* wolfSSL_PEM_read_X509_CRL(XFILE fp,
                        WOLFSSL_X509_CRL **crl, wc_pem_password_cb *cb, void *u)
{
    return (WOLFSSL_X509_CRL* )wolfSSL_PEM_read_X509_ex(fp, (void **)crl, cb, u,
         CRL_TYPE);
}

/* Store CRL to file in DER or PEM format.
 * Returns WOLFSSL_SUCCESS on success, negative on failure.
 */
int wolfSSL_write_X509_CRL(WOLFSSL_X509_CRL* crl, const char* path, int type)
{
    int ret;
    WOLFSSL_ENTER("wolfSSL_write_X509_CRL");
    ret = StoreCRL(crl, path, type);
    WOLFSSL_LEAVE("wolfSSL_write_X509_CRL", ret);
    return ret;
}
#endif

#ifdef WOLFSSL_CERT_GEN
#ifndef NO_BIO
    int wolfSSL_PEM_write_X509(XFILE fp, WOLFSSL_X509* x)
    {
        int ret;
        WOLFSSL_BIO* bio;

        if (x == NULL || fp == XBADFILE)
            return 0;

        bio = wolfSSL_BIO_new(wolfSSL_BIO_s_file());
        if (bio == NULL)
            return 0;

        if (wolfSSL_BIO_set_fp(bio, fp, WOLFSSL_BIO_NOCLOSE) != WOLFSSL_SUCCESS) {
            wolfSSL_BIO_free(bio);
            bio = NULL;
        }

        ret = wolfSSL_PEM_write_bio_X509(bio, x);

        if (bio != NULL)
            wolfSSL_BIO_free(bio);

        return ret;
    }
#endif /* !NO_BIO */
#endif /* WOLFSSL_CERT_GEN */
#endif /* !NO_FILESYSTEM */

#endif /* OPENSSL_EXTRA || OPENSSL_ALL */
#if defined(OPENSSL_EXTRA) || defined(OPENSSL_ALL)

#ifndef NO_BIO
    /* create and return a new WOLFSSL_X509_PKEY structure or NULL on failure */
    static WOLFSSL_X509_PKEY* wolfSSL_X509_PKEY_new(void* heap)
    {
        WOLFSSL_X509_PKEY* ret;

        ret = (WOLFSSL_X509_PKEY*)XMALLOC(sizeof(WOLFSSL_X509_PKEY), heap,
            DYNAMIC_TYPE_KEY);
        if (ret != NULL) {
            XMEMSET(ret, 0, sizeof(WOLFSSL_X509_PKEY));
            ret->heap = heap;
        }
        return ret;
    }
#endif /* !NO_BIO */


    /* free up all memory used by "xPkey" passed in */
    void wolfSSL_X509_PKEY_free(WOLFSSL_X509_PKEY* xPkey)
    {
        if (xPkey != NULL) {
            wolfSSL_EVP_PKEY_free(xPkey->dec_pkey);
            XFREE(xPkey, xPkey->heap, DYNAMIC_TYPE_KEY);
        }
    }


#ifndef NO_BIO

#define PEM_COMPARE_HEADER(start, end, header) \
        ((end) - (start) == XSTR_SIZEOF(header) && XMEMCMP(start, header, \
                XSTR_SIZEOF(header)) == 0)

    /**
     * This read one structure from bio and returns the read structure
     * in the appropriate output parameter (x509, crl, x_pkey). The
     * output parameters must be set to NULL.
     * @param bio    Input for reading structures
     * @param cb     Password callback
     * @param x509   Output
     * @param crl    Output
     * @param x_pkey Output
     * @return WOLFSSL_SUCCESS on success and WOLFSSL_FAILURE otherwise
     */
    int wolfSSL_PEM_X509_X509_CRL_X509_PKEY_read_bio(
            WOLFSSL_BIO* bio, wc_pem_password_cb* cb, WOLFSSL_X509** x509,
            WOLFSSL_X509_CRL** crl, WOLFSSL_X509_PKEY** x_pkey)
    {

#if defined(WOLFSSL_PEM_TO_DER) || defined(WOLFSSL_DER_TO_PEM)
        char* pem = NULL;
        long  i = pem_struct_min_sz, l;
        const char* header = NULL;
        const char* headerEnd = NULL;
        const char* footer = NULL;
        const char* footerEnd = NULL;
    #ifdef HAVE_CRL
        DerBuffer* der = NULL;
    #endif
        WOLFSSL_BIO* pemBio = NULL;

        if (!bio || !x509 || *x509 || !crl || *crl || !x_pkey || *x_pkey) {
            WOLFSSL_MSG("Bad input parameter or output parameters "
                        "not set to a NULL value.");
            return WOLFSSL_FAILURE;
        }

        l = wolfSSL_BIO_get_len(bio);

        if (l < 0) {
            WOLFSSL_ERROR(BAD_FUNC_ARG);
            return WOLFSSL_FAILURE;
        }

        if (l == 0) {
            /* Streaming BIO (pipe/FIFO/socket): size unknown, use the cap. */
            l = MAX_BIO_READ_BUFFER;
        }
        else if (l <= pem_struct_min_sz) {
            /* No certificate in buffer */
            WOLFSSL_ERROR(ASN_NO_PEM_HEADER);
            return WOLFSSL_FAILURE;
        }

        pem = (char*)XMALLOC(l, 0, DYNAMIC_TYPE_PEM);
        if (pem == NULL)
            return WOLFSSL_FAILURE;

        if (wolfSSL_BIO_read(bio, &pem[0], pem_struct_min_sz) !=
                pem_struct_min_sz) {
            WOLFSSL_ERROR(ASN_NO_PEM_HEADER);
            goto err;
        }

        /* Read the header and footer */
        while (i < l && wolfSSL_BIO_read(bio, &pem[i], 1) == 1) {
            i++;
            if (!header) {
                header = XSTRNSTR(pem, "-----BEGIN ", i);
            }
            else if (!headerEnd) {
                headerEnd = XSTRNSTR(header + XSTR_SIZEOF("-----BEGIN "),
                        "-----",
                        i - (header + XSTR_SIZEOF("-----BEGIN ") - pem));
                if (headerEnd) {
                    headerEnd += XSTR_SIZEOF("-----");
                    /* Read in the newline */
                    if (wolfSSL_BIO_read(bio, &pem[i], 1) != 1) {
                        WOLFSSL_MSG("wolfSSL_BIO_read error");
                        goto err;
                    }
                    i++;
                    if (*headerEnd != '\n' && *headerEnd != '\r') {
                        WOLFSSL_MSG("Missing newline after header");
                        goto err;
                    }
                }
            }
            else if (!footer) {
                footer = XSTRNSTR(headerEnd, "-----END ",
                        i - (headerEnd - pem));
            }
            else if (!footerEnd) {
                footerEnd = XSTRNSTR(footer + XSTR_SIZEOF("-----"),
                        "-----",
                        i - (footer + XSTR_SIZEOF("-----") - pem));
                if (footerEnd) {
                    footerEnd += XSTR_SIZEOF("-----");
                    /* Now check that footer matches header */
                    if ((headerEnd - (header + XSTR_SIZEOF("-----BEGIN "))) ==
                        (footerEnd - (footer + XSTR_SIZEOF("-----END "))) &&
                        XMEMCMP(header + XSTR_SIZEOF("-----BEGIN "),
                                footer + XSTR_SIZEOF("-----END "),
                        headerEnd - (header + XSTR_SIZEOF("-----BEGIN ")))
                            != 0) {
                        WOLFSSL_MSG("Header and footer don't match");
                        goto err;
                    }
                    /* header and footer match */
                    break;
                }
            }
        }
        if (!footerEnd) {
            /* Only check footerEnd since it is set last */
            WOLFSSL_ERROR(ASN_NO_PEM_HEADER);
            goto err;
        }
        else {
            if (PEM_COMPARE_HEADER(header, headerEnd,
                    "-----BEGIN CERTIFICATE-----")) {
                /* We have a certificate */
                WOLFSSL_MSG("Parsing x509 cert");
                *x509 = wolfSSL_X509_load_certificate_buffer(
                        (const unsigned char*) header,
                        (int)(footerEnd - header), WOLFSSL_FILETYPE_PEM);
                if (!*x509) {
                    WOLFSSL_MSG("wolfSSL_X509_load_certificate_buffer error");
                    goto err;
                }
            }
    #ifdef HAVE_CRL
            else if (PEM_COMPARE_HEADER(header, headerEnd,
                        "-----BEGIN X509 CRL-----")) {
                /* We have a crl */
                WOLFSSL_MSG("Parsing crl");
                if ((PemToDer((const unsigned char*) header,
                        (long)(footerEnd - header), CRL_TYPE, &der, NULL, NULL,
                        NULL)) < 0) {
                    WOLFSSL_MSG("PemToDer error");
                    goto err;
                }
                *crl = wolfSSL_d2i_X509_CRL(NULL, der->buffer, der->length);
                if (!*crl) {
                    WOLFSSL_MSG("wolfSSL_d2i_X509_CRL error");
                    goto err;
                }
            }
    #endif
            else {
                WOLFSSL_MSG("Parsing x509 key");

                if (!(*x_pkey = wolfSSL_X509_PKEY_new(NULL))) {
                    WOLFSSL_MSG("wolfSSL_X509_PKEY_new error");
                    goto err;
                }

                if (!(pemBio = wolfSSL_BIO_new(wolfSSL_BIO_s_mem()))) {
                    WOLFSSL_MSG("wolfSSL_BIO_new error");
                    goto err;
                }

                if (wolfSSL_BIO_write(pemBio, header,
                        (int)(footerEnd - header)) != footerEnd - header) {
                    WOLFSSL_MSG("wolfSSL_BIO_new error");
                    goto err;
                }

                if (wolfSSL_PEM_read_bio_PrivateKey(pemBio,
                        &(*x_pkey)->dec_pkey, cb, NULL) == NULL) {
                    WOLFSSL_MSG("wolfSSL_PEM_read_bio_PrivateKey error");
                    goto err;
                }

                wolfSSL_BIO_free(pemBio);
            }
        }

        XFREE(pem, 0, DYNAMIC_TYPE_PEM);
    #ifdef HAVE_CRL
        if (der)
            FreeDer(&der);
    #endif
        return WOLFSSL_SUCCESS;
err:
        XFREE(pem, 0, DYNAMIC_TYPE_PEM);
    #ifdef HAVE_CRL
        if (der)
            FreeDer(&der);
    #endif
        if (*x_pkey) {
            wolfSSL_X509_PKEY_free(*x_pkey);
            *x_pkey = NULL;
        }
        if (pemBio)
            wolfSSL_BIO_free(pemBio);
        return WOLFSSL_FAILURE;
#else /* ! (WOLFSSL_PEM_TO_DER || WOLFSSL_DER_TO_PEM) */
        return WOLFSSL_FAILURE;
#endif /* WOLFSSL_PEM_TO_DER || WOLFSSL_DER_TO_PEM */
    }

#endif /* OPENSSL_EXTRA || OPENSSL_ALL */
#ifdef OPENSSL_ALL

#ifndef NO_FILESYSTEM
    WOLF_STACK_OF(WOLFSSL_X509_INFO)* wolfSSL_PEM_X509_INFO_read(
            XFILE fp, WOLF_STACK_OF(WOLFSSL_X509_INFO)* sk,
            pem_password_cb* cb, void* u)
    {
        WOLFSSL_BIO* fileBio = wolfSSL_BIO_new_fp(fp, WOLFSSL_BIO_NOCLOSE);
        WOLF_STACK_OF(WOLFSSL_X509_INFO)* ret = NULL;

        WOLFSSL_ENTER("wolfSSL_PEM_X509_INFO_read");
        if (fileBio != NULL) {
            ret = wolfSSL_PEM_X509_INFO_read_bio(fileBio, sk, cb, u);
            wolfSSL_BIO_free(fileBio);
        }
        return ret;
    }
#endif /* !NO_FILESYSTEM */

    /*
     * bio WOLFSSL_BIO to read certificates from
     * sk  possible stack to push more X509_INFO structs to. Can be NULL
     * cb  callback password for encrypted PEM certificates
     * u   user input such as password
     *
     * returns stack on success and NULL or default stack passed in on fail
     */
    WOLF_STACK_OF(WOLFSSL_X509_INFO)* wolfSSL_PEM_X509_INFO_read_bio(
        WOLFSSL_BIO* bio, WOLF_STACK_OF(WOLFSSL_X509_INFO)* sk,
        wc_pem_password_cb* cb, void* u)
    {
        WOLF_STACK_OF(WOLFSSL_X509_INFO)* localSk = NULL;
        int ret = WOLFSSL_SUCCESS;
        WOLFSSL_X509_INFO* current = NULL;
        WOLFSSL_X509*      x509 = NULL;
        WOLFSSL_X509_CRL*  crl  = NULL;
        WOLFSSL_X509_PKEY* x_pkey = NULL;

        (void)u;

        WOLFSSL_ENTER("wolfSSL_PEM_X509_INFO_read_bio");

        /* attempt to use passed in stack or create a new one */
        if (sk != NULL) {
            localSk = sk;
        }
        else {
            localSk = wolfSSL_sk_X509_INFO_new_null();
        }
        if (localSk == NULL) {
            WOLFSSL_LEAVE("wolfSSL_PEM_X509_INFO_read_bio",
                    MEMORY_E);
            return NULL;
        }

        /* parse through BIO and push new info's found onto stack */
        while (1) {
            x509 = NULL;
            crl  = NULL;
            x_pkey = NULL;

            if (wolfSSL_PEM_X509_X509_CRL_X509_PKEY_read_bio(bio, cb,
                    &x509, &crl, &x_pkey) == WOLFSSL_SUCCESS) {
                if (current == NULL ||
                        (x509 && current->x509) ||
                        (crl && current->crl) ||
                        (x_pkey && current->x_pkey)) {
                    /* Need to create new current since existing one already
                     * has the member filled or this is the first successful
                     * read. */
                    current = wolfSSL_X509_INFO_new();
                    if (current == NULL) {
                        ret = MEMORY_E;
                        break;
                    }
                    if (wolfSSL_sk_X509_INFO_push(localSk, current) <= 0) {
                        wolfSSL_X509_INFO_free(current);
                        current = NULL;
                        ret = WOLFSSL_FAILURE;
                        break;
                    }
                }

                if (x509) {
                    current->x509 = x509;
                }
                else if (crl) {
                    current->crl = crl;
                }
                else if (x_pkey) {
                    current->x_pkey = x_pkey;
                }
                else {
                    WOLFSSL_MSG("No output parameters set");
                    ret = WOLFSSL_FAILURE;
                    break;
                }
            }
            else {
#ifdef WOLFSSL_HAVE_ERROR_QUEUE
                unsigned long err;
                CLEAR_ASN_NO_PEM_HEADER_ERROR(err);
                if (ERR_GET_LIB(err) != ERR_LIB_PEM ||
                    ERR_GET_REASON(err) != PEM_R_NO_START_LINE) {
                    ret = WOLFSSL_FAILURE;
                }
#else
                if (wolfSSL_sk_X509_INFO_num(localSk) > 0) {
                    WOLFSSL_MSG("At least one X509_INFO object on stack."
                                "Assuming error means EOF or no more PEM"
                                "headers found.");
                }
                else {
                    ret = WOLFSSL_FAILURE;
                }
#endif
                break;
            }
        }
        if (ret != WOLFSSL_SUCCESS ||
                wolfSSL_sk_X509_INFO_num(localSk) == 0) {
            /* current should always be pushed onto the localsk stack at this
             * point. The only case when it isn't is when
             * wolfSSL_sk_X509_INFO_push fails but in that case the current
             * free is handled inside the loop. */
            if (localSk != sk) {
                wolfSSL_sk_pop_free(localSk, NULL);
            }
            wolfSSL_X509_free(x509);
#ifdef HAVE_CRL
            wolfSSL_X509_CRL_free(crl);
#endif
            wolfSSL_X509_PKEY_free(x_pkey);
            localSk = NULL;
        }
        WOLFSSL_LEAVE("wolfSSL_PEM_X509_INFO_read_bio", ret);
        return localSk;
    }
#endif /* !NO_BIO */
#endif /* OPENSSL_EXTRA || OPENSSL_ALL */

    void wolfSSL_X509_NAME_ENTRY_free(WOLFSSL_X509_NAME_ENTRY* ne)
    {
        WOLFSSL_ENTER_VERBOSE("wolfSSL_X509_NAME_ENTRY_free");
        if (ne != NULL) {
            wolfSSL_ASN1_OBJECT_free(ne->object);
            if (ne->value != NULL) {
                wolfSSL_ASN1_STRING_free(ne->value);
            }
            XFREE(ne, NULL, DYNAMIC_TYPE_NAME_ENTRY);
        }
    }


    WOLFSSL_X509_NAME_ENTRY* wolfSSL_X509_NAME_ENTRY_new(void)
    {
        WOLFSSL_X509_NAME_ENTRY* ne;

        ne = (WOLFSSL_X509_NAME_ENTRY*)XMALLOC(sizeof(WOLFSSL_X509_NAME_ENTRY),
                NULL, DYNAMIC_TYPE_NAME_ENTRY);
        if (ne != NULL) {
            XMEMSET(ne, 0, sizeof(WOLFSSL_X509_NAME_ENTRY));
        }

        return ne;
    }


    static void wolfssl_x509_name_entry_set(WOLFSSL_X509_NAME_ENTRY* ne,
        int nid, int type, const unsigned char *data, int dataSz)
    {
        ne->nid = nid;
        /* Reuse the object if already available. */
        ne->object = wolfSSL_OBJ_nid2obj_ex(nid, ne->object);
        if (ne->value == NULL) {
            ne->value = wolfSSL_ASN1_STRING_type_new(type);
        }
        if (ne->value != NULL) {
            if (wolfSSL_ASN1_STRING_set(ne->value, (const void*)data,
                                            dataSz) == WOLFSSL_SUCCESS) {
                ne->set = 1;
            }
            else {
                /* Free the ASN1_STRING if it is not set. */
                wolfSSL_ASN1_STRING_free(ne->value);
                ne->value = NULL;
            }
        }
    }

    /* Create a new WOLFSSL_X509_NAME_ENTRY structure based on the text passed
     * in. Returns NULL on failure */
    WOLFSSL_X509_NAME_ENTRY* wolfSSL_X509_NAME_ENTRY_create_by_txt(
            WOLFSSL_X509_NAME_ENTRY **neIn, const char *txt, int type,
            const unsigned char *data, int dataSz)
    {
        int nid = -1;
        WOLFSSL_X509_NAME_ENTRY* ne = NULL;

        WOLFSSL_ENTER("wolfSSL_X509_NAME_ENTRY_create_by_txt");

        if (txt == NULL) {
            return NULL;
        }

        if (neIn != NULL) {
            ne = *neIn;
        }

        nid = wolfSSL_OBJ_txt2nid(txt);
        if (nid == WC_NID_undef) {
            WOLFSSL_MSG("Unable to find text");
            ne = NULL;
        }
        else {
            if (ne == NULL) {
                ne = wolfSSL_X509_NAME_ENTRY_new();
                if (ne == NULL) {
                    return NULL;
                }
            }

            wolfssl_x509_name_entry_set(ne, nid, type, data, dataSz);
        }

        return ne;
    }


    /* Creates a new entry given the NID, type, and data
     * "dataSz" is number of bytes in data, if set to -1 then XSTRLEN is used
     * "out" can be used to store the new entry data in an existing structure
     *       if NULL then a new WOLFSSL_X509_NAME_ENTRY structure is created
     * returns a pointer to WOLFSSL_X509_NAME_ENTRY on success and NULL on fail
     */
    WOLFSSL_X509_NAME_ENTRY* wolfSSL_X509_NAME_ENTRY_create_by_NID(
            WOLFSSL_X509_NAME_ENTRY** out, int nid, int type,
            const unsigned char* data, int dataSz)
    {
        WOLFSSL_X509_NAME_ENTRY* ne;

        WOLFSSL_ENTER_VERBOSE("wolfSSL_X509_NAME_ENTRY_create_by_NID");

        if (!data) {
            WOLFSSL_MSG("Bad parameter");
            return NULL;
        }

        if (out == NULL || *out == NULL) {
            ne = wolfSSL_X509_NAME_ENTRY_new();
            if (ne == NULL) {
                return NULL;
            }
            if (out != NULL) {
                *out = ne;
            }
        }
        else {
            ne = *out;
        }

        wolfssl_x509_name_entry_set(ne, nid, type, data, dataSz);

        return ne;
    }
#endif /* OPENSSL_EXTRA || OPENSSL_EXTRA_X509_SMALL */

#if defined(OPENSSL_EXTRA) || defined(OPENSSL_EXTRA_X509_SMALL) || \
    defined(HAVE_LIGHTY) || defined(WOLFSSL_MYSQL_COMPATIBLE) || \
    defined(HAVE_STUNNEL) || defined(WOLFSSL_NGINX) || \
    defined(HAVE_POCO_LIB) || defined(WOLFSSL_HAPROXY)
WOLFSSL_ASN1_OBJECT* wolfSSL_X509_NAME_ENTRY_get_object(
    WOLFSSL_X509_NAME_ENTRY *ne)
{
    WOLFSSL_ASN1_OBJECT* object = NULL;

    WOLFSSL_ENTER_VERBOSE("wolfSSL_X509_NAME_ENTRY_get_object");

    if (ne != NULL) {
        /* Create object from nid - reuse existing object if possible. */
        object = wolfSSL_OBJ_nid2obj_ex(ne->nid, ne->object);
        if (object != NULL) {
            /* Set the object when no error. */
            ne->object = object;
        }
    }

    return object;
}
#endif /* OPENSSL_ALL || HAVE_LIGHTY || WOLFSSL_MYSQL_COMPATIBLE ||
        * HAVE_STUNNEL || WOLFSSL_NGINX || HAVE_POCO_LIB || WOLFSSL_HAPROXY */

#if defined(OPENSSL_EXTRA) || defined(OPENSSL_EXTRA_X509_SMALL)
    /* add all entry of type "nid" to the buffer "fullName" and advance "idx"
     * since number of entries is small, a brute force search is used here
     * returns the number of entries added
     */
    static int AddAllEntry(WOLFSSL_X509_NAME* name, char* fullName,
            int fullNameSz, int* idx)
    {
        int i;
        int ret = 0;

        for (i = 0; i < MAX_NAME_ENTRIES; i++) {
            if (name->entry[i].set) {
                WOLFSSL_X509_NAME_ENTRY* e;
                WOLFSSL_ASN1_OBJECT* obj;

                int sz;
                unsigned char* data;

                e = &name->entry[i];
                obj = wolfSSL_X509_NAME_ENTRY_get_object(e);
                if (obj == NULL) {
                    return BAD_FUNC_ARG;
                }

                XMEMCPY(fullName + *idx, "/", 1); *idx = *idx + 1;
                sz = (int)XSTRLEN(obj->sName);
                XMEMCPY(fullName + *idx, obj->sName, sz);
                *idx += sz;
                XMEMCPY(fullName + *idx, "=", 1); *idx = *idx + 1;

                data = wolfSSL_ASN1_STRING_data(e->value);
                if (data != NULL) {
                    sz = (int)XSTRLEN((const char*)data);
                    XMEMCPY(fullName + *idx, data, sz);
                    *idx += sz;
                }

                ret++;
            }
        }
        (void)fullNameSz;
        return ret;
    }


    /* Converts a list of entries in WOLFSSL_X509_NAME struct into a string
     * returns 0 on success */
    static int RebuildFullName(WOLFSSL_X509_NAME* name)
    {
        int totalLen = 0, i, idx, entryCount = 0;

        if (name == NULL)
            return BAD_FUNC_ARG;

        for (i = 0; i < MAX_NAME_ENTRIES; i++) {
            if (name->entry[i].set) {
                WOLFSSL_X509_NAME_ENTRY* e;
                WOLFSSL_ASN1_OBJECT* obj;

                e = &name->entry[i];
                obj = wolfSSL_X509_NAME_ENTRY_get_object(e);
                if (obj == NULL)
                    return BAD_FUNC_ARG;

                totalLen += (int)XSTRLEN(obj->sName) + 2;/*+2 for '/' and '=' */
                totalLen += wolfSSL_ASN1_STRING_length(e->value);
            }
        }

        if (name->dynamicName) {
            XFREE(name->name, name->heap, DYNAMIC_TYPE_X509);
            name->name = name->staticName;
            name->dynamicName = 0;
        }

        if (totalLen >= ASN_NAME_MAX) {
            name->name = (char*)XMALLOC(totalLen + 1, name->heap,
                    DYNAMIC_TYPE_X509);
            if (name->name == NULL)
                return MEMORY_E;
            name->dynamicName = 1;
        }

        idx = 0;
        entryCount = AddAllEntry(name, name->name, totalLen, &idx);
        if (entryCount < 0)
            return entryCount;

        name->name[idx] = '\0';
        name->sz = idx + 1; /* size includes null terminator */
        name->entrySz = entryCount;

        return 0;
    }

    /* Copies entry into name. With it being copied freeing entry becomes the
     * callers responsibility.
     * returns 1 for success and 0 for error */
    int wolfSSL_X509_NAME_add_entry(WOLFSSL_X509_NAME* name,
            WOLFSSL_X509_NAME_ENTRY* entry, int idx, int set)
    {
        WOLFSSL_X509_NAME_ENTRY* current = NULL;
        int ret, i;

        WOLFSSL_ENTER_VERBOSE("wolfSSL_X509_NAME_add_entry");

        if (name == NULL || entry == NULL || entry->value == NULL) {
            WOLFSSL_MSG("NULL argument passed in");
            return WOLFSSL_FAILURE;
        }

        if (idx >= 0) {
            /* place in specific index */

            if (idx >= MAX_NAME_ENTRIES) {
                WOLFSSL_MSG("Error index to insert entry is larger than array");
                return WOLFSSL_FAILURE;
            }
            i = idx;
        }
        else {
            /* iterate through and find first open spot */
            for (i = 0; i < MAX_NAME_ENTRIES; i++) {
                if (name->entry[i].set == 0) { /* not set so overwritten */
                    WOLFSSL_MSG_VERBOSE("Found place for name entry");
                    break;
                }
            }

            if (i == MAX_NAME_ENTRIES) {
                WOLFSSL_MSG("No spot found for name entry");
                return WOLFSSL_FAILURE;
            }
        }

        current = &name->entry[i];
        if (current->set == 0)
            name->entrySz++;

        if (wolfSSL_X509_NAME_ENTRY_create_by_NID(&current,
                            entry->nid,
                            wolfSSL_ASN1_STRING_type(entry->value),
                            wolfSSL_ASN1_STRING_data(entry->value),
                            wolfSSL_ASN1_STRING_length(entry->value)) != NULL)
        {
            ret = WOLFSSL_SUCCESS;
        #ifdef OPENSSL_ALL
            if (name->entries == NULL) {
                name->entries = wolfSSL_sk_X509_NAME_new(NULL);
            }
            if (wolfSSL_sk_X509_NAME_ENTRY_push(name->entries, current) <= 0) {
                ret = WOLFSSL_FAILURE;
            }
        #endif
        }
        else {
            ret = WOLFSSL_FAILURE;
        }

        if (ret != WOLFSSL_SUCCESS) {
            WOLFSSL_MSG("Error adding the name entry");
            if (current->set == 0)
                name->entrySz--;
            return WOLFSSL_FAILURE;
        }

#ifdef WOLFSSL_PYTHON
        /* Set name index for OpenSSL stack index position and so Python can
         * generate tuples/sets from the list. */
        for (i = 0; i < MAX_NAME_ENTRIES; i++) {
            if (name->entry[i].set != 0)
                name->entry[i].set = i + 1;
        }
#endif

        if (RebuildFullName(name) != 0)
            return WOLFSSL_FAILURE;

        (void)set;
        return WOLFSSL_SUCCESS;
    }

    int wolfSSL_X509_NAME_add_entry_by_txt(WOLFSSL_X509_NAME *name,
                                           const char *field, int type,
                                           const unsigned char *bytes, int len,
                                           int loc, int set)
    {
        int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
        int nid;
        WOLFSSL_X509_NAME_ENTRY* entry;

        (void)type;
        WOLFSSL_ENTER("wolfSSL_X509_NAME_add_entry_by_txt");

        if (name == NULL || field == NULL)
            return WOLFSSL_FAILURE;

        if ((nid = wolfSSL_OBJ_txt2nid(field)) == WC_NID_undef) {
            WOLFSSL_MSG("Unable convert text to NID");
            return WOLFSSL_FAILURE;
        }

        entry = wolfSSL_X509_NAME_ENTRY_create_by_NID(NULL,
                  nid, type, (unsigned char*)bytes, len);
        if (entry == NULL)
            return WOLFSSL_FAILURE;

        ret = wolfSSL_X509_NAME_add_entry(name, entry, loc, set);
        wolfSSL_X509_NAME_ENTRY_free(entry);

        return ret;
    }

    int wolfSSL_X509_NAME_add_entry_by_NID(WOLFSSL_X509_NAME *name, int nid,
                                           int type, const unsigned char *bytes,
                                           int len, int loc, int set)
    {
        int ret;
        WOLFSSL_X509_NAME_ENTRY* entry;
        WOLFSSL_ENTER_VERBOSE("wolfSSL_X509_NAME_add_entry_by_NID");
        entry = wolfSSL_X509_NAME_ENTRY_create_by_NID(NULL, nid, type, bytes,
                len);
        if (entry == NULL)
            return WOLFSSL_FAILURE;
        ret = wolfSSL_X509_NAME_add_entry(name, entry, loc, set);
        wolfSSL_X509_NAME_ENTRY_free(entry);
        return ret;
    }

    WOLFSSL_X509_NAME_ENTRY *wolfSSL_X509_NAME_delete_entry(
            WOLFSSL_X509_NAME *name, int loc)
    {
        WOLFSSL_X509_NAME_ENTRY* ret;
        WOLFSSL_ENTER("wolfSSL_X509_NAME_delete_entry");

        if (!name) {
            WOLFSSL_MSG("Bad parameter");
            return NULL;
        }

        ret = wolfSSL_X509_NAME_get_entry(name, loc);
        if (!ret) {
            WOLFSSL_MSG("loc entry not found");
            return NULL;
        }
        name->entry[loc].set = 0;
#ifdef WOLFSSL_PYTHON
        {
            int i;
            /* Set name index for OpenSSL stack index position and so Python can
            * generate tuples/sets from the list. */
            for (i = 0; i < MAX_NAME_ENTRIES; i++) {
                if (name->entry[i].set != 0)
                    name->entry[i].set = i + 1;
            }
        }
#endif
        return ret;
    }

#endif /* OPENSSL_EXTRA || OPENSSL_EXTRA_X509_SMALL */

#if defined(OPENSSL_EXTRA) && !defined(NO_ASN)
    int wolfSSL_X509_NAME_get_index_by_OBJ(WOLFSSL_X509_NAME *name,
                                           const WOLFSSL_ASN1_OBJECT *obj,
                                           int idx) {
        if (!name || idx >= MAX_NAME_ENTRIES ||
                !obj || !obj->obj) {
            return WOLFSSL_FATAL_ERROR;
        }

        if (idx < 0) {
            idx = -1;
        }

        for (idx++; idx < MAX_NAME_ENTRIES; idx++) {
            /* Find index of desired name */
            if (name->entry[idx].set) {
                if (XSTRLEN(obj->sName) ==
                        XSTRLEN(name->entry[idx].object->sName) &&
                    XSTRNCMP((const char*) obj->sName,
                        name->entry[idx].object->sName, obj->objSz - 1) == 0) {
                    return idx;
                }
            }
        }
        return WOLFSSL_FATAL_ERROR;
    }
#endif

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL) || \
    defined(OPENSSL_EXTRA_X509_SMALL)

#ifdef OPENSSL_EXTRA
    int wolfSSL_X509_NAME_ENTRY_set(const WOLFSSL_X509_NAME_ENTRY *ne)
    {
        if (ne != NULL) {
            return ne->set;
        }
        return 0;
    }
#endif


    /* returns a pointer to the internal entry at location 'loc' on success,
     * a null pointer is returned in fail cases */
    WOLFSSL_X509_NAME_ENTRY *wolfSSL_X509_NAME_get_entry(
                                        const WOLFSSL_X509_NAME *name, int loc)
    {
        WOLFSSL_ENTER_VERBOSE("wolfSSL_X509_NAME_get_entry");

        if (name == NULL) {
            return NULL;
        }

        if (loc < 0 || loc >= MAX_NAME_ENTRIES) {
            WOLFSSL_MSG("Bad argument");
            return NULL;
        }

        if (name->entry[loc].set) {
            return (WOLFSSL_X509_NAME_ENTRY*)&name->entry[loc];
        }
        else {
            return NULL;
        }
    }
#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL */

#ifdef OPENSSL_EXTRA

int wolfSSL_X509_check_private_key(WOLFSSL_X509 *x509, WOLFSSL_EVP_PKEY *key)
{
    WOLFSSL_ENTER("wolfSSL_X509_check_private_key");

    if (!x509 || !key) {
        WOLFSSL_MSG("Bad parameter");
        return WOLFSSL_FAILURE;
    }

#ifndef NO_CHECK_PRIVATE_KEY
    return wc_CheckPrivateKey((byte*)key->pkey.ptr, key->pkey_sz,
            x509->pubKey.buffer, x509->pubKey.length,
            (enum Key_Sum)x509->pubKeyOID, key->heap) == 1 ?
                    WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
#else
    /* not compiled in */
    return WOLFSSL_SUCCESS;
#endif
}

#endif /* OPENSSL_EXTRA */

#if defined(HAVE_LIGHTY) || defined(HAVE_STUNNEL) \
    || defined(WOLFSSL_MYSQL_COMPATIBLE) || defined(OPENSSL_EXTRA)
#ifndef NO_BIO

#ifdef WOLFSSL_CERT_GEN

#ifdef WOLFSSL_CERT_REQ
/* writes the x509 from x to the WOLFSSL_BIO bp
 *
 * returns WOLFSSL_SUCCESS on success and WOLFSSL_FAILURE on fail
 */
int wolfSSL_PEM_write_bio_X509_REQ(WOLFSSL_BIO *bp, WOLFSSL_X509 *x)
{
    byte* pem;
    int   pemSz = 0;
    const unsigned char* der;
    int derSz;
    int ret;

    WOLFSSL_ENTER("wolfSSL_PEM_write_bio_X509_REQ");

    if (x == NULL || bp == NULL) {
        return WOLFSSL_FAILURE;
    }

    der = wolfSSL_X509_get_der(x, &derSz);
    if (der == NULL) {
        return WOLFSSL_FAILURE;
    }

    /* get PEM size */
    pemSz = wc_DerToPemEx(der, (word32)derSz, NULL, 0, NULL, CERTREQ_TYPE);
    if (pemSz < 0) {
        return WOLFSSL_FAILURE;
    }

    /* create PEM buffer and convert from DER */
    pem = (byte*)XMALLOC(pemSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
    if (pem == NULL) {
        return WOLFSSL_FAILURE;
    }
    if (wc_DerToPemEx(der, (word32)derSz, pem, pemSz, NULL, CERTREQ_TYPE) < 0) {
        XFREE(pem, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        return WOLFSSL_FAILURE;
    }

    /* write the PEM to BIO */
    ret = wolfSSL_BIO_write(bp, pem, pemSz);
    XFREE(pem, NULL, DYNAMIC_TYPE_TMP_BUFFER);

    if (ret <= 0) return WOLFSSL_FAILURE;
    return WOLFSSL_SUCCESS;
}
#endif /* WOLFSSL_CERT_REQ */


/* writes the x509 from x to the WOLFSSL_BIO bp
 *
 * returns WOLFSSL_SUCCESS on success and WOLFSSL_FAILURE on fail
 */
int wolfSSL_PEM_write_bio_X509_AUX(WOLFSSL_BIO *bp, WOLFSSL_X509 *x)
{
    byte* pem;
    int   pemSz = 0;
    const unsigned char* der;
    int derSz;
    int ret;

    WOLFSSL_ENTER("wolfSSL_PEM_write_bio_X509_AUX");

    if (bp == NULL || x == NULL) {
        WOLFSSL_MSG("NULL argument passed in");
        return WOLFSSL_FAILURE;
    }

    der = wolfSSL_X509_get_der(x, &derSz);
    if (der == NULL) {
        return WOLFSSL_FAILURE;
    }

    /* get PEM size */
    pemSz = wc_DerToPemEx(der, (word32)derSz, NULL, 0, NULL, CERT_TYPE);
    if (pemSz < 0) {
        return WOLFSSL_FAILURE;
    }

    /* create PEM buffer and convert from DER */
    pem = (byte*)XMALLOC(pemSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
    if (pem == NULL) {
        return WOLFSSL_FAILURE;
    }
    if (wc_DerToPemEx(der, (word32)derSz, pem, pemSz, NULL, CERT_TYPE) < 0) {
        XFREE(pem, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        return WOLFSSL_FAILURE;
    }

    /* write the PEM to BIO */
    ret = wolfSSL_BIO_write(bp, pem, pemSz);
    XFREE(pem, NULL, DYNAMIC_TYPE_TMP_BUFFER);

    if (ret <= 0) return WOLFSSL_FAILURE;
    return WOLFSSL_SUCCESS;
}

int wolfSSL_PEM_write_bio_X509(WOLFSSL_BIO *bio, WOLFSSL_X509 *cert)
{
    byte* pem = NULL;
    int   pemSz = 0;
    /* Get large buffer to hold cert der */
    const byte* der = NULL;
    int derSz = X509_BUFFER_SZ;
    int ret;

    WOLFSSL_ENTER("wolfSSL_PEM_write_bio_X509");

    if (bio == NULL || cert == NULL) {
        WOLFSSL_MSG("NULL argument passed in");
        return WOLFSSL_FAILURE;
    }

    /* Do not call wolfssl_x509_make_der() here. If we did, then need to re-sign
     * because we don't know the original order of the extensions and so we must
     * assume our extensions are in a different order, thus need to re-sign. */
    der = wolfSSL_X509_get_der(cert, &derSz);
    if (der == NULL) {
        goto error;
    }

    /* get PEM size */
    pemSz = wc_DerToPemEx(der, (word32)derSz, NULL, 0, NULL, CERT_TYPE);
    if (pemSz < 0) {
        goto error;
    }

    /* create PEM buffer and convert from DER */
    pem = (byte*)XMALLOC(pemSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
    if (pem == NULL) {
        goto error;
    }
    if (wc_DerToPemEx(der, (word32)derSz, pem, pemSz, NULL, CERT_TYPE) < 0) {
        goto error;
    }

    /* write the PEM to BIO */
    ret = wolfSSL_BIO_write(bio, pem, pemSz);
    XFREE(pem, NULL, DYNAMIC_TYPE_TMP_BUFFER);

    if (ret <= 0) return WOLFSSL_FAILURE;
    return WOLFSSL_SUCCESS;

error:
    XFREE(pem, NULL, DYNAMIC_TYPE_TMP_BUFFER);
    return WOLFSSL_FAILURE;
}
#endif /* WOLFSSL_CERT_GEN */

#endif /* !NO_BIO */
#endif /* HAVE_LIGHTY || HAVE_STUNNEL || WOLFSSL_MYSQL_COMPATIBLE */

#if defined(OPENSSL_EXTRA) || defined(HAVE_STUNNEL) || \
        defined(WOLFSSL_NGINX) || defined(HAVE_LIGHTY) || \
        defined(WOLFSSL_HAPROXY) || defined(WOLFSSL_OPENSSH) || \
        defined(HAVE_SBLIM_SFCB)

WOLF_STACK_OF(WOLFSSL_X509_NAME)* wolfSSL_sk_X509_NAME_new(
        WOLF_SK_COMPARE_CB(WOLFSSL_X509_NAME, cb))
{
    WOLFSSL_STACK* sk;
    (void)cb;

    WOLFSSL_ENTER_VERBOSE("wolfSSL_sk_X509_NAME_new");

    sk = wolfSSL_sk_new_node(NULL);
    if (sk != NULL) {
        sk->type = STACK_TYPE_X509_NAME;
    }

    return sk;
}

int wolfSSL_sk_X509_NAME_num(const WOLF_STACK_OF(WOLFSSL_X509_NAME) *sk)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_NAME_num");

    if (sk == NULL)
        return BAD_FUNC_ARG;

    return (int)sk->num;
}

/* Getter function for WOLFSSL_X509_NAME pointer
 *
 * sk is the stack to retrieve pointer from
 * i  is the index value in stack
 *
 * returns a pointer to a WOLFSSL_X509_NAME structure on success and NULL on
 *         fail
 */
WOLFSSL_X509_NAME* wolfSSL_sk_X509_NAME_value(
    const WOLF_STACK_OF(WOLFSSL_X509_NAME)* sk, int i)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_NAME_value");
    return (WOLFSSL_X509_NAME*)wolfSSL_sk_value(sk, i);
}

WOLFSSL_X509_NAME* wolfSSL_sk_X509_NAME_pop(
    WOLF_STACK_OF(WOLFSSL_X509_NAME)* sk)
{
    return (WOLFSSL_X509_NAME*)wolfSSL_sk_pop(sk);
}

void wolfSSL_sk_X509_NAME_pop_free(WOLF_STACK_OF(WOLFSSL_X509_NAME)* sk,
    void (*f) (WOLFSSL_X509_NAME*))
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_NAME_pop_free");
    wolfSSL_sk_pop_free(sk, (wolfSSL_sk_freefunc)f);
}

/* Free only the sk structure, NOT X509_NAME members */
void wolfSSL_sk_X509_NAME_free(WOLF_STACK_OF(WOLFSSL_X509_NAME)* sk)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_NAME_free");
    wolfSSL_sk_free(sk);
}

int wolfSSL_sk_X509_NAME_push(WOLF_STACK_OF(WOLFSSL_X509_NAME)* sk,
    WOLFSSL_X509_NAME* name)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_NAME_push");

    return wolfSSL_sk_push(sk, name);
}

/* return index of found, or negative to indicate not found */
int wolfSSL_sk_X509_NAME_find(const WOLF_STACK_OF(WOLFSSL_X509_NAME) *sk,
    WOLFSSL_X509_NAME *name)
{
    int i;

    WOLFSSL_ENTER("wolfSSL_sk_X509_NAME_find");

    if (sk == NULL)
        return BAD_FUNC_ARG;

    for (i = 0; sk; i++, sk = sk->next) {
        if (wolfSSL_X509_NAME_cmp(sk->data.name, name) == 0) {
            return i;
        }
    }
    return WOLFSSL_FATAL_ERROR;
}

/* Name Entry */
WOLF_STACK_OF(WOLFSSL_X509_NAME_ENTRY)* wolfSSL_sk_X509_NAME_ENTRY_new(
    WOLF_SK_COMPARE_CB(WOLFSSL_X509_NAME_ENTRY, cb))
{
    WOLFSSL_STACK* sk = wolfSSL_sk_new_node(NULL);
    if (sk != NULL) {
        sk->type = STACK_TYPE_X509_NAME_ENTRY;
        (void)cb;
    }
    return sk;
}

int wolfSSL_sk_X509_NAME_ENTRY_push(WOLF_STACK_OF(WOLFSSL_X509_NAME_ENTRY)* sk,
    WOLFSSL_X509_NAME_ENTRY* name_entry)
{
    return wolfSSL_sk_push(sk, name_entry);
}

WOLFSSL_X509_NAME_ENTRY* wolfSSL_sk_X509_NAME_ENTRY_value(
    const WOLF_STACK_OF(WOLFSSL_X509_NAME_ENTRY)* sk, int i)
{
    return (WOLFSSL_X509_NAME_ENTRY*)wolfSSL_sk_value(sk, i);
}

int wolfSSL_sk_X509_NAME_ENTRY_num(
    const WOLF_STACK_OF(WOLFSSL_X509_NAME_ENTRY)* sk)
{
    if (sk == NULL)
        return BAD_FUNC_ARG;
    return (int)sk->num;
}

void wolfSSL_sk_X509_NAME_ENTRY_free(WOLF_STACK_OF(WOLFSSL_X509_NAME_ENTRY)* sk)
{
    wolfSSL_sk_free(sk);
}

#endif /* OPENSSL_EXTRA || HAVE_STUNNEL || WOLFSSL_NGINX ||
            HAVE_LIGHTY || WOLFSSL_HAPROXY ||
            WOLFSSL_OPENSSH || HAVE_SBLIM_SFCB */

#if defined(OPENSSL_ALL) || defined(OPENSSL_EXTRA) || \
    (defined(HAVE_STUNNEL) || defined(WOLFSSL_NGINX) || \
    defined(HAVE_LIGHTY) || defined(WOLFSSL_HAPROXY) || \
    defined(WOLFSSL_OPENSSH) || defined(HAVE_SBLIM_SFCB))

#if defined(OPENSSL_ALL)
WOLFSSL_X509_INFO* wolfSSL_X509_INFO_new(void)
{
    WOLFSSL_X509_INFO* info;
    info = (WOLFSSL_X509_INFO*)XMALLOC(sizeof(WOLFSSL_X509_INFO), NULL,
        DYNAMIC_TYPE_X509);
    if (info) {
        XMEMSET(info, 0, sizeof(*info));
    }
    return info;
}

void wolfSSL_X509_INFO_free(WOLFSSL_X509_INFO* info)
{
    if (info == NULL)
        return;

    if (info->x509) {
        wolfSSL_X509_free(info->x509);
        info->x509 = NULL;
    }
#ifdef HAVE_CRL
    if (info->crl) {
        wolfSSL_X509_CRL_free(info->crl);
        info->crl = NULL;
    }
#endif
    wolfSSL_X509_PKEY_free(info->x_pkey);
    info->x_pkey = NULL;

    XFREE(info, NULL, DYNAMIC_TYPE_X509);
}
#endif

WOLFSSL_STACK* wolfSSL_sk_X509_INFO_new_null(void)
{
    WOLFSSL_STACK* sk = wolfSSL_sk_new_node(NULL);
    if (sk) {
        sk->type = STACK_TYPE_X509_INFO;
    }
    return sk;
}

int wolfSSL_sk_X509_INFO_num(const WOLF_STACK_OF(WOLFSSL_X509_INFO) *sk)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_INFO_num");

    return wolfSSL_sk_num(sk);
}

WOLFSSL_X509_INFO* wolfSSL_sk_X509_INFO_value(
        const WOLF_STACK_OF(WOLFSSL_X509_INFO) *sk, int i)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_INFO_value");

    return (WOLFSSL_X509_INFO *)wolfSSL_sk_value(sk, i);
}

WOLFSSL_X509_INFO* wolfSSL_sk_X509_INFO_pop(
        WOLF_STACK_OF(WOLFSSL_X509_INFO)* sk)
{
    return (WOLFSSL_X509_INFO*)wolfSSL_sk_pop(sk);
}

#if defined(OPENSSL_ALL)
void wolfSSL_sk_X509_INFO_pop_free(WOLF_STACK_OF(WOLFSSL_X509_INFO)* sk,
    void (*f) (WOLFSSL_X509_INFO*))
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_INFO_pop_free");
    wolfSSL_sk_pop_free(sk, (wolfSSL_sk_freefunc)f);
}

void wolfSSL_sk_X509_INFO_free(WOLF_STACK_OF(WOLFSSL_X509_INFO) *sk)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_INFO_free");
    wolfSSL_sk_free(sk);
}

/* Adds the WOLFSSL_X509_INFO to the stack "sk". "sk" takes control of "in" and
 * tries to free it when the stack is free'd.
 *
 * return number of elements on success 0 on fail
 */
int wolfSSL_sk_X509_INFO_push(WOLF_STACK_OF(WOLFSSL_X509_INFO)* sk,
                                                      WOLFSSL_X509_INFO* in)
{
    return wolfSSL_sk_push(sk, in);
}

/* Creates a duplicate of WOLF_STACK_OF(WOLFSSL_X509_NAME).
 * Returns a new WOLF_STACK_OF(WOLFSSL_X509_NAME) or NULL on failure */
WOLF_STACK_OF(WOLFSSL_X509_NAME) *wolfSSL_dup_CA_list(
    WOLF_STACK_OF(WOLFSSL_X509_NAME)* sk)
{
    int i;
    const int num = wolfSSL_sk_X509_NAME_num(sk);
    WOLF_STACK_OF(WOLFSSL_X509_NAME) *copy;
    WOLFSSL_X509_NAME *name;

    WOLFSSL_ENTER("wolfSSL_dup_CA_list");

    copy = wolfSSL_sk_X509_NAME_new(NULL);
    if (copy == NULL) {
        WOLFSSL_MSG("Memory error");
        return NULL;
    }

    for (i = 0; i < num; i++) {
        name = wolfSSL_X509_NAME_dup(wolfSSL_sk_X509_NAME_value(sk, i));
        if (name == NULL || wolfSSL_sk_X509_NAME_push(copy, name) <= 0) {
            WOLFSSL_MSG("Memory error");
            wolfSSL_sk_X509_NAME_pop_free(copy, wolfSSL_X509_NAME_free);
            wolfSSL_X509_NAME_free(name);
            return NULL;
        }
    }

    return copy;
}

void* wolfSSL_sk_X509_OBJECT_value(WOLF_STACK_OF(WOLFSSL_X509_OBJECT)* sk,
    int i)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_OBJECT_value");
    for (; sk != NULL && i > 0; i--)
        sk = sk->next;

    if (i != 0 || sk == NULL)
        return NULL;
    return sk->data.x509_obj;
}

int wolfSSL_sk_X509_OBJECT_num(const WOLF_STACK_OF(WOLFSSL_X509_OBJECT) *s)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_OBJECT_num");
    if (s) {
        return (int)s->num;
    }
    else {
        return 0;
    }
}

int wolfSSL_sk_X509_NAME_set_cmp_func(WOLF_STACK_OF(WOLFSSL_X509_NAME)* sk,
    WOLF_SK_COMPARE_CB(WOLFSSL_X509_NAME, cb))
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_NAME_set_cmp_func");

    if (sk == NULL)
        return BAD_FUNC_ARG;

    WOLFSSL_MSG("Stack comparison not used in wolfSSL");
    (void)cb;
    return 0;
}
#endif /* OPENSSL_ALL */

#ifndef NO_BIO

/* Helper function for X509_NAME_print_ex. Sets *buf to string for domain
   name attribute based on NID. Returns size of buf */
static int get_dn_attr_by_nid(int n, const char** buf)
{
    int len = 0;
    const char *str;

    switch(n)
    {
        case WC_NID_commonName :
            str = "CN";
            len = 2;
            break;
        case WC_NID_countryName:
            str = "C";
            len = 1;
            break;
        case WC_NID_localityName:
            str = "L";
            len = 1;
            break;
        case WC_NID_stateOrProvinceName:
            str = "ST";
            len = 2;
            break;
        case WC_NID_streetAddress:
            str = "street";
            len = 6;
            break;
        case WC_NID_organizationName:
            str = "O";
            len = 1;
            break;
        case WC_NID_organizationalUnitName:
            str = "OU";
            len = 2;
            break;
        case WC_NID_postalCode:
            str = "postalCode";
            len = 10;
            break;
        case WC_NID_emailAddress:
            str = "emailAddress";
            len = 12;
            break;
        case WC_NID_surname:
            str = "SN";
            len = 2;
            break;
        case WC_NID_givenName:
            str = "GN";
            len = 2;
            break;
        case WC_NID_dnQualifier:
            str = "dnQualifier";
            len = 11;
            break;
        case WC_NID_name:
            str = "name";
            len = 4;
            break;
        case WC_NID_initials:
            str = "initials";
            len = 8;
            break;
        case WC_NID_domainComponent:
            str = "DC";
            len = 2;
            break;
        case WC_NID_pkcs9_contentType:
            str = "contentType";
            len = 11;
            break;
        case WC_NID_userId:
            str = "UID";
            len = 3;
            break;
        case WC_NID_x500UniqueIdentifier:
            str = "x500UniqueIdentifier";
            len = 20;
            break;
        case WC_NID_serialNumber:
            str = "serialNumber";
            len = 12;
            break;
        case WC_NID_title:
            str = "title";
            len = 5;
            break;
        case WC_NID_rfc822Mailbox:
            str = "mail";
            len = 4;
            break;
        default:
            WOLFSSL_MSG("Attribute type not found");
            str = NULL;

    }
    if (buf != NULL)
        *buf = str;
    return len;
}

/* Escape a name entry value. Mirrors OpenSSL's do_esc_char() for single
 * byte characters. Only ASN1_STRFLGS_ESC_2253, ASN1_STRFLGS_ESC_CTRL and
 * ASN1_STRFLGS_ESC_MSB are implemented. ASN1_STRFLGS_ESC_QUOTE does not
 * quote but, as in OpenSSL, still causes the backslash to be escaped.
 *
 * in    - value to escape, may contain NUL bytes
 * inSz  - length of in
 * flags - ASN1_STRFLGS_* flags
 * out   - buffer for escaped value, NULL to only get the length
 *
 * Returns number of bytes written, or needed when out is NULL.
 */
static int wolfssl_x509_name_esc_value(const char* in, int inSz,
                                       unsigned long flags, char* out)
{
    static const char hexDigit[] = "0123456789ABCDEF";
    const unsigned long escFlags = WOLFSSL_ASN1_STRFLGS_ESC_2253 |
        WOLFSSL_ASN1_STRFLGS_ESC_CTRL | WOLFSSL_ASN1_STRFLGS_ESC_MSB |
        WOLFSSL_ASN1_STRFLGS_ESC_QUOTE;
    int i;
    int outIdx = 0;

    for (i = 0; i < inSz; i++) {
        unsigned char c = (unsigned char)in[i];
        int hex = 0;
        int bs = 0;

        if (c >= 0x80) {
            hex = (flags & WOLFSSL_ASN1_STRFLGS_ESC_MSB) != 0;
        }
        else if ((flags & WOLFSSL_ASN1_STRFLGS_ESC_2253) &&
                 (c == ',' || c == '+' || c == '"' || c == '\\' ||
                  c == '<' || c == '>' || c == ';' ||
                  (i == 0 && (c == ' ' || c == '#')) ||
                  (i == inSz - 1 && c == ' '))) {
            bs = 1;
        }
        else if ((flags & WOLFSSL_ASN1_STRFLGS_ESC_CTRL) &&
                 (c < 0x20 || c == 0x7F)) {
            hex = 1;
        }
        else if (c == '\\' && (flags & escFlags)) {
            /* Any escaping means the escape character itself is escaped. */
            bs = 1;
        }

        if (hex) {
            if (out != NULL) {
                out[outIdx]     = '\\';
                out[outIdx + 1] = hexDigit[c >> 4];
                out[outIdx + 2] = hexDigit[c & 0x0F];
            }
            outIdx += 3;
        }
        else {
            if (bs) {
                if (out != NULL)
                    out[outIdx] = '\\';
                outIdx++;
            }
            if (out != NULL)
                out[outIdx] = (char)c;
            outIdx++;
        }
    }

    return outIdx;
}

/*
 * Print human readable version of X509_NAME to provided BIO.
 *
 * bio    - output BIO to place name string. Does not include null terminator.
 * name   - input name to convert to string
 * indent - number of indent spaces to prepend to name string, and to every
 *          line with XN_FLAG_SEP_MULTILINE
 * flags  - flags to control function behavior, as in OpenSSL:
 *              XN_FLAG_SEP_COMMA_PLUS, XN_FLAG_SEP_CPLUS_SPC,
 *              XN_FLAG_SEP_SPLUS_SPC, XN_FLAG_SEP_MULTILINE - entry
 *                                      separator, ", " when none is set
 *              XN_FLAG_FN_SN, XN_FLAG_FN_LN, XN_FLAG_FN_NONE - attribute
 *                                      name style, XN_FLAG_FN_OID prints
 *                                      short names
 *              XN_FLAG_FN_ALIGN      - pad the attribute name
 *              XN_FLAG_DN_REV        - print name reversed
 *              XN_FLAG_SPC_EQ        - spaces before and after '='
 *              ASN1_STRFLGS_ESC_2253 - backslash escape the RFC 2253
 *                                      special characters in values
 *              ASN1_STRFLGS_ESC_CTRL - escape control characters as \XX
 *              ASN1_STRFLGS_ESC_MSB  - escape bytes above 0x7F as \XX
 *          Multi-valued RDNs are flattened: their attributes are separated
 *          like RDNs.
 *
 * Returns WOLFSSL_SUCCESS (1) on success, WOLFSSL_FAILURE (0) on failure.
 */
int wolfSSL_X509_NAME_print_ex(WOLFSSL_BIO* bio, WOLFSSL_X509_NAME* name,
                int indent, unsigned long flags)
{
    int i, count = 0;
    int eqSz = 1;
    const char* eqStr = "=";
    int sepSz = 2;
    const char* sep = ", ";
    int lineIndent = 0;
    int fnOpt;
    int fnWidth = 0;
    WOLFSSL_X509_NAME_ENTRY* ne;
    WOLFSSL_ASN1_STRING* str;

    WOLFSSL_ENTER("wolfSSL_X509_NAME_print_ex");

    if ((name == NULL) || (bio == NULL))
        return WOLFSSL_FAILURE;

    if (indent < 0)
        indent = 0;

    switch (flags & WOLFSSL_XN_FLAG_SEP_MASK) {
        case WOLFSSL_XN_FLAG_SEP_COMMA_PLUS:
            sep = ",";
            sepSz = 1;
            break;
        case WOLFSSL_XN_FLAG_SEP_SPLUS_SPC:
            sep = "; ";
            sepSz = 2;
            break;
        case WOLFSSL_XN_FLAG_SEP_MULTILINE:
            sep = "\n";
            sepSz = 1;
            lineIndent = indent;
            break;
        default:
            /* XN_FLAG_SEP_CPLUS_SPC or no separator flag */
            break;
    }

    if (flags & WOLFSSL_XN_FLAG_SPC_EQ) {
        eqStr = " = ";
        eqSz = 3;
    }

    fnOpt = (int)(flags & WOLFSSL_XN_FLAG_FN_MASK);
    if (flags & WOLFSSL_XN_FLAG_FN_ALIGN) {
        if (fnOpt == WOLFSSL_XN_FLAG_FN_SN)
            fnWidth = 10;
        else if (fnOpt == WOLFSSL_XN_FLAG_FN_LN)
            fnWidth = 25;
    }

    for (i = 0; i < indent; i++) {
        if (wolfSSL_BIO_write(bio, " ", 1) != 1)
            return WOLFSSL_FAILURE;
    }

    count = wolfSSL_X509_NAME_entry_count(name);

    for (i = 0; i < count; i++) {
        const char* attr = NULL;
        int attrSz = 0;
        int padSz = 0;
        int valSz;
        int tmpSz;
        int idx;
        int j;
        char* tmp;

        if (flags & WOLFSSL_XN_FLAG_DN_REV) {
            ne = wolfSSL_X509_NAME_get_entry(name, count - i - 1);
        }
        else {
            ne = wolfSSL_X509_NAME_get_entry(name, i);
        }
        if (ne == NULL)
            return WOLFSSL_FAILURE;

        str = wolfSSL_X509_NAME_ENTRY_get_data(ne);
        if (str == NULL)
            return WOLFSSL_FAILURE;

        if (fnOpt == WOLFSSL_XN_FLAG_FN_NONE) {
            /* no attribute name */
        }
#ifdef OPENSSL_EXTRA
        else if (fnOpt == WOLFSSL_XN_FLAG_FN_LN) {
            attr = wolfSSL_OBJ_nid2ln(ne->nid);
            if (attr == NULL)
                return WOLFSSL_FAILURE;
            attrSz = (int)XSTRLEN(attr);
        }
#endif
        else {
            /* attrSz is without null terminator */
            attrSz = get_dn_attr_by_nid(ne->nid, &attr);
            if (attrSz == 0 || attr == NULL)
                return WOLFSSL_FAILURE;
        }
        if (attrSz < fnWidth)
            padSz = fnWidth - attrSz;

        /* escaping can triple the value length */
        if (str->length < 0 || str->length > INT_MAX / 4)
            return WOLFSSL_FAILURE;

        valSz = wolfssl_x509_name_esc_value(str->data, str->length, flags,
                                            NULL);

        /* attribute, padding, '=', value and separator, +1 for empty */
        tmpSz = attrSz + padSz + eqSz + valSz + sepSz + 1;
        tmp = (char*)XMALLOC((size_t)tmpSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        if (tmp == NULL)
            return WOLFSSL_FAILURE;

        idx = 0;
        if (fnOpt != WOLFSSL_XN_FLAG_FN_NONE) {
            XMEMCPY(tmp, attr, (size_t)attrSz);
            idx = attrSz;
            XMEMSET(tmp + idx, ' ', (size_t)padSz);
            idx += padSz;
            XMEMCPY(tmp + idx, eqStr, (size_t)eqSz);
            idx += eqSz;
        }
        (void)wolfssl_x509_name_esc_value(str->data, str->length, flags,
                                          tmp + idx);
        idx += valSz;
        if (i < count - 1) {
            XMEMCPY(tmp + idx, sep, (size_t)sepSz);
            idx += sepSz;
        }

        if (wolfSSL_BIO_write(bio, tmp, idx) != idx) {
            XFREE(tmp, NULL, DYNAMIC_TYPE_TMP_BUFFER);
            return WOLFSSL_FAILURE;
        }

        XFREE(tmp, NULL, DYNAMIC_TYPE_TMP_BUFFER);

        if (i < count - 1) {
            for (j = 0; j < lineIndent; j++) {
                if (wolfSSL_BIO_write(bio, " ", 1) != 1)
                    return WOLFSSL_FAILURE;
            }
        }
    }

    return WOLFSSL_SUCCESS;
}

#ifndef NO_FILESYSTEM
int wolfSSL_X509_NAME_print_ex_fp(XFILE file, WOLFSSL_X509_NAME* name,
        int indent, unsigned long flags)
{
    WOLFSSL_BIO* bio;
    int ret;

    WOLFSSL_ENTER("wolfSSL_X509_NAME_print_ex_fp");

    if (!(bio = wolfSSL_BIO_new_fp(file, WOLFSSL_BIO_NOCLOSE))) {
        WOLFSSL_MSG("wolfSSL_BIO_new_fp error");
        return WOLFSSL_FAILURE;
    }

    ret = wolfSSL_X509_NAME_print_ex(bio, name, indent, flags);

    wolfSSL_BIO_free(bio);

    return ret;
}
#endif /* NO_FILESYSTEM */
#endif /* !NO_BIO */

#ifndef NO_WOLFSSL_STUB
WOLFSSL_ASN1_BIT_STRING* wolfSSL_X509_get0_pubkey_bitstr(const WOLFSSL_X509* x)
{
    (void)x;
    WOLFSSL_ENTER("wolfSSL_X509_get0_pubkey_bitstr");
    WOLFSSL_STUB("X509_get0_pubkey_bitstr");

    return NULL;
}
#endif

#ifdef OPENSSL_ALL
WOLFSSL_X509_LOOKUP_TYPE wolfSSL_X509_OBJECT_get_type(
        const WOLFSSL_X509_OBJECT* obj)
{
    if (obj == NULL)
        return WOLFSSL_X509_LU_NONE;
    return obj->type;
}

WOLFSSL_X509_OBJECT* wolfSSL_X509_OBJECT_new(void)
{
    WOLFSSL_X509_OBJECT* ret = (WOLFSSL_X509_OBJECT*)
            XMALLOC(sizeof(WOLFSSL_X509_OBJECT), NULL, DYNAMIC_TYPE_OPENSSL);
    if (ret != NULL)
        XMEMSET(ret, 0, sizeof(WOLFSSL_X509_OBJECT));
    return ret;
}

void wolfSSL_X509_OBJECT_free(WOLFSSL_X509_OBJECT *obj)
{
    WOLFSSL_ENTER("wolfSSL_X509_OBJECT_free");
    if (obj != NULL) {
        if (obj->type == WOLFSSL_X509_LU_X509) {
            wolfSSL_X509_free(obj->data.x509);
        }
    #ifdef HAVE_CRL
        else if (obj->type == WOLFSSL_X509_LU_CRL) {
            wolfSSL_X509_CRL_free(obj->data.crl);
        }
    #endif
        else {
            /* We don't free as this will point to
             * store->cm->crl which we don't own */
            WOLFSSL_MSG("Not free'ing CRL in WOLFSSL_X509_OBJECT");
        }
        XFREE(obj, NULL, DYNAMIC_TYPE_OPENSSL);
    }
}

WOLFSSL_X509_OBJECT *wolfSSL_X509_OBJECT_retrieve_by_subject(
        WOLF_STACK_OF(WOLFSSL_X509_OBJECT) *sk,
        WOLFSSL_X509_LOOKUP_TYPE type,
        WOLFSSL_X509_NAME *name)
{
    int i;

    WOLFSSL_ENTER("wolfSSL_X509_OBJECT_retrieve_by_subject");

    if (sk == NULL || name == NULL)
        return NULL;

    for (i = 0; i < wolfSSL_sk_X509_OBJECT_num(sk); i++) {
        WOLFSSL_X509_OBJECT* obj = (WOLFSSL_X509_OBJECT *)
            wolfSSL_sk_X509_OBJECT_value(sk, i);
        if (obj != NULL && obj->type == type &&
            wolfSSL_X509_NAME_cmp(
                wolfSSL_X509_get_subject_name(obj->data.x509), name) == 0)
            return obj;
    }
    return NULL;
}
#endif /* OPENSSL_ALL */

#ifndef NO_WOLFSSL_STUB
WOLFSSL_X509_OBJECT* wolfSSL_sk_X509_OBJECT_delete(
    WOLF_STACK_OF(WOLFSSL_X509_OBJECT)* sk, int i)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_OBJECT_delete");
    WOLFSSL_STUB("wolfSSL_sk_X509_OBJECT_delete");
    (void)sk;
    (void)i;
    return NULL;
}
#endif

WOLFSSL_X509 *wolfSSL_X509_OBJECT_get0_X509(const WOLFSSL_X509_OBJECT *obj)
{
    if (obj != NULL && obj->type == WOLFSSL_X509_LU_X509)
        return obj->data.x509;
    return NULL;
}

WOLFSSL_X509_CRL *wolfSSL_X509_OBJECT_get0_X509_CRL(WOLFSSL_X509_OBJECT *obj)
{
    if (obj != NULL && obj->type == WOLFSSL_X509_LU_CRL)
        return obj->data.crl;
    return NULL;
}

#endif /* OPENSSL_ALL || (OPENSSL_EXTRA && (HAVE_STUNNEL || WOLFSSL_NGINX ||
        * HAVE_LIGHTY || WOLFSSL_HAPROXY || WOLFSSL_OPENSSH ||
        * HAVE_SBLIM_SFCB)) */


#if defined(OPENSSL_EXTRA)

int wolfSSL_sk_X509_num(const WOLF_STACK_OF(WOLFSSL_X509) *s)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_num");

    if (s == NULL)
        return WOLFSSL_FATAL_ERROR;
    return (int)s->num;
}

#endif /* OPENSSL_EXTRA */

#ifdef HAVE_EX_DATA_CRYPTO
int wolfSSL_X509_get_ex_new_index(int idx, void *arg,
                                  WOLFSSL_CRYPTO_EX_new* new_func,
                                  WOLFSSL_CRYPTO_EX_dup* dup_func,
                                  WOLFSSL_CRYPTO_EX_free* free_func)
{
    WOLFSSL_ENTER("wolfSSL_X509_get_ex_new_index");

    return wolfssl_local_get_ex_new_index(WOLF_CRYPTO_EX_INDEX_X509, idx, arg,
                                    new_func, dup_func, free_func);
}
#endif

#if defined(OPENSSL_EXTRA) || defined(OPENSSL_EXTRA_X509_SMALL)
void *wolfSSL_X509_get_ex_data(WOLFSSL_X509 *x509, int idx)
{
    WOLFSSL_ENTER("wolfSSL_X509_get_ex_data");
#ifdef HAVE_EX_DATA
    if (x509 != NULL) {
        return wolfSSL_CRYPTO_get_ex_data(&x509->ex_data, idx);
    }
#else
    (void)x509;
    (void)idx;
#endif
    return NULL;
}

int wolfSSL_X509_set_ex_data(WOLFSSL_X509 *x509, int idx, void *data)
{
    WOLFSSL_ENTER("wolfSSL_X509_set_ex_data");
#ifdef HAVE_EX_DATA
    if (x509 != NULL) {
        return wolfSSL_CRYPTO_set_ex_data(&x509->ex_data, idx, data);
    }
#else
    (void)x509;
    (void)idx;
    (void)data;
#endif
    return WOLFSSL_FAILURE;
}

#ifdef HAVE_EX_DATA_CLEANUP_HOOKS
int wolfSSL_X509_set_ex_data_with_cleanup(
    WOLFSSL_X509 *x509,
    int idx,
    void *data,
    wolfSSL_ex_data_cleanup_routine_t cleanup_routine)
{
    WOLFSSL_ENTER("wolfSSL_X509_set_ex_data_with_cleanup");
    if (x509 != NULL)
    {
        return wolfSSL_CRYPTO_set_ex_data_with_cleanup(&x509->ex_data, idx,
                                                       data, cleanup_routine);
    }
    return WOLFSSL_FAILURE;
}
#endif /* HAVE_EX_DATA_CLEANUP_HOOKS */
#endif /* OPENSSL_EXTRA || OPENSSL_EXTRA_X509_SMALL */


#ifndef NO_ASN
int wolfSSL_X509_check_host(WOLFSSL_X509 *x, const char *chk, size_t chklen,
                    unsigned int flags, char **peername)
{
    int         ret;
    size_t      i;
    WC_DECLARE_VAR(dCert, DecodedCert, 1, 0);

    WOLFSSL_ENTER("wolfSSL_X509_check_host");

    /* flags and peername not needed for Nginx. */
    (void)peername;

    if ((x == NULL) || (chk == NULL)) {
        WOLFSSL_MSG("Invalid parameter");
        return WOLFSSL_FAILURE;
    }

    if (flags & WOLFSSL_NO_WILDCARDS) {
        WOLFSSL_MSG("X509_CHECK_FLAG_NO_WILDCARDS not yet implemented");
        return WOLFSSL_FAILURE;
    }
    if (flags & WOLFSSL_NO_PARTIAL_WILDCARDS) {
        WOLFSSL_MSG("X509_CHECK_FLAG_NO_PARTIAL_WILDCARDS not yet implemented");
        return WOLFSSL_FAILURE;
    }
    if (flags & WOLFSSL_MULTI_LABEL_WILDCARDS) {
        WOLFSSL_MSG("X509_CHECK_FLAG_NO_PARTIAL_WILDCARDS not yet implemented");
        return WOLFSSL_FAILURE;
    }

#ifdef WOLFSSL_SMALL_STACK
    dCert = (DecodedCert *)XMALLOC(sizeof(*dCert), x->heap,
                                   DYNAMIC_TYPE_DCERT);
    if (dCert == NULL) {
        WOLFSSL_MSG("\tout of memory");
        return WOLFSSL_FATAL_ERROR;
    }
#endif

    InitDecodedCert(dCert, x->derCert->buffer, x->derCert->length, NULL);
    ret = ParseCertRelative(dCert, CERT_TYPE, 0, NULL, NULL);
    if (ret != 0) {
        goto out;
    }

    /* Replicate openssl behavior for checklen */
    if (chklen == 0) {
        chklen = (size_t)(XSTRLEN(chk));
    }
    else {
        for (i = 0; i < (chklen > 1 ? chklen - 1 : chklen); i++) {
            if (chk[i] == '\0') {
                ret = WOLFSSL_FATAL_ERROR;
                goto out;
            }
        }
    }
    if (chklen > 1 && (chk[chklen - 1] == '\0')) {
        chklen--;
    }

#ifdef WOLFSSL_IP_ALT_NAME
    ret = CheckIPAddr(dCert, (char *)chk, chklen);
    if (ret == 0) {
        goto out;
    }
#endif /* WOLFSSL_IP_ALT_NAME */

    ret = CheckHostName(dCert, (char *)chk, chklen, flags, 0);

out:

    FreeDecodedCert(dCert);
    WC_FREE_VAR_EX(dCert, x->heap, DYNAMIC_TYPE_DCERT);

    if (ret != 0)
        return WOLFSSL_FAILURE;
    return WOLFSSL_SUCCESS;
}


int wolfSSL_X509_check_ip_asc(WOLFSSL_X509 *x, const char *ipasc,
        unsigned int flags)
{
    int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
    WC_DECLARE_VAR(dCert, DecodedCert, 1, 0);

    WOLFSSL_ENTER("wolfSSL_X509_check_ip_asc");

    /* flags not yet implemented */
    (void)flags;

    if ((x == NULL) || (x->derCert == NULL) || (ipasc == NULL)) {
        WOLFSSL_MSG("Invalid parameter");
    }
    else {
        ret = WOLFSSL_SUCCESS;
    }

#ifdef WOLFSSL_SMALL_STACK
    if (ret == WOLFSSL_SUCCESS) {
        dCert = (DecodedCert *)XMALLOC(sizeof(*dCert), x->heap,
                                       DYNAMIC_TYPE_DCERT);
        if (dCert == NULL) {
            WOLFSSL_MSG("\tout of memory");
            ret = WOLFSSL_FAILURE;
        }
    }
#endif

    if (ret == WOLFSSL_SUCCESS) {
        InitDecodedCert(dCert, x->derCert->buffer, x->derCert->length, NULL);
        ret = ParseCertRelative(dCert, CERT_TYPE, 0, NULL, NULL);
        if (ret != 0) {
            ret = WOLFSSL_FAILURE;
        }
        else {
            ret = CheckIPAddr(dCert, ipasc, (size_t)XSTRLEN(ipasc));
            if (ret != 0) {
                ret = WOLFSSL_FAILURE;
            }
            else {
                ret = WOLFSSL_SUCCESS;
            }
        }
        FreeDecodedCert(dCert);
    }

#ifdef WOLFSSL_SMALL_STACK
    if (x != NULL) {
        XFREE(dCert, x->heap, DYNAMIC_TYPE_DCERT);
    }
#endif

    return ret;
}
#endif

#if defined(OPENSSL_EXTRA) && defined(WOLFSSL_CERT_GEN)
int wolfSSL_X509_check_email(WOLFSSL_X509 *x, const char *chk, size_t chkLen,
                             unsigned int flags)
{
    WOLFSSL_X509_NAME *subjName;
    int emailLen;
    char *emailBuf;

    (void)flags;

    WOLFSSL_ENTER("wolfSSL_X509_check_email");

    if ((x == NULL) || (chk == NULL)) {
        WOLFSSL_MSG("Invalid parameter");
        return WOLFSSL_FAILURE;
    }

    subjName = wolfSSL_X509_get_subject_name(x);
    if (subjName == NULL)
        return WOLFSSL_FAILURE;

    /* Call with NULL buffer to get required length. */
    emailLen = wolfSSL_X509_NAME_get_text_by_NID(subjName, WC_NID_emailAddress,
                                                 NULL, 0);
    if (emailLen < 0)
        return WOLFSSL_FAILURE;

    ++emailLen; /* Add 1 for the NUL. */

    emailBuf = (char*)XMALLOC(emailLen, x->heap, DYNAMIC_TYPE_OPENSSL);
    if (emailBuf == NULL)
        return WOLFSSL_FAILURE;

    emailLen = wolfSSL_X509_NAME_get_text_by_NID(subjName, WC_NID_emailAddress,
                                                 emailBuf, emailLen);
    if (emailLen < 0) {
        XFREE(emailBuf, x->heap, DYNAMIC_TYPE_OPENSSL);
        return WOLFSSL_FAILURE;
    }

    if (chkLen == 0)
        chkLen = XSTRLEN(chk);

    if (chkLen != (size_t)emailLen
     || XSTRNCMP(chk, emailBuf, chkLen)) {
        XFREE(emailBuf, x->heap, DYNAMIC_TYPE_OPENSSL);
        return WOLFSSL_FAILURE;
    }

    XFREE(emailBuf, x->heap, DYNAMIC_TYPE_OPENSSL);
    return WOLFSSL_SUCCESS;
}
#endif /* OPENSSL_EXTRA && WOLFSSL_CERT_GEN */

#if defined(OPENSSL_ALL) || defined(WOLFSSL_NGINX) || defined(WOLFSSL_HAPROXY) \
    || defined(OPENSSL_EXTRA) || defined(HAVE_LIGHTY)

int wolfSSL_X509_NAME_digest(const WOLFSSL_X509_NAME *name,
        const WOLFSSL_EVP_MD *type, unsigned char *md, unsigned int *len)
{
    WOLFSSL_ENTER("wolfSSL_X509_NAME_digest");

    if (name == NULL || type == NULL)
        return WOLFSSL_FAILURE;

#if !defined(NO_FILESYSTEM) && !defined(NO_PWDBASED)
    return wolfSSL_EVP_Digest((unsigned char*)name->name,
                              name->sz, md, len, type, NULL);
#else
    (void)md;
    (void)len;
    return NOT_COMPILED_IN;
#endif
}

#endif /* OPENSSL_ALL || WOLFSSL_NGINX || WOLFSSL_HAPROXY ||
    OPENSSL_EXTRA || HAVE_LIGHTY */

#if defined(WOLFSSL_NGINX) || defined(WOLFSSL_HAPROXY) || \
    defined(OPENSSL_EXTRA) || defined(OPENSSL_ALL)

void wolfSSL_X509_email_free(WOLF_STACK_OF(WOLFSSL_STRING) *sk)
{
    wolfSSL_sk_pop_free(sk, NULL);
}

static int x509_aia_append_string(WOLFSSL_STACK* list, const byte* uri,
        word32 uriSz)
{
    WOLFSSL_STRING url = (WOLFSSL_STRING)XMALLOC(uriSz + 1, NULL,
            DYNAMIC_TYPE_OPENSSL);
    if (url == NULL)
        return -1;
    XMEMCPY(url, uri, uriSz);
    url[uriSz] = '\0';

    if (wolfSSL_sk_push(list, url) <= 0) {
        XFREE(url, NULL, DYNAMIC_TYPE_OPENSSL);
        return -1;
    }

    return 0;
}

static WOLFSSL_STACK* x509_get1_aia_by_method(WOLFSSL_X509* x, word32 method,
    const byte* fallback, int fallbackSz)
{
    WOLFSSL_STACK* ret = NULL;
    int i;

    if (x == NULL)
        return NULL;

    ret = wolfSSL_sk_WOLFSSL_STRING_new();
    if (ret == NULL)
        return NULL;

    /* Build from multi-entry list when available; otherwise fall back to the
     * legacy single-entry fields to preserve previous behavior. */
    if (x->authInfoListSz > 0) {
        for (i = 0; i < x->authInfoListSz; i++) {
            if (x->authInfoList[i].method != method ||
                    x->authInfoList[i].uri == NULL ||
                    x->authInfoList[i].uriSz == 0) {
                continue;
            }

            if (x509_aia_append_string(ret, x->authInfoList[i].uri,
                    x->authInfoList[i].uriSz) != 0) {
                wolfSSL_X509_email_free(ret);
                return NULL;
            }
        }
    }
    /* Only use fallback when nothing was found in the list */
    if (wolfSSL_sk_num(ret) == 0 && fallback != NULL && fallbackSz > 0) {
        if (x509_aia_append_string(ret, fallback, (word32)fallbackSz) != 0) {
            wolfSSL_X509_email_free(ret);
            return NULL;
        }
    }

    /* Return NULL when empty */
    if (wolfSSL_sk_num(ret) == 0) {
        wolfSSL_X509_email_free(ret);
        ret = NULL;
    }

    return ret;
}

WOLF_STACK_OF(WOLFSSL_STRING) *wolfSSL_X509_get1_ocsp(WOLFSSL_X509 *x)
{
    if (x == NULL)
        return NULL;
    return x509_get1_aia_by_method(x, AIA_OCSP_OID, x->authInfo, x->authInfoSz);
}

int wolfSSL_X509_get_aia_overflow(WOLFSSL_X509 *x)
{
    int overflow = 0;

    WOLFSSL_ENTER("wolfSSL_X509_get_aia_overflow");

    if (x != NULL) {
        overflow = x->authInfoListOverflow;
    }

    WOLFSSL_LEAVE("wolfSSL_X509_get_aia_overflow", overflow);

    return overflow;
}

#ifdef WOLFSSL_ASN_CA_ISSUER
WOLF_STACK_OF(WOLFSSL_STRING) *wolfSSL_X509_get1_ca_issuers(WOLFSSL_X509 *x)
{
    if (x == NULL)
        return NULL;
    return x509_get1_aia_by_method(x, AIA_CA_ISSUER_OID, x->authInfoCaIssuer,
            x->authInfoCaIssuerSz);
}
#endif /* WOLFSSL_ASN_CA_ISSUER */

int wolfSSL_X509_check_issued(WOLFSSL_X509 *issuer, WOLFSSL_X509 *subject)
{
    WOLFSSL_X509_NAME *issuerName = wolfSSL_X509_get_issuer_name(subject);
    WOLFSSL_X509_NAME *subjectName = wolfSSL_X509_get_subject_name(issuer);

    if (issuerName == NULL || subjectName == NULL)
        return WOLFSSL_X509_V_ERR_SUBJECT_ISSUER_MISMATCH;

    /* Literal matching of encoded names and key ids. */
    if (issuerName->sz != subjectName->sz ||
           XMEMCMP(issuerName->name, subjectName->name, subjectName->sz) != 0) {
        return WOLFSSL_X509_V_ERR_SUBJECT_ISSUER_MISMATCH;
    }

    if (subject->authKeyId != NULL && issuer->subjKeyId != NULL) {
        if (subject->authKeyIdSz != issuer->subjKeyIdSz ||
                XMEMCMP(subject->authKeyId, issuer->subjKeyId,
                        issuer->subjKeyIdSz) != 0) {
            return WOLFSSL_X509_V_ERR_SUBJECT_ISSUER_MISMATCH;
        }
    }

    return WOLFSSL_X509_V_OK;
}

#endif /* WOLFSSL_NGINX || WOLFSSL_HAPROXY || OPENSSL_EXTRA || OPENSSL_ALL */

#if defined(OPENSSL_EXTRA) || defined(WOLFSSL_WPAS_SMALL) || \
    defined(KEEP_PEER_CERT) || defined(SESSION_CERTS)
WOLFSSL_X509* wolfSSL_X509_dup(WOLFSSL_X509 *x)
{
    WOLFSSL_ENTER("wolfSSL_X509_dup");

    if (x == NULL) {
        WOLFSSL_MSG("Error: NULL input");
        return NULL;
    }

    if (x->derCert == NULL) {
        WOLFSSL_MSG("Error: NULL derCert parameter");
        return NULL;
    }

    return wolfSSL_X509_d2i_ex(NULL, x->derCert->buffer, x->derCert->length,
        x->heap);
}
#endif /* OPENSSL_EXTRA || WOLFSSL_WPAS_SMALL || KEEP_PEER_CERT || \
          SESSION_CERTS */

#if defined(OPENSSL_EXTRA)
int wolfSSL_X509_check_ca(WOLFSSL_X509 *x509)
{
    WOLFSSL_ENTER("wolfSSL_X509_check_ca");

    if (x509 == NULL)
        return WOLFSSL_FAILURE;
    if (x509->isCa)
        return 1;
    if (x509->extKeyUsageCrit)
        return 4;

    return 0;
}
#endif /* OPENSSL_EXTRA */

#if defined(OPENSSL_EXTRA) || defined(OPENSSL_EXTRA_X509_SMALL)
long wolfSSL_X509_get_version(const WOLFSSL_X509 *x509)
{
    int version = 0;

    WOLFSSL_ENTER("wolfSSL_X509_get_version");

    if (x509 == NULL) {
        WOLFSSL_MSG("invalid parameter");
        return 0L;
    }
    version = x509->version;
    if (version != 0)
        return (long)version - 1L;

    return 0L;
}
#endif /* OPENSSL_EXTRA || OPENSSL_EXTRA_X509_SMALL */

#if defined(OPENSSL_EXTRA)
int wolfSSL_X509_get_signature_nid(const WOLFSSL_X509 *x)
{
    if (x == NULL)
        return 0;

    return oid2nid((word32)x->sigOID, oidSigType);
}
#endif  /* OPENSSL_EXTRA */

#if defined(OPENSSL_EXTRA)
WOLFSSL_STACK* wolfSSL_sk_X509_new(WOLF_SK_COMPARE_CB(WOLFSSL_X509, cb))
{
    (void)cb;
    return wolfSSL_sk_X509_new_null();
}

WOLFSSL_STACK* wolfSSL_sk_X509_new_null(void)
{
    WOLFSSL_STACK* s = (WOLFSSL_STACK*)XMALLOC(sizeof(WOLFSSL_STACK), NULL,
            DYNAMIC_TYPE_OPENSSL);
    if (s != NULL) {
        XMEMSET(s, 0, sizeof(*s));
        s->type = STACK_TYPE_X509;
    }

    return s;
}
#endif  /* OPENSSL_EXTRA */

#ifdef OPENSSL_ALL

WOLFSSL_STACK* wolfSSL_sk_X509_OBJECT_new(void)
{
    WOLFSSL_STACK* s = (WOLFSSL_STACK*)XMALLOC(sizeof(WOLFSSL_STACK), NULL,
            DYNAMIC_TYPE_OPENSSL);
    WOLFSSL_ENTER("wolfSSL_sk_X509_OBJECT_new");
    if (s != NULL) {
        XMEMSET(s, 0, sizeof(*s));
        s->type = STACK_TYPE_X509_OBJ;
    }
    return s;
}

void wolfSSL_sk_X509_OBJECT_free(WOLFSSL_STACK* s)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_OBJECT_free");
    wolfSSL_sk_free(s);
}

void wolfSSL_sk_X509_OBJECT_pop_free(WOLFSSL_STACK* s,
        void (*f) (WOLFSSL_X509_OBJECT*))
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_OBJECT_pop_free");
    wolfSSL_sk_pop_free(s, (wolfSSL_sk_freefunc)f);
}

int wolfSSL_sk_X509_OBJECT_push(WOLFSSL_STACK* sk, WOLFSSL_X509_OBJECT* obj)
{
    WOLFSSL_ENTER("wolfSSL_sk_X509_OBJECT_push");

    if (sk == NULL || obj == NULL) {
        return WOLFSSL_FAILURE;
    }

    return wolfSSL_sk_push(sk, obj);
}

#endif /* OPENSSL_ALL */

#if defined(OPENSSL_EXTRA) || defined(OPENSSL_EXTRA_X509_SMALL)
/* unlike wolfSSL_X509_NAME_dup this does not malloc a duplicate, only deep
 * copy. "to" is expected to be a fresh blank name, if not pointers could be
 * lost */
int wolfSSL_X509_NAME_copy(const WOLFSSL_X509_NAME* from, WOLFSSL_X509_NAME* to)
{
    int i;

    WOLFSSL_ENTER("wolfSSL_X509_NAME_copy");

    if (from == NULL || to == NULL) {
        WOLFSSL_MSG("NULL parameter");
        return BAD_FUNC_ARG;
    }

#if defined(OPENSSL_ALL) || defined(WOLFSSL_NGINX) || defined(HAVE_LIGHTY)
    if (from->rawLen > 0) {
        if (from->rawLen > ASN_NAME_MAX) {
            WOLFSSL_MSG("Bad raw size");
            return BAD_FUNC_ARG;
        }
        XMEMCPY(to->raw, from->raw, from->rawLen);
        to->rawLen = from->rawLen;
    }
#endif

    if (from->dynamicName) {
        to->name = (char*)XMALLOC(from->sz, to->heap, DYNAMIC_TYPE_SUBJECT_CN);
        if (to->name == NULL)
            return WOLFSSL_FAILURE;
        to->dynamicName = 1;
    }
    XMEMCPY(to->name, from->name, from->sz);
    to->sz = from->sz;

    for (i = 0; i < MAX_NAME_ENTRIES; i++) {
        WOLFSSL_X509_NAME_ENTRY* ne = wolfSSL_X509_NAME_get_entry(from, i);
        if (ne != NULL) {
            if (wolfSSL_X509_NAME_add_entry(to, ne, i, 1) != WOLFSSL_SUCCESS) {
                return WOLFSSL_FAILURE;
            }
        }
    }
    to->entrySz = from->entrySz;
    return WOLFSSL_SUCCESS;
}


/* copies over information from "name" to the "cert" subject name
 * returns WOLFSSL_SUCCESS on success */
int wolfSSL_X509_set_subject_name(WOLFSSL_X509 *cert, WOLFSSL_X509_NAME *name)
{
    WOLFSSL_ENTER("wolfSSL_X509_set_subject_name");
    if (cert == NULL || name == NULL)
        return WOLFSSL_FAILURE;

    FreeX509Name(&cert->subject);
    InitX509Name(&cert->subject, 0, cert->heap);

    if (wolfSSL_X509_NAME_copy(name, &cert->subject) != WOLFSSL_SUCCESS) {
        FreeX509Name(&cert->subject);
        return WOLFSSL_FAILURE;
    }

    cert->subject.x509 = cert;
    return WOLFSSL_SUCCESS;
}


/* copies over information from "name" to the "cert" issuer name
 * returns WOLFSSL_SUCCESS on success */
int wolfSSL_X509_set_issuer_name(WOLFSSL_X509 *cert, WOLFSSL_X509_NAME *name)
{
    WOLFSSL_ENTER("wolfSSL_X509_set_issuer_name");
    if (cert == NULL || name == NULL)
        return WOLFSSL_FAILURE;

    FreeX509Name(&cert->issuer);
    InitX509Name(&cert->issuer, 0, cert->heap);

    if (wolfSSL_X509_NAME_copy(name, &cert->issuer) != WOLFSSL_SUCCESS) {
        FreeX509Name(&cert->issuer);
        return WOLFSSL_FAILURE;
    }

    cert->issuer.x509 = cert;
    cert->issuerSet = 1;

    return WOLFSSL_SUCCESS;
}


int wolfSSL_X509_set_notAfter(WOLFSSL_X509* x509, const WOLFSSL_ASN1_TIME* t)
{
    if (x509 == NULL || t == NULL) {
        return WOLFSSL_FAILURE;
    }

    if (t->length < 0 || t->length > CTC_DATE_SIZE - 2) {
        return WOLFSSL_FAILURE;
    }

    x509->notAfter.type = t->type;
    x509->notAfter.length = t->length;

    XMEMCPY(x509->notAfter.data, t->data, CTC_DATE_SIZE);

    return WOLFSSL_SUCCESS;
}

int wolfSSL_X509_set_notBefore(WOLFSSL_X509* x509, const WOLFSSL_ASN1_TIME* t)
{
    if (x509 == NULL || t == NULL) {
        return WOLFSSL_FAILURE;
    }

    if (t->length < 0 || t->length > CTC_DATE_SIZE - 2) {
        return WOLFSSL_FAILURE;
    }

    x509->notBefore.type = t->type;
    x509->notBefore.length = t->length;

    XMEMCPY(x509->notBefore.data, t->data, CTC_DATE_SIZE);

    return WOLFSSL_SUCCESS;
}

int wolfSSL_X509_set1_notAfter(WOLFSSL_X509* x509, const WOLFSSL_ASN1_TIME *t)
{
    return wolfSSL_X509_set_notAfter(x509, t);
}

int wolfSSL_X509_set1_notBefore(WOLFSSL_X509* x509, const WOLFSSL_ASN1_TIME *t)
{
    return wolfSSL_X509_set_notBefore(x509, t);
}

int wolfSSL_X509_set_serialNumber(WOLFSSL_X509* x509, WOLFSSL_ASN1_INTEGER* s)
{
    WOLFSSL_ENTER("wolfSSL_X509_set_serialNumber");
    if (x509 == NULL || s == NULL || s->data == NULL ||
            s->length >= EXTERNAL_SERIAL_SIZE)
        return WOLFSSL_FAILURE;

    /* WOLFSSL_ASN1_INTEGER has type | size | data
     * Sanity check that the data is actually in ASN format */
    if (s->length < 3 || s->data[0] != ASN_INTEGER ||
            s->data[1] != s->length - 2) {
        return WOLFSSL_FAILURE;
    }
    XMEMCPY(x509->serial, s->data + 2, s->length - 2);
    x509->serialSz = s->length - 2;
    x509->serial[x509->serialSz] = 0;

    return WOLFSSL_SUCCESS;
}


int wolfSSL_X509_set_pubkey(WOLFSSL_X509 *cert, WOLFSSL_EVP_PKEY *pkey)
{
    byte* p = NULL;
    int derSz = 0;
    WOLFSSL_ENTER("wolfSSL_X509_set_pubkey");

    if (cert == NULL || pkey == NULL)
        return WOLFSSL_FAILURE;

    /* Regenerate since pkey->pkey.ptr may contain private key */
    switch (pkey->type) {
#if (defined(WOLFSSL_KEY_GEN) || defined(OPENSSL_EXTRA)) && !defined(NO_RSA)
    case WC_EVP_PKEY_RSA:
        {
            RsaKey* rsa;

            if (pkey->rsa == NULL || pkey->rsa->internal == NULL)
                return WOLFSSL_FAILURE;

            rsa = (RsaKey*)pkey->rsa->internal;
            derSz = wc_RsaPublicKeyDerSize(rsa, 1);
            if (derSz <= 0)
                return WOLFSSL_FAILURE;

            p = (byte*)XMALLOC(derSz, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);
            if (p == NULL)
                return WOLFSSL_FAILURE;

            if ((derSz = wc_RsaKeyToPublicDer(rsa, p, (word32)derSz)) <= 0) {
                XFREE(p, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);
                return WOLFSSL_FAILURE;
            }
            cert->pubKeyOID = RSAk;
        }
        break;
#endif /* (WOLFSSL_KEY_GEN || OPENSSL_EXTRA) && !NO_RSA */
#if !defined(HAVE_SELFTEST) && (defined(WOLFSSL_KEY_GEN) || \
        defined(WOLFSSL_CERT_GEN)) && !defined(NO_DSA)
    case WC_EVP_PKEY_DSA:
        {
            DsaKey* dsa;

            if (pkey->dsa == NULL || pkey->dsa->internal == NULL)
                return WOLFSSL_FAILURE;

            dsa = (DsaKey*)pkey->dsa->internal;
            /* size of pub, priv, p, q, g + ASN.1 additional information */
            derSz = 5 * mp_unsigned_bin_size(&dsa->g) + MAX_ALGO_SZ;
            p = (byte*)XMALLOC(derSz, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);
            if (p == NULL)
                return WOLFSSL_FAILURE;

            if ((derSz = wc_DsaKeyToPublicDer(dsa, p, (word32)derSz)) <= 0) {
                XFREE(p, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);
                return WOLFSSL_FAILURE;
            }
            cert->pubKeyOID = DSAk;
        }
        break;
#endif /* !HAVE_SELFTEST && (WOLFSSL_KEY_GEN || WOLFSSL_CERT_GEN) && !NO_DSA */
#ifdef HAVE_ECC
    case WC_EVP_PKEY_EC:
        {
            ecc_key* ecc;

            if (pkey->ecc == NULL || pkey->ecc->internal == NULL)
                return WOLFSSL_FAILURE;

            ecc = (ecc_key*)pkey->ecc->internal;
            derSz = wc_EccPublicKeyDerSize(ecc, 1);
            if (derSz <= 0)
                return WOLFSSL_FAILURE;

            p = (byte*)XMALLOC(derSz, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);
            if (p == NULL)
                return WOLFSSL_FAILURE;

            if ((derSz = wc_EccPublicKeyToDer(ecc, p, (word32)derSz, 1)) <= 0) {
                XFREE(p, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);
                return WOLFSSL_FAILURE;
            }
            cert->pubKeyOID = ECDSAk;
        }
        break;
#endif
#if defined(WOLFSSL_HAVE_MLDSA) && defined(WOLFSSL_MLDSA_PUBLIC_KEY) && \
    !defined(WOLFSSL_MLDSA_NO_ASN1) && defined(WC_ENABLE_ASYM_KEY_EXPORT)
    case WC_EVP_PKEY_DILITHIUM:
        {
            /* Decode key DER (private or public) and export public part. */
            wc_MlDsaKey* mldsa;
            word32 idx = 0;
            int oidSum = 0;
            int decodeOk = 0;

            mldsa = (wc_MlDsaKey*)XMALLOC(sizeof(wc_MlDsaKey), cert->heap,
                    DYNAMIC_TYPE_MLDSA);
            if (mldsa == NULL) {
                WOLFSSL_MSG("Failed to allocate memory for wc_MlDsaKey");
                return WOLFSSL_FAILURE;
            }
            if (wc_MlDsaKey_Init(mldsa, cert->heap, INVALID_DEVID) != 0) {
                WOLFSSL_MSG("wc_MlDsaKey_Init error");
                XFREE(mldsa, cert->heap, DYNAMIC_TYPE_MLDSA);
                return WOLFSSL_FAILURE;
            }
        #ifdef WOLFSSL_MLDSA_PRIVATE_KEY
            PRIVATE_KEY_UNLOCK();
            if (wc_MlDsaKey_PrivateKeyDecode(mldsa,
                    (const byte*)pkey->pkey.ptr, (word32)pkey->pkey_sz,
                    &idx) == 0) {
                decodeOk = 1;
            }
            PRIVATE_KEY_LOCK();
        #endif
            if (!decodeOk) {
            #ifdef WOLFSSL_MLDSA_PRIVATE_KEY
                /* A failed PrivateKeyDecode may leave the level pinned;
                 * reset the key so PublicKeyDecode auto-detects it from
                 * the SPKI OID. */
                wc_MlDsaKey_Free(mldsa);
                if (wc_MlDsaKey_Init(mldsa, cert->heap, INVALID_DEVID) != 0) {
                    WOLFSSL_MSG("wc_MlDsaKey_Init error");
                    XFREE(mldsa, cert->heap, DYNAMIC_TYPE_MLDSA);
                    return WOLFSSL_FAILURE;
                }
            #endif
                idx = 0;
                if (wc_MlDsaKey_PublicKeyDecode(mldsa,
                        (const byte*)pkey->pkey.ptr, (word32)pkey->pkey_sz,
                        &idx) != 0) {
                    WOLFSSL_MSG("Error decoding ML-DSA public key");
                    wc_MlDsaKey_Free(mldsa);
                    XFREE(mldsa, cert->heap, DYNAMIC_TYPE_MLDSA);
                    return WOLFSSL_FAILURE;
                }
            }
            /* Map the parameter set to its OID with mldsa_get_oid_sum():
             * unlike wc_MlDsaKey_GetParams() it distinguishes FIPS204-draft
             * levels, keeping pubKeyOID consistent with the SPKI encoded
             * by wc_MlDsaKey_PublicKeyToDer(). */
            if (mldsa_get_oid_sum(mldsa, &oidSum) != 0) {
                WOLFSSL_MSG("Error getting ML-DSA OID");
                wc_MlDsaKey_Free(mldsa);
                XFREE(mldsa, cert->heap, DYNAMIC_TYPE_MLDSA);
                return WOLFSSL_FAILURE;
            }

            derSz = MLDSA_MAX_PUB_KEY_DER_SIZE;
            p = (byte*)XMALLOC(derSz, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);
            if (p == NULL) {
                WOLFSSL_MSG("malloc error");
                wc_MlDsaKey_Free(mldsa);
                XFREE(mldsa, cert->heap, DYNAMIC_TYPE_MLDSA);
                return WOLFSSL_FAILURE;
            }
            derSz = wc_MlDsaKey_PublicKeyToDer(mldsa, p, (word32)derSz, 1);
            wc_MlDsaKey_Free(mldsa);
            XFREE(mldsa, cert->heap, DYNAMIC_TYPE_MLDSA);
            if (derSz <= 0) {
                WOLFSSL_MSG("Error making ML-DSA public key DER");
                XFREE(p, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);
                return WOLFSSL_FAILURE;
            }
            cert->pubKeyOID = oidSum;
        }
        break;
#endif /* WOLFSSL_HAVE_MLDSA && WOLFSSL_MLDSA_PUBLIC_KEY &&
        * !WOLFSSL_MLDSA_NO_ASN1 && WC_ENABLE_ASYM_KEY_EXPORT */
#if defined(HAVE_ED25519) && defined(HAVE_ED25519_KEY_EXPORT)
    case WC_EVP_PKEY_ED25519:
        {
            word32 rawLen = ED25519_PUB_KEY_SIZE;

            if (pkey->ed25519 == NULL)
                return WOLFSSL_FAILURE;

            /* Store the RAW public key: wolfSSL keeps an X.509 Ed25519
             * public key as the bare key bytes (see StoreKey /
             * CopyDecodedToX509), not a SubjectPublicKeyInfo. */
            p = (byte*)XMALLOC(rawLen, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);
            if (p == NULL)
                return WOLFSSL_FAILURE;

            if (wc_ed25519_export_public(pkey->ed25519, p, &rawLen) != 0) {
                XFREE(p, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);
                return WOLFSSL_FAILURE;
            }
            derSz = (int)rawLen;
            cert->pubKeyOID = ED25519k;
        }
        break;
#endif
    default:
        return WOLFSSL_FAILURE;
    }
    XFREE(cert->pubKey.buffer, cert->heap, DYNAMIC_TYPE_PUBLIC_KEY);
    cert->pubKey.buffer = p;
    cert->pubKey.length = (unsigned int)derSz;

    return WOLFSSL_SUCCESS;
}

int wolfSSL_X509_set_version(WOLFSSL_X509* x509, long v)
{
    WOLFSSL_ENTER("wolfSSL_X509_set_version");
    if ((x509 == NULL) || (v < 0) || (v >= INT_MAX)) {
        return WOLFSSL_FAILURE;
    }
    x509->version = (int) v + 1;

    return WOLFSSL_SUCCESS;
}

#ifdef WOLFSSL_CERT_EXT
/* Set Subject Key Identifier from raw bytes.
 *
 * x509  - Certificate to modify
 * skid  - Raw SKID bytes
 * skidSz - Size of SKID in bytes
 *
 * Returns WOLFSSL_SUCCESS or WOLFSSL_FAILURE
 */
int wolfSSL_X509_set_subject_key_id(WOLFSSL_X509* x509,
    const unsigned char* skid, int skidSz)
{
    WOLFSSL_ENTER("wolfSSL_X509_set_subject_key_id");

    if (x509 == NULL || skid == NULL || skidSz <= 0) {
        return WOLFSSL_FAILURE;
    }

    /* Allocate/reallocate memory for subjKeyId */
    if (x509->subjKeyId == NULL || (int)x509->subjKeyIdSz < skidSz) {
        if (x509->subjKeyId != NULL) {
            XFREE(x509->subjKeyId, x509->heap, DYNAMIC_TYPE_X509_EXT);
        }
        x509->subjKeyId = (byte*)XMALLOC((word32)skidSz, x509->heap,
                                          DYNAMIC_TYPE_X509_EXT);
        if (x509->subjKeyId == NULL) {
            return WOLFSSL_FAILURE;
        }
    }

    XMEMCPY(x509->subjKeyId, skid, (word32)skidSz);
    x509->subjKeyIdSz = (word32)skidSz;
    x509->subjKeyIdSet = 1;

    return WOLFSSL_SUCCESS;
}

#ifndef NO_SHA
/* Set Subject Key Identifier by computing SHA-1 hash of the public key.
 *
 * x509 - Certificate to modify (must have public key set)
 *
 * Returns WOLFSSL_SUCCESS or WOLFSSL_FAILURE
 */
int wolfSSL_X509_set_subject_key_id_ex(WOLFSSL_X509* x509)
{
    byte hash[WC_SHA_DIGEST_SIZE];
    int ret;

    WOLFSSL_ENTER("wolfSSL_X509_set_subject_key_id_ex");

    if (x509 == NULL) {
        return WOLFSSL_FAILURE;
    }

    /* Check if public key has been set */
    if (x509->pubKey.buffer == NULL || x509->pubKey.length == 0) {
        WOLFSSL_MSG("Public key not set");
        return WOLFSSL_FAILURE;
    }

    /* Compute SHA-1 hash of the public key */
    ret = wc_ShaHash(x509->pubKey.buffer, x509->pubKey.length, hash);
    if (ret != 0) {
        WOLFSSL_MSG("wc_ShaHash failed");
        return WOLFSSL_FAILURE;
    }

    return wolfSSL_X509_set_subject_key_id(x509, hash, WC_SHA_DIGEST_SIZE);
}
#endif /* !NO_SHA */

/* Set Authority Key Identifier from raw bytes.
 * The bytes passed in are the keyIdentifier OCTET STRING contents only,
 * they must not be a pre-encoded AuthorityKeyIdentifier SEQUENCE.
 * The cert encoder wraps them in SEQUENCE { [0] keyIdentifier } at sign time.
 *
 * x509   - Certificate to modify
 * akid   - Raw AKID bytes
 * akidSz - Size of AKID in bytes
 *
 * Returns WOLFSSL_SUCCESS or WOLFSSL_FAILURE
 */
int wolfSSL_X509_set_authority_key_id(WOLFSSL_X509* x509,
    const unsigned char* akid, int akidSz)
{
    byte* newAkid = NULL;

    WOLFSSL_ENTER("wolfSSL_X509_set_authority_key_id");

    if (x509 == NULL || akid == NULL || akidSz <= 0) {
        return WOLFSSL_FAILURE;
    }

    /* Allocate new buffer up front so failure leaves prior state intact */
    newAkid = (byte*)XMALLOC((word32)akidSz, x509->heap, DYNAMIC_TYPE_X509_EXT);
    if (newAkid == NULL) {
        return WOLFSSL_FAILURE;
    }
    XMEMCPY(newAkid, akid, (word32)akidSz);

    /* Free any prior storage. authKeyIdSrc may be populated from a prior
     * parse cert operation. authKeyId aliases inside that buffer, so
     * authKeyIdSrc must be freed first to avoid a dangling authKeyId. */
    if (x509->authKeyIdSrc != NULL) {
        XFREE(x509->authKeyIdSrc, x509->heap, DYNAMIC_TYPE_X509_EXT);
        x509->authKeyIdSrc = NULL;
        x509->authKeyIdSrcSz = 0;
    }
    else if (x509->authKeyId != NULL) {
        XFREE(x509->authKeyId, x509->heap, DYNAMIC_TYPE_X509_EXT);
    }

    /* Store newAkid as authKeyId only, do not populate authKeyIdSrc.
     * When authKeyIdSrc is non-NULL, the encoder writes those bytes without
     * SEQUENCE/[0] wrapper. authKeyIdSrc must be NULL here so encoder does
     * wrap them. */
    x509->authKeyId = newAkid;
    x509->authKeyIdSz = (word32)akidSz;
    x509->authKeyIdSet = 1;

    return WOLFSSL_SUCCESS;
}

#ifndef NO_SHA
/* Set Authority Key Identifier from issuer certificate.
 * Extracts SKID from issuer (or computes from issuer's public key).
 *
 * x509   - Certificate to modify
 * issuer - Issuer certificate
 *
 * Returns WOLFSSL_SUCCESS or WOLFSSL_FAILURE
 */
int wolfSSL_X509_set_authority_key_id_ex(WOLFSSL_X509* x509,
    WOLFSSL_X509* issuer)
{
    byte hash[WC_SHA_DIGEST_SIZE];
    int ret;

    WOLFSSL_ENTER("wolfSSL_X509_set_authority_key_id_ex");

    if (x509 == NULL || issuer == NULL) {
        return WOLFSSL_FAILURE;
    }

    /* First try to use issuer's SKID if it's set */
    if (issuer->subjKeyIdSet && issuer->subjKeyId != NULL &&
        issuer->subjKeyIdSz > 0) {
        return wolfSSL_X509_set_authority_key_id(x509, issuer->subjKeyId,
                                                  (int)issuer->subjKeyIdSz);
    }

    /* Otherwise compute from issuer's public key */
    if (issuer->pubKey.buffer == NULL || issuer->pubKey.length == 0) {
        WOLFSSL_MSG("Issuer public key not available");
        return WOLFSSL_FAILURE;
    }

    ret = wc_ShaHash(issuer->pubKey.buffer, issuer->pubKey.length, hash);
    if (ret != 0) {
        WOLFSSL_MSG("wc_ShaHash failed");
        return WOLFSSL_FAILURE;
    }

    return wolfSSL_X509_set_authority_key_id(x509, hash, WC_SHA_DIGEST_SIZE);
}
#endif /* !NO_SHA */
#endif /* WOLFSSL_CERT_EXT */

#ifndef IGNORE_NETSCAPE_CERT_TYPE
/* Set Netscape Certificate Type extension.
 *
 * x509       - Certificate to modify
 * nsCertType - Bitwise OR of NS_SSL_CLIENT, NS_SSL_SERVER, etc.
 *
 * Returns WOLFSSL_SUCCESS or WOLFSSL_FAILURE
 */
int wolfSSL_X509_set_ns_cert_type(WOLFSSL_X509* x509, int nsCertType)
{
    WOLFSSL_ENTER("wolfSSL_X509_set_ns_cert_type");

    if (x509 == NULL) {
        return WOLFSSL_FAILURE;
    }

    x509->nsCertType = (byte)nsCertType;

    return WOLFSSL_SUCCESS;
}
#endif /* !IGNORE_NETSCAPE_CERT_TYPE */

#endif /* (OPENSSL_EXTRA || OPENSSL_EXTRA_X509_SMALL) && WOLFSSL_CERT_GEN */

#if (defined(OPENSSL_ALL) || defined(OPENSSL_EXTRA)) &&           \
    defined(WOLFSSL_CERT_GEN) && defined(WOLFSSL_CERT_REQ)

void wolfSSL_X509V3_set_ctx(WOLFSSL_X509V3_CTX* ctx, WOLFSSL_X509* issuer,
        WOLFSSL_X509* subject, WOLFSSL_X509* req, WOLFSSL_X509_CRL* crl,
        int flag)
{
    int ret = WOLFSSL_SUCCESS;
    WOLFSSL_ENTER("wolfSSL_X509V3_set_ctx");
    if (!ctx) {
        ret = WOLFSSL_FAILURE;
        WOLFSSL_MSG("wolfSSL_X509V3_set_ctx() called with null ctx.");
    }

    if (ret == WOLFSSL_SUCCESS && (ctx->x509 != NULL)) {
        ret = WOLFSSL_FAILURE;
        WOLFSSL_MSG("wolfSSL_X509V3_set_ctx() called "
                    "with ctx->x509 already allocated.");
    }

    if (ret == WOLFSSL_SUCCESS) {
        ctx->x509 = wolfSSL_X509_new_ex(
            (issuer && issuer->heap) ? issuer->heap :
            (subject && subject->heap) ? subject->heap :
            (req && req->heap) ? req->heap :
            NULL);
        if (!ctx->x509) {
            ret = WOLFSSL_FAILURE;
            WOLFSSL_MSG("wolfSSL_X509_new_ex() failed "
                        "in wolfSSL_X509V3_set_ctx().");
        }
    }

    /* Set parameters in ctx as long as ret == WOLFSSL_SUCCESS */
    if (ret == WOLFSSL_SUCCESS && issuer)
        ret = wolfSSL_X509_set_issuer_name(ctx->x509, &issuer->issuer);

    if (ret == WOLFSSL_SUCCESS && subject)
        ret = wolfSSL_X509_set_subject_name(ctx->x509, &subject->subject);

    if (ret == WOLFSSL_SUCCESS && req) {
        WOLFSSL_MSG("req not implemented.");
    }

    if (ret == WOLFSSL_SUCCESS && crl) {
        WOLFSSL_MSG("crl not implemented.");
    }

    if (ret == WOLFSSL_SUCCESS && flag) {
        WOLFSSL_MSG("flag not implemented.");
    }

    if (ret != WOLFSSL_SUCCESS) {
        WOLFSSL_MSG("Error setting WOLFSSL_X509V3_CTX parameters.");
    }
}

#ifndef NO_BIO
int wolfSSL_i2d_X509_REQ(WOLFSSL_X509* req, unsigned char** out)
{
    int derSz = 0;
    int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
    WOLFSSL_BIO* bio = NULL;
    WOLFSSL_ENTER("wolfSSL_i2d_X509_REQ");

    if (req == NULL || out == NULL) {
        return BAD_FUNC_ARG;
    }

    if (!(bio = wolfSSL_BIO_new(wolfSSL_BIO_s_mem()))) {
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_i2d_X509_REQ_bio(bio, req) != WOLFSSL_SUCCESS) {
        WOLFSSL_MSG("wolfSSL_i2d_X509_REQ_bio error");
        goto cleanup;
    }

    derSz = wolfSSL_BIO_get_len(bio);

    if (*out == NULL) {
        *out = (unsigned char*)XMALLOC(derSz, NULL, DYNAMIC_TYPE_OPENSSL);
        if (!*out) {
            WOLFSSL_MSG("malloc error");
            ret = MEMORY_E;
            goto cleanup;
        }
    }

    if (wolfSSL_BIO_read(bio, *out, derSz) != derSz) {
        WOLFSSL_MSG("wolfSSL_BIO_read error");
        goto cleanup;
    }

    ret = derSz;
cleanup:
    wolfSSL_BIO_free(bio);

    return ret;
}
#endif /* !NO_BIO */

WOLFSSL_X509* wolfSSL_X509_REQ_new(void)
{
    return wolfSSL_X509_new();
}

void wolfSSL_X509_REQ_free(WOLFSSL_X509* req)
{
    wolfSSL_X509_free(req);
}

int wolfSSL_X509_REQ_set_version(WOLFSSL_X509 *x, long version)
{
    WOLFSSL_ENTER("wolfSSL_X509_REQ_set_version");
    if ((x == NULL) || (version < 0) || (version >= INT_MAX)) {
        return WOLFSSL_FAILURE;
    }
    x->version = (int)version;
    return WOLFSSL_SUCCESS;
}

long wolfSSL_X509_REQ_get_version(const WOLFSSL_X509 *req)
{
    WOLFSSL_ENTER("wolfSSL_X509_REQ_get_version");
    if (req == NULL) {
        return 0; /* invalid arg */
    }
    return (long)req->version;
}

int wolfSSL_X509_REQ_sign(WOLFSSL_X509 *req, WOLFSSL_EVP_PKEY *pkey,
                          const WOLFSSL_EVP_MD *md)
{
    int ret;
    byte* der = NULL;
    int bufSz;
    int derSz;
    int sigType;

    if (req == NULL || pkey == NULL) {
        WOLFSSL_LEAVE("wolfSSL_X509_REQ_sign", BAD_FUNC_ARG);
        return WOLFSSL_FAILURE;
    }

    bufSz = x509_gen_buf_sz(req, pkey);
    derSz = bufSz;
    der = (byte*)XMALLOC((size_t)bufSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
    if (der == NULL) {
        return WOLFSSL_FAILURE;
    }

    /* Create a Cert that has the certificate request fields.  The (pkey, md)
     * combination is resolved by wolfSSL_sigTypeFromPKEY() - Ed25519 CSRs sign
     * with a NULL digest, ML-DSA ignores the digest, every other key type
     * requires one - and sigOID is only updated on success, so the object is
     * unmodified on a rejected key/md combination. */
    sigType = wolfSSL_sigTypeFromPKEY((WOLFSSL_EVP_MD*)md, pkey);
    if (sigType == WC_NO_ERR_TRACE(WOLFSSL_FAILURE)) {
        WOLFSSL_MSG("Unsupported key/md combination for signing");
        XFREE(der, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        return WOLFSSL_FAILURE;
    }
    req->sigOID = sigType;
    ret = wolfssl_x509_make_der(req, 1, der, &derSz, 0);
    if (ret != WOLFSSL_SUCCESS) {
        XFREE(der, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        WOLFSSL_MSG("Unable to make DER for X509");
        WOLFSSL_LEAVE("wolfSSL_X509_REQ_sign", ret);
        return WOLFSSL_FAILURE;
    }

    if (wolfSSL_X509_resign_cert(req, 1, der, bufSz, derSz,
            (WOLFSSL_EVP_MD*)md, pkey) <= 0) {
        XFREE(der, NULL, DYNAMIC_TYPE_TMP_BUFFER);
        return WOLFSSL_FAILURE;
    }
    XFREE(der, NULL, DYNAMIC_TYPE_TMP_BUFFER);
    return WOLFSSL_SUCCESS;
}

int wolfSSL_X509_REQ_sign_ctx(WOLFSSL_X509 *req,
                              WOLFSSL_EVP_MD_CTX* md_ctx)
{
    if (md_ctx && md_ctx->pctx)
        return wolfSSL_X509_REQ_sign(req, md_ctx->pctx->pkey,
                wolfSSL_EVP_MD_CTX_md(md_ctx));
    else
        return WOLFSSL_FAILURE;
}

static int regenX509REQDerBuffer(WOLFSSL_X509* x509)
{
    int derSz = X509_BUFFER_SZ;
    int ret = WC_NO_ERR_TRACE(WOLFSSL_FAILURE);
#ifndef WOLFSSL_SMALL_STACK
    byte der[X509_BUFFER_SZ];
#else
    byte* der;

    der = (byte*)XMALLOC(derSz, NULL, DYNAMIC_TYPE_TMP_BUFFER);
    if (!der) {
        WOLFSSL_MSG("malloc failed");
        return WOLFSSL_FAILURE;
    }
#endif

    if (wolfssl_x509_make_der(x509, 1, der, &derSz, 0) == WOLFSSL_SUCCESS) {
        FreeDer(&x509->derCert);
        if (AllocDer(&x509->derCert, (word32)derSz, CERT_TYPE,
                                                             x509->heap) == 0) {
            XMEMCPY(x509->derCert->buffer, der, derSz);
            ret = WOLFSSL_SUCCESS;
        }
        else {
            WOLFSSL_MSG("Failed to allocate DER buffer for X509");
        }
    }
    else {
        WOLFSSL_MSG("Unable to make DER for X509 REQ");
    }
    WC_FREE_VAR_EX(der, NULL, DYNAMIC_TYPE_TMP_BUFFER);
    return ret;
}

int wolfSSL_X509_REQ_add_extensions(WOLFSSL_X509* req,
        WOLF_STACK_OF(WOLFSSL_X509_EXTENSION)* ext_sk)
{
    WOLFSSL_X509_EXTENSION* ext = NULL;

    if (!req || !ext_sk) {
        WOLFSSL_MSG("Bad parameter");
        return WOLFSSL_FAILURE;
    }

    /* It is not an error if the stack is empty. */
    ext = ext_sk->data.ext;
    if (ext == NULL) {
        return WOLFSSL_SUCCESS;
    }

    while (ext_sk) {
        ext = ext_sk->data.ext;

        if (wolfSSL_X509_add_ext(req, ext, -1) != WOLFSSL_SUCCESS) {
            WOLFSSL_MSG("wolfSSL_X509_add_ext error");
            return WOLFSSL_FAILURE;
        }

        ext_sk = ext_sk->next;
    }

    return regenX509REQDerBuffer(req);
}

int wolfSSL_X509_REQ_add1_attr_by_txt(WOLFSSL_X509 *req,
                              const char *attrname, int type,
                              const unsigned char *bytes, int len)
{
    WOLFSSL_ENTER("wolfSSL_X509_REQ_add1_attr_by_txt");

#ifdef HAVE_LIBEST
    if (!req || !attrname || !bytes || type != MBSTRING_ASC) {
        WOLFSSL_MSG("Bad parameter");
        return WOLFSSL_FAILURE;
    }

    if (len < 0) {
        len = (int)XSTRLEN((char*)bytes);
    }

    /* For now just pretend that we support this for libest testing */
    if (len == XSTR_SIZEOF("1.3.6.1.1.1.1.22") &&
            XMEMCMP("1.3.6.1.1.1.1.22", bytes, len) == 0) {
        /* MAC Address */
    }
    else if (len == XSTR_SIZEOF("1.2.840.10045.2.1") &&
            XMEMCMP("1.2.840.10045.2.1", bytes, len) == 0) {
        /* ecPublicKey */
    }
    else if (len == XSTR_SIZEOF("1.2.840.10045.4.3.3") &&
            XMEMCMP("1.2.840.10045.4.3.3", bytes, len) == 0) {
        /* ecdsa-with-SHA384 */
    }
    else {
        return WOLFSSL_FAILURE;
    }

    /* return error if not built for libest */
    return WOLFSSL_SUCCESS;
#else
    (void)req;
    (void)attrname;
    (void)type;
    (void)bytes;
    (void)len;
    return WOLFSSL_FAILURE;
#endif
}


static int wolfSSL_X509_ATTRIBUTE_set(WOLFSSL_X509_ATTRIBUTE* attr,
        const char* data, int dataSz, int type, int nid)
{
    if (attr) {
        attr->value->value.asn1_string = wolfSSL_ASN1_STRING_new();
        if (wolfSSL_ASN1_STRING_set(attr->value->value.asn1_string,
                data, dataSz) != WOLFSSL_SUCCESS) {
            wolfSSL_ASN1_STRING_free(attr->value->value.asn1_string);
            WOLFSSL_MSG("wolfSSL_ASN1_STRING_set error");
            return WOLFSSL_FAILURE;
        }
        attr->value->type = type;
        attr->object->nid = nid;
    }
    else {
        WOLFSSL_MSG("wolfSSL_X509_ATTRIBUTE_new error");
        return WOLFSSL_FAILURE;
    }

    return WOLFSSL_SUCCESS;
}


int wolfSSL_X509_REQ_add1_attr_by_NID(WOLFSSL_X509 *req,
                                      int nid, int type,
                                      const unsigned char *bytes,
                                      int len)
{
    int ret;
    WOLFSSL_X509_ATTRIBUTE* attr;

    WOLFSSL_ENTER("wolfSSL_X509_REQ_add1_attr_by_NID");

    if (!req || !bytes || type != WOLFSSL_MBSTRING_ASC) {
        WOLFSSL_MSG("Bad parameter");
        return WOLFSSL_FAILURE;
    }

    switch (nid) {
    case WC_NID_pkcs9_challengePassword:
        if (len < 0)
            len = (int)XSTRLEN((char*)bytes);
        if (len < CTC_NAME_SIZE) {
            XMEMCPY(req->challengePw, bytes, len);
            req->challengePw[len] = '\0';
        }
        else {
            WOLFSSL_MSG("Challenge password too long");
            WOLFSSL_ERROR_VERBOSE(BUFFER_E);
            return WOLFSSL_FAILURE;
        }
        break;
    case WC_NID_serialNumber:
        if (len < 0)
            len = (int)XSTRLEN((char*)bytes);
        if (len + 1 > EXTERNAL_SERIAL_SIZE) {
            WOLFSSL_MSG("SerialNumber too long");
            WOLFSSL_ERROR_VERBOSE(BUFFER_E);
            return WOLFSSL_FAILURE;
        }
        XMEMCPY(req->serial, bytes, len);
        req->serialSz = len;
        break;

    case WC_NID_pkcs9_unstructuredName:
    case WC_NID_pkcs9_contentType:
    case WC_NID_surname:
    case WC_NID_initials:
    case WC_NID_givenName:
    case WC_NID_dnQualifier:
        break;

    default:
        WOLFSSL_MSG("Unsupported attribute");
        return WOLFSSL_FAILURE;
    }

    attr = wolfSSL_X509_ATTRIBUTE_new();
    ret = wolfSSL_X509_ATTRIBUTE_set(attr, (const char*)bytes, len,
            WOLFSSL_V_ASN1_PRINTABLESTRING, nid);
    if (ret != WOLFSSL_SUCCESS) {
        wolfSSL_X509_ATTRIBUTE_free(attr);
    }
    else {
        if (req->reqAttributes == NULL) {
            req->reqAttributes = wolfSSL_sk_new_node(req->heap);
            if (req->reqAttributes != NULL) {
                req->reqAttributes->type = STACK_TYPE_X509_REQ_ATTR;
            }
        }
        if ((req->reqAttributes != NULL) &&
                (req->reqAttributes->type == STACK_TYPE_X509_REQ_ATTR)) {
            /* Using wolfSSL_sk_insert to maintain backwards compatibility with
             * earlier versions of _push API that pushed items to the start of
             * the list instead of the end. */
            ret = wolfSSL_sk_insert(req->reqAttributes, attr, 0) > 0
                    ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
        }
        else {
            ret = WOLFSSL_FAILURE;
        }
        if (ret != WOLFSSL_SUCCESS)
            wolfSSL_X509_ATTRIBUTE_free(attr);
    }

    return ret;
}

WOLFSSL_X509 *wolfSSL_X509_to_X509_REQ(WOLFSSL_X509 *x,
        WOLFSSL_EVP_PKEY *pkey, const WOLFSSL_EVP_MD *md)
{
    WOLFSSL_ENTER("wolfSSL_X509_to_X509_REQ");
    (void)pkey;
    (void)md;
    return wolfSSL_X509_dup(x);
}

int wolfSSL_X509_REQ_set_subject_name(WOLFSSL_X509 *req,
                                      WOLFSSL_X509_NAME *name)
{
    return wolfSSL_X509_set_subject_name(req, name);
}

int wolfSSL_X509_REQ_set_pubkey(WOLFSSL_X509 *req, WOLFSSL_EVP_PKEY *pkey)
{
    return wolfSSL_X509_set_pubkey(req, pkey);
}
#endif /* OPENSSL_ALL && WOLFSSL_CERT_GEN && WOLFSSL_CERT_REQ */

#if (defined(OPENSSL_ALL) || defined(OPENSSL_EXTRA)) && \
    (defined(WOLFSSL_CERT_GEN) || defined(WOLFSSL_CERT_REQ))

WOLFSSL_ASN1_TYPE *wolfSSL_X509_ATTRIBUTE_get0_type(
        WOLFSSL_X509_ATTRIBUTE *attr, int idx)
{
    WOLFSSL_ENTER("wolfSSL_X509_ATTRIBUTE_get0_type");

    if (!attr || idx != 0) {
        WOLFSSL_MSG("Bad parameter");
        return NULL;
    }

    return attr->value;
}


/**
 * @param req X509_REQ containing attribute
 * @return the number of attributes
 */
int wolfSSL_X509_REQ_get_attr_count(const WOLFSSL_X509 *req)
{
    if (req == NULL || req->reqAttributes == NULL)
        return 0;

    return wolfSSL_sk_num(req->reqAttributes);
}


/**
 * @param req X509_REQ containing attribute
 * @param loc NID of the attribute to return
 */
WOLFSSL_X509_ATTRIBUTE *wolfSSL_X509_REQ_get_attr(
        const WOLFSSL_X509 *req, int loc)
{
    WOLFSSL_ENTER("wolfSSL_X509_REQ_get_attr");

    if (!req || req->reqAttributes == NULL) {
        WOLFSSL_MSG("Bad parameter");
        return NULL;
    }

    return (WOLFSSL_X509_ATTRIBUTE*)wolfSSL_sk_value(req->reqAttributes, loc);
}

/* Return NID as the attr index */
int wolfSSL_X509_REQ_get_attr_by_NID(const WOLFSSL_X509 *req,
        int nid, int lastpos)
{
    int idx;

    WOLFSSL_ENTER("wolfSSL_X509_REQ_get_attr_by_NID");

    if (!req) {
        WOLFSSL_MSG("Bad parameter");
        return WOLFSSL_FATAL_ERROR;
    }

    /* search through stack for first matching nid */
    for (idx = lastpos + 1; idx < wolfSSL_sk_num(req->reqAttributes); idx++) {
        WOLFSSL_X509_ATTRIBUTE* attr =
             (WOLFSSL_X509_ATTRIBUTE*)wolfSSL_sk_value(req->reqAttributes, idx);
        if (attr != NULL && attr->object != NULL && attr->object->nid == nid)
            return idx;
    }

    return WOLFSSL_FATAL_ERROR;
}

WOLFSSL_X509_ATTRIBUTE* wolfSSL_X509_ATTRIBUTE_new(void)
{
    WOLFSSL_X509_ATTRIBUTE* ret;
    WOLFSSL_ENTER("wolfSSL_X509_ATTRIBUTE_new");
    ret = (WOLFSSL_X509_ATTRIBUTE*)XMALLOC(sizeof(WOLFSSL_X509_ATTRIBUTE),
            NULL, DYNAMIC_TYPE_OPENSSL);
    if (!ret) {
        WOLFSSL_MSG("malloc error");
        return NULL;
    }
    XMEMSET(ret, 0, sizeof(WOLFSSL_X509_ATTRIBUTE));
    ret->object = wolfSSL_ASN1_OBJECT_new();
    ret->value = wolfSSL_ASN1_TYPE_new();
    /* Don't allocate ret->set since WOLFSSL_ASN1_TYPE
     * is not supported as a stack type */
    if (!ret->object || !ret->value) {
        WOLFSSL_MSG("wolfSSL_ASN1_OBJECT_new or wolfSSL_ASN1_TYPE_new error");
        wolfSSL_X509_ATTRIBUTE_free(ret);
        return NULL;
    }
    return ret;
}

void wolfSSL_X509_ATTRIBUTE_free(WOLFSSL_X509_ATTRIBUTE* attr)
{
    WOLFSSL_ENTER("wolfSSL_X509_ATTRIBUTE_free");
    if (attr) {
        if (attr->object) {
            wolfSSL_ASN1_OBJECT_free(attr->object);
        }
        if (attr->value) {
            wolfSSL_ASN1_TYPE_free(attr->value);
        }
        if (attr->set) {
            wolfSSL_sk_pop_free(attr->set, NULL);
        }
        XFREE(attr, NULL, DYNAMIC_TYPE_OPENSSL);
    }
}
#endif /* (OPENSSL_ALL || OPENSSL_EXTRA) &&
          (WOLFSSL_CERT_GEN || WOLFSSL_CERT_REQ) */

#if defined(WOLFSSL_ACERT) && \
   (defined(OPENSSL_EXTRA_X509_SMALL) || defined(OPENSSL_EXTRA))

/* Allocate and return a new WOLFSSL_X509_ACERT struct pointer.
 *
 * @param [in]      heap        heap hint
 *
 * @return  pointer  on success
 * @return  NULL     on error
 * */
WOLFSSL_X509_ACERT * wolfSSL_X509_ACERT_new_ex(void* heap)
{
    WOLFSSL_X509_ACERT * x509 = NULL;

    WOLFSSL_ENTER("wolfSSL_X509_ACERT_new");

    x509 = (WOLFSSL_X509_ACERT*) XMALLOC(sizeof(WOLFSSL_X509_ACERT), heap,
                                         DYNAMIC_TYPE_X509_ACERT);

    if (x509 != NULL) {
        wolfSSL_X509_ACERT_init(x509, 1, heap);
    }

    return x509;
}

WOLFSSL_X509_ACERT * wolfSSL_X509_ACERT_new(void)
{
    return wolfSSL_X509_ACERT_new_ex(NULL);
}

/* Initialize a WOLFSSL_X509_ACERT struct.
 *
 * If dynamic == 1, then the x509 pointer will be freed
 * in wolfSSL_X509_ACERT_free.
 *
 * @param [in]      x509        x509 acert pointer
 * @param [in]      dynamic     dynamic mem flag
 * @param [in]      heap        heap hint
 *
 * @return  void
 * */
void wolfSSL_X509_ACERT_init(WOLFSSL_X509_ACERT * x509, int dynamic, void* heap)
{
    WOLFSSL_ENTER("wolfSSL_X509_ACERT_init");

    if (x509 == NULL) {
        WOLFSSL_MSG("error: InitX509Acert: null parameter");
        return;
    }

    XMEMSET(x509, 0, sizeof(*x509));

    x509->heap = heap;
    x509->dynamic = dynamic;
}

/* Free a WOLFSSL_X509_ACERT struct and its sub-fields.
 *
 * If this ACERT was initialized with dynamic == 1, then
 * the x509 pointer itself will be freed as well.
 *
 * @param [in]      x509        x509 acert pointer
 *
 * @return  void
 * */
void wolfSSL_X509_ACERT_free(WOLFSSL_X509_ACERT * x509)
{
    int    dynamic = 0;
    void * heap = NULL;

    WOLFSSL_ENTER("wolfSSL_X509_ACERT_free");

    if (x509 == NULL) {
        WOLFSSL_MSG("error: wolfSSL_X509_ACERT_free: null parameter");
        return;
    }

    dynamic = x509->dynamic;
    heap = x509->heap;

    /* Free holder and att cert issuer structures. */
    if (x509->holderIssuerName) {
        FreeAltNames(x509->holderIssuerName, heap);
        x509->holderIssuerName = NULL;
    }

    if (x509->holderEntityName) {
        FreeAltNames(x509->holderEntityName, heap);
        x509->holderEntityName = NULL;
    }

    if (x509->AttCertIssuerName) {
        FreeAltNames(x509->AttCertIssuerName, heap);
        x509->AttCertIssuerName = NULL;
    }

    if (x509->rawAttr != NULL) {
        XFREE(x509->rawAttr, heap, DYNAMIC_TYPE_X509_EXT);
        x509->rawAttr = NULL;
        x509->rawAttrLen = 0;
    }

    /* Free derCert source and signature buffer. */
    FreeDer(&x509->derCert);

    if (x509->sig.buffer != NULL) {
        XFREE(x509->sig.buffer, heap, DYNAMIC_TYPE_SIGNATURE);
        x509->sig.buffer = NULL;
    }

    /* Finally memset and free x509 acert structure. */
    XMEMSET(x509, 0, sizeof(*x509));

    if (dynamic == 1) {
        XFREE(x509, heap, DYNAMIC_TYPE_X509_ACERT);
    }

    return;
}

#if defined(OPENSSL_EXTRA)
long wolfSSL_X509_ACERT_get_version(const WOLFSSL_X509_ACERT* x509)
{
    int version = 0;

    if (x509 == NULL) {
        return 0L;
    }

    version = x509->version;

    return version != 0 ? (long)version - 1L : 0L;
}
#endif /* OPENSSL_EXTRA */

int wolfSSL_X509_ACERT_version(WOLFSSL_X509_ACERT* x509)
{
    if (x509 == NULL) {
        return 0;
    }

    return x509->version;
}

/* Retrieve the serial number from an ACERT.
 *
 * @param [in]       x509    the x509 attribute certificate
 * @param [in, out]  buf     the serial number buffer pointer
 * @param [in, out]  bufSz   the serial number buffer size pointer
 *
 * buf may be null, but bufSz is required. On success, sets
 * bufSz pointer to signature length, and copies signature
 * to buf if provided.
 *
 * Returns  WWOLFSSL_FATAL_ERROR if bufSz is null or too small.
 * Returns  WOLFSSL_SUCCESS on success.
 */
int wolfSSL_X509_ACERT_get_serial_number(WOLFSSL_X509_ACERT* x509,
                                         byte* buf, int* bufSz)
{
    WOLFSSL_ENTER("wolfSSL_X509_ACERT_get_serial_number");

    if (x509 == NULL || bufSz == NULL) {
        WOLFSSL_MSG("error: null argument passed in");
        return BAD_FUNC_ARG;
    }

    if (buf != NULL) {
        if (*bufSz < x509->serialSz) {
            WOLFSSL_MSG("error: serial buffer too small");
            return BUFFER_E;
        }

        XMEMCPY(buf, x509->serial, x509->serialSz);
    }

    *bufSz = x509->serialSz;

    return WOLFSSL_SUCCESS;
}

/* Sets buf pointer and len to raw Attribute buffer and buffer len
 * in X509 struct.
 *
 * Returns WOLFSSL_SUCCESS on success.
 * Returns BAD_FUNC_ARG if input pointers are null.
 * */
int wolfSSL_X509_ACERT_get_attr_buf(const WOLFSSL_X509_ACERT* x509,
                                                const byte ** rawAttr,
                                                word32 * rawAttrLen)
{
    if (x509 == NULL || rawAttr == NULL || rawAttrLen == NULL) {
        return BAD_FUNC_ARG;
    }

    *rawAttr = x509->rawAttr;
    *rawAttrLen = x509->rawAttrLen;

    return WOLFSSL_SUCCESS;
}

#ifndef NO_WOLFSSL_STUB
int wolfSSL_X509_ACERT_sign(WOLFSSL_X509_ACERT * x509,
                                        WOLFSSL_EVP_PKEY * pkey,
                                        const WOLFSSL_EVP_MD * md)
{
    WOLFSSL_STUB("X509_ACERT_sign");
    (void) x509;
    (void) pkey;
    (void) md;
    return WOLFSSL_NOT_IMPLEMENTED;
}
#endif /* NO_WOLFSSL_STUB */

/* Helper function for ACERT_verify.
 *
 * @param [in]       x509    the x509 attribute certificate
 * @param [in, out]  outSz   the x509 der length
 *
 * @return  der buffer on success
 * @return  NULL on error
 * */
static const byte* acert_get_der(WOLFSSL_X509_ACERT * x509, int* outSz)
{
    if (x509 == NULL || x509->derCert == NULL || outSz == NULL) {
        return NULL;
    }

    *outSz = (int)x509->derCert->length;
    return x509->derCert->buffer;
}

/* Given an X509_ACERT and EVP_PKEY, verify the acert's signature.
 *
 * @param [in]    x509    the x509 attribute certificate
 * @param [in]    pkey    the evp_pkey
 *
 * @return  WOLFSSL_SUCCESS on verify success
 * @return  < 0 on error
 * */
int wolfSSL_X509_ACERT_verify(WOLFSSL_X509_ACERT* x509, WOLFSSL_EVP_PKEY* pkey)
{
    int          ret = 0;
    const byte * der = NULL;
    int          derSz = 0;
    int          pkey_type;

    if (x509 == NULL || pkey == NULL) {
        WOLFSSL_MSG("error: wolfSSL_X509_ACERT_verify: bad arg");
        return WOLFSSL_FATAL_ERROR;
    }

    WOLFSSL_ENTER("wolfSSL_X509_ACERT_verify");

    der = acert_get_der(x509, &derSz);

    if (der == NULL || derSz <= 0) {
        WOLFSSL_MSG("error: wolfSSL_X509_ACERT_verify: get der failed");
        return WOLFSSL_FATAL_ERROR;
    }

    switch (pkey->type) {
    case WC_EVP_PKEY_RSA:
        pkey_type = RSAk;
        break;

    case WC_EVP_PKEY_EC:
        pkey_type = ECDSAk;
        break;

    case WC_EVP_PKEY_DSA:
        pkey_type = DSAk;
        break;

    default:
        WOLFSSL_MSG("error: wolfSSL_X509_ACERT_verify: unknown pkey type");
        return WOLFSSL_FATAL_ERROR;
    }


    ret = VerifyX509Acert(der, (word32)derSz,
                          (const byte *)pkey->pkey.ptr, pkey->pkey_sz,
                          pkey_type, x509->heap);

    return ret == 0 ? WOLFSSL_SUCCESS : WOLFSSL_FAILURE;
}

/* Loads an x509 attribute certificate from buffer, and returns
 * pointer to new WOLFSSL_X509_ACERT struct on success.
 *
 * @param [in]  buf    The acert buffer to load.
 * @param [in]  sz     The size of the buffer.
 * @param [in]  format The format of the buffer data.
 * @param [in]  heap   Dynamic memory allocation hint.
 *
 * @return  pointer to WOLFSSL_X509_ACERT on success.
 * @return  NULL on error.
 * */
WOLFSSL_X509_ACERT * wolfSSL_X509_ACERT_load_certificate_buffer_ex(
    const unsigned char* buf, int sz, int format, void * heap)
{
    int                  ret = 0;
    WOLFSSL_X509_ACERT * x509 = NULL;
    DerBuffer *          der = NULL;
    WC_DECLARE_VAR(acert, DecodedAcert, 1, 0);

    WOLFSSL_ENTER("wolfSSL_X509_ACERT_load_certificate_buffer");

    if (format == WOLFSSL_FILETYPE_PEM) {
    #ifdef WOLFSSL_PEM_TO_DER
        ret = PemToDer(buf, sz, ACERT_TYPE, &der, heap, NULL, NULL);

        if (ret != 0 || der == NULL || der->buffer == NULL) {
            WOLFSSL_ERROR(ret);

            if (der != NULL) {
                FreeDer(&der);
            }

            return NULL;
        }
    #else
        WOLFSSL_ERROR(NOT_COMPILED_IN);
        return NULL;
    #endif
    }
    else {
        ret = AllocDer(&der, (word32)sz, ACERT_TYPE, heap);

        if (ret != 0 || der == NULL || der->buffer == NULL) {
            WOLFSSL_ERROR(ret);
            return NULL;
        }

        XMEMCPY(der->buffer, buf, sz);
    }

    #ifdef WOLFSSL_SMALL_STACK
    acert = (DecodedAcert*)XMALLOC(sizeof(DecodedAcert), heap,
                                   DYNAMIC_TYPE_DCERT);
    if (acert == NULL) {
        WOLFSSL_ERROR(MEMORY_ERROR);
        FreeDer(&der);
        return NULL;
    }
    #endif

    InitDecodedAcert(acert, der->buffer, der->length, heap);

    ret = ParseX509Acert(acert, VERIFY_SKIP_DATE);

    if (ret == 0) {
        x509 = wolfSSL_X509_ACERT_new_ex(heap);

        if (x509 != NULL) {
            ret = CopyDecodedAcertToX509(x509, acert);

            if (ret != 0) {
                wolfSSL_X509_ACERT_free(x509);
                x509 = NULL;
            }
        }
        else {
            ret = MEMORY_ERROR;
        }
    }

    FreeDecodedAcert(acert);

    WC_FREE_VAR_EX(acert, heap, DYNAMIC_TYPE_DCERT);

    FreeDer(&der);

    if (ret != 0) {
        WOLFSSL_ERROR(ret);
    }

    return x509;
}

WOLFSSL_X509_ACERT * wolfSSL_X509_ACERT_load_certificate_buffer(
    const unsigned char* buf, int sz, int format)
{
    return wolfSSL_X509_ACERT_load_certificate_buffer_ex(buf, sz, format, NULL);
}

/* Retrieve the signature from an ACERT.
 *
 * @param [in]       x509    the x509 attribute certificate
 * @param [in, out]  buf     the signature buffer pointer
 * @param [in, out]  bufSz   the signature buffer size pointer
 *
 * buf may be null, but bufSz is required. On success, sets
 * bufSz pointer to signature length, and copies signature
 * to buf if provided.
 *
 * Returns  WWOLFSSL_FATAL_ERROR if bufSz is null or too small.
 * Returns  WOLFSSL_SUCCESS on success.
 */
int wolfSSL_X509_ACERT_get_signature(WOLFSSL_X509_ACERT* x509,
                                     unsigned char* buf, int* bufSz)
{
    WOLFSSL_ENTER("wolfSSL_X509_ACERT_get_signature");

    if (x509 == NULL || bufSz == NULL) {
        return WOLFSSL_FATAL_ERROR;
    }

    /* If buf array is provided, it must be long enough. */
    if (buf != NULL && *bufSz < (int)x509->sig.length) {
        return WOLFSSL_FATAL_ERROR;
    }

    if (buf != NULL) {
        /* Copy in buffer if provided. */
        XMEMCPY(buf, x509->sig.buffer, x509->sig.length);
    }

    *bufSz = (int)x509->sig.length;

    return WOLFSSL_SUCCESS;
}
#endif /* WOLFSSL_ACERT && (OPENSSL_EXTRA_X509_SMALL || OPENSSL_EXTRA) */

#endif /* !NO_CERTS */

#endif /* !WOLFCRYPT_ONLY */

#endif /* WOLFSSL_X509_INCLUDED */

Coverage Report

Created: 2026-09-20 06:33